Re: [FFmpeg-devel] [PATCH 6/7] avformat/lxfdec: Fix multiple integer overflows related to track_size

2021-01-15 Thread Tomas Härdin
tor 2021-01-14 klockan 23:51 +0100 skrev Michael Niedermayer: > Fixes: signed integer overflow: 538976288 * 8 cannot be represented in type > 'int' > Fixes: > 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_LXF_fuzzer-6634030636335104 > > Found-by: continuous fuzzing process > https://github.co

[FFmpeg-devel] [PATCH V2 3/3] dnn/openvino: support model input resize

2021-01-15 Thread Ting Fu
OpenVINO APIs require specify input size to run the model, while some OpenVINO model does accept different input size. To enable this feature adding input_resizable option here for easier use. Setting bool variable input_resizable to specify if the input can be resizable or not. input_resizable =

[FFmpeg-devel] [PATCH V2 1/3] dnn/openvino: remove unnecessary code

2021-01-15 Thread Ting Fu
Signed-off-by: Ting Fu --- libavfilter/dnn/dnn_backend_openvino.c | 8 1 file changed, 8 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index 5271d1caa5..8476f4fb38 100644 --- a/libavfilter/dnn/dnn_backend_openvino.c +++ b/liba

[FFmpeg-devel] [PATCH V2 2/3] dnn/openvino: refine code for better model initialization

2021-01-15 Thread Ting Fu
Move openvino model/inference request creation and initialization steps from ff_dnn_load_model_ov to new function init_model_ov, for later input resize support. Signed-off-by: Ting Fu --- libavfilter/dnn/dnn_backend_openvino.c | 196 ++--- 1 file changed, 111 insertions(+), 8

Re: [FFmpeg-devel] [PATCH v4 3/3] avformat/mxfenc: prefer to use the configured metadta

2021-01-15 Thread Tomas Härdin
lör 2021-01-09 klockan 13:07 +0800 skrev lance.lmw...@gmail.com: > From: Limin Wang > > The metadata company_name, product_name, product_version from input > file will be deleted to avoid overwriting information > Please to test with below command: > ./ffmpeg -i ../fate-suite/mxf/Sony-1.mxf -

[FFmpeg-devel] [PATCH] avfilter: Added siti filter

2021-01-15 Thread Boris Baracaldo
Calculate Spatial Info (SI) and Temporal Info (TI) scores for a video, as defined in ITU-T P.910: Subjective video quality assessment methods for multimedia applications. --- Changelog| 1 + doc/filters.texi | 25 libavfilter/Makefile | 1 + libavfilter/allf

Re: [FFmpeg-devel] [PATCH V2] libavfilter/dnn: add batch mode for async execution

2021-01-15 Thread Guo, Yejun
> -Original Message- > From: Steven Liu > Sent: 2021年1月15日 11:34 > To: FFmpeg development discussions and patches > Cc: Steven Liu ; Guo, Yejun > Subject: Re: [FFmpeg-devel] [PATCH V2] libavfilter/dnn: add batch mode for > async execution > > > > > 2021年1月10日 下午9:16,Guo, Yejun 写道:

[FFmpeg-devel] [PATCH] avformat/hls: change sequence number type to int64_t

2021-01-15 Thread Zhao Zhili
Fix atoi() overflow for large EXT-X-MEDIA-SEQUENCE. The spec says the type of sequence number is uint64_t. Use int64_t here since current implementation requires it to be signed integer, and hlsenc use int64_t too. --- libavformat/hls.c | 49 --- 1 file

Re: [FFmpeg-devel] [PATCH] avformat/hls: change sequence number type to int64_t

2021-01-15 Thread Nicolas George
Zhao Zhili (12021-01-15): > -AV_WB32(seg->iv + 12, seq); > +AV_WB32(seg->iv + 8, seq); AV_WB64? Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@

Re: [FFmpeg-devel] [PATCH 2/3] avformat/dashdec: fix code style in is_common_init_section_exist

2021-01-15 Thread Moritz Barsnick
On Tue, Jan 12, 2021 at 21:20:03 +0800, liuqi05 wrote: > -if (av_strcasecmp(pls[i]->init_section->url, url) || > pls[i]->init_section->url_offset != url_offset || pls[i]->init_section->size > != size) { > +if (av_strcasecmp(pls[i]->init_section->url, url) || > +

Re: [FFmpeg-devel] [PATCH 2/3] avformat/dashdec: fix code style in is_common_init_section_exist

2021-01-15 Thread Steven Liu
> 2021年1月15日 下午8:02,Moritz Barsnick 写道: > > On Tue, Jan 12, 2021 at 21:20:03 +0800, liuqi05 wrote: >> -if (av_strcasecmp(pls[i]->init_section->url, url) || >> pls[i]->init_section->url_offset != url_offset || pls[i]->init_section->size >> != size) { >> +if (av_strcasecmp(pls[i

[FFmpeg-devel] [PATCH v2] avformat/hls: change sequence number type to int64_t

2021-01-15 Thread Zhao Zhili
Fix atoi() overflow for large EXT-X-MEDIA-SEQUENCE. The spec says the type of sequence number is uint64_t. Use int64_t here since current implementation requires it to be signed integer, and hlsenc use int64_t too. --- v2: AV_WB32 -> AV_WB64 libavformat/hls.c | 49 ---

Re: [FFmpeg-devel] [PATCH] avformat/hls: change sequence number type to int64_t

2021-01-15 Thread zhilizhao(赵志立)
> On Jan 15, 2021, at 7:43 PM, Nicolas George wrote: > > Zhao Zhili (12021-01-15): >> -AV_WB32(seg->iv + 12, seq); >> +AV_WB32(seg->iv + 8, seq); > > AV_WB64? Good catch, thanks! Version two: http://ffmpeg.org/pipermail/ffmpeg-devel/2021-January/274693

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Remove dts delay from duration.

2021-01-15 Thread Martin Storsjö
Hi Josh, On Tue, 22 Dec 2020, Josh Allmann wrote: Thank you for taking the time to look into this! Tested with your alternative patch and it does seem to be an improvement. I was able to find a case where it didn't seem to do the correct thing (described below), but this is not a regression; ma

Re: [FFmpeg-devel] [PATCH 5/5] avformat/hlsenc: use AV_OPT_TYPE_DURATION

2021-01-15 Thread Moritz Barsnick
On Wed, Jan 06, 2021 at 23:35:31 +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/muxers.texi | 4 ++-- > libavformat/hlsenc.c | 18 +- > 2 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/doc/muxers.texi b/d

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: Fix WebVTT decoder truncating files at first STYLE block

2021-01-15 Thread Moritz Barsnick
On Tue, Jan 12, 2021 at 17:40:06 +, Dave Evans wrote: > Hijacking with related, similar patch from a few months ago: > https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=2538 ... which even includes a fate test, which is what I was about to request from the newly submitted patch. Cheers

[FFmpeg-devel] [PATCH] avformat/hlsenc: EXT-X-I-FRAMES-ONLY requires version 4 or higher

2021-01-15 Thread Zhao Zhili
--- libavformat/hlsenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index cafe0e8c69..d376fc6f08 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -1564,6 +1564,10 @@ static int hls_window(AVFormatContext *s, int last, Variant

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: EXT-X-I-FRAMES-ONLY requires version 4 or higher

2021-01-15 Thread Zhao Zhili
> On Jan 16, 2021, at 12:47 AM, Zhao Zhili wrote: > > --- > libavformat/hlsenc.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index cafe0e8c69..d376fc6f08 100644 > --- a/libavformat/hlsenc.c > +++ b/libavformat/hlsenc.c > @@ -1564,6

Re: [FFmpeg-devel] [PATCH] avfilter: add estdif video filter

2021-01-15 Thread Paul B Mahol
Will apply soon! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/hls: change sequence number type to int64_t

2021-01-15 Thread Chad Fraleigh
On 1/15/2021 3:41 AM, Zhao Zhili wrote: Fix atoi() overflow for large EXT-X-MEDIA-SEQUENCE. The spec says the type of sequence number is uint64_t. Use int64_t here since current implementation requires it to be signed integer, and hlsenc use int64_t too. --- libavformat/hls.c | 49 +++

Re: [FFmpeg-devel] [PATCH 3/7] avutil/parseutils: Check sign in av_parse_time()

2021-01-15 Thread Marton Balint
On Thu, 14 Jan 2021, Michael Niedermayer wrote: Fixes: signed integer overflow: -9223372053736 * 100 cannot be represented in type 'long' Fixes: 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_CONCAT_fuzzer-6607924558430208 Found-by: continuous fuzzing process https://github.com/google

Re: [FFmpeg-devel] [PATCH v4 3/3] avformat/mxfenc: prefer to use the configured metadta

2021-01-15 Thread Marton Balint
On Fri, 15 Jan 2021, Tomas Härdin wrote: lör 2021-01-09 klockan 13:07 +0800 skrev lance.lmw...@gmail.com: From: Limin Wang The metadata company_name, product_name, product_version from input file will be deleted to avoid overwriting information Please to test with below command: ./ffmpeg -i

Re: [FFmpeg-devel] [PATCH] libswscale/aarch64/hscale.S: Support more bit-depth variants.

2021-01-15 Thread Martin Storsjö
On Mon, 11 Jan 2021, reimar.doeffin...@gmx.de wrote: From: Reimar Döffinger Trivially expand hscale assembler to support > 8 bit formats both for input and output. 16-bit input is not supported as I am not certain how to get sufficient test coverage. --- libswscale/aarch64/hscale.S | 53 +

Re: [FFmpeg-devel] [PATCH] libswscale/aarch64/hscale.S: Support more bit-depth variants.

2021-01-15 Thread Reimar Döffinger
> On 15 Jan 2021, at 22:10, Martin Storsjö wrote: > > On Mon, 11 Jan 2021, reimar.doeffin...@gmx.de wrote: > >> From: Reimar Döffinger >> >> Trivially expand hscale assembler to support > 8 bit formats >> both for input and output. >> 16-bit input is not supported as I am not certain how to

[FFmpeg-devel] [PATCH] configure: Set MSVC as_default later.

2021-01-15 Thread Reimar . Doeffinger
From: Reimar Döffinger It would get immediately overridden to $cc, which in case of gas-preprocessor missing would result in it trying to use cl.exe for asm files instead of erroring out. This is because cl.exe does not fail but just print a warning when it is given a file it does not know what t

Re: [FFmpeg-devel] [PATCH] configure: Set MSVC as_default later.

2021-01-15 Thread Martin Storsjö
On Fri, 15 Jan 2021, reimar.doeffin...@gmx.de wrote: From: Reimar Döffinger It would get immediately overridden to $cc, which in case of gas-preprocessor missing would result in it trying to use cl.exe for asm files instead of erroring out. This is because cl.exe does not fail but just print a

Re: [FFmpeg-devel] [PATCH] libavcodec/hevcdsp: port SIMD idct functions from 32-bit.

2021-01-15 Thread Martin Storsjö
On Tue, 12 Jan 2021, reimar.doeffin...@gmx.de wrote: From: Reimar Döffinger Makes SIMD-optimized 8x8 and 16x16 idcts for 8 and 10 bit depth available on aarch64. For a UHD HDR (10 bit) sample video these were consuming the most time and this optimization reduced overall decode time from 19.4s

Re: [FFmpeg-devel] [PATCH] libavcodec/aarch64/hevcdsp_idct_neon.S: Also port add_residual functions.

2021-01-15 Thread Martin Storsjö
On Sun, 10 Jan 2021, reimar.doeffin...@gmx.de wrote: From: Reimar Döffinger Speedup is fairly small, around 1.5%, but these are fairly simple. --- libavcodec/aarch64/hevcdsp_idct_neon.S| 190 ++ libavcodec/aarch64/hevcdsp_init_aarch64.c | 24 +++ 2 files changed, 214 ins

Re: [FFmpeg-devel] [PATCH 3/7] avutil/parseutils: Check sign in av_parse_time()

2021-01-15 Thread Michael Niedermayer
On Fri, Jan 15, 2021 at 09:36:26PM +0100, Marton Balint wrote: > > > On Thu, 14 Jan 2021, Michael Niedermayer wrote: > > > Fixes: signed integer overflow: -9223372053736 * 100 cannot be > > represented in type 'long' > > Fixes: > > 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_CONCAT_fuz

Re: [FFmpeg-devel] [PATCH 6/7] avformat/lxfdec: Fix multiple integer overflows related to track_size

2021-01-15 Thread Michael Niedermayer
On Fri, Jan 15, 2021 at 09:48:38AM +0100, Tomas Härdin wrote: > tor 2021-01-14 klockan 23:51 +0100 skrev Michael Niedermayer: > > Fixes: signed integer overflow: 538976288 * 8 cannot be represented in type > > 'int' > > Fixes: > > 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_LXF_fuzzer-6634030

[FFmpeg-devel] [PATCH] avutil/parseutils: Check sign in av_parse_time()

2021-01-15 Thread Michael Niedermayer
Fixes: signed integer overflow: -9223372053736 * 100 cannot be represented in type 'long' Fixes: 26910/clusterfuzz-testcase-minimized-ffmpeg_dem_CONCAT_fuzzer-6607924558430208 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

Re: [FFmpeg-devel] [PATCH] avformat/async: Use the correct return values

2021-01-15 Thread Michael Niedermayer
On Thu, Jan 14, 2021 at 11:29:18PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/async.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavformat/async.c b/libavformat/async.c > index a0bdfa2..801b20e 100644 > --- a/li

Re: [FFmpeg-devel] [PATCH] configure: Set MSVC as_default later.

2021-01-15 Thread Reimar Döffinger
> On 15 Jan 2021, at 23:25, Martin Storsjö wrote: > > On Fri, 15 Jan 2021, reimar.doeffin...@gmx.de wrote: > >> From: Reimar Döffinger >> >> It would get immediately overridden to $cc, which in case >> of gas-preprocessor missing would result in it trying >> to use cl.exe for asm files inste

Re: [FFmpeg-devel] [PATCH] avformat/async: Use the correct return values

2021-01-15 Thread lance . lmwang
On Sat, Jan 16, 2021 at 12:30:04AM +0100, Michael Niedermayer wrote: > On Thu, Jan 14, 2021 at 11:29:18PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/async.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git

Re: [FFmpeg-devel] [PATCH v4 3/3] avformat/mxfenc: prefer to use the configured metadta

2021-01-15 Thread lance . lmwang
On Fri, Jan 15, 2021 at 09:43:58PM +0100, Marton Balint wrote: > > > On Fri, 15 Jan 2021, Tomas Härdin wrote: > > > lör 2021-01-09 klockan 13:07 +0800 skrev lance.lmw...@gmail.com: > > > From: Limin Wang > > > > > > The metadata company_name, product_name, product_version from input > > > file

Re: [FFmpeg-devel] [PATCH 5/5] avformat/hlsenc: use AV_OPT_TYPE_DURATION

2021-01-15 Thread lance . lmwang
On Fri, Jan 15, 2021 at 02:27:44PM +0100, Moritz Barsnick wrote: > On Wed, Jan 06, 2021 at 23:35:31 +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > doc/muxers.texi | 4 ++-- > > libavformat/hlsenc.c | 18 +- > > 2 file

[FFmpeg-devel] [PATCH] libavcodec/hevcdsp: port SIMD idct functions from 32-bit.

2021-01-15 Thread Reimar . Doeffinger
From: Reimar Döffinger Makes SIMD-optimized 8x8 and 16x16 idcts for 8 and 10 bit depth available on aarch64. For a UHD HDR (10 bit) sample video these were consuming the most time and this optimization reduced overall decode time from 19.4s to 16.4s, approximately 15% speedup. Test sample was the

Re: [FFmpeg-devel] [PATCH] libavcodec/hevcdsp: port SIMD idct functions from 32-bit.

2021-01-15 Thread Reimar Döffinger
> On 15 Jan 2021, at 23:55, Martin Storsjö wrote: > > On Tue, 12 Jan 2021, reimar.doeffin...@gmx.de wrote: > >> create mode 100644 libavcodec/aarch64/hevcdsp_idct_neon.S >> create mode 100644 libavcodec/aarch64/hevcdsp_init_aarch64.c > > This patch fails checkasm Fixed, one mis-translated co

[FFmpeg-devel] [PATCH v2] avformat/async: Use AVERROR macro

2021-01-15 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/async.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/async.c b/libavformat/async.c index a0bdfa2..cc11ec4 100644 --- a/libavformat/async.c +++ b/libavformat/async.c @@ -262,24 +262,28 @@ static int async_open(URLC

[FFmpeg-devel] [PATCH v3] avformat/hls: change sequence number type to int64_t

2021-01-15 Thread Zhao Zhili
Fix atoi() overflow for large EXT-X-MEDIA-SEQUENCE. The spec says the type of sequence number is uint64_t. Use int64_t here since current implementation requires it to be signed integer, and hlsenc use int64_t too. --- v3: handle MEDIA-SEQUENCE higher than INT64_MAX v2: AV_WB32 -> AV_WB64 libav

[FFmpeg-devel] [PATCH] avcodec/bsf: set pctx to NULL when av_bsf_alloc failed

2021-01-15 Thread Steven Liu
av_bsf_free will free invalid pointer when av_bsf_alloc failed. because av_bsf_list_parse_str called av_bsf_get_null_filter, av_bsf_get_null_filter called av_bsf_alloc, and av_bsf_alloc should set a value to the *pctx before return success or failed, because it dose not initial a null pointer ever,

Re: [FFmpeg-devel] [PATCH v4 1/2] lavf/qsv: Add functions to print mfx iopattern, warning and error

2021-01-15 Thread Linjie Fu
Haihao: On Tue, Jan 5, 2021 at 3:03 PM Haihao Xiang wrote: > > It is a copy of the relevant part in lavc/qsv but use different function > names to avoid multiple definition when linking lavc and lavf statically. > > Signed-off-by: Haihao Xiang > --- > v4: rename the new functions to avoid multip

Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/qsvdec: refact, remove duplicate code for plugin loading

2021-01-15 Thread Linjie Fu
Guangxin: On Tue, Jan 5, 2021 at 10:44 AM Xu Guangxin wrote: > > --- > libavcodec/qsvdec.c | 29 +++-- > 1 file changed, 11 insertions(+), 18 deletions(-) > > diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c > index 3ca16dafae..d10f90a0db 100644 > --- a/libavcodec/q

Re: [FFmpeg-devel] [PATCH v3 0/8] HEVC native support for Screen content coding

2021-01-15 Thread Linjie Fu
On Mon, Dec 7, 2020 at 8:56 PM Linjie Fu wrote: > > Add parsing support and reference management for HEVC SCC, as part of > the fully decoding support for hardware(vaapi). > > v3: > - addressed the hang issue in multi-threads > - prompted more logs to prompt scc is not fully supported > - PPS o