Re: [FFmpeg-devel] [PATCH v2 01/11] avcodec/vvc: add shared header for vvc

2021-01-10 Thread Nuo Mi
How about we define it as 20, check the size and return error if > 20. 20 should enough for most of clips. hevc used 20. On Sun, Jan 10, 2021 at 9:39 AM Nuo Mi wrote: > > > On Sun, Jan 10, 2021 at 3:09 AM Mark Thompson wrote: > >> On 09/01/2021 07:34, Nuo Mi wrote: >> > --- >> > libavcodec/v

[FFmpeg-devel] [PATCH v2] avformat/utils: prevent ts out of [min_ts, max_ts] interval due to rouding

2021-01-10 Thread Zhao Zhili
Rounding min_ts towards +infinity and max_ts towards -infinity can make ts out of the [min_ts, max_ts] interval, and then leads to seek failure. Fix it by using the simple rounding as ts for both min_ts and max_ts. --- libavformat/utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [FFmpeg-devel] [PATCH v2 06/11] avcodec: add cbs for h266/vvc

2021-01-10 Thread Nuo Mi
On Sun, Jan 10, 2021 at 5:34 AM Mark Thompson wrote: > On 09/01/2021 07:34, Nuo Mi wrote: > > --- > > configure |2 + > > libavcodec/Makefile |1 + > > libavcodec/cbs.c |6 + > > libavcodec/cbs_h2645.c

[FFmpeg-devel] [PATCH] libavcodec/aarch64/hevcdsp_idct_neon.S: Also port add_residual functions.

2021-01-10 Thread Reimar . Doeffinger
From: Reimar Döffinger Speedup is fairly small, around 1.5%, but these are fairly simple. --- libavcodec/aarch64/hevcdsp_idct_neon.S| 190 ++ libavcodec/aarch64/hevcdsp_init_aarch64.c | 24 +++ 2 files changed, 214 insertions(+) diff --git a/libavcodec/aarch64/hevcdsp_i

[FFmpeg-devel] [PATCH] libavcodec/aarch64/hevcdsp_idct_neon.S: Also port add_residual functions.

2021-01-10 Thread Reimar . Doeffinger
From: Reimar Döffinger Speedup is fairly small, around 1.5%, but these are fairly simple. --- libavcodec/aarch64/hevcdsp_idct_neon.S| 190 ++ libavcodec/aarch64/hevcdsp_init_aarch64.c | 24 +++ 2 files changed, 214 insertions(+) diff --git a/libavcodec/aarch64/hevcdsp_i

Re: [FFmpeg-devel] [PATCH] libavfilter/dnn: add batch mode for async execution

2021-01-10 Thread Guo, Yejun
> -Original Message- > From: Guo, Yejun > Sent: 2021年1月8日 16:37 > To: ffmpeg-devel@ffmpeg.org > Cc: Guo, Yejun > Subject: [PATCH] libavfilter/dnn: add batch mode for async execution > > the default number of batch_size is 1 > > Signed-off-by: Xie, Lin > Signed-off-by: Wu Zhiwen > Si

[FFmpeg-devel] [PATCH V2] libavfilter/dnn: add batch mode for async execution

2021-01-10 Thread Guo, Yejun
the default number of batch_size is 1 Signed-off-by: Xie, Lin Signed-off-by: Wu Zhiwen Signed-off-by: Guo, Yejun --- libavfilter/dnn/dnn_backend_openvino.c | 187 - libavfilter/dnn/dnn_backend_openvino.h | 1 + libavfilter/dnn/dnn_interface.c| 1 + libavfilt

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/fft_template: Remove unused fixed-point cosine tables

2021-01-10 Thread Michael Niedermayer
On Sun, Jan 10, 2021 at 01:56:21AM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Thu, Jan 07, 2021 at 12:13:05AM +0100, Andreas Rheinhardt wrote: > >> There are three types of FFTs: floating-point, 32-bit fixed-point and > >> 16-bit fixed-point. The latter has exactly one user: The

Re: [FFmpeg-devel] [PATCH] Moves yuv2yuvX_sse3 to yasm, unrolls main loop and other small optimizations for ~20% speedup.

2021-01-10 Thread Michael Niedermayer
On Thu, Jan 07, 2021 at 10:39:56AM +0100, Alan Kelly wrote: > Thanks for your patience with this, I have replaced mova with movdqu - movu > generated a compile error on ssse3. What system did this crash on? AMD Ryzen 9 3950X on linux [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF1

Re: [FFmpeg-devel] [PATCH] Moves yuv2yuvX_sse3 to yasm, unrolls main loop and other small optimizations for ~20% speedup.

2021-01-10 Thread Michael Niedermayer
On Thu, Jan 07, 2021 at 10:41:19AM +0100, Alan Kelly wrote: > --- > Replaces mova with movdqu due to alignment issues > libswscale/x86/Makefile | 1 + > libswscale/x86/swscale.c| 106 +--- > libswscale/x86/yuv2yuvX.asm | 117 ++

Re: [FFmpeg-devel] [PATCH 1/4] avformat/rtsp: set AV_OPT_FLAG_DEPRECATED on depracated options

2021-01-10 Thread Andriy Gelman
On Thu, 17. Dec 10:42, Andriy Gelman wrote: > On Tue, 08. Dec 22:35, Andriy Gelman wrote: > > Hi Zhao, > > > > Thanks for reviewing. > > > > On Tue, 08. Dec 13:25, "zhilizhao(赵志立)" wrote: > > > > > > > > > > On Dec 8, 2020, at 12:08 PM, Andriy Gelman > > > > wrote: > > > > > > > > On Sun, 1

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: use sigaction() instead of signal() on linux

2021-01-10 Thread Andriy Gelman
On Sun, 13. Dec 11:41, Andriy Gelman wrote: > On Sat, 28. Nov 14:46, Andriy Gelman wrote: > > From: Andriy Gelman > > > > As per signal() help (man 2 signal) the semantics of using signal may > > vary across platforms. It is suggested to use sigaction() instead. > > > > On my system, the capture

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: use sigaction() instead of signal() on linux

2021-01-10 Thread Zane van Iperen
On 29/11/20 5:46 am, Andriy Gelman wrote: void term_init(void) { +#if defined __linux__ +struct sigaction action; Nit: Should this have a "= {0}"? My sigaction(2) says: On some architectures a union is involved: do not assign to both sa_handler and sa_sigaction. so it's possible th

[FFmpeg-devel] [PATCH] Add support for "omp simd" pragma.

2021-01-10 Thread Reimar . Doeffinger
From: Reimar Döffinger This requests loops to be vectorized using SIMD instructions. The performance increase is far from hand-optimized assembly but still significant over the plain C version. Typical values are a 2-4x speedup where a hand-written version would achieve 4x-10x. So it is far from

Re: [FFmpeg-devel] [PATCH] Add support for "omp simd" pragma.

2021-01-10 Thread Lynne
Jan 10, 2021, 17:43 by reimar.doeffin...@gmx.de: > From: Reimar Döffinger > > This requests loops to be vectorized using SIMD > instructions. > The performance increase is far from hand-optimized > assembly but still significant over the plain C version. > Typical values are a 2-4x speedup where

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: use sigaction() instead of signal() on linux

2021-01-10 Thread Andriy Gelman
On Sun, 10. Jan 16:32, Zane van Iperen wrote: > On 29/11/20 5:46 am, Andriy Gelman wrote: > > > void term_init(void) > > { > > +#if defined __linux__ > > +struct sigaction action; Hi Zane, Thanks for reviewing the patch. > > Nit: Should this have a "= {0}"? > > My sigaction(2) says: >

Re: [FFmpeg-devel] [PATCH v5] avformat/udp: return the error code instead of generic EIO

2021-01-10 Thread Marton Balint
On Sun, 10 Jan 2021, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/udp.c | 55 +-- 1 file changed, 33 insertions(+), 22 deletions(-) [...] @@ -888,8 +901,6 @@ static int udp_open(URLContext *h

Re: [FFmpeg-devel] FFmpeg buying an Apple M1 Mac Mini

2021-01-10 Thread Kieran Kunhya
> > > I will buy these if nobody objects by the end of the week. > > Totally in favor, also I'd like us to have two machines running. > > Thanks for hosting! > > -Thilo > Hi, Just to confirm, I have bought the two Mac Minis. They should be delivered and racked up in early February (lockdown may d

[FFmpeg-devel] Buying and hosting a HiFive RISC-V system

2021-01-10 Thread Kieran Kunhya
Hello, Lynne has suggested on IRC that we purchase one or more of these: https://www.sifive.com/boards/hifive-unmatched I think this is an interesting idea as RISC-V is an important platform for the future (like M1). I'll likely have to buy from Mouser (as I'm not sure SPI will accept CrowdSupply

Re: [FFmpeg-devel] Buying and hosting a HiFive RISC-V system

2021-01-10 Thread chen
In my evaluate, the RISC-V code density is 60% compare to ARM, with C-Extension, it raise to 80% it may be a big problem play large ffmpeg on really products, but we have more space to improve ffmpeg on it. At 2021-01-11 04:21:07, "Kieran Kunhya" wrote: >Hello, > >Lynne has suggested on IRC th

Re: [FFmpeg-devel] Buying and hosting a HiFive RISC-V system

2021-01-10 Thread Joel Linn
Keep in mind though that the RISC-V Vector Extensions (which btw look really smart and promising) are not implemented in the SiFive Unmatched Chip yet (iIrc). But one has to start somewhere and some future embedded devices like will also lack those. On 2021-01-10 21:39, chen wrote: In my eval

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/fft_template: Remove unused fixed-point cosine tables

2021-01-10 Thread Andreas Rheinhardt
Michael Niedermayer: > On Sun, Jan 10, 2021 at 01:56:21AM +0100, Andreas Rheinhardt wrote: >> Michael Niedermayer: >>> On Thu, Jan 07, 2021 at 12:13:05AM +0100, Andreas Rheinhardt wrote: There are three types of FFTs: floating-point, 32-bit fixed-point and 16-bit fixed-point. The latter h

[FFmpeg-devel] [PATCH] avcodec/xbmenc: Better xbm memory use

2021-01-10 Thread Jose Da Silva
Small memory reduction which uses approx 6/7th total memory. Assuming \n is 2bytes, we first need {32+33+40+5}=110 but we also need to include the terminating zero => 110+1 = 111 (bug-fix). Then assuming \n is 2bytes, data requires => height * (linesize * 6 + 2) For example, " 0x00, 0x11, 0x22,\n"

[FFmpeg-devel] [PATCH] avcodec/cbs: constify decompose_unit_types

2021-01-10 Thread James Almer
CBS doesn't change its contents in any way whatsoever internally, and most users already set it to a const array. Signed-off-by: James Almer --- libavcodec/av1_frame_split_bsf.c | 2 +- libavcodec/av1_parser.c | 2 +- libavcodec/cbs.h | 2 +- 3 files changed, 3 insertion

Re: [FFmpeg-devel] [PATCH] avcodec/cbs: constify decompose_unit_types

2021-01-10 Thread Andreas Rheinhardt
James Almer: > CBS doesn't change its contents in any way whatsoever internally, and most > users already set it to a const array. > > Signed-off-by: James Almer > --- > libavcodec/av1_frame_split_bsf.c | 2 +- > libavcodec/av1_parser.c | 2 +- > libavcodec/cbs.h | 2 +-

[FFmpeg-devel] [PATCH] libswscale/aarch64/hscale.S: Support more bit-depth variants.

2021-01-10 Thread Reimar . Doeffinger
From: Reimar Döffinger Trivially expand hscale assembler to support > 8 bit formats both for input and output. 16-bit input is not supported as I am not certain how to get sufficient test coverage. --- libswscale/aarch64/hscale.S | 53 ++-- libswscale/aarch64/sws

Re: [FFmpeg-devel] [PATCH v5] avformat/udp: return the error code instead of generic EIO

2021-01-10 Thread lance . lmwang
On Sun, Jan 10, 2021 at 08:29:30PM +0100, Marton Balint wrote: > > > On Sun, 10 Jan 2021, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/udp.c | 55 > > +-- > > 1 file changed,

Re: [FFmpeg-devel] [PATCH] Add support for "omp simd" pragma.

2021-01-10 Thread Carl Eugen Hoyos
Am So., 10. Jan. 2021 um 19:55 Uhr schrieb Lynne : > > Jan 10, 2021, 17:43 by reimar.doeffin...@gmx.de: > > > From: Reimar Döffinger > > > > This requests loops to be vectorized using SIMD > > instructions. > > The performance increase is far from hand-optimized > > assembly but still significant

[FFmpeg-devel] [PATCH 1/3] dnn/openvino: remove unnecessary code

2021-01-10 Thread Ting Fu
Signed-off-by: Ting Fu --- libavfilter/dnn/dnn_backend_openvino.c | 8 1 file changed, 8 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index d27e451eea..050be97209 100644 --- a/libavfilter/dnn/dnn_backend_openvino.c +++ b/liba

[FFmpeg-devel] [PATCH 2/3] dnn/openvino: refine code for better model initialization

2021-01-10 Thread Ting Fu
Move openvino model/inference request creation and initialization steps from ff_dnn_load_model_ov to new function init_model_ov, for later input resize support. Signed-off-by: Ting Fu --- libavfilter/dnn/dnn_backend_openvino.c | 153 +++-- 1 file changed, 93 insertions(+), 60

[FFmpeg-devel] [PATCH 3/3] dnn/openvino: support model input resize

2021-01-10 Thread Ting Fu
OpenVINO APIs require specify input size to run the model, while some OpenVINO model does accept different input size. To enable this feature adding input_resizable option here for easier use. Setting bool variable input_resizable to specify if the input can be resizable or not. input_resizable =