Re: [FFmpeg-devel] [RFC] Event loop

2021-01-02 Thread Nicolas George
Anton Khirnov (12021-01-01): > I do not think this is a good idea. There are enough event loops in the > world and making yet another one is not in scope for us. What we should > do instead is allow clean integration with existing event loops, mainly > by exporting the underlying file descriptors s

Re: [FFmpeg-devel] [RFC] Event loop

2021-01-02 Thread Nicolas George
Kieran Kunhya (12020-12-31): > This would be a good idea in general and bring FFmpeg into the early 21st > century. Thanks for the feedback. > As I understand it the hard part is cross-platform event loops (does libev > support windows now?) AFAIK, it is hard to make something really optimized,

[FFmpeg-devel] [PATCH] doc/tcp: update option listen description

2021-01-02 Thread Lingjiang Fang
--- doc/protocols.texi | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index de377a9546..e5a68dcbf4 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -1635,8 +1635,10 @@ tcp://@var{hostname}:@var{port}[?@var{options}] The

Re: [FFmpeg-devel] [PATCH] avformat/utils: fix seek failed

2021-01-02 Thread Marton Balint
On Thu, 31 Dec 2020, "zhilizhao(赵志立)" wrote: On Dec 31, 2020, at 6:51 PM, Marton Balint wrote: On Thu, 31 Dec 2020, Zhao Zhili wrote: Rounding min_ts towards +infinity and max_ts towards -infinity can make ts out of the [min_ts, max_ts] range, and then leads to seek failure. For examp

[FFmpeg-devel] [PATCH] avcodec/videotoolbox: make FFmpeg-to-VT mapping error more informative

2021-01-02 Thread Jan Ekström
Now logs the actual failed-to-map pixel format as well as range. --- libavcodec/videotoolbox.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c index 8773de3393..49e726a75f 100644 --- a/libavcodec/videotoolbox.c +++ b/

[FFmpeg-devel] Constant quality for H.264/265 encoding with VideoToolBox on M1

2021-01-02 Thread Aleksid
Do you plan to add support in FFmpeg for constant quality compression H.264 / H.265 using VideoToolBox on macOS 11 on new M1 Macs? CQ mode for video compression was added in new Macs on Apple M1 chip. Handbrake 1.4 Beta for Apple M1 already supports constant quality (CQ) mode. I tested this mode

Re: [FFmpeg-devel] [RFC] Event loop

2021-01-02 Thread Anton Khirnov
Quoting Nicolas George (2021-01-02 12:28:30) > Anton Khirnov (12021-01-01): > > I do not think this is a good idea. There are enough event loops in the > > world and making yet another one is not in scope for us. What we should > > do instead is allow clean integration with existing event loops, ma

Re: [FFmpeg-devel] [RFC PATCH] avfilter/fastdeint: import simple cpu-optimized deinterlacing algorithms from VLC

2021-01-02 Thread Paul B Mahol
On Tue, Sep 10, 2019 at 1:03 AM Aman Gupta wrote: > On Mon, Sep 9, 2019 at 3:19 PM Hendrik Leppkes > wrote: > > > On Tue, Sep 10, 2019 at 12:00 AM Aman Gupta wrote: > > > > > > On Mon, Sep 9, 2019 at 2:47 PM Carl Eugen Hoyos > > wrote: > > > > > > > Am Mo., 9. Sept. 2019 um 22:19 Uhr schrieb A

Re: [FFmpeg-devel] [RFC] Event loop

2021-01-02 Thread Nicolas George
Anton Khirnov (12021-01-02): > I don't see how that conclusion follows. If a protocol has multiple FDs, > we design the API to allow exporting multiple FDs. Why would we > absolutely need our own event loop? The protocol exports multiple FDs... ok... and then what? How do you make the protocol wor

Re: [FFmpeg-devel] [PATCH 2/6] avcodec: add h266 codec id and profiles

2021-01-02 Thread James Almer
On 1/2/2021 12:38 AM, Nuo Mi wrote: Hi James, Thanks, it works for me. It's wired no error prompt for my previous command line. Looks like there are other modules with "aud" options in your build, like libx264, nvenc or amfenc, and for some reason the CLI considers they have a global scope.

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox: make FFmpeg-to-VT mapping error more informative

2021-01-02 Thread Aman Karmani
On Sat, Jan 2, 2021 at 5:05 AM Jan Ekström wrote: > Now logs the actual failed-to-map pixel format as well as range. > --- > libavcodec/videotoolbox.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c > index 877

Re: [FFmpeg-devel] [RFC] Event loop

2021-01-02 Thread Kieran Kunhya
On Sat, 2 Jan 2021 at 16:52, Nicolas George wrote: > If we want FFmpeg to have good protocols as well as good codecs, it > needs to have the infrastructure to make them possible. And for > protocols, the infrastructure is mostly two things: crypto protocols and > en event loop. > In my opinion w

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox: make FFmpeg-to-VT mapping error more informative

2021-01-02 Thread Jan Ekström
On Sat, Jan 2, 2021 at 7:22 PM Aman Karmani wrote: > > On Sat, Jan 2, 2021 at 5:05 AM Jan Ekström wrote: > > > Now logs the actual failed-to-map pixel format as well as range. > > --- > > libavcodec/videotoolbox.c | 8 +++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --gi

[FFmpeg-devel] Problem with "-f concat" and mixed path types on Windows.

2021-01-02 Thread Steinar Apalnes
Hi, It looks like the -f concat options has a problem when mixingUNC paths in the concat file and local concat file path in command line: Concat file: ffconcat version 1.0 file '\\server\CanonXF\CONTENTS\CLIPS001\AA4002\AA400201.MXF' file '\\server\CanonXF\CONTENTS\CLIPS001\AA4002\AA400202.MXF'

Re: [FFmpeg-devel] Problem with "-f concat" and mixed path types on Windows.

2021-01-02 Thread Marton Balint
On Sat, 2 Jan 2021, Steinar Apalnes wrote: Hi, It looks like the -f concat options has a problem when mixingUNC paths in the concat file and local concat file path in command line: Concat file: ffconcat version 1.0 file '\\server\CanonXF\CONTENTS\CLIPS001\AA4002\AA400201.MXF' file '\\server

Re: [FFmpeg-devel] Problem with "-f concat" and mixed path types on Windows.

2021-01-02 Thread Steinar Apalnes
> > Hi, > > It looks like the -f concat options has a problem when mixingUNC paths in > > the concat file and local concat file path in command line: > > > > > > Concat file: > > > > ffconcat version 1.0 > > file '\\server\CanonXF\CONTENTS\CLIPS001\AA4002\AA400201.MXF' > > file '\\server\CanonXF\CO

Re: [FFmpeg-devel] Problem with "-f concat" and mixed path types on Windows.

2021-01-02 Thread Marton Balint
On Sat, 2 Jan 2021, Steinar Apalnes wrote: Hi, > It looks like the -f concat options has a problem when mixingUNC paths in > the concat file and local concat file path in command line: > > > Concat file: > > ffconcat version 1.0 > file '\\server\CanonXF\CONTENTS\CLIPS001\AA4002\AA400201.MXF'

Re: [FFmpeg-devel] Problem with "-f concat" and mixed path types on Windows.

2021-01-02 Thread Steinar Apalnes
> >>> Hi, > >> > It looks like the -f concat options has a problem when mixingUNC paths in > >> > the concat file and local concat file path in command line: > >> > > >> > > >> > Concat file: > >> > > >> > ffconcat version 1.0 > >> > file '\\server\CanonXF\CONTENTS\CLIPS001\AA4002\AA400201.MXF' > >

Re: [FFmpeg-devel] [PATCH 5/7] avformat/wavdec: Avoid zeroing written to array

2021-01-02 Thread Michael Niedermayer
On Mon, Nov 16, 2020 at 01:05:07AM +0100, Michael Niedermayer wrote: > On Sat, Nov 14, 2020 at 11:12:15AM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2020-11-10 00:04:54) > > > Fixes: OOM > > > Fixes: > > > 26934/clusterfuzz-testcase-minimized-ffmpeg_dem_W64_fuzzer-599678421381939

Re: [FFmpeg-devel] [PATCH 01/11] avcodec/notchlc: Check uncompressed size against input for LZ4

2021-01-02 Thread Michael Niedermayer
On Tue, Oct 20, 2020 at 10:56:09PM +0200, Michael Niedermayer wrote: > Fixes: OOM > Fixes: > 26168/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NOTCHLC_fuzzer-6019839015256064 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-