[FFmpeg-devel] 转发: [PATCH, v4] libavformat/movenc: Add support for HEVC in .3gp

2020-12-11 Thread Sun Zhenliang
>> +if (st->codecpar->codec_id == AV_CODEC_ID_H265){ >pay attention about the code style Sorry, I couldn't see problems in code style. Can you explain it in more detail, it would be helpful. Appreciate and regards, SunZhenliang 发件人: Steven Liu 发送时间: 20

Re: [FFmpeg-devel] [PATCH, v4] libavformat/movenc: Add support for HEVC in .3gp

2020-12-11 Thread Gyan Doshi
On 11-12-2020 11:28 am, hisunzhenli...@outlook.com wrote: From: SunZhenliang Just add HEVC's tag in 3gp tag list and it works to support HEVC in 3gp files. Signed-off-by: SunZhenliang --- libavformat/movenc.c | 29 + 1 file changed, 21 insertions(+), 8 deletio

Re: [FFmpeg-devel] About support a new arch

2020-12-11 Thread Linjie Fu
Hi, On Fri, Dec 11, 2020 at 3:58 PM Steven Liu wrote: > > > > > 2020年12月11日 下午3:55,俞林杰 写道: > > > > a new arch called csky > > How should we test your code for this arch? > Previous discussion in mail thread[1] about adding new hardware implementation, which you may want to refer to. [1] https:

[FFmpeg-devel] [PATCH 1/2] avformat/iff: Check data_size

2020-12-11 Thread Michael Niedermayer
Fixes: infinite loop Fixes: 27834/clusterfuzz-testcase-minimized-ffmpeg_dem_IFF_fuzzer-5694930919620608 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/iff.c | 3 +++ 1 file changed, 3 insert

[FFmpeg-devel] [PATCH 2/2] avformat/microdvddec: use 64bit for durations

2020-12-11 Thread Michael Niedermayer
Fixes: signed integer overflow: 7 - -2147483647 cannot be represented in type 'int' Fixes: 28036/clusterfuzz-testcase-minimized-ffmpeg_dem_MICRODVD_fuzzer-5171698751766528 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

Re: [FFmpeg-devel] About support a new arch

2020-12-11 Thread Steven Liu
> 2020年12月11日 下午5:52,Linjie Fu 写道: > > Hi, > > On Fri, Dec 11, 2020 at 3:58 PM Steven Liu wrote: >> >> >> >>> 2020年12月11日 下午3:55,俞林杰 写道: >>> >>> a new arch called csky >> >> How should we test your code for this arch? >> > > Previous discussion in mail thread[1] about adding new hardw

Re: [FFmpeg-devel] [PATCH, v4] libavformat/movenc: Add support for HEVC in .3gp

2020-12-11 Thread Steven Liu
> 2020年12月11日 下午5:48,Sun Zhenliang 写道: > > > >>> +if (st->codecpar->codec_id == AV_CODEC_ID_H265){ >> pay attention about the code style > > Sorry, I couldn't see problems in code style. Can you explain it in more > detail, it would be helpful. Space? > > Appreciate and regards, >

Re: [FFmpeg-devel] [PATCH, v4] libavformat/movenc: Add support for HEVC in .3gp

2020-12-11 Thread Jan Ekström
On Fri, Dec 11, 2020 at 11:51 AM Gyan Doshi wrote: > > > > On 11-12-2020 11:28 am, hisunzhenli...@outlook.com wrote: > > From: SunZhenliang > > > > Just add HEVC's tag in 3gp tag list and it works to support HEVC in > > 3gp files. > > > > Signed-off-by: SunZhenliang > > --- > > libavformat/mov

Re: [FFmpeg-devel] About support a new arch

2020-12-11 Thread Linjie Fu
On Fri, Dec 11, 2020 at 6:31 PM Steven Liu wrote: > > > > > 2020年12月11日 下午5:52,Linjie Fu 写道: > > > > Hi, > > > > On Fri, Dec 11, 2020 at 3:58 PM Steven Liu wrote: > >> > >> > >> > >>> 2020年12月11日 下午3:55,俞林杰 写道: > >>> > >>> a new arch called csky > >> > >> How should we test your code for this a

[FFmpeg-devel] [PATCH, v5] libavformat/movenc: Add support for HEVC in .3gp

2020-12-11 Thread hisunzhenliang
From: SunZhenliang Just add HEVC's tag in 3gp tag list and it works to support HEVC in 3gp files. Signed-off-by: SunZhenliang --- libavformat/movenc.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c

Re: [FFmpeg-devel] [PATCH v2] avformat/nut: Store display matrix side data

2020-12-11 Thread Paul B Mahol
Perhaps Michael failed to see it, if nut stuff is still not merged ping Michael directly. On Fri, Dec 11, 2020 at 9:35 AM Matthias Neugebauer wrote: > > > Am 06.11.2020 um 22:25 schrieb Michael Niedermayer > : > > > > see: > > > > https://git.ffmpeg.org/nut.git > > svn://svn.mplayerhq.hu/nut > >

Re: [FFmpeg-devel] [PATCH 27/39] avcodec/ituh263enc: Make static initializations thread-safe

2020-12-11 Thread Andreas Rheinhardt
Andreas Rheinhardt: > This already makes several encoders (namely FLV, H.263, H.263+ and > RealVideo 1.0 and 2.0) that use this init-threadsafe. > > It also makes the Snow encoder init-threadsafe; it was already marked > as such since commit d49210788b0836d56dd872d517fe73f83b080101, because > it w

Re: [FFmpeg-devel] [PATCH v2] avformat/nut: Store display matrix side data

2020-12-11 Thread Matthias Neugebauer
> Am 06.11.2020 um 22:25 schrieb Michael Niedermayer : > > see: > > https://git.ffmpeg.org/nut.git > svn://svn.mplayerhq.hu/nut > https://lists.ffmpeg.org/mailman/listinfo/nut-devel > > thx I submitted a patch for nut.txt some time ago. Is there still something missing on my part? __

[FFmpeg-devel] 回复: [PATCH, v4] libavformat/movenc: Add support for HEVC in .3gp

2020-12-11 Thread Sun Zhenliang
I think there two files: 3GPP TS 26.244 V16.1.0 (2020-09) and ISO/IEC 14496-15 2019: "Information technology – Coding of audio-visual objects – Part 15: Carriage of NAL unit structured video in the ISO base media file format" states the major brands of HEVC. https://www.etsi.org/deliver/etsi_ts/

Re: [FFmpeg-devel] [PATCH 1/2] avformat/iff: Check data_size

2020-12-11 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-12-11 11:00:01) > Fixes: infinite loop > Fixes: > 27834/clusterfuzz-testcase-minimized-ffmpeg_dem_IFF_fuzzer-5694930919620608 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niede

Re: [FFmpeg-devel] 回复: [PATCH, v4] libavformat/movenc: Add support for HEVC in .3gp

2020-12-11 Thread Jan Ekström
On Fri, Dec 11, 2020 at 3:27 PM Sun Zhenliang wrote: > > I think there two files: 3GPP TS 26.244 V16.1.0 (2020-09) > and ISO/IEC 14496-15 2019: "Information technology – Coding > of audio-visual objects – Part 15: Carriage of NAL unit structured > video in the ISO base media file format" states t

Re: [FFmpeg-devel] [PATCH] Moves yuv2yuvX_sse3 to yasm, unrolls main loop and other small optimizations for ~20% speedup.

2020-12-11 Thread Michael Niedermayer
On Thu, Dec 10, 2020 at 04:46:26PM +0100, Alan Kelly wrote: > --- > Replaces ff_sws_init_swscale_x86 with ff_getSwsFunc > Load offset if not gprsize but 8 on both 32 and 64 bit > Removes sfence as NT store no longer used > libswscale/x86/Makefile | 1 + > libswscale/x86/swscale.c| 106

Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: support exporting Film Grain params as frame side data

2020-12-11 Thread James Almer
On 12/9/2020 7:06 PM, Lynne wrote: Dec 9, 2020, 19:01 by jamr...@gmail.com: Signed-off-by: James Almer --- libavcodec/av1dec.c| 69 ++ libavcodec/dxva2_av1.c | 5 +-- libavcodec/nvdec_av1.c | 10 +++--- libavcodec/vaapi_av1.c | 8 +++-- 4 fil

Re: [FFmpeg-devel] [PATCH 1/2] avformat/iff: Check data_size

2020-12-11 Thread Michael Niedermayer
On Fri, Dec 11, 2020 at 02:56:10PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-12-11 11:00:01) > > Fixes: infinite loop > > Fixes: > > 27834/clusterfuzz-testcase-minimized-ffmpeg_dem_IFF_fuzzer-5694930919620608 > > > > Found-by: continuous fuzzing process > > https://github.c

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/af_earwax: fix filter behavior

2020-12-11 Thread Michael Niedermayer
On Thu, Dec 10, 2020 at 11:45:51PM +0100, Paul B Mahol wrote: > Should be fixed. thanks! [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting code that is poorly written but fully understood is good. Rewriting code that one doesnt understand is a sign that

[FFmpeg-devel] [PATCH] avformat/movenc: Remove dts delay from duration.

2020-12-11 Thread Josh Allmann
A negative start_dts value (eg, delay from edit lists) typically yields a duration larger than end_pts. During edit list processing, the delay is removed again, yielding the correct duration within the elst. However, other duration-carrying atoms (tkhd, mvhd, mdhd) still have the delay incorporate

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Remove dts delay from duration.

2020-12-11 Thread Martin Storsjö
On Fri, 11 Dec 2020, Josh Allmann wrote: A negative start_dts value (eg, delay from edit lists) typically yields a duration larger than end_pts. During edit list processing, the delay is removed again, yielding the correct duration within the elst. However, other duration-carrying atoms (tkhd,

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Remove dts delay from duration.

2020-12-11 Thread Josh Allmann
On Fri, 11 Dec 2020 at 14:07, Martin Storsjö wrote: > > On Fri, 11 Dec 2020, Josh Allmann wrote: > > > A negative start_dts value (eg, delay from edit lists) typically yields > > a duration larger than end_pts. During edit list processing, the > > delay is removed again, yielding the correct durat

[FFmpeg-devel] 回复: 回复: [PATCH, v4] libavformat/movenc: Add support for HEVC in .3gp

2020-12-11 Thread Sun Zhenliang
In 14496-15 2019 5.4.1"AVC file type and identification" and 8.4"HEVC video stream definition" , I think the Entry Box types 'hvc1' 'hev1',could be considered as brands of HEVC. I just think AVC uses its Entry as major brand, maybe it works same to HEVC. Regards, SunZhenliang __