[FFmpeg-devel] help

2020-12-08 Thread Akshay Bhuradia
Hi Dev Team, Why -hls_enc_key and -hls_enc_iv are taking 16 characters only. For AES-128 it should be 32 characters. whenever i provide 32 characters it takes only 16 characters. *Thanks and Regards* *Akshay Bhuradia* *Software Engineer* *Contact No : +91-9716414797 | SkypeId : akshay.bhura..

[FFmpeg-devel] [PATCH] avcodec/libaom: Support monochrome encoding with libaom >= 2.0.1

2020-12-08 Thread Philip Langdale
Monochrome encoding with libaom was buggy for a long time, but this was finally sorted out in libaom 2.0.1 (2.0.0 is almost there but was still buggy in realtime mode). Surprisingly, we've never had an external library feature flag in configure before, but it seems reasonable to add such a categor

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: remove an always true condition

2020-12-08 Thread myp...@gmail.com
On Sat, Oct 17, 2020 at 11:48 PM Zhao Zhili wrote: > > > > > On Sep 18, 2020, at 10:33 PM, Zhao Zhili wrote: > > > > From: Zhao Zhili > > > > --- > > libavformat/mov.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/mov.c b/libavformat/mov.c > > index 9f

Re: [FFmpeg-devel] [PATCH 1/6] fate: Add dpx-probe test

2020-12-08 Thread Paul B Mahol
Will upload a dpx sample and apply patches after 48h. On Mon, Dec 7, 2020 at 12:39 PM Harry Mallon wrote: > I attach the cyan.dpx that I generated for this test, it needs to be in > the dpx folder in fate. > > Best, > Harry > > > > > > On 7 Dec 2020, at 10:32, Harry Mallon wrote: > > > > Signed

Re: [FFmpeg-devel] [PATCH] avformat/hashenc: Reuse hash_free() for framehash muxers

2020-12-08 Thread Paul B Mahol
LGTM On Mon, Dec 7, 2020 at 1:11 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/hashenc.c | 14 +++--- > 1 file changed, 3 insertions(+), 11 deletions(-) > > diff --git a/libavformat/hashenc.c b/libavformat/hashenc.c

Re: [FFmpeg-devel] [PATCH] avcodec: set AV_CODEC_CAP_CHANNEL_CONF on decoders which set their own channels

2020-12-08 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avformat/fifo: utilize a clone packet for muxing

2020-12-08 Thread Jan Ekström
From: Jan Ekström This way the timestamp adjustments do not have to be manually undone in case of failure and need to recover/retry. Fixes an issue where the timestamp adjustment would be re-done over and over again when recovery by muxing the same AVPacket again is attempted. Would become visib

[FFmpeg-devel] [PATCH] avfilter/cropdetect: add option for initial skip

2020-12-08 Thread Gyan Doshi
The cropdetect filter, at present, skips the first two frames. This behaviour is hardcoded. New option 'skip' allows users to change this. Convenient for when input is a single image or a trimmed video stream. Default is kept at 2 to preserve current behaviour. --- doc/filters.texi|

Re: [FFmpeg-devel] [PATCH] avfilter/cropdetect: add option for initial skip

2020-12-08 Thread Paul B Mahol
lgtm On Tue, Dec 8, 2020 at 2:29 PM Gyan Doshi wrote: > The cropdetect filter, at present, skips the first two frames. This > behaviour is hardcoded. > > New option 'skip' allows users to change this. Convenient for when > input is a single image or a trimmed video stream. > > Default is kept at

[FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: check for SpeedHQ encoder

2020-12-08 Thread Gyan Doshi
Avoids build failure when mpegvideo_enc is built but SpeedHQ encoder isn't. --- libavcodec/mpegvideo_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 7afc789ec0..243d3ca632 100644 --- a/libavcodec/mpegvideo_enc.

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: check for SpeedHQ encoder

2020-12-08 Thread Paul B Mahol
lgtm On Tue, Dec 8, 2020 at 2:36 PM Gyan Doshi wrote: > Avoids build failure when mpegvideo_enc is built but SpeedHQ encoder > isn't. > --- > libavcodec/mpegvideo_enc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc

Re: [FFmpeg-devel] [PATCH] avcodec/libaom: Support monochrome encoding with libaom >= 2.0.1

2020-12-08 Thread James Almer
On 12/8/2020 2:04 AM, Philip Langdale wrote: Monochrome encoding with libaom was buggy for a long time, but this was finally sorted out in libaom 2.0.1 (2.0.0 is almost there but was still buggy in realtime mode). Surprisingly, we've never had an external library feature flag in configure before

[FFmpeg-devel] [RFC] Machines & Platforms of interest for testing

2020-12-08 Thread Josh Dekker
Hi, As discussed in the meeting, I'm starting a RFC for Machines & Platforms of interest for testing, developer access and FATE. These would be funded by SPI. The two platforms mentioned were a Mac Mini (M1 Apple Silicon platform) and a TALOS II (POWER9 platform). My personal suggestion would be

Re: [FFmpeg-devel] [RFC] Machines & Platforms of interest for testing

2020-12-08 Thread Kieran Kunhya
On Tue, 8 Dec 2020 at 14:03, Josh Dekker wrote: > Kieran offered to host one Mac Mini, though I'm unsure what his capacity > for > hosting is. > I can host as many devices as you see fit and give access to appropriate people. I've done this in the past when avx2 was a new feature set. Kieran __

Re: [FFmpeg-devel] [PATCH 143/217] avcodec/cinepak: Mark decoder as init-threadsafe

2020-12-08 Thread Tomas Härdin
ons 2020-12-02 klockan 05:21 +0100 skrev Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cinepak.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/cinepak.c b/libavcodec/cinepak.c > index 9c5b254231..17148a3577 100644 > --- a/libavcodec/cinepak.c >

Re: [FFmpeg-devel] [PATCH 142/217] avcodec/cinepakenc: Mark encoder as init-threadsafe

2020-12-08 Thread Tomas Härdin
ons 2020-12-02 klockan 05:21 +0100 skrev Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cinepakenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/cinepakenc.c b/libavcodec/cinepakenc.c > index cc125ed39e..9eaa972a9c 100644 > ---

Re: [FFmpeg-devel] [PATCH 164/217] avcodec/idcinvideo: Mark decoder as init-threadsafe

2020-12-08 Thread Tomas Härdin
ons 2020-12-02 klockan 05:21 +0100 skrev Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/idcinvideo.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/idcinvideo.c b/libavcodec/idcinvideo.c > index 6b2d8087ae..941a89d36d 100644 > --- a/libavcodec/idc

Re: [FFmpeg-devel] [RFC] Machines & Platforms of interest for testing

2020-12-08 Thread Kieran Kunhya
On Tue, 8 Dec 2020 at 14:10, Kieran Kunhya wrote: > On Tue, 8 Dec 2020 at 14:03, Josh Dekker wrote: > >> Kieran offered to host one Mac Mini, though I'm unsure what his capacity >> for >> hosting is. >> > > I can host as many devices as you see fit and give access to appropriate > people. > I've

Re: [FFmpeg-devel] [PATCH 1/6] fate: Add dpx-probe test

2020-12-08 Thread Andriy Gelman
Hi, On Mon, 07. Dec 10:32, Harry Mallon wrote: > Signed-off-by: Harry Mallon > --- > tests/fate/image.mak | 4 ++ > tests/ref/fate/dpx-probe | 85 > 2 files changed, 89 insertions(+) > create mode 100644 tests/ref/fate/dpx-probe > > diff --git a/te

Re: [FFmpeg-devel] [PATCH 1/6] fate: Add dpx-probe test

2020-12-08 Thread Paul B Mahol
big endian is dead. On Tue, Dec 8, 2020 at 6:18 PM Andriy Gelman wrote: > Hi, > > On Mon, 07. Dec 10:32, Harry Mallon wrote: > > Signed-off-by: Harry Mallon > > --- > > tests/fate/image.mak | 4 ++ > > tests/ref/fate/dpx-probe | 85 > > 2 files cha

[FFmpeg-devel] [PATCH] avformat/matroska: Handle TargetType and nested SimpleTags in metadata

2020-12-08 Thread zsugabubus
Metadata names now recognized in the following format: [ [TargetTypeValue][TargetType] "/" ] TagName [ "/" TagName ]... [ "@" [ "-" ] [TagLanguage] ] Language designators separated with "@" instead of "-" to avoid future ambiguity about IETF language tags, like "en-US" and similar. "-" designa

[FFmpeg-devel] [PATCH 1/4] avcodec/h264_sei: refactor parsing User Data Registered ITU-T T35 SEI messages

2020-12-08 Thread James Almer
Signed-off-by: James Almer --- libavcodec/h264_sei.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/libavcodec/h264_sei.c b/libavcodec/h264_sei.c index 669560ae5f..42ba94114c 100644 --- a/libavcodec/h264_sei.c +++ b/libavcodec/h264_sei.c @@ -1

[FFmpeg-devel] [PATCH 2/4] avcodec/h264_sei: print a log message when a unsupported ITU-T T35 SEI messages is parsed

2020-12-08 Thread James Almer
Signed-off-by: James Almer --- libavcodec/h264_sei.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264_sei.c b/libavcodec/h264_sei.c index 42ba94114c..96ae50a24a 100644 --- a/libavcodec/h264_sei.c +++ b/libavcodec/h264_sei.c @@ -195,8 +195,12 @@ stat

[FFmpeg-devel] [PATCH 3/4] avcodec/hevc_sei: refactor parsing User Data Registered ITU-T T35 SEI messages

2020-12-08 Thread James Almer
Signed-off-by: James Almer --- libavcodec/hevc_sei.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/libavcodec/hevc_sei.c b/libavcodec/hevc_sei.c index 3b0fa43439..d30568c20d 100644 --- a/libavcodec/hevc_sei.c +++ b/libavcodec/hevc_sei.c @@ -238,11 +2

[FFmpeg-devel] [PATCH 4/4] avcodec/hevc_sei: print a log message when a unsupported ITU-T T35 SEI messages is parsed

2020-12-08 Thread James Almer
Signed-off-by: James Almer --- libavcodec/hevc_sei.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/libavcodec/hevc_sei.c b/libavcodec/hevc_sei.c index d30568c20d..0607b1f7b4 100644 --- a/libavcodec/hevc_sei.c +++ b/libavcodec/hevc_sei.c @@ -236,7 +236,7 @@

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Handle TargetType and nested SimpleTags in metadata

2020-12-08 Thread Andreas Rheinhardt
zsugabubus@national.shitposting.agency: > Metadata names now recognized in the following format: > > [ [TargetTypeValue][TargetType] "/" ] TagName [ "/" TagName ]... [ "@" [ > "-" ] [TagLanguage] ] > > Language designators separated with "@" instead of "-" to avoid future > ambiguity about IET

Re: [FFmpeg-devel] [PATCH v2] avcodec/libaom: Support monochrome encoding with libaom >= 2.0.1

2020-12-08 Thread James Almer
On 12/8/2020 6:45 PM, Philip Langdale wrote: Monochrome encoding with libaom was buggy for a long time, but this was finally sorted out in libaom 2.0.1 (2.0.0 is almost there but was still buggy in realtime mode). Signed-off-by: Philip Langdale --- Changelog | 1 + libavcodec/l

[FFmpeg-devel] [PATCH] lavu: use address-of operator checking clock_gettime

2020-12-08 Thread Marvin Scholz
When targeting a recent enough macOS/iOS version that has clock_gettime it won't be a weak symbol, in which case clang warns for this check as it's always true: warning: address of function 'clock_gettime' will always evaluate to 'true' This warning is silenced by using the address-of operato

[FFmpeg-devel] [PATCH] avcodec/bitstream: use av_assert0 in GET_DATA

2020-12-08 Thread Marvin Scholz
For builds with asserts disabled, if the default case would ever be reached it could lead to uninitialized use of variables as v is never assigned to anything. This caused the following clang warning: libavcodec/bitstream.c:374:5: warning: variable 'len' is used uninitialized whenever switch

[FFmpeg-devel] [PATCH] avcodec/bitstream: Rewrite code to avoid triggering compiler warning

2020-12-08 Thread Andreas Rheinhardt
Clang infers from the existence of a default case that said case can be taken. In case of libavcodec/bitstream.c said default case consisted of an av_assert1 that evaluates to nothing in case of the ordinary assert level. In this case (that doesn't happen) a variable wouldn't be initialized, so Cla

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Handle TargetType and nested SimpleTags in metadata

2020-12-08 Thread zsugabubus
Metadata names now recognized in the following format: [ [TargetTypeValue][TargetType] "/" ] TagName [ "/" TagName ]... [ "@" [ "-" ] [TagLanguage] ] Language designators separated with "@" instead of "-" to avoid future ambiguity about IETF language tags, like "en-US" and similar. "-" designa

[FFmpeg-devel] [PATCH] doc/muxers: correct decribe of hls_enc_key and hls_enc_iv

2020-12-08 Thread liuqi05
From: Steven Liu because hls_enc_key and hls_enc_iv get 16byte char for example: -hls_enc_key 0123456789abcdef -hls_enc_iv abcdefghijklmnop Signed-off-by: liuqi05 --- doc/muxers.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index

[FFmpeg-devel] [PATCH v2] avcodec/libaom: Support monochrome encoding with libaom >= 2.0.1

2020-12-08 Thread Philip Langdale
Monochrome encoding with libaom was buggy for a long time, but this was finally sorted out in libaom 2.0.1 (2.0.0 is almost there but was still buggy in realtime mode). Signed-off-by: Philip Langdale --- Changelog | 1 + libavcodec/libaomenc.c | 42 +

Re: [FFmpeg-devel] [PATCH 1/4] avformat/rtsp: set AV_OPT_FLAG_DEPRECATED on depracated options

2020-12-08 Thread Andriy Gelman
Hi Zhao, Thanks for reviewing. On Tue, 08. Dec 13:25, "zhilizhao(赵志立)" wrote: > > > > On Dec 8, 2020, at 12:08 PM, Andriy Gelman wrote: > > > > On Sun, 15. Nov 13:20, Andriy Gelman wrote: > >> From: Andriy Gelman > >> > >> Signed-off-by: Andriy Gelman > >> --- > >> libavformat/rtsp.c | 4

Re: [FFmpeg-devel] [PATCH] doc/muxers: correct decribe of hls_enc_key and hls_enc_iv

2020-12-08 Thread Gyan Doshi
On 09-12-2020 06:52 am, liuqi05 wrote: From: Steven Liu because hls_enc_key and hls_enc_iv get 16byte char for example: -hls_enc_key 0123456789abcdef -hls_enc_iv abcdefghijklmnop Signed-off-by: liuqi05 --- doc/muxers.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

Re: [FFmpeg-devel] [PATCH] doc/muxers: correct decribe of hls_enc_key and hls_enc_iv

2020-12-08 Thread Gyan Doshi
And title: doc/muxers: correct description of hls_enc_key and hls_enc_iv On 09-12-2020 09:52 am, Gyan Doshi wrote: On 09-12-2020 06:52 am, liuqi05 wrote: From: Steven Liu because hls_enc_key and hls_enc_iv get 16byte char for example: -hls_enc_key 0123456789abcdef -hls_enc_iv abcdefghijklm

Re: [FFmpeg-devel] [PATCH] doc/muxers: correct decribe of hls_enc_key and hls_enc_iv

2020-12-08 Thread Steven Liu
> 2020年12月9日 下午12:22,Gyan Doshi 写道: > > > > On 09-12-2020 06:52 am, liuqi05 wrote: >> From: Steven Liu >> >> because hls_enc_key and hls_enc_iv get 16byte char >> for example: >> -hls_enc_key 0123456789abcdef -hls_enc_iv abcdefghijklmnop >> >> Signed-off-by: liuqi05 >> --- >> doc/muxers.

[FFmpeg-devel] [PATCH v2] doc/muxers: correct description of hls_enc_key and hls_enc_iv

2020-12-08 Thread liuqi05
From: Steven Liu because hls_enc_key and hls_enc_iv get 16byte char for example: -hls_enc_key 0123456789abcdef -hls_enc_iv abcdefghijklmnop Signed-off-by: liuqi05 --- doc/muxers.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index

Re: [FFmpeg-devel] [PATCH] doc/muxers: correct decribe of hls_enc_key and hls_enc_iv

2020-12-08 Thread Steven Liu
> 2020年12月9日 下午12:42,Gyan Doshi 写道: > > And title: > > doc/muxers: correct description of hls_enc_key and hls_enc_iv > > On 09-12-2020 09:52 am, Gyan Doshi wrote: >> >> >> On 09-12-2020 06:52 am, liuqi05 wrote: >>> From: Steven Liu >>> >>> because hls_enc_key and hls_enc_iv get 16byte cha

[FFmpeg-devel] [PATCH] libavformat/movenc: add support for HEVC in .3gp

2020-12-08 Thread hisunzhenliang
From: SunZhenliang Just add HEVC's tag in 3gp tag list and it works to support HEVC in 3gp files. Signed-off-by: SunZhenliang --- libavformat/movenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 18fa3f9b5e..8715cb6e5c 100644 --- a/libav

Re: [FFmpeg-devel] [PATCH v2] doc/muxers: correct description of hls_enc_key and hls_enc_iv

2020-12-08 Thread Gyan Doshi
LGTM. On 09-12-2020 11:09 am, liuqi05 wrote: From: Steven Liu because hls_enc_key and hls_enc_iv get 16byte char for example: -hls_enc_key 0123456789abcdef -hls_enc_iv abcdefghijklmnop Signed-off-by: liuqi05 --- doc/muxers.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: check for SpeedHQ encoder

2020-12-08 Thread Gyan Doshi
Thanks. Pushed as b9b719fedc532ebc6bbde711d60985e8cb5957b2 On 08-12-2020 07:06 pm, Paul B Mahol wrote: lgtm On Tue, Dec 8, 2020 at 2:36 PM Gyan Doshi wrote: Avoids build failure when mpegvideo_enc is built but SpeedHQ encoder isn't. --- libavcodec/mpegvideo_enc.c | 2 +- 1 file changed, 1

Re: [FFmpeg-devel] [PATCH] avfilter/cropdetect: add option for initial skip

2020-12-08 Thread Gyan Doshi
Thanks. Pushed as e5119ad3377e2c4cb20a7aff56448d035b55 On 08-12-2020 07:02 pm, Paul B Mahol wrote: lgtm On Tue, Dec 8, 2020 at 2:29 PM Gyan Doshi wrote: The cropdetect filter, at present, skips the first two frames. This behaviour is hardcoded. New option 'skip' allows users to change t