Re: [FFmpeg-devel] [PATCH] avcodec/dxva2_av1: use correct grain parameters with update_grain = 0

On Thu, Nov 26, 2020 at 9:05 PM James Almer wrote: > On 11/26/2020 2:34 AM, Guangxin Xu wrote: > > spec did not forbid this. > > Here is da1vd code: > > https://code.videolan.org/videolan/dav1d/-/blob/master/src/obu.c#L1057 > > If update_grain == 0, it will copy film grain data from the referen

Re: [FFmpeg-devel] [PATCH 01/45] avcodec/a64multienc: Fix memleak upon init failure

LGTM On Fri, Nov 27, 2020 at 2:55 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/a64multienc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/a64multienc.c b/libavcodec/a64multienc.c > index 38f25020f5..

Re: [FFmpeg-devel] [PATCH 4/7] lavfi/vf_spp: convert to the video_enc_params API

Quoting Michael Niedermayer (2020-10-09 19:17:06) > On Fri, Oct 09, 2020 at 08:13:24AM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2020-10-06 00:15:06) > > > On Mon, Oct 05, 2020 at 10:26:24AM +0200, Anton Khirnov wrote: > > > > Quoting Michael Niedermayer (2020-10-03 20:23:02) > >

Re: [FFmpeg-devel] [PATCH] avcodec: deprecate thread_safe_callbacks

Quoting Anton Khirnov (2020-10-29 15:01:22) > They add considerable complexity to frame-threading implementation, > which includes an unavoidably leaking error path, while the advantages > of this option to the users are highly dubious. > > It should be always possible and desirable for the caller

[FFmpeg-devel] [PATCH 46/72] avcodec/sunrastenc: Mark encoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/sunrastenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/sunrastenc.c b/libavcodec/sunrastenc.c index 97b2242a6e..3a66eab615 100644 --- a/libavcodec/sunrastenc.c +++ b/libavcodec/sunrastenc.c @@ -248,4 +248,5 @@ AVCodec ff_sunras

[FFmpeg-devel] [PATCH 47/72] avcodec/svq1dec: Make decoder init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/svq1dec.c | 38 ++ 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/libavcodec/svq1dec.c b/libavcodec/svq1dec.c index e67b460ae3..7aea138060 100644 --- a/libavcodec/svq1dec.c +++ b/libavcodec/svq1d

[FFmpeg-devel] [PATCH 48/72] avcodec/r210enc: Mark encoders as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/r210enc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/r210enc.c b/libavcodec/r210enc.c index be1943f5f9..f3596d2bac 100644 --- a/libavcodec/r210enc.c +++ b/libavcodec/r210enc.c @@ -94,6 +94,7 @@ AVCodec ff_r210_encoder = {

[FFmpeg-devel] [PATCH 49/72] avcodec/ra144dec: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/ra144dec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/ra144dec.c b/libavcodec/ra144dec.c index c716c32e67..0c72f78dbb 100644 --- a/libavcodec/ra144dec.c +++ b/libavcodec/ra144dec.c @@ -135,4 +135,5 @@ AVCodec ff_ra_144_decoder =

[FFmpeg-devel] [PATCH 50/72] avcodec/cdxl: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/cdxl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/cdxl.c b/libavcodec/cdxl.c index 7c82967df0..96ae14c418 100644 --- a/libavcodec/cdxl.c +++ b/libavcodec/cdxl.c @@ -335,4 +335,5 @@ AVCodec ff_cdxl_decoder = { .close

[FFmpeg-devel] [PATCH 55/72] avcodec/roqvideodec: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/roqvideodec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/roqvideodec.c b/libavcodec/roqvideodec.c index 36b4ddf755..4b80007962 100644 --- a/libavcodec/roqvideodec.c +++ b/libavcodec/roqvideodec.c @@ -243,5 +243,5

[FFmpeg-devel] [PATCH 51/72] avcodec/ra144enc: Mark encoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/ra144enc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/ra144enc.c b/libavcodec/ra144enc.c index c6965c5c47..7ba1cb3aa0 100644 --- a/libavcodec/ra144enc.c +++ b/libavcodec/ra144enc.c @@ -553,4 +553,5 @@ AVCodec ff_ra_144_encoder =

[FFmpeg-devel] [PATCH 56/72] avcodec/roqvideoenc: Mark encoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/roqvideoenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/roqvideoenc.c b/libavcodec/roqvideoenc.c index dc6a63099d..ca48f7f820 100644 --- a/libavcodec/roqvideoenc.c +++ b/libavcodec/roqvideoenc.c @@ -1131,5 +1131

[FFmpeg-devel] [PATCH 52/72] avcodec/ralf: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/ralf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/ralf.c b/libavcodec/ralf.c index 0080b23941..47effa1f09 100644 --- a/libavcodec/ralf.c +++ b/libavcodec/ralf.c @@ -538,4 +538,5 @@ AVCodec ff_ralf_decoder = { .capabilities

[FFmpeg-devel] [PATCH 57/72] avcodec/rpza: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/rpza.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/rpza.c b/libavcodec/rpza.c index 02bbfe753f..416af2d6c5 100644 --- a/libavcodec/rpza.c +++ b/libavcodec/rpza.c @@ -296,4 +296,5 @@ AVCodec ff_rpza_decoder = { .close

[FFmpeg-devel] [PATCH 53/72] avcodec/rl2: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/rl2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/rl2.c b/libavcodec/rl2.c index 2d336a61e5..55ceaf080d 100644 --- a/libavcodec/rl2.c +++ b/libavcodec/rl2.c @@ -228,4 +228,5 @@ AVCodec ff_rl2_decoder = { .close = rl

[FFmpeg-devel] [PATCH 58/72] avcodec/pafaudio: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/pafaudio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/pafaudio.c b/libavcodec/pafaudio.c index 12f473ae0a..f306e3b96c 100644 --- a/libavcodec/pafaudio.c +++ b/libavcodec/pafaudio.c @@ -79,4 +79,5 @@ AVCodec ff_paf_audio_decoder

[FFmpeg-devel] [PATCH 59/72] avcodec/pafvideo: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/pafvideo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/pafvideo.c b/libavcodec/pafvideo.c index 07fa05caf8..22ae26ac10 100644 --- a/libavcodec/pafvideo.c +++ b/libavcodec/pafvideo.c @@ -419,4 +419,5 @@ AVCodec ff_paf_video_decode

[FFmpeg-devel] [PATCH 54/72] avcodec/roqaudioenc: Mark encoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/roqaudioenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/roqaudioenc.c b/libavcodec/roqaudioenc.c index c09212d3d1..1c32f7f701 100644 --- a/libavcodec/roqaudioenc.c +++ b/libavcodec/roqaudioenc.c @@ -195,4 +195,5 @@ AVCodec ff_r

[FFmpeg-devel] [PATCH 60/72] avcodec/pamenc: Mark encoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/pamenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/pamenc.c b/libavcodec/pamenc.c index 50c9fcb404..3f2ce16d2f 100644 --- a/libavcodec/pamenc.c +++ b/libavcodec/pamenc.c @@ -153,4 +153,5 @@ AVCodec ff_pam_encoder = { A

[FFmpeg-devel] [PATCH 61/72] avcodec/pcm-dvd: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/pcm-dvd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/pcm-dvd.c b/libavcodec/pcm-dvd.c index 725c2f5b29..e019de80bd 100644 --- a/libavcodec/pcm-dvd.c +++ b/libavcodec/pcm-dvd.c @@ -302,5 +302,6 @@ AVCodec ff_pcm

[FFmpeg-devel] [PATCH 62/72] avcodec/pcm-dvdenc: Mark encoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/pcm-dvdenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/pcm-dvdenc.c b/libavcodec/pcm-dvdenc.c index 63f6e5d81b..97ac778334 100644 --- a/libavcodec/pcm-dvdenc.c +++ b/libavcodec/pcm-dvdenc.c @@ -188,4 +188,5 @@ AVCodec ff_pcm_dv

[FFmpeg-devel] [PATCH 63/72] avcodec/pcxenc: Mark encoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/pcxenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/pcxenc.c b/libavcodec/pcxenc.c index 6135944c31..288988104a 100644 --- a/libavcodec/pcxenc.c +++ b/libavcodec/pcxenc.c @@ -218,4 +218,5 @@ AVCodec ff_pcx_encoder = { A

[FFmpeg-devel] [PATCH 64/72] avcodec/pgssubdec: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/pgssubdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/pgssubdec.c b/libavcodec/pgssubdec.c index 9c59a2297f..472cd60200 100644 --- a/libavcodec/pgssubdec.c +++ b/libavcodec/pgssubdec.c @@ -727,4 +727,5 @@ AVCodec ff_pgssub_deco

[FFmpeg-devel] [PATCH 65/72] avcodec/photocd: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/photocd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/photocd.c b/libavcodec/photocd.c index aa1b1059e9..408ddeaac8 100644 --- a/libavcodec/photocd.c +++ b/libavcodec/photocd.c @@ -469,4 +469,5 @@ AVCodec ff_photocd_decoder = {

[FFmpeg-devel] [PATCH 66/72] avcodec/pnmenc: Mark encoders as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/pnmenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/pnmenc.c b/libavcodec/pnmenc.c index ba9478d0da..7bb42c5a7a 100644 --- a/libavcodec/pnmenc.c +++ b/libavcodec/pnmenc.c @@ -142,6 +142,7 @@ AVCodec ff_pgm_encoder = { .

[FFmpeg-devel] [PATCH 67/72] avcodec/proresdec2: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/proresdec2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/proresdec2.c b/libavcodec/proresdec2.c index 5fd2796115..0071b69d9f 100644 --- a/libavcodec/proresdec2.c +++ b/libavcodec/proresdec2.c @@ -827,4 +827,5 @@ AVCodec ff_prores

[FFmpeg-devel] [PATCH 68/72] avcodec/proresenc_anatoliy: Fix memleak upon init error

A buffer may leak in case of YUVA444P10 with dimensions that are not both divisible by 16. Signed-off-by: Andreas Rheinhardt --- libavcodec/proresenc_anatoliy.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 8bc13fd57

[FFmpeg-devel] [PATCH 69/72] avcodec/proresenc_anatoliy: Mark encoders as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/proresenc_anatoliy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 85e8cb3aaa..a15ac10e26 100644 --- a/libavcodec/proresenc_anatoliy.c +++ b/libavcode

[FFmpeg-devel] [PATCH 70/72] avcodec/proresenc_kostya: Mark encoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/proresenc_kostya.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/proresenc_kostya.c b/libavcodec/proresenc_kostya.c index 8e6f905a9f..cf598b7ef2 100644 --- a/libavcodec/proresenc_kostya.c +++ b/libavcodec/proresenc_kostya.c @@ -143

[FFmpeg-devel] [PATCH 71/72] avcodec/on2avc: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/on2avc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/on2avc.c b/libavcodec/on2avc.c index 60adc32b9f..6693dcfcb6 100644 --- a/libavcodec/on2avc.c +++ b/libavcodec/on2avc.c @@ -1007,7 +1007,7 @@ AVCodec ff_on2avc_d

[FFmpeg-devel] [PATCH 72/72] avcodec/pafvideo: Cleanup generically on init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/pafvideo.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/pafvideo.c b/libavcodec/pafvideo.c index 22ae26ac10..1e5d891332 100644 --- a/libavcodec/pafvideo.c +++ b/libavcodec/pafvideo.c @@ -104,10 +104,8 @@ stat

Re: [FFmpeg-devel] [PATCH 72/72] avcodec/pafvideo: Cleanup generically on init failure

LGTM On Fri, Nov 27, 2020 at 6:52 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/pafvideo.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/pafvideo.c b/libavcodec/pafvideo.c > index 2

Re: [FFmpeg-devel] [PATCH 50/72] avcodec/cdxl: Mark decoder as init-threadsafe

LGTM On Fri, Nov 27, 2020 at 6:48 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cdxl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/cdxl.c b/libavcodec/cdxl.c > index 7c82967df0..96ae14c418 100644 > ---

Re: [FFmpeg-devel] [PATCH 65/72] avcodec/photocd: Mark decoder as init-threadsafe

LGTM On Fri, Nov 27, 2020 at 6:51 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/photocd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/photocd.c b/libavcodec/photocd.c > index aa1b1059e9..408ddeaac8 100

Re: [FFmpeg-devel] [PATCH 59/72] avcodec/pafvideo: Mark decoder as init-threadsafe

LGTM On Fri, Nov 27, 2020 at 6:49 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/pafvideo.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/pafvideo.c b/libavcodec/pafvideo.c > index 07fa05caf8..22ae26ac10

Re: [FFmpeg-devel] [PATCH 58/72] avcodec/pafaudio: Mark decoder as init-threadsafe

LGTM On Fri, Nov 27, 2020 at 6:49 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/pafaudio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/pafaudio.c b/libavcodec/pafaudio.c > index 12f473ae0a..f306e3b96c

Re: [FFmpeg-devel] [PATCH 62/72] avcodec/pcm-dvdenc: Mark encoder as init-threadsafe

LGTM On Fri, Nov 27, 2020 at 6:50 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/pcm-dvdenc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/pcm-dvdenc.c b/libavcodec/pcm-dvdenc.c > index 63f6e5d81b..97ac7

Re: [FFmpeg-devel] [PATCH 47/72] avcodec/svq1dec: Make decoder init-threadsafe

On Fri, Nov 27, 2020 at 06:46:27PM +0100, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/svq1dec.c | 38 ++ > 1 file changed, 22 insertions(+), 16 deletions(-) probably ok thx [...] -- Michael GnuPG fingerprint: 9FF2128

Re: [FFmpeg-devel] [PATCH 66/72] avcodec/pnmenc: Mark encoders as init-threadsafe

On Fri, Nov 27, 2020 at 06:46:46PM +0100, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/pnmenc.c | 4 > 1 file changed, 4 insertions(+) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Does the universe only hav

Re: [FFmpeg-devel] [PATCH v2 161/162] avcodec/mpegaudiodec: Hardcode tables to save space

Michael Niedermayer: > On Fri, Nov 20, 2020 at 08:33:26AM +0100, Andreas Rheinhardt wrote: >> The csa_tables (which always consist of 32 entries of four byte each, >> but the type depends upon whether the decoder is fixed or >> floating-point) are currently initialized once during decoder >> initia

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/utils: Require a non zero channels unless AV_CODEC_CAP_CHANNEL_CONF is set

On Fri, Sep 11, 2020 at 03:42:45PM +0200, Paul B Mahol wrote: > On Thu, Sep 10, 2020 at 02:02:20PM +0200, Michael Niedermayer wrote: > > This avoids per codec checks for channels not being 0 > > > > Fixes: division by 0 > > Fixes: > > 25419/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FASTAU

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: Set AV_CODEC_CAP_CHANNEL_CONF in more decoders

On Fri, Sep 11, 2020 at 03:46:43PM +0200, Paul B Mahol wrote: > On Thu, Sep 10, 2020 at 02:02:19PM +0200, Michael Niedermayer wrote: > > Suggested-by: Paul B Mahol > > See: [FFmpeg-devel] [PATCH 1/3] avcodec/fastaudio: Check channels > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/

[FFmpeg-devel] [PATCH] avcodec/notchlc: Check available space for luma block code and alpha code

Fixes: Timeout (too long -> 2sec) Fixes: 25439/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NOTCHLC_fuzzer-5688211127664640 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/notchlc.c | 6 +

Re: [FFmpeg-devel] [PATCH] libavformat/mov.c: export vendor id as metadata

ping? On Wed, Nov 18, 2020 at 12:09 PM Thierry Foucu wrote: > --- > libavformat/mov.c | 8 ++-- > tests/ref/fate/hapqa-extract-nosnappy-to-hapalphaonly-mov | 1 + > tests/ref/fate/hapqa-extract-nosnappy-to-hapq-mov | 1 + > tests/ref/fate/mov-