Re: [FFmpeg-devel] [PATCH 2/2] qsvdec_av1: add an option to disable film grain

Hi Haihao, Hold on a moment, Let me send another related refact patch set. :) On Thu, Nov 26, 2020 at 1:30 PM Haihao Xiang wrote: > User may use '-disable_film_grain 1' to disable film grain. > --- > libavcodec/qsvdec.c | 5 + > libavcodec/qsvdec.h | 2 ++ > libavcodec/qsvdec_

[FFmpeg-devel] [PATCH 1/5] avcodec/qsvdec_other: refact, use DEFINE_QSV_DECODER to remove duplicate code

--- libavcodec/qsvdec_other.c | 188 -- 1 file changed, 36 insertions(+), 152 deletions(-) diff --git a/libavcodec/qsvdec_other.c b/libavcodec/qsvdec_other.c index 2775e07955..266ac9f2e5 100644 --- a/libavcodec/qsvdec_other.c +++ b/libavcodec/qsvdec_other.c @@

[FFmpeg-devel] [PATCH 2/5] avcodec/qsvdec_h2645: refact, use DEFINE_QSV_DECODER to remove duplicate code

--- libavcodec/qsvdec_h2645.c | 89 +++ 1 file changed, 33 insertions(+), 56 deletions(-) diff --git a/libavcodec/qsvdec_h2645.c b/libavcodec/qsvdec_h2645.c index 02c41883b6..b0ab23a922 100644 --- a/libavcodec/qsvdec_h2645.c +++ b/libavcodec/qsvdec_h2645.c @@ -

[FFmpeg-devel] [PATCH 3/5] avcodec/qsvdec: refact, move qsvdec_h2645.c to qsvdec.c

--- libavcodec/Makefile | 8 +- libavcodec/qsvdec.c | 215 - libavcodec/qsvdec_h2645.c | 248 -- 3 files changed, 217 insertions(+), 254 deletions(-) delete mode 100644 libavcodec/qsvdec_h2645.c diff --git a/libavc

[FFmpeg-devel] [PATCH 4/5] avcodec/qsvdec: refact, move qsvdec_other.c to qsvdec.c

--- libavcodec/Makefile | 14 +-- libavcodec/qsvdec.c | 42 ++- libavcodec/qsvdec_other.c | 242 -- 3 files changed, 48 insertions(+), 250 deletions(-) delete mode 100644 libavcodec/qsvdec_other.c diff --git a/libavcodec/Makefile b/libavcodec

[FFmpeg-devel] [PATCH 5/5] avcodec/qsvdec: refact, remove duplicate code for plugin loading

--- libavcodec/qsvdec.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c index ed40e2f4c2..8da367079a 100644 --- a/libavcodec/qsvdec.c +++ b/libavcodec/qsvdec.c @@ -681,21 +681,12 @@ static av_cold int qsv

Re: [FFmpeg-devel] [PATCH] avcodec/dxva2_av1: use correct grain parameters with update_grain = 0

On 11/26/2020 2:34 AM, Guangxin Xu wrote: spec did not forbid this. Here is da1vd code: https://code.videolan.org/videolan/dav1d/-/blob/master/src/obu.c#L1057 If update_grain == 0, it will copy film grain data from the reference frame to the current frame. Maybe we can do the same thing on CBS,

Re: [FFmpeg-devel] [PATCH] avfilter: add asupcut filter

Will apply with minor fixes. On Mon, Nov 23, 2020 at 7:52 PM Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 15 +++ > libavfilter/Makefile | 1 + > libavfilter/af_asupcut.c | 248 +++ > libavfilter/allfilters.c |

Re: [FFmpeg-devel] [PATCH 2/2] qsvdec_av1: add an option to disable film grain

On 11/26/2020 2:30 AM, Haihao Xiang wrote: User may use '-disable_film_grain 1' to disable film grain. A side data type was recently pushed that lets the user choose to export film grain parameters as frame side data instead of having the decoder apply them. Can you implement it here? Does QS

[FFmpeg-devel] [PATCH] avformat/hls: Fixes overwriting existing #EXT-X-PROGRAM-DATE-TIME value in HLS playlist Bug ID: 8989

This is is due to the following behavior in the current code: 1. The initial_prog_date_time gets set to the current local time 2. The existing playlist (.m3u8) file gets parsed and the segments present are added to the variant stream 3. The new segment is created and added 4. The existing segments

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fixes overwriting existing #EXT-X-PROGRAM-DATE-TIME value in HLS playlist

Sounds good :D I have incorporated the changes and resubmitted the patch - http://ffmpeg.org/pipermail/ffmpeg-devel/2020-November/272964.html Please review. Thanks, Vignesh On Thu, Nov 26, 2020 at 12:37 PM Steven Liu wrote: > > > > 2020年11月26日 下午12:43，Vignesh Ravichandran < > vignesh.ravichand

Re: [FFmpeg-devel] [PATCH v2 2/3] libavcodec: add a new AV_CODEC_EXPORT_DATA_FILM_GRAIN flag and option

On 11/17/2020 8:15 AM, Lynne wrote: Nov 17, 2020, 10:58 by an...@khirnov.net: Quoting Lynne (2020-11-17 00:21:43) Nov 16, 2020, 15:56 by ffm...@haasn.xyz: In terms of an API user needing this functionality, the way I see it working is that presence of the side-data will imply that it still

Re: [FFmpeg-devel] Add RTSP range header

Hi, On Sun, 22. Nov 11:21, Yakov Okshtein wrote: > Hi all, > > While working to get historical video off a DVR, I found the lack of a > customizable Range: header for RTSP video frustrating (as, apparently, have > others on StackOverflow and the Trac wiki, #6659). One user mentionedhaving > made

[FFmpeg-devel] [PATCH] avutil/film_grain_params: add more details to some AVFilmGrainAOMParams fields

Signed-off-by: James Almer --- libavutil/film_grain_params.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavutil/film_grain_params.h b/libavutil/film_grain_params.h index cdc8f623c6..f5baf9a928 100644 --- a/libavutil/film_grain_params.h +++ b/libavutil/film_

Re: [FFmpeg-devel] [PATCH 1/6] avutil/timecode: allow drop frame timecodes for multiples of 30000/1001 fps

On Thu, 19 Nov 2020, Marton Balint wrote: Signed-off-by: Marton Balint --- libavutil/timecode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavutil/timecode.c b/libavutil/timecode.c index f2db21c52c..8fcdf320ee 100644 --- a/libavutil/timecode.c +++ b/libavutil/t

[FFmpeg-devel] [PATCH 2/2] avformat/rtspdec: fix potential mem leak in listen mode

From: Andriy Gelman Currently a repeating setup request (with the same stream id) will simply overwrite rtp_handle/transport_priv without freeing the resources first. This is fixed by closing the previous setup request. Signed-off-by: Andriy Gelman --- libavformat/rtspdec.c | 10 ++ 1

[FFmpeg-devel] [PATCH v2] avformat/rtspdec: fix potential mem leak in listen mode

From: Andriy Gelman Currently a repeating setup request (with the same stream id) will simply overwrite rtp_handle/transport_priv without freeing the resources first. This is fixed by closing the previous setup request. Signed-off-by: Andriy Gelman --- libavformat/rtspdec.c | 11 +++ 1

[FFmpeg-devel] [PATCH 1/2] avformat/rtspdec: show method request in log

From: Andriy Gelman Signed-off-by: Andriy Gelman --- libavformat/rtspdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index 28b35d1993..be11576913 100644 --- a/libavformat/rtspdec.c +++ b/libavformat/rtspdec.c @@ -474,6 +474,7 @@ int ff_r

Re: [FFmpeg-devel] [PATCH 2/2] qsvdec_av1: add an option to disable film grain

On Thu, 2020-11-26 at 10:17 -0300, James Almer wrote: > On 11/26/2020 2:30 AM, Haihao Xiang wrote: > > User may use '-disable_film_grain 1' to disable film grain. > > A side data type was recently pushed that lets the user choose to export > film grain parameters as frame side data instead of hav

[FFmpeg-devel] [PATCH 02/45] avcodec/a64multienc: Mark encoders as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/a64multienc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/a64multienc.c b/libavcodec/a64multienc.c index 5f4825d55d..55616c8524 100644 --- a/libavcodec/a64multienc.c +++ b/libavcodec/a64multienc.c @@ -407,7 +4

[FFmpeg-devel] [PATCH 03/45] avcodec/cdtoons: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/cdtoons.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/cdtoons.c b/libavcodec/cdtoons.c index a8609815c1..3530f81452 100644 --- a/libavcodec/cdtoons.c +++ b/libavcodec/cdtoons.c @@ -453,4 +453,5 @@ AVCodec ff_cdtoons_decoder = {

[FFmpeg-devel] [PATCH 05/45] avcodec/adpcmenc: Mark encoders as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/adpcmenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c index 4bab004dac..78600735cf 100644 --- a/libavcodec/adpcmenc.c +++ b/libavcodec/adpcmenc.c @@ -978,7 +978,7 @@ AVCodec ff_

[FFmpeg-devel] [PATCH 07/45] avcodec/pcm: Mark decoders as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/pcm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/pcm.c b/libavcodec/pcm.c index 8ba38c6645..7f0af8564f 100644 --- a/libavcodec/pcm.c +++ b/libavcodec/pcm.c @@ -575,6 +575,7 @@ AVCodec ff_ ## name_ ## _decoder = {

[FFmpeg-devel] [PATCH 13/45] avcodec/yuv4dec: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/yuv4dec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/yuv4dec.c b/libavcodec/yuv4dec.c index f89f62debe..3fb1dbac28 100644 --- a/libavcodec/yuv4dec.c +++ b/libavcodec/yuv4dec.c @@ -81,4 +81,5 @@ AVCodec ff_yuv4_decoder = { .

[FFmpeg-devel] [PATCH 08/45] avcodec/loco: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/loco.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/loco.c b/libavcodec/loco.c index 25dd1575ba..99e3a1d021 100644 --- a/libavcodec/loco.c +++ b/libavcodec/loco.c @@ -346,4 +346,5 @@ AVCodec ff_loco_decoder = { .init

[FFmpeg-devel] [PATCH 14/45] avcodec/xan: Cleanup generically on init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/xan.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libavcodec/xan.c b/libavcodec/xan.c index 1ccf164847..5318aab797 100644 --- a/libavcodec/xan.c +++ b/libavcodec/xan.c @@ -100,16 +100,12 @@ static av_cold int xan_de

[FFmpeg-devel] [PATCH 15/45] avcodec/xan: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/xan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/xan.c b/libavcodec/xan.c index 5318aab797..6bf754f151 100644 --- a/libavcodec/xan.c +++ b/libavcodec/xan.c @@ -645,5 +645,5 @@ AVCodec ff_xan_wc3_decoder = {

[FFmpeg-devel] [PATCH 10/45] avcodec/yop: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/yop.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/yop.c b/libavcodec/yop.c index aff28ef3fc..8f8ed940ec 100644 --- a/libavcodec/yop.c +++ b/libavcodec/yop.c @@ -274,4 +274,5 @@ AVCodec ff_yop_decoder = { .init = yo

[FFmpeg-devel] [PATCH 16/45] avcodec/xfacedec: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/xfacedec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/xfacedec.c b/libavcodec/xfacedec.c index ab4c0823f5..763be6761a 100644 --- a/libavcodec/xfacedec.c +++ b/libavcodec/xfacedec.c @@ -185,4 +185,5 @@ AVCodec ff_xface_decoder =

[FFmpeg-devel] [PATCH 11/45] avcodec/y41pdec: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/y41pdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/y41pdec.c b/libavcodec/y41pdec.c index 85a39e4ae2..2bfabe277e 100644 --- a/libavcodec/y41pdec.c +++ b/libavcodec/y41pdec.c @@ -89,4 +89,5 @@ AVCodec ff_y41p_decoder = { .

[FFmpeg-devel] [PATCH 17/45] avcodec/xl: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/xl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/xl.c b/libavcodec/xl.c index 37ab46e4f7..72fb3bf259 100644 --- a/libavcodec/xl.c +++ b/libavcodec/xl.c @@ -135,4 +135,5 @@ AVCodec ff_xl_decoder = { .init = decode_ini

[FFmpeg-devel] [PATCH 18/45] avcodec/xsubdec: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/xsubdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/xsubdec.c b/libavcodec/xsubdec.c index c1c6e11dc3..87ac910577 100644 --- a/libavcodec/xsubdec.c +++ b/libavcodec/xsubdec.c @@ -24,6 +24,7 @@ #include "avcodec.h" #include

[FFmpeg-devel] [PATCH 19/45] avcodec/xsubenc: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/xsubenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/xsubenc.c b/libavcodec/xsubenc.c index 58be5e6deb..ad7144db2d 100644 --- a/libavcodec/xsubenc.c +++ b/libavcodec/xsubenc.c @@ -22,6 +22,7 @@ #include "avcodec.h" #includ

[FFmpeg-devel] [PATCH 21/45] avcodec/xxan: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/xxan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/xxan.c b/libavcodec/xxan.c index 865dfa8f87..1dd46b36eb 100644 --- a/libavcodec/xxan.c +++ b/libavcodec/xxan.c @@ -443,5 +443,5 @@ AVCodec ff_xan_wc4_decoder = {

[FFmpeg-devel] [PATCH 22/45] avcodec/ws-snd1: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/ws-snd1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/ws-snd1.c b/libavcodec/ws-snd1.c index 0f005807ae..bc9ed00938 100644 --- a/libavcodec/ws-snd1.c +++ b/libavcodec/ws-snd1.c @@ -178,4 +178,5 @@ AVCodec ff_ws_snd1_decoder = {

[FFmpeg-devel] [PATCH 23/45] avcodec/ulti: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/ulti.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/ulti.c b/libavcodec/ulti.c index e6fb661f6e..cf6891d530 100644 --- a/libavcodec/ulti.c +++ b/libavcodec/ulti.c @@ -428,4 +428,5 @@ AVCodec ff_ulti_decoder = { .close

[FFmpeg-devel] [PATCH 24/45] avcodec/tmv: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/tmv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/tmv.c b/libavcodec/tmv.c index b738fcb103..f8485cda59 100644 --- a/libavcodec/tmv.c +++ b/libavcodec/tmv.c @@ -94,4 +94,5 @@ AVCodec ff_tmv_decoder = { .init = tmv_

[FFmpeg-devel] [PATCH 25/45] avcodec/sgidec: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/sgidec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/sgidec.c b/libavcodec/sgidec.c index 02ad1e1165..e954140258 100644 --- a/libavcodec/sgidec.c +++ b/libavcodec/sgidec.c @@ -297,4 +297,5 @@ AVCodec ff_sgi_decoder = { .deco

[FFmpeg-devel] [PATCH 26/45] avcodec/sgienc: Mark encoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/sgienc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/sgienc.c b/libavcodec/sgienc.c index 40771d4666..65eff33bc8 100644 --- a/libavcodec/sgienc.c +++ b/libavcodec/sgienc.c @@ -300,4 +300,5 @@ AVCodec ff_sgi_encoder = { A

[FFmpeg-devel] [PATCH 27/45] avcodec/sgienc: Combine av_log() statements

Signed-off-by: Andreas Rheinhardt --- libavcodec/sgienc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/sgienc.c b/libavcodec/sgienc.c index 65eff33bc8..3aa0c7f4a5 100644 --- a/libavcodec/sgienc.c +++ b/libavcodec/sgienc.c @@ -39,9 +39,9 @@ typedef struct Sg

[FFmpeg-devel] [PATCH 28/45] avcodec/sgirledec: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/sgirledec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/sgirledec.c b/libavcodec/sgirledec.c index aa4f0e7e15..9cb637b07f 100644 --- a/libavcodec/sgirledec.c +++ b/libavcodec/sgirledec.c @@ -139,4 +139,5 @@ AVCodec ff_sgirle_deco

[FFmpeg-devel] [PATCH 29/45] avcodec/shorten: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/shorten.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/shorten.c b/libavcodec/shorten.c index 4134af74cf..c423ca73be 100644 --- a/libavcodec/shorten.c +++ b/libavcodec/shorten.c @@ -812,4 +812,5 @@ AVCodec ff_shorten_decoder = {

[FFmpeg-devel] [PATCH 30/45] avcodec/sipr: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/sipr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/sipr.c b/libavcodec/sipr.c index 1b6de25fff..ad045a543f 100644 --- a/libavcodec/sipr.c +++ b/libavcodec/sipr.c @@ -571,4 +571,5 @@ AVCodec ff_sipr_decoder = { .init

[FFmpeg-devel] [PATCH 31/45] avcodec/smc: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/smc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/smc.c b/libavcodec/smc.c index 2beb1ce291..342ebb71d1 100644 --- a/libavcodec/smc.c +++ b/libavcodec/smc.c @@ -484,4 +484,5 @@ AVCodec ff_smc_decoder = { .close = sm

[FFmpeg-devel] [PATCH 32/45] avcodec/smvjpegdec: Error out early if extradata is invalid

Don't allocate and open a whole decoder after having already found out that the given extradata is invalid. Signed-off-by: Andreas Rheinhardt --- libavcodec/smvjpegdec.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/libavcodec/smvjpegdec.c b/libavcodec/

[FFmpeg-devel] [PATCH 33/45] avcodec/smvjpegdec: Check allocation for success

Signed-off-by: Andreas Rheinhardt --- libavcodec/smvjpegdec.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/smvjpegdec.c b/libavcodec/smvjpegdec.c index 587ad82a00..32756b54f3 100644 --- a/libavcodec/smvjpegdec.c +++ b/libavcodec/smvjpegdec.c @@ -120,6 +120,10 @@ static av_co

[FFmpeg-devel] [PATCH 35/45] avcodec/mjpegdec: Fix memleak upon init failure

This affected all decoders that used ff_mjpeg_decode_init() as init function; and it also affected decoders that open jpeg decoders via ff_codec_open2_recursive() as well as MxPEG. Signed-off-by: Andreas Rheinhardt --- libavcodec/jpeglsdec.c | 2 +- libavcodec/mjpegbdec.c | 2 +- libavcodec/mjpe

[FFmpeg-devel] [PATCH 34/45] avcodec/smvjpegdec: Cleanup generically on init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/smvjpegdec.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/libavcodec/smvjpegdec.c b/libavcodec/smvjpegdec.c index 32756b54f3..807d990d00 100644 --- a/libavcodec/smvjpegdec.c +++ b/libavcodec/smvjpegdec.c @@ -

[FFmpeg-devel] [PATCH 36/45] avcodec/mxpegdec: Fix memleaks upon init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/mjpegdec.c | 2 ++ libavcodec/mxpegdec.c | 6 ++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index 6cf8014490..c2d946752e 100644 --- a/libavcodec/mjpegdec.c +++ b/libavcodec/mjpeg

[FFmpeg-devel] [PATCH 37/45] avcodec: Fix invalid uses of ff_codec_open2_recursive()

Normally no two codecs with FF_CODEC_CAP_INIT_THREADSAFE unset can be initialized at the same time: a mutex in avcodec_open2() ensures this. This implies that one cannot simply open a codec with a non-threadsafe init-function from the init function of a codec whose own init function is not threadsa

[FFmpeg-devel] [PATCH 38/45] avcodec/cri: Make decoder init-threadsafe

The only thing that stands in the way of adding the FF_CODEC_CAP_INIT_THREADSAFE flag to the Cintel RAW decoder is its usage of ff_codec_open2_recursive(): This function requires its caller to hold the lock for the mutex that guards initialization of AVCodecContexts whose codecs have a non-threadsa

[FFmpeg-devel] [PATCH 39/45] avcodec/smvjpegdec: Make decoder init-threadsafe

The only thing that stands in the way of adding the FF_CODEC_CAP_INIT_THREADSAFE flag to the SMV JPEG decoder is its usage of ff_codec_open2_recursive(): This function requires its caller to hold the lock for the mutex that guards initialization of AVCodecContexts whose codecs have a non-threadsafe

[FFmpeg-devel] [PATCH 40/45] avcodec/smvjpegdec: Remove unused private class

This decoder does not have any private option. Signed-off-by: Andreas Rheinhardt --- libavcodec/smvjpegdec.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/libavcodec/smvjpegdec.c b/libavcodec/smvjpegdec.c index 670e3313c9..c134fdc685 100644 --- a/libavcodec/smvjpegdec.c +++ b/libavco

[FFmpeg-devel] [PATCH 41/45] avcodec/smvjpegdec: Remove unused MJpegDecodeContext

The SMV JPEG uses the Motion JPEG decoder internally, but it does so by opening a decoder instance via avcodec_open2(); this means that the Motion JPEG decoder has its own context and its own private data; so there is no need to add a MJpegDecodeContext at the beginning of the SMV JPEG decoder's st

[FFmpeg-devel] [PATCH 42/45] avcodec/smvjpegdec: Use pointer to const AVCodec

Signed-off-by: Andreas Rheinhardt --- libavcodec/smvjpegdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/smvjpegdec.c b/libavcodec/smvjpegdec.c index 72c8f34370..f153f6e390 100644 --- a/libavcodec/smvjpegdec.c +++ b/libavcodec/smvjpegdec.c @@ -88,7 +88,7 @@ sta

[FFmpeg-devel] [PATCH 43/45] avcodec/faxcompr: Make ff_ccitt_unpack_init() thread-safe

This will allow to make the TIFF decoder's init function thread-safe. Signed-off-by: Andreas Rheinhardt --- libavcodec/faxcompr.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/libavcodec/faxcompr.c b/libavcodec/faxcompr.c index 2a1d2bc3f6..3dd64cf730 100644 --

[FFmpeg-devel] [PATCH 44/45] avcodec/tiff: Make decoder init-threadsafe

The only thing that stands in the way of adding the FF_CODEC_CAP_INIT_THREADSAFE flag to the TIFF decoder is its usage of ff_codec_open2_recursive(): This function requires its caller to hold the lock for the mutex that guards initialization of AVCodecContexts whose codecs have a non-threadsafe ini

[FFmpeg-devel] [PATCH 45/45] avcodec/utils: Remove ff_codec_open2_recursive()

This function existed to enable codecs with non-threadsafe init functions to initialize other codecs despite the fact that normally no two codecs with non-threadsafe init functions can be initialized at the same time (there is a mutex guarding this). Yet there are no users of this function any more

[FFmpeg-devel] [PATCH 06/45] avcodec/pcm: Make encoders init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/pcm.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/libavcodec/pcm.c b/libavcodec/pcm.c index 12d1b3a2c3..8ba38c6645 100644 --- a/libavcodec/pcm.c +++ b/libavcodec/pcm.c @@ -24,8 +24,10 @@ * PCM cod

[FFmpeg-devel] [PATCH 12/45] avcodec/y41penc: Mark encoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/y41penc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/y41penc.c b/libavcodec/y41penc.c index d7d301fab5..4340a3fbba 100644 --- a/libavcodec/y41penc.c +++ b/libavcodec/y41penc.c @@ -84,4 +84,5 @@ AVCodec ff_y41p_encoder = { .

[FFmpeg-devel] [PATCH 20/45] avcodec/xxan: Cleanup generically on init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/xxan.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libavcodec/xxan.c b/libavcodec/xxan.c index afe60e1564..865dfa8f87 100644 --- a/libavcodec/xxan.c +++ b/libavcodec/xxan.c @@ -71,16 +71,12 @@ static av_cold int xan

[FFmpeg-devel] [PATCH 04/45] avcodec/adpcm: Mark decoders as init-threadsafe

They don't modify any global state Signed-off-by: Andreas Rheinhardt --- libavcodec/adpcm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 01aced2e10..eb228cc47a 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -2142,6 +2142,7 @@ AVCo

[FFmpeg-devel] [PATCH 09/45] avcodec/cljrdec: Mark decoder as init-threadsafe

Signed-off-by: Andreas Rheinhardt --- libavcodec/cljrdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/cljrdec.c b/libavcodec/cljrdec.c index 4b187f8cf3..c41df12d53 100644 --- a/libavcodec/cljrdec.c +++ b/libavcodec/cljrdec.c @@ -90,5 +90,6 @@ AVCodec ff_cljr_decoder = { .

Re: [FFmpeg-devel] [PATCH] lavu/film_grain_params: fix typo in type enum

On 11/26/2020 10:16 PM, Lynne wrote: Unfortunately, this wasn't caught during reviews. Patch attached. From b83c9e225163dfa22c3092e9b808484ada02db91 Mon Sep 17 00:00:00 2001 From: Lynne Date: Fri, 27 Nov 2020 02:12:10 +0100 Subject: [PATCH] lavu/film_grain_params: fix typo in type enum ---

Re: [FFmpeg-devel] [PATCH] avutil/film_grain_params: add more details to some AVFilmGrainAOMParams fields

On 11/26/2020 10:33 PM, Lynne wrote: Nov 26, 2020, 21:31 by jamr...@gmail.com: Signed-off-by: James Almer --- libavutil/film_grain_params.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavutil/film_grain_params.h b/libavutil/film_grain_params.h index cd

[FFmpeg-devel] [PATCH 01/45] avcodec/a64multienc: Fix memleak upon init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/a64multienc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/a64multienc.c b/libavcodec/a64multienc.c index 38f25020f5..5f4825d55d 100644 --- a/libavcodec/a64multienc.c +++ b/libavcodec/a64multienc.c @@ -407,6 +407,7 @@ AVCodec ff

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fixes overwriting existing #EXT-X-PROGRAM-DATE-TIME value in HLS playlist Bug ID: 8989

> 2020年11月26日 下午10:21，Vignesh Ravichandran > 写道： > > This is is due to the following behavior in the current code: > 1. The initial_prog_date_time gets set to the current local time > 2. The existing playlist (.m3u8) file gets parsed and the segments present > are added to the variant stream

Re: [FFmpeg-devel] [PATCH 2/2] qsvdec_av1: add an option to disable film grain

Sure, I will update my patch against your patchset. Thanks Haihao Hi Haihao, Hold on a moment, Let me send another related refact patch set. :) On Thu, Nov 26, 2020 at 1:30 PM Haihao Xiang mailto:haihao.xi...@intel.com>> wrote: User may use '-disable_film_grain 1' to disable film grain. ---

[FFmpeg-devel] [PATCH] lavu/film_grain_params: fix typo in type enum

Unfortunately, this wasn't caught during reviews. Patch attached. >From b83c9e225163dfa22c3092e9b808484ada02db91 Mon Sep 17 00:00:00 2001 From: Lynne Date: Fri, 27 Nov 2020 02:12:10 +0100 Subject: [PATCH] lavu/film_grain_params: fix typo in type enum --- libavcodec/libdav1d.c | 2 +- l

Re: [FFmpeg-devel] [PATCH] lavu/film_grain_params: fix typo in type enum

Nov 27, 2020, 02:23 by jamr...@gmail.com: > On 11/26/2020 10:16 PM, Lynne wrote: > >> Unfortunately, this wasn't caught during reviews. >> >> Patch attached. >> >> From b83c9e225163dfa22c3092e9b808484ada02db91 Mon Sep 17 00:00:00 2001 >> From: Lynne >> Date: Fri, 27 Nov 2020 02:12:10 +0100 >> Sub

Re: [FFmpeg-devel] [PATCH] avutil/film_grain_params: add more details to some AVFilmGrainAOMParams fields

Nov 26, 2020, 21:31 by jamr...@gmail.com: > Signed-off-by: James Almer > --- > libavutil/film_grain_params.h | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavutil/film_grain_params.h b/libavutil/film_grain_params.h > index cdc8f623c6..f5baf9a928 100644 >

Re: [FFmpeg-devel] [PATCH v2 2/3] libavcodec: add a new AV_CODEC_EXPORT_DATA_FILM_GRAIN flag and option

Nov 26, 2020, 16:21 by jamr...@gmail.com: > On 11/17/2020 8:15 AM, Lynne wrote: > >> Nov 17, 2020, 10:58 by an...@khirnov.net: >> >>> Quoting Lynne (2020-11-17 00:21:43) >>> Nov 16, 2020, 15:56 by ffm...@haasn.xyz: > In terms of an API user needing this functionality, the way I see i

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fixes overwriting existing #EXT-X-PROGRAM-DATE-TIME value in HLS playlist Bug ID: 8989

av_isdigit seems to only check if the integer is from 0 to 9. So values above 9 would fail the check, for example: 2020 would fail the check. Also, we will not be able to use av_isdigit for checking the double value. On Fri, Nov 27, 2020 at 7:41 AM Steven Liu wrote: > > > > 2020年11月26日 下午10:21，V

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fixes overwriting existing #EXT-X-PROGRAM-DATE-TIME value in HLS playlist Bug ID: 8989

> 2020年11月27日 下午2:36，Vignesh Ravichandran 写道： > > av_isdigit seems to only check if the integer is from 0 to 9. So values > above 9 would fail the check, for example: 2020 would fail the check. Also, > we will not be able to use av_isdigit for checking the double value. > > On Fri, Nov 27, 202

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fixes overwriting existing #EXT-X-PROGRAM-DATE-TIME value in HLS playlist Bug ID: 8989

On Thu, 26. Nov 19:51, Vignesh Ravichandran wrote: > This is is due to the following behavior in the current code: > 1. The initial_prog_date_time gets set to the current local time > 2. The existing playlist (.m3u8) file gets parsed and the segments present > are added to the variant stream > 3.

Re: [FFmpeg-devel] [PATCH v2] avformat/rtspdec: fix potential mem leak in listen mode

On Thu, 26 Nov 2020, Andriy Gelman wrote: From: Andriy Gelman Currently a repeating setup request (with the same stream id) will simply overwrite rtp_handle/transport_priv without freeing the resources first. This is fixed by closing the previous setup request. Signed-off-by: Andriy Gelman -

Re: [FFmpeg-devel] [PATCH 1/2] avformat/rtspdec: show method request in log

On Thu, 26 Nov 2020, Andriy Gelman wrote: From: Andriy Gelman Signed-off-by: Andriy Gelman --- libavformat/rtspdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index 28b35d1993..be11576913 100644 --- a/libavformat/rtspdec.c +++ b/libavfo