Re: [FFmpeg-devel] [PATCH 10/18] lavf: move AVStream.*index_entries* to AVStreamInternal

2020-11-17 Thread Hendrik Leppkes
On Tue, Nov 17, 2020 at 1:46 AM James Almer wrote: > > On 11/16/2020 12:25 PM, Hendrik Leppkes wrote: > > On Mon, Nov 16, 2020 at 4:20 PM James Almer wrote: > >> > >> On 11/16/2020 3:01 AM, Anton Khirnov wrote: > >>> Quoting Xiang, Haihao (2020-11-16 06:16:55) > > This change breaks the

Re: [FFmpeg-devel] [PATCH] http: Check for AVERROR_EOF in the check for premature end

2020-11-17 Thread Martin Storsjö
On Fri, 13 Nov 2020, Martin Storsjö wrote: When the check was added (in 3668701f9600, in 2015), some IO functions returned 0 on EOF (in particular, the TCP protocol did, but the TLS protocol returned AVERROR_EOF). Since 0e1f771d2200d in 2017, the TCP protocol also returns AVERROR_EOF instead of

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/exr: use lookuptable for alpha if there is no trc_func

2020-11-17 Thread Paul B Mahol
LGTM On Mon, Nov 9, 2020 at 4:37 AM wrote: > From: Mark Reid > > --- > libavcodec/exr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/exr.c b/libavcodec/exr.c > index cf7824402a..e907c5c464 100644 > --- a/libavcodec/exr.c > +++ b/libavcodec/exr.c > @@ -120

Re: [FFmpeg-devel] [PATCH 1/1] avfilter/vf_lut3d: fix sanitizef INF handling

2020-11-17 Thread Paul B Mahol
LGTM On Mon, Nov 9, 2020 at 2:12 AM wrote: > From: Mark Reid > > --- > libavfilter/vf_lut3d.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c > index 988f6c8b55..172d6df0c8 100644 > --- a/libavfilter/vf_lut3d.c > +++

Re: [FFmpeg-devel] [PATCH 5/7] avformat/wavdec: Avoid zeroing written to array

2020-11-17 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-11-16 22:28:48) > On Mon, Nov 16, 2020 at 07:07:21AM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2020-11-16 01:05:07) > > > On Sat, Nov 14, 2020 at 11:12:15AM +0100, Anton Khirnov wrote: > > > > Quoting Michael Niedermayer (2020-11-10 00:04:54) > >

Re: [FFmpeg-devel] [PATCH v2 2/3] libavcodec: add a new AV_CODEC_EXPORT_DATA_FILM_GRAIN flag and option

2020-11-17 Thread Anton Khirnov
Quoting Lynne (2020-11-17 00:21:43) > Nov 16, 2020, 15:56 by ffm...@haasn.xyz: > > > In terms of an API user needing this functionality, the way I see it > > working is that presence of the side-data will imply that it still needs > > to be applied, with the side data being removed the moment grai

Re: [FFmpeg-devel] [PATCH 10/18] lavf: move AVStream.*index_entries* to AVStreamInternal

2020-11-17 Thread James Almer
On 11/17/2020 3:43 AM, Andreas Rheinhardt wrote: James Almer: On 11/16/2020 12:25 PM, Hendrik Leppkes wrote: On Mon, Nov 16, 2020 at 4:20 PM James Almer wrote: On 11/16/2020 3:01 AM, Anton Khirnov wrote: Quoting Xiang, Haihao (2020-11-16 06:16:55) This change breaks the compiling of gst-l

Re: [FFmpeg-devel] [PATCH] avformat/mov: adjust skip_samples according to seek timestamp

2020-11-17 Thread Matthieu Bouron
On Mon, Nov 09, 2020 at 06:26:46PM +0100, Matthieu Bouron wrote: > On Mon, Nov 02, 2020 at 12:42:19PM +0100, Matthieu Bouron wrote: > > Currently skip_samples is set to start_pad if sample_time is lesser or > > equal to 0. This can cause issues if the stream starts with packets that > > have negati

Re: [FFmpeg-devel] [PATCH v2 2/3] libavcodec: add a new AV_CODEC_EXPORT_DATA_FILM_GRAIN flag and option

2020-11-17 Thread Lynne
Nov 17, 2020, 10:58 by an...@khirnov.net: > Quoting Lynne (2020-11-17 00:21:43) > >> Nov 16, 2020, 15:56 by ffm...@haasn.xyz: >> >> > In terms of an API user needing this functionality, the way I see it >> > working is that presence of the side-data will imply that it still needs >> > to be applie

Re: [FFmpeg-devel] [PATCH] Moves yuv2yuvX_sse3 to yasm, unrolls main loop and other small optimizations for ~20% speedup.

2020-11-17 Thread Henrik Gramner
On Mon, Nov 16, 2020 at 11:03 AM Alan Kelly wrote: > +cglobal yuv2yuvX, 6, 7, 16, filter, filterSize, dest, dstW, dither, offset, > src Only 8 xmm registers are used, so 8 should be used instead of 16 here. Otherwise it causes unnecessary spilling of registers on 64-bit Windows. > +%if ARCH_X86_

[FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: Adjust maxpixels for G2M

2020-11-17 Thread Michael Niedermayer
Fixes: Timeout (50sec -> 3sec) Fixes: 27383/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_G2M_fuzzer-5196953666977792 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 2 +-

Re: [FFmpeg-devel] [PATCH] http: support retry on connection error

2020-11-17 Thread Eran Kornblau
Another ping... would be great to have some feedback on this... Eran From: Eran Kornblau Sent: Sunday, November 8, 2020 8:59 AM To: FFmpeg development discussions and patches Subject: RE: [PATCH] http: support retry on connection error Pinging again... Thanks, Eran From: Eran Kornblau Sent: S

[FFmpeg-devel] [PATCH] libavformat/mov.c: export vendor id as metadata

2020-11-17 Thread Thierry Foucu
--- libavformat/mov.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 2b90e31170..1f9163d658 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2095,6 +2095,8 @@ static void mov_parse_stsd_video(MOVCo

Re: [FFmpeg-devel] [PATCH] fate: Convert the musepack8 test to an oneoff test

2020-11-17 Thread Martin Storsjö
On Thu, 12 Nov 2020, Martin Storsjö wrote: On Thu, 12 Nov 2020, Andreas Rheinhardt wrote: Martin Storsjö: This fixes tests if built for x86 with x87 FPU. --- This requires someone to upload a reference file. --- tests/fate/mpc.mak | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) dif

[FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-11-17 Thread Mohammad Izadi
From: Mohammad Izadi HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs to be decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred to side data packet to be used or passed through. --- The fate test file can be found here: https://drive.google.com/file/d/1vc

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-11-17 Thread Mohammad Izadi
On Sun, Nov 15, 2020 at 12:19 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Mohammad Izadi: > > From: Mohammad Izadi > > > > HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs > to be decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred > to si

Re: [FFmpeg-devel] [PATCH] libavformat/mov.c: export vendor id as metadata

2020-11-17 Thread Gyan Doshi
On 18-11-2020 02:41 am, Thierry Foucu wrote: --- libavformat/mov.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 2b90e31170..1f9163d658 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2095,

Re: [FFmpeg-devel] [PATCH] libavformat/mov.c: export vendor id as metadata

2020-11-17 Thread Thierry Foucu
On Tue, Nov 17, 2020 at 9:54 PM Gyan Doshi wrote: > > > On 18-11-2020 02:41 am, Thierry Foucu wrote: > > --- > > libavformat/mov.c | 24 ++-- > > 1 file changed, 22 insertions(+), 2 deletions(-) > > > > diff --git a/libavformat/mov.c b/libavformat/mov.c > > index 2b90e31170