Yet a ping ...
This is a simple technical patch, it just needs a policy decision.
Can I have one ?
Jocke
On Thu, 2020-10-22 at 14:17 +0200, Joakim Tjernlund wrote:
> Ping ?
>
> Jocke
>
> On Fri, 2020-10-16 at 10:57 +0200, Joakim Tjernlund wrote:
> > From https://bugs.chromium.org/p/chromiu
---
libswscale/x86/Makefile | 1 +
libswscale/x86/swscale.c| 75 --
libswscale/x86/yuv2yuvX.asm | 105
3 files changed, 116 insertions(+), 65 deletions(-)
create mode 100644 libswscale/x86/yuv2yuvX.asm
diff --git a/libswscal
Thanks for the review, I have made the required changes. As I have changed
the subject the patch is in a new thread.
On Fri, Oct 23, 2020 at 4:10 PM James Almer wrote:
> On 10/23/2020 10:17 AM, Alan Kelly wrote:
> > Fixed. The wrong step size was used causing a write passed the end of
> > the
Apologies for the multiple threads, my git send-email was wrongly
configured. This has been fixed.
This code has been tested on AVX2 giving a significant speedup, however,
until the ff_hscale* functions are ported to avx2, this should not be
enabled as it results in an overall slowdown of swscale
---
libswscale/x86/Makefile | 1 +
libswscale/x86/swscale.c| 75 -
libswscale/x86/yuv2yuvX.asm | 109
3 files changed, 120 insertions(+), 65 deletions(-)
create mode 100644 libswscale/x86/yuv2yuvX.asm
diff --git a/libswscale
Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> The main motivation for this patch is actually the second patch and not
> the improved check.
>
> libavcodec/bitstream.c | 12 +++-
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/libavcodec/bitstream.c b
Hi,
Quoting Alan Kelly (2020-10-27 10:10:14)
> ---
> libswscale/x86/Makefile | 1 +
> libswscale/x86/swscale.c| 75 -
> libswscale/x86/yuv2yuvX.asm | 109
> 3 files changed, 120 insertions(+), 65 deletions(-)
> create mode 10
Quoting Andreas Rheinhardt (2020-10-26 15:21:26)
> Unnecessary: The code below also works for LE writers, now that the LE
> version of put_bits() is called.
Right, changed locally.
>
> > diff --git a/libavcodec/version.h b/libavcodec/version.h
> > index 02ffa95749..78c4dd64ee 100644
> > --- a/li
Quoting James Almer (2020-10-27 01:10:47)
> On 10/26/2020 10:41 AM, Anton Khirnov wrote:
> > It has not been used outside of lavc since 6f69f7a8bf6.
> >
> > Also, move it to the only place where it is used.
>
> Shouldn't you keep the symbol around until the bump? Even though it was
> not used by
Quoting Michael Niedermayer (2020-10-26 19:01:47)
> On Sun, Oct 25, 2020 at 01:55:11PM +0100, Anton Khirnov wrote:
> > Quoting Michael Niedermayer (2020-10-19 23:57:31)
> > > On Mon, Oct 19, 2020 at 07:22:48PM +0200, Jean-Baptiste Kempf wrote:
> > > > Yo,
> > > >
> > > > On Mon, 19 Oct 2020, at 19
Andreas Rheinhardt:
> If a static VLC table gets initialized a second time (or concurrently by
> two threads) and if said VLC table uses symbols that have the sign bit
> of VLC_TYPE (a typedef for int16_t) set, initializing the VLC fails. The
> reason is that the type of the symbol in the temporary
Quoting Jan Ekström (2020-10-16 15:16:47)
> Additionally, reap the first rewards by being able to set the
> color related encoding values based on the passed AVFrame.
>
> The only tests that seem to have changed their results with this
> change seem to be the MXF tests. There, the muxer writes the
Quoting Jan Ekström (2020-10-16 15:16:48)
> We now have the possibility of getting AVFrames here, and we should
> not touch the muxer's codecpar after writing the header.
> ---
> fftools/ffmpeg.c | 27 ++-
> .../fate/concat-demuxer-extended-lavf-mxf_d10
Quoting Andreas Rheinhardt (2020-10-27 11:30:32)
> Andreas Rheinhardt:
> > If a static VLC table gets initialized a second time (or concurrently by
> > two threads) and if said VLC table uses symbols that have the sign bit
> > of VLC_TYPE (a typedef for int16_t) set, initializing the VLC fails. The
Anton Khirnov:
> Quoting Andreas Rheinhardt (2020-10-27 11:30:32)
>> Andreas Rheinhardt:
>>> If a static VLC table gets initialized a second time (or concurrently by
>>> two threads) and if said VLC table uses symbols that have the sign bit
>>> of VLC_TYPE (a typedef for int16_t) set, initializing
Thanks for the feedback Anton.
The second patch incorporates changes suggested by James Almer:
avx2 instructions are wrapped in if cpuflag(avx2) and movddup restored
mm1 is replaced by m1 on x86_32
On Tue, Oct 27, 2020 at 10:40 AM Anton Khirnov wrote:
> Hi,
> Quoting Alan Kelly (2020-10-27 10
Section 6.10.1 of the AV1 spec states:
It is a requirement of bitstream conformance that the value of tg_end is
greater than or equal to tg_start.
Signed-off-by: James Almer
---
libavcodec/cbs_av1_syntax_template.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/
Signed-off-by: James Almer
---
libavcodec/codec2utils.c | 8
libavcodec/codec2utils.h | 14 +++---
libavcodec/libcodec2.c | 16
libavformat/codec2.c | 32
4 files changed, 35 insertions(+), 35 deletions(-)
diff --git a/lib
It's only used by the codec2 demuxers
Signed-off-by: James Almer
---
libavcodec/codec2utils.h | 5 -
libavformat/codec2.c | 5 +
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/libavcodec/codec2utils.h b/libavcodec/codec2utils.h
index e9b1f84d84..2ee7a592a1 100644
---
They are only used by the codec2 demuxers.
The symbols are kept around until the next major bump.
Signed-off-by: James Almer
---
libavcodec/codec2utils.c | 2 ++
libavcodec/codec2utils.h | 4 +++
libavformat/codec2.c | 66 ++--
3 files changed, 69 inser
On Tue, Oct 27, 2020 at 1:03 PM Anton Khirnov wrote:
>
> Quoting Jan Ekström (2020-10-16 15:16:47)
> > Additionally, reap the first rewards by being able to set the
> > color related encoding values based on the passed AVFrame.
> >
> > The only tests that seem to have changed their results with th
On Tue, Oct 27, 2020, 13:13 Anton Khirnov wrote:
>
> Quoting Jan Ekström (2020-10-16 15:16:48)
> > We now have the possibility of getting AVFrames here, and we should
> > not touch the muxer's codecpar after writing the header.
> > ---
> > fftools/ffmpeg.c | 27 ++
init.mp4 can be expanded with strftime() the same way as
hls_segment_filename.
Signed-off-by: Nikola Pajkovsky
---
v2: fix memleak on strftime failure
v3: use av_free() insted of free()
doc/muxers.texi | 7 ++
libavformat/hlsenc.c | 54 +++-
2
James Almer:
> It's only used by the codec2 demuxers
>
> Signed-off-by: James Almer
> ---
> libavcodec/codec2utils.h | 5 -
> libavformat/codec2.c | 5 +
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/libavcodec/codec2utils.h b/libavcodec/codec2utils.h
> index e
Fixes: Infinite loop
Fixes:
26576/clusterfuzz-testcase-minimized-ffmpeg_dem_GXF_fuzzer-4823080360476672
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavformat/gxf.c | 7 +--
1 file changed, 5 in
Fixes: shift exponent 95 is too large for 32-bit type 'int'
Fixes:
26590/clusterfuzz-testcase-minimized-ffmpeg_dem_SMACKER_fuzzer-5120609937522688
Signed-off-by: Michael Niedermayer
---
libavcodec/utils.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libavcodec/utils.c
Fixes: Fixes infinite loop
Fixes:
26575/clusterfuzz-testcase-minimized-ffmpeg_dem_AIFF_fuzzer-5727522236661760
Signed-off-by: Michael Niedermayer
---
libavformat/aiffdec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c
index c650e9074d..15733
Fixes: signed integer overflow: 11494 * 107374182400 cannot be represented
in type 'long'
Fixes:
26586/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PIXLET_fuzzer-5752633970917376
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-
On Tue, Oct 27, 2020 at 11:07:23AM +0100, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2020-10-26 19:01:47)
> > On Sun, Oct 25, 2020 at 01:55:11PM +0100, Anton Khirnov wrote:
> > > Quoting Michael Niedermayer (2020-10-19 23:57:31)
> > > > On Mon, Oct 19, 2020 at 07:22:48PM +0200, Jean-Baptis
On Tue, 27 Oct 2020, at 18:02, Michael Niedermayer wrote:
> > AFAIU we used schulze STV for the votes so far, right? So it seems
>
> do you think this ? hope it ? or did you check it ?
All the methods gave the same results.
--
Jean-Baptiste Kempf - President
+33 672 704 734
_
This patch set started with a very simple wish to not have to set color
related values manually each time when utilizing ffmpeg.c.
As of the fourth iteration, the following changes were done since the third:
1. The data size threshold patch was moved to be the first one, thus meaning
that there
This way the old max queue size limit based behavior for streams
where each individual packet is large is kept, while for smaller
streams more packets can be buffered (current default is at 50
megabytes per stream).
For some explanation, by default ffmpeg copies packets from before
the appointed s
- For video, this means a single initialization point in do_video_out.
- For audio we unfortunately need to do it in two places just
before the buffer sink is utilized (if av_buffersink_get_samples
would still work according to its specification after a call to
avfilter_graph_request_oldest w
This will have to be called later for video down the line.
---
fftools/ffmpeg.c | 72 +++-
1 file changed, 47 insertions(+), 25 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 3af189e7f2..498e5f08a6 100644
--- a/fftools/ffmpeg.c
+++
We now have the possibility of getting AVFrames here, and we should
not touch the muxer's codecpar after writing the header.
Results of FATE tests change as the MXF and Matroska muxers actually
write down the field/frame coding type of a stream in their
respective headers. Before this change, thes
Additionally, reap the first rewards by being able to set the
color related encoding values based on the passed AVFrame.
The only tests that seem to have changed their results with this
change seem to be the MXF tests. There, the muxer writes the
limited/full range flag to the output container if
Quoting Michael Niedermayer (2020-10-27 18:02:46)
>
> > AFAIU we used schulze STV for the votes so far, right? So it seems
>
> do you think this ? hope it ? or did you check it ?
It was my impression, because as I recall the vote was postponed so that
this method could be added to the software.
On 26/10/2020 22:04, Bohan Li wrote:
Add the option to use -enable-keyframe-filtering with libaom-av1
codec. The option controls the encoder behavior on performing
temporal filtering on keyframes.
Signed-off-by: Bohan Li
---
doc/encoders.texi | 13 +
libavcodec/libaomenc.c
Thanks for the comment, Mark. Indeed this may not be helpful for people who
did not know the background of such parameters. I added more details to it
so people could understand the trade-off behind it better. Will re-submit
the patch soon.
Best,
Bohan
On Tue, Oct 27, 2020 at 1:26 PM Mark Thompso
Add the option to use -enable-keyframe-filtering with libaom-av1
codec. The option controls the encoder behavior on performing
temporal filtering on keyframes.
Signed-off-by: Bohan Li
---
doc/encoders.texi | 17 +
libavcodec/libaomenc.c | 5 +
2 files changed, 22 inser
On 21/10/2020 01:11, James Almer wrote:
Partially implements of setup_past_independence() and load_previous().
These ensures they are always set, even if the values were not coded
in the input bitstream and will not be coded in the output bitstream.
Signed-off-by: James Almer
---
libavcodec/c
On 27/10/2020 13:49, James Almer wrote:
Section 6.10.1 of the AV1 spec states:
It is a requirement of bitstream conformance that the value of tg_end is
greater than or equal to tg_start.
Signed-off-by: James Almer
---
libavcodec/cbs_av1_syntax_template.c | 2 +-
1 file changed, 1 insertion
On 10/27/2020 5:09 PM, Mark Thompson wrote:
> On 27/10/2020 13:49, James Almer wrote:
>> Section 6.10.1 of the AV1 spec states:
>>
>> It is a requirement of bitstream conformance that the value of tg_end
>> is greater than or equal to tg_start.
>>
>> Signed-off-by: James Almer
>> ---
>> libavcod
On 21/10/2020 01:11, James Almer wrote:
Partially implements of setup_past_independence() and load_previous().
These ensures they are always set, even if the values were not coded
in the input bitstream and will not be coded in the output bitstream.
Signed-off-by: James Almer
---
libavcodec/c
On 10/27/2020 5:38 PM, Mark Thompson wrote:
> On 21/10/2020 01:11, James Almer wrote:
>> Partially implements of setup_past_independence() and load_previous().
>> These ensures they are always set, even if the values were not coded
>> in the input bitstream and will not be coded in the output bitst
On 17/10/2020 20:30, James Almer wrote:
Signed-off-by: James Almer
---
libavcodec/av1dec.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
index 54aeba1812..04aaf5d148 100644
--- a/libavcodec/av1dec.c
+++ b/libavcodec/av1d
On 10/27/2020 5:57 PM, Mark Thompson wrote:
> On 17/10/2020 20:30, James Almer wrote:
>> Signed-off-by: James Almer
>> ---
>> libavcodec/av1dec.c | 9 +++--
>> 1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
>> index 54aeba1812..0
On 27/10/2020 21:01, James Almer wrote:
On 10/27/2020 5:57 PM, Mark Thompson wrote:
On 17/10/2020 20:30, James Almer wrote:
Signed-off-by: James Almer
---
libavcodec/av1dec.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/libavcodec/av1dec.c b/libavcodec/av1d
On 10/27/2020 6:04 PM, Mark Thompson wrote:
> On 27/10/2020 21:01, James Almer wrote:
>> On 10/27/2020 5:57 PM, Mark Thompson wrote:
>>> On 17/10/2020 20:30, James Almer wrote:
Signed-off-by: James Almer
---
libavcodec/av1dec.c | 9 +++--
1 file changed, 7 insertions(+
On Tue, Oct 27, 2020 at 10:38 PM Bohan Li
wrote:
>
> Add the option to use -enable-keyframe-filtering with libaom-av1
> codec. The option controls the encoder behavior on performing
> temporal filtering on keyframes.
>
Hi,
Looking at the amount of options etc which you want to expose to
FFmpeg
On 27/10/2020 20:53, James Almer wrote:
On 10/27/2020 5:38 PM, Mark Thompson wrote:
On 21/10/2020 01:11, James Almer wrote:
Partially implements of setup_past_independence() and load_previous().
These ensures they are always set, even if the values were not coded
in the input bitstream and will
Section 6.10.1 of the AV1 spec states:
It is a requirement of bitstream conformance that the value of tg_start is
equal to the value of TileNum at the point that tile_group_obu is invoked.
It is a requirement of bitstream conformance that the value of tg_end is
greater than or equal to tg_start.
Hi! could you please review and accept this patch? It fixes a broken AMF
hwaccel pipeline.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ
Hi Jan,
Thanks for the suggestion! I believe that is a good idea. I am not super
familiar with this part, though, so will probably need to propose this to
the Aomedia issue tracker.
Meanwhile I think it is also useful to expose useful options (like this
one, enable-keyframe-filtering, which is dis
On 10/27/2020 12:47 PM, Andreas Rheinhardt wrote:
> James Almer:
>> It's only used by the codec2 demuxers
>>
>> Signed-off-by: James Almer
>> ---
>> libavcodec/codec2utils.h | 5 -
>> libavformat/codec2.c | 5 +
>> 2 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/li
Hi Anton,
Thanks for responding!
- For more information on URI length standards for the web domain, this
link provides a good explanation:
https://stackoverflow.com/questions/417142/what-is-the-maximum-length-of-a-url-in-different-browsers
Simply speaking there are no set standards for the m
On Tue, Oct 27, 2020 at 05:21:19PM +0100, Michael Niedermayer wrote:
> Fixes: shift exponent 95 is too large for 32-bit type 'int'
> Fixes:
> 26590/clusterfuzz-testcase-minimized-ffmpeg_dem_SMACKER_fuzzer-5120609937522688
>
> Signed-off-by: Michael Niedermayer
> ---
> libavcodec/utils.c | 5 +++
From: Limin Wang
change to first_pts_checked and reverse the logic.
Signed-off-by: Limin Wang
---
libavformat/mpegtsenc.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c
index 29dcaf6..383181d 100644
--- a/libavforma
From: Limin Wang
Signed-off-by: Limin Wang
---
libavformat/mpegtsenc.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c
index 383181d..acc8c32 100644
--- a/libavformat/mpegtsenc.c
+++ b/libavformat/mpegtsenc.c
@@ -233,6 +233,7 @@ typed
Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/clearvideo.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/libavcodec/clearvideo.c b/libavcodec/clearvideo.c
> index 65bf140401..73c0367f71 100644
> --- a/libavcodec/clearvideo.c
> +++ b/libavcodec/clearvideo.
60 matches
Mail list logo
