Re: [FFmpeg-devel] [PATCH 1/4] avcodec/atrac3plus: Perform reusing of VLCs during init

2020-10-26 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/atrac3plus.c | 10 +++--- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/atrac3plus.c b/libavcodec/atrac3plus.c > index 8d17889582..6b046a887e 100644 > --- a/libavcodec/atrac3plus.c > ++

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/atrac3: Don't use too big VLC tables

2020-10-26 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The longest code of any of the VLC tables used is eight bits long, so > using nine bits long VLC tables is wasteful. Furthermore, there are only > seven VLC tables used, yet the code up until now made it look like there > should be eight. This has been corrected, too. > > Sig

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/webp: Use uint8_t for code lengths

2020-10-26 Thread Andreas Rheinhardt
Andreas Rheinhardt: > They are always in the range 0..15, so using an int is not necessary. > Furthermore, using an int would not work if sizeof(int) == 4 as > ff_init_vlc_sparse() can only handle uint8_t, uint16_t and uint32_t > lengths. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/

Re: [FFmpeg-devel] [PATCH] Preventing Buffer Overflow for RTSP Links Increasing the buffer size of control uri, used when storing the input argument RTSP link. Following the Web URI standards, lengths

2020-10-26 Thread Anton Khirnov
Hi, Quoting g...@yigituyan.com (2020-10-21 20:17:18) > Hi, I've just checked the state of this patch on Patchwork. There are > three builds listed, two successful and one warning. I've checked the > logs for the warning, none seems to be about the submitted patch. I've > also thoroughly tested t

Re: [FFmpeg-devel] [PATCH 8/8] avcodec/dirac_parser: do not offset AV_NOPTS_OFFSET

2020-10-26 Thread Michael Niedermayer
On Fri, Oct 23, 2020 at 08:39:40PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -9223372036854775807 - 48000 cannot be > represented in type 'long long' > Fixes: > 26521/clusterfuzz-testcase-minimized-ffmpeg_dem_DIRAC_fuzzer-5635536506847232 > > Found-by: continuous fuzzin

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/webp: Use uint8_t for code lengths

2020-10-26 Thread zhilizhao(赵志立)
> On Oct 26, 2020, at 3:24 PM, Andreas Rheinhardt > wrote: > > Andreas Rheinhardt: >> They are always in the range 0..15, so using an int is not necessary. >> Furthermore, using an int would not work if sizeof(int) == 4 as You mean if sizeof(int) != 4 ? >> ff_init_vlc_sparse() can only handl

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/webp: Use uint8_t for code lengths

2020-10-26 Thread Andreas Rheinhardt
"zhilizhao(赵志立)": > > >> On Oct 26, 2020, at 3:24 PM, Andreas Rheinhardt >> wrote: >> >> Andreas Rheinhardt: >>> They are always in the range 0..15, so using an int is not necessary. >>> Furthermore, using an int would not work if sizeof(int) == 4 as > > You mean if sizeof(int) != 4 ? > Good

[FFmpeg-devel] How do I add the starttime and totalduration DOUBLE-type metadata to FLV files?

2020-10-26 Thread Ben Hutchinson
Google's standard for FLV (as used on older versions of YouTube player and Google Video player) involves at least 2 additional metadata tags. These are starttime and totalduration. The value for starttime should be 0, and totalduration should be equal to the official Adobe Flash Video standard "dur

[FFmpeg-devel] [PATCH 2/3] avcodec/vp3: Don't check for errors for complete VLC

2020-10-26 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/vp3.c | 5 - 1 file changed, 5 deletions(-) diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index 51be4ebf05..c4ad43a299 100644 --- a/libavcodec/vp3.c +++ b/libavcodec/vp3.c @@ -682,11 +682,6 @@ static int vp4_get_mb_count(Vp3DecodeContext *s

[FFmpeg-devel] [PATCH 1/3] avcodec/cllc: Don't unnecessarily free VLC

2020-10-26 Thread Andreas Rheinhardt
The Canopus Lossless decoder uses several VLCs and if initializing the ith VLC fails, all the VLCs 0..i have been freed; the ith VLC's table is initialized to NULL for this purpose. Yet it is totally unnecessary to free the ith VLC table at all: ff_init_vlc_sparse() cleans up after itself on error

[FFmpeg-devel] [PATCH 3/3] avcodec/bitstream: Consistently treat symbol as VLC_TYPE

2020-10-26 Thread Andreas Rheinhardt
If a static VLC table gets initialized a second time (or concurrently by two threads) and if said VLC table uses symbols that have the sign bit of VLC_TYPE (a typedef for int16_t) set, initializing the VLC fails. The reason is that the type of the symbol in the temporary array is an uint16_t and so

[FFmpeg-devel] [PATCH v3 2/3] avformat/mpegtsenc: make first_pcr sync with the first valid dts

2020-10-26 Thread lance . lmwang
From: Limin Wang now first_pts assume dts will start from zero, if it's not true(copyts is enable), too many null packet will be inserted for cbr output. Please test with below command, you'll get huge test.ts without the patch: ./ffmpeg -y -copyts -i ../fate-suite/mpegts/loewe.ts -c:v libx264

[FFmpeg-devel] [PATCH 3/6] put_bits: make avpriv_align_put_bits() inline

2020-10-26 Thread Anton Khirnov
This function is so extremely simple that it is preferable to make it inline rather than deal with all the complications arising from it being an exported symbol. Keep avpriv_align_put_bits() around until the next major bump to preserve ABI compatibility. --- libavcodec/aacenc.c | 4 ++-- li

[FFmpeg-devel] [PATCH 5/6] put_bits: make avpriv_copy_bits() lavc-local

2020-10-26 Thread Anton Khirnov
It is not used outside of lavc anymore. Keep the avpriv exported symbol around until the next bump to preserve ABI compatibility. --- libavcodec/bitstream.c | 6 +- libavcodec/mpeg4videoenc.c | 4 ++-- libavcodec/mpegvideo_enc.c | 8 libavcodec/put_bits.h | 5 +++-- libav

[FFmpeg-devel] [PATCH 4/6] put_bits: make avpriv_put_string() lavc-local

2020-10-26 Thread Anton Khirnov
It has not been used outside of libavcodec since 20f325f320c6e18ee88983870d2a1fee94257293 --- libavcodec/aacenc.c | 2 +- libavcodec/bitstream.c | 3 +-- libavcodec/mjpegenc_common.c | 6 +++--- libavcodec/mpeg4videoenc.c | 2 +- libavcodec/put_bits.h| 4 ++-- libavcodec/v

[FFmpeg-devel] [PATCH 6/6] lavc: un-avpriv avpriv_bprint_to_extradata()

2020-10-26 Thread Anton Khirnov
It has not been used outside of lavc since 6f69f7a8bf6. Also, move it to the only place where it is used. --- libavcodec/dvdsubenc.c | 25 - libavcodec/internal.h | 5 - libavcodec/utils.c | 23 --- 3 files changed, 24 insertions(+), 29 deleti

[FFmpeg-devel] [PATCH 1/6] lavf/latmenc: fix units mismatch

2020-10-26 Thread Anton Khirnov
avpriv_copy_bits() takes the size in bits, not bytes. According to a736eb4a605f46d5ff96c7b32e55710ecd9cce89, nobody is quite sure whether this code produces working files. --- libavformat/latmenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/latmenc.c b/libavfor

[FFmpeg-devel] [PATCH 2/6] lavf/latmenc: use a local simplified copy of avpriv_copy_bits()

2020-10-26 Thread Anton Khirnov
This is the only place in lavf where avpriv_copy_bits() is used, so this allows us to make avpriv_copy_bits() lavc-local. --- libavformat/latmenc.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/libavformat/latmenc.c b/libavformat/latmenc.c index 684483bc7

Re: [FFmpeg-devel] [PATCH 3/6] put_bits: make avpriv_align_put_bits() inline

2020-10-26 Thread Andreas Rheinhardt
Anton Khirnov: > This function is so extremely simple that it is preferable to make it > inline rather than deal with all the complications arising from it being > an exported symbol. > > Keep avpriv_align_put_bits() around until the next major bump to > preserve ABI compatibility. > --- > libavc

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: constrained intra predict, do not check top left IS_INTRA if it's not available

2020-10-26 Thread Guangxin Xu
The bug reporter confirmed the fix. https://trac.ffmpeg.org/ticket/8932 ping for review and merge. thanks On Fri, Oct 16, 2020 at 9:57 PM Xu Guangxin wrote: > fix ticket: 8932 > > For poc 2, we have tile boundary at x = 640. > When we predict cu(640,912),the top left pixel is not avaliable to t

Re: [FFmpeg-devel] [PATCHv2] Document community process

2020-10-26 Thread Michael Niedermayer
On Sun, Oct 25, 2020 at 01:55:11PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-10-19 23:57:31) > > On Mon, Oct 19, 2020 at 07:22:48PM +0200, Jean-Baptiste Kempf wrote: > > > Yo, > > > > > > On Mon, 19 Oct 2020, at 19:02, Michael Niedermayer wrote: > > > > > +## Voting > > > > >

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/av1dec: Check for unset obu instead of crashing

2020-10-26 Thread Michael Niedermayer
On Sun, Oct 25, 2020 at 09:00:53PM -0300, James Almer wrote: > On 10/25/2020 8:00 PM, Michael Niedermayer wrote: > > Fixes: NULL pointer dereference > > Fixes: > > 26550/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AV1_fuzzer-5417762807349248 > > > > Found-by: continuous fuzzing process > >

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

2020-10-26 Thread Mohammad Izadi
Thank you, Jan! I hope you feel better soon. On Sun, Oct 25, 2020 at 5:49 PM Jan Ekström wrote: > On Wed, Oct 14, 2020 at 2:54 AM Mohammad Izadi > wrote: > > > > From: Mohammad Izadi > > > > HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs > to be decoded from ITU-T T.3

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/mpegtsenc: make first_pcr sync with the first valid dts

2020-10-26 Thread Marton Balint
On Mon, 26 Oct 2020, lance.lmw...@gmail.com wrote: From: Limin Wang now first_pts assume dts will start from zero, if it's not true(copyts is enable), too many null packet will be inserted for cbr output. Please test with below command, you'll get huge test.ts without the patch: ./ffmpeg -

[FFmpeg-devel] [PATCH] avcodec/rkmpp : reset end of stream flag on flush

2020-10-26 Thread David Sowa
Currently the flag eos_reached is set to 1 on end of stream and there is no mechanism to reset it to 0. After a flush new buffers should be able to be decoded but the eos_reached flag causes all the frames to be dropped. Reset the eos_reached flag to 0 during the flush operation to allow new frames

[FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-26 Thread Bohan Li
Signed-off-by: Bohan Li --- libavcodec/libaomenc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index 2b0581b15a..a5d9843ae2 100644 --- a/libavcodec/libaomenc.c +++ b/libavcodec/libaomenc.c @@ -124,6 +124,7 @@ typedef struct AOMEncoderCo

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-26 Thread James Almer
On 10/26/2020 6:01 PM, Bohan Li wrote: > Signed-off-by: Bohan Li > --- > libavcodec/libaomenc.c | 5 + > 1 file changed, 5 insertions(+) Missing documentation. > > diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c > index 2b0581b15a..a5d9843ae2 100644 > --- a/libavcodec/libaomen

[FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-26 Thread Bohan Li
Add the option to use -enable-keyframe-filtering with libaom-av1 codec. The option controls the encoder behavior on performing temporal filtering on keyframes. Signed-off-by: Bohan Li --- libavcodec/libaomenc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/libaomenc.c b/li

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-26 Thread Bohan Li
Thank you for the prompt response! I'll fix the typo, add documentation and re-submit. Regarding the last comment, the enable-keyframe-filtering parameter was a boolean, but recently there is one more option added to libaom (--enable-keyframe-filtering=2), so I thought it would be better to use A

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-26 Thread James Almer
On 10/26/2020 6:21 PM, Bohan Li wrote: > Regarding the last comment, the enable-keyframe-filtering parameter was a > boolean, but recently there is one more option added to libaom > (--enable-keyframe-filtering=2), so I thought it would be better to use > AV_OPT_TYPE_INT here so people who build

[FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-26 Thread Bohan Li
Add the option to use -enable-keyframe-filtering with libaom-av1 codec. The option controls the encoder behavior on performing temporal filtering on keyframes. Signed-off-by: Bohan Li --- doc/encoders.texi | 13 + libavcodec/libaomenc.c | 5 + 2 files changed, 18 insertion

Re: [FFmpeg-devel] [PATCH] Add enable_keyframe_filtering option for libaom-av1 encoder.

2020-10-26 Thread Bohan Li
Thanks a lot for the explanation! I'll add the documentation accordingly. Best, Bohan On Mon, Oct 26, 2020 at 2:46 PM James Almer wrote: > On 10/26/2020 6:21 PM, Bohan Li wrote: > > > Regarding the last comment, the enable-keyframe-filtering parameter was a > > boolean, but recently there is on

Re: [FFmpeg-devel] [PATCH 6/6] lavc: un-avpriv avpriv_bprint_to_extradata()

2020-10-26 Thread James Almer
On 10/26/2020 10:41 AM, Anton Khirnov wrote: > It has not been used outside of lavc since 6f69f7a8bf6. > > Also, move it to the only place where it is used. Shouldn't you keep the symbol around until the bump? Even though it was not used by other libraries, it was nonetheless still exported by la

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/mpegtsenc: make first_pcr sync with the first valid dts

2020-10-26 Thread lance . lmwang
On Mon, Oct 26, 2020 at 09:13:08PM +0100, Marton Balint wrote: > > > On Mon, 26 Oct 2020, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > now first_pts assume dts will start from zero, if it's not true(copyts is > > enable), > > too many null packet will be inserted for cbr outpu

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: constrained intra predict, do not check top left IS_INTRA if it's not available

2020-10-26 Thread Linjie Fu
On Mon, Oct 26, 2020 at 10:29 PM Guangxin Xu wrote: > The bug reporter confirmed the fix. > https://trac.ffmpeg.org/ticket/8932 > > ping for review and merge. > thanks > > On Fri, Oct 16, 2020 at 9:57 PM Xu Guangxin wrote: > > > fix ticket: 8932 > > > > For poc 2, we have tile boundary at x = 64

[FFmpeg-devel] How to parse the audio payload in AudioMuxElement of LATM to multiple avstreams?

2020-10-26 Thread shiguang...@outlook.com
Hello, I'm a newer ffmepg. I recently wanted to try to implement a latm demuxer. Now I have a problem. Because a latm's AudioMuxElement() contains multiple aac streams of payload() and AudioSpecificConfig(). How can I store these payloads with the correct stream_index when reading an AudioMuxE