[FFmpeg-devel] ION MP4 causing issues

2020-10-18 Thread Matthias Opitz
Experts, I am capturing mp4 files since several years with an ION SPEED PRO without any issues. I did not use the camera a while. Today I realized that either W10 (tested different laptops) and even Linux ins not able to play these files any more. Old ION files ( same device) still do work pr

[FFmpeg-devel] [PATCH] avfilter: add frequency and phase shift filters

2020-10-18 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- Now with better output quality. --- doc/filters.texi| 30 +++ libavfilter/Makefile| 2 + libavfilter/af_afreqshift.c | 379 libavfilter/allfilters.c| 2 + 4 files changed, 413 insertions(+) create m

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/photocd: Use ff_set_dimensions()

2020-10-18 Thread Michael Niedermayer
On Sat, Oct 10, 2020 at 01:00:14PM +0200, Michael Niedermayer wrote: > On Mon, Sep 21, 2020 at 12:28:37AM +0200, Paul B Mahol wrote: > > On Sun, Sep 20, 2020 at 10:26:08PM +0200, Michael Niedermayer wrote: > > > Fixes: out of memory > > > Fixes: > > > 25588/clusterfuzz-testcase-minimized-ffmpeg_AV

Re: [FFmpeg-devel] [PATCH 2/2] avformat/rmdec: sanity check coded_framesize

2020-10-18 Thread Michael Niedermayer
On Sun, Aug 16, 2020 at 08:04:09PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -14671840 * 8224 cannot be represented in > type 'int' > Fixes: > 24793/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5101884323659776 > > Found-by: continuous fuzzing process > https:/

Re: [FFmpeg-devel] [PATCH] avformat/ape: Remove seektable and bittable

2020-10-18 Thread Michael Niedermayer
On Sat, Jul 25, 2020 at 08:02:40PM +0200, Michael Niedermayer wrote: > Suggested-by: Andreas > Signed-off-by: Michael Niedermayer > --- > libavformat/ape.c | 75 --- > 1 file changed, 25 insertions(+), 50 deletions(-) will apply [...] -- Michael

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg12dec: Limit maximum A53 CC size

2020-10-18 Thread Michael Niedermayer
On Tue, Sep 22, 2020 at 10:33:14AM +0200, Michael Niedermayer wrote: > This is more than 10 times the size of the largest i found. And also alot more > than our encoder could handle (our encoder is limited to max 31) > Without any limit megabyte+ sized blocks can be reallocated millions of times. >

Re: [FFmpeg-devel] [PATCH 4/6] tools/target_dec_fuzzer: Correct maxsamples_per_frame if maxsamples has been changed

2020-10-18 Thread Michael Niedermayer
On Sat, Sep 26, 2020 at 12:26:36AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > tools/target_dec_fuzzer.c | 1 + > 1 file changed, 1 insertion(+) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting code that i

Re: [FFmpeg-devel] [PATCH 5/6] tools/target_dec_fuzzer: assume that discarded audio packets produced max samples

2020-10-18 Thread Michael Niedermayer
On Sat, Sep 26, 2020 at 12:26:37AM +0200, Michael Niedermayer wrote: > We do not know how many samples these produce as its not exported. > Alternatively we could export that but as long as its not we better > assume its more than 0 as otherwise the thresholds would not work > > Signed-off-by: Mic

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/decode: Consider discarded samples in max_samples

2020-10-18 Thread Michael Niedermayer
On Sat, Sep 26, 2020 at 12:26:38AM +0200, Michael Niedermayer wrote: > Fixes: Timeout (several minutes -> 3 sec) > Fixes: > 25246/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5943400661254144 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/maste

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h264_slice: fix undefined integer overflow with POC in error concealment

2020-10-18 Thread Michael Niedermayer
On Thu, Oct 08, 2020 at 09:19:13PM +0200, Michael Niedermayer wrote: > Alternatively the POC could be changed to 64bit. the large values seem to be > within what is allowed. > > Fixes: signed integer overflow: 2147483646 + 2 cannot be represented in type > 'int' > Fixes: > 26076/clusterfuzz-tes

Re: [FFmpeg-devel] [PATCH 2/2] avformat/kvag: Fix integer overflow in bitrate computation

2020-10-18 Thread Michael Niedermayer
On Sat, Oct 10, 2020 at 05:41:27PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 1077952576 * 4 cannot be represented in type > 'int' > Fixes: > 26152/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5674758518341632 > > Found-by: continuous fuzzing process > https://g

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec_fixed: Limit index in vector_pow43()

2020-10-18 Thread Michael Niedermayer
On Mon, Oct 12, 2020 at 05:54:27PM +0200, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 26087/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5724825462767616 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/project

Re: [FFmpeg-devel] ION MP4 causing issues

2020-10-18 Thread Carl Eugen Hoyos
Am So., 18. Okt. 2020 um 16:38 Uhr schrieb Matthias Opitz : > I am capturing mp4 files since several years with an ION SPEED PRO > without any issues. I did not use the camera a while. Today I realized > that either W10 (tested different laptops) and even Linux ins not able > to play these files a

Re: [FFmpeg-devel] [PATCH v1] libavformat/hls: During operation, the user exits and interrupts, causing pls->segment to be released, resulting in a null pointer crash

2020-10-18 Thread 徐慧书
Steven Liu 于2020年10月17日周六 下午4:57写道: > > > > 在 2020年10月17日,13:38,徐慧书 写道: > > > > Andreas Rheinhardt 于2020年10月16日周五 > 下午9:32写道: > > > >> javashu2...@gmail.com: > >>> From: bevis > >>> > >>> Signed-off-by: bevis > >>> --- > >>> libavformat/hls.c | 5 +++-- > >>> 1 file changed, 3 insertions(+), 2

[FFmpeg-devel] [PATCH v2] libavformat/hls: use local var url for log to avoid crash

2020-10-18 Thread javashu2012
From: bevis During operation, the user exits and interrupts, causing pls->segment to be released, resulting in a null pointer crash Signed-off-by: bevis --- libavformat/hls.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 7

[FFmpeg-devel] [PATCH 1/1] libavformat/mov: Add bound checks to avoid integer overflow and invalid memory allocation

2020-10-18 Thread Xiaohui Zhang
From: Zhang Xiaohui Hi, I think function mov_read_cmov fails to perform proper bounds checking on atom.size and cmov_len, which may lead to integer overflow and invalid memory allocation. Signed-off-by: Zhang Xiaohui --- libavformat/mov.c | 4 1 file changed, 4 insertions(+) diff --git a

Re: [FFmpeg-devel] [PATCH] libavformat/hls: add support for SAMPLE-AES decryption in HLS demuxer

2020-10-18 Thread Steven Liu
Nachiket Tarate 于2020年10月18日周日 上午8:07写道: > > ___ > From: ffmpeg-devel on behalf of Michael > Niedermayer > Sent: Thursday, October 15, 2020 11:35 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] libavformat/hls: add su

Re: [FFmpeg-devel] [PATCH 01/11] avcodec/movtextdec: Reset counter of fonts when freeing them

2020-10-18 Thread Philip Langdale
On Sat, 17 Oct 2020 20:22:38 +0200 Andreas Rheinhardt wrote: > If allocating fonts fails when reading the header, all fonts are > freed, yet the counter of fonts is not reset and no error is > returned; when subtitles are decoded lateron, the inexistent list of > fonts is searched for the matchin

[FFmpeg-devel] [PATCH 1/1] libavformat/mov: Add bound checks to avoid invalid memory allocation

2020-10-18 Thread Xiaohui Zhang
From: Zhang Xiaohui Hi, I think function mov_read_cmov fails to perform proper bounds checking on cmov_len, which may lead to invalid memory allocation. Signed-off-by: Zhang Xiaohui --- libavformat/mov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.

[FFmpeg-devel] [PATCH] tests/audiomatch: removes a warning when compiling tests/audiomatch

2020-10-18 Thread liuqi05
the warning message: warning: using floating point absolute value function 'fabs' when argument is of integer type use FFABS to set the absolute value. Signed-off-by: liuqi05 --- tests/audiomatch.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/audiomatch.c b/te

Re: [FFmpeg-devel] [PATCH v1] libavcodec/pthread_frame: fix crash that call method ff_frame_thread_init failed because of mem insufficient

2020-10-18 Thread 徐慧书
Andreas Rheinhardt 于2020年10月16日周五 下午4:46写道: > javashu2...@gmail.com: > > From: xuhuishu > > > > Signed-off-by: xuhuishu > > --- > > libavcodec/pthread_frame.c | 23 --- > > 1 file changed, 12 insertions(+), 11 deletions(-) > > > > diff --git a/libavcodec/pthread_frame.c b/l

Re: [FFmpeg-devel] [PATCH v1] libavformat/hls: During operation, the user exits and interrupts, causing pls->segment to be released, resulting in a null pointer crash

2020-10-18 Thread 徐慧书
Andreas Rheinhardt 于2020年10月16日周五 下午9:32写道: > javashu2...@gmail.com: > > From: bevis > > > > Signed-off-by: bevis > > --- > > libavformat/hls.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/libavformat/hls.c b/libavformat/hls.c > > index 72e28ab94f..0a522a