Re: [FFmpeg-devel] [PATCH v1] lavf/url: fix rel path’s query string contains :/

2020-10-16 Thread Nicolas George
蔡昊凝 (12020-10-16): > Scheme can't contain ?. Scheme in standard URLs cannot contain ?, but these are not standard URLs, and the protocol part can contain ?. > Marton Balint 于2020年10月16日周五 上午3:15写道: Please remember that top-posting is not allowed here; if you don't know what it means look it up.

[FFmpeg-devel] [PATCH v1] libavcodec/pthread_frame: fix crash that call method ff_frame_thread_init failed because of mem insufficient

2020-10-16 Thread javashu2012
From: xuhuishu Signed-off-by: xuhuishu --- libavcodec/pthread_frame.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c index f8a01ad8cd..2babeb4a6a 100644 --- a/libavcodec/pthread_frame.c +++ b/

Re: [FFmpeg-devel] [PATCH 5/5] fate: add test for adpcm_swf in wav

2020-10-16 Thread Zane van Iperen
On 16/10/20 4:23 pm, Zane van Iperen wrote: > > Signed-off-by: Zane van Iperen > --- > tests/fate/acodec.mak | 7 +-- > tests/ref/acodec/adpcm-swf-flv | 4 > tests/ref/acodec/adpcm-swf-wav | 4 > 3 files changed, 13 insertions(+), 2 deletions(-) > create mode 100644

Re: [FFmpeg-devel] [PATCH v1] lavf/url: fix rel path’s query string contains :/

2020-10-16 Thread Nicolas George
Marton Balint (12020-10-15): > Why not simply add ? and # to the list of delimiters instead? > > Nevertheless that would disallow ? and # in lavf specific scheme options. Is > it an acceptable tradeoff? I think that would be an acceptable constraint, and I think it is a more correct fix indeed.

[FFmpeg-devel] [PATCH v1.1 5/5] fate: add test for adpcm_swf in wav

2020-10-16 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- tests/fate/acodec.mak | 4 tests/ref/acodec/adpcm-swf-wav | 4 2 files changed, 8 insertions(+) create mode 100644 tests/ref/acodec/adpcm-swf-wav diff --git a/tests/fate/acodec.mak b/tests/fate/acodec.mak index 50932095dc..8ac71b1b27 100644

Re: [FFmpeg-devel] [PATCH v1] libavcodec/pthread_frame: fix crash that call method ff_frame_thread_init failed because of mem insufficient

2020-10-16 Thread Andreas Rheinhardt
javashu2...@gmail.com: > From: xuhuishu > > Signed-off-by: xuhuishu > --- > libavcodec/pthread_frame.c | 23 --- > 1 file changed, 12 insertions(+), 11 deletions(-) > > diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c > index f8a01ad8cd..2babeb4a6a 10064

[FFmpeg-devel] [PATCH v4] Unbreak av_malloc_max(0) API/ABI

2020-10-16 Thread Joakim Tjernlund
From https://bugs.chromium.org/p/chromium/issues/detail?id=1095962 This seems to be caused by the custom handling of "av_max_alloc(0)" in Chromium's ffmpeg fork to mean unlimited (added in [1]). Upstream ffmpeg doesn't treat 0 as a special value; versions before 4.3 s

[FFmpeg-devel] [PATCH v1] libavcodec/pthread_frame: fix crash that call method ff_frame_thread_init failed because of mem insufficient

2020-10-16 Thread javashu2012
From: bevis Signed-off-by: bevis --- libavcodec/pthread_frame.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c index f8a01ad8cd..2babeb4a6a 100644 --- a/libavcodec/pthread_frame.c +++ b/libavc

Re: [FFmpeg-devel] [PATCH v3] Unbreak av_malloc_max(0) API/ABI

2020-10-16 Thread Joakim Tjernlund
On Fri, 2020-10-16 at 01:38 +0200, Andreas Rheinhardt wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > Joakim Tjernlund: > > From > > https://nam11.safelinks.

Re: [FFmpeg-devel] [PATCH v1] lavf/url: fix rel path’s query string contains :/

2020-10-16 Thread 蔡昊凝
Although not a standard URL, is it necessary that protocol can contain "?" Regards, Nicolas George 于2020年10月16日周五 下午4:13写道: > 蔡昊凝 (12020-10-16): > > Scheme can't contain ?. > > Scheme in standard URLs cannot contain ?, but these are not standard > URLs, and the protocol part can contain ?. > >

[FFmpeg-devel] [PATCH 1/3] avformat/av1dec: Fix padding in obu_get_packet()

2020-10-16 Thread Michael Niedermayer
Fixes: stack buffer overflow (read) Fixes: 26369/clusterfuzz-testcase-minimized-ffmpeg_dem_VIVIDAS_fuzzer-5721057325219840 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/av1dec.c | 2 +- 1 f

[FFmpeg-devel] [PATCH 3/3] tools/target_dem_fuzzer: Set format independent of c

2020-10-16 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- tools/target_dem_fuzzer.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/target_dem_fuzzer.c b/tools/target_dem_fuzzer.c index 79d572a6dc..a4d69bb230 100644 --- a/tools/target_dem_fuzzer.c +++ b/tools/target_dem_fuzzer.c @@

[FFmpeg-devel] [PATCH 2/3] avformat/asfdec_f: Check for negative ext_len

2020-10-16 Thread Michael Niedermayer
Fixes: Infinite loop Fixes: 26376/clusterfuzz-testcase-minimized-ffmpeg_dem_PCM_U32LE_fuzzer-6050518830678016 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/asfdec_f.c | 2 ++ 1 file changed

Re: [FFmpeg-devel] [PATCH v1] lavf/url: fix rel path’s query string contains :/

2020-10-16 Thread Nicolas George
蔡昊凝 (12020-10-16): > Although not a standard URL, is it necessary that protocol can contain "?" > > Regards, > > Nicolas George 于2020年10月16日周五 下午4:13写道: Please remember that top-posting is not allowed here; if you don't know what it means look it up. -- Nicolas George signature.asc Descri

Re: [FFmpeg-devel] [PATCH 3/3] tools/target_dem_fuzzer: Set format independent of c

2020-10-16 Thread Michael Niedermayer
On Fri, Oct 16, 2020 at 12:46:14PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > tools/target_dem_fuzzer.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) I intend to apply this one soon as it should fix the fuzzer behaving a bit broken [...] --

Re: [FFmpeg-devel] [PATCH 1/3] avformat/av1dec: Fix padding in obu_get_packet()

2020-10-16 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: stack buffer overflow (read) > Fixes: > 26369/clusterfuzz-testcase-minimized-ffmpeg_dem_VIVIDAS_fuzzer-5721057325219840 > Sure this is the right testcase? > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Sig

[FFmpeg-devel] [PATCH 1/3] avcodec/hevc_mvs: Cleanup ff_hevc_set_neighbour_available()

2020-10-16 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/hevc_mvs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/hevc_mvs.c b/libavcodec/hevc_mvs.c index fd0dbd9a56..1f6ca5a314 100644 --- a/libavcodec/hevc_mvs.c +++ b/libavcodec/hevc_mvs.c @@ -48,9 +48,9 @@ void ff_

[FFmpeg-devel] [PATCH 3/3] avcodec/utils: Check for overflow with ATRAC* in get_audio_frame_duration()

2020-10-16 Thread Michael Niedermayer
Fixes: signed integer overflow: 1024 * 13129048 cannot be represented in type 'int' Fixes: 26378/clusterfuzz-testcase-minimized-ffmpeg_dem_CODEC2RAW_fuzzer-5634018353348608 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 2/3] avcodec/hevcpred_template: Fix diagonal chroma availability in 4:2:2 edge case in intra_pred

2020-10-16 Thread Michael Niedermayer
Fixes: pixel decode issue.ts Fixes: raw frame.hevc Signed-off-by: Michael Niedermayer --- libavcodec/hevcpred_template.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/hevcpred_template.c b/libavcodec/hevcpred_template.c index 6fe33546b1..f1a1f4c1f0 100644 --

[FFmpeg-devel] [PATCH v2] libavcodec/pthread_frame: fix crash that call method ff_frame_thread_init failed because of mem insufficient

2020-10-16 Thread javashu2012
From: bevis Start planning to submit in two, This is my complete modification. Signed-off-by: bevis --- libavcodec/pthread_frame.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c index f8

Re: [FFmpeg-devel] [PATCH v1] lavf/url: fix rel path’s query string contains :/

2020-10-16 Thread 蔡昊凝
Excuse me, what does this mean for your last reply. I submitted the patch for the first time. Regards, Nicolas George 于2020年10月16日周五 下午6:55写道: > 蔡昊凝 (12020-10-16): > > Although not a standard URL, is it necessary that protocol can contain > "?" > > > > Regards, > > > > Nicolas George 于2020年10月

[FFmpeg-devel] [PATCH v1] libavformat/hls: During operation, the user exits and interrupts, causing pls->segment to be released, resulting in a null pointer crash

2020-10-16 Thread javashu2012
From: bevis Signed-off-by: bevis --- libavformat/hls.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 72e28ab94f..0a522a4595 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1979,17 +1979,18 @@ static int hls_read_h

Re: [FFmpeg-devel] [PATCH 1/3] avformat/av1dec: Fix padding in obu_get_packet()

2020-10-16 Thread Michael Niedermayer
On Fri, Oct 16, 2020 at 01:20:15PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: stack buffer overflow (read) > > Fixes: > > 26369/clusterfuzz-testcase-minimized-ffmpeg_dem_VIVIDAS_fuzzer-5721057325219840 > > > > Sure this is the right testcase? yes, thats related to the ot

Re: [FFmpeg-devel] [PATCH 1/3] avformat/av1dec: Fix padding in obu_get_packet()

2020-10-16 Thread James Almer
On 10/16/2020 7:46 AM, Michael Niedermayer wrote: > Fixes: stack buffer overflow (read) > Fixes: > 26369/clusterfuzz-testcase-minimized-ffmpeg_dem_VIVIDAS_fuzzer-5721057325219840 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-of

Re: [FFmpeg-devel] [PATCH V2] dnn_backend_tf.c: add option sess_config for tf backend

2020-10-16 Thread Guo, Yejun
> -Original Message- > From: Guo, Yejun > Sent: 2020年10月15日 21:17 > To: ffmpeg-devel@ffmpeg.org > Cc: Guo, Yejun > Subject: [PATCH V2] dnn_backend_tf.c: add option sess_config for tf backend > > TensorFlow C library accepts config for session options to set different > parameters for t

[FFmpeg-devel] [PATCH v3 4/6] ffmpeg: pass decoded or filtered AVFrame to output stream initialization

2020-10-16 Thread Jan Ekström
Additionally, reap the first rewards by being able to set the color related encoding values based on the passed AVFrame. The only tests that seem to have changed their results with this change seem to be the MXF tests. There, the muxer writes the limited/full range flag to the output container if

[FFmpeg-devel] [PATCH v3 1/6] ffmpeg: deduplicate init_output_stream usage logic

2020-10-16 Thread Jan Ekström
Adds a wrapper function, which handles any errors depending on how fatal a failure would be. --- fftools/ffmpeg.c | 51 1 file changed, 25 insertions(+), 26 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 84306818a2..cb7644de6a

Re: [FFmpeg-devel] [PATCH 1/3] avformat/av1dec: Fix padding in obu_get_packet()

2020-10-16 Thread Andreas Rheinhardt
James Almer: > On 10/16/2020 7:46 AM, Michael Niedermayer wrote: >> Fixes: stack buffer overflow (read) >> Fixes: >> 26369/clusterfuzz-testcase-minimized-ffmpeg_dem_VIVIDAS_fuzzer-5721057325219840 >> >> Found-by: continuous fuzzing process >> https://github.com/google/oss-fuzz/tree/master/project

[FFmpeg-devel] [PATCH v3 2/6] ffmpeg: move AVFrame time base adjustment into a function

2020-10-16 Thread Jan Ekström
This will have to be called later for video down the line. --- fftools/ffmpeg.c | 72 +++- 1 file changed, 47 insertions(+), 25 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index cb7644de6a..0d8ed26912 100644 --- a/fftools/ffmpeg.c +++

[FFmpeg-devel] [PATCH v3 0/6] ffmpeg: late A/V encoder init, AVFrame metadata usage

2020-10-16 Thread Jan Ekström
This patch set started with a very simple wish to not have to set color related values manually each time when utilizing ffmpeg.c. As of the third iteration, the following changes were done since the second: 1. A simple mistake was corrected, fixing `debug_ts`. 2. As I noticed such a change enabli

[FFmpeg-devel] [PATCH v3 5/6] ffmpeg: move field order decision making to encoder initialization

2020-10-16 Thread Jan Ekström
We now have the possibility of getting AVFrames here, and we should not touch the muxer's codecpar after writing the header. --- fftools/ffmpeg.c | 27 ++- .../fate/concat-demuxer-extended-lavf-mxf_d10 | 2 +- .../fate/concat-demuxer-simple1-lavf-mxf_d

[FFmpeg-devel] [PATCH v3 3/6] ffmpeg: move A/V non-streamcopy initialization to a later point

2020-10-16 Thread Jan Ekström
- For video, this means a single initialization point in do_video_out. - For audio we unfortunately need to do it in two places just before the buffer sink is utilized (if av_buffersink_get_samples would still work according to its specification after a call to avfilter_graph_request_oldest w

Re: [FFmpeg-devel] [PATCH 1/3] avformat/av1dec: Fix padding in obu_get_packet()

2020-10-16 Thread James Almer
On 10/16/2020 10:23 AM, Andreas Rheinhardt wrote: > James Almer: >> On 10/16/2020 7:46 AM, Michael Niedermayer wrote: >>> Fixes: stack buffer overflow (read) >>> Fixes: >>> 26369/clusterfuzz-testcase-minimized-ffmpeg_dem_VIVIDAS_fuzzer-5721057325219840 >>> >>> Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH v1] libavformat/hls: During operation, the user exits and interrupts, causing pls->segment to be released, resulting in a null pointer crash

2020-10-16 Thread Andreas Rheinhardt
javashu2...@gmail.com: > From: bevis > > Signed-off-by: bevis > --- > libavformat/hls.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index 72e28ab94f..0a522a4595 100644 > --- a/libavformat/hls.c > +++ b/libavformat/hls.c

Re: [FFmpeg-devel] [PATCH 1/3] avformat/av1dec: Fix padding in obu_get_packet()

2020-10-16 Thread Andreas Rheinhardt
James Almer: > On 10/16/2020 10:23 AM, Andreas Rheinhardt wrote: >> James Almer: >>> On 10/16/2020 7:46 AM, Michael Niedermayer wrote: Fixes: stack buffer overflow (read) Fixes: 26369/clusterfuzz-testcase-minimized-ffmpeg_dem_VIVIDAS_fuzzer-5721057325219840 Found-by: conti

[FFmpeg-devel] [PATCH v3 6/6] ffmpeg: add a data size threshold for muxing queue size

2020-10-16 Thread Jan Ekström
This way the old max queue size limit based behavior for streams where each individual packet is large is kept, while for smaller streams more packets can be buffered (current default is at 50 megabytes per stream). For some explanation, by default ffmpeg copies packets from before the appointed s

Re: [FFmpeg-devel] [PATCH 1/3] avformat/av1dec: Fix padding in obu_get_packet()

2020-10-16 Thread James Almer
On 10/16/2020 10:35 AM, Andreas Rheinhardt wrote: > James Almer: >> On 10/16/2020 10:23 AM, Andreas Rheinhardt wrote: >>> James Almer: On 10/16/2020 7:46 AM, Michael Niedermayer wrote: > Fixes: stack buffer overflow (read) > Fixes: > 26369/clusterfuzz-testcase-minimized-ffmpeg_dem

Re: [FFmpeg-devel] [PATCH 1/3] avformat/av1dec: Fix padding in obu_get_packet()

2020-10-16 Thread Andreas Rheinhardt
James Almer: > On 10/16/2020 10:35 AM, Andreas Rheinhardt wrote: >> James Almer: >>> On 10/16/2020 10:23 AM, Andreas Rheinhardt wrote: James Almer: > On 10/16/2020 7:46 AM, Michael Niedermayer wrote: >> Fixes: stack buffer overflow (read) >> Fixes: >> 26369/clusterfuzz-testcas

[FFmpeg-devel] [PATCH] avcodec/hevcdec: constrained intra predict, do not check top left IS_INTRA if it's not available

2020-10-16 Thread Xu Guangxin
fix ticket: 8932 For poc 2, we have tile boundary at x = 640. When we predict cu(640,912),the top left pixel is not avaliable to the cu. So, we can not check it's intra or not. We need set top[-1] = top[0] directly. see 8.4.4.2.1 for details --- libavcodec/hevcpred_template.c | 2 +- 1 file chang

[FFmpeg-devel] [PATCH 2/2] avcodec/movtextenc: Don't presume every style to have a font

2020-10-16 Thread Andreas Rheinhardt
Fixes segfaults in the absence of fonts; this can happen because the file didn't contain any or because the allocation of the font-string failed. Signed-off-by: Andreas Rheinhardt --- Do ASS files actually have to prescribe the font? libavcodec/movtextenc.c | 8 ++-- 1 file changed, 6 inser

[FFmpeg-devel] [PATCH 1/2] avcodec/movtextdec: Reset array counter after freeing array

2020-10-16 Thread Andreas Rheinhardt
Otherwise the mov_text muxer can segfault when given subtitles with more than one AVSubtitleRect if one of the first nb_rects - 1 rects contained a style attribute. Signed-off-by: Andreas Rheinhardt --- I wonder whether we should also reset the STYL_BOX flag of s->box_flags. libavcodec/movtexte

[FFmpeg-devel] [PATCH 1/5] avcodec/mobiclip: Avoid signed integer overflows in idct()

2020-10-16 Thread Michael Niedermayer
Fixes: signed integer overflow: 536870912 + 1610612736 cannot be represented in type 'int' Fixes: 26288/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOBICLIP_fuzzer-6194364759670784 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-o

[FFmpeg-devel] [PATCH 5/5] avformat/boadec: Check that channels and block_align are set

2020-10-16 Thread Michael Niedermayer
Fixes: Infinite loop Fixes: 26381/clusterfuzz-testcase-minimized-ffmpeg_dem_BOA_fuzzer-5745789089087488 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/boadec.c | 4 ++-- 1 file changed, 2 in

[FFmpeg-devel] [PATCH 2/5] avcodec/exr: Check limits to avoid overflow in delta computation

2020-10-16 Thread Michael Niedermayer
Fixes: signed integer overflow: 553590816 - -2145378049 cannot be represented in type 'int' Fixes: 26315/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EXR_fuzzer-5938755121446912 Fixes: 26340/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EXR_fuzzer-5644316208529408 Found-by: continuous

[FFmpeg-devel] [PATCH 4/5] avformat/icodec: Change order of operations to avoid NULL dereference

2020-10-16 Thread Michael Niedermayer
Fixes: SEGV on unknown address 0x Fixes: 26379/clusterfuzz-testcase-minimized-ffmpeg_dem_ICO_fuzzer-5709011753893888 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/icodec.c | 4 +

[FFmpeg-devel] [PATCH 3/5] avformat/asfdec_f: Check for negative ext_len

2020-10-16 Thread Michael Niedermayer
Fixes: Infinite loop Fixes: 26376/clusterfuzz-testcase-minimized-ffmpeg_dem_PCM_U32LE_fuzzer-6050518830678016 Fixes: 26377/clusterfuzz-testcase-minimized-ffmpeg_dem_TY_fuzzer-4838195726123008 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Sig

Re: [FFmpeg-devel] [PATCH v3 3/6] ffmpeg: move A/V non-streamcopy initialization to a later point

2020-10-16 Thread Michael Niedermayer
On Fri, Oct 16, 2020 at 04:16:46PM +0300, Jan Ekström wrote: > - For video, this means a single initialization point in do_video_out. > - For audio we unfortunately need to do it in two places just > before the buffer sink is utilized (if av_buffersink_get_samples > would still work according t

Re: [FFmpeg-devel] [PATCH v3 1/6] ffmpeg: deduplicate init_output_stream usage logic

2020-10-16 Thread Michael Niedermayer
On Fri, Oct 16, 2020 at 04:16:44PM +0300, Jan Ekström wrote: > Adds a wrapper function, which handles any errors depending on how > fatal a failure would be. > --- > fftools/ffmpeg.c | 51 > 1 file changed, 25 insertions(+), 26 deletions(-) LGTM t

Re: [FFmpeg-devel] [PATCH 4/5] avformat/icodec: Change order of operations to avoid NULL dereference

2020-10-16 Thread Peter Ross
On Fri, Oct 16, 2020 at 07:35:29PM +0200, Michael Niedermayer wrote: > Fixes: SEGV on unknown address 0x > Fixes: > 26379/clusterfuzz-testcase-minimized-ffmpeg_dem_ICO_fuzzer-5709011753893888 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/pr

Re: [FFmpeg-devel] [PATCH 5/6] avformat/udp: clarify option description for timeout unit

2020-10-16 Thread Marton Balint
On Wed, 14 Oct 2020, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/udp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index 30d8041..ee5fa84 100644 --- a/libavformat/udp.c +++ b/libavforma

Re: [FFmpeg-devel] [PATCH] avformat/udp: remove redundant setting of h->max_packet_size

2020-10-16 Thread Marton Balint
On Thu, 24 Sep 2020, myp...@gmail.com wrote: On Thu, Sep 24, 2020 at 12:15 AM Zhao Zhili wrote: h->max_packet_size is being reset in the following code. --- libavformat/udp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index 30d8041433..96d8b

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: fix cleanups on failed libsrt_open() and libsrt_setup()

2020-10-16 Thread Marton Balint
On Fri, 9 Oct 2020, Marton Balint wrote: - Call srt_epoll_release() to avoid fd leak on libsrt_setup() error. - Call srt_cleanup() on libsrt_open() failure. - Fix return value and method on mode parsing failure. Based on a patch by Nicolas Sugino . Will apply. Regards, Marton Signed-off

Re: [FFmpeg-devel] [PATCH] Revert "aviobuf: Discard old buffered, previously read data in ffio_read_partial"

2020-10-16 Thread Marton Balint
On Thu, 15 Oct 2020, Marton Balint wrote: On Fri, 9 Oct 2020, Marton Balint wrote: This is unneeded after 2ca48e466675a8a3630061cd2c15325eab8eda97 and it breaks ffio_ensure_seekback(). This reverts commit 53c25ee0736497b46bb76064cc2c84c976b2d295. --- libavformat/aviobuf.c | 7 --- 1

Re: [FFmpeg-devel] [PATCH] lavf/mpeg: replace magic descriptor_tag values with defines

2020-10-16 Thread Marton Balint
On Sun, 11 Oct 2020, Michael Niedermayer wrote: On Sat, Oct 10, 2020 at 05:04:30PM +1100, Brad Hards wrote: This takes the used values from ISO/IEC 13818-1 Table 2-45 and adds them to the mpegts.h header. No functional changes. Signed-off-by: Brad Hards --- libavformat/mpegts.c| 16 +++

Re: [FFmpeg-devel] [PATCH v3 3/6] ffmpeg: move A/V non-streamcopy initialization to a later point

2020-10-16 Thread Jan Ekström
On Fri, Oct 16, 2020, 22:47 Michael Niedermayer wrote: > On Fri, Oct 16, 2020 at 04:16:46PM +0300, Jan Ekström wrote: > > - For video, this means a single initialization point in do_video_out. > > - For audio we unfortunately need to do it in two places just > > before the buffer sink is utiliz

[FFmpeg-devel] [PATCH v2] lavf/url: fix rel path’s query string contains :/

2020-10-16 Thread caihaoning83
From: "ruiquan.crq" Signed-off-by: ruiquan.crq --- libavformat/tests/url.c | 1 + libavformat/url.c | 2 +- tests/ref/fate/url | 4 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/tests/url.c b/libavformat/tests/url.c index 2440ae08bc..c294795fa2 100644

Re: [FFmpeg-devel] [PATCH 5/6] avformat/udp: clarify option description for timeout unit

2020-10-16 Thread lance . lmwang
On Fri, Oct 16, 2020 at 11:03:00PM +0200, Marton Balint wrote: > > > On Wed, 14 Oct 2020, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/udp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavfo

Re: [FFmpeg-devel] [PATCH v1] libavformat/hls: During operation, the user exits and interrupts, causing pls->segment to be released, resulting in a null pointer crash

2020-10-16 Thread 徐慧书
It was found in the crash logs of online users, and it was also simulated locally. In China, we have a very large number of users, and the hls protocol is widely used, with hundreds of millions of views every day, and every small problem becomes more obvious. Andreas Rheinhardt 于2020年10月16日周五 下午

Re: [FFmpeg-devel] [PATCH v1] libavformat/hls: During operation, the user exits and interrupts, causing pls->segment to be released, resulting in a null pointer crash

2020-10-16 Thread 徐慧书
Andreas Rheinhardt 于2020年10月16日周五 下午9:32写道: > javashu2...@gmail.com: > > From: bevis > > > > Signed-off-by: bevis > > --- > > libavformat/hls.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/libavformat/hls.c b/libavformat/hls.c > > index 72e28ab94f..0a522a