Re: [FFmpeg-devel] [PATCH 1/2] swscale/utils: split range override check into its own function

2020-10-11 Thread Jan Ekström
On Sun, Oct 11, 2020 at 12:28 AM Michael Niedermayer wrote: > > On Sat, Oct 10, 2020 at 03:20:28AM +0300, Jan Ekström wrote: > > --- > > libswscale/utils.c | 9 +++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/libswscale/utils.c b/libswscale/utils.c > > index 9ca

Re: [FFmpeg-devel] [PATCH] lavf/mpeg: replace magic descriptor_tag values with defines

2020-10-11 Thread Michael Niedermayer
On Sat, Oct 10, 2020 at 05:04:30PM +1100, Brad Hards wrote: > This takes the used values from ISO/IEC 13818-1 Table 2-45 and adds > them to the mpegts.h header. No functional changes. > > Signed-off-by: Brad Hards > --- > libavformat/mpegts.c| 16 > libavformat/mpegts.h|

Re: [FFmpeg-devel] [PATCH] Allow using only the mfra info for seeking using the fragment index

2020-10-11 Thread Derek Buitenhuis
On 08/10/2020 11:26, Derek Buitenhuis wrote: >> Ping. > > Will push late today, or tomorrow, if nobody objects. Pushed. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, vis

Re: [FFmpeg-devel] [PATCH 14/18] lavf: move AVStream.{need_parsing, parser} to AVStreamInternal

2020-10-11 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-10-09 16:36:27) > Anton Khirnov: > > Those are private fields, no reason to have them exposed in a public > > header. > > --- > > libavdevice/v4l2.c | 2 +- > > This is a problem: There is no requirement to update libavdevice at the > same time as libav

Re: [FFmpeg-devel] [PATCH 14/18] lavf: move AVStream.{need_parsing, parser} to AVStreamInternal

2020-10-11 Thread James Almer
On 10/11/2020 9:12 AM, Anton Khirnov wrote: > Quoting Andreas Rheinhardt (2020-10-09 16:36:27) >> Anton Khirnov: >>> Those are private fields, no reason to have them exposed in a public >>> header. >>> --- >>> libavdevice/v4l2.c | 2 +- >> >> This is a problem: There is no requirement t

Re: [FFmpeg-devel] [PATCH 14/18] lavf: move AVStream.{need_parsing, parser} to AVStreamInternal

2020-10-11 Thread James Almer
On 10/11/2020 9:12 AM, Anton Khirnov wrote: > Quoting Andreas Rheinhardt (2020-10-09 16:36:27) >> Anton Khirnov: >>> Those are private fields, no reason to have them exposed in a public >>> header. >>> --- >>> libavdevice/v4l2.c | 2 +- >> >> This is a problem: There is no requirement t

[FFmpeg-devel] [PATCH] avcodec/cbs_av1: Free content in cbs_av1_free_metadata()

2020-10-11 Thread Michael Niedermayer
Fixes: memleak Fixes: 25838/clusterfuzz-testcase-minimized-ffmpeg_BSF_TRACE_HEADERS_fuzzer-5736255957237760 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cbs_av1.c | 1 + 1 file changed, 1 i

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/exr: Check xdelta, ydelta

2020-10-11 Thread Michael Niedermayer
On Sun, Sep 27, 2020 at 09:55:49AM +0200, Michael Niedermayer wrote: > Fixes: assertion failure > Fixes: > 25617/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EXR_fuzzer-5648746061496320 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/adpcm: Check block align for AV_CODEC_ID_ADPCM_PSX

2020-10-11 Thread Michael Niedermayer
On Wed, Sep 30, 2020 at 12:18:37AM +0200, Michael Niedermayer wrote: > Regression since: ca49476ace90ddebc5f92d9d82297f77e528c21e > Fixes: out of array write > Fixes: > 25786/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_PSX_fuzzer-5704869380620288 > > Found-by: continuous fuzzing proce

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/exr: Check line size for overflow

2020-10-11 Thread Michael Niedermayer
On Sun, Sep 27, 2020 at 09:55:51AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 570425356 * 6 cannot be represented in type > 'int > Fixes: > 25929/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EXR_fuzzer-5099197739827200 > > Found-by: continuous fuzzing process > htt

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: Free content in cbs_av1_free_metadata()

2020-10-11 Thread James Almer
On 10/11/2020 10:46 AM, Michael Niedermayer wrote: > Fixes: memleak > Fixes: > 25838/clusterfuzz-testcase-minimized-ffmpeg_BSF_TRACE_HEADERS_fuzzer-5736255957237760 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH] avfilter/vf_bwdif_cuda: CUDA implementation of bwdif

2020-10-11 Thread Thomas Mundt
Hi Philip, Am Fr., 9. Okt. 2020 um 18:33 Uhr schrieb Philip Langdale : > I've been sitting on this for a couple of years now, and I figured I > should just send it out. This is what I believe is a conceptually > correct port of bwdif to cuda (modulo edge handling which is not done > in the same w

Re: [FFmpeg-devel] [PATCH] avformat/udp: remove redundant setting of h->max_packet_size

2020-10-11 Thread Zhao Zhili
Ping. On Thu, Sep 24, 2020 at 12:15 AM Zhao Zhili https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.

Re: [FFmpeg-devel] [PATCH v2] examples/decode_video: flush parser to fix missing frame

2020-10-11 Thread Zhao Zhili
Ping for review. > On Sep 24, 2020, at 2:01 AM, Zhao Zhili https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". ___ ffmpeg-devel mailing list ffmpeg

[FFmpeg-devel] [PATCH]lavc/aomdec: Allow RGB decoding

2020-10-11 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #8929 for me. Please comment, Carl Eugen From 580477c4b0e07fa5436474ae732596bed5faf2d4 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 11 Oct 2020 19:25:10 +0200 Subject: [PATCH] lavc/aomdec: Allow RGB decoding. Fixes ticket #8929. --- libavcodec/liba

Re: [FFmpeg-devel] [PATCH]lavc/aomdec: Allow RGB decoding

2020-10-11 Thread James Almer
On 10/11/2020 2:27 PM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #8929 for me. > > Please comment, Carl Eugen > From 580477c4b0e07fa5436474ae732596bed5faf2d4 Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos > Date: Sun, 11 Oct 2020 19:25:10 +0200 > Subject: [PATCH] lavc/aom

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: Free content in cbs_av1_free_metadata()

2020-10-11 Thread Michael Niedermayer
On Sun, Oct 11, 2020 at 10:58:04AM -0300, James Almer wrote: > On 10/11/2020 10:46 AM, Michael Niedermayer wrote: > > Fixes: memleak > > Fixes: > > 25838/clusterfuzz-testcase-minimized-ffmpeg_BSF_TRACE_HEADERS_fuzzer-5736255957237760 > > > > Found-by: continuous fuzzing process > > https://githu

Re: [FFmpeg-devel] [PATCH 14/18] lavf: move AVStream.{need_parsing, parser} to AVStreamInternal

2020-10-11 Thread Michael Niedermayer
On Sun, Oct 11, 2020 at 10:14:39AM -0300, James Almer wrote: > On 10/11/2020 9:12 AM, Anton Khirnov wrote: > > Quoting Andreas Rheinhardt (2020-10-09 16:36:27) > >> Anton Khirnov: > >>> Those are private fields, no reason to have them exposed in a public > >>> header. > >>> --- > >>> libavdevice/v

Re: [FFmpeg-devel] [PATCH]lavc/aomdec: Allow RGB decoding

2020-10-11 Thread Carl Eugen Hoyos
Am So., 11. Okt. 2020 um 19:51 Uhr schrieb James Almer : > > On 10/11/2020 2:27 PM, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch fixes ticket #8929 for me. > > > > Please comment, Carl Eugen > > > From 580477c4b0e07fa5436474ae732596bed5faf2d4 Mon Sep 17 00:00:00 2001 > > From: Carl Eugen

Re: [FFmpeg-devel] [PATCH 14/18] lavf: move AVStream.{need_parsing, parser} to AVStreamInternal

2020-10-11 Thread Nicolas George
Michael Niedermayer (12020-10-11): > The situation with a single API+ABI shared by 2 libs with their own soname > is bad. > lavd either needs an independant API thats designed for devices (which is > probably more a medium to long term effort) This would be a terrible idea. Being functionally a pa

[FFmpeg-devel] [PATCH 2/3] avformat/rtspdec: fix mem leaks on init fail

2020-10-11 Thread Andriy Gelman
From: Andriy Gelman Fixes #6334 Signed-off-by: Andriy Gelman --- libavformat/rtspdec.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index b519b6f1a2..623f478585 100644 --- a/libavformat/rtspdec.c +++ b/liba

[FFmpeg-devel] [PATCH 1/3] avformat/rtspdec: set dangling pointers to NULL

2020-10-11 Thread Andriy Gelman
From: Andriy Gelman Otherwise a double free will occur in case rtsp_read_close() is called on error. Signed-off-by: Andriy Gelman --- libavformat/rtspdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index ef084a8b2b..b519

[FFmpeg-devel] [PATCH 3/3] avformat/rtspdec: cosmetics

2020-10-11 Thread Andriy Gelman
From: Andriy Gelman Make error check style consistent with rest of function. Signed-off-by: Andriy Gelman --- libavformat/rtspdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index 623f478585..6da408c95b 100644 --- a/li

Re: [FFmpeg-devel] [PATCH] libavformat/hls: add support for SAMPLE-AES decryption in HLS demuxer

2020-10-11 Thread Carl Eugen Hoyos
Am Sa., 10. Okt. 2020 um 17:01 Uhr schrieb Nachiket Tarate : > -pls->ctx->probesize = s->probesize > 0 ? s->probesize : 1024 * 4; > -pls->ctx->max_analyze_duration = s->max_analyze_duration > 0 ? > s->max_analyze_duration : 4 * AV_TIME_BASE; > -pls->ctx->interrupt_callback

Re: [FFmpeg-devel] [PATCH 1/3] avformat/rtspdec: set dangling pointers to NULL

2020-10-11 Thread Andreas Rheinhardt
Andriy Gelman: > From: Andriy Gelman > > Otherwise a double free will occur in case rtsp_read_close() is called > on error. > > Signed-off-by: Andriy Gelman > --- > libavformat/rtspdec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/rtspdec.c b/libavfo

Re: [FFmpeg-devel] [PATCH] libavformat/hls: add support for SAMPLE-AES decryption in HLS demuxer

2020-10-11 Thread Nachiket Tarate
From: ffmpeg-devel on behalf of Carl Eugen Hoyos Sent: Monday, October 12, 2020 12:46 AM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] libavformat/hls: add support for SAMPLE-AES decryption in HLS demuxer Am Sa., 10. Okt.

Re: [FFmpeg-devel] [PATCH 1/3] avformat/rtspdec: set dangling pointers to NULL

2020-10-11 Thread Andriy Gelman
On Sun, 11. Oct 21:28, Andreas Rheinhardt wrote: > Andriy Gelman: > > From: Andriy Gelman > > > > Otherwise a double free will occur in case rtsp_read_close() is called > > on error. > > > > Signed-off-by: Andriy Gelman > > --- > > libavformat/rtspdec.c | 3 ++- > > 1 file changed, 2 insertion

Re: [FFmpeg-devel] [PATCH] libavformat/hls: add support for SAMPLE-AES decryption in HLS demuxer

2020-10-11 Thread Carl Eugen Hoyos
Am So., 11. Okt. 2020 um 22:15 Uhr schrieb Nachiket Tarate : > > -pls->ctx->probesize = s->probesize > 0 ? s->probesize : 1024 * 4; > > -pls->ctx->max_analyze_duration = s->max_analyze_duration > 0 ? > > s->max_analyze_duration : 4 * AV_TIME_BASE; > > -pls->ctx->interrupt_

[FFmpeg-devel] [PATCH v2 2/2] avformat/rtspdec: cosmetics

2020-10-11 Thread Andriy Gelman
From: Andriy Gelman Make error check style consistent with rest of function. Signed-off-by: Andriy Gelman --- libavformat/rtspdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index d6a903c026..a75af3d327 100644 --- a/li

[FFmpeg-devel] [PATCH v2 1/2] avformat/rtspdec: fix mem leaks on init fail

2020-10-11 Thread Andriy Gelman
From: Andriy Gelman Fixes #6334 Signed-off-by: Andriy Gelman --- libavformat/rtspdec.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index ef084a8b2b..d6a903c026 100644 --- a/libavformat/rtspdec.c +++ b/l

Re: [FFmpeg-devel] [PATCH 2/3] avformat/rtspdec: fix mem leaks on init fail

2020-10-11 Thread Andreas Rheinhardt
Andriy Gelman: > From: Andriy Gelman > > Fixes #6334 > > Signed-off-by: Andriy Gelman > --- > libavformat/rtspdec.c | 17 ++--- > 1 file changed, 10 insertions(+), 7 deletions(-) > > diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c > index b519b6f1a2..623f478585 100644 >

Re: [FFmpeg-devel] [PATCH 14/18] lavf: move AVStream.{need_parsing, parser} to AVStreamInternal

2020-10-11 Thread Michael Niedermayer
On Sun, Oct 11, 2020 at 08:50:50PM +0200, Nicolas George wrote: > Michael Niedermayer (12020-10-11): > > The situation with a single API+ABI shared by 2 libs with their own soname > > is bad. > > lavd either needs an independant API thats designed for devices (which is > > probably more a medium to

Re: [FFmpeg-devel] [PATCH]lavc/aomdec: Allow RGB decoding

2020-10-11 Thread James Almer
On 10/11/2020 3:07 PM, Carl Eugen Hoyos wrote: > Am So., 11. Okt. 2020 um 19:51 Uhr schrieb James Almer : >> >> On 10/11/2020 2:27 PM, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> Attached patch fixes ticket #8929 for me. >>> >>> Please comment, Carl Eugen >> >>> From 580477c4b0e07fa5436474ae732596bed5f

Re: [FFmpeg-devel] [PATCH 2/3] avformat/rtspdec: fix mem leaks on init fail

2020-10-11 Thread Andriy Gelman
On Sun, 11. Oct 22:44, Andreas Rheinhardt wrote: > Andriy Gelman: > > From: Andriy Gelman > > > > Fixes #6334 > > > > Signed-off-by: Andriy Gelman > > --- > > libavformat/rtspdec.c | 17 ++--- > > 1 file changed, 10 insertions(+), 7 deletions(-) > > > > diff --git a/libavformat/rt

Re: [FFmpeg-devel] [PATCH 2/3] avformat/rtspdec: fix mem leaks on init fail

2020-10-11 Thread Andriy Gelman
On Sun, 11. Oct 22:04, Andriy Gelman wrote: > On Sun, 11. Oct 22:44, Andreas Rheinhardt wrote: > > Andriy Gelman: > > > From: Andriy Gelman > > > > > > Fixes #6334 > > > > > > Signed-off-by: Andriy Gelman > > > --- > > > libavformat/rtspdec.c | 17 ++--- > > > 1 file changed, 10 in