Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/tiff: do not abort decoding if strips are available

On Wed, Oct 07, 2020 at 09:13:52PM -0300, James Almer wrote: > > ffmpeg | branch: master | Paul B Mahol > > | Fri Oct 2 12:16:49 > > 2020 +0200| [da5b3d002862d1e105002a6dc1567e6551860896] | committer: Paul B > > Mahol > > > > avcodec/tiff: do n

Re: [FFmpeg-devel] [PATCH v4 0/9] avformat: wav-s337m support + new probe_stream option

Am Mo., 5. Okt. 2020 um 12:23 Uhr schrieb Nicolas Gaullier : > > >> Because of the dependencies, I had to group all the patches in a serie, > >> but they are 3 functional parts : > >> * patch 1 is necessary to fix dolby_e pts that will be part of the > >> test in patch 8 > >> * patch 2,3,4,5,6,7,8

Re: [FFmpeg-devel] [PATCH v4 0/9] avformat: wav-s337m support + new probe_stream option

>> - contribution: mpegts (or dvb for satt etc.) with s302m data -> s337m >> (this could be interesting for ffmpeg to support it) > >I believe we only had such samples until recently. With things moving from SDI to IP, I think this is going to be commonplace. I have two s302m samples with DolbyE

Re: [FFmpeg-devel] [PATCH] avcodec/dpxenc: stop hardcoding color trc/primaries

Woah, more amazing film preservation patches, thank you! From my uninformed reading of the code, does this only support the detection of Linear, 709, 240M, 170M, Gamm22? The reason I ask is that you frequently see Printing Density appear as well, which has a value of '1' in the 801/802 offset..

Re: [FFmpeg-devel] [PATCH] Allow using only the mfra info for seeking using the fragment index

On 07/10/2020 16:44, Derek Buitenhuis wrote: >> The mfra has enough information to enable seeking, and reading it is >> behind an AVOption flag, so we shouldn't require that sidx information >> also be present in order to seek using the fragment index. >> >> Signed-off-by: Derek Buitenhuis >> ---

[FFmpeg-devel] [PATCH] FATE/dnn: only run unit test when CONFIG_DNN enabled

Signed-off-by: Peter Ross --- tests/fate/dnn.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/dnn.mak b/tests/fate/dnn.mak index 90a1bb3cac..c5e458708e 100644 --- a/tests/fate/dnn.mak +++ b/tests/fate/dnn.mak @@ -33,6 +33,6 @@ fate-dnn-layer-avgpool: $(DNNTESTSD

[FFmpeg-devel] [PATCH 1/3] avformat/mspdec: Microsoft Paint (MSP) demuxer

Signed-off-by: Peter Ross --- Week nine or so of lockdown... Changelog | 1 + doc/general_contents.texi | 2 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/mspdec.c | 95 +++ 5 files changed, 100 insert

[FFmpeg-devel] [PATCH 2/3] avcodec/msp2dec: Microsoft Paint (MSP) version 2 decoder

Signed-off-by: Peter Ross --- Changelog | 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 +++ libavcodec/codec_id.h | 1 + libavcodec/msp2dec.c| 100 libavformat/mspdec.c|

[FFmpeg-devel] [PATCH 3/3] fate: add Microsoft Paint (MSP) test cases

--- tests/fate/video.mak| 6 ++ tests/ref/fate/msp-msp1 | 6 ++ tests/ref/fate/msp-msp2 | 6 ++ 3 files changed, 18 insertions(+) create mode 100644 tests/ref/fate/msp-msp1 create mode 100644 tests/ref/fate/msp-msp2 diff --git a/tests/fate/video.mak b/tests/fate/video.mak index

Re: [FFmpeg-devel] [PATCH] avcodec/dpxenc: stop hardcoding color trc/primaries

> On 7 Oct 2020, at 22:02, Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol > --- > libavcodec/dpxenc.c | 36 ++-- > tests/ref/lavf/dpx | 2 +- > 2 files changed, 35 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/dpxenc.c b/libavcodec/dpxenc.c > i

Re: [FFmpeg-devel] [PATCH] avcodec/dpxenc: stop hardcoding color trc/primaries

On Thu, Oct 08, 2020 at 12:27:02PM +0100, Harry Mallon wrote: > > > > On 7 Oct 2020, at 22:02, Paul B Mahol wrote: > > > > Signed-off-by: Paul B Mahol > > --- > > libavcodec/dpxenc.c | 36 ++-- > > tests/ref/lavf/dpx | 2 +- > > 2 files changed, 35 insertions(+)

[FFmpeg-devel] [PATCH] libavformat/dashdec: Fix issue with dash on Windows

Use xmlFree instead of av_freep snip from libxml2: * xmlGetProp: ... * Returns the attribute value or NULL if not found. * It's up to the caller to free the memory with xmlFree(). According to libxml2, you are supposed to use xmlFree instead of free on the pointer returned by it, and also

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/msp2dec: Microsoft Paint (MSP) version 2 decoder

On Thu, Oct 08, 2020 at 10:02:32PM +1100, Peter Ross wrote: > Signed-off-by: Peter Ross > --- > Changelog | 1 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/codec_desc.c | 7 +++ > libavcodec/codec_id.h | 1 + > libavcodec/msp2dec.c

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/vf_minterpolate: Reject too small dimensions

Andreas Rheinhardt: > The latter code relies upon the dimensions to be not too small; > otherwise one will call av_clip() with min > max lateron which aborts > in case ASSERT_LEVEL is >= 2 or one will get a nonsense result that may > lead to a heap-buffer-overflow/underflow. The latter has happened

Re: [FFmpeg-devel] [PATCH] libavformat/dashdec: Fix issue with dash on Windows

On 10/8/2020 9:45 AM, Christopher Degawa wrote: > Use xmlFree instead of av_freep > > snip from libxml2: > > * xmlGetProp: > ... > * Returns the attribute value or NULL if not found. > * It's up to the caller to free the memory with xmlFree(). > > According to libxml2, you are supposed to

Re: [FFmpeg-devel] [PATCH] Add atsc_a53 dependency to h264/hevc decoders

On 10/6/2020 1:09 AM, Chris Miceli wrote: > As per ticket #8901 there is a compilation issue where there is > an undefined reference when compiled with a minimal set of filters. > This commit remedies that by ensuring decoders which have SEI parsers > import the relevent caption object and hence fu

Re: [FFmpeg-devel] [PATCH] libavformat/dashdec: Fix issue with dash on Windows

Christopher Degawa: > Use xmlFree instead of av_freep > > snip from libxml2: > > * xmlGetProp: > ... > * Returns the attribute value or NULL if not found. > * It's up to the caller to free the memory with xmlFree(). > > According to libxml2, you are supposed to use xmlFree instead of free

[FFmpeg-devel] [PATCH] avcodec/h2645_parse: remove initial skipped_bytes_pos buffer

Allocate it only when needed, and instead of giving it a fixed initial size that's doubled on each realloc, ensure it's always big enough for the NAL currently being parsed. Fixes: OOM Fixes: 23817/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_METADATA_fuzzer-6300869057576960 Found-by: continuo

[FFmpeg-devel] [PATCH] avformat/dashdec: Reset pointer to NULL after freeing it

This is currently safe here, because the effective lifetime of adaptionset_lang is parse_manifest_adaptationset() (i.e. the pointer gets overwritten each time on entry to the function and gets freed before exiting the function), but it is nevertheless safer to reset the pointer. Signed-off-by: And

Re: [FFmpeg-devel] [PATCH] libavformat/dashdec: Fix issue with dash on Windows

> You should also reset c->adaptionset_lang to NULL after freeing it. (I > remember finding this issue myself, but somehow forgot to fix it. Strange.) Ah, I forgot that's what av_freep does in addition to freeing, do you wish to make the change, or do you want me to? > (Actually, the lifetime of

[FFmpeg-devel] [PATCH] avformat/libopenmpt: Don't discard const

Signed-off-by: Andreas Rheinhardt --- libavformat/libopenmpt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c index 52511aba56..b07da5f078 100644 --- a/libavformat/libopenmpt.c +++ b/libavformat/libopenmpt.c @@ -218,7 +218,7

Re: [FFmpeg-devel] [PATCH] avcodec/dpxenc: stop hardcoding color trc/primaries

>> >>> >>> [..] >>> +static int get_dpx_pri(int color_pri) >>> +{ >>> +switch (color_pri) { >>> +case AVCOL_PRI_BT709: >>> +return 6; >>> +case AVCOL_PRI_SMPTE240M: >>> +case AVCOL_PRI_SMPTE170M: >>> +return 9; >> >> I think perhaps this should be 8 (ITU 601 525)

Re: [FFmpeg-devel] [PATCH] libavformat/dashdec: Fix issue with dash on Windows

Christopher Degawa: >> You should also reset c->adaptionset_lang to NULL after freeing it. (I >> remember finding this issue myself, but somehow forgot to fix it. Strange.) > > Ah, I forgot that's what av_freep does in addition to freeing, do you > wish to make the change, or do you want me to? >

[FFmpeg-devel] [PATCH] libavcodec/adts_header: add frame_length field and avpriv function to parse AAC ADTS header

These will be used by HLS demuxer in case of SAMPLE-AES encryption. Signed-off-by: Nachiket Tarate --- libavcodec/adts_header.c | 1 + libavcodec/adts_header.h | 1 + libavcodec/adts_parser.c | 29 - libavcodec/adts_parser.h | 4 4 files changed, 34 insertions

[FFmpeg-devel] [PATCH] avformat/isom: add support for RAW ASC Bayer BGGR in mov

Signed-off-by: Paul B Mahol --- libavcodec/raw.c | 1 + libavformat/isom.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/libavcodec/raw.c b/libavcodec/raw.c index b6fb91c1c6..079d5c5d10 100644 --- a/libavcodec/raw.c +++ b/libavcodec/raw.c @@ -246,6 +246,7 @@ const PixelFormatTag ff_raw

[FFmpeg-devel] [PATCH 1/2] avcodec/mjpegdec: Use correct number of codes for VLC tables

Commit 1249698e1b424cff8e77e6a83cfdbc9d11e01aa7 made ff_mjpeg_decode_dht() call build_vlc() with a wrong (too hight) number of codes. The reason it worked is that the lengths of the extraneous entries is initialized to zero and ff_init_vlc_sparse() ignores codes with a length of zero. But using a t

[FFmpeg-devel] [PATCH 2/2] avcodec/mjpegdec: Use correct number of codes when init default VLCs

Commit bbc0d0c1fe2b7ecdc4367295594f084f85ad22f5 made the mjpeg decoder use default Huffman tables when none are given, yet when initializing the default Huffman tables, it did not use the correct number of entries of the arrays used to initialize the tables, but instead it used the biggest entry +

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mjpegdec: Use correct number of codes when init default VLCs

On Thu, Oct 08, 2020 at 07:57:56PM +0200, Andreas Rheinhardt wrote: > Commit bbc0d0c1fe2b7ecdc4367295594f084f85ad22f5 made the mjpeg decoder > use default Huffman tables when none are given, yet when initializing > the default Huffman tables, it did not use the correct number of entries > of the ar

Re: [FFmpeg-devel] [PATCH] avformat/libopenmpt: Don't discard const

Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/libopenmpt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c > index 52511aba56..b07da5f078 100644 > --- a/libavformat/libopenmpt.c > +++ b/lib

[FFmpeg-devel] [PATCH 1/4] avcodec/mjpegdec: Remove use_static from build_vlc()

It is always zero; it referred to the INIT_VLC_USE_STATIC flag which has been removed in 595324e143b57a52e2329eb47b84395c70f93087. Signed-off-by: Andreas Rheinhardt --- libavcodec/mjpegdec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/mjpegdec.c b/li

[FFmpeg-devel] [PATCH 2/4] avcodec/mjpegdec: Remove redundant initialization

Now that the correct number of codes is used, it is no longer necessary to initialize the lengths of the codes at all any more as the length of the actually used codes is set later anyway. Signed-off-by: Andreas Rheinhardt --- libavcodec/mjpegdec.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[FFmpeg-devel] [PATCH 3/4] avcodec/magicyuvenc: Avoid sorting Huffman table unnecessarily

Signed-off-by: Andreas Rheinhardt --- libavcodec/magicyuvenc.c | 41 ++-- 1 file changed, 14 insertions(+), 27 deletions(-) diff --git a/libavcodec/magicyuvenc.c b/libavcodec/magicyuvenc.c index 0bd6b8ef6a..1b8bb53114 100644 --- a/libavcodec/magicyuvenc.c +++

[FFmpeg-devel] [PATCH 4/4] avcodec/magicyuvenc: Use more correct cast in compare function

There is no need to cast const away (even if it was harmless) and to copy the object at all. Signed-off-by: Andreas Rheinhardt --- libavcodec/magicyuvenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/magicyuvenc.c b/libavcodec/magicyuvenc.c index 1b8bb531

[FFmpeg-devel] [PATCH 3/3] avformat/flvdec: Check for EOF in amf_parse_object()

Fixes: Timeout (too long -> 1ms) Fixes: 26108/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5653887668977664 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/flvdec.c | 3 +++ 1 file ch

[FFmpeg-devel] [PATCH 1/3] avcodec/h264_slice: fix undefined integer overflow with POC in error concealment

Alternatively the POC could be changed to 64bit. the large values seem to be within what is allowed. Fixes: signed integer overflow: 2147483646 + 2 cannot be represented in type 'int' Fixes: 26076/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5711127201447936 Found-by: continuo

[FFmpeg-devel] [PATCH 2/3] avcodec/pgxdec: Check depth more completely

Fixes: shift exponent -1 is negative Fixes: 26107/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PGX_fuzzer-5378790047612928 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/pgxdec.c | 6 +++

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/apedec: use ff_clz() instead of while loop

On Wed, Oct 07, 2020 at 05:12:47PM +0200, Paul B Mahol wrote: > On Wed, Oct 07, 2020 at 04:45:56PM +0200, Michael Niedermayer wrote: > > On Tue, Oct 06, 2020 at 12:08:27PM +0200, Anton Khirnov wrote: > > > Quoting Paul B Mahol (2020-10-06 10:19:13) > > > > On Tue, Oct 06, 2020 at 10:08:58AM +0200,

Re: [FFmpeg-devel] [PATCH 9/9] avformat/aviobuf: increase default read buffer size to 2*max_buffer_size for streamed data

On Tue, 6 Oct 2020, Marton Balint wrote: On Wed, 30 Sep 2020, Paul B Mahol wrote: On Tue, Sep 29, 2020 at 11:10:21PM +0200, Marton Balint wrote: This should increase the effectiveness of ffio_ensure_seekback by reducing the number of buffer reallocations and memmoves/memcpys because eve

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/pgxdec: Check depth more completely

Michael Niedermayer: > Fixes: shift exponent -1 is negative > Fixes: > 26107/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PGX_fuzzer-5378790047612928 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermaye

[FFmpeg-devel] [PATCH 1/3] avcodec/mpeg12: Reduce size of motion-vector VLC

It currently uses 9 bits per table, but there are no codes with nine bits at all, while there are codes with eight, ten and eleven bits. So reducing the table size to eight bits will not reduce the amount of codes that can be parsed in the first step, but it allows to reduce the size of the motion-

[FFmpeg-devel] [PATCH 2/3] avcodec/mpeg12: Don't pretend reading dct_dc_size_* VLCs can fail

It can't because the corresponding trees don't have any loose ends. Removing the checks also removed an instance of av_log(NULL (with a nonsense message) from the codebase. Signed-off-by: Andreas Rheinhardt --- libavcodec/mdec.c | 2 -- libavcodec/mpeg12.h| 4 libavcodec/mpeg12dec

[FFmpeg-devel] [PATCH 3/3] avcodec/mpeg12dec: Optimize reading mpeg2 intra escape codes

Said escape code is only six bits long, so that one has at least 25 - 6 bits in the bitstream reader's cache after reading it; therefore the whole following 18 bits (containing the actual code) are already in the bitstream reader's cache, making it unnecessary to reload the cache. Signed-off-by: A

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/magicyuvenc: Use more correct cast in compare function

On Thu, Oct 08, 2020 at 09:18:42PM +0200, Andreas Rheinhardt wrote: > There is no need to cast const away (even if it was harmless) and to > copy the object at all. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/magicyuvenc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/magicyuvenc: Avoid sorting Huffman table unnecessarily

On Thu, Oct 08, 2020 at 09:18:41PM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/magicyuvenc.c | 41 ++-- > 1 file changed, 14 insertions(+), 27 deletions(-) > should be ok if encoding still works

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/mjpegdec: Remove use_static from build_vlc()

On Thu, Oct 08, 2020 at 09:18:39PM +0200, Andreas Rheinhardt wrote: > It is always zero; it referred to the INIT_VLC_USE_STATIC flag which has > been removed in 595324e143b57a52e2329eb47b84395c70f93087. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mjpegdec.c | 10 +- > 1 file

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/mjpegdec: Remove redundant initialization

On Thu, Oct 08, 2020 at 09:18:40PM +0200, Andreas Rheinhardt wrote: > Now that the correct number of codes is used, it is no longer necessary > to initialize the lengths of the codes at all any more as the length of > the actually used codes is set later anyway. > > Signed-off-by: Andreas Rheinhar

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/mjpegdec: Remove use_static from build_vlc()

On Thu, Oct 08, 2020 at 09:18:39PM +0200, Andreas Rheinhardt wrote: > It is always zero; it referred to the INIT_VLC_USE_STATIC flag which has > been removed in 595324e143b57a52e2329eb47b84395c70f93087. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mjpegdec.c | 10 +- > 1 file

Re: [FFmpeg-devel] [PATCH] VP9 Profile 2 VDPAU support

On Thu, 8 Oct 2020 11:48:51 +0530 ManojGuptaBonda wrote: > Added VDPAU to list of supported formats for VP9 420 10 and 12 bit > formats. Add VP9 10/12 Bit support for VDPAU > --- > libavcodec/vp9.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavcodec/vp9.c b/libavcodec/vp9.

[FFmpeg-devel] [PATCH] Revert "aviobuf: Discard old buffered, previously read data in ffio_read_partial"

This is unneeded after 2ca48e466675a8a3630061cd2c15325eab8eda97 and it breaks ffio_ensure_seekback(). This reverts commit 53c25ee0736497b46bb76064cc2c84c976b2d295. --- libavformat/aviobuf.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c ind

Re: [FFmpeg-devel] [PATCH] avformat/isom: add support for RAW ASC Bayer BGGR in mov

On Thu, Oct 08, 2020 at 07:25:33PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/raw.c | 1 + > libavformat/isom.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/libavcodec/raw.c b/libavcodec/raw.c > index b6fb91c1c6..079d5c5d10 100644 > --- a/libavco

Re: [FFmpeg-devel] [PATCH] FATE/dnn: only run unit test when CONFIG_DNN enabled

> -Original Message- > From: ffmpeg-devel On Behalf Of Peter > Ross > Sent: 2020年10月8日 19:01 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH] FATE/dnn: only run unit test when > CONFIG_DNN enabled > > Signed-off-by: Peter Ross > --- > tests/fate/dnn.mak | 2 +- > 1 file

Re: [FFmpeg-devel] [PATCH v6] avdevice/xcbgrab: Add select_region option

On Sat, 11. Jul 11:29, Omar Emara wrote: > This patch adds a select_region option to the xcbgrab input device. > If set to 1, the user will be prompted to select the grabbing area > graphically by clicking and dragging. A rectangle will be drawn to > mark the grabbing area. A single click with no d

Re: [FFmpeg-devel] [PATCH 4/7] lavfi/vf_spp: convert to the video_enc_params API

Quoting Michael Niedermayer (2020-10-06 00:15:06) > On Mon, Oct 05, 2020 at 10:26:24AM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2020-10-03 20:23:02) > > > On Fri, Oct 02, 2020 at 08:03:28PM +0200, Anton Khirnov wrote: > > > > --- > > > > libavfilter/Makefile| 2 +- > >