Re: [FFmpeg-devel] [PATCH 29/40] avcodec/cfhdenc: Fix leaks on allocation errors

2020-09-14 Thread Paul B Mahol
On Mon, Sep 14, 2020 at 07:27:36AM +0200, Andreas Rheinhardt wrote: > The CineForm HD encoder attempts to allocate several buffers in its init > function; yet if only some of these allocations succeed, the > successfully allocated buffers leak. This is fixed by setting the > FF_CODEC_CAP_INIT_CLEAN

Re: [FFmpeg-devel] [PATCH] avfilter/vf_premultiply: add missing AV_PIX_FMT_YUVA444P12

2020-09-14 Thread Paul B Mahol
On Sun, Sep 13, 2020 at 07:55:01PM -0700, mindm...@gmail.com wrote: > From: Mark Reid > > query_formats says its supported, but is missing from switch statement > leading to segfault > > --- > libavfilter/vf_premultiply.c | 2 ++ > 1 file changed, 2 insertions(+) > gonna apply. _

Re: [FFmpeg-devel] [PATCH 2/2] libswcale/input: fix incorrect rgbf32 yuv conversions

2020-09-14 Thread Rémi Achard
> The rgb48ToUV and rgb48ToY funcs in input.c use the formula I'm using. rgb64ToUV and rgb64ToY use it too, might be an opportunity to reduce code duplication. I ran into this while working on related precision issues (color range conversion being precise only for 8bits) and just used the same fo

Re: [FFmpeg-devel] [PATCH v2 4/4] avformat: add Argonaut Games BRP demuxer

2020-09-14 Thread Paul B Mahol
On Wed, Sep 09, 2020 at 12:05:03AM +, Zane van Iperen wrote: > Used in FMVs for FX Fighter and Croc. Supports BVID and BASF streams, > requests samples for anything else. > > Due to the way BASF streams are contained in the file, only one is > supported. I have yet to see a BRP file with multi

Re: [FFmpeg-devel] [PATCH 3/4] avdevice/decklink_dec: add support for rgb/yuv pixel format autodetection

2020-09-14 Thread Gyan Doshi
Building with Decklink is broken, apparently due to f1b908d20a8 Error is src/libavdevice/decklink_dec.cpp: In function 'int ff_decklink_read_header(AVFormatContext*)': src/libavdevice/decklink_dec.cpp:1235:28: error: 'bmdFormatUnspecified' was not declared in this scope 1235 | if (c

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: fix pixel format extraction for cinema j2k

2020-09-14 Thread Tomas Härdin
sön 2020-09-13 klockan 23:42 +0100 skrev Rémi Achard: > > @@ -855,15 +857,19 @@ static int mxf_read_cryptographic_context(void *arg, > AVIOContext *pb, int tag, i > > static int mxf_read_strong_ref_array(AVIOContext *pb, UID **refs, int *count) > { > -*count = avio_rb32(pb); > -av_fre

Re: [FFmpeg-devel] [PATCH] avfilter/af_amix: do not leave unset PTS for frames after first stream is over

2020-09-14 Thread Nicolas George
Paul B Mahol (12020-09-13): > First stream is used only to get number of samples to put into each output > frame. > > Signed-off-by: Paul B Mahol > --- > libavfilter/af_amix.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) I cannot judge the change of the code since I do not know th

Re: [FFmpeg-devel] [PATCH] avfilter/avf_concat: check for possible integer overflow

2020-09-14 Thread Nicolas George
Paul B Mahol (12020-09-13): > Also check that segment delta pts is always bigger than input pts. > > There is nothing much currently that can be done to recover from > this situation so just return AVERROR_INVALIDDATA error code. Looks ok. -- Nicolas George signature.asc Description: PGP si

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: fix pixel format extraction for cinema j2k

2020-09-14 Thread Rémi Achard
> > Why this added hunk? Appending strong refs like this is likely to have > all sorts of unintended effects. The same MaterialPackages will appear > multiple times for example. This is my attempt to fix an issue in the fate tests. If you look at mxf_read_generic_descriptor, there is two places

Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/mxfdec: Read Apple private Content Light Level from MXF

2020-09-14 Thread Tomas Härdin
ons 2020-09-09 klockan 15:56 +0100 skrev Harry Mallon: > * As embedded by Apple Compressor > > Signed-off-by: Harry Mallon > --- > libavformat/mxfdec.c| 27 + > tests/fate/mxf.mak | 4 + > tests/ref/fate/mxf-probe-applehdr10 | 169 +

Re: [FFmpeg-devel] [PATCH v2 2/3] avformat/mxfenc: Write Mastering Display Colour Volume to MXF

2020-09-14 Thread Tomas Härdin
ons 2020-09-09 klockan 15:56 +0100 skrev Harry Mallon: > Described in Annex B SMPTE ST 2067-21:2020 > > Signed-off-by: Harry Mallon Simple enough. /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/mxfdec: Read Mastering Display Colour Volume from MXF

2020-09-14 Thread Tomas Härdin
ons 2020-09-09 klockan 15:56 +0100 skrev Harry Mallon: > Described in Annex B SMPTE ST 2067-21:2020 > > Signed-off-by: Harry Mallon > av_freep(&((MXFDescriptor *)*ctx)->sub_descriptors_refs); > @@ -1272,6 +1276,42 @@ static int mxf_read_generic_descriptor(void *arg, > AVIOContext *pb,

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: fix pixel format extraction for cinema j2k

2020-09-14 Thread Tomas Härdin
mån 2020-09-14 klockan 10:48 +0100 skrev Rémi Achard: > > Why this added hunk? Appending strong refs like this is likely to have > > all sorts of unintended effects. The same MaterialPackages will appear > > multiple times for example. > > This is my attempt to fix an issue in the fate tests. FAT

Re: [FFmpeg-devel] [FFmpeg-cvslog] fate: disable automatic conversions on many tests.

2020-09-14 Thread Nicolas George
Nicolas George (12020-09-10): > Anyway, I will try to find a big-endian arch and check. I have tried on this: Linux erpro8-fsf1 3.14.10-er8mod-00013-ge0fe977 #1 SMP PREEMPT Wed Jan 14 12:33:22 PST 2015 mips64 GNU/Linux system type : UBNT_E200 (CN6120p1.1-1000-NSP) machine

[FFmpeg-devel] [PATCH 2/2] dnn_backend_native_layer_conv2d.c: refine code.

2020-09-14 Thread xujunzz
From: Xu Jun Move thread area allocate out of thread function into main thread. Signed-off-by: Xu Jun --- .../dnn/dnn_backend_native_layer_conv2d.c | 29 +-- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_native_layer_conv2d.c b

[FFmpeg-devel] [PATCH 1/2] dnn_backend_native_layer_conv2d.c: fix memory allocation bug in multithread function.

2020-09-14 Thread xujunzz
From: Xu Jun Before patch, memory was allocated in each thread functions, which may cause more than one time of memory allocation and cause crash. After patch, memory is allocated in the main thread once, an index was parsed into thread functions. Bug fixed. Signed-off-by: Xu Jun --- .../dnn/

[FFmpeg-devel] [PATCH 2/2] avformat: add IPU demuxer

2020-09-14 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/ipudec.c | 89 3 files changed, 91 insertions(+) create mode 100644 libavformat/ipudec.c diff --git a/libavformat/Makefile b/libavformat/Mak

[FFmpeg-devel] [PATCH 1/2] avcodec: add IPU Video decoder and parser

2020-09-14 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 2 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 ++ libavcodec/codec_id.h | 1 + libavcodec/ipu_parser.c | 78 libavcodec/ipudec.c | 0 libavcodec/mpeg12dec.c | 155 +++

Re: [FFmpeg-devel] [PATCH 27/40] avcodec/avrndec: Fix memleak on error

2020-09-14 Thread Paul B Mahol
On Mon, Sep 14, 2020 at 07:27:34AM +0200, Andreas Rheinhardt wrote: > If ff_codec_open2_recursive() fails, the already allocated > AVCodecContext leaks. Fix this by setting the FF_CODEC_CAP_INIT_CLEANUP > flag. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/avrndec.c | 2 +- > 1 file c

Re: [FFmpeg-devel] [PATCH 26/40] avcodec/avrndec: Check allocation for success

2020-09-14 Thread Paul B Mahol
On Mon, Sep 14, 2020 at 07:27:33AM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/avrndec.c | 2 ++ > 1 file changed, 2 insertions(+) > lgtm > diff --git a/libavcodec/avrndec.c b/libavcodec/avrndec.c > index f4ec490de5..a4b6fadfc8 100644 > --- a/libavcode

Re: [FFmpeg-devel] [PATCH 17/40] avcodec/alacenc: Remove redundant code to free extradata

2020-09-14 Thread Paul B Mahol
On Mon, Sep 14, 2020 at 07:27:24AM +0200, Andreas Rheinhardt wrote: > It is already freed generically for encoders. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/alacenc.c | 2 -- > 1 file changed, 2 deletions(-) lgtm > > diff --git a/libavcodec/alacenc.c b/libavcodec/alacenc.c > i

Re: [FFmpeg-devel] [PATCH 18/40] avcodec/alacenc: Don't free unnecessarily

2020-09-14 Thread Paul B Mahol
On Mon, Sep 14, 2020 at 07:27:25AM +0200, Andreas Rheinhardt wrote: > The init function of the ALAC encoder calls its own close function > if a call to ff_lpc_init() fails; yet nothing has been allocated before > that point (except extradata which is freed generically) and ff_lpc_init() > can be ex

Re: [FFmpeg-devel] [PATCH 20/40] avcodec/atrac1: Cleanup generically after init failure

2020-09-14 Thread Paul B Mahol
On Mon, Sep 14, 2020 at 07:27:27AM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/atrac1.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 19/40] avcodec/atrac1: Check allocation of AVFloatDSPContext

2020-09-14 Thread Paul B Mahol
On Mon, Sep 14, 2020 at 07:27:26AM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/atrac1.c | 4 > 1 file changed, 4 insertions(+) > lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg

Re: [FFmpeg-devel] [PATCH 32/40] avcodec/dsicinvideo: Remove redundant code for freeing

2020-09-14 Thread Paul B Mahol
On Mon, Sep 14, 2020 at 07:27:39AM +0200, Andreas Rheinhardt wrote: > The dsicinvideo decoder already has the FF_CODEC_CAP_INIT_CLEANUP flag > set, so it is unnecessary to directly clean up some already allocated > buffers in case another one could not be allocated in the init function, > as all bu

[FFmpeg-devel] [PATCHv2] [RFC] libavcodec/hevc_refs: Clear DPB of old frames

2020-09-14 Thread Kieran Kunhya
From 21bf6e5eac61d34f270534dd5a2a7229967c1ee9 Mon Sep 17 00:00:00 2001 From: Kieran Kunhya Date: Thu, 16 Jul 2020 20:29:24 +0100 Subject: [PATCHv2] [RFC] libavcodec/hevc_refs: Clear DPB of old frames During glitching or looping streams, old frames remain in the DPB. The decoder incorrectly thinks

Re: [FFmpeg-devel] [PATCH 18/40] avcodec/alacenc: Don't free unnecessarily

2020-09-14 Thread Andreas Rheinhardt
Paul B Mahol: > On Mon, Sep 14, 2020 at 07:27:25AM +0200, Andreas Rheinhardt wrote: >> The init function of the ALAC encoder calls its own close function >> if a call to ff_lpc_init() fails; yet nothing has been allocated before >> that point (except extradata which is freed generically) and ff_lpc

[FFmpeg-devel] [PATCH] libavformat/rmdec.c: Fix Use-of-uninitialized-value in ff_codec_get_id

2020-09-14 Thread Thierry Foucu
In case the pb does not contain 4 bytes, the buf[256] will not be initialize before we pass it to ff_codec_get_id --- libavformat/rmdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c index a36e693ab2..220aa8aee2 100644 --- a/libavfor

Re: [FFmpeg-devel] [PATCH 3/4] avdevice/decklink_dec: add support for rgb/yuv pixel format autodetection

2020-09-14 Thread Marton Balint
On Mon, 14 Sep 2020, Gyan Doshi wrote: Building with Decklink is broken, apparently due to f1b908d20a8 Error is src/libavdevice/decklink_dec.cpp: In function 'int ff_decklink_read_header(AVFormatContext*)': src/libavdevice/decklink_dec.cpp:1235:28: error: 'bmdFormatUnspecified' wa

[FFmpeg-devel] [PATCH] avdevice/decklink_dec: fix build with older SDK

2020-09-14 Thread Marton Balint
Apparently bmdFormatUnspecified needs SDK 11.0. It is just a fancy way of checking for zero, so let's do that instead. Fixes build issue since f1b908d20a8. Signed-off-by: Marton Balint --- libavdevice/decklink_dec.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevi

[FFmpeg-devel] [PATCH] fate: add scale filters for big-endian architectures.

2020-09-14 Thread Nicolas George
Filters mostly work in native endianness, but they must output a specified endianness, usually little: that requires a final conversion for big endian. I do not know what's the deal with gif-deal: inserting explicitly the filters that are implicitly inserted result in less frames in output. Probab

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: fix pixel format extraction for cinema j2k

2020-09-14 Thread Rémi Achard
> > FATE works fine for me, at least with a default configuration. Can you > provide what options you're using? So the original patch I submitted errored in the test suite, you can see the error here https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200913184510.85070-1-remiach...@gmail.com/ I

Re: [FFmpeg-devel] [PATCH 3/4 v2] ffmpeg: move A/V non-streamcopy initialization to a later point

2020-09-14 Thread Jan Ekström
On Mon, Sep 14, 2020 at 12:33 AM Jan Ekström wrote: > > - For video, this means a single initialization point in do_video_out. > - For audio we unfortunately need to do it in two places just > before the buffer sink is utilized (if av_buffersink_get_samples > would still work according to its

Re: [FFmpeg-devel] [aarch64] yuv2planeX - unroll outer loop by 4 to increase performance by 6.3%

2020-09-14 Thread Martin Storsjö
Hi, On Tue, 18 Aug 2020, Sebastian Pop wrote: Unrolling by 4 the outer loop in yuv2planeX reduces the number of cache accesses by 7.5%. The values loaded for the filter are used in the 4 unrolled iterations and avoids reloading 3 times the same values. The performance was measured on an Arm64 N

Re: [FFmpeg-devel] [PATCH 2/4 v2] ffmpeg: move AVFrame time base adjustment into a function

2020-09-14 Thread Jan Ekström
On Mon, Sep 14, 2020 at 12:31 AM Jan Ekström wrote: > Diff between v1 and v2 follows: - Forgotten to be removed debug logs removed. - Still log debug_ts even in case of nullptr AVFrame or AV_NOPTS_VALUE. Decided against separating the logging because this way it's a self-contained package and t

Re: [FFmpeg-devel] [PATCH 2/2] libswcale/input: fix incorrect rgbf32 yuv conversions

2020-09-14 Thread Michael Niedermayer
On Sun, Sep 13, 2020 at 04:04:42PM -0700, Mark Reid wrote: > On Sun, Sep 13, 2020 at 8:55 AM Michael Niedermayer > wrote: > > > On Sat, Sep 12, 2020 at 02:07:14AM -0700, mindm...@gmail.com wrote: > > > From: Mark Reid > > > > > > --- > > > libswscale/input.c | 12 +--- >

[FFmpeg-devel] [PATCH] avformat/argo_asf: initialise file header inline

2020-09-14 Thread Zane van Iperen
Garbage was left-over in the ArgoASFFileHeader::name field if the url was too short. This zero-initialises it. Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf

Re: [FFmpeg-devel] [PATCH 2/2] dnn_backend_native_layer_conv2d.c: refine code.

2020-09-14 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > xuju...@sjtu.edu.cn > Sent: 2020年9月14日 19:32 > To: ffmpeg-devel@ffmpeg.org > Cc: xuju...@sjtu.edu.cn > Subject: [FFmpeg-devel] [PATCH 2/2] dnn_backend_native_layer_conv2d.c: > refine code. > > From: Xu Jun > > Move thread area a

Re: [FFmpeg-devel] [PATCH 2/2] libswcale/input: fix incorrect rgbf32 yuv conversions

2020-09-14 Thread Mark Reid
On Mon, Sep 14, 2020 at 2:44 PM Michael Niedermayer wrote: > On Sun, Sep 13, 2020 at 04:04:42PM -0700, Mark Reid wrote: > > On Sun, Sep 13, 2020 at 8:55 AM Michael Niedermayer > > > wrote: > > > > > On Sat, Sep 12, 2020 at 02:07:14AM -0700, mindm...@gmail.com wrote: > > > > From: Mark Reid > >

[FFmpeg-devel] [PATCH] libavcodec/exr: fix incorrect translation of denorm mantissa

2020-09-14 Thread mindmark
From: Mark Reid Hi, This fixes a very subtle error thats hard notice until up unpremultiply a image. This loop is suppose to stop at first 1, instead was stoping at first 0 The comment is correct through! openexrs implementation is very similar. https://github.com/AcademySoftwareFoundation/open

Re: [FFmpeg-devel] [PATCH] libavcodec/exr: fix incorrect translation of denorm mantissa

2020-09-14 Thread Mark Reid
On Mon, Sep 14, 2020 at 7:14 PM wrote: > From: Mark Reid > > Hi, > This fixes a very subtle error thats hard notice until up unpremultiply a > image. > > This loop is suppose to stop at first 1, instead was stoping at first 0 > The comment is correct through! > > openexrs implementation is very

Re: [FFmpeg-devel] [PATCHv2] [RFC] libavcodec/hevc_refs: Clear DPB of old frames

2020-09-14 Thread Kieran Kunhya
On Mon, 14 Sep 2020 at 17:37, Kieran Kunhya wrote: > From 21bf6e5eac61d34f270534dd5a2a7229967c1ee9 Mon Sep 17 00:00:00 2001 > From: Kieran Kunhya > Date: Thu, 16 Jul 2020 20:29:24 +0100 > Subject: [PATCHv2] [RFC] libavcodec/hevc_refs: Clear DPB of old frames > > During glitching or looping strea

Re: [FFmpeg-devel] [PATCH v9 2/5] lavc/avs3: add AVS3 related definitions

2020-09-14 Thread myp...@gmail.com
On Mon, Aug 31, 2020 at 11:09 PM wrote: > > From: hwren > > Signed-off-by: hwren > --- > libavcodec/avs3.h | 118 ++ > 1 file changed, 118 insertions(+) > create mode 100644 libavcodec/avs3.h > > diff --git a/libavcodec/avs3.h b/libavcodec/avs3.h > n

Re: [FFmpeg-devel] [PATCH V2] Added MKV tag for AVS2 video codec

2020-09-14 Thread myp...@gmail.com
On Sun, Sep 6, 2020 at 6:40 PM Ze Yuan wrote: > > From ea96e70874c87b003af1fb3fcd5c792b3292bf29 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?=E9=83=91=E5=A4=A9=E6=B3=A2?= > Date: Sun, 6 Sep 2020 18:35:51 +0800 > Subject: [PATCH] Added MKV tag for AVS2 video codec > > avs2 (IEEE 1857.4) video codec

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: fix build with older SDK

2020-09-14 Thread Gyan Doshi
On 15-09-2020 12:54 am, Marton Balint wrote: Apparently bmdFormatUnspecified needs SDK 11.0. It is just a fancy way of checking for zero, so let's do that instead. Fixes build issue since f1b908d20a8. Signed-off-by: Marton Balint --- libavdevice/decklink_dec.cpp | 2 +- 1 file changed, 1

Re: [FFmpeg-devel] [PATCH] lavf/srt: fix build fail when used the libsrt 1.4.1

2020-09-14 Thread Gyan Doshi
This should be backported to 4.3 and other releases whose builds fail. Gyan On 12-07-2020 11:33 am, Jun Zhao wrote: From: Jun Zhao libsrt 1.4.1 changed the: SRTO_SMOOTHER -> SRTO_CONGESTION SRTO_STRICTENC -> SRTO_ENFORCEDENCRYPTION SRTO_TSBPDDELAY -> SRTO_LATENCY and removed the front of d