Re: [FFmpeg-devel] [FFmpeg-cvslog] fate: disable automatic conversions on many tests.

2020-09-12 Thread Michael Niedermayer
On Thu, Sep 10, 2020 at 07:09:50PM -0300, James Almer wrote: > On 9/10/2020 3:47 PM, Michael Niedermayer wrote: > > On Thu, Sep 10, 2020 at 07:35:12PM +0200, Nicolas George wrote: > >> Michael Niedermayer (12020-09-10): > >>> this breaks several tests on big endian as that needs converts at > >>>

Re: [FFmpeg-devel] [PATCH 2/2] dnn/openvino: add input/output name info

2020-09-12 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Ting Fu > Sent: 2020年9月9日 9:52 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH 2/2] dnn/openvino: add input/output name info > > show all input/output names when the input or output name not correct > > Signed-off-by

[FFmpeg-devel] [PATCH 1/2] fate: use correct uint32 layer

2020-09-12 Thread mindmark
From: Mark Reid --- tests/fate/image.mak | 2 +- tests/ref/fate/exr-rgb-scanline-pxr24-half-uint32-13x9 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fate/image.mak b/tests/fate/image.mak index 756d01c667..69b4ea5431 100644 --- a/t

[FFmpeg-devel] [PATCH 2/2] libswcale/input: fix incorrect rgbf32 yuv conversions

2020-09-12 Thread mindmark
From: Mark Reid --- libswscale/input.c | 12 +--- tests/ref/fate/filter-pixfmts-scale | 8 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/libswscale/input.c b/libswscale/input.c index 064ed5902f..67a85b0418 100644 --- a/libswscale/input.c +++ b

[FFmpeg-devel] [PATCH 0/2] libswcale/input: fix incorrect rgbf32 yuv conversions

2020-09-12 Thread mindmark
From: Mark Reid Hi, I'm not sure how I didn't notice this before but the f32 to yuv conversion is slightly off. the folowinng 2 patches fix it. In doing this I found that one of the exr tests probably wasn't testing the right layer, so I fixed that before. Mark Reid (2): fate: use correct u

[FFmpeg-devel] [PATCH] avformat: add DAT CCTV demuxer

2020-09-12 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/luodatdec.c | 129 +++ 3 files changed, 131 insertions(+) create mode 100644 libavformat/luodatdec.c diff --git a/libavformat/Makefile b/libavform

Re: [FFmpeg-devel] [PATCH 1/2] fate: use correct uint32 layer

2020-09-12 Thread Paul B Mahol
On Sat, Sep 12, 2020 at 02:07:13AM -0700, mindm...@gmail.com wrote: > From: Mark Reid > > --- > tests/fate/image.mak | 2 +- > tests/ref/fate/exr-rgb-scanline-pxr24-half-uint32-13x9 | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Gonna apply. > > d

Re: [FFmpeg-devel] [PATCH] avfilter/f_graphmonitor: add tiny output mode

2020-09-12 Thread Paul B Mahol
On Wed, Sep 09, 2020 at 09:46:32PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 2 +- > libavfilter/f_graphmonitor.c | 119 +++ > 2 files changed, 109 insertions(+), 12 deletions(-) > Gonna apply. _

Re: [FFmpeg-devel] [PATCH] avcodec/mobiclip: Check quantizer before table setup

2020-09-12 Thread Michael Niedermayer
On Fri, Sep 11, 2020 at 10:00:02PM +0200, Paul B Mahol wrote: > On Fri, Sep 11, 2020 at 08:09:48PM +0200, Michael Niedermayer wrote: > > On Fri, Sep 11, 2020 at 11:12:33AM +0200, Paul B Mahol wrote: > > > On Fri, Sep 11, 2020 at 01:19:59AM +0200, Michael Niedermayer wrote: > > > > Fixes: index -1 o

Re: [FFmpeg-devel] [PATCH] avcodec/adpcm: take into account block_align when decoding ADPCM_PSX

2020-09-12 Thread Zane van Iperen
On Fri, 11 Sep 2020 15:27:42 +0200 "Paul B Mahol" wrote: > get_nb_samples() gives number of samples in single packet depending on its > size. > We here uses blocks and block_align to decode mutliple frames at once. > > Imagine decoding stereo int16 pcm so that you pick only 4 bytes each time. >

Re: [FFmpeg-devel] [PATCH v5 2/2] libavformat/webp: add WebP demuxer

2020-09-12 Thread Lynne
On 11/09/2020 08:36, Josef Zlomek wrote: > Adds the demuxer of animated WebP files. > It supports non-animated, animated, truncated, and concatenated files. > Reading from a pipe (and other non-seekable inputs) is also supported. > > The WebP demuxer splits the input stream into packets containing

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/mpc: Fix multiple numerical overflows in ff_mpc_dequantize_and_synth()

2020-09-12 Thread Michael Niedermayer
On Tue, Jun 30, 2020 at 10:28:32PM +0200, Michael Niedermayer wrote: > Fixes: -2.4187e+09 is outside the range of representable values of type 'int' > Fixes: signed integer overflow: -14512205 + -2147483648 cannot be represented > in type 'int' > Fixes: > 20492/clusterfuzz-testcase-minimized-ffmp

[FFmpeg-devel] [PATCH 1/2] avcodec/mobiclip: check for pmode=2 ax/ay=0

2020-09-12 Thread Michael Niedermayer
Fixes: out of array access Fixes: 25452/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOBICLIP_fuzzer-5081657055641600 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mobiclip.c | 3 +++ 1

[FFmpeg-devel] [PATCH 2/2] avcodec/mobiclip: set the bitstream size to the input

2020-09-12 Thread Michael Niedermayer
Fixes: out of array read Fixes: 25453/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOBICLIP_fuzzer-5163575973511168 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mobiclip.c | 2 +- 1 fi

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mobiclip: check for pmode=2 ax/ay=0

2020-09-12 Thread Paul B Mahol
On Sat, Sep 12, 2020 at 04:35:54PM +0200, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 25452/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOBICLIP_fuzzer-5081657055641600 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mobiclip: set the bitstream size to the input

2020-09-12 Thread Paul B Mahol
On Sat, Sep 12, 2020 at 04:35:55PM +0200, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: > 25453/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOBICLIP_fuzzer-5163575973511168 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/f

[FFmpeg-devel] [PATCH] avcodec/libaomenc: Extract extradata directly if available

2020-09-12 Thread Andriy Gelman
From: Andriy Gelman Currently a bsf is inserted to extract OBU headers which are propagated as packet side data. The side data is used in matroska to insert out of band extradata. Support to fetch extradata directly from av1 was added in commit f8d6a1653476662a7b00a1564afe37516adeba1a in libaom.

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Extract extradata directly if available

2020-09-12 Thread James Almer
On 9/12/2020 11:39 AM, Andriy Gelman wrote: > From: Andriy Gelman > > Currently a bsf is inserted to extract OBU headers which are propagated > as packet side data. The side data is used in matroska to insert out of > band extradata. > > Support to fetch extradata directly from av1 was added in

[FFmpeg-devel] [PATCH] avcodec/notchlc: Check available space for luma block code

2020-09-12 Thread Michael Niedermayer
Fixes: Timeout (too long -> 2sec) Fixes: 25439/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NOTCHLC_fuzzer-5688211127664640 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/notchlc.c | 3 +

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Extract extradata directly if available

2020-09-12 Thread Derek Buitenhuis
On 12/09/2020 16:48, James Almer wrote: > No, see https://bugs.chromium.org/p/aomedia/issues/detail?id=2208 > > aom_codec_get_global_headers() has a bug that hasn't been fixed. That's > why i haven't implemented it yet in our wrapper. Even if fixed, shouldn't be still use the BSF anyway, since it

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Extract extradata directly if available

2020-09-12 Thread James Almer
On 9/12/2020 1:32 PM, Derek Buitenhuis wrote: > On 12/09/2020 16:48, James Almer wrote: >> No, see https://bugs.chromium.org/p/aomedia/issues/detail?id=2208 >> >> aom_codec_get_global_headers() has a bug that hasn't been fixed. That's >> why i haven't implemented it yet in our wrapper. > > Even if

Re: [FFmpeg-devel] [PATCH V3 1/2] avcodec: add av1 hardware acceleration decoder

2020-09-12 Thread James Almer
On 9/9/2020 10:23 PM, Wang, Fei W wrote: > >> On 9/9/2020 12:39 AM, Fei Wang wrote: >>> This av1 decoder is now only used for av1 hardware acceleration >>> decoder. Consider it can be extend to a local decoder like hevc or vp9 >>> in the future, so define its name as "av1" and put it into external

Re: [FFmpeg-devel] [PATCH v5 2/2] libavformat/webp: add WebP demuxer

2020-09-12 Thread Carl Eugen Hoyos
Am Fr., 11. Sept. 2020 um 08:36 Uhr schrieb Josef Zlomek : This is not the requested review, I am just curious about the behaviour: > +static int webp_probe(const AVProbeData *p) > +{ > +const uint8_t *b = p->buf; > + > +if (AV_RB32(b) == MKBETAG('R', 'I', 'F', 'F') && > +AV_R

[FFmpeg-devel] [PATCH 2/2] avformat/asfdec_f: Change order or operations slightly

2020-09-12 Thread Michael Niedermayer
Fixes: signed integer overflow: 20 * 5184056935931942919 cannot be represented in type 'long' Fixes: 25466/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-4798660247552000 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mic

[FFmpeg-devel] [PATCH 1/2] avcodec/arbc: Assume that at least one segment has a tile

2020-09-12 Thread Michael Niedermayer
If no segment has a tile, the segment count really should be 0 Fixes: Timeout (61sec -> 2sec) Fixes: 25445/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ARBC_fuzzer-5657711222718464 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Extract extradata directly if available

2020-09-12 Thread Andriy Gelman
On Sat, 12. Sep 14:00, James Almer wrote: > On 9/12/2020 1:32 PM, Derek Buitenhuis wrote: > > On 12/09/2020 16:48, James Almer wrote: > >> No, see https://bugs.chromium.org/p/aomedia/issues/detail?id=2208 > >> > >> aom_codec_get_global_headers() has a bug that hasn't been fixed. That's > >> why i h

Re: [FFmpeg-devel] [PATCH 1/8] avutil/timecode: fix av_timecode_get_smpte_from_framenum with 50/60 fps

2020-09-12 Thread Marton Balint
On Sat, 5 Sep 2020, Marton Balint wrote: SMPTE 12M timecode can only count frames up to 39, because the tens-of-frames value is stored in 2 bit. In order to resolve this 50/60 fps SMPTE timecode is using the field bit (which is the same bit as the phase correction bit) to signal the least sign

[FFmpeg-devel] [PATCH 2/2] avcodec/adxdec: add support for new extradata in packet sidedata

2020-09-12 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/adxdec.c | 16 1 file changed, 16 insertions(+) diff --git a/libavcodec/adxdec.c b/libavcodec/adxdec.c index 40ed8e5ba7..81ffc8b296 100644 --- a/libavcodec/adxdec.c +++ b/libavcodec/adxdec.c @@ -103,6 +103,22 @@ static int adx_decode_fr

[FFmpeg-devel] [PATCH 1/2] avformat: add CRI AAX demuxer

2020-09-12 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/aaxdec.c | 324 +++ libavformat/allformats.c | 1 + 3 files changed, 326 insertions(+) create mode 100644 libavformat/aaxdec.c diff --git a/libavformat/Makefile b/libavformat/

Re: [FFmpeg-devel] [PATCH] avcodec/notchlc: Check available space for luma block code

2020-09-12 Thread Paul B Mahol
On Sat, Sep 12, 2020 at 06:43:30PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (too long -> 2sec) > Fixes: > 25439/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NOTCHLC_fuzzer-5688211127664640 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/pr

Re: [FFmpeg-devel] [PATCH 1/2] avformat: add CRI AAX demuxer

2020-09-12 Thread James Almer
On 9/12/2020 7:33 PM, Paul B Mahol wrote: > +static int aax_read_packet(AVFormatContext *s, AVPacket *pkt) > +{ > +AAXContext *a = s->priv_data; > +AVCodecParameters *par = s->streams[0]->codecpar; > +AVIOContext *pb = s->pb; > +const int size = 18 * par->channels; > +int ret, e

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/arbc: Assume that at least one segment has a tile

2020-09-12 Thread Paul B Mahol
On Sat, Sep 12, 2020 at 08:18:54PM +0200, Michael Niedermayer wrote: > If no segment has a tile, the segment count really should be 0 > Fixes: Timeout (61sec -> 2sec) > Fixes: > 25445/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ARBC_fuzzer-5657711222718464 > > Found-by: continuous fuzzing p

Re: [FFmpeg-devel] [PATCH 1/2] avformat: add CRI AAX demuxer

2020-09-12 Thread Andreas Rheinhardt
Paul B Mahol: > Signed-off-by: Paul B Mahol > --- > libavformat/Makefile | 1 + > libavformat/aaxdec.c | 324 +++ > libavformat/allformats.c | 1 + > 3 files changed, 326 insertions(+) > create mode 100644 libavformat/aaxdec.c > > diff --git a/lib

Re: [FFmpeg-devel] [PATCH 4/6] avformat/cdg: Fix integer overflow in duration computation

2020-09-12 Thread Michael Niedermayer
On Sun, Jul 19, 2020 at 07:42:16PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 8398407 * 300 cannot be represented in type > 'int' > Fixes: > 23914/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-4702539290509312 > > Found-by: continuous fuzzing process > https://gi

Re: [FFmpeg-devel] [PATCH 6/6] tools:target_dem_fuzzer: Split into a fuzzer fuzzing at the protocol level and one fuzzing a fixed demuxer input

2020-09-12 Thread Michael Niedermayer
On Sun, Jul 19, 2020 at 07:42:18PM +0200, Michael Niedermayer wrote: > This should improve coverage and should improve the efficiency of seed files > > Signed-off-by: Michael Niedermayer > --- > Makefile | 3 +++ > tools/Makefile| 5 - > tools/target_dem_fuzzer.c

[FFmpeg-devel] [PATCH] avformat: add CRI AAX demuxer

2020-09-12 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/adxdec.c | 16 ++ libavformat/Makefile | 1 + libavformat/aaxdec.c | 340 +++ libavformat/allformats.c | 1 + 4 files changed, 358 insertions(+) create mode 100644 libavformat/aaxdec.c diff --git a/

Re: [FFmpeg-devel] [PATCH] avformat: add CRI AAX demuxer

2020-09-12 Thread James Almer
On 9/12/2020 8:13 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/adxdec.c | 16 ++ > libavformat/Makefile | 1 + > libavformat/aaxdec.c | 340 +++ > libavformat/allformats.c | 1 + > 4 files changed, 358 insertions(+)

Re: [FFmpeg-devel] [PATCH] avformat: add CRI AAX demuxer

2020-09-12 Thread Andreas Rheinhardt
Paul B Mahol: > Signed-off-by: Paul B Mahol > --- > libavcodec/adxdec.c | 16 ++ Why are you sending the encoder patch in the same patch? > libavformat/Makefile | 1 + > libavformat/aaxdec.c | 340 +++ > libavformat/allformats.c | 1 + > 4 f

Re: [FFmpeg-devel] [PATCH] avformat: add CRI AAX demuxer

2020-09-12 Thread Andreas Rheinhardt
Paul B Mahol: > Signed-off-by: Paul B Mahol > --- > libavcodec/adxdec.c | 16 ++ > libavformat/Makefile | 1 + > libavformat/aaxdec.c | 340 +++ > libavformat/allformats.c | 1 + > 4 files changed, 358 insertions(+) > create mode 100644 libav

[FFmpeg-devel] [PATCH 01/16] avcodec/snowdec: Use ff_snow_common_init() directly

2020-09-12 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/snowdec.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/libavcodec/snowdec.c b/libavcodec/snowdec.c index 5e69f39022..68afe0df26 100644 --- a/libavcodec/snowdec.c +++ b/libavcodec/snowdec.c @@ -422,17 +422,6 @@ s

[FFmpeg-devel] [PATCH 02/16] avcodec/pcm-dvd: Avoid allocation of buffer

2020-09-12 Thread Andreas Rheinhardt
In this case, it also allows to remove the decoder's close function. Signed-off-by: Andreas Rheinhardt --- libavcodec/pcm-dvd.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/libavcodec/pcm-dvd.c b/libavcodec/pcm-dvd.c index 0a751a8191..725c2f5b29 100644 --

[FFmpeg-devel] [PATCH 08/16] avcodec/roqaudioenc: Avoid redundant free of unallocated buffer

2020-09-12 Thread Andreas Rheinhardt
If allocating a buffer in RoQ DPCM encoder's init function failed, the close function would be called manually; all this function does is freeing said buffer, but given that it has not been allocated at all, this is unnecessary. Signed-off-by: Andreas Rheinhardt --- libavcodec/roqaudioenc.c | 10

[FFmpeg-devel] [PATCH 09/16] avcodec/sonic: Fix leaks upon allocation errors

2020-09-12 Thread Andreas Rheinhardt
The Sonic decoder and encoders allocate several buffers in their init function and return immediately if one of these allocations fails; this will lead to leaks if there was an earlier successfull allocation. Fix this by setting the FF_CODEC_CAP_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt

[FFmpeg-devel] [PATCH 04/16] avcodec/qtrleenc: Fix memleak upon allocation failure

2020-09-12 Thread Andreas Rheinhardt
The qtrle encoder allocates several buffers and an AVFrame in its init function. If one of these allocations fails, but others succeed, the successfully allocated objects leak. This is fixed by setting the FF_CODEC_CAP_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavcodec/qtrleenc.

[FFmpeg-devel] [PATCH 03/16] avcodec/pcm-dvdenc: Remove empty function

2020-09-12 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/pcm-dvdenc.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/libavcodec/pcm-dvdenc.c b/libavcodec/pcm-dvdenc.c index d26eaf071c..63f6e5d81b 100644 --- a/libavcodec/pcm-dvdenc.c +++ b/libavcodec/pcm-dvdenc.c @@ -170,11 +170,6 @@ static int

[FFmpeg-devel] [PATCH 05/16] avcodec/ra144enc: Don't free unnecessarily

2020-09-12 Thread Andreas Rheinhardt
The init function of the real_144 encoder calls its own close function if a call to ff_lpc_init() fails; yet nothing has been allocated before that point and ff_lpc_init() can be expected to clean up after itself on error (the documentation does not say anything to the contrary and the current impl

[FFmpeg-devel] [PATCH 11/16] avcodec/svq3: Fix memleaks upon allocation error

2020-09-12 Thread Andreas Rheinhardt
Commit b2361cfb94738298a6c4037cc348fe5015efb841e made all of the error paths in svq3_decode_init() call svq3_decode_end(); yet several new error paths that were added later (in merges from Libav) returned directly without cleaning up properly. This commit fixes the resulting potential memleaks by s

[FFmpeg-devel] [PATCH 12/16] avcodec/svq3: Remove unused buffer

2020-09-12 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/svq3.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c index 41a9bf2daa..0ac81364bd 100644 --- a/libavcodec/svq3.c +++ b/libavcodec/svq3.c @@ -75,10 +75,6 @@ typedef struct SVQ3Fra

[FFmpeg-devel] [PATCH 06/16] avcodec/ra288: Avoid indirection when calling float dsp function

2020-09-12 Thread Andreas Rheinhardt
Do this by only keeping the only function pointer from the AVFloatDSPContext that is needed lateron. This also allows to remove the decoder's close function. Signed-off-by: Andreas Rheinhardt --- libavcodec/ra288.c | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-)

[FFmpeg-devel] [PATCH 10/16] avcodec/svq3: Avoid allocations for SVQ3Frames

2020-09-12 Thread Andreas Rheinhardt
These frames can be made part of the SVQ3Context; notice that the pointers to the frames have been retained in order to allow to just swap them as the code already does. Signed-off-by: Andreas Rheinhardt --- libavcodec/svq3.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-)

[FFmpeg-devel] [PATCH 07/16] avcodec/pcm: Avoid indirection when calling float dsp function

2020-09-12 Thread Andreas Rheinhardt
Do this by only keeping the only function pointer from the AVFloatDSPContext that is needed lateron. This also allows to remove the decoders' close function. Signed-off-by: Andreas Rheinhardt --- libavcodec/pcm.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-)

[FFmpeg-devel] [PATCH 13/16] avcodec/svq3: Avoid overhead of AVBuffer API

2020-09-12 Thread Andreas Rheinhardt
Up until now, the SVQ3 decoder allocated several refcounted buffers, despite no sharing/refcounting happening at all: Their refcount never exceeds one and they are treated like ordinary buffers (with the exception that the pointer used to access them is in the middle of the allocated buffer, but th

[FFmpeg-devel] [PATCH 14/16] avcodec/tscc2: Cleanup generically after init failure

2020-09-12 Thread Andreas Rheinhardt
Do this by setting the FF_CODEC_CAP_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavcodec/tscc2.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/libavcodec/tscc2.c b/libavcodec/tscc2.c index 65fbb010f6..6aadb51ad4 100644 --- a/libavcodec/tscc2.c

[FFmpeg-devel] [PATCH 16/16] avcodec/vble: Don't free buffer known to be NULL

2020-09-12 Thread Andreas Rheinhardt
Freeing a buffer allocated in the VBLE decoder's init function is the only thing the decoder's close function does and this implies that it is unnecessary to call it in case said allocation fails. Yet this is what has been done. Signed-off-by: Andreas Rheinhardt --- libavcodec/vble.c | 1 - 1 fi

[FFmpeg-devel] [PATCH 15/16] avcodec/vb: Cleanup generically after init failure

2020-09-12 Thread Andreas Rheinhardt
In other words: Set the FF_CODEC_CAP_INIT_CLEANUP flag. Signed-off-by: Andreas Rheinhardt --- libavcodec/vb.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/vb.c b/libavcodec/vb.c index d9c6b93a73..fe419c7663 100644 --- a/libavcodec/vb.c +++ b/libavcodec/vb.

Re: [FFmpeg-devel] [PATCH v5 2/2] libavformat/webp: add WebP demuxer

2020-09-12 Thread Zlomek, Josef
Dne so 12. 9. 2020 22:35 uživatel Carl Eugen Hoyos napsal: > Am Fr., 11. Sept. 2020 um 08:36 Uhr schrieb Josef Zlomek : > > This is not the requested review, I am just curious about the > behaviour: > > > +static int webp_probe(const AVProbeData *p) > > +{ > > +const uint8_t *b = p->buf; > >

[FFmpeg-devel] [PATCH 1/2] lavfi/drawtext: Add reinit to debug message

2020-09-12 Thread Jun Zhao
From: Jun Zhao Add reinit flag to debug message, it's help to debug sending commands to drawtext. Signed-off-by: Jun Zhao --- libavfilter/vf_drawtext.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c index abe1ca6..1

[FFmpeg-devel] [PATCH 2/2] lavfi/sendcmd: correct the option flags dump

2020-09-12 Thread Jun Zhao
From: Jun Zhao correct the option flags dump for sendcmd/asendcmd. Signed-off-by: Jun Zhao --- libavfilter/f_sendcmd.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/libavfilter/f_sendcmd.c b/libavfilter/f_sendcmd.c index 6b02669..5e4c891 10064