On Wed, 09 Sep 2020 00:04:43 +
"Zane van Iperen" wrote:
>
> Adds support for demuxing BRP files from Argonaut Games' games.
> Used to store the FMVs.
>
> v2: [1]
> - Don't add AV_CODEC_ID_ARGO descriptor, use AV_CODEC_ID_NONE instead.
>
> [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2020
On Tue, Sep 08, 2020 at 06:44:11PM +0200, Nicolas George wrote:
> Jean-Baptiste Kempf (12020-09-08):
> > I think the explanation is quite aggressive and has absolutely nothing
> > to do inside a git log, to be honest.
> >
> > The fact that you disagree on the commit is fine, but being passive
> >
On Thu, Sep 10, 2020 at 10:41:09PM +0200, Andreas Rheinhardt wrote:
> Paul B Mahol:
> > Signed-off-by: Paul B Mahol
> > ---
> > libavformat/moflex.c | 19 ++-
> > 1 file changed, 18 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavformat/moflex.c b/libavformat/moflex.c
> >
On Thu, Sep 10, 2020 at 11:48:53PM +0200, Andreas Rheinhardt wrote:
> Happened on several error conditions, e.g. if there is just no decoder
> for the format (like with svg images).
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavfilter/lavfutils.c | 4 ++--
> 1 file changed, 2 insertions(+),
On Fri, Sep 11, 2020 at 01:19:59AM +0200, Michael Niedermayer wrote:
> Fixes: index -1 out of bounds for type 'const uint8_t [6][16]'
> Fixes: out of array read
> Fixes: shift exponent -21 is negative
> Fixes:
> 25422/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOBICLIP_fuzzer-57482582265692
On Fri, Sep 11, 2020 at 01:49:09AM +0200, Andreas Rheinhardt wrote:
> Before commit 2f76476549a01ae2c4ec2a440e4b14c5aba64869, avfilter.h
> contained no typedef for AVFilterChannelLayouts; all references to it
> were done using its struct tag. formats.h meanwhile contained the
> definition of the st
Andreas Rheinhardt (12020-09-10):
> Signed-off-by: Andreas Rheinhardt
> ---
> libavfilter/lavfutils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
LGTM.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-de
On Thu, Sep 10, 2020 at 11:48:54PM +0200, Andreas Rheinhardt wrote:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavfilter/lavfutils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
ok
> diff --git a/libavfilter/lavfutils.c b/libavfilter/lavfutils.c
> index 84dd4c0704..d7de89f4b3 1
On Thu, Sep 10, 2020 at 11:48:58PM +0200, Andreas Rheinhardt wrote:
> av_read_frame() can handle uninitialized packets.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavfilter/vf_subtitles.c | 3 ---
> 1 file changed, 3 deletions(-)
>
probably ok
> diff --git a/libavfilter/vf_subtitles.c b/
Andreas Rheinhardt (12020-09-10):
> av_read_frame() can handle uninitialized packets.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavfilter/lavfutils.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
LGTM.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
On Thu, Sep 10, 2020 at 11:48:57PM +0200, Andreas Rheinhardt wrote:
> init_subtitles() sometimes returned directly upon error without cleaning
> up after itself. The easiest way to trigger this is by using
> picture-based subtitles; it is also possible to run into this in case of
> missing decoders
Andreas Rheinhardt (12020-09-10):
> Signed-off-by: Andreas Rheinhardt
> ---
> libavfilter/vf_uspp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Looks ok.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-
Andreas Rheinhardt (12020-09-10):
> libavcodec major version is already 58.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavfilter/vf_subtitles.c | 10 +++---
> 1 file changed, 3 insertions(+), 7 deletions(-)
LGTM.
Regards,
--
Nicolas George
signature.asc
Description: PGP signatur
On Thu, Sep 10, 2020 at 11:49:01PM +0200, Andreas Rheinhardt wrote:
> The user has no business modifying the underlying AVCodec.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> fftools/ffmpeg.h | 5 +++--
> fftools/ffmpeg_filter.c| 5 +++--
> libavcodec/avrndec.c | 2 +-
> liba
On Thu, Sep 10, 2020 at 11:49:00PM +0200, Andreas Rheinhardt wrote:
> There is nothing to free at this point.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavfilter/vf_subtitles.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
probably ok
>
> diff --git a/libavfilter/vf_subtitles.
On Thu, Sep 10, 2020 at 11:48:59PM +0200, Andreas Rheinhardt wrote:
> libavcodec major version is already 58.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavfilter/vf_subtitles.c | 10 +++---
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
ok
> diff --git a/libavfilter/vf_subtitle
Andreas Rheinhardt (12020-09-10):
> There is nothing to free at this point.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavfilter/vf_subtitles.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Does it help anything? If something gets allocated earlier, we will need
to add it back. W
Andreas Rheinhardt (12020-09-10):
> init_subtitles() sometimes returned directly upon error without cleaning
> up after itself. The easiest way to trigger this is by using
> picture-based subtitles; it is also possible to run into this in case of
> missing decoders or allocation failures.
>
> Furt
Andreas Rheinhardt (12020-09-10):
> av_read_frame() can handle uninitialized packets.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavfilter/vf_subtitles.c | 3 ---
> 1 file changed, 3 deletions(-)
LGTM.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
_
Andreas Rheinhardt (12020-09-10):
> The user has no business modifying the underlying AVCodec.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> fftools/ffmpeg.h | 5 +++--
> fftools/ffmpeg_filter.c| 5 +++--
> libavcodec/avrndec.c | 2 +-
> libavcodec/utils.c | 4 ++--
>
Andreas Rheinhardt (12020-09-11):
> Before commit 2f76476549a01ae2c4ec2a440e4b14c5aba64869, avfilter.h
> contained no typedef for AVFilterChannelLayouts; all references to it
> were done using its struct tag. formats.h meanwhile contained the
> definition of the struct and a typedef for it. Said co
Andreas Rheinhardt (12020-09-11):
> ff_formats_ref() takes a pointer to an AVFilterFormats and a pointer to
> a pointer to an AVFilterFormats as arguments and adds the latter as an
> owner to the list pointed to by the former; the latter is hereby always
> the address of a list contained in an AVFi
On Tue, Sep 08, 2020 at 19:52:29 +0200, Marton Balint wrote:
> Subject: Re: [FFmpeg-devel] [PATCH 1/4] avdevice/decklink_commoh.h: remove
Nit: typo^
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel
Timo Rothenpieler (12020-09-11):
> Entirely outside of this filter being acceptable at all,
> pulling in libcurl is not an option without major safeguards for every
> single overlapping tls library both ffmpeg and curl support.
> If both are using the same library, there is a huge potential for lib
Nicolas George:
> Andreas Rheinhardt (12020-09-10):
>> There is nothing to free at this point.
>>
>> Signed-off-by: Andreas Rheinhardt
>> ---
>> libavfilter/vf_subtitles.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Does it help anything? If something gets allocated earlier, we
Signed-off-by: Paul B Mahol
---
libavformat/Makefile | 1 +
libavformat/allformats.c | 1 +
libavformat/svs.c| 96
3 files changed, 98 insertions(+)
create mode 100644 libavformat/svs.c
diff --git a/libavformat/Makefile b/libavformat/Makefi
Hi all!
WebRTC can be an intimidating monster, and we all are aware of that.
Also, the fact that every webrtc media server/service has their own
custom protocol has not helped to increase its adoption in the streaming
world, with still relies heavily on other protocols like RTMP, SRTP or
even
Andreas Rheinhardt (12020-09-11):
> It avoids cleaning up three inexistent objects; I actually regarded this
> as enough benefit to merit the change.
Cleaning-up inexistent objects is a negligible cost. In this case, it
happens in a part of the code that is particularly not speed-critical. I
think
> Hard-coded URL parameters,
>nothing to set the formats, not even the possibility of a filter that
>changes the resolution.
This filter has options: url and content-type header for requests and it's not
hardcoded. Format and resolution can be changed after this filter later in
filter graph, it'
Alex (12020-09-11):
> This filter has options: url and content-type header for requests and it's
> not hardcoded.
The format for the parameters is hard-coded.
> Format and resolution can be changed after this filter later in filter
> graph, it's not a job for this filter, for example:
It is a j
Should reduce decoding overhead.
Signed-off-by: Paul B Mahol
---
libavcodec/adpcm.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c
index 71e37efde7..e409a3aa6a 100644
--- a/libavcodec/adpcm.c
+++ b/libavcodec/adpcm.c
@@ -1966,11
>The format for the parameters is hard-coded.Please, tell me more I don't
>understand that do You mean?
--- Original message ---
From: "Nicolas George"
Date: 11 September 2020, 14:09:47
Alex (12020-09-11):
> This filter has options: url and content-type header for requests and it's
> not hardc
On Sun, Aug 02, 2020 at 10:21:12AM +, Zane van Iperen wrote:
> Signed-off-by: Zane van Iperen
> ---
> Changelog| 1 +
> libavformat/Makefile | 1 +
> libavformat/allformats.c | 1 +
> libavformat/argo_asf.c | 123 ++-
> libavform
On 11/09/2020 13:49, Lynne wrote:
On 11/09/2020 12:31, Sergio Garcia Murillo wrote:
Hi all!
WebRTC can be an intimidating monster, and we all are aware of that.
Also, the fact that every webrtc media server/service has their own
custom protocol has not helped to increase its adoption in the str
> The hard-coding of HTTP, the hard-coding of the parameters passing, the
> arbitrary limitations make> this unacceptable.
Can You explain more, because I not fully understand "hard-coding " params,
http.
> It is a job for this filter if the external processing requires it. As
> it is, the exte
On Fri, 11 Sep 2020 13:45:58 +0200
"Paul B Mahol" wrote:
>
> On Sun, Aug 02, 2020 at 10:21:12AM +, Zane van Iperen wrote:
> > Signed-off-by: Zane van Iperen
> > ---
> > Changelog| 1 +
> > libavformat/Makefile | 1 +
> > libavformat/allformats.c | 1 +
> > libavfo
On Fri, 11 Sep 2020 13:29:39 +0200
"Paul B Mahol" wrote:
>
> Should reduce decoding overhead.
>
> Signed-off-by: Paul B Mahol
> ---
> libavcodec/adpcm.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c
> index 71e37efde7.
On Fri, Sep 11, 2020 at 01:14:02PM +, Zane van Iperen wrote:
> On Fri, 11 Sep 2020 13:29:39 +0200
> "Paul B Mahol" wrote:
>
> >
> > Should reduce decoding overhead.
> >
> > Signed-off-by: Paul B Mahol
> > ---
> > libavcodec/adpcm.c | 7 +--
> > 1 file changed, 5 insertions(+), 2 delet
On 9/10/2020 10:38 AM, James Almer wrote:
> Signed-off-by: James Almer
> ---
> libavcodec/thread.h | 2 +-
> libavcodec/utils.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/thread.h b/libavcodec/thread.h
> index 540135fbc9..87bf154da9 100644
> --- a/lib
On Thu, Sep 10, 2020 at 02:02:20PM +0200, Michael Niedermayer wrote:
> This avoids per codec checks for channels not being 0
>
> Fixes: division by 0
> Fixes:
> 25419/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FASTAUDIO_fuzzer-5632544761184256
> Fixes:
> 25433/clusterfuzz-testcase-minimiz
On Thu, Sep 10, 2020 at 02:02:19PM +0200, Michael Niedermayer wrote:
> Suggested-by: Paul B Mahol
> See: [FFmpeg-devel] [PATCH 1/3] avcodec/fastaudio: Check channels
> Signed-off-by: Michael Niedermayer
> ---
> libavcodec/ac3dec_fixed.c | 3 ++-
> libavcodec/ac3dec_float.c | 6
Alex (12020-09-11):
> Can You explain more, because I not fully understand "hard-coding " params,
> http.
Where does it say that the size and format of the frame needs to be
passed as "width=1280&height=720&format=1" rather than
"1280x720/yuv420p"?
In fact, where did you find that using the nume
El vie., 11 sept. 2020 15:23, Lynne escribió:
> On 11/09/2020 14:16, Sergio Garcia Murillo wrote:
> > On 11/09/2020 13:49, Lynne wrote:
> >
> > WebRTC uses rtp muxing to send all data in the same udp port, and lip
> > sync based on rtcp (also muxed on same udp port). It has been working
> > for
On 11/09/2020 12:31, Sergio Garcia Murillo wrote:
> Hi all!
>
> WebRTC can be an intimidating monster, and we all are aware of that.
> Also, the fact that every webrtc media server/service has their own
> custom protocol has not helped to increase its adoption in the streaming
> world, with still
On Fri, 11 Sep 2020 at 11:31, Sergio Garcia Murillo <
sergio.garcia.muri...@gmail.com> wrote:
> Hi all!
>
> WebRTC can be an intimidating monster, and we all are aware of that.
> Also, the fact that every webrtc media server/service has their own
> custom protocol has not helped to increase its ad
This enables us to utilize AVFrames for initialization parameters
further down the line.
---
fftools/ffmpeg.c | 63 ++--
1 file changed, 34 insertions(+), 29 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index cb7644de6a..24b8e175a6 1006
Adds a wrapper function, which handles any errors depending on how
fatal a failure would be.
---
fftools/ffmpeg.c | 51
1 file changed, 25 insertions(+), 26 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 84306818a2..cb7644de6a
Additionally, reap the first rewards by being able to set the
color related encoding values based on the passed AVFrame.
---
fftools/ffmpeg.c | 40 ++--
1 file changed, 30 insertions(+), 10 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 24b
This should make it easier to spot such cases.
---
fftools/ffmpeg.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 63c8771a01..70e7274d87 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -3281,6 +3281,20 @@ static int init_outpu
This patch set started with a very simple wish to not have to set color
related values manually each time when utilizing ffmpeg.c.
I do not have the whole FATE suite locally, so most likely some test will
fail due to expectations of the metadata not being set for video - or due to
me failing to ha
Unused since 41b0561dc7246b72a834067da539ae98b1ec6631.
Signed-off-by: Andreas Rheinhardt
---
Completely untested as I don't have a CrystalHD device.
libavcodec/crystalhd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/libavcodec/crystalhd.c b/libavcodec/crystalhd.c
index e3c5955969..2288
On 9/11/2020 1:52 PM, Andreas Rheinhardt wrote:
> Unused since 41b0561dc7246b72a834067da539ae98b1ec6631.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> Completely untested as I don't have a CrystalHD device.
>
> libavcodec/crystalhd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/li
On 11/09/2020 14:16, Sergio Garcia Murillo wrote:
> On 11/09/2020 13:49, Lynne wrote:
>
> WebRTC uses rtp muxing to send all data in the same udp port, and lip
> sync based on rtcp (also muxed on same udp port). It has been working
> for years.
Its still a bit of a mess, and it took many years t
Decode and discard them.
Fixes ticket 4641.
---
libavcodec/opus_silk.c | 28
libavcodec/opustab.c | 3 +++
libavcodec/opustab.h | 3 +++
3 files changed, 26 insertions(+), 8 deletions(-)
diff --git a/libavcodec/opus_silk.c b/libavcodec/opus_silk.c
index 2fcbf3b
On Fri, Sep 11, 2020 at 11:12:33AM +0200, Paul B Mahol wrote:
> On Fri, Sep 11, 2020 at 01:19:59AM +0200, Michael Niedermayer wrote:
> > Fixes: index -1 out of bounds for type 'const uint8_t [6][16]'
> > Fixes: out of array read
> > Fixes: shift exponent -21 is negative
> > Fixes:
> > 25422/cluste
On Fri, Sep 11, 2020 at 08:09:48PM +0200, Michael Niedermayer wrote:
> On Fri, Sep 11, 2020 at 11:12:33AM +0200, Paul B Mahol wrote:
> > On Fri, Sep 11, 2020 at 01:19:59AM +0200, Michael Niedermayer wrote:
> > > Fixes: index -1 out of bounds for type 'const uint8_t [6][16]'
> > > Fixes: out of arra
On 9/7/2020 11:31 AM, James Almer wrote:
> And replace the flags parameter with a function callback that can be used to
> copy the contents of the packet (e.g, av_packet_ref and av_packet_copy_props).
>
> Signed-off-by: James Almer
> ---
> This version achieves the same effect as v2 while being c
On 11/09/2020 17:29, Kieran Kunhya wrote:
On Fri, 11 Sep 2020 at 11:31, Sergio Garcia Murillo <
sergio.garcia.muri...@gmail.com> wrote:
Hi all!
WebRTC can be an intimidating monster, and we all are aware of that.
Also, the fact that every webrtc media server/service has their own
custom protoc
On Fri, 11 Sep 2020 at 21:41, Sergio Garcia Murillo <
sergio.garcia.muri...@gmail.com> wrote:
> On 11/09/2020 17:29, Kieran Kunhya wrote:
> > On Fri, 11 Sep 2020 at 11:31, Sergio Garcia Murillo <
> > sergio.garcia.muri...@gmail.com> wrote:
> >
> >> Hi all!
> >>
> >> WebRTC can be an intimidating m
On 11/09/2020 19:37, Anton Khirnov wrote:
> Decode and discard them.
>
> Fixes ticket 4641.
> ---
> libavcodec/opus_silk.c | 28
> libavcodec/opustab.c | 3 +++
> libavcodec/opustab.h | 3 +++
> 3 files changed, 26 insertions(+), 8 deletions(-)
>
> diff --git a
60 matches
Mail list logo
