Re: [FFmpeg-devel] [PATCH] avformat/argo_asf: fix handling of v1.1 files

2020-09-06 Thread Zane van Iperen
On Sat, 05 Sep 2020 12:05:03 + "Zane van Iperen" wrote: > > Version 1.1 (FX Fighter) files all have a sample rate of 44100 > in the header, but only play back correctly at 22050. > > Force the sample rate to 22050 when reading, and restrict it > when muxing. > > Signed-off-by: Zane van Ipe

[FFmpeg-devel] [PATCH] Added MKV tag for AVS2 codec

2020-09-06 Thread Ze Yuan
From de8c6cdb3325bed66185bfd80ce4e39c5dd62cf6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=83=91=E5=A4=A9=E6=B3=A2?= Date: Sun, 6 Sep 2020 16:34:33 +0800 Subject: [PATCH] Added MKV tag for AVS2 codec avs2 (IEEE 1857.4) video codec MKV spec: V_AVS2 Codec ID: V_AVS2 Codec Name: AVS2-P2/IEEE.1857.4

Re: [FFmpeg-devel] [PATCH] avfilter/vf_lut3d: support remaping negative values in the prelut

2020-09-06 Thread Paul B Mahol
On Sat, Sep 05, 2020 at 02:13:01PM -0700, mindm...@gmail.com wrote: > From: Mark Reid > > --- > libavfilter/vf_lut3d.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c > index 6730a424ce..988f6c8b55 100644 > --- a/l

Re: [FFmpeg-devel] [PATCH] libavcodec/options_table: Add missing colorspace options

2020-09-06 Thread Harry Mallon
Is there anything I need to do to move this forwards? I think it is relatively uncontroversial? Harry ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmp

[FFmpeg-devel] [PATCH V2] Added MKV tag for AVS2 video codec

2020-09-06 Thread Ze Yuan
From ea96e70874c87b003af1fb3fcd5c792b3292bf29 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=83=91=E5=A4=A9=E6=B3=A2?= Date: Sun, 6 Sep 2020 18:35:51 +0800 Subject: [PATCH] Added MKV tag for AVS2 video codec avs2 (IEEE 1857.4) video codec MKV spec: V_AVS2 Codec ID: V_AVS2 Codec Name: AVS2-P2/IEEE.

Re: [FFmpeg-devel] [PATCH] libavcodec/options_table: Add missing colorspace options

2020-09-06 Thread Gyan Doshi
On 06-09-2020 02:59 pm, Harry Mallon wrote: Is there anything I need to do to move this forwards? I think it is relatively uncontroversial? Agreed. Will push in 3 days if there are no objections. Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffm

Re: [FFmpeg-devel] [PATCH v4 2/2] dnn_backend_native_layer_conv2d.c:Add mutithread function

2020-09-06 Thread Xu Jun
Hi, Steven - Original Message - > From: "Steven Liu" > To: "FFmpeg development discussions and patches" > Sent: Saturday, September 5, 2020 6:07:45 AM > Subject: Re: [FFmpeg-devel] [PATCH v4 2/2] > dnn_backend_native_layer_conv2d.c:Add mutithread function > 于2020年9月4日周五 下午11:09写道: >>

[FFmpeg-devel] [PATCH v5 1/2] dnn_backend_native.c: parse options in native backend

2020-09-06 Thread xujunzz
From: Xu Jun Signed-off-by: Xu Jun --- v2: use av_opt_set_from_string instead of function dnn_parse_option(). v3: make all the options supported, not just conv2d_threads v4: move dnn_native_options and dnn_native_class to from .h to .c. libavfilter/dnn/dnn_backend_native.c | 22 +++

[FFmpeg-devel] [PATCH v5 2/2] dnn_backend_native_layer_conv2d.c:Add mutithread function

2020-09-06 Thread xujunzz
From: Xu Jun Use pthread to multithread dnn_execute_layer_conv2d. Can be tested with command "./ffmpeg_g -i input.png -vf \ format=yuvj420p,dnn_processing=dnn_backend=native:model= \ espcn.model:input=x:output=y:options=conv2d_threads=23 \ -y sr_native.jpg -benchmark" before patch: utime=11.238

[FFmpeg-devel] [PATCH 1/2] avcodec/ffwavesynth: Fix integer overflow in wavesynth_synth_sample / WS_SINE

2020-09-06 Thread Michael Niedermayer
Fixes: signed integer overflow: -1429092 * -32596 cannot be represented in type 'int' Fixes: 24419/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5157849974702080 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off

Re: [FFmpeg-devel] qsv: question on CONFIG macros

2020-09-06 Thread Mark Thompson
On 04/09/2020 16:57, Rogozhkin, Dmitry V wrote: Hi, Can someone, please, help to clarify: 1. Where CONFIG_QSV and CONFIG_LIBMFX gets defined (I don't see that in the grep output - attached below)? By configure, they end up in config.h in the build directory. 2. What's relationship between

[FFmpeg-devel] [PATCH 2/2] tools/target_dec_fuzzer: Adjust threshold for WMV3IMAGE

2020-09-06 Thread Michael Niedermayer
Fixes: Timeout (1131sec -> 1sec) Fixes: 24727/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMV3IMAGE_fuzzer-5754167793287168 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c

Re: [FFmpeg-devel] [PATCH 3/8] avutil/timecode: do not trash bits on invalid av_timecode_get_smpte arguments

2020-09-06 Thread lance . lmwang
On Sat, Sep 05, 2020 at 08:22:12PM +0200, Marton Balint wrote: > The function has no way to return error, so let's clip or calculate modulo. > > Signed-off-by: Marton Balint > --- > libavutil/timecode.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavutil/timecode.c b/libavut

Re: [FFmpeg-devel] [PATCH 6/8] avcodec: use av_timecode_make_smpte_tc_string2 in hevc and h264 decoder

2020-09-06 Thread lance . lmwang
On Sat, Sep 05, 2020 at 08:22:15PM +0200, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavcodec/h264_slice.c | 2 +- > libavcodec/hevcdec.c| 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c > index c7

Re: [FFmpeg-devel] [PATCH 2/8] avutil/timecode: cosmetics on av_timecode_get_smpte

2020-09-06 Thread lance . lmwang
On Sat, Sep 05, 2020 at 08:22:11PM +0200, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavutil/timecode.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/libavutil/timecode.c b/libavutil/timecode.c > index cb916970ef..c0956adadb 100644 > ---

Re: [FFmpeg-devel] [PATCH] lavc/qsvdec: allow qsv decoders to use initialized device

2020-09-06 Thread Mark Thompson
On 04/09/2020 19:24, Rogozhkin, Dmitry V wrote: On Thu, 2020-09-03 at 01:02 +, Rogozhkin, Dmitry V wrote: (If you do implement it then you can delete all of the ad-hoc treatment in ffmpeg, like has been done for the other hardware codecs.) I like deleting code:). Ok, this sounds good. Let

Re: [FFmpeg-devel] [PATCH 1/2] avformat/dv: allow returning damaged audio

2020-09-06 Thread Dave Rice
> On Aug 3, 2020, at 5:16 PM, Michael Niedermayer > wrote: > > On Mon, Aug 03, 2020 at 10:38:21PM +0200, Marton Balint wrote: >> >> >> On Sun, 2 Aug 2020, Dave Rice wrote: >> >>> >>> On Aug 1, 2020, at 5:26 PM, Marton Balint wrote: On Sat, 1 Aug 2020, Michael N

Re: [FFmpeg-devel] [PATCH 7/8] avfilter/vf_showinfo: use av_timecode_make_smpte_tc_string2

2020-09-06 Thread lance . lmwang
On Sat, Sep 05, 2020 at 08:22:16PM +0200, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavfilter/vf_showinfo.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c > index 1be939614d..c63e6f075f 1006

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_buffers: remove unused function argument

2020-09-06 Thread Andriy Gelman
On Thu, 27. Aug 23:12, Andriy Gelman wrote: > From: Andriy Gelman > > Signed-off-by: Andriy Gelman > --- > libavcodec/v4l2_buffers.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/v4l2_buffers.c b/libavcodec/v4l2_buffers.c > index 02f23d954b..4b2679

Re: [FFmpeg-devel] [PATCH] ffplay: fix autoexit doesn't work in the case of pb->error

2020-09-06 Thread Zhao Zhili
> On Aug 27, 2020, at 4:20 PM, Marton Balint wrote: > > > > On Thu, 27 Aug 2020, Zhao Zhili wrote: > >> --- >> Goto fail will make ffplay exit immediately. I'm not sure >> it is the expected behavior. How about just remove the >> check on pb->error so decoders can drain normally? > > I thin

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/jpeglsenc: Don't use put bits API for byte-aligned writes

2020-09-06 Thread Paul B Mahol
On Sat, Sep 05, 2020 at 01:17:09AM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > Is it actually guaranteed that the allocated packet size is > sufficient? If it is, one could use unchecked writes throughout; if it > isn't, should I add a check to properly error out i

Re: [FFmpeg-devel] [PATCH 3/8] avcodec/jpeglsenc: Move check out of loop

2020-09-06 Thread Paul B Mahol
On Sat, Sep 05, 2020 at 01:17:11AM +0200, Andreas Rheinhardt wrote: > ls_encode_line() encodes a line of input, going from left to right. In > order to calculate a predicted value it uses the left and upper-left > value of the output picture (that is, it uses how a decoder would see > the already e

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/ffwavesynth: Fix integer overflow in wavesynth_synth_sample / WS_SINE

2020-09-06 Thread Nicolas George
Michael Niedermayer (12020-09-06): > Fixes: signed integer overflow: -1429092 * -32596 cannot be represented in > type 'int' > Fixes: > 24419/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5157849974702080 > > Found-by: continuous fuzzing process > https://github.com/googl

Re: [FFmpeg-devel] [PATCH] ffmpeg_qsv: use -hwaccel_device to specify a device for VAAPI backend

2020-09-06 Thread Mark Thompson
On 03/09/2020 05:59, myp...@gmail.com wrote: On Thu, Sep 3, 2020 at 9:21 AM Xiang, Haihao wrote: On Wed, 2020-09-02 at 14:04 +, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Rogozhkin, Dmitry V Sent: Wednesday, September 2, 2020 3:54 PM To: ffmpeg-devel@ffmp

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/mips: Refine get_cabac_inline_mips.

2020-09-06 Thread Michael Niedermayer
On Sat, Sep 05, 2020 at 10:25:17AM +0800, Shiyou Yin wrote: > 1. Refined function get_cabac_inline_mips. > 2. Optimize function get_cabac_bypass and get_cabac_bypass_sign. > > Speed of decoding h264: 5.23x ==> 5.45x(tested on 3A4000). > --- > libavcodec/mips/cabac.h | 131 > +

Re: [FFmpeg-devel] [PATCH 8/8] avcodec/jpegls: Remove unused structure

2020-09-06 Thread Michael Niedermayer
On Sat, Sep 05, 2020 at 01:17:16AM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/jpegls.h | 4 > 1 file changed, 4 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Never trust a computer, one

[FFmpeg-devel] [PATCH] avformat/electronicarts: Check if there are any streams

2020-09-06 Thread Michael Niedermayer
Fixes: Assertion failure (invalid stream index) Fixes: 25120/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6565251898933248 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/electronicar

Re: [FFmpeg-devel] [PATCH] tiff: remove tiff type check for ICC profiles

2020-09-06 Thread Lynne
Sep 5, 2020, 20:23 by d...@lynne.ee: > Although the ICC specifications say to check for this, libtiff doesn't > and neither does any other TIFF implementation, and the TIFF specs > say that Photoshop has a different way to encapsulate ICC profiles, > and are asking for advice on how to deal with i

[FFmpeg-devel] [PATCH] avcodec/hlsenc: Fix playlist not getting flushed when using custom io

2020-09-06 Thread Steve Lam
--- libavformat/hlsenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index cb31d6aed7..fdfa907234 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -287,6 +287,7 @@ static int hlsenc_io_close(AVFormatContext *s, AVIOContext **pb, c

Re: [FFmpeg-devel] [PATCH] avformat/electronicarts: Check if there are any streams

2020-09-06 Thread James Almer
On 9/6/2020 7:57 PM, Michael Niedermayer wrote: > Fixes: Assertion failure (invalid stream index) > Fixes: > 25120/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6565251898933248 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Sig

[FFmpeg-devel] [PATCH 04/10] avformat/segment: Fix segfault when error happens and segment list is output

2020-09-06 Thread Andreas Rheinhardt
The segment muxer has an option to output a file containing a list of the segments written. The AVIOContext used for writing this file is opened via the main AVFormatContext's io_open callback; seg_free() meanwhile unconditionally closes this AVIOContext by calling ff_format_io_close() with the chi

[FFmpeg-devel] [PATCH 09/10] avformat/segment: Fix error messages

2020-09-06 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/segment.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index 0253b750b8..3dcbda6957 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -511,7 +511,7 @@ stati

[FFmpeg-devel] [PATCH 06/10] avformat/segment: Fix leak and invalid free of AVIOContext

2020-09-06 Thread Andreas Rheinhardt
seg_init() and seg_write_header() currently contain a few error paths in which an already opened AVIOContext for the child muxer leaks (namely if there are unrecognized options for the child muxer or if writing the header of the child muxer fails); the reason for this is that this AVIOContext is no

[FFmpeg-devel] [PATCH 08/10] avformat/segment: Remove redundant code for freeing in write_trailer

2020-09-06 Thread Andreas Rheinhardt
This code mostly duplicates code in the deinit function; the only exception is av_opt_free(): The options are freed generically lateron. Signed-off-by: Andreas Rheinhardt --- libavformat/segment.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/libavformat/

[FFmpeg-devel] [PATCH 10/10] avformat/segment: Avoid duplicating string when parsing frames list

2020-09-06 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- The first check in the loop could be removed btw; its only advantage is a better error message. libavformat/segment.c | 38 ++ 1 file changed, 14 insertions(+), 24 deletions(-) diff --git a/libavformat/segment.c b/libavfo

[FFmpeg-devel] [PATCH 05/10] avformat/segment: Fix leak of string on error

2020-09-06 Thread Andreas Rheinhardt
A string containing the segment's filename that the segment muxer allocates got only freed in its write_trailer function. This implies that it leaks if write_trailer is never called, e.g. if initializing the child muxer fails. This commit fixes this by freeing the string in the deinit function inst

[FFmpeg-devel] [PATCH 01/10] avformat/segment: Don't overwrite AVCodecParameters after init

2020-09-06 Thread Andreas Rheinhardt
The segment muxer copies the user-provided AVCodecParameters to the newly created child streams in its init function before initializing the child muxer; and since commit 8e6478b723affe4d44f94d34b98e0c47f6a0b411, it does this again before calling avformat_write_header() if that is called from seg_w

[FFmpeg-devel] [PATCH 03/10] avformat/segment: Fix segfault on allocation error, avoid allocation

2020-09-06 Thread Andreas Rheinhardt
If the user has set none of the options specifying the segments' durations, a default value of 2s is used by duplicating a "2" string and using av_parse_time() on it. Yet duplicating the string was unchecked and if the allocation failed, one would get a segfault in av_parse_time(). This commit sol

[FFmpeg-devel] [PATCH 02/10] avformat/segment: Fix leak of duration/framenumber lists upon error

2020-09-06 Thread Andreas Rheinhardt
The code to free them is not in the segment muxer's deinit function, but in its write_trailer function which means that these lists leak if write_trailer isn't called after their allocation. This happens e.g. if the given lists are invalid (e.g. consisting only of ',' (which delimit entries)), so t

[FFmpeg-devel] [PATCH 07/10] avformat/segment: Free SegmentListEntries in deinit, not write_trailer

2020-09-06 Thread Andreas Rheinhardt
This fixes leaks when the trailer is never written. Signed-off-by: Andreas Rheinhardt --- The allocation of the filename is btw currently unchecked. Actually, using a flexible array member for it would be advantageous (it could then be allocated and freed together with its SegmentListEntry). Flex

[FFmpeg-devel] [PATCH v6]libavfilter/asrc_fluidsynthmusic.c : generate algorithmic music

2020-09-06 Thread Ashutosh Pradhan
Generate algorithmic music using riffs, lindenmayer systems, cellular automaton and rhythm algorithms. Changelog |1 + configure |4 + doc/filters.texi | 146 libavfilter/Makefile |1 + libavfilte

[FFmpeg-devel] [PATCH] libwavpackenc: remove libwavpackenc wrapper

2020-09-06 Thread Lynne
The manual states "there is virtually no reason to use that encoder.". It supports less sample formats than the native encoder, is less efficient than the native encoder and is also slower and pretty much remains untested. libwavpack also isn't being fuzzed, which given that we plug the parameter