On Wed, 12 Aug 2020, Alexander Strasser wrote:
Hi all!
On 2020-08-12 14:53 +, Nicolas George wrote:
ffmpeg | branch: master | Nicolas George | Thu Jul 30
00:02:10 2020 +0200| [1201687da268c11459891a80ca1972aeaca8db88] | committer: Nicolas
George
lavf/url: rewrite ff_make_absolute_url
On Thu, 13 Aug 2020, Jan Ekström wrote:
While having the possibility of non-NOPTS values that can suddenly
jump in time due to adjustments to match PCR is not nice for DVB
subtitles, apparently the parser for this format bases its behavior on
whether the packets' timestamps are NOPTS or not.
Andreas Rheinhardt (12020-08-13):
> The channel layouts accepted by ff_merge_channel_layouts() are of two
> types: Ordinary channel layouts and generic channel layouts. These are
> layouts that match all layouts with a certain number of channels.
> Therefore parsing these channel layouts is not don
> On 12 Aug 2020, at 14:59, Tomas Härdin wrote:
>
> ons 2020-08-12 klockan 13:43 +0100 skrev Harry Mallon:
>> @@ -2492,6 +2504,18 @@ static int mxf_parse_structural_metadata(MXFContext
>> *mxf)
>> }
>> if (descriptor->aspect_ratio.num && descriptor->aspect_ratio.den)
>
make sense.
regards
Max
On Thu, Aug 13, 2020 at 4:15 AM Alex Pokotilo wrote:
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel
Here is an updated patch (now hopefully going with correct email headers).
From 5866d0dc5536a6ea3f6a899c3d09f19df083c16a Mon Sep 17 00:00:00 2001
From: Harry Mallon
Date: Wed, 12 Aug 2020 10:26:23 +0100
Subject: [PATCH v4] avformat/mxfdec: Read video range from PictureDescriptor
* Capture black
On Thu, Aug 13, 2020 at 10:34 AM Marton Balint wrote:
>
>
>
> On Thu, 13 Aug 2020, Jan Ekström wrote:
>
> > While having the possibility of non-NOPTS values that can suddenly
> > jump in time due to adjustments to match PCR is not nice for DVB
> > subtitles, apparently the parser for this format b
It will allow to refernce it as a whole without clunky macros.
Most of the changes have been automatically made with sed:
sed -i '
s/-> *in_formats/->incfg.formats/g;
s/-> *out_formats/->outcfg.formats/g;
s/-> *in_channel_layouts/->incfg.channel_layouts/g;
s/-> *out_channel_layouts/->outc
Signed-off-by: Nicolas George
---
libavfilter/formats.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/libavfilter/formats.c b/libavfilter/formats.c
index 32f41f2c13..8843200f47 100644
--- a/libavfilter/formats.c
+++ b/libavfilter/formats.c
@@ -549,15 +549,
Part of the code expect valid lists, in particular no duplicates.
These tests allow to catch bugs in filters (unlikely but possible)
and to give a clear message when the error comes from the user
((a)formats) or the application (buffersink).
Signed-off-by: Nicolas George
---
libavfilter/avfilter
Nicolas George:
> Andreas Rheinhardt (12020-08-13):
>> The channel layouts accepted by ff_merge_channel_layouts() are of two
>> types: Ordinary channel layouts and generic channel layouts. These are
>> layouts that match all layouts with a certain number of channels.
>> Therefore parsing these chan
Nicolas George:
> Part of the code expect valid lists, in particular no duplicates.
Which part of the code fails if there are duplicates?
ff_merge_channel_layouts() can be easily fixed by adding breaks to all
loops, so if it is only this, we could forgo checking as its cost is
quadratic in the num
Andreas Rheinhardt (12020-08-12):
> When one merges two AVFilterChannelLayouts structs, there is no need to
> allocate a new one. Instead one can reuse one of the two given ones.
> If one does this, one also doesn't need to update the references of the
> AVFilterChannelLayouts that is reused. There
Nicolas George:
> Andreas Rheinhardt (12020-08-12):
>> When one merges two AVFilterChannelLayouts structs, there is no need to
>> allocate a new one. Instead one can reuse one of the two given ones.
>> If one does this, one also doesn't need to update the references of the
>> AVFilterChannelLayouts
Andreas Rheinhardt (12020-08-13):
> Which part of the code fails if there are duplicates?
At least the merge loops. They can be protected, but the result is still
invalid and should be avoided, preferably with useful diagnostic.
> ff_merge_channel_layouts() can be easily fixed by adding breaks to
Andreas Rheinhardt (12020-08-13):
> No, I just swap the pointers, not the structures themselves. It just
> ensures a->refcount <= b->refcount in the following code. (The same
> swapping btw already happens at the beginning of the function.)
Oh, yes, my bad. I thought you wanted to reuse the format
Signed-off-by: Mingyu Yin
---
.../dnn/dnn_backend_native_layer_mathbinary.c | 17 +
.../dnn/dnn_backend_native_layer_mathbinary.h | 1 +
tests/dnn/dnn-layer-mathbinary-test.c | 5 +
tools/python/convert_from_tensorflow.py | 2 +-
tools/python/convert_h
Signed-off-by: Guo, Yejun
---
libavfilter/dnn/dnn_backend_openvino.c | 40 +-
1 file changed, 39 insertions(+), 1 deletion(-)
diff --git a/libavfilter/dnn/dnn_backend_openvino.c
b/libavfilter/dnn/dnn_backend_openvino.c
index d343bf2..030670b 100644
--- a/libavfil
Signed-off-by: Guo, Yejun
---
libavfilter/dnn/dnn_backend_tf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c
index 86da991..9099d2b 100644
--- a/libavfilter/dnn/dnn_backend_tf.c
+++ b/libavfilter/dnn/dnn_bac
tor 2020-08-13 klockan 11:04 +0100 skrev Harry Mallon:
> Here is an updated patch (now hopefully going with correct email headers).
It would be nice if in the future you either attach the patch or make
the entire email the patch itself. I've had to trim these first couple
of lines in each of the p
Commit a500b975 removed NULL input handling from this function,
moving the check higher up the call tree in one branch. However,
there is another call to set_string_video_rate() which may pass
NULL, and future users of the function may not be clear that
a NULL check is required. This patch restores
Hi Andreas,
You're right - apologies. So in fact there was an exchange of one kind of
undefined behaviour for another.
Thanks
Jack
On Thu, Aug 6, 2020 at 1:52 PM Andreas Rheinhardt <
andreas.rheinha...@gmail.com> wrote:
> Jack Haughton:
> > A NULL check in av_parse_video_rate() would certainly
Hi,
patch attached.
Please review and/or benchmark, especially .asm file.
0001-avcodec-cfhd-add-x86-SIMD.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscr
Signed-off-by: Harry Mallon
---
libavcodec/dpx.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c
index b1833ed9ef..694deb27c5 100644
--- a/libavcodec/dpx.c
+++ b/libavcodec/dpx.c
@@ -216,10 +216,22 @@ static int decode_frame(A
Nicolas George:
> Andreas Rheinhardt (12020-08-08):
>> I was thinking about this part of the MERGE_FORMATS macro:
>>
>> for (i = 0; i < a->nb; i++)
>> for (j = 0; j < b->nb; j++)
>> if (a->fmts[i] == b->fmts[j]) {
>> if(k >= FFMIN(a->nb, b->nb
On 8/13/2020 3:51 AM, Xu Guangxin wrote:
> Hi James,
> thanks for your feedback, please help review it again.
>
> Changelist for v3:
> use av_fifo_* instead of homebrewed fifo operations
> obu_probe(), add padding obu to alllow list
> read_header(), use "const AVRational* framerate" instead
On Thu, 13 Aug 2020, James Almer wrote:
On 8/13/2020 3:51 AM, Xu Guangxin wrote:
+
+ret = obu_prefetch(s, header, MAX_OBU_HEADER_SIZE);
+if (!ret)
+return AVERROR(EOF);
We use AVERROR_EOF rather than AVERROR(EOF) (Afair, it was done because
EOF is not portable, but don't quo
Fixes: Assertion failure
Fixes:
24612/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6600899842277376.fuzz
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavformat/siff.c | 2 ++
1 file changed,
On Thu, 13 Aug 2020, Tomas Härdin wrote:
tor 2020-08-13 klockan 11:04 +0100 skrev Harry Mallon:
Here is an updated patch (now hopefully going with correct email headers).
It would be nice if in the future you either attach the patch or make
the entire email the patch itself. I've had to tri
On Wed, Aug 12, 2020 at 08:58:30PM +0200, Alexander Strasser wrote:
> On 2020-08-09 14:56 +0200, Michael Niedermayer wrote:
> > On Sun, Aug 09, 2020 at 02:24:34PM +0200, Alexander Strasser wrote:
> > >
> > >
> > > Am 9. August 2020 12:56:53 MESZ schrieb Michael Niedermayer
> > > :
> > > >On Fri, A
Hi. Replying to a very old patch already applied.
lance.lmw...@gmail.com (12019-09-14):
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> tests/fate/filter-video.mak | 4
> tests/ref/fate/filter-minterpolate-down | 6 ++
> tests/ref/fate/filter-minterpolate-up |
Andreas Rheinhardt (12020-08-13):
> Sure about that? The filter-framerate-up test fails (the output pixel
> format is now YUV9 instead of I420) when I switch a and b in
> MERGE_FORMATS if b->nb < a->nb. What you said seems to only apply to
> sample rates, not format negotiations.
Well, there is on
Fixed an Use-of-uninitialized-value
---
libavformat/mpeg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c
index 265b2bd1ad..15a768e6e8 100644
--- a/libavformat/mpeg.c
+++ b/libavformat/mpeg.c
@@ -146,7 +146,7 @@ static int mpegps_read_he
We only make one PPS, so the tile structure necessarily fixed.
---
libavcodec/vaapi_encode_h265.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c
index d2bcb8d3db..dbd8c77f6d 100644
--- a/libavcodec/vaapi_encode_h265.c
+++ b/libav
While libavcodec doesn't care about these constraints, the HM reference
decoder does enforce them and other decoders may run into problems.
---
libavcodec/vaapi_encode_h265.c | 35 +-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/libavcodec/vaapi_enc
This precalculates all of the information we will need to define slice
and tile positions at init time rather than rebuilding some of it with
every slice. The control of tiles is generalised to match slices, so that
arbitrary tile and slice layouts are possible within the constraint that
slices ca
A few popular sites have started generating MP4 files which have a
sidx plus an mfra. The sidx accounts for all size except the mfra,
so the old code did not mark the fragment index as complete.
Instead we can just check if there's an mfra and if its size makes
up the difference we can mark the in
In listener mode the first fd is not closed when libsrt_close() is called
because it is overwritten by the new accept fd.
Added the listen_fd to the context to properly close it when libsrt_close() is
called.
Fixes trac ticket #8372
Signed-off-by: Nicolas Sugino
---
libavformat/libsrt.c | 10 +
In listener mode the first fd is not closed when libsrt_close() is called
because it is overwritten by the new accept fd.
Added the listen_fd to the context to properly close it when libsrt_close() is
called.
Fixes trac ticket #8372
Signed-off-by: Nicolas Sugino
---
libavformat/libsrt.c | 10 +
El jue., 13 ago. 2020 a las 3:56, Marton Balint () escribió:
>
>
>
> On Thu, 13 Aug 2020, Nicolas Sugino wrote:
>
> > In listener mode the first fd is not closed when libsrt_close() is called
> > because it is overwritten by the new accept fd.
> > Added the listen_fd to the context to properly clo
Printing venc params in ffprobe makes it easier for program to parse the data
via
ffprobe json output
---
fftools/ffprobe.c | 33 +
1 file changed, 33 insertions(+)
diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index 5515e1b31b..b20bddc897 100644
--- a/fftool
---
libavcodec/vp9.c | 102 ++
libavcodec/vp9block.c | 2 +
libavcodec/vp9dec.h | 3 ++
3 files changed, 107 insertions(+)
diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c
index fd0bab14a2..5289fb3099 100644
--- a/libavcodec/vp9.c
+++ b/libavcode
> -Original Message-
> From: ffmpeg-devel On Behalf Of Guo,
> Yejun
> Sent: 2020年8月13日 22:47
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH 1/2] dnn: fix build issue for tensorflow
> backend
>
> Signed-off-by: Guo, Yejun
> ---
> libavfilter/dnn/dnn_backend_tf.c | 2 +-
In listener mode the first fd is not closed when libsrt_close() is called
because it is overwritten by the new accept fd.
Added the listen_fd to the context to properly close it when libsrt_close() is
called.
Fixes trac ticket #8372
Signed-off-by: Nicolas Sugino
---
libavformat/libsrt.c | 12 +
From: Limin Wang
Reported-by: Nicolas George
Signed-off-by: Limin Wang
---
tests/fate/filter-video.mak | 4 ++--
tests/ref/fate/filter-minterpolate-up | 16
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/tests/fate/filter-video.mak b/tests/fate/fil
On Thu, Aug 13, 2020 at 10:55:07PM +0200, Nicolas George wrote:
> Hi. Replying to a very old patch already applied.
>
> lance.lmw...@gmail.com (12019-09-14):
> > From: Limin Wang
> >
> > Signed-off-by: Limin Wang
> > ---
> > tests/fate/filter-video.mak | 4
> > tests/ref/fate
Signed-off-by: Guo, Yejun
---
libavfilter/dnn/dnn_backend_openvino.c | 37 +-
1 file changed, 36 insertions(+), 1 deletion(-)
diff --git a/libavfilter/dnn/dnn_backend_openvino.c
b/libavfilter/dnn/dnn_backend_openvino.c
index d343bf2..478e151 100644
--- a/libavfil
> Should be good with those trivial changes, so i can implement them and push if
> you don't want to send another revision.
>
Great! thanks for you kindly help on this and previous review.
Really appreciate it.
> -Original Message-
> From: ffmpeg-devel On Behalf Of James
> Almer
> Sent: F
Hi Martin,
Thanks for your detailed explaining.
It's a good education to me.
thanks
> -Original Message-
> From: ffmpeg-devel On Behalf Of Martin
> Storsjö
> Sent: Friday, August 14, 2020 3:25 AM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH v3
On 8/13/2020 11:45 PM, Xu, Guangxin wrote:
>> Should be good with those trivial changes, so i can implement them and push
>> if
>> you don't want to send another revision.
>>
> Great! thanks for you kindly help on this and previous review.
> Really appreciate it.
Applied those changes, added miss
On Sat, 08. Aug 09:55, Andriy Gelman wrote:
> On Wed, 05. Aug 14:37, Moritz Barsnick wrote:
> > On Mon, Jul 20, 2020 at 09:18:55 +0200, Alexander Strasser wrote:
> > > On 2020-07-19 19:47 -0400, Andriy Gelman wrote:
> > > > > > This check seems dead code. Looking at xcb sources, cursor is just
> >
v3 changelist: add missed tests/ref/fate/av1-low-overhead-demux
---
tests/fate/demux.mak | 3 +++
tests/ref/fate/av1-low-overhead-demux | 16
2 files changed, 19 insertions(+)
create mode 100644 tests/ref/fate/av1-low-overhead-demux
diff --git a/tests/fate/dem
Will apply.
On 10-08-2020 10:14 pm, gautamr...@gmail.com wrote:
From: Gautam Ramakrishnan
This patch updates the documentation by adding all options
for JPEG2000 encoder.
---
doc/encoders.texi | 36 +++-
1 file changed, 35 insertions(+), 1 deletion(-)
diff -
53 matches
Mail list logo
