[FFmpeg-devel] [PATCH v2 1/6] avformat/argo_asf: check sample count in demuxer

2020-08-04 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c index 3339425244..9de64dfab4 100644 --- a/libavformat/argo_asf.c +++ b/libavformat/argo_asf.c @@ -27,6 +27,7 @@ #d

[FFmpeg-devel] [PATCH v2 0/6] add adpcm_argo encoder and argo_asf muxer

2020-08-04 Thread Zane van Iperen
v2: [1] * enforce the samples-per-block value in the demuxer * remove unnecessary initialisers * add missing return when stream isn't seekable * change a sequence of avio_wl8()s to an avio_write() * add write_packet() and check packet sizes * use AVStream::nb_frames instead of calculating the value

[FFmpeg-devel] [PATCH v2 2/6] avcodec/adpcm_argo: add ff_adpcm_argo_expand_nibble() and cleanup parameters

2020-08-04 Thread Zane van Iperen
Replaces adpcm_argo_expand_nibble(). Preparation for the encoder. Signed-off-by: Zane van Iperen --- libavcodec/adpcm.c | 10 +- libavcodec/adpcm.h | 2 ++ 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index b77f4b8ef6..1366932352

[FFmpeg-devel] [PATCH v2 3/6] avcodec: add adpcm_argo encoder

2020-08-04 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi | 2 +- libavcodec/Makefile| 1 + libavcodec/adpcmenc.c | 86 +- libavcodec/allcodecs.c | 1 + libavcodec/utils.c | 1 + libavcodec/version.h | 2 +- 7

[FFmpeg-devel] [PATCH v2 4/6] avformat: add argo_asf muxer

2020-08-04 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/argo_asf.c | 124 ++- libavformat/version.h| 2 +- 5 files changed, 127 insertions(+), 2 deletions(-) d

[FFmpeg-devel] [PATCH v2 6/6] fate: cosmetics

2020-08-04 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- tests/fate/acodec.mak | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/fate/acodec.mak b/tests/fate/acodec.mak index 96ab0e587e..3e2a18435f 100644 --- a/tests/fate/acodec.mak +++ b/tests/fate/acodec.mak @@ -44,15 +44,15

[FFmpeg-devel] [PATCH v2 5/6] fate: add adpcm_argo test

2020-08-04 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- tests/fate/acodec.mak | 2 ++ tests/ref/acodec/adpcm-argo | 4 2 files changed, 6 insertions(+) create mode 100644 tests/ref/acodec/adpcm-argo diff --git a/tests/fate/acodec.mak b/tests/fate/acodec.mak index 197b6ed7c0..96ab0e587e 100644 --- a/tests

Re: [FFmpeg-devel] AVWriter again (was: v2 1/2] avformat/url: check double dot is not to parent directory)

2020-08-04 Thread Nicolas George
Zhao Zhili (12020-07-31): > So we can get a writer with AVIO context as backend, with custom stream > filters. > It do sound interesting, as long as it doesn't go too far like io in Java and > C++. The maze of twisty little APIs all alike is one of the reasons I try to minimize my interactions w

Re: [FFmpeg-devel] [PATCH 1/2] lavf/url: add ff_url_decompose().

2020-08-04 Thread Nicolas George
Marton Balint (12020-08-04): > So you are returning NULL pointers here and success at the same time. This > does not look like a good idea, e.g. checking fields later on involves > arithmetic on NULL pointers, no? I don't really see it useful that we handle > NULL url here, we are better off with a

Re: [FFmpeg-devel] [PATCH v2 4/6] avformat: add argo_asf muxer

2020-08-04 Thread Zane van Iperen
On Tue, 04 Aug 2020 08:46:41 + "Zane van Iperen" wrote: Disregard, this breaks FATE. Will post a follow-up later. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link ab

Re: [FFmpeg-devel] [PATCH v2 4/6] avformat: add argo_asf muxer

2020-08-04 Thread Zane van Iperen
On Tue, 04 Aug 2020 09:27:35 + "Zane van Iperen" wrote: > > On Tue, 04 Aug 2020 08:46:41 + > "Zane van Iperen" wrote: > > Disregard, this breaks FATE. Will post a follow-up later. > Right, so there's two ways I can fix this, which would be the preferred option? 1. Explicitly tell FAT

Re: [FFmpeg-devel] [PATCH v2 4/4] lavc, doc: add libuavs3d video decoder wrapper

2020-08-04 Thread myp...@gmail.com
? On Mon, Jun 22, 2020 at 9:59 PM wrote: > > From: hwren > > Signed-off-by: hbj > Signed-off-by: hwren > --- > Changelog | 1 + > configure | 4 + > doc/decoders.texi | 21 +++ > doc/general.texi | 8 ++ > libavcodec/Makefile| 1 + > libavcod

[FFmpeg-devel] [PATCH] avcodec: deprecate thread_safe_callbacks

2020-08-04 Thread Anton Khirnov
They add considerable complexity to frame-threading implementation, which includes an unavoidably leaking error path, while the advantages of this option to the users are highly dubious. It should be always possible and desirable for the callers to make their get_buffer2() implementation thread-sa

Re: [FFmpeg-devel] [v5] dnn_backend_native_layer_mathunary: add ceil support

2020-08-04 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Mingyu > Yin > Sent: 2020年8月3日 19:17 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [v5] dnn_backend_native_layer_mathunary: add ceil > support > > It can be tested with the model generated with below python script: > > im

Re: [FFmpeg-devel] [PATCH] avutil/opt: Restore NULL input handling to set_string_video_rate()

2020-08-04 Thread Jack Haughton
I think we're talking past each other. You're asking me to demonstrate a current way in which NULL might be passed to this function. I don't think it's necessary to do that in order for this patch to be a good idea. > Is this about something iam missing or a lib user passing invalidly > setup AVOp

Re: [FFmpeg-devel] [PATCH] avutil/opt: Restore NULL input handling to set_string_video_rate()

2020-08-04 Thread Nicolas George
Jack Haughton (12020-08-04): > Absolutely, he should fix his code. But let's say some code gets by code > review that has a corner case whereby NULL can be passed. Isn't it better > for that condition to be handled cleanly (as it was before a500b975) rather > than causing undefined behaviour? Then

Re: [FFmpeg-devel] [PATCH] swscale: do not drop half of bits from 16bit bayer formats

2020-08-04 Thread Michael Niedermayer
On Sun, Aug 02, 2020 at 03:58:10PM +0200, Paul B Mahol wrote: > Hi, > > patch attached. > bayer_template.c | 102 > + > swscale_internal.h |7 +++ > swscale_unscaled.c | 51 ++ > utils.c|5 +- >

Re: [FFmpeg-devel] [PATCH] avcodec/mpegaudiodec_template: Check CRCs for layer1 and layer2

2020-08-04 Thread Michael Niedermayer
On Mon, Aug 03, 2020 at 08:53:41PM +0200, Lynne wrote: > Aug 3, 2020, 18:31 by mich...@niedermayer.cc: > > > This differs from the MPEG specification as the actual real world > > files do compute their CRC over variable areas and not the fixed > > ones listed in the specification. This is also the

[FFmpeg-devel] [PATCH] libavcodec/j2kenc: Allow Encoder to use SOP and EPH markers

2020-08-04 Thread gautamramk
From: Gautam Ramakrishnan This patch allows the encoder to use SOP and EPH markers. This would be useful as these markers provide better error detection mechanisms. --- libavcodec/j2kenc.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/libavcode

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Check comp_brand_size

2020-08-04 Thread Michael Niedermayer
On Sun, Aug 02, 2020 at 01:23:22AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type > 'int' > Fixes: > 24457/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5760093644390400 > > Found-by: continuous fuzzing process > https://g

Re: [FFmpeg-devel] [PATCH] avcodec: deprecate thread_safe_callbacks

2020-08-04 Thread James Almer
On 8/4/2020 8:59 AM, Anton Khirnov wrote: > They add considerable complexity to frame-threading implementation, > which includes an unavoidably leaking error path, while the advantages > of this option to the users are highly dubious. > > It should be always possible and desirable for the callers

Re: [FFmpeg-devel] [PATCH] libavcodec/libx264.c: Fix chromaoffset of libx264 doesn't work

2020-08-04 Thread Jan Ekström
On Tue, Jul 28, 2020 at 3:30 PM Takio Yamaoka wrote: > > An initial value of `AVCodecContext::chromaoffset` is zero, > then it causes to block `-chromaoffset` setting as result. > In addition, even though a negative number of `chromaoffset` > is meaningful, `X264Context::chroma_offset` is initiali

[FFmpeg-devel] [PATCH v3 0/6] add adpcm_argo encoder and argo_asf muxer

2020-08-04 Thread Zane van Iperen
v3: * fix FATE failure (lavf-asf) caused by "asf" extension conflict v2: [1] * enforce the samples-per-block value in the demuxer * remove unnecessary initialisers * add missing return when stream isn't seekable * change a sequence of avio_wl8()s to an avio_write() * add write_packet() and check p

[FFmpeg-devel] [PATCH v3 5/6] fate: add adpcm_argo test

2020-08-04 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- tests/fate/acodec.mak | 2 ++ tests/ref/acodec/adpcm-argo | 4 2 files changed, 6 insertions(+) create mode 100644 tests/ref/acodec/adpcm-argo diff --git a/tests/fate/acodec.mak b/tests/fate/acodec.mak index 197b6ed7c0..96ab0e587e 100644 --- a/tests

[FFmpeg-devel] [PATCH v3 4/6] avformat: add argo_asf muxer

2020-08-04 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/argo_asf.c | 127 ++- libavformat/version.h| 2 +- 5 files changed, 130 insertions(+), 2 deletions(-) d

[FFmpeg-devel] [PATCH v3 1/6] avformat/argo_asf: check sample count in demuxer

2020-08-04 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c index 3339425244..9de64dfab4 100644 --- a/libavformat/argo_asf.c +++ b/libavformat/argo_asf.c @@ -27,6 +27,7 @@ #d

[FFmpeg-devel] [PATCH v3 2/6] avcodec/adpcm_argo: add ff_adpcm_argo_expand_nibble() and cleanup parameters

2020-08-04 Thread Zane van Iperen
Replaces adpcm_argo_expand_nibble(). Preparation for the encoder. Signed-off-by: Zane van Iperen --- libavcodec/adpcm.c | 10 +- libavcodec/adpcm.h | 2 ++ 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index b77f4b8ef6..1366932352

[FFmpeg-devel] [PATCH v3 3/6] avcodec: add adpcm_argo encoder

2020-08-04 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi | 2 +- libavcodec/Makefile| 1 + libavcodec/adpcmenc.c | 86 +- libavcodec/allcodecs.c | 1 + libavcodec/utils.c | 1 + libavcodec/version.h | 2 +- 7

[FFmpeg-devel] [PATCH v3 6/6] fate: cosmetics

2020-08-04 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- tests/fate/acodec.mak | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/fate/acodec.mak b/tests/fate/acodec.mak index 96ab0e587e..3e2a18435f 100644 --- a/tests/fate/acodec.mak +++ b/tests/fate/acodec.mak @@ -44,15 +44,15

Re: [FFmpeg-devel] [PATCH] libavcodec/libx264.c: Fix chromaoffset of libx264 doesn't work

2020-08-04 Thread Takio Yamaoka
Thank you for the review! It is my first time to send a patch. So I was relieved to hear that. Is it OK to wait to merge? Best Regards, Takio 2020年8月5日(水) 6:00 Jan Ekström : > > On Tue, Jul 28, 2020 at 3:30 PM Takio Yamaoka wrote: > > > > An initial value of `AVCodecContext::chromaoffset` is ze

[FFmpeg-devel] [PATCH V4 1/2] dnn/native: add native support for avg_pool

2020-08-04 Thread Ting Fu
Not support pooling strides in channel dimension now. It can be tested with the model generated with below python script: import tensorflow as tf import numpy as np import imageio in_img = imageio.imread('input_odd.jpg') in_img = in_img.astype(np.float32)/255.0 in_data = in_img[np.newaxis, :] x

[FFmpeg-devel] [PATCH V4 2/2] FATE/dnn: add unit test for dnn avgpool layer

2020-08-04 Thread Ting Fu
'make fate-dnn-layer-avgpool' to run the test Signed-off-by: Ting Fu --- tests/dnn/.gitignore | 1 + tests/dnn/Makefile | 1 + tests/dnn/dnn-layer-avgpool-test.c | 202 + tests/fate/dnn.mak | 5 + 4 files changed, 20

[FFmpeg-devel] [PATCH V5 1/2] dnn/native: add native support for avg_pool

2020-08-04 Thread Ting Fu
Not support pooling strides in channel dimension now. It can be tested with the model generated with below python script: import tensorflow as tf import numpy as np import imageio in_img = imageio.imread('input_odd.jpg') in_img = in_img.astype(np.float32)/255.0 in_data = in_img[np.newaxis, :] x

[FFmpeg-devel] [PATCH V5 2/2] FATE/dnn: add unit test for dnn avgpool layer

2020-08-04 Thread Ting Fu
'make fate-dnn-layer-avgpool' to run the test Signed-off-by: Ting Fu --- V5: Fix the issue V4 make fate failed. tests/dnn/.gitignore | 1 + tests/dnn/Makefile | 1 + tests/dnn/dnn-layer-avgpool-test.c | 202 + tests/fate/dnn.mak

[FFmpeg-devel] [PATCH V6 1/2] dnn/native: add native support for avg_pool

2020-08-04 Thread Ting Fu
Not support pooling strides in channel dimension now. It can be tested with the model generated with below python script: import tensorflow as tf import numpy as np import imageio in_img = imageio.imread('input_odd.jpg') in_img = in_img.astype(np.float32)/255.0 in_data = in_img[np.newaxis, :] x

[FFmpeg-devel] [PATCH V6 2/2] FATE/dnn: add unit test for dnn avgpool layer

2020-08-04 Thread Ting Fu
'make fate-dnn-layer-avgpool' to run the test Signed-off-by: Ting Fu --- V6: Fix the issue of make fate failed in V4&V5 tests/dnn/.gitignore | 1 + tests/dnn/Makefile | 1 + tests/dnn/dnn-layer-avgpool-test.c | 198 + tests/fate/dn