Re: [FFmpeg-devel] [PATCH 1/2] libsvt-av1: Consistently use - rather than _

Mark Thompson (12020-07-29): > Matching libaom-av1. As for options, most of FFmpeg uses underscores. It would be better to use them too here. Also, you cannot rename options, you have to create aliases and deprecate the original. Otherwise you break user cases. Regards, -- Nicolas George s

[FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter

From: Yinhang Liu xcam filter is a wrapper of libxcam project which supports 360 video stitching, automotive surround view stitching, digital video stabilization (DVS), Wide dynamic range (WDR), wavelet noise reduction, 3D noise reduction, etc. libxcam library optimized algorithms by AVX, GLES a

Re: [FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter

zongwave (12020-07-31): > From: Yinhang Liu > > xcam filter is a wrapper of libxcam project which supports 360 video > stitching, > automotive surround view stitching, digital video stabilization (DVS), > Wide dynamic range (WDR), wavelet noise reduction, 3D noise reduction, etc. Hi. Thanks for

Re: [FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter

Yes, I made the patch with git command "format-patch", there's some redundant message, so I modified the patch file a little bit manually. Then I use git "send-email" to send the patch. -Original Message- From: ffmpeg-devel On Behalf Of Nicolas George Sent: Thursday, July 30, 2020 5:12

Re: [FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter

On Thu, Jul 30, 2020 at 5:12 PM Nicolas George wrote: > > zongwave (12020-07-31): > > From: Yinhang Liu > > > > xcam filter is a wrapper of libxcam project which supports 360 video > > stitching, > > automotive surround view stitching, digital video stabilization (DVS), > > Wide dynamic range (W

Re: [FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter

zongwave 于2020年7月30日周四 下午5:06写道： > > From: Yinhang Liu > > xcam filter is a wrapper of libxcam project which supports 360 video > stitching, > automotive surround view stitching, digital video stabilization (DVS), > Wide dynamic range (WDR), wavelet noise reduction, 3D noise reduction, etc. > >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter

On Thu, Jul 30, 2020 at 5:15 PM myp...@gmail.com wrote: > > On Thu, Jul 30, 2020 at 5:12 PM Nicolas George wrote: > > > > zongwave (12020-07-31): > > > From: Yinhang Liu > > > > > > xcam filter is a wrapper of libxcam project which supports 360 video > > > stitching, > > > automotive surround v

Re: [FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter

Steven Liu (12020-07-30): > What's happened? ctrl+c + ctrl+v, and forgot remove the first column? If you have a first column to remove, then you are doing something wrong. Could we see the output of git format-patch exactly as is, as an attached file, please? Regards, -- Nicolas George sig

Re: [FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter

This file is the original git format-patch. It has double commit messages, I removed the old one manually. -Original Message- From: ffmpeg-devel On Behalf Of Nicolas George Sent: Thursday, July 30, 2020 5:34 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [

Re: [FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter

Someone opened an issue https://github.com/intel/libxcam/issues/729 they want to use a FFmpeg video filter pipeline to do multiple decoder, stitching and encoder. Those 3rd party libs are not necessary for stitching and most image processing functions. By default these 3rd libs are disabled.

Re: [FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter

Zong, Wei (12020-07-30): > This file is the original git format-patch. It has double commit > messages, I removed the old one manually. Thanks. Please remember not to top-post on this mailing-list (if you do not know what it means, look it up). You were indeed doing something wrong, and making yo

[FFmpeg-devel] [PATCH V3 1/2] dnn/native: add native support for avg_pool

Not support pooling strides in channel dimension now. It can be tested with the model generated with below python script: import tensorflow as tf import numpy as np import imageio in_img = imageio.imread('input_odd.jpg') in_img = in_img.astype(np.float32)/255.0 in_data = in_img[np.newaxis, :] x

[FFmpeg-devel] [PATCH V3 2/2] FATE/dnn: add unit test for dnn avgpool layer

'make fate-dnn-layer-avgpool' to run the test Signed-off-by: Ting Fu --- tests/dnn/.gitignore | 1 + tests/dnn/Makefile | 1 + tests/dnn/dnn-layer-avgpool-test.c | 202 + tests/fate/dnn.mak | 5 + 4 files changed, 20

Re: [FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter

Zong, Wei 于2020年7月30日周四 下午6:00写道： > > Someone opened an issue https://github.com/intel/libxcam/issues/729 they > want to use a FFmpeg video filter pipeline to do multiple decoder, stitching > and encoder. > > Those 3rd party libs are not necessary for stitching and most image > processing func

Re: [FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter

On Thu, 30 Jul 2020 09:23:12 + "Zong, Wei" wrote: > Yes, I made the patch with git command "format-patch", there's some > redundant message, so I modified the patch file a little bit > manually. Then I use git "send-email" to send the patch. I'm pretty sure modifying the .patch manually inva

Re: [FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter

On Fri, 31 Jul 2020 00:55:56 +0800 "zongwave" wrote: > ++static int xcam_query_formats(AVFilterContext *ctx) > ++{ > ++XCAMContext *s = ctx->priv; > ++AVFilterFormats *formats = NULL; > ++ > ++static const enum AVPixelFormat nv12_fmts[] = {AV_PIX_FMT_NV12, > AV_PIX_FMT_NONE}; > ++

[FFmpeg-devel] Backporting Policy

Hi all, What's the policy for backporting patches? Is it just run-FATE-then-push, or is there some extra review required? Zane ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit

[FFmpeg-devel] [PATCH] lavc/ratecontrol: Fix error logging for parsing and evaluation of rc_eq

Don't pass a potential NULL pointer to av_log, instead use a default in the rc_eq AVOption definitions. Now the context variable always holds a string; even if it's the default expression. Note this also fixes the evaluation error path, where a similar av_log references the rc_eq string from the c

Re: [FFmpeg-devel] [PATCH 1/2] libsvt-av1: Consistently use - rather than _

On 7/30/2020 5:05 AM, Nicolas George wrote: > Mark Thompson (12020-07-29): >> Matching libaom-av1. > > As for options, most of FFmpeg uses underscores. It would be better to > use them too here. > > Also, you cannot rename options, you have to create aliases and > deprecate the original. Otherwis

Re: [FFmpeg-devel] [PATCH 1/2] lavc/aac_ac3_parser: fix the potential overflow

On Sat, Jul 25, 2020 at 3:21 AM Alexander Strasser wrote: > > On 2020-07-24 19:56 +0800, zhilizhao wrote: > > > > > > > On Jul 24, 2020, at 9:40 AM, myp...@gmail.com wrote: > > > > > > On Fri, Jul 24, 2020 at 4:43 AM Alexander Strasser > > > wrote: > > >> > > >> On 2020-0

Re: [FFmpeg-devel] [PATCH 1/2] libsvt-av1: Consistently use - rather than _

James Almer (12020-07-30): > This encoder was pushed yesterday night, which is why this change is > being suggested. It's not going to break anyone's use cases. Yes, I realized that afterwards and forgot to amend. But options with underscores are still the preferred form in the project. Regards,

Re: [FFmpeg-devel] [PATCH] [RFC] lavc, lavfmt: add FLIF decoding support

July 30, 2020 1:08 AM, "Andreas Rheinhardt" wrote: > Anamitra Ghorui: > >> This patch implements non interlaced decoding of FLIF16 images with all >> transforms except for one, FrameLookback which is being tested. >> >> Several test files have been attached. The above mentioned transform >> an

[FFmpeg-devel] avformat/mxfdec: Read color metadata from MXF

Hello, Sorry I wasn't able to send this with git-send-email. The following patch adds reading colour metadata (transfer, primaries and colour space) from standard MXF files. I wrote it without seeing the other patch but it turned out very similar to this one that was never merged https://patchwork

[FFmpeg-devel] [PATCH v2 4/5] avformat/mpegts: parse and export descriptor 6a side data

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/mpegts.c| 57 + tests/ref/fate/ts-demux | 2 +- 2 files changed, 54 insertions(+), 5 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index c6fd3e1..720ed34 1006

[FFmpeg-devel] avformat/mxfdec: Read color metadata from MXF

Hello, Sorry I wasn't able to send this with git-send-email, I'm trying again with patch inline. The following patch adds reading colour metadata (transfer, primaries and colour space) from standard MXF files. I wrote it without seeing the other patch but it turned out very similar to this one

[FFmpeg-devel] [PATCH v2 2/5] API: add AV_PKT_DATA_MPEGTS_DESC_6A to AVPacketSideDataType

From: Limin Wang Signed-off-by: Limin Wang --- doc/APIchanges| 3 +++ libavcodec/avpacket.c | 1 + libavcodec/packet.h | 7 +++ libavcodec/version.h | 2 +- 4 files changed, 12 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 72a4833..12e65a2 10064

[FFmpeg-devel] [PATCH v2 5/5] avformat/mpegtsenc: support 0x6a descriptor for AC-3 by side data if have

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/mpegtsenc.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 718ddab..f4f4e3d 100644 --- a/libavformat/mpegtsenc.c +++ b/libavforma

[FFmpeg-devel] [PATCH 1/2] lavf/url: add ff_url_decompose().

Signed-off-by: Nicolas George --- libavformat/tests/url.c | 34 +++ libavformat/url.c | 74 + libavformat/url.h | 41 +++ tests/ref/fate/url | 45 + 4 files changed, 194 insertions

[FFmpeg-devel] [PATCH 2/2] lavf/url: rewrite ff_make_absolute_url() using ff_url_decompose().

Also add and update some tests. Change the semantic a little, because for filesytem paths symlinks complicate things. See the comments in the code for detail. Signed-off-by: Nicolas George --- libavformat/tests/url.c | 17 ++- libavformat/url.c | 246 +++--

[FFmpeg-devel] [PATCH v2 1/5] avutil/mpegts_audio_desc_metadata: add helper function for AC3 descriptor 0x6a

From: Limin Wang Signed-off-by: Limin Wang --- libavutil/Makefile | 2 ++ libavutil/mpegts_audio_desc_metadata.c | 33 libavutil/mpegts_audio_desc_metadata.h | 57 ++ 3 files changed, 92 insertions(+) create mode 100644

[FFmpeg-devel] [PATCH v2 3/5] avformat/dump: dump AV_PKT_DATA_MPEGTS_6A_DESC side data

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/dump.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavformat/dump.c b/libavformat/dump.c index 6d29d85..249789a 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -28,6 +28,7 @@ #include "libavuti

Re: [FFmpeg-devel] [PATCH 0/5 v2] 22.2 channel layout support for AAC decoding

On Wed, Jul 29, 2020 at 2:51 PM Lynne wrote: > > Jul 29, 2020, 13:39 by jee...@gmail.com: > > > Now that we actually have sample(s) for channel_config 13, it was possible > > to see at which various points the AAC decoder fails attempting to parse > > the bit stream. > > > > As the feature `-reque

Re: [FFmpeg-devel] AVWriter again (was: v2 1/2] avformat/url: check double dot is not to parent directory)

zhilizhao (12020-07-28): > fmemopen() can work with memory on stack or on heap, although it doesn’t > support switch between the two dynamically. It’s a good to have feature like > the small string optimization in std::string, but i’m not too keen on it. I think it is an important optimization. Th

Re: [FFmpeg-devel] Create and populate AVStream side data packet with contents of ISOBMFF edit list entries

On Wed, Jul 29, 2020 at 4:17 PM Thierry Foucu wrote: > > On Wed, Jul 29, 2020 at 4:02 PM Matthew Szatmary wrote: > > > Create and populate AVStream side data packet with contents of ISOBMFF > > edit list entries > > > > Signed-off-by: Matthew Szatmary > > --- > > Changelog | 1 + > >

Re: [FFmpeg-devel] Create and populate AVStream side data packet with contents of ISOBMFF edit list entries

From 91ae719dd69cba5153e4ce1aad2eb3ce819668b1 Mon Sep 17 00:00:00 2001 From: Matthew Szatmary Date: Thu, 23 Jul 2020 16:36:49 -0700 Subject: [PATCH] Create and populate AVStream side data packet with contents of ISOBMFF edit list entries Signed-off-by: Matthew Szatmary --- Changelog

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

On Mon, Jul 27, 2020 at 11:44 PM Mohammad Izadi < izadi-at-google@ffmpeg.org> wrote: > It seems FATE is for the regression test. Here is a sample that you can use > and check: > > https://www.dropbox.com/s/3ewr2t2lvv2cy8d/20200727_143643.mp4?dl=0 > > Thanks I will check it out. Fate is indeed

Re: [FFmpeg-devel] AVWriter again (was: v2 1/2] avformat/url: check double dot is not to parent directory)

> On Jul 30, 2020, at 11:42 PM, Nicolas George wrote: > > zhilizhao (12020-07-28): >> fmemopen() can work with memory on stack or on heap, although it doesn’t >> support switch between the two dynamically. It’s a good to have feature like >> the small string optimization in std::string, but i’m

Re: [FFmpeg-devel] Backporting Policy

> Am 30.07.2020 um 14:33 schrieb Zane van Iperen : > > > What's the policy for backporting patches? Please only backport security-related fixes and regression fixes. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.or

[FFmpeg-devel] [RFC] cineform CFHD encoder, and decoder speedup

Hi, patches attached. Decoder speedup is approx %20 overall. 0001-avcodec-add-CFHD-encoder.patch Description: Binary data 0002-avcodec-cfhd-move-if-else-out-of-loop-in-inverse-tra.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-d

Re: [FFmpeg-devel] [RFC] cineform CFHD encoder, and decoder speedup

On 7/30/2020 1:32 PM, Paul B Mahol wrote: > Hi, > > patches attached. > > Decoder speedup is approx %20 overall. > From 9692daafc0c4a69ce3cf7dca5b5aa90b5737e15f Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Sat, 25 Jul 2020 18:18:18 +0200 > Subject: [PATCH 1/2] avcodec: add CFHD encoder

Re: [FFmpeg-devel] [RFC] cineform CFHD encoder, and decoder speedup

Paul B Mahol (12020-07-30): > Hi, > > patches attached. > > Decoder speedup is approx %20 overall. > From 9692daafc0c4a69ce3cf7dca5b5aa90b5737e15f Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Sat, 25 Jul 2020 18:18:18 +0200 > Subject: [PATCH 1/2] avcodec: add CFHD encoder > > --- > l

Re: [FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter

Hi! On 2020-07-30 12:16 +, Zane van Iperen wrote: > On Fri, 31 Jul 2020 00:55:56 +0800 > "zongwave" wrote: [...] > > > ++static av_cold int xcam_init(AVFilterContext *ctx) > > ++{ > > ++XCAMContext *s = ctx->priv; > > ++int ret = 0; > > ++ > > ++s->handle = xcam_create_handle(s->n

Re: [FFmpeg-devel] [PATCH 1/2] lavc/aac_ac3_parser: fix the potential overflow

On 2020-07-30 21:18 +0800, myp...@gmail.com wrote: > > After repeated thinking， I can accept this solution, thx Just to avoid confusion. You accept this > > > > avctx->bit_rate += (s->bit_rate - avctx->bit_rate) / s->frame_number; or this > > If you are aiming for improving accuracy, I guess go

Re: [FFmpeg-devel] Backporting Policy

On 7/30/2020 9:33 AM, Zane van Iperen wrote: > Hi all, > > What's the policy for backporting patches? > Is it just run-FATE-then-push, or is there some extra review required? Ensuring nothing breaks and FATE passes is of course a must, but there's no extra review requirement. Keep in mind the onl

[FFmpeg-devel] [PATCH] avcodec, avfilter, avformat: Remove redundant avpriv_align_put_bits

flush_put_bits() already fills the bitstream with zeroes, so it is unnecessary to align the bitstream before. Signed-off-by: Andreas Rheinhardt --- avpriv_align_put_bits() seems to be a function that should not exist as an avpriv function and instead be replaced by an inline function like the oth

[FFmpeg-devel] [PATCH v2 3/3] libsvtav1: Fix the documentation to match the actual options

--- doc/encoders.texi | 48 +++--- libavcodec/libsvtav1.c | 6 +++--- 2 files changed, 39 insertions(+), 15 deletions(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index af7d2ba983..2f5457fb26 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi

[FFmpeg-devel] [PATCH v2 2/3] libsvtav1: Use _ rather than - in options

--- libavcodec/libsvtav1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c index 0c951286c7..13d3adc0f8 100644 --- a/libavcodec/libsvtav1.c +++ b/libavcodec/libsvtav1.c @@ -536,8 +536,8 @@ static const AVOption options[] = {

[FFmpeg-devel] [PATCH v2 1/3] libsvtav1: Rename without a -

The external library is called libsvtav1, so use this name everywhere. --- configure| 2 +- libavcodec/Makefile | 2 +- libavcodec/allcodecs.c | 2 +- libavcodec/{libsvt_av1.c => libsvtav1.c} | 8 4 files changed, 7 in

Re: [FFmpeg-devel] [PATCH 0/5 v2] 22.2 channel layout support for AAC decoding

On Wed, Jul 29, 2020 at 2:39 PM Jan Ekström wrote: > > swresample seems to give out the correct channels for 5.1 and stereo > downmix (checked with ffmpeg.c by utilizing `-channel_layout` 5.1 and stereo), > although the default downmix logic seems to lower the volume somewhat. > I attempted to ta

Re: [FFmpeg-devel] [RFC] cineform CFHD encoder, and decoder speedup

Paul B Mahol: > > +static int cfhd_encode_frame(AVCodecContext *avctx, AVPacket *pkt, > + const AVFrame *frame, int *got_packet) > +{ > +CFHDEncContext *s = avctx->priv_data; > +PutByteContext *pby = &s->pby; > +PutBitContext *pb = &s->pb; > +const Codeb

[FFmpeg-devel] [PATCH] librav1e: Make tile options consistent with other encoders

In all other AV1 encoders these are set as log2 of the number of tile columns/rows to use. This does change not the accessible configuration, since librav1e already requires these numbers to be powers of two. --- Possibly this is too late to be acceptable without additional messing around, but I'

Re: [FFmpeg-devel] [PATCH 1/6] vaapi_encode_h265: Remove confusing and redundant tile options

On 29/07/2020 07:08, Fu, Linjie wrote: From: ffmpeg-devel On Behalf Of Mark Thompson Sent: Wednesday, July 29, 2020 06:50 To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 1/6] vaapi_encode_h265: Remove confusing and redundant tile options The tile_rows/cols options currently do a conf

Re: [FFmpeg-devel] [PATCH 1/2] libsvt-av1: Consistently use - rather than _

On 30/07/2020 03:53, James Almer wrote: > The name could also be simply libsvtav1, same as the library (and the > configure option), since unlike libvpx and (in theory) libaom, no other > codec will be supported by it. HEVC is in a different library. That makes more sense. I'll use libsvtav1 eve

Re: [FFmpeg-devel] [PATCH v2 1/3] libsvtav1: Rename without a -

On 7/30/2020 6:31 PM, Mark Thompson wrote: > The external library is called libsvtav1, so use this name everywhere. > --- > configure| 2 +- > libavcodec/Makefile | 2 +- > libavcodec/allcodecs.c | 2 +- > libavcodec/{libsvt_av

Re: [FFmpeg-devel] [PATCH 1/2] lavc/aac_ac3_parser: fix the potential overflow

On Fri, Jul 31, 2020 at 3:47 AM Alexander Strasser wrote: > > On 2020-07-30 21:18 +0800, myp...@gmail.com wrote: > > > > After repeated thinking， I can accept this solution, thx > > Just to avoid confusion. You accept this > > > > > > avctx->bit_rate += (s->bit_rate - avctx->bit_rate) / s->frame_n

Re: [FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter

> On Jul 31, 2020, at 3:08 AM, Alexander Strasser wrote: > > Hi! > > On 2020-07-30 12:16 +, Zane van Iperen wrote: >> On Fri, 31 Jul 2020 00:55:56 +0800 >> "zongwave" wrote: > [...] >> >>> ++static av_cold int xcam_init(AVFilterContext *ctx) >>> ++{ >>> ++XCAMContext *s = ctx->priv;

[FFmpeg-devel] Pull Request - Support Windows Subsystem for Linux

Attaching git format-patch change. Allows building FFmpeg on Windows using bash.exe provided by WSL, as an alternative to MSYS. 0001-Add-support-for-WSL.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg

[FFmpeg-devel] [v2] dnn_backend_native_layer_mathunary: add ceil_v2 support

It can be tested with the model generated with below python script: import tensorflow as tf import os import numpy as np import imageio from tensorflow.python.framework import graph_util name = 'ceil' pb_file_path = os.getcwd() if not os.path.exists(pb_file_path+'/{}_savemodel/'.format(name)):

Re: [FFmpeg-devel] Pull Request - Support Windows Subsystem for Linux

> Am 31.07.2020 um 06:59 schrieb Julio César Rocha : > > Attaching git format-patch change. > > Allows building FFmpeg on Windows using bash.exe provided by WSL, as an > alternative to MSYS. The commit message is not ok as many people regularly build with wsl. And please split the patch. Carl

Re: [FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter

> -Original Message- > From: ffmpeg-devel On Behalf Of Zane > van Iperen > Sent: Thursday, July 30, 2020 8:17 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter > > On Fri, 31 Jul 2020 00:55:56 +0800 > "zongwave" wrote: > > >