Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/url: check double dot is not to parent directory

2020-07-25 Thread Nicolas George
Steven Liu (12020-07-25): > fix ticket: 8814 > if get ".." in the url, check next byte and lead byte by double dot, > it there have no '/' and not root node, it is not used go to directory ".." > > Signed-off-by: Steven Liu > --- > libavformat/url.c | 12 > 1 file changed, 12 insert

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/url: check double dot is not to parent directory

2020-07-25 Thread Nicolas George
刘歧 (12020-07-25): > I think the best would be to use strtok(p, "/") to split the path into the > components and for each ".." component remove the previous one (if there > are some still). > I think you can submit patch if you have full idea for it. strtok() is a terrible API, and bett

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/url: check double dot is not to parent directory

2020-07-25 Thread Steven Liu
Nicolas George 于2020年7月25日周六 下午4:31写道: > > Steven Liu (12020-07-25): > > fix ticket: 8814 > > if get ".." in the url, check next byte and lead byte by double dot, > > it there have no '/' and not root node, it is not used go to directory ".." > > > > Signed-off-by: Steven Liu > > --- > > libavfo

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/url: check double dot is not to parent directory

2020-07-25 Thread Nicolas George
Steven Liu (12020-07-25): > > And I think you would better rework the complete logic of the test: > agreed, I think need lots of testcase for the logic, ../ .../.. > dummy../... .../..dummy and so on, > maybe need spend some time to do it :D I did not mean the FATE test for this feature, I meant t

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/url: check double dot is not to parent directory

2020-07-25 Thread Steven Liu
Nicolas George 于2020年7月25日周六 下午4:44写道: > > Steven Liu (12020-07-25): > > > And I think you would better rework the complete logic of the test: > > agreed, I think need lots of testcase for the logic, ../ .../.. > > dummy../... .../..dummy and so on, > > maybe need spend some time to do it :D > > I

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/url: check double dot is not to parent directory

2020-07-25 Thread Marton Balint
On Sat, 25 Jul 2020, Zlomek, Josef wrote: Hi Steven, It is better but still not correct. Consider this test: test("http://server/foo/bar";, "a/b/../c/d/../e../.../..f/g../h../other/url/a.mp3/..."); It should give " http://server/foo/bar/a/c/e../.../..f/g../h../other/url/a.mp3/...";. I think

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/url: check double dot is not to parent directory

2020-07-25 Thread Steven Liu
Marton Balint 于2020年7月25日周六 下午5:40写道: > And I also would like to point out that using static strings with > MAX_URL_SIZE is not OK. This function supports an arbitrary buffer size, > so limiting it to MAX_URL_SIZE is a bug. Okay, get it, i'm reworking. Thanks Steven _

[FFmpeg-devel] AVWriter again (was: v2 1/2] avformat/url: check double dot is not to parent directory)

2020-07-25 Thread Nicolas George
Marton Balint (12020-07-25): > And I also would like to point out that using static strings with > MAX_URL_SIZE is not OK. This function supports an arbitrary buffer size, so > limiting it to MAX_URL_SIZE is a bug. Excellent point. That would require changing the prototype of a few functions, but

[FFmpeg-devel] [PATCH v5] libavcodec/jpeg2000dec: Support for PPM marker

2020-07-25 Thread gautamramk
From: Gautam Ramakrishnan This patch adds support for PPM marker for JPEG2000 decoder. It allows the samples p1_03.j2k and p1_05.j2k to be decoded. --- libavcodec/jpeg2000dec.c | 106 +++ 1 file changed, 96 insertions(+), 10 deletions(-) diff --git a/libavcod

[FFmpeg-devel] [PATCH] flvdec: Remove unnecessary initializations

2020-07-25 Thread Zhao Zhili
pre_tag_size is always reset by avio_rb32(). For AVFormatContext start_time, as the document says, "NEVER set this value directly: It is deduced from the AVStream values." --- libavformat/flvdec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/flvdec.c b/libavfor

Re: [FFmpeg-devel] [PATCH] lavf/srt: fix build fail when used the libsrt 1.4.1

2020-07-25 Thread Christopher Degawa
On Sat, Jul 18, 2020 at 9:24 AM myp...@gmail.com wrote: > > On Thu, Jul 16, 2020 at 9:35 AM myp...@gmail.com wrote: > > > > On Tue, Jul 14, 2020 at 9:47 PM Moritz Barsnick wrote: > > > > > > On Sun, Jul 12, 2020 at 22:44:46 +0800, myp...@gmail.com wrote: > > > > Maybe I give an inaccurate descri

[FFmpeg-devel] cineform decoder bug

2020-07-25 Thread Paul B Mahol
Hi, In decoder bits per raw sample is always hardcoded to 10, that is not correct. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffm

Re: [FFmpeg-devel] [PATCH] avformat/riffenc: correct calculation for extradata size

2020-07-25 Thread Gyan Doshi
Will push in 12 hours. On 25-07-2020 10:44 am, Gyan Doshi wrote: In 1ec2b3de5a, the extradata size was affected when the raster was signaled as flipped due to user-set option rather than via extradata. This resulted in a wrong header size being written. Fixed. --- libavformat/riffenc.c | 8 +++

Re: [FFmpeg-devel] [PATCH] avformat/ape: Error out in case of EOF in the header

2020-07-25 Thread Michael Niedermayer
On Sat, Jul 25, 2020 at 06:10:44AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: OOM > > Fixes: > > 24375/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6216862443241472 > > > > Found-by: continuous fuzzing process > > https://github.com/google/oss-fuzz/tree/master/pro

[FFmpeg-devel] [PATCH] avformat/ape: Remove seektable and bittable

2020-07-25 Thread Michael Niedermayer
Suggested-by: Andreas Signed-off-by: Michael Niedermayer --- libavformat/ape.c | 75 --- 1 file changed, 25 insertions(+), 50 deletions(-) diff --git a/libavformat/ape.c b/libavformat/ape.c index d92cb2867d..2698c770ee 100644 --- a/libavformat/ape.c ++

Re: [FFmpeg-devel] working with file descriptors on Android

2020-07-25 Thread Matthieu Bouron
On Wed, Jul 22, 2020 at 2:38 PM Alex Cohn wrote: > Usually, we employ the `pipe:` protocol to deal with the numerical > file descriptors, and this answers all our needs. On Android, there is > a different use case in which numerical file descriptors appear, and > this is not covered well with `pi

[FFmpeg-devel] [PATCH 1/2] avcodec/pgxdec: Fix invalid shift in write_frame_*

2020-07-25 Thread Michael Niedermayer
Fixes: left shift of negative value -121 Fixes: 23911/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PGX_fuzzer-4986800258154496 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/pgxdec.c | 2

[FFmpeg-devel] [PATCH 2/2] avcodec/mv30: Fix several integer overflows in idct_1d()

2020-07-25 Thread Michael Niedermayer
Fixes: signed integer overflow: -1846510390 + -361755993 cannot be represented in type 'int' Fixes: 23941/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MV30_fuzzer-5654696631730176 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off

[FFmpeg-devel] Inconsistent handling of initial_padding and PTS adjustment

2020-07-25 Thread Kieran Kunhya
Hi, I notice that some encoders adjust the PTS with initial_padding and some don't. Is this intentional and should we decide that all encoders should do this? Regards, Kieran Kunhya ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.or

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/pgxdec: Fix invalid shift in write_frame_*

2020-07-25 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: left shift of negative value -121 > Fixes: > 23911/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PGX_fuzzer-4986800258154496 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Nieder

[FFmpeg-devel] [PATCH] avformat/flvdec: Remove unnecessary initializations

2020-07-25 Thread Zhao Zhili
pre_tag_size is always reset by avio_rb32(). For AVFormatContext start_time, as the document says, "NEVER set this value directly: It is deduced from the AVStream values." --- fix commit subject libavformat/flvdec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/

Re: [FFmpeg-devel] [PATCH] avformat/riffenc: correct calculation for extradata size

2020-07-25 Thread Gyan Doshi
On 25-07-2020 11:00 pm, Gyan Doshi wrote: Will push in 12 hours. Pushed as 93694fe777d12a9432b5ceeb564631da6311ae26 Gyan On 25-07-2020 10:44 am, Gyan Doshi wrote: In 1ec2b3de5a, the extradata size was affected when the raster was signaled as flipped due to user-set option rather than via

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/url: check double dot is not to parent directory

2020-07-25 Thread Zlomek, Josef
I will submit patch on monday. Josef On Sat, Jul 25, 2020 at 8:27 AM 刘歧 wrote: > > > 在 2020/7/25 下午2:11,“ffmpeg-devel 代表 Zlomek, Josef”< > ffmpeg-devel-boun...@ffmpeg.org 代表 jo...@pex.com> 写入: > > Hi Steven, > > It is better but still not correct. Consider this test: > > test("http