Re: [FFmpeg-devel] [PATCH] x86/yuv2rgb: fix crashes when storing data on unaligned buffers

2020-07-13 Thread Carl Eugen Hoyos
> Am 13.07.2020 um 02:33 schrieb James Almer : > > Regression since fc6a5883d6af8cae0e96af84dda0ad74b360a084 on SSSE3 enabled > CPUs. FFmpeg does not require aligned output buffers on x86_64? > Fixes ticket #8747 Another issue is described in this ticket that implies an overwrite: Can you re

Re: [FFmpeg-devel] Bug in FFMPEG video filter TINTERLACE needs fixing

2020-07-13 Thread Paul B Mahol
You have setfield and similar filters that can be used before this filter. On 7/12/20, Ben Hutchinson wrote: > Problem is it's not as simple as just patching it to start at field 1 > instead of field 2. It really depends on your signal source. If your signal > source recorded all lines that conta

[FFmpeg-devel] [PATCH 2/2] SpeedHQ encoder

2020-07-13 Thread Jean-Baptiste Kempf
This is heavily based on MPEG-2 encoder, of course. --- Changelog | 1 + doc/general.texi | 2 +- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/mpegutils.h | 1 + libavcodec/mpegvideo.h | 3 +++ libavcodec/mpegvideo_enc.c |

[FFmpeg-devel] [PATCH 1/2] mpeg2: Renaming functions around init_uni_ac_vlc

2020-07-13 Thread Jean-Baptiste Kempf
We need to export init_uni_ac_vlc to init_uni_ac_vlc and therefore need renaming ff_init_uni_ac_vlc to ff_init_uni_ac_huffman for the following patch. --- libavcodec/mjpegenc.c| 4 ++-- libavcodec/mjpegenc_common.c | 6 +++--- libavcodec/mjpegenc_common.h | 2 +- libavcodec/mpeg12.h

[FFmpeg-devel] [PATCH 2/2] SpeedHQ encoder

2020-07-13 Thread Jean-Baptiste Kempf
This is heavily based on MPEG-2 encoder, of course. --- Changelog | 1 + doc/general.texi | 2 +- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/mpegutils.h | 1 + libavcodec/mpegvideo.h | 3 + libavcodec/mpegvideo_enc.

Re: [FFmpeg-devel] [PATCH] x86/yuv2rgb: fix crashes when storing data on unaligned buffers

2020-07-13 Thread James Almer
On 7/13/2020 4:02 AM, Carl Eugen Hoyos wrote: > > >> Am 13.07.2020 um 02:33 schrieb James Almer : >> >> Regression since fc6a5883d6af8cae0e96af84dda0ad74b360a084 on SSSE3 enabled >> CPUs. > > FFmpeg does not require aligned output buffers on x86_64? There's no alignment requirement mentioned an

Re: [FFmpeg-devel] [PATCH v08.01 2/3] fbtile tile/detile, hwcontext_drm detile NonLinear

2020-07-13 Thread Lynne
Jul 12, 2020, 18:21 by hanish...@gmail.com: > ** fbtile cpu based framebuffer tile/detile helpers > > diff --git a/Changelog b/Changelog > index 20ba03ae8b..0b48858da7 100644 > --- a/Changelog > +++ b/Changelog > @@ -6,6 +6,8 @@ version : > - MacCaption demuxer > - PGX decoder > - kmsgrab GetFB

Re: [FFmpeg-devel] [PATCH 2/2] SpeedHQ encoder

2020-07-13 Thread Derek Buitenhuis
On 13/07/2020 12:31, Jean-Baptiste Kempf wrote: > + > +av_cold int ff_speedhq_encode_init(MpegEncContext *s) > +{ Most of the stuff in this init function is global, and thus should be done via ff_thread_once, and caps_internal should have FF_CODEC_CAP_INIT_THREADSAFE. - Derek ___

Re: [FFmpeg-devel] [PATCH] [PATCH] POWER8 VSX vectorization libswscale/input.c Track ticket 5570

2020-07-13 Thread Pestov Vyacheslav
Please, check my patch. It has been in pending status for a long time. I can’t get a bounty. If something needs to be finalized, just tell me. https://patchwork.ffmpeg.org/project/ffmpeg/patch/1585056463-7934-1-git-send-email-pestov.vy...@yandex.ru/ https://trac.ffmpeg.org/ticket/5570 On 25.03.

Re: [FFmpeg-devel] [PATCH v8 3/3] avdevice/decklink_dec: export timecode with s12m side data

2020-07-13 Thread Devin Heitmueller
On Sun, Jul 12, 2020 at 6:16 AM wrote: > I have add fate timecode testing for h264/hevc and haven't submit yet. But if > the frame rate > 30, I got one unexpected result after map SMPTE ST 12-1:2014 > side data to HEVC timecode, the frame is 6bit only(2bit for tens of frame), > so to framerate > 3

Re: [FFmpeg-devel] [PATCH v3] avcodec/v4l2_m2m_dec: Remove redundant packet and fix double free

2020-07-13 Thread James Almer
On 7/12/2020 8:11 PM, Andriy Gelman wrote: > On Wed, 24. Jun 09:26, Andriy Gelman wrote: >> On Mon, 25. May 14:59, Andriy Gelman wrote: >>> On Sat, 16. May 11:53, Andriy Gelman wrote: On Sat, 09. May 13:35, Andriy Gelman wrote: > From: Andriy Gelman > > v4l2_receive_frame() uses t

Re: [FFmpeg-devel] [PATCH] x86/yuv2rgb: fix crashes when storing data on unaligned buffers

2020-07-13 Thread Ronald S. Bultje
On Mon, Jul 13, 2020 at 3:10 AM Carl Eugen Hoyos wrote: > > > > Am 13.07.2020 um 02:33 schrieb James Almer : > > > > Regression since fc6a5883d6af8cae0e96af84dda0ad74b360a084 on SSSE3 > enabled > > CPUs. > > FFmpeg does not require aligned output buffers on x86_64? Not in swscale/avfilter, only

[FFmpeg-devel] [PATCH v3 1/4] libavutil/imgutils: add utility to get plane sizes

2020-07-13 Thread Brian Kim
This utility helps avoid undefined behavior when doing things like checking how much memory we need to allocate for an image before we have allocated a buffer. Signed-off-by: Brian Kim --- doc/APIchanges | 3 ++ libavutil/imgutils.c | 98 +--- libav

[FFmpeg-devel] [PATCH v3 2/4] libavutil/frame: avoid UB when getting plane sizes

2020-07-13 Thread Brian Kim
This uses av_image_fill_plane_sizes instead of av_image_fill_pointers when we are getting plane sizes to avoid UB from adding offsets to NULL. Signed-off-by: Brian Kim --- libavutil/frame.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/libavutil/frame.

[FFmpeg-devel] [PATCH v3 4/4] libavutil/imgutils: check for non-null buffer in av_image_fill_pointers

2020-07-13 Thread Brian Kim
We were previously always filling data by adding offsets to ptr, which was undefined behavior when ptr was NULL. Signed-off-by: Brian Kim --- libavutil/imgutils.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/imgutils.c b/libavutil/imgutils.c index 345b7fa94c..721dc2784a 10064

[FFmpeg-devel] [PATCH v3 3/4] libavcodec/decode: avoid UB when getting plane sizes

2020-07-13 Thread Brian Kim
This uses av_image_fill_plane_sizes instead of av_image_fill_pointers when we are getting plane sizes to avoid UB from adding offsets to NULL. Signed-off-by: Brian Kim --- libavcodec/decode.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/libavc

[FFmpeg-devel] [PATCH 1/4] libavcodec/jpeg2000dec : Prevent overriding SOP marker bit

2020-07-13 Thread gautamramk
From: Gautam Ramakrishnan Currently, the COC marker overrides the SOP marker bit. However, only the COD marker may set this value. This patch fixes this bug. --- libavcodec/jpeg2000dec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/

[FFmpeg-devel] [PATCH 4/4] libavcodec/jpeg2000dec: Support for PPM marker

2020-07-13 Thread gautamramk
From: Gautam Ramakrishnan This patch adds support for PPM marker for JPEG2000 decoder. It allows the samples p1_03.j2k and p1_05.j2k to be decoded. --- libavcodec/jpeg2000dec.c | 107 +++ 1 file changed, 97 insertions(+), 10 deletions(-) diff --git a/libavcod

[FFmpeg-devel] [PATCH 2/4] libavcodec/jpeg2000 Fix PCRL Progression Order check

2020-07-13 Thread gautamramk
From: Gautam Ramakrishnan The PCRL progression checks were incomplete. This patch modifes completes the check. Tested on p1_05.j2k. --- libavcodec/jpeg2000dec.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg

[FFmpeg-devel] [PATCH 3/4] libavcodec/jpeg2000 Fix RPCL Progression order check

2020-07-13 Thread gautamramk
From: Gautam Ramakrishnan The RPCL progression order check was incomplete. This patch completes the check. Tested on p1_07.j2k. --- libavcodec/jpeg2000dec.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c

Re: [FFmpeg-devel] [PATCH v3 1/4] libavutil/imgutils: add utility to get plane sizes

2020-07-13 Thread James Almer
On 7/13/2020 2:09 PM, Brian Kim wrote: > This utility helps avoid undefined behavior when doing things like > checking how much memory we need to allocate for an image before we have > allocated a buffer. > > Signed-off-by: Brian Kim > --- > doc/APIchanges | 3 ++ > libavutil/imgutils.c |

Re: [FFmpeg-devel] [PATCH] avformat/crypto.c: remove unnecessary code

2020-07-13 Thread Tomas Härdin
lör 2020-07-11 klockan 16:04 +0800 skrev Steven Liu: > Because the newpos variable is set value before use it. > The newpos variable declared at the head partition of crypto_seek. > > Signed-off-by: Steven Liu > --- > libavformat/crypto.c | 11 --- > 1 file changed, 4 insertions(+), 7 de

Re: [FFmpeg-devel] [PATCH] x86/yuv2rgb: fix crashes when storing data on unaligned buffers

2020-07-13 Thread Michael Niedermayer
On Mon, Jul 13, 2020 at 10:19:07AM -0300, James Almer wrote: > On 7/13/2020 4:02 AM, Carl Eugen Hoyos wrote: > > > > > >> Am 13.07.2020 um 02:33 schrieb James Almer : > >> > >> Regression since fc6a5883d6af8cae0e96af84dda0ad74b360a084 on SSSE3 enabled > >> CPUs. > > > > FFmpeg does not require a

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Prevent shift by negative number

2020-07-13 Thread Tomas Härdin
fre 2020-07-10 klockan 15:48 +0200 skrev Andreas Rheinhardt: > This happened in get_ue_golomb() if the cached bitstream reader was > in > use, because there was no check to handle the case of the read value > not being in the range 0..8190. > > Signed-off-by: Andreas Rheinhardt > --- > libavcode

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Prevent shift by negative number

2020-07-13 Thread Andreas Rheinhardt
Tomas Härdin: > fre 2020-07-10 klockan 15:48 +0200 skrev Andreas Rheinhardt: >> This happened in get_ue_golomb() if the cached bitstream reader was >> in >> use, because there was no check to handle the case of the read value >> not being in the range 0..8190. >> >> Signed-off-by: Andreas Rheinhard

[FFmpeg-devel] [PATCH 4/4] avformat/au: Avoid allocation for metadata string

2020-07-13 Thread Andreas Rheinhardt
When there are potentially annotation (i.e. metadata) fields to write, au_get_annotations() is called to produce a string with them. To do so, it uses an AVBPrint which is finalized to create the string. This is wasteful, because it always leads to an allocation even if the string actually fits int

[FFmpeg-devel] [PATCH 3/4] avformat/au: Simplify writing string into AVBPrint

2020-07-13 Thread Andreas Rheinhardt
by using av_bprintf() instead of several av_bprint_append(). Signed-off-by: Andreas Rheinhardt --- libavformat/au.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavformat/au.c b/libavformat/au.c index c4a32ff76c..a8906a9db7 100644 --- a/libavformat/au.c +++ b/libav

[FFmpeg-devel] [PATCH 2/4] avformat/au: Remove redundant av_freep()

2020-07-13 Thread Andreas Rheinhardt
This av_freep(&key) in conjunction with the fact that the loop condition checks for key != NULL was equivalent to a av_freep(&key) + a break immediately thereafter. But given that there is an av_freep(&key) directly after the loop, the av_freep(&key) is unnecessary and the break can also be added e

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Prevent shift by negative number

2020-07-13 Thread Michael Niedermayer
On Mon, Jul 13, 2020 at 09:04:30PM +0200, Tomas Härdin wrote: > fre 2020-07-10 klockan 15:48 +0200 skrev Andreas Rheinhardt: > > This happened in get_ue_golomb() if the cached bitstream reader was > > in > > use, because there was no check to handle the case of the read value > > not being in the r

[FFmpeg-devel] [PATCH 1/4] avformat/au: Store strings instead of pointers to strings in array

2020-07-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/au.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavformat/au.c b/libavformat/au.c index f92863e400..b419c9ed95 100644 --- a/libavformat/au.c +++ b/libavformat/au.c @@ -68,13 +68,13 @@ static int au_probe(co

Re: [FFmpeg-devel] [PATCH] [PATCH] POWER8 VSX vectorization libswscale/input.c Track ticket 5570

2020-07-13 Thread Michael Niedermayer
Hi On Mon, Jul 13, 2020 at 05:38:40PM +0300, Pestov Vyacheslav wrote: > Please, check my patch. It has been in pending status for a long time. I > can’t get a bounty. If something needs to be finalized, just tell me. > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/1585056463-7934-1-git-sen

Re: [FFmpeg-devel] [PATCH] [PATCH] POWER8 VSX vectorization libswscale/input.c Track ticket 5570

2020-07-13 Thread Michael Niedermayer
On Mon, Jul 13, 2020 at 10:23:28PM +0200, Michael Niedermayer wrote: > Hi > > On Mon, Jul 13, 2020 at 05:38:40PM +0300, Pestov Vyacheslav wrote: > > Please, check my patch. It has been in pending status for a long time. I > > can’t get a bounty. If something needs to be finalized, just tell me. >

Re: [FFmpeg-devel] [PATCH 4/4] libavcodec/jpeg2000dec: Support for PPM marker

2020-07-13 Thread Michael Niedermayer
On Mon, Jul 13, 2020 at 10:50:02PM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This patch adds support for PPM marker for JPEG2000 > decoder. It allows the samples p1_03.j2k and p1_05.j2k > to be decoded. > --- > libavcodec/jpeg2000dec.c | 107 +

Re: [FFmpeg-devel] [PATCH 1/2] mpeg2: Renaming functions around init_uni_ac_vlc

2020-07-13 Thread Michael Niedermayer
On Mon, Jul 13, 2020 at 01:16:18PM +0200, Jean-Baptiste Kempf wrote: > We need to export init_uni_ac_vlc to init_uni_ac_vlc and therefore need > renaming ff_init_uni_ac_vlc to ff_init_uni_ac_huffman for the following > patch. > --- > libavcodec/mjpegenc.c| 4 ++-- > libavcodec/mjpegenc_com

Re: [FFmpeg-devel] [PATCH v2 2/3] doc/developer.texi: Restructured "Submitting patches" section.

2020-07-13 Thread Michael Niedermayer
On Sun, Jul 12, 2020 at 11:53:00PM +0200, Manolis Stamatogiannakis wrote: > - Main text split to two sections. > - Detailed checklist for new codecs or formats demoted to section. > - Detailed checklist for patch submission demoted to section. If a commit message needs a list enumerating something

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_codecview: enable qp visualization for H264 and VP9

2020-07-13 Thread Yongle Lin
On Thu, Jul 9, 2020 at 2:18 PM Yongle Lin wrote: > > > On Mon, Jul 6, 2020 at 10:56 AM Yongle Lin > wrote: > >> >> >> On Thu, Jun 25, 2020 at 12:09 PM Yongle Lin >> wrote: >> >>> Add qp visualization in codecview filter which supports H264 and VP9 >>> codecs. Add options for luma/chroma qp and

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_codecview: add block structure visualization

2020-07-13 Thread Yongle Lin
On Thu, Jul 2, 2020 at 8:09 AM Michael Niedermayer wrote: > On Wed, Jul 01, 2020 at 05:42:48PM +, Yongle Lin wrote: > > example command line to visualize block decomposition: > > ./ffmpeg -export_side_data +venc_params -i input.webm -vf > > codecview=bs=true output.webm > > --- > > > doc/fil

Re: [FFmpeg-devel] [PATCH] libavcodec/vp9: export block structure when segmentation isn't enable

2020-07-13 Thread Yongle Lin
On Thu, Jul 9, 2020 at 2:23 PM Yongle Lin wrote: > > > On Mon, Jul 6, 2020 at 11:31 AM Yongle Lin > wrote: > >> it makes sense to export block structure like src_x, src_y, width and >> height when segmentation isn't enable so we could visualize and see the >> structure of the block. >> --- >> l

Re: [FFmpeg-devel] [PATCH v8 3/3] avdevice/decklink_dec: export timecode with s12m side data

2020-07-13 Thread lance . lmwang
On Mon, Jul 13, 2020 at 10:24:11AM -0400, Devin Heitmueller wrote: > On Sun, Jul 12, 2020 at 6:16 AM wrote: > > I have add fate timecode testing for h264/hevc and haven't submit yet. But > > if > > the frame rate > 30, I got one unexpected result after map SMPTE ST > > 12-1:2014 > > side data to

Re: [FFmpeg-devel] [PATCH v3 1/4] libavutil/imgutils: add utility to get plane sizes

2020-07-13 Thread Brian Kim
On Mon, Jul 13, 2020 at 11:22 AM James Almer wrote: [...] > You would need to cast height to size_t for this, i think, but seeing > av_image_check_size() currently rejects line sizes and plane sizes > bigger than INT_MAX, maybe we should just keep INT_MAX in the above > check instead (No need to s

Re: [FFmpeg-devel] [PATCH] avformat/crypto.c: remove unnecessary code

2020-07-13 Thread 刘歧
在 2020/7/14 上午2:45,“ffmpeg-devel 代表 Tomas Härdin” 写入: lör 2020-07-11 klockan 16:04 +0800 skrev Steven Liu: > Because the newpos variable is set value before use it. > The newpos variable declared at the head partition of crypto_seek. > > Signed-off-by: Steven Liu > --

Re: [FFmpeg-devel] [PATCH 4/4] libavcodec/jpeg2000dec: Support for PPM marker

2020-07-13 Thread Gautam Ramakrishnan
On Tue, Jul 14, 2020 at 2:57 AM Michael Niedermayer wrote: > > On Mon, Jul 13, 2020 at 10:50:02PM +0530, gautamr...@gmail.com wrote: > > From: Gautam Ramakrishnan > > > > This patch adds support for PPM marker for JPEG2000 > > decoder. It allows the samples p1_03.j2k and p1_05.j2k > > to be decod

[FFmpeg-devel] [PATCH v2] avformat/crypto.c: remove unnecessary code

2020-07-13 Thread Steven Liu
Because the newpos variable is set value before use it. The newpos variable declared at the head partition of crypto_seek. Make the code clean. Signed-off-by: Steven Liu --- libavformat/crypto.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/libavformat/crypto.c