Re: [FFmpeg-devel] Support for dumping pgx for JPEG2000

2020-06-22 Thread Carl Eugen Hoyos
> Am 22.06.2020 um 07:32 schrieb Gautam Ramakrishnan : > > Hello, > > JPEG2000 uses .pgx format for conformance testing. Is it a good idea > to allow the ffmpeg > native decoder to have an option to dump .pgx files? This would help > with testing additions > to the code. I believe it would be

Re: [FFmpeg-devel] Support for dumping pgx for JPEG2000

2020-06-22 Thread Gautam Ramakrishnan
On Mon, Jun 22, 2020 at 12:38 PM Carl Eugen Hoyos wrote: > > > > > Am 22.06.2020 um 07:32 schrieb Gautam Ramakrishnan : > > > > Hello, > > > > JPEG2000 uses .pgx format for conformance testing. Is it a good idea > > to allow the ffmpeg > > native decoder to have an option to dump .pgx files? This

Re: [FFmpeg-devel] [Patch] vf_edgedetect: properly implement double_threshold()

2020-06-22 Thread Valery Kot
On Mon, Jun 22, 2020 at 7:58 AM Andriy Gelman wrote: > > Hi Valery, > > Thanks for the patch. > > Please also update the fate test: > https://patchwork.ffmpeg.org/project/ffmpeg/patch/cagtf1mncx2joo-vmtucdkjcp76y5jslnhubzat4mf48c2hf...@mail.gmail.com/ Thanks for feedback. Updating FATE tests is a

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/packet: Improve documentation of av_packet_get_side_data

2020-06-22 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-06-21 10:53:47) > Document that it also sets the size in case the desired side data is > absent (if the pointer has been supplied). > > Signed-off-by: Andreas Rheinhardt > --- > Do this and the next patch actually need a version bump and API change > entry? I'd s

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/nellymoserdec: Don't use invalid AVPacketSideDataType

2020-06-22 Thread Anton Khirnov
Patchset looks ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] To Speed Up thumbnail creation - picture & video

2020-06-22 Thread Arunava Banerjee
Hello, We have been using FFMPEG library to create the following thumbnails from videos: a. picture b. video - for example a 60secs video thumbnail. Our video sizes are about 200 - 300 MB. We are using a PHP program to transfer command to the shell for FFMPEG executable to generate the thumbnails

Re: [FFmpeg-devel] [PATCH 05/11] avcodec/h264_parser: Reuse the RBSP buffer

2020-06-22 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-05-29 17:52:40) > Ping. What is other's opinion on this matter? Notice that the current > behaviour is suboptimal even if it is decided that the buffer should not > be kept: It allocates 1/16 more than needed (in addition to > AV_INPUT_BUFFER_PADDING_SIZE) that is g

Re: [FFmpeg-devel] [PATCH 1/4 v2] avutil/buffer: change public function and struct size parameter types to size_t

2020-06-22 Thread Anton Khirnov
Quoting James Almer (2020-06-01 19:25:36) > Signed-off-by: James Almer > --- > No changes since v1. > > doc/APIchanges | 4 > libavutil/buffer.c | 25 + > libavutil/buffer.h | 31 +++ > libavutil/buffer_inte

Re: [FFmpeg-devel] Support for dumping pgx for JPEG2000

2020-06-22 Thread Moritz Barsnick
On Mon, Jun 22, 2020 at 12:47:11 +0530, Gautam Ramakrishnan wrote: > On Mon, Jun 22, 2020 at 12:38 PM Carl Eugen Hoyos wrote: > > > Am 22.06.2020 um 07:32 schrieb Gautam Ramakrishnan : > > > JPEG2000 uses .pgx format for conformance testing. Is it a good idea > > > to allow the ffmpeg native decod

Re: [FFmpeg-devel] [Patch] vf_edgedetect: properly implement double_threshold()

2020-06-22 Thread Moritz Barsnick
On Fri, Jun 19, 2020 at 17:15:06 +0200, Valery Kot wrote: > -if ((!i || i == w - 1 || !j || j == h - 1) && > +if (!(!i || i == w - 1 || !j || j == h - 1) && NOT of a logical OR can be inverted, so this *may* be more readable as: if ((i && i != w - 1 && j && j

Re: [FFmpeg-devel] [Patch] vf_edgedetect: properly implement double_threshold()

2020-06-22 Thread Moritz Barsnick
On Mon, Jun 22, 2020 at 09:58:42 +0200, Valery Kot wrote: > Thanks for feedback. Updating FATE tests is a bridge too far for me. I > can't even build FFmpeg itself at the moment, say nothing about > setting up the test environment and finding out how it works. Could > you please do this update for

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-06-22 Thread Zivkovic, Milos
Hello, I've attached another patch with the latest changes. Sorry for sending it as an attachment again, I'll figure something out for the future patches. Anyhow, this patch removes the reordering and the unused HANC constant. It also checks if PSC is in order and renames the option to "enable_kl

Re: [FFmpeg-devel] [Patch] vf_edgedetect: properly implement double_threshold()

2020-06-22 Thread Valery Kot
On Mon, Jun 22, 2020 at 12:54 PM Moritz Barsnick wrote: > > On Fri, Jun 19, 2020 at 17:15:06 +0200, Valery Kot wrote: > > -if ((!i || i == w - 1 || !j || j == h - 1) && > > +if (!(!i || i == w - 1 || !j || j == h - 1) && > > NOT of a logical OR can be inverted, so this *may

Re: [FFmpeg-devel] [Patch] vf_edgedetect: properly implement double_threshold()

2020-06-22 Thread Valery Kot
On Mon, Jun 22, 2020 at 12:57 PM Moritz Barsnick wrote: > > On Mon, Jun 22, 2020 at 09:58:42 +0200, Valery Kot wrote: > > Thanks for feedback. Updating FATE tests is a bridge too far for me. I > > can't even build FFmpeg itself at the moment, say nothing about > > setting up the test environment a

Re: [FFmpeg-devel] [PATCH 1/4 v2] avutil/buffer: change public function and struct size parameter types to size_t

2020-06-22 Thread James Almer
On 6/22/2020 6:18 AM, Anton Khirnov wrote: > Quoting James Almer (2020-06-01 19:25:36) >> Signed-off-by: James Almer >> --- >> No changes since v1. >> >> doc/APIchanges | 4 >> libavutil/buffer.c | 25 + >> libavutil/buffer.h | 31 +

Re: [FFmpeg-devel] [PATCH] avfilter: add nonlinearstretch filter.

2020-06-22 Thread Paul B Mahol
On 6/22/20, Mathias Rasmussen wrote: > --- > Hi there! First time contributor here. > > I've made a filter for performing nonlinear stretching of videos, > also known as dynamic stretch and similar to GoPro's SuperView. > I really doubt that this filter have anything to do with GoPro's SuperView.

[FFmpeg-devel] [PATCH v2 0/4] Supplement AVS3-P2/IEEE1857.10 video decoding via libuavs3d

2020-06-22 Thread hwrenx
From: hwren === Version1 === These patches are to supplement the third generation of Audio Video Coding Standard, part 2: video (AVS3-P2), aka IEEE1857.10, decoding support via libuavs3d wrapper. The uAVS3d decoder could be found in https://github.com/uavs3/uavs3d AVS3 sample streams could be

[FFmpeg-devel] [PATCH v2 2/4] lavc/avs3_paeser: add avs3 parser

2020-06-22 Thread hwrenx
From: hwren Signed-off-by: hbj Signed-off-by: hwren --- libavcodec/Makefile | 1 + libavcodec/avs3_parser.c | 184 +++ libavcodec/parsers.c | 1 + 3 files changed, 186 insertions(+) create mode 100644 libavcodec/avs3_parser.c diff --git a/liba

[FFmpeg-devel] [PATCH v2 3/4] lavf/avs3dec: add raw avs3 demuxer

2020-06-22 Thread hwrenx
From: hwren Signed-off-by: hbj Signed-off-by: hwren --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/avs3dec.c| 75 3 files changed, 77 insertions(+) create mode 100644 libavformat/avs3dec.c diff --git a/libavforma

[FFmpeg-devel] [PATCH v2 1/4] lavc: add AVS3 codec id and desc

2020-06-22 Thread hwrenx
From: hwren Signed-off-by: hbj Signed-off-by: hwren --- libavcodec/codec_desc.c | 7 +++ libavcodec/codec_id.h | 1 + 2 files changed, 8 insertions(+) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index 9f8847544f..ad55d992d3 100644 --- a/libavcodec/codec_desc.c +++ b/l

[FFmpeg-devel] [PATCH v2 4/4] lavc, doc: add libuavs3d video decoder wrapper

2020-06-22 Thread hwrenx
From: hwren Signed-off-by: hbj Signed-off-by: hwren --- Changelog | 1 + configure | 4 + doc/decoders.texi | 21 +++ doc/general.texi | 8 ++ libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/libuavs3d.c | 283 ++

Re: [FFmpeg-devel] Support for dumping pgx for JPEG2000

2020-06-22 Thread Carl Eugen Hoyos
> Am 22.06.2020 um 12:42 schrieb Moritz Barsnick : > >> On Mon, Jun 22, 2020 at 12:47:11 +0530, Gautam Ramakrishnan wrote: >> On Mon, Jun 22, 2020 at 12:38 PM Carl Eugen Hoyos wrote: Am 22.06.2020 um 07:32 schrieb Gautam Ramakrishnan : JPEG2000 uses .pgx format for conformance testing

Re: [FFmpeg-devel] [Patch] vf_edgedetect: properly implement double_threshold()

2020-06-22 Thread Andriy Gelman
On Mon, 22. Jun 09:58, Valery Kot wrote: > On Mon, Jun 22, 2020 at 7:58 AM Andriy Gelman wrote: > > > > Hi Valery, > > > > Thanks for the patch. > > > > Please also update the fate test: > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/cagtf1mncx2joo-vmtucdkjcp76y5jslnhubzat4mf48c2hf...@mail.

Re: [FFmpeg-devel] [PATCH] avfilter: add nonlinearstretch filter.

2020-06-22 Thread Mathias Rasmussen
On 22 Jun 2020, at 15.57, Paul B Mahol wrote: > > I really doubt that this filter have anything to do with GoPro's SuperView. > GoPro's SuperView, unlike this filter, extends FOV of currently > recording video with real data. Please see https://community.gopro.com/t5/en/What-is-SuperView/ta-p/39

[FFmpeg-devel] [PATCH 2/6] avformat/ftp: check return value of av_bprint_finalize()

2020-06-22 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/ftp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/ftp.c b/libavformat/ftp.c index caeea42..39ea297 100644 --- a/libavformat/ftp.c +++ b/libavformat/ftp.c @@ -200,7 +200,7 @@ static int ftp_status(FTPC

[FFmpeg-devel] [PATCH 6/6] avformat/hlsenc: fix av_bprint_finalize() usage

2020-06-22 Thread lance . lmwang
From: Limin Wang Don't need to do double check by the description of the API. Signed-off-by: Limin Wang --- libavformat/hlsenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index f7a4f30..a34da2f 100644 --- a/libavformat/h

[FFmpeg-devel] [PATCH v2] avfilter/vf_edgedetect: properly implement double_threshold()

2020-06-22 Thread Valery Kot
=== Version 1 === vf_edgedetect video filter implements Canny algorithm (https://en.wikipedia.org/wiki/Canny_edge_detector) Important part of this algo is the double threshold step: pixels above "high" threshold being kept, pixels below "low" threshold dropped, pixels in between kept if they are a

[FFmpeg-devel] [PATCH 3/6] avformat/au: check return value of av_bprint_finalize()

2020-06-22 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/au.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/au.c b/libavformat/au.c index 4afee85..ff9176a 100644 --- a/libavformat/au.c +++ b/libavformat/au.c @@ -81,7 +81,7 @@ static int au_read_annotati

Re: [FFmpeg-devel] [PATCH] avfilter: add nonlinearstretch filter.

2020-06-22 Thread Mathias Rasmussen
On Mon, Jun 22, 2020 at 3:57 PM Paul B Mahol wrote: > I really doubt that this filter have anything to do with GoPro's SuperView. > GoPro's SuperView, unlike this filter, extends FOV of currently > recording video with real data. Please see https://community.gopro.com/t5/en/What-is-SuperView/ta

[FFmpeg-devel] [PATCH 4/6] avformat/au: check return value of au_read_annotation()

2020-06-22 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/au.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/au.c b/libavformat/au.c index ff9176a..b6df63e 100644 --- a/libavformat/au.c +++ b/libavformat/au.c @@ -145,6 +145,7 @@ static int au_read_header(AV

[FFmpeg-devel] [PATCH 1/6] avutil/opt: check return value of av_bprint_finalize()

2020-06-22 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavutil/opt.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 2c3f998..552985e 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -2120,6 +2120,9 @@ int av_opt_serialize(void *obj

Re: [FFmpeg-devel] [Patch] vf_edgedetect: properly implement double_threshold()

2020-06-22 Thread Valery Kot
On Mon, Jun 22, 2020 at 4:56 PM Andriy Gelman wrote: > It should be enough to change the hashes in two files. > Please resend with these changes. > > diff --git a/tests/ref/fate/filter-edgedetect > b/tests/ref/fate/filter-edgedetect > index 23c9953e61..e49639afac 100644 > --- a/tests/ref/fate/fil

[FFmpeg-devel] [PATCH 5/6] avformat/hlsenc: use proper error codes

2020-06-22 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/hlsenc.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 71fa3db..f7a4f30 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -370,6 +370,7

Re: [FFmpeg-devel] [PATCH] avfilter: add nonlinearstretch filter.

2020-06-22 Thread Paul B Mahol
On 6/22/20, Mathias Rasmussen wrote: > On 22 Jun 2020, at 15.57, Paul B Mahol wrote: >> >> I really doubt that this filter have anything to do with GoPro's >> SuperView. >> GoPro's SuperView, unlike this filter, extends FOV of currently >> recording video with real data. > > Please see https://co

Re: [FFmpeg-devel] Support for dumping pgx for JPEG2000

2020-06-22 Thread Gautam Ramakrishnan
On Mon, Jun 22, 2020 at 8:07 PM Carl Eugen Hoyos wrote: > > > > > Am 22.06.2020 um 12:42 schrieb Moritz Barsnick : > > > >> On Mon, Jun 22, 2020 at 12:47:11 +0530, Gautam Ramakrishnan wrote: > >> On Mon, Jun 22, 2020 at 12:38 PM Carl Eugen Hoyos > >> wrote: > Am 22.06.2020 um 07:32 schrieb

Re: [FFmpeg-devel] Support for dumping pgx for JPEG2000

2020-06-22 Thread Carl Eugen Hoyos
Am Mo., 22. Juni 2020 um 19:40 Uhr schrieb Gautam Ramakrishnan : > > On Mon, Jun 22, 2020 at 8:07 PM Carl Eugen Hoyos wrote: > > > > > > > > > Am 22.06.2020 um 12:42 schrieb Moritz Barsnick : > > > > > >> On Mon, Jun 22, 2020 at 12:47:11 +0530, Gautam Ramakrishnan wrote: > > >> On Mon, Jun 22, 202

Re: [FFmpeg-devel] Support for dumping pgx for JPEG2000

2020-06-22 Thread Gautam Ramakrishnan
On Mon, Jun 22, 2020 at 11:30 PM Carl Eugen Hoyos wrote: > > Am Mo., 22. Juni 2020 um 19:40 Uhr schrieb Gautam Ramakrishnan > : > > > > On Mon, Jun 22, 2020 at 8:07 PM Carl Eugen Hoyos wrote: > > > > > > > > > > > > > Am 22.06.2020 um 12:42 schrieb Moritz Barsnick : > > > > > > > >> On Mon, Jun 2

Re: [FFmpeg-devel] [PATCH] avfilter: add nonlinearstretch filter.

2020-06-22 Thread Mathias Rasmussen
On Mon, Jun 22, 2020 at 6:35 PM Paul B Mahol wrote: > I simply looked at youtube videos and images, as I never trust their > documentation. > Okay, but that's what I meant by SuperView. It's difficult to discuss beyond what is documented. The filter is not for public. > In that case, I would s

Re: [FFmpeg-devel] Support for dumping pgx for JPEG2000

2020-06-22 Thread Gautam Ramakrishnan
On Mon, Jun 22, 2020 at 11:37 PM Gautam Ramakrishnan wrote: > > On Mon, Jun 22, 2020 at 11:30 PM Carl Eugen Hoyos wrote: > > > > Am Mo., 22. Juni 2020 um 19:40 Uhr schrieb Gautam Ramakrishnan > > : > > > > > > On Mon, Jun 22, 2020 at 8:07 PM Carl Eugen Hoyos > > > wrote: > > > > > > > > > > > >

Re: [FFmpeg-devel] [RFC PATCH] libavcodec/jpeg2000: Make corrections jpeg2000 decoder

2020-06-22 Thread Michael Niedermayer
On Sun, Jun 21, 2020 at 10:55:24PM +0530, Gautam Ramakrishnan wrote: > On Sat, Jun 20, 2020 at 9:48 AM Gautam Ramakrishnan > wrote: > > > > On Sat, Jun 20, 2020 at 1:29 AM Michael Niedermayer > > wrote: > > > > > > On Thu, Jun 18, 2020 at 11:55:20PM +0530, gautamr...@gmail.com wrote: > > > > From

Re: [FFmpeg-devel] [PATCH] avfilter: add nonlinearstretch filter.

2020-06-22 Thread Michael Niedermayer
On Mon, Jun 22, 2020 at 12:47:30AM +0200, Mathias Rasmussen wrote: > --- > Hi there! First time contributor here. > > I've made a filter for performing nonlinear stretching of videos, > also known as dynamic stretch and similar to GoPro's SuperView. > > I left some questions as TODO's in the code

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/jpeg2000dec.c: Remove log2_chroma check in pixel format selection

2020-06-22 Thread Michael Niedermayer
On Mon, Jun 22, 2020 at 12:14:39AM +0530, Gautam Ramakrishnan wrote: > On Mon, Jun 22, 2020 at 12:12 AM wrote: > > > > From: Gautam Ramakrishnan > > > > The log2_chroma_wh is derived from the sample separations of the > > codestream if the file is a j2k codestream. Not sure if sample > > separati

Re: [FFmpeg-devel] [PATCH] avfilter: add nonlinearstretch filter.

2020-06-22 Thread Mathias Rasmussen
On Mon, Jun 22, 2020 at 10:35 PM Michael Niedermayer wrote: > the test does not succeed, maybe you forgot to include the ref file in the > patch > Yes, you are correct, is it supposed to be an empty file? I'm not sure my test case really works though, is there a way to see the results of the tes

Re: [FFmpeg-devel] [PATCH 2/6] avformat/ftp: check return value of av_bprint_finalize()

2020-06-22 Thread Marton Balint
On Mon, 22 Jun 2020, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/ftp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/ftp.c b/libavformat/ftp.c index caeea42..39ea297 100644 --- a/libavformat/ftp.c +++ b/libavforma

Re: [FFmpeg-devel] [PATCH 4/6] avformat/au: check return value of au_read_annotation()

2020-06-22 Thread Marton Balint
On Mon, 22 Jun 2020, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/au.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/au.c b/libavformat/au.c index ff9176a..b6df63e 100644 --- a/libavformat/au.c +++ b/libavformat

Re: [FFmpeg-devel] [PATCH 4/5] libavcodec/jpeg2000dec.c: Enable image offsets

2020-06-22 Thread Michael Niedermayer
On Mon, Jun 22, 2020 at 12:12:07AM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This patch enables support for image offsets. > --- > libavcodec/jpeg2000dec.c | 4 > 1 file changed, 4 deletions(-) Is there a testcase for this ? (a file using this) [...] -- Michael

Re: [FFmpeg-devel] [PATCH 3/5] libavcodec/jpeg2000dec.c Fixed WRITE_FRAME and tile co-ordinates:

2020-06-22 Thread Michael Niedermayer
On Mon, Jun 22, 2020 at 12:12:06AM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > libopenjpeg2000 uses ceiling division while dividing tile > co-ordinates with the sample separation. Also, corrections > were made to the WRITE_FRAME macro. > --- > libavcodec/jpeg2000dec.c | 24

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/jpeg2000dec.c: Remove log2_chroma check in pixel format selection

2020-06-22 Thread Carl Eugen Hoyos
Am Mo., 22. Juni 2020 um 04:57 Uhr schrieb Gautam Ramakrishnan : > > On Mon, Jun 22, 2020 at 1:54 AM Carl Eugen Hoyos wrote: > > > > Am So., 21. Juni 2020 um 21:11 Uhr schrieb : > > > > > > From: Gautam Ramakrishnan > > > > > > The log2_chroma_wh is derived from the sample separations of the > >

Re: [FFmpeg-devel] [PATCH 4/5] libavcodec/jpeg2000dec.c: Enable image offsets

2020-06-22 Thread Carl Eugen Hoyos
Am Mo., 22. Juni 2020 um 23:16 Uhr schrieb Michael Niedermayer : > > On Mon, Jun 22, 2020 at 12:12:07AM +0530, gautamr...@gmail.com wrote: > > From: Gautam Ramakrishnan > > > > This patch enables support for image offsets. > > --- > > libavcodec/jpeg2000dec.c | 4 > > 1 file changed, 4 delet

Re: [FFmpeg-devel] [PATCH 2/5] libavcodec/jpeg2000dec.c: Modify image dimensions

2020-06-22 Thread Michael Niedermayer
On Mon, Jun 22, 2020 at 12:12:05AM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > Reduce image size of the image if all components have > a non zero sample separation. This is to replicate the > output of opj_decompress. > --- > libavcodec/jpeg2000dec.c | 19 ++---

Re: [FFmpeg-devel] [PATCH 2/5] libavcodec/jpeg2000dec.c: Modify image dimensions

2020-06-22 Thread Carl Eugen Hoyos
Am Mo., 22. Juni 2020 um 23:32 Uhr schrieb Michael Niedermayer : > > On Mon, Jun 22, 2020 at 12:12:05AM +0530, gautamr...@gmail.com wrote: > > From: Gautam Ramakrishnan > > > > Reduce image size of the image if all components have > > a non zero sample separation. This is to replicate the > > outp

Re: [FFmpeg-devel] Support for dumping pgx for JPEG2000

2020-06-22 Thread Carl Eugen Hoyos
Am Mo., 22. Juni 2020 um 20:08 Uhr schrieb Gautam Ramakrishnan : > > On Mon, Jun 22, 2020 at 11:30 PM Carl Eugen Hoyos wrote: > > > > Am Mo., 22. Juni 2020 um 19:40 Uhr schrieb Gautam Ramakrishnan > > : > > > > > > On Mon, Jun 22, 2020 at 8:07 PM Carl Eugen Hoyos > > > wrote: > > > > > > > > > >

Re: [FFmpeg-devel] Support for dumping pgx for JPEG2000

2020-06-22 Thread Carl Eugen Hoyos
Am Mo., 22. Juni 2020 um 20:44 Uhr schrieb Gautam Ramakrishnan : > Another issue is that as the .pgx format is tightly linked to JPEG2000, > how could the format be restricted to conversions between j2k and jp2 > files only? For the sake of this discussion, pgx has absolutely nothing to do with j

[FFmpeg-devel] [PATCH] lavc/hevc: set correct chroma location

2020-06-22 Thread Steinar H. Gunderson
HEVC is left chroma like H.264, so add the proper location on init. Signed-off-by: Steinar H. Gunderson --- libavcodec/hevcdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index c9e28f5826..3306cf3702 100644 --- a/libavcodec/hevcdec.c +++ b/

Re: [FFmpeg-devel] [PATCH] lavc/hevc: set correct chroma location

2020-06-22 Thread Hendrik Leppkes
On Tue, Jun 23, 2020 at 12:02 AM Steinar H. Gunderson wrote: > > HEVC is left chroma like H.264, so add the proper location on init. > > Signed-off-by: Steinar H. Gunderson > --- > libavcodec/hevcdec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/hevcdec.c b/libavcodec/h

Re: [FFmpeg-devel] [PATCH 4/6] avformat/au: check return value of au_read_annotation()

2020-06-22 Thread lance . lmwang
On Mon, Jun 22, 2020 at 11:15:12PM +0200, Marton Balint wrote: > > > On Mon, 22 Jun 2020, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/au.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/libav

Re: [FFmpeg-devel] [PATCH 2/6] avformat/ftp: check return value of av_bprint_finalize()

2020-06-22 Thread lance . lmwang
On Mon, Jun 22, 2020 at 11:08:23PM +0200, Marton Balint wrote: > > > On Mon, 22 Jun 2020, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/ftp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavfo

[FFmpeg-devel] [PATCH v2 3/5] avformat/au: check return value of au_read_annotation()

2020-06-22 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/au.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/au.c b/libavformat/au.c index ff9176a..f92863e 100644 --- a/libavformat/au.c +++ b/libavformat/au.c @@ -145,6 +145,7 @@ static int au_read_header(A

[FFmpeg-devel] [PATCH 1/2] avformat/mvdec: Fix integer overflow with billions of channels

2020-06-22 Thread Michael Niedermayer
Fixes: signed integer overflow: 1394614304 * 2 cannot be represented in type 'int' Fixes: 23491/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5697377020411904 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nieder

[FFmpeg-devel] [PATCH 2/2] avformat/subtitles: Check for NOPTS in ff_subtitles_queue_finalize()

2020-06-22 Thread Michael Niedermayer
Fixes; signed integer overflow: 1 - -9223372036854775808 cannot be represented in type 'long' Fixes: 23490/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5133490093031424 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mic

[FFmpeg-devel] [PATCH] avcodec/cbs_h265: set default VUI parameters when vui_parameters_present_flag is false

2020-06-22 Thread James Almer
Based on cbs_h264 code. Should fix ticket #8752. Signed-off-by: James Almer --- libavcodec/cbs_h265_syntax_template.c | 28 +++ 1 file changed, 28 insertions(+) diff --git a/libavcodec/cbs_h265_syntax_template.c b/libavcodec/cbs_h265_syntax_template.c index 5b7d1aa837.

Re: [FFmpeg-devel] [PATCH 3/5] libavcodec/jpeg2000dec.c Fixed WRITE_FRAME and tile co-ordinates:

2020-06-22 Thread Gautam Ramakrishnan
On Tue, Jun 23, 2020 at 2:48 AM Michael Niedermayer wrote: > > On Mon, Jun 22, 2020 at 12:12:06AM +0530, gautamr...@gmail.com wrote: > > From: Gautam Ramakrishnan > > > > libopenjpeg2000 uses ceiling division while dividing tile > > co-ordinates with the sample separation. Also, corrections > > w

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/jpeg2000dec.c: Remove log2_chroma check in pixel format selection

2020-06-22 Thread Gautam Ramakrishnan
On Tue, Jun 23, 2020 at 2:55 AM Carl Eugen Hoyos wrote: > > Am Mo., 22. Juni 2020 um 04:57 Uhr schrieb Gautam Ramakrishnan > : > > > > On Mon, Jun 22, 2020 at 1:54 AM Carl Eugen Hoyos wrote: > > > > > > Am So., 21. Juni 2020 um 21:11 Uhr schrieb : > > > > > > > > From: Gautam Ramakrishnan > > >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mvdec: Fix integer overflow with billions of channels

2020-06-22 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: signed integer overflow: 1394614304 * 2 cannot be represented in type > 'int' > Fixes: > 23491/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5697377020411904 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/f

[FFmpeg-devel] [PATCH v2] avformat/smoothstreaming: Don't write trailer of subcontext

2020-06-22 Thread Andreas Rheinhardt
Nothing written in avformat_write_trailer() for the submuxers will be output anyway because the AVIOContexts used for actual output have been closed before the call. Writing the trailer of the subcontext has probably only been done in order to free the memory allocated by the submuxer. And this job

Re: [FFmpeg-devel] [PATCH 04/17] avformat/smoothstreaming: Forward errors from copying white/blacklists

2020-06-22 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/smoothstreamingenc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavformat/smoothstreamingenc.c > b/libavformat/smoothstreamingenc.c > index 0e4f531f90..a5fd8a18db 100644 > --- a/libavf