[FFmpeg-devel] [PATCH 1/5] avcodec/iff: Fix off by x error

2020-06-13 Thread Michael Niedermayer
Fixes: out of array access Fixes: 23245/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5723121327013888.fuzz Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/iff.c | 2 +- 1

[FFmpeg-devel] [PATCH 2/5] avformat/ape: Cleanup after ape_read_header() failure

2020-06-13 Thread Michael Niedermayer
Fixes: memleaks Fixes: 23306/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5635436931448832 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/ape.c | 26 +++--- 1 fil

[FFmpeg-devel] [PATCH 3/5] avcodec/pixlet: Fix log(0) check

2020-06-13 Thread Michael Niedermayer
Fixes: passing zero to clz(), which is not a valid argument Fixes: 23337/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PIXLET_fuzzer-5179131989065728 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- l

[FFmpeg-devel] [PATCH 5/5] avformat/oggdec: Disable mid stream codec changes

2020-06-13 Thread Michael Niedermayer
The code crashes and neither the authors nor anyone else did fix this We cannot release code which crashes, so if noone fixes it, the only option left is to disable or revert. Revert is difficult as there are multiple commits afterwards Fixes: 22082/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_f

[FFmpeg-devel] [PATCH 4/5] avcodec/mpeg4videodec: avoid invalid values and reinitialize in format changes for studio profile

2020-06-13 Thread Michael Niedermayer
Fixes: out of array access Fixes: 23327/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-5134822992510976 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mpeg4videodec.c | 19 +++

Re: [FFmpeg-devel] [PATCH 5/5] avformat/oggdec: Disable mid stream codec changes

2020-06-13 Thread Paul B Mahol
On 6/13/20, Michael Niedermayer wrote: > The code crashes and neither the authors nor anyone else did fix this > We cannot release code which crashes, so if noone fixes it, the only > option left is to disable or revert. Revert is difficult as there are > multiple commits afterwards > > Fixes: > 2

Re: [FFmpeg-devel] [PATCH] OS/2:Support linking against libcx

2020-06-13 Thread KO Myung-Hun
Hi/2. Dave Yeo wrote: > On 06/11/20 10:26 AM, Michael Niedermayer wrote: >> On Wed, Jun 10, 2020 at 09:24:51PM -0700, Dave Yeo wrote: >>> On 06/10/20 02:09 PM, Michael Niedermayer wrote: On Tue, Jun 09, 2020 at 11:11:48PM -0700, Dave Yeo wrote: > Hi, could I get this pushed to trunk and t

Re: [FFmpeg-devel] [PATCH v12 3/4] avfilter/vf_showinfo: display H.26[45] user data unregistered sei message

2020-06-13 Thread lance . lmwang
On Thu, Jun 11, 2020 at 06:35:15PM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/vf_showinfo.c | 37 + > > 1 file changed, 37 insertions(+) > > > > diff --git a/libav

Re: [FFmpeg-devel] [PATCH 5/5] avformat/oggdec: Disable mid stream codec changes

2020-06-13 Thread James Almer
On 6/13/2020 9:12 AM, Lynne wrote: > Jun 13, 2020, 12:23 by mich...@niedermayer.cc: > >> The code crashes and neither the authors nor anyone else did fix this >> We cannot release code which crashes, so if noone fixes it, the only >> option left is to disable or revert. Revert is difficult as ther

[FFmpeg-devel] [PATCH 1/2] fix the bug that AV_PKT_FLAG_CORRUPT flags lost after parse_packet()

2020-06-13 Thread levizhao
From: zhaoyi --- libavformat/utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index 667249362c..a74c0f74a2 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -1516,6 +1516,7 @@ static int parse_packet(AVFormatContext *s, AVPacket *p

Re: [FFmpeg-devel] [PATCH v3 0/7] adpcm_ima_apm encoder + apm muxer

2020-06-13 Thread Zane van Iperen
On Fri, 12 Jun 2020 11:46:08 + "Zane van Iperen" wrote: > > Add support for encoding adpcm_ima_apm and muxing to apm. > > If possible, I would like to get this functionality into the 4.3 > release. > Ping. Zane ___ ffmpeg-devel mailing list ffm

[FFmpeg-devel] [PATCH 3/4] avcodec/mpegvideo: remove extra space

2020-06-13 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/mpegvideo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index 52a0ec3..c28d1ad 100644 --- a/libavcodec/mpegvideo.c +++ b/libavcodec/mpegvideo.c @@ -1112,7 +1112,7 @@

[FFmpeg-devel] [PATCH 1/4] swscale/utils: reindent

2020-06-13 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libswscale/utils.c | 71 +++--- 1 file changed, 36 insertions(+), 35 deletions(-) diff --git a/libswscale/utils.c b/libswscale/utils.c index ff99e79..6e218ba 100644 --- a/libswscale/utils.c +++ b/lib

[FFmpeg-devel] [PATCH 2/4] swscale/utils: return better error code from initFilter()

2020-06-13 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libswscale/utils.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/libswscale/utils.c b/libswscale/utils.c index 6e218ba..dcd1dba 100644 --- a/libswscale/utils.c +++ b/libswscale/utils.c @@ -612,7 +

[FFmpeg-devel] [PATCH 4/4] avcodec/smvjpegdec: remove uninitialized ret

2020-06-13 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/smvjpegdec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/smvjpegdec.c b/libavcodec/smvjpegdec.c index 209f3ff..973a911 100644 --- a/libavcodec/smvjpegdec.c +++ b/libavcodec/smvjpegdec.c @@ -79,13 +79,

[FFmpeg-devel] [PATCH 4/4] avcodec/smvjpegdec: remove uninitialized ret

2020-06-13 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/smvjpegdec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/smvjpegdec.c b/libavcodec/smvjpegdec.c index 209f3ff..973a911 100644 --- a/libavcodec/smvjpegdec.c +++ b/libavcodec/smvjpegdec.c @@ -79,13 +79,

[FFmpeg-devel] [PATCH 2/4] swscale/utils: return better error code from initFilter()

2020-06-13 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libswscale/utils.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/libswscale/utils.c b/libswscale/utils.c index 6e218ba..dcd1dba 100644 --- a/libswscale/utils.c +++ b/libswscale/utils.c @@ -612,7 +

[FFmpeg-devel] [PATCH 2/2] add socks5 support for tcp clients

2020-06-13 Thread levizhao
From: zhaoyi --- libavformat/tcp.c | 204 ++ 1 file changed, 204 insertions(+) diff --git a/libavformat/tcp.c b/libavformat/tcp.c index 2198e0f00e..ca6ba2867e 100644 --- a/libavformat/tcp.c +++ b/libavformat/tcp.c @@ -45,6 +45,7 @@ typedef struct TCPC

[FFmpeg-devel] [PATCH 1/4] swscale/utils: reindent

2020-06-13 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libswscale/utils.c | 71 +++--- 1 file changed, 36 insertions(+), 35 deletions(-) diff --git a/libswscale/utils.c b/libswscale/utils.c index ff99e79..6e218ba 100644 --- a/libswscale/utils.c +++ b/lib

[FFmpeg-devel] MPEG-2 FLAGS2_FAST benchmarks

2020-06-13 Thread Kieran Kunhya
Hello, I have run the following commands on the following CPU which is 7 years old: Intel(R) Xeon(R) CPU E3-1265L v3 ffmpeg_g -i matrixbench_mpeg2.mpg -f null - and ffmpeg_g -flags2 fast -i matrixbench_mpeg2.mpg -f null - Here are the results: Normal Fast 2202 2168 2155 2057 2210 2128 2104 2051

Re: [FFmpeg-devel] [PATCH 5/5] avformat/oggdec: Disable mid stream codec changes

2020-06-13 Thread Lynne
Jun 13, 2020, 12:23 by mich...@niedermayer.cc: > The code crashes and neither the authors nor anyone else did fix this > We cannot release code which crashes, so if noone fixes it, the only > option left is to disable or revert. Revert is difficult as there are > multiple commits afterwards > You

Re: [FFmpeg-devel] MPEG-2 FLAGS2_FAST benchmarks

2020-06-13 Thread Derek Buitenhuis
On 13/06/2020 17:11, Kieran Kunhya wrote: > It can therefore be shown that the difference is statistically > insignificant. I really think the onus of proving FAST is useful should be on the people who claim it is useful - something I haven't seen any evidence for. - Derek ___

[FFmpeg-devel] [PATCH] avformat: add MCC demuxer

2020-06-13 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/mccdec.c | 217 +++ 3 files changed, 219 insertions(+) create mode 100644 libavformat/mccdec.c diff --git a/libavformat/Makefile b/libavformat/

Re: [FFmpeg-devel] [PATCH] avformat: add MCC demuxer

2020-06-13 Thread Kieran Kunhya
> > +if (av_sscanf(line, "%d:%d:%d:%d", &hh, &mm, &ss, &fs) != 4) > +continue; > Maybe worth a comment saying you're converting a timecode to a PTS here. These are often not the same. Kieran ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] fix the bug that AV_PKT_FLAG_CORRUPT flags lost after parse_packet()

2020-06-13 Thread Andreas Rheinhardt
leviz...@live.cn: > From: zhaoyi > > --- > libavformat/utils.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/utils.c b/libavformat/utils.c > index 667249362c..a74c0f74a2 100644 > --- a/libavformat/utils.c > +++ b/libavformat/utils.c > @@ -1516,6 +1516,7 @@ static int pars

[FFmpeg-devel] [PATCH 2/2] avcodec/mv30: check mode_size vs. input space

2020-06-13 Thread Michael Niedermayer
Fixes: Timeout (longer than my patience vs 1sec) Fixes: 22984/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MV30_fuzzer-5630021988515840 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mv3

[FFmpeg-devel] [PATCH 1/2] avcodec/ffwavesynth: Avoid undefined operation on ts overflow

2020-06-13 Thread Michael Niedermayer
Alternatively these conditions could be treated as errors Fixes: 23147/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5639254549200896 Fixes: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'int64_t' (aka 'long') Found-by: continuous fuzzing p

Re: [FFmpeg-devel] [PATCH] avformat: add MCC demuxer

2020-06-13 Thread Lou Logan
On Sat, Jun 13, 2020, at 9:49 AM, Paul B Mahol wrote: [...] > +static int mcc_read_header(AVFormatContext *s) > +{ > +MCCContext *mcc = s->priv_data; > +AVStream *st = avformat_new_stream(s, NULL); > +AVRational rate; > +int64_t ts, pos; > +ptrdiff_t len; ‘len’ set but not used

[FFmpeg-devel] [PATCH] avformat/icecast: Add option to use TLS connection

2020-06-13 Thread Marvin Scholz
--- doc/protocols.texi| 3 +++ libavformat/icecast.c | 7 ++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 7aa758541c..32c829d2a3 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -520,6 +520,9 @@ audio/mpeg. This en

Re: [FFmpeg-devel] [PATCH] avformat/icecast: Add option to use TLS connection

2020-06-13 Thread Andreas Rheinhardt
Marvin Scholz: > --- > doc/protocols.texi| 3 +++ > libavformat/icecast.c | 7 ++- > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/doc/protocols.texi b/doc/protocols.texi > index 7aa758541c..32c829d2a3 100644 > --- a/doc/protocols.texi > +++ b/doc/protocols.texi > @@ -5

[FFmpeg-devel] [PATCH v2] avformat/icecast: Add option to use TLS connection

2020-06-13 Thread Marvin Scholz
--- doc/protocols.texi| 3 +++ libavformat/icecast.c | 8 +++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 7aa758541c..32c829d2a3 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -520,6 +520,9 @@ audio/mpeg. This

Re: [FFmpeg-devel] [PATCH] avformat: add MCC demuxer

2020-06-13 Thread Carl Eugen Hoyos
Am Sa., 13. Juni 2020 um 19:56 Uhr schrieb Paul B Mahol : [...] Please mention ticket #7680. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email f

Re: [FFmpeg-devel] [PATCH v2] avformat/icecast: Add option to use TLS connection

2020-06-13 Thread Carl Eugen Hoyos
Am So., 14. Juni 2020 um 00:32 Uhr schrieb Marvin Scholz : > +// Check which underlying protocol should be used > +real_proto = (s->tls) ? "https" : "http"; Both comment and parentheses are useless. Carl Eugen ___ ffmpeg-devel mailing list ffmp

Re: [FFmpeg-devel] MPEG-2 FLAGS2_FAST benchmarks

2020-06-13 Thread Michael Niedermayer
On Sat, Jun 13, 2020 at 05:11:05PM +0100, Kieran Kunhya wrote: > Hello, > > I have run the following commands on the following CPU which is 7 years old: > Intel(R) Xeon(R) CPU E3-1265L v3 > > ffmpeg_g -i matrixbench_mpeg2.mpg -f null - > and > ffmpeg_g -flags2 fast -i matrixbench_mpeg2.mpg -f nul

[FFmpeg-devel] [PATCH v3] avformat/icecast: Add option to use TLS connection

2020-06-13 Thread Marvin Scholz
--- doc/protocols.texi| 3 +++ libavformat/icecast.c | 6 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 7aa758541c..32c829d2a3 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -520,6 +520,9 @@ audio/mpeg. This ena

Re: [FFmpeg-devel] [PATCH 5/5] avformat/oggdec: Disable mid stream codec changes

2020-06-13 Thread Michael Niedermayer
On Sat, Jun 13, 2020 at 02:12:55PM +0200, Lynne wrote: > Jun 13, 2020, 12:23 by mich...@niedermayer.cc: > > > The code crashes and neither the authors nor anyone else did fix this > > We cannot release code which crashes, so if noone fixes it, the only > > option left is to disable or revert. Reve

Re: [FFmpeg-devel] [PATCH] avformat/icecast: Add option to use TLS connection

2020-06-13 Thread Marvin Scholz
On 14 Jun 2020, at 0:18, Andreas Rheinhardt wrote: Marvin Scholz: --- doc/protocols.texi| 3 +++ libavformat/icecast.c | 7 ++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 7aa758541c..32c829d2a3 100644 --- a/doc/protocol

Re: [FFmpeg-devel] [PATCH v2] avformat/icecast: Add option to use TLS connection

2020-06-13 Thread Marvin Scholz
On 14 Jun 2020, at 0:36, Carl Eugen Hoyos wrote: Am So., 14. Juni 2020 um 00:32 Uhr schrieb Marvin Scholz : +// Check which underlying protocol should be used +real_proto = (s->tls) ? "https" : "http"; Both comment and parentheses are useless. Sent new version that gets rid of

Re: [FFmpeg-devel] [PATCH 1/4] swscale/utils: reindent

2020-06-13 Thread lance . lmwang
Sorry, please ignore the repeat sending for 1,3,4. I haven't got them for a while so I think something is wrong with client and resend. On Sat, Jun 13, 2020 at 11:05:36PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libswscale/utils.c | 71 >

Re: [FFmpeg-devel] MPEG-2 FLAGS2_FAST benchmarks

2020-06-13 Thread Kieran Kunhya
Hi, > Problem 1 > you have a mean of around 2100 and Stdev of about between 55 and 80 so if > by > statistically significant you man 2 Stdev, then with the mean you have. > You would declare every optimization of less than 6% to be statistically > insignificant. > So by what you say here, it seem

Re: [FFmpeg-devel] [PATCH] OS/2:Support linking against libcx

2020-06-13 Thread Dave Yeo
On 06/13/20 07:03 AM, KO Myung-Hun wrote: Hi/2. Dave Yeo wrote: On 06/11/20 10:26 AM, Michael Niedermayer wrote: On Wed, Jun 10, 2020 at 09:24:51PM -0700, Dave Yeo wrote: On 06/10/20 02:09 PM, Michael Niedermayer wrote: On Tue, Jun 09, 2020 at 11:11:48PM -0700, Dave Yeo wrote: Hi, could I g