Re: [FFmpeg-devel] [PATCH v5 2/3] avdevice/lavfi: support the dumpgraph with options

2020-05-24 Thread Marton Balint
On Sun, 24 May 2020, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- doc/indevs.texi | 15 +-- libavdevice/lavfi.c | 2 +- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/doc/indevs.texi b/doc/indevs.texi index 6f5afaf..7ec7062 100

Re: [FFmpeg-devel] [PATCH v5 2/3] avdevice/lavfi: support the dumpgraph with options

2020-05-24 Thread lance . lmwang
On Sun, May 24, 2020 at 09:47:12AM +0200, Marton Balint wrote: > > > On Sun, 24 May 2020, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > doc/indevs.texi | 15 +-- > > libavdevice/lavfi.c | 2 +- > > 2 files changed, 14 inserti

Re: [FFmpeg-devel] ffmpeg Filtergraph Output

2020-05-24 Thread lance . lmwang
On Sun, May 24, 2020 at 02:43:52AM +, Soft Works wrote: > Hello, > > I've seen the commit about the option for dumping the filtergraph and that > reminded me about something that I'd be willing to contribute in case anybody > likes it. > > A while ago I was looking for a way to get informat

Re: [FFmpeg-devel] ffmpeg Filtergraph Output

2020-05-24 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > lance.lmw...@gmail.com > Sent: Sunday, May 24, 2020 1:24 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] ffmpeg Filtergraph Output > > On Sun, May 24, 2020 at 02:43:52AM +, Soft Works wrote: > > Hello, > > > > I'

[FFmpeg-devel] [PATCH] avfilter/qsvvpp: Work around a bug in MSDK where VPP processing hangs under certain conditions

2020-05-24 Thread Soft Works
These conditions are: - Dimensions are aligned to 16/32 byte (e.g. 1920x800) - No scaling is done - Color format conversion (e.g. 10bit to 8bit) Example command: ffmpeg -c:v hevc_qsv -hwaccel qsv -i hevc_10bit_1920_800.mkv -filter_complex "scale_qsv=format=nv12" -c:v h264_qsv out.mkv Fix: - Incr

Re: [FFmpeg-devel] ffmpeg Filtergraph Output

2020-05-24 Thread Bodecs Bela
2020.05.24. 4:55 keltezéssel, Dennis Mungai írta: On Sun, 24 May 2020 at 05:44, Soft Works wrote: Hello, I've seen the commit about the option for dumping the filtergraph and that reminded me about something that I'd be willing to contribute in case anybody likes it. A while ago I was looki

Re: [FFmpeg-devel] ffmpeg Filtergraph Output

2020-05-24 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Bodecs Bela > Sent: Sunday, May 24, 2020 2:21 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] ffmpeg Filtergraph Output > > > 2020.05.24. 4:55 keltezéssel, Dennis Mungai írta: > > On Sun, 24 May 2020 at 05:44, Soft

Re: [FFmpeg-devel] ffmpeg Filtergraph Output

2020-05-24 Thread lance . lmwang
On Sun, May 24, 2020 at 11:49:28AM +, Soft Works wrote: > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > lance.lmw...@gmail.com > > Sent: Sunday, May 24, 2020 1:24 PM > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] ffmpeg Filtergraph Output > > > > On

Re: [FFmpeg-devel] [PATCH] avfilter/qsvvpp: Work around a bug in MSDK where VPP processing hangs under certain conditions

2020-05-24 Thread Zhong Li
Soft Works 于2020年5月24日周日 下午8:13写道: > > These conditions are: > - Dimensions are aligned to 16/32 byte (e.g. 1920x800) > - No scaling is done > - Color format conversion (e.g. 10bit to 8bit) > > Example command: > ffmpeg -c:v hevc_qsv -hwaccel qsv -i hevc_10bit_1920_800.mkv -filter_complex > "scal

Re: [FFmpeg-devel] [PATCH] avfilter/qsvvpp: Work around a bug in MSDK where VPP processing hangs under certain conditions

2020-05-24 Thread myp...@gmail.com
On Sun, May 24, 2020 at 8:13 PM Soft Works wrote: > > These conditions are: > - Dimensions are aligned to 16/32 byte (e.g. 1920x800) > - No scaling is done > - Color format conversion (e.g. 10bit to 8bit) > > Example command: > ffmpeg -c:v hevc_qsv -hwaccel qsv -i hevc_10bit_1920_800.mkv -filter_c

Re: [FFmpeg-devel] [PATCH] avfilter/qsvvpp: Work around a bug in MSDK where VPP processing hangs under certain conditions

2020-05-24 Thread Soft Works
I'm afraid, I spent enough time on identifying the problem. I won't file a bug after I have provided a fix. But I'll send you a short clip that will allow you to reproduce. Best regards softworkz > -Original Message- > From: ffmpeg-devel On Behalf Of > Zhong Li > Sent: Sunday, May 24,

Re: [FFmpeg-devel] [PATCH] avfilter/qsvvpp: Work around a bug in MSDK where VPP processing hangs under certain conditions

2020-05-24 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > myp...@gmail.com > Sent: Sunday, May 24, 2020 2:29 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] avfilter/qsvvpp: Work around a bug in > MSDK where VPP processing hangs

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/adpcmenc: Add FF_CODEC_CAP_INIT_CLEANUP

2020-05-24 Thread lance . lmwang
On Mon, May 18, 2020 at 07:11:07PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > then we can remove adpcm_encode_close() in adpcm_encode_init() if have failed. > so the goto error lable wlll be unnecessary and can be removed later. > > Signed-off-by: Limin Wang > --- > libavcode

Re: [FFmpeg-devel] [PATCH] avfilter/qsvvpp: Work around a bug in MSDK where VPP processing hangs under certain conditions

2020-05-24 Thread Max Dmitrichenko
On Sun, May 24, 2020 at 2:13 PM Soft Works wrote: > These conditions are: > - Dimensions are aligned to 16/32 byte (e.g. 1920x800) > - No scaling is done > - Color format conversion (e.g. 10bit to 8bit) > > Example command: > ffmpeg -c:v hevc_qsv -hwaccel qsv -i hevc_10bit_1920_800.mkv > -filter_

Re: [FFmpeg-devel] [PATCH] avcodec/frame_thread_encoder: remove usage of avcodec_encode_video2()

2020-05-24 Thread James Almer
On 5/17/2020 11:07 AM, James Almer wrote: > Call the encoder's internal AVCodec.encode2() function instead. > > Signed-off-by: James Almer > --- > libavcodec/encode.c | 20 > libavcodec/frame_thread_encoder.c | 14 -- > 2 files changed, 20 insertion

[FFmpeg-devel] [PATCH 4/4] avfilter/af_biquads: add reverse filtering support

2020-05-24 Thread Paul B Mahol
Add it to all filters, except allpass as it does not make sense to use it in such case. Signed-off-by: Paul B Mahol --- doc/filters.texi | 72 +++ libavfilter/af_biquads.c | 271 +-- 2 files changed, 333 insertions(+), 10 deletions(-) diff --

[FFmpeg-devel] [PATCH 2/4] avfilter/af_biquads: switch to activate()

2020-05-24 Thread Paul B Mahol
Needed by following commits. Signed-off-by: Paul B Mahol --- libavfilter/af_biquads.c | 33 + 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/libavfilter/af_biquads.c b/libavfilter/af_biquads.c index 81cdb0c10e..ef28db741a 100644 --- a/libavfilter/a

[FFmpeg-devel] [PATCH 3/4] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

2020-05-24 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/avfilter.c | 61 +- libavfilter/filters.h | 17 2 files changed, 72 insertions(+), 6 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 394811916d..85010c88fe 100644 ---

[FFmpeg-devel] [PATCH 1/4] avfilter/af_biquads: implement 1st order allpass

2020-05-24 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 3 +++ libavfilter/af_biquads.c | 28 ++-- 2 files changed, 25 insertions(+), 6 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 85a511b205..5af4797b7e 100644 --- a/doc/filters.texi +++ b/doc/f

Re: [FFmpeg-devel] [PATCH] x86: cabac: Disable the inline asm on clang on windows on i386

2020-05-24 Thread Martin Storsjö
On Sun, 24 May 2020, Carl Eugen Hoyos wrote: Am Sa., 23. Mai 2020 um 20:35 Uhr schrieb Martin Storsjö : The cabac inline assembly is very brittle to assemble properly on i386 windows with clang; libavcodec/hevc_cabac.c fails to build in the default mode (which is -march=pentium4), it only work

Re: [FFmpeg-devel] [PATCH] x86: cabac: Disable the inline asm on clang on windows on i386

2020-05-24 Thread Carl Eugen Hoyos
Am So., 24. Mai 2020 um 21:53 Uhr schrieb Martin Storsjö : > configure --enable-gpl --arch=i686 --cc=clang-cl --ld=lld-link > --target-os=win32 --toolchain=msvc --enable-cross-compile --ar=llvm-ar > --nm=llvm-nm --disable-stripping --extra-cflags=-m32 Why are you cross-compiling? On which system

Re: [FFmpeg-devel] [PATCH] avfilter/qsvvpp: Work around a bug in MSDK where VPP processing hangs under certain conditions

2020-05-24 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Max Dmitrichenko > Sent: Sunday, May 24, 2020 4:43 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] avfilter/qsvvpp: Work around a bug in > MSDK where VPP processing hangs u

Re: [FFmpeg-devel] [PATCH] x86: cabac: Disable the inline asm on clang on windows on i386

2020-05-24 Thread Martin Storsjö
On Sun, 24 May 2020, Carl Eugen Hoyos wrote: Am So., 24. Mai 2020 um 21:53 Uhr schrieb Martin Storsjö : configure --enable-gpl --arch=i686 --cc=clang-cl --ld=lld-link --target-os=win32 --toolchain=msvc --enable-cross-compile --ar=llvm-ar --nm=llvm-nm --disable-stripping --extra-cflags=-m32 W

Re: [FFmpeg-devel] [PATCH] avfilter/qsvvpp: Work around a bug in MSDK where VPP processing hangs under certain conditions

2020-05-24 Thread Moritz Barsnick
I don't understand functionally, but: On Sun, May 24, 2020 at 12:13:07 +, Soft Works wrote: > +int height_align_adjust = 0; > int i, ret; > > + > /* check that we have a hw context */ Stray line. > > +in_format = in_frames_ctx->sw_format; > in_format = in_frame

Re: [FFmpeg-devel] [PATCH v6 1/3] avfilter/graphdump: support for the graph2dot function

2020-05-24 Thread Michael Niedermayer
On Sun, May 24, 2020 at 09:04:49AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > reuse the function from tools/graph2dot.c and add support for filter graph > with > graphviz DOT format for avfilter directly. So tools/graph2dot.c is duplicated > and can be removed. > > In addition,

[FFmpeg-devel] [PATCH 1/3] avcodec/mv30: Fix multiple integer overflows in idct_1d()

2020-05-24 Thread Michael Niedermayer
Fixes: signed integer overflow: -4869937 * 473 cannot be represented in type 'int' Fixes: 21934/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MV30_fuzzer-5667289925156864 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Micha

[FFmpeg-devel] [PATCH 3/3] avcodec/vp9dsp_template: Fix integer overflow(s) in iadst16_1d()

2020-05-24 Thread Michael Niedermayer
Fixes: signed integer overflow: 1080285923 - -1130879337 cannot be represented in type 'int' Fixes: 22002/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP9_fuzzer-6260237310099456 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-

[FFmpeg-devel] [PATCH v2] avfilter/qsvvpp: Work around a bug in MSDK where VPP processing hangs under certain conditions

2020-05-24 Thread Soft Works
These are: - Dimensions are already aligned (e.g. 1920x800) - No scaling is done - Color format conversion (e.g. 10bit to 8bit) Example command: ffmpeg -c:v hevc_qsv -hwaccel qsv -i hevc_10bit_1920_800.mkv -filter_complex "scale_qsv=format=nv12" -c:v h264_qsv out.mkv Fix: - Increase the frame he

[FFmpeg-devel] [PATCH 2/3] avcodec/wmalosslessdec: Fix integer overflow in mclms_predict()

2020-05-24 Thread Michael Niedermayer
Fixes: signed integer overflow: 2147483636 + 2048 cannot be represented in type 'int' Fixes: 22016/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-5109395618004992 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off

Re: [FFmpeg-devel] [PATCH] avfilter/qsvvpp: Work around a bug in MSDK where VPP processing hangs under certain conditions

2020-05-24 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Moritz Barsnick > Sent: Monday, May 25, 2020 12:04 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] avfilter/qsvvpp: Work around a bug in > MSDK where VPP processing hangs

Re: [FFmpeg-devel] [PATCH v6 1/3] avfilter/graphdump: support for the graph2dot function

2020-05-24 Thread lance . lmwang
On Mon, May 25, 2020 at 12:13:37AM +0200, Michael Niedermayer wrote: > On Sun, May 24, 2020 at 09:04:49AM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > reuse the function from tools/graph2dot.c and add support for filter graph > > with > > graphviz DOT format for avfilter dir

[FFmpeg-devel] [PATCH v7 1/3] avfilter/graphdump: support for the graph2dot function

2020-05-24 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/Makefile| 1 - libavfilter/graphdump.c | 89 + tools/graph2dot.c | 204 3 files changed, 89 insertions(+), 205 deletions(-) delete mode 100644 tools/grap

[FFmpeg-devel] [PATCH v7 2/3] avdevice/lavfi: support the dumpgraph with options

2020-05-24 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/indevs.texi | 19 +-- libavdevice/lavfi.c | 8 +--- 2 files changed, 22 insertions(+), 5 deletions(-) diff --git a/doc/indevs.texi b/doc/indevs.texi index 6f5afaf..b4dffc4 100644 --- a/doc/indevs.texi +++ b/doc/indevs.

[FFmpeg-devel] [PATCH v7 3/3] fftools: add options to dump filter graph

2020-05-24 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/ffmpeg.texi | 12 fftools/ffmpeg.c| 1 + fftools/ffmpeg.h| 1 + fftools/ffmpeg_filter.c | 11 +++ fftools/ffmpeg_opt.c| 10 ++ 5 files changed, 35 insertions(+) diff --git a/doc/ffmpeg

[FFmpeg-devel] [PATCH] lavfi/afir: fix vpad.name leak

2020-05-24 Thread Jun Zhao
From: Jun Zhao Fixed vpad.name leak in error path, move the vpad related operation only if enabeled show IR frequency response. Signed-off-by: Jun Zhao --- libavfilter/af_afir.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/libavfilter/af_afir.c b/libavfilt

Re: [FFmpeg-devel] [PATCH] drawtext: Allow textfile path to be expanded per frame

2020-05-24 Thread David Andreoletti
FFmpeg team, Is there any other discussion/changes needed to get this contribution merged in ? Regards, On Tue, May 19, 2020 12:36 PM, David Andreoletti da...@andreoletti.net wrote: Manolis: drawtext's text expansion section [0] does not mention the special variable %{frame_num} has 0 padda

Re: [FFmpeg-devel] [PATCH 1/3] avformat/matroskadec: Beautify matroska_parse_laces()

2020-05-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/matroskadec.c | 27 +++ > 1 file changed, 11 insertions(+), 16 deletions(-) > > diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c > index 4fa32365c3..c02c2561c1 100644 > --- a/lib

[FFmpeg-devel] [PATCH] avformat: Replace ffurl_close() by ffurl_closep() where appropriate

2020-05-24 Thread Andreas Rheinhardt
It avoids leaving dangling pointers behind in memory. Also remove redundant checks for whether the URLContext to be closed is already NULL. Signed-off-by: Andreas Rheinhardt --- libavformat/async.c | 4 ++-- libavformat/cache.c | 2 +- libavformat/concat.c