Re: [FFmpeg-devel] [PATCH] avformat/mpegts: Check the next sync byte to avoid incorrectt detected raw packet size

2020-05-16 Thread Marton Balint
On Sat, 16 May 2020, lance.lmw...@gmail.com wrote: On Fri, May 15, 2020 at 06:52:55PM +0200, Marton Balint wrote: On Fri, 15 May 2020, lance.lmw...@gmail.com wrote: > On Fri, May 15, 2020 at 08:02:44PM +0800, myp...@gmail.com wrote: > > On Fri, May 15, 2020 at 6:23 PM wrote: > > > > > > F

Re: [FFmpeg-devel] [PATCH] avcodec/ass: explicitly set ScaledBorderAndShadow

2020-05-16 Thread Oneric
On Fri, Apr 17, 2020 at 03:35:44 +0200, one...@oneric.de wrote: > On Fri, Apr 17, 2020 at 02:15:17 +0200, Oneric wrote: > > ffmpeg does not set the 'ScaledBorderAndShadow' header for ASS > > subtitles. This currently leads to inconsistent behaviour depending on the > > renderer > > Attached is the

Re: [FFmpeg-devel] [PATCH 1/2] swscale: fix NEON hscale init

2020-05-16 Thread Carl Eugen Hoyos
Am Fr., 15. Mai 2020 um 12:27 Uhr schrieb Josh de Kock : > > On 08/05/2020 12:25, Michael Niedermayer wrote: > > On Thu, May 07, 2020 at 12:25:34PM +0100, Josh de Kock wrote: > >> The NEON hscale function only supports X8 filter sizes and should only > >> be selected when these are being used. > >>

[FFmpeg-devel] [PATCH v5 1/4] avcodec/adpcmenc: add capabilities argument to ADPCM_ENCODER()

2020-05-16 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavcodec/adpcmenc.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c index 668939c778..d3098a8f9c 100644 --- a/libavcodec/adpcmenc.c +++ b/libavcodec/adpcmenc.

[FFmpeg-devel] [PATCH v5 0/4] adpcm_ima_ssi encoder + kvag muxer

2020-05-16 Thread Zane van Iperen
Add support for encoding adpcm_ima_ssi and muxing to kvag. v5: [1] - change AVERROR(EINVAL) to AVERROR_PATCHWELCOME - Split "capabilities" argument and formatting out into new commits - If too verbose, patch 3 may be squashed into patch 2 v{4,3,2,1}: - ancient history [1]: https://ffmp

[FFmpeg-devel] [PATCH v5 2/4] avcodec: add adpcm_ima_ssi encoder

2020-05-16 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi | 2 +- libavcodec/Makefile| 1 + libavcodec/adpcmenc.c | 32 libavcodec/allcodecs.c | 1 + libavcodec/utils.c | 1 + libavcodec/version.h | 2 +- 7 files chan

[FFmpeg-devel] [PATCH v5 4/4] avformat: add kvag muxer

2020-05-16 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/kvag.c | 84 +++- libavformat/version.h| 2 +- 5 files changed, 87 insertions(+), 2 deletions(-) diff -

[FFmpeg-devel] [PATCH v5 3/4] avcodec/adpcmenc: fix formatting

2020-05-16 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavcodec/adpcmenc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c index fbddbd085b..940279274e 100644 --- a/libavcodec/adpcmenc.c +++ b/libavcodec/adpcmenc.c @@ -751,9 +751,9 @@ AVC

[FFmpeg-devel] [PATCH] avformat/hls: check target duration in the playlist

2020-05-16 Thread Steven Liu
fix ticket: 8673 reference rfc8216 4.3.3.1 said: The EXT-X-TARGETDURATION tag is REQUIRED. in ticket 8673, the EXT-X-TARGETDURATION is incorrect, so hls should return error. Signed-off-by: Steven Liu --- libavformat/hls.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat/hl

Re: [FFmpeg-devel] [PATCH] avformat/hls: check target duration in the playlist

2020-05-16 Thread Carl Eugen Hoyos
Am Sa., 16. Mai 2020 um 14:12 Uhr schrieb Steven Liu : > > fix ticket: 8673 > reference rfc8216 4.3.3.1 said: > The EXT-X-TARGETDURATION tag is REQUIRED. > in ticket 8673, the EXT-X-TARGETDURATION is incorrect, so hls > should return error. Can't an invalid target duration be ignored? Or is the s

Re: [FFmpeg-devel] [PATCH] avformat/hls: check target duration in the playlist

2020-05-16 Thread Steven Liu
> 2020年5月16日 下午8:21,Carl Eugen Hoyos 写道: > > Am Sa., 16. Mai 2020 um 14:12 Uhr schrieb Steven Liu : >> >> fix ticket: 8673 >> reference rfc8216 4.3.3.1 said: >> The EXT-X-TARGETDURATION tag is REQUIRED. > >> in ticket 8673, the EXT-X-TARGETDURATION is incorrect, so hls >> should return error.

Re: [FFmpeg-devel] [PATCH] avformat/hls: check target duration in the playlist

2020-05-16 Thread 刘歧
2020年5月16日 下午8:21,Carl Eugen Hoyos 写道: Am Sa., 16. Mai 2020 um 14:12 Uhr schrieb Steven Liu : fix ticket: 8673 reference rfc8216 4.3.3.1 said: The EXT-X-TARGETDURATION tag is REQUIRED. in ticket 8673, the EXT-X-TARGETDURATION is incorrect, so hls should return error. Can't an invalid target dur

Re: [FFmpeg-devel] [PATCH v5 1/4] avcodec/adpcmenc: add capabilities argument to ADPCM_ENCODER()

2020-05-16 Thread Paul B Mahol
Why sending this kind of patches? I see no point in this patch? On 5/16/20, Zane van Iperen wrote: > Signed-off-by: Zane van Iperen > --- > libavcodec/adpcmenc.c | 33 + > 1 file changed, 17 insertions(+), 16 deletions(-) > > diff --git a/libavcodec/adpcmenc.c b

Re: [FFmpeg-devel] [PATCH] lavfi: add untile filter.

2020-05-16 Thread Nicolas George
Paul B Mahol (12020-05-15): > When to apply? When I have time to check the few things I noted I had to check. Is it important? Do you have a need for this? Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailin

Re: [FFmpeg-devel] [PATCH v5 3/4] avcodec/adpcmenc: fix formatting

2020-05-16 Thread Paul B Mahol
Why? No point in this. On 5/16/20, Zane van Iperen wrote: > Signed-off-by: Zane van Iperen > --- > libavcodec/adpcmenc.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c > index fbddbd085b..940279274e 100644 > ---

Re: [FFmpeg-devel] [PATCH] lavfi: add untile filter.

2020-05-16 Thread Paul B Mahol
On 5/16/20, Nicolas George wrote: > Paul B Mahol (12020-05-15): >> When to apply? > > When I have time to check the few things I noted I had to check. Is it > important? Do you have a need for this? I see nowhere notes for things that need checking... Except maybe that query_formats thing. It is

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/jpeg2000dec: Free packed_headers

2020-05-16 Thread Gautam Ramakrishnan
On Thu, May 14, 2020 at 2:19 AM Michael Niedermayer wrote: > > Fixes: memleak > Fixes: > 21784/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-565256551058636 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-

[FFmpeg-devel] [RFC] encoder profile validation

2020-05-16 Thread Marton Balint
Hi, As you may know, a recent patchset enabled AVCodecContext->profile constants to reside in encoders. In order to make a full transition to avctx->profile even in existing encoders which might use a private profile setting, we have to make sure only supported avctx->profile values are pass

Re: [FFmpeg-devel] [PATCH v5 1/4] avcodec/adpcmenc: add capabilities argument to ADPCM_ENCODER()

2020-05-16 Thread Zane van Iperen
On Sat, 16 May 2020 15:03:22 +0200 "Paul B Mahol" wrote: > > Why sending this kind of patches? > > I see no point in this patch? > Michael suggested it here https://ffmpeg.org/pipermail/ffmpeg-devel/2020-May/262730.html ___ ffmpeg-devel mailing l

Re: [FFmpeg-devel] [PATCH v5 3/4] avcodec/adpcmenc: fix formatting

2020-05-16 Thread Zane van Iperen
On Sat, 16 May 2020 15:04:04 +0200 "Paul B Mahol" wrote: > > Why? > > No point in this. > Because of the "Cosmetic changes should be kept in separate patches." section at https://www.ffmpeg.org/developer.html I mentioned in the cover letter that if this patch is too little to be standalone

[FFmpeg-devel] [PATCH] avformat/dump: Use int64_t for intermediate time values

2020-05-16 Thread Derek Buitenhuis
Prevents wrap-around to negative values while calculating the duration string. Before: Duration: -411422:-59:-42.17, start: 0.00, bitrate: 0 kb/s After: Duration: 781623:28:34.17, start: 0.00, bitrate: 0 kb/s Signed-off-by: Derek Buitenhuis --- Minimal example file: http://chr

[FFmpeg-devel] [PATCH] avformat: Add Dynacolor MVC Demuxer

2020-05-16 Thread Tom Needham
This demuxer adds support for demuxing files in the Dynacolor format such as the sample located at: http://samples.ffmpeg.org/camera-dvr/dynacolor/dynacolor-camera-sample However some decode errors are showing on the resulting MPEG4 stream. I don't know whether this is a bug with the demuxer or t

[FFmpeg-devel] [PATCH V4] avformat: Add Dynacolor MVC Demuxer

2020-05-16 Thread Tom Needham
Please ignore my previous email as it was sent in error. This demuxer adds support for demuxing files in the Dynacolor format such as the sample located at: http://samples.ffmpeg.org/camera-dvr/dynacolor/dynacolor-camera-sample However some decode errors are showing on the resulting MPEG4 stream

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: Check the next sync byte to avoid incorrectt detected raw packet size

2020-05-16 Thread lance . lmwang
On Sat, May 16, 2020 at 11:44:01AM +0200, Marton Balint wrote: > > > On Sat, 16 May 2020, lance.lmw...@gmail.com wrote: > > > On Fri, May 15, 2020 at 06:52:55PM +0200, Marton Balint wrote: > > > > > > > > > On Fri, 15 May 2020, lance.lmw...@gmail.com wrote: > > > > > > > On Fri, May 15, 2020

Re: [FFmpeg-devel] [RFC] encoder profile validation

2020-05-16 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > Marton Balint > Sent: Saturday, May 16, 2020 21:52 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [RFC] encoder profile validation > > Hi, > > As you may know, a recent patchset enabled AVCodecContext->profile > constants to reside in encoders. > > I

Re: [FFmpeg-devel] [PATCH] avformat/dump: Use int64_t for intermediate time values

2020-05-16 Thread Carl Eugen Hoyos
Am Sa., 16. Mai 2020 um 16:21 Uhr schrieb Derek Buitenhuis : > > Prevents wrap-around to negative values while calculating the duration string. > > Before: > > Duration: -411422:-59:-42.17, start: 0.00, bitrate: 0 kb/s > > After: > > Duration: 781623:28:34.17, start: 0.00, bitrate:

Re: [FFmpeg-devel] [PATCH] avformat/dump: Use int64_t for intermediate time values

2020-05-16 Thread Derek Buitenhuis
On 16/05/2020 16:23, Carl Eugen Hoyos wrote: > I believe there is a ticket that this patch fixes, but I won't find it > quickly;-( A quick search of trac didn't reveal anything to me, either... - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.o

Re: [FFmpeg-devel] [PATCH v3] avcodec/v4l2_m2m_dec: Remove redundant packet and fix double free

2020-05-16 Thread Andriy Gelman
On Sat, 09. May 13:35, Andriy Gelman wrote: > From: Andriy Gelman > > v4l2_receive_frame() uses two packets s->buf_pkt and avpkt. If avpkt > cannot be enqueued, the packet is buffered in s->buf_pkt and enqueued in > the next call. Currently the ownership transfer between the two packets > is not

[FFmpeg-devel] [PATCH] avcodec/pnmdec: Use unsigned for maxval rescaling

2020-05-16 Thread Michael Niedermayer
Fixes: signed integer overflow: 65535 * 55335 cannot be represented in type 'int' Fixes: 21955/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PGMYUV_fuzzer-5669206981083136 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mich

Re: [FFmpeg-devel] [PATCH v5 1/4] avcodec/adpcmenc: add capabilities argument to ADPCM_ENCODER()

2020-05-16 Thread Paul B Mahol
On 5/16/20, Zane van Iperen wrote: > On Sat, 16 May 2020 15:03:22 +0200 > "Paul B Mahol" wrote: > >> >> Why sending this kind of patches? >> >> I see no point in this patch? >> > > Michael suggested it here > https://ffmpeg.org/pipermail/ffmpeg-devel/2020-May/262730.html > > > Ah, one of them us

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/binkaudio: Check sample_rate to avoid integer overflow

2020-05-16 Thread Michael Niedermayer
On Mon, Apr 20, 2020 at 01:03:34AM +0200, Michael Niedermayer wrote: > On Sun, Apr 19, 2020 at 05:52:01PM +0200, Lynne wrote: > > Apr 19, 2020, 16:05 by mich...@niedermayer.cc: > > > > > Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in > > > type 'int' > > > Fixes: > > > 1

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/binkaudio: Check sample_rate to avoid integer overflow

2020-05-16 Thread Paul B Mahol
On 5/16/20, Michael Niedermayer wrote: > On Mon, Apr 20, 2020 at 01:03:34AM +0200, Michael Niedermayer wrote: >> On Sun, Apr 19, 2020 at 05:52:01PM +0200, Lynne wrote: >> > Apr 19, 2020, 16:05 by mich...@niedermayer.cc: >> > >> > > Fixes: signed integer overflow: 2147483647 + 1 cannot be represent

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: Check the next sync byte to avoid incorrectt detected raw packet size

2020-05-16 Thread Marton Balint
On Sat, 16 May 2020, lance.lmw...@gmail.com wrote: On Sat, May 16, 2020 at 11:44:01AM +0200, Marton Balint wrote: On Sat, 16 May 2020, lance.lmw...@gmail.com wrote: > On Fri, May 15, 2020 at 06:52:55PM +0200, Marton Balint wrote: > > > > > > On Fri, 15 May 2020, lance.lmw...@gmail.com wr

Re: [FFmpeg-devel] [RFC] encoder profile validation

2020-05-16 Thread Marton Balint
On Sat, 16 May 2020, Fu, Linjie wrote: From: ffmpeg-devel On Behalf Of Marton Balint Sent: Saturday, May 16, 2020 21:52 To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [RFC] encoder profile validation Hi, As you may know, a recent patchset enabled AVCodecContext->profile constants to re

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_chromakey: fix formula for calculation of difference

2020-05-16 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_chromakey.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_chromakey.c b/libavfilter/vf_chromakey.c index ce8003657c..4b1669d084 100644 --- a/libavfilter/vf_chromakey.c +++ b/libavfilter/vf_chromakey.c @@ -56,7

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_colorkey: fix formula for calculation of difference

2020-05-16 Thread Paul B Mahol
Also fixes colorhold filtering. Signed-off-by: Paul B Mahol --- libavfilter/vf_colorkey.c | 2 +- tests/ref/fate/ffmpeg-filter_colorkey | 20 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/libavfilter/vf_colorkey.c b/libavfilter/vf_colorkey.c i

Re: [FFmpeg-devel] [PATCH V4] avformat: Add Dynacolor MVC Demuxer

2020-05-16 Thread Andreas Rheinhardt
Tom Needham: > Please ignore my previous email as it was sent in error. > > This demuxer adds support for demuxing files in the Dynacolor format > such as the sample located at: > > http://samples.ffmpeg.org/camera-dvr/dynacolor/dynacolor-camera-sample > > However some decode errors are showing

[FFmpeg-devel] [PATCH] fftools/ffmpeg: add new abort_on flag which aborts if there is a stream which received no packets

2020-05-16 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/ffmpeg.texi | 2 ++ fftools/ffmpeg.c | 4 fftools/ffmpeg.h | 3 ++- fftools/ffmpeg_opt.c | 5 +++-- 4 files changed, 11 insertions(+), 3 deletions(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index ed437bb16f..76fafdcf7e 100644 --- a/do

Re: [FFmpeg-devel] [PATCH v3] libavformat/flacdec: Workaround for truncated metadata picture size

2020-05-16 Thread Andreas Rheinhardt
Mattias Wadman: > lavf flacenc could previously write truncated metadata picture size if > the picture data did not fit in 24 bits. Detect this by truncting the > size found inside the picture block and if it matches the block size > use it and read rest of picture data. > > Also only enable this

Re: [FFmpeg-devel] [PATCH 1/2] swscale: fix NEON hscale init

2020-05-16 Thread Josh de Kock
On 16/05/2020 11:50, Carl Eugen Hoyos wrote: Am Fr., 15. Mai 2020 um 12:27 Uhr schrieb Josh de Kock : On 08/05/2020 12:25, Michael Niedermayer wrote: On Thu, May 07, 2020 at 12:25:34PM +0100, Josh de Kock wrote: The NEON hscale function only supports X8 filter sizes and should only be selecte

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/binkaudio: Check sample_rate to avoid integer overflow

2020-05-16 Thread Michael Niedermayer
On Sat, May 16, 2020 at 07:12:28PM +0200, Paul B Mahol wrote: > On 5/16/20, Michael Niedermayer wrote: > > On Mon, Apr 20, 2020 at 01:03:34AM +0200, Michael Niedermayer wrote: > >> On Sun, Apr 19, 2020 at 05:52:01PM +0200, Lynne wrote: > >> > Apr 19, 2020, 16:05 by mich...@niedermayer.cc: > >> > >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/jpeg2000dec: Free packed_headers

2020-05-16 Thread Michael Niedermayer
On Sat, May 16, 2020 at 06:55:44PM +0530, Gautam Ramakrishnan wrote: > On Thu, May 14, 2020 at 2:19 AM Michael Niedermayer > wrote: > > > > Fixes: memleak > > Fixes: > > 21784/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-565256551058636 > > > > Found-by: continuous fuzzing pr

[FFmpeg-devel] [PATCH] decode: don't treat hwaccel->alloc_frame as always failing

2020-05-16 Thread comex
Fixes regression caused by a1133db30ef07896afd96f067e5c51531a4e85ab. On my Mac, the bug seems to make `mpv --hwdec=auto` always fail with: [ffmpeg/video] h264: get_buffer() failed [ffmpeg] Assertion src->f->buf[0] failed at src/libavcodec/h264_picture.c:70 Signed-off-by: comex --- libavcodec/d

Re: [FFmpeg-devel] [PATCH] avformat/url: check the result of the strrchr

2020-05-16 Thread Steven Liu
> 2020年5月15日 下午6:26,Steven Liu 写道: > > > >> 2020年5月15日 下午6:01,Steven Liu 写道: >> >> because it need be check for success, is should not >> change the old way if it failure. > Change the comments: > because it need be checked for success status, it should not > change the old way if it failu

Re: [FFmpeg-devel] [PATCH] decode: don't treat hwaccel->alloc_frame as always failing

2020-05-16 Thread James Almer
On 5/16/2020 8:41 PM, comex wrote: > Fixes regression caused by a1133db30ef07896afd96f067e5c51531a4e85ab. > > On my Mac, the bug seems to make `mpv --hwdec=auto` always fail with: > > [ffmpeg/video] h264: get_buffer() failed > [ffmpeg] Assertion src->f->buf[0] failed at src/libavcodec/h264_pictur