lance.lmw...@gmail.com (12020-05-07):
> Yeah, then I had to change the ff_mpv_encode_init() return with accurate
> error code also.
If necessary yes. But it can be done later if you have other priorities.
But I consider better to correctly forward an invalid error code than to
incorrectly invent
On Thu, 7 May 2020, leozhang wrote:
Suggested-by: Nicolas George
Reviewed-by: Nicolas George
Reviewed-by: Marton Balint
Reviewed-by: Andreas Rheinhardt
You seem to misunderstand the use of this tag. You should only add these
if you received an explict LGTM for your patches. This has
Quoting Mark Reid (2020-05-07 03:16:17)
> On Wed, May 6, 2020 at 1:07 PM Anton Khirnov wrote:
>
> > Quoting mindm...@gmail.com (2020-04-29 05:02:35)
> > > From: Mark Reid
> > >
> > > ---
> > > libavcodec/exr.c | 103 +++
> > > 1 file changed, 86 inser
Signed-off-by: Steven Liu
---
libavformat/hlsenc.c | 37 -
1 file changed, 20 insertions(+), 17 deletions(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index 5695c6cc95..a1eddade7b 100644
--- a/libavformat/hlsenc.c
+++ b/libavformat/hlsenc.c
@@ -
mails to GMX seem working again
This reverts commit cd11fbcfb03994d3ddbc83f0620530d6f6748f68.
---
doc/mailing-list-faq.texi | 4
1 file changed, 4 deletions(-)
diff --git a/doc/mailing-list-faq.texi b/doc/mailing-list-faq.texi
index 15fc8e86c0..439d783956 100644
--- a/doc/mailing-list-faq.t
This avoids accessing an old, no longer valid buffer.
Fixes: out of array access
Fixes: crash_audio-2020
Found-by: le wu
Signed-off-by: Michael Niedermayer
---
libavformat/mpegts.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/libavformat/mpegts.c b/libavformat/mpeg
From: Limin Wang
Signed-off-by: Limin Wang
---
libavcodec/mpegvideo_enc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c
index b2eb9cf..e1fd92c 100644
--- a/libavcodec/mpegvideo_enc.c
+++ b/libavcodec/mpegvideo_enc
From: Limin Wang
Signed-off-by: Limin Wang
---
libavcodec/mpeg12enc.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c
index 643ba81..cab7076 100644
--- a/libavcodec/mpeg12enc.c
+++ b/libavcodec/mpeg12enc.c
@@ -139
From: Limin Wang
Signed-off-by: Limin Wang
---
libavcodec/mpegvideo_enc.c | 85 +++---
1 file changed, 43 insertions(+), 42 deletions(-)
diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c
index e1fd92c..45aa82f 100644
--- a/libavcodec/m
From: Limin Wang
Signed-off-by: Limin Wang
---
libavcodec/mpegvideo.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
index 22cab28..b5ddb1b 100644
--- a/libavcodec/mpegvideo.c
+++ b/libavcodec/mpegvideo.c
@@ -88
From: Limin Wang
Signed-off-by: Limin Wang
---
libavcodec/mpegvideo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
index b5ddb1b..8a74a45 100644
--- a/libavcodec/mpegvideo.c
+++ b/libavcodec/mpegvideo.c
@@ -359,7 +359,7
This tests the hscale 8bpp to 14bpp functions with different filter
sizes.
Signed-off-by: Josh de Kock
---
Not quite ready to be committed but I wanted to submit it anyway so I
could get some comments. I still need to do the rest of the scale sizes
(such as 8bpp to 19bpp) and make the benchma
The NEON hscale function only supports X8 filter sizes and should only
be selected when these are being used.
Signed-off-by: Josh de Kock
---
libswscale/aarch64/swscale.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libswscale/aarch64/swscale.c b/libswscale/aarch64/sws
On 05/05/2020 17:02, Fu, Linjie wrote:
From: ffmpeg-devel On Behalf Of
Josh Brewster
Sent: Tuesday, May 5, 2020 23:52
To: FFmpeg development discussions and patches
Subject: Re: [FFmpeg-devel] [PATCH v3] libavcodec/libx264: fix reference
frame computation based on level
From: ffmpeg-devel ffm
lance.lmw...@gmail.com (12020-05-07):
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> libavcodec/mpegvideo_enc.c | 85
> +++---
> 1 file changed, 43 insertions(+), 42 deletions(-)
>
> diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvid
> 2020年5月6日 下午3:09，myp...@gmail.com 写道：
>
> On Wed, May 6, 2020 at 2:53 PM Steven Liu wrote:
>>
>> because the offset should use one byte
>>
>> Reported-by: Zhao Jun >
>> Signed-off-by: Steven Liu
>> ---
>> libavformat/dashdec.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
On Thu, 7 May 2020, Josh de Kock wrote:
This tests the hscale 8bpp to 14bpp functions with different filter
sizes.
Signed-off-by: Josh de Kock
---
Not quite ready to be committed but I wanted to submit it anyway so I
could get some comments. I still need to do the rest of the scale sizes
(suc
Quoting Michael Niedermayer (2020-05-07 12:38:26)
> This avoids accessing an old, no longer valid buffer.
> Fixes: out of array access
> Fixes: crash_audio-2020
>
> Found-by: le wu
> Signed-off-by: Michael Niedermayer
> ---
> libavformat/mpegts.c | 7 ---
> 1 file changed, 4 insertions(+),
Quoting lance.lmw...@gmail.com (2020-05-05 16:43:10)
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
Looks good.
--
Anton Khirnov
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsub
Quoting Roger Pack (2020-04-28 08:15:19)
> From 5d7c12a3f703e794e1092087355bc9523d5f4d93 Mon Sep 17 00:00:00 2001
> From: rogerdpack
> Date: Tue, 28 Apr 2020 05:15:15 +
> Subject: [PATCH 1/3] closed caption decoder: accept and decode a new codec
> type of 'raw 608 byte pairs'
>
> Signed-off-
On Thu, May 07, 2020 at 01:30:02PM +0200, Nicolas George wrote:
> lance.lmw...@gmail.com (12020-05-07):
> > From: Limin Wang
> >
> > Signed-off-by: Limin Wang
> > ---
> > libavcodec/mpegvideo_enc.c | 85
> > +++---
> > 1 file changed, 43 insertions(+), 4
Is it just me, or the coded id is too much verbose?
On 5/7/20, Anton Khirnov wrote:
> Quoting Roger Pack (2020-04-28 08:15:19)
>> From 5d7c12a3f703e794e1092087355bc9523d5f4d93 Mon Sep 17 00:00:00 2001
>> From: rogerdpack
>> Date: Tue, 28 Apr 2020 05:15:15 +
>> Subject: [PATCH 1/3] closed cap
On Thu, May 07, 2020 at 02:14:07PM +0200, Anton Khirnov wrote:
> Quoting lance.lmw...@gmail.com (2020-05-05 16:43:10)
> > From: Limin Wang
> >
> > Signed-off-by: Limin Wang
> > ---
>
> Looks good.
will apply.
>
> --
> Anton Khirnov
> ___
> ffmpeg-
From: Limin Wang
Signed-off-by: Limin Wang
---
libavcodec/mpegvideo_enc.c | 85 +++---
1 file changed, 43 insertions(+), 42 deletions(-)
diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c
index e1fd92c..bb7ac88 100644
--- a/libavcodec/m
On 5/7/2020 10:22 AM, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> libavcodec/mpegvideo_enc.c | 85
> +++---
> 1 file changed, 43 insertions(+), 42 deletions(-)
>
> diff --git a/libavcodec/mpegvideo_enc.c b/liba
From: Limin Wang
Signed-off-by: Limin Wang
---
libavcodec/mpegvideo_enc.c | 85 +++---
1 file changed, 43 insertions(+), 42 deletions(-)
diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c
index e1fd92c..50ae57e 100644
--- a/libavcodec/m
On Thu, May 07, 2020 at 10:29:50AM -0300, James Almer wrote:
> On 5/7/2020 10:22 AM, lance.lmw...@gmail.com wrote:
> > From: Limin Wang
> >
> > Signed-off-by: Limin Wang
> > ---
> > libavcodec/mpegvideo_enc.c | 85
> > +++---
> > 1 file changed, 43 inser
On Sat, Apr 18, 2020 at 12:52:47PM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> return error if unknown picture type encountered
>
> Fixes CID 1457234
> Signed-off-by: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> haven't merge yet, so rebase to the git master
>
> libavcod
On Tue, May 05, 2020 at 04:16:56PM +0200, Andreas Rheinhardt wrote:
> When writing the header, the NUT muxer allocates an array with as many
> entries as there are chapters containing information about the used
> timebase. This information is used when writing the headers and also
> when resending
Thanks for the tip Nicolas.
Well, -copyts works fine when you're re-encoding at full speed.
But when used in combination with -re, as shown below, it prevents the
input from being "fast-seeked" to the desired position. So, it's kind of
useless.
ffmpeg -re -copyts -ss 20:10.00 -i input.mp4
On Tue, May 05, 2020 at 04:16:57PM +0200, Andreas Rheinhardt wrote:
> Commit 14b3f9961f3cf9173c43c936eb0cfb5a35fb8419 introduced header
> repetition (used to improve resilience) in the NUT muxer; a variable
> header_count was added for this to the NUTContext. It contained the
> number of times the
Michael Niedermayer:
> On Tue, May 05, 2020 at 04:16:56PM +0200, Andreas Rheinhardt wrote:
>> When writing the header, the NUT muxer allocates an array with as many
>> entries as there are chapters containing information about the used
>> timebase. This information is used when writing the headers
On Thu, May 07, 2020 at 02:09:43PM +0200, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2020-05-07 12:38:26)
> > This avoids accessing an old, no longer valid buffer.
> > Fixes: out of array access
> > Fixes: crash_audio-2020
> >
> > Found-by: le wu
> > Signed-off-by: Michael Niedermayer
>
Michael Niedermayer:
> On Tue, May 05, 2020 at 04:16:57PM +0200, Andreas Rheinhardt wrote:
>> Commit 14b3f9961f3cf9173c43c936eb0cfb5a35fb8419 introduced header
>> repetition (used to improve resilience) in the NUT muxer; a variable
>> header_count was added for this to the NUTContext. It contained
Hi FFMPEG devel,
I have been writing a simple XComposite window capture demuxer, heavily
inspired from x11grab sources and OBS Window capture logic/code.
I would like to give back to the community and share the sources; before
I would formally submit for a review/patch, I would really appreci
Neil Birkbeck:
> On Tue, Apr 28, 2020 at 3:18 AM Nicolas George wrote:
>
>> Andreas Rheinhardt (12020-04-28):
>>> That's expected. The patch provided only provides the structure in which
>>> the values are intended to be exported; it does not add any demuxing or
>>> muxing capabilities for mov or
There is no reason to enforce a high minimum. In the context
of streaming only a few output buffers and capture buffers
are even needed for continuous playback. This also helps
alleviate memory pressure when decoding 4K media.
---
libavcodec/v4l2_m2m.h | 2 +-
libavcodec/v4l2_m2m_dec.c | 2 +-
On Thu, 7 May 2020, lance.lmw...@gmail.com wrote:
From: Limin Wang
Signed-off-by: Limin Wang
---
libavcodec/mpegvideo.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
index 22cab28..b5ddb1b 100644
--- a/libav
On Thu, 7 May 2020, lance.lmw...@gmail.com wrote:
From: Limin Wang
Signed-off-by: Limin Wang
---
libavcodec/mpegvideo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
index b5ddb1b..8a74a45 100644
--- a/libavcodec/mpegv
On Tue, 5 May 2020, Marton Balint wrote:
On Tue, 5 May 2020, Andreas Rheinhardt wrote:
Marton Balint:
On Tue, 5 May 2020, Andreas Rheinhardt wrote:
Marton Balint:
Previously only 1:1 bitstream filters were supported, the end of the
stream was
not signalled to the bitstream filters an
On Thu, 7 May 2020, Emanuele Oriani wrote:
Hi FFMPEG devel,
I have been writing a simple XComposite window capture demuxer, heavily
inspired from x11grab sources and OBS Window capture logic/code.
Have you compared performance to x11grab for various resolutions and
frame rates? Do you hav
Marton Balint:
>
>
> On Tue, 5 May 2020, Marton Balint wrote:
>
>>
>>
>> On Tue, 5 May 2020, Andreas Rheinhardt wrote:
>>
>>> Marton Balint:
On Tue, 5 May 2020, Andreas Rheinhardt wrote:
> Marton Balint:
>> Previously only 1:1 bitstream filters were supported, the end
On Sat, Apr 18, 2020 at 5:02 AM Lynne wrote:
> Apr 18, 2020, 11:14 by an...@khirnov.net:
>
> > From: Juan De León
> >
> > This is intended to replace the deprecated the AV_FRAME_DATA_QP_TABLE*
> > API and extend it to a wider range of codecs.
> >
> > In the future, it may also be extended to sup
It can't fail since 9c8aa86883f28fc27ca790b290c3be2d347b0d19.
Signed-off-by: Andreas Rheinhardt
---
libavformat/matroskaenc.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
index d16d607269..158193738e 1006
in mkv_write_stereo_mode(). Also check the size of the AVStereo3D
side data.
Signed-off-by: Andreas Rheinhardt
---
libavformat/matroskaenc.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
index 158193738e..4
The Matroska muxer writes the Chapters early when chapters were already
available when writing the header; in this case any tags pertaining to
these chapters get written, too.
Yet if no chapters had been supplied before writing the header, Chapters
can also be written when writing the trailer if a
Up until now, the Matroska muxer writes only one Tags level 1 element
and therefore using a certain place to store the dynamic buffer used for
writing it was hardcoded; yet the Matroska specifications allow an
unlimited amount of Tags elements and we have reason to write a second
one: If chapters a
Each AttachedFile in Matroska can have a FileDescription element that
contains a human-friendly name for the attached file; yet this element
has been ignored up until now. This commit changes this and exports it
as title tag instead (the Matroska muxer mapped the title tag to the
AttachedFile eleme
The Matroska muxer has always mapped the title tag to the FileDescription
element for attachments streams since support for writing attachments
was added in commit c7a63a521b5c165405e3577751d649529d09f0c5. This
commit merely documents this fact.
Signed-off-by: Andreas Rheinhardt
---
doc/muxers.t
Mostly reindentation after the last commit. Also remove a variable that
is always zero; move another variable to a more local scope and don't
assign a value to a local variable immediately before leaving the function.
Signed-off-by: Andreas Rheinhardt
---
libavformat/matroskaenc.c | 87 +
This is needed so that it can access mkv_write_tag() and mkv_check_tag()
without using forward declarations (which are unnecessary here).
Signed-off-by: Andreas Rheinhardt
---
libavformat/matroskaenc.c | 118 +++---
1 file changed, 59 insertions(+), 59 deletions(-
If you have a file with multiple Metadata Keys, the second time you parse
the keys, you will re-alloc c->meta_keys without freeing the old one.
This change will avoid parsing all the consecutive Metadata keys.
---
libavformat/mov.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --gi
Signed-off-by: Marton Balint
---
libavformat/fifo.c | 59 +-
1 file changed, 58 insertions(+), 1 deletion(-)
diff --git a/libavformat/fifo.c b/libavformat/fifo.c
index d11dc6626c..17748e94ce 100644
--- a/libavformat/fifo.c
+++ b/libavformat/fif
On Thu, 7 May 2020, Andreas Rheinhardt wrote:
Marton Balint:
On Tue, 5 May 2020, Marton Balint wrote:
On Tue, 5 May 2020, Andreas Rheinhardt wrote:
Marton Balint:
On Tue, 5 May 2020, Andreas Rheinhardt wrote:
Marton Balint:
Previously only 1:1 bitstream filters were supported, t
Neil Birkbeck:
> On Tue, Apr 28, 2020 at 3:18 AM Nicolas George wrote:
>
>> Andreas Rheinhardt (12020-04-28):
>>> That's expected. The patch provided only provides the structure in which
>>> the values are intended to be exported; it does not add any demuxing or
>>> muxing capabilities for mov or
This commit fixes two recent regressions both of which are about using
pkt->stream_index as index in an AVFormatContext's streams array before
actually comparing the value with the count of streams in said array.
96e5e6abb9851d7a26ba21703955d5826ac857c0 did this in
prepare_input_packet() and 640635
On Thu, May 07, 2020 at 08:36:50PM +0200, Marton Balint wrote:
>
>
> On Thu, 7 May 2020, lance.lmw...@gmail.com wrote:
>
> > From: Limin Wang
> >
> > Signed-off-by: Limin Wang
> > ---
> > libavcodec/mpegvideo.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a
On Thu, May 07, 2020 at 08:34:44PM +0200, Marton Balint wrote:
>
>
> On Thu, 7 May 2020, lance.lmw...@gmail.com wrote:
>
> > From: Limin Wang
> >
> > Signed-off-by: Limin Wang
> > ---
> > libavcodec/mpegvideo.c | 14 +++---
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > d
From: Limin Wang
Signed-off-by: Limin Wang
---
libavcodec/mpegvideo.c | 30 --
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
index 22cab28..5101e97 100644
--- a/libavcodec/mpegvideo.c
+++ b/libavcodec/
From: Limin Wang
Signed-off-by: Limin Wang
---
libavcodec/mpegvideo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
index 5101e97..dd3b925 100644
--- a/libavcodec/mpegvideo.c
+++ b/libavcodec/mpegvideo.c
@@ -408,7 +408,7 @@ s
On Mon, Dec 30, 2019 at 07:09:58PM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> libavfilter/vf_signalstats.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_sign
Marton Balint 于2020年5月7日周四 下午6:23写道：
>
>
>
> On Thu, 7 May 2020, leozhang wrote:
>
> > Suggested-by: Nicolas George
> > Reviewed-by: Nicolas George
> > Reviewed-by: Marton Balint
> > Reviewed-by: Andreas Rheinhardt
>
> You seem to misunderstand the use of this tag. You should only add these
On Thu, Sep 12, 2019 at 12:55:09PM +0200, Carl Eugen Hoyos wrote:
> Am Do., 12. Sept. 2019 um 11:24 Uhr schrieb :
> >
> > From: Limin Wang
> >
> > Signed-off-by: Limin Wang
> > ---
> > libavcodec/lcldec.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavcodec/l
https://github.com/FFmpeg/FFmpeg/commit/601c238 added support
for AV_PKT_DATA_NEW_EXTRADATA, but only for avcC extradata.
This commit adds support for sps/pps extradata as well. This
makes support consistent for passing new extradata consistent
with the types of extradata that can be passed when in
64 matches
Mail list logo
