Re: [FFmpeg-devel] [PATCH] [GSOC] libavfilter/vf_colorconstancy.c : Adding weighted greyedge

2020-04-17 Thread Moritz Barsnick
On Thu, Apr 16, 2020 at 18:39:58 +0530, YATENDRA SINGH wrote: > > As Michael noted, please resend without broken like feeds. I can't read > > most of the diff the way it is now. > > > Sorry but I could not understand what broken by newlines mean. Can you > explain a little bit further? Your mailer

Re: [FFmpeg-devel] [PATCH] lavfi: add untile filter.

2020-04-17 Thread Paul B Mahol
On 4/16/20, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > doc/filters.texi | 34 ++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_untile.c | 198 +++ > tests/fate/filter-video

Re: [FFmpeg-devel] [PATCH] lavfi: add untile filter.

2020-04-17 Thread Nicolas George
Paul B Mahol (12020-04-17): > Can't nb_frames be int64 ? It could, but that makes a difference if somebody wants to have more than two billions frames in a single image, which I consider insane, irregardless of the technical limitations. As it is, I prefer to let a slightly saner limit to catch u

Re: [FFmpeg-devel] [PATCH 1/3] lavc/pgs_frame_merge_bsf: add bsf to merge PGS segments

2020-04-17 Thread Petri Hintukainen
to, 2020-04-16 kello 16:57 -0600, John Stebbins kirjoitti: > Required to remux m2ts to mkv > --- > libavcodec/Makefile | 1 + > libavcodec/bitstream_filters.c | 1 + > libavcodec/pgs_frame_merge_bsf.c | 164 > +++ > 3 files changed, 166 insertions(+)

Re: [FFmpeg-devel] [PATCH v3] lavfi: add new iteration API

2020-04-17 Thread Jean-Baptiste Kempf
On Thu, Apr 16, 2020, at 21:56, Nicolas George wrote: > Andreas Rheinhardt (12020-04-16): > > How would one create these out-of-tree filters without using internal > > API and without extending the public API for this (thereby hindering > > development generally)? E.g. all those function pointers

[FFmpeg-devel] [PATCH v2] libavcodec/libx264: fix reference frame computation based on level

2020-04-17 Thread Josh Brewster
> Hi, > > > From: ffmpeg-devel ffmpeg-devel-boun...@ffmpeg.org On Behalf Of > > josh.brews...@protonmail.com > > Sent: Friday, April 17, 2020 07:05 > > To: ffmpeg-devel@ffmpeg.org > > Subject: [FFmpeg-devel] [PATCH] libavcodec/libx264: fix reference frame > > computation based on level > > Hell, ca

Re: [FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-17 Thread Ross Nicholson
Ping > On 15 Apr 2020, at 17:21, Ross Nicholson wrote: > >  > Ping to hopefully apply this patch! > >>> On 12 Apr 2020, at 16:54, Ross Nicholson wrote: >>> >>  >> User testing has been completed successfully so this is ready to be applied. >> >> Thanks >> On 7 Apr 2020, at 23:50, Ro

[FFmpeg-devel] [PATCH] ffplay: do not segfault on stream_open internal error

2020-04-17 Thread Peter Ross
is->ic is assigned by read_thread, but this may not have happened yet when stream_open fails. --- fftools/ffplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 1beec54293..5530d2a396 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay

[FFmpeg-devel] [PATCH] avcodec/pngdec: set return value on av_stereo3d_create_side_data() failure

2020-04-17 Thread Peter Ross
--- libavcodec/pngdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 7e2c19bd57..12d4eb0610 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -1286,8 +1286,10 @@ static int decode_frame_common(AVCodecContext *avc

Re: [FFmpeg-devel] [PATCH v1] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-17 Thread James Almer
On 4/16/2020 10:23 PM, Limin Wang wrote: > On Thu, Apr 16, 2020 at 05:16:35PM +0200, Nicolas George wrote: >> Sorry, forgot to reply to that. >> >> Limin Wang (12020-04-04): >>> the md5 framecrc is generated by libavformat/tests/movenc.c, I have no >>> clue how the movenc testing work and how to ge

Re: [FFmpeg-devel] [PATCH v1] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-17 Thread Nicolas George
James Almer (12020-04-17): > The change is effectively just the keyframe flag being added to audio > packets in all of the movenc tests. > > To verify, simply apply > without your patch, and you'll get the same changes in the test. I would be more comfortable with the information that it was che

Re: [FFmpeg-devel] [PATCH v1] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-17 Thread James Almer
On 4/17/2020 10:27 AM, Nicolas George wrote: > James Almer (12020-04-17): >> The change is effectively just the keyframe flag being added to audio >> packets in all of the movenc tests. >> >> To verify, simply apply > >> without your patch, and you'll get the same changes in the test. > > I would

Re: [FFmpeg-devel] [PATCH v1] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-17 Thread Nicolas George
James Almer (12020-04-17): > The movenc test does not produce any files. It creates bogus packets > that are dumped into the AVOutputFormat output using a custom > AVIOContext on each stream that just calculates an md5 hash of the data. > > I think the one line change i posted is enough to reprodu

Re: [FFmpeg-devel] [PATCH v1] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-17 Thread Jan Ekström
On Fri, Apr 17, 2020 at 4:37 PM James Almer wrote: > > The movenc test does not produce any files. It creates bogus packets > that are dumped into the AVOutputFormat output using a custom > AVIOContext on each stream that just calculates an md5 hash of the data. > > I think the one line change i p

Re: [FFmpeg-devel] [PATCH v1] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-17 Thread Derek Buitenhuis
On 17/04/2020 14:38, Nicolas George wrote: > James Almer (12020-04-17): >> The movenc test does not produce any files. It creates bogus packets >> that are dumped into the AVOutputFormat output using a custom >> AVIOContext on each stream that just calculates an md5 hash of the data. It has an opt

Re: [FFmpeg-devel] [PATCH v1] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-17 Thread Limin Wang
On Fri, Apr 17, 2020 at 10:24:53AM -0300, James Almer wrote: > On 4/16/2020 10:23 PM, Limin Wang wrote: > > On Thu, Apr 16, 2020 at 05:16:35PM +0200, Nicolas George wrote: > >> Sorry, forgot to reply to that. > >> > >> Limin Wang (12020-04-04): > >>> the md5 framecrc is generated by libavformat/tes

Re: [FFmpeg-devel] [PATCH v1] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-17 Thread James Almer
On 4/17/2020 10:54 AM, Derek Buitenhuis wrote: > On 17/04/2020 14:38, Nicolas George wrote: >> James Almer (12020-04-17): >>> The movenc test does not produce any files. It creates bogus packets >>> that are dumped into the AVOutputFormat output using a custom >>> AVIOContext on each stream that ju

[FFmpeg-devel] [PATCH] libavcodec/avpacket: Don't simply forward return value of av_dict_set()

2020-04-17 Thread Andreas Rheinhardt
The documentation of av_dict_set() states that values >= 0 indicate success, whereas av_packet_unpack_dictionary() implies that return values > 0 are impossible. So only forward the return value of av_dict_set() in av_packet_unpack_dictionary() on error. (Btw: av_dict_set() does currently not retu

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec/mpeg12enc: Support mpeg2 encoder profile with const options

2020-04-17 Thread Limin Wang
ping for merge, please. On Sat, Apr 04, 2020 at 08:25:31AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/encoders.texi | 8 > libavcodec/mpeg12enc.c | 22 +- > libavcodec/mpegvideo.h | 1 + > 3 files chang

Re: [FFmpeg-devel] [PATCH v3 1/3] avfilter/af_acrossover: Check sscanf() return value

2020-04-17 Thread Limin Wang
ping for merge please. On Sun, Mar 29, 2020 at 08:08:04AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/af_acrossover.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/af_acrossover.c b/libav

[FFmpeg-devel] [PATCH v1] avcodec/bsf: simplify the code

2020-04-17 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/bsf.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c index 7b96183e64..c4c939c205 100644 --- a/libavcodec/bsf.c +++ b/libavcodec/bsf.c @@ -533,7 +533,7 @@ end: int av_b

Re: [FFmpeg-devel] [PATCH v3 1/3] avfilter/af_acrossover: Check sscanf() return value

2020-04-17 Thread Paul B Mahol
On 4/17/20, Limin Wang wrote: > > ping for merge please. trival patch, apply at will. > > On Sun, Mar 29, 2020 at 08:08:04AM +0800, lance.lmw...@gmail.com wrote: >> From: Limin Wang >> >> Signed-off-by: Limin Wang >> --- >> libavfilter/af_acrossover.c | 5 - >> 1 file changed, 4 insertion

Re: [FFmpeg-devel] [PATCH v3 1/3] avfilter/af_acrossover: Check sscanf() return value

2020-04-17 Thread Nicolas George
Paul B Mahol (12020-04-17): > trival patch, apply at will. It is not a trivial patch when it has required a v3. Let's stop applying at will. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmp

Re: [FFmpeg-devel] [PATCH v3 1/3] avfilter/af_acrossover: Check sscanf() return value

2020-04-17 Thread Limin Wang
On Fri, Apr 17, 2020 at 04:34:28PM +0200, Paul B Mahol wrote: > On 4/17/20, Limin Wang wrote: > > > > ping for merge please. > > trival patch, apply at will. I can't push it directly, so ping it for developer/maintainer help to apply it. > > > > > On Sun, Mar 29, 2020 at 08:08:04AM +0800, lanc

Re: [FFmpeg-devel] [PATCH v1] avcodec/bsf: simplify the code

2020-04-17 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/bsf.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c > index 7b96183e64..c4c939c205 100644 > --- a/libavcodec/bsf.c > +++ b/libav

Re: [FFmpeg-devel] [PATCH v1] avcodec/bsf: simplify the code

2020-04-17 Thread Limin Wang
On Fri, Apr 17, 2020 at 04:41:44PM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/bsf.c | 10 ++ > > 1 file changed, 2 insertions(+), 8 deletions(-) > > > > diff --git a/libavcodec/bsf.c b/libavco

Re: [FFmpeg-devel] [PATCH v1] avcodec/bsf: simplify the code

2020-04-17 Thread Paul B Mahol
On 4/17/20, Limin Wang wrote: > On Fri, Apr 17, 2020 at 04:41:44PM +0200, Andreas Rheinhardt wrote: >> lance.lmw...@gmail.com: >> > From: Limin Wang >> > >> > Signed-off-by: Limin Wang >> > --- >> > libavcodec/bsf.c | 10 ++ >> > 1 file changed, 2 insertions(+), 8 deletions(-) >> > >> >

Re: [FFmpeg-devel] [PATCH] avcodec/pngdec: set return value on av_stereo3d_create_side_data() failure

2020-04-17 Thread Vittorio Giovara
On Fri, Apr 17, 2020 at 8:37 AM Peter Ross wrote: > --- > libavcodec/pngdec.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c > index 7e2c19bd57..12d4eb0610 100644 > --- a/libavcodec/pngdec.c > +++ b/libavcodec/pngdec.c > @@ -

Re: [FFmpeg-devel] [PATCH 1/3] lavc/pgs_frame_merge_bsf: add bsf to merge PGS segments

2020-04-17 Thread John Stebbins
On Fri, 2020-04-17 at 13:21 +0300, Petri Hintukainen wrote: > to, 2020-04-16 kello 16:57 -0600, John Stebbins kirjoitti: > > Required to remux m2ts to mkv > > --- > > libavcodec/Makefile | 1 + > > libavcodec/bitstream_filters.c | 1 + > > libavcodec/pgs_frame_merge_bsf.c | 164

Re: [FFmpeg-devel] [PATCH 1/3] lavc/pgs_frame_merge_bsf: add bsf to merge PGS segments

2020-04-17 Thread John Stebbins
On Fri, 2020-04-17 at 08:52 -0700, John Stebbins wrote: > On Fri, 2020-04-17 at 13:21 +0300, Petri Hintukainen wrote: > > to, 2020-04-16 kello 16:57 -0600, John Stebbins kirjoitti: > > > Required to remux m2ts to mkv > > > --- > > > libavcodec/Makefile | 1 + > > > libavcodec/bitstr

Re: [FFmpeg-devel] [PATCH v8 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-04-17 Thread Michael Niedermayer
On Thu, Apr 16, 2020 at 11:39:00PM +, Zane van Iperen wrote: > On Thu, 16 Apr 2020 21:37:54 +0200 > "Michael Niedermayer" wrote: > > > > > > @@ -1304,6 +1329,13 @@ static int > > > > > adpcm_decode_frame(AVCodecContext *avctx, void *data, samples > > > > > += avctx->channels; } > > > > >

Re: [FFmpeg-devel] [PATCH v4 2/2] libavcodec/libaomenc.c: Support lossless encoding

2020-04-17 Thread Ryo Hirafuji
I see, Thanks. I'm looking forward to the answer. (If you are OK, please CC to me. I also would like to know about lossless mode in libaom, because I also use my software) 2020年4月15日(水) 10:00 James Zern : > On Tue, Apr 7, 2020 at 5:14 PM Ryo Hirafuji > wrote: > > > > From: Ryo Hirafuji > > > >

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: restructure the internal implementation of the bistream filter API

2020-04-17 Thread Andreas Rheinhardt
James Almer: > Process input data as soon as it's fed to av_bsf_send_packet(), instead of > storing a single packet and expecting the user to call av_bsf_receive_packet() > in order to trigger the decoding process before they are allowed to feed more > data. > > This puts the bsf API more in line

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: restructure the internal implementation of the bistream filter API

2020-04-17 Thread James Almer
On 4/17/2020 3:49 PM, Andreas Rheinhardt wrote: > James Almer: >> Process input data as soon as it's fed to av_bsf_send_packet(), instead of >> storing a single packet and expecting the user to call >> av_bsf_receive_packet() >> in order to trigger the decoding process before they are allowed to f

Re: [FFmpeg-devel] [PATCH] ffplay: do not segfault on stream_open internal error

2020-04-17 Thread Marton Balint
On Fri, 17 Apr 2020, Peter Ross wrote: is->ic is assigned by read_thread, but this may not have happened yet when stream_open fails. I think the idea was that audio_stream/video_stream/subtitle_stream should be -1 if no stream is opened. But that is not true, because it is only initialized

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/bsf: use simplified algorithm for bsf_list chained filtering

2020-04-17 Thread Marton Balint
On Fri, 17 Apr 2020, Marton Balint wrote: On Fri, 10 Apr 2020, Andreas Rheinhardt wrote: Marton Balint: On Thu, 9 Apr 2020, Andreas Rheinhardt wrote: Marton Balint: Based on the one in ffmpeg.c and it is not using an extra flush_idx variable. Signed-off-by: Marton Balint ---  libav

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: restructure the internal implementation of the bistream filter API

2020-04-17 Thread Andreas Rheinhardt
James Almer: > On 4/17/2020 3:49 PM, Andreas Rheinhardt wrote: >> James Almer: >>> Process input data as soon as it's fed to av_bsf_send_packet(), instead of >>> storing a single packet and expecting the user to call >>> av_bsf_receive_packet() >>> in order to trigger the decoding process before t

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: restructure the internal implementation of the bistream filter API

2020-04-17 Thread James Almer
On 4/17/2020 5:40 PM, Andreas Rheinhardt wrote: > James Almer: >> On 4/17/2020 3:49 PM, Andreas Rheinhardt wrote: >>> James Almer: Process input data as soon as it's fed to av_bsf_send_packet(), instead of storing a single packet and expecting the user to call av_bsf_receive_packet(

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: restructure the internal implementation of the bistream filter API

2020-04-17 Thread James Almer
On 4/17/2020 6:11 PM, James Almer wrote: > On 4/17/2020 5:40 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 4/17/2020 3:49 PM, Andreas Rheinhardt wrote: What is the caller now supposed to do with the packet he has? Submit it again for filtering? >>> >>> In case of failure, you shoul

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: restructure the internal implementation of the bistream filter API

2020-04-17 Thread Andreas Rheinhardt
James Almer: > On 4/17/2020 5:40 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 4/17/2020 3:49 PM, Andreas Rheinhardt wrote: James Almer: > Process input data as soon as it's fed to av_bsf_send_packet(), instead of > storing a single packet and expecting the user to call > a

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: restructure the internal implementation of the bistream filter API

2020-04-17 Thread James Almer
On 4/17/2020 6:56 PM, Andreas Rheinhardt wrote: > James Almer: >> On 4/17/2020 5:40 PM, Andreas Rheinhardt wrote: >>> James Almer: On 4/17/2020 3:49 PM, Andreas Rheinhardt wrote: > James Almer: >> Process input data as soon as it's fed to av_bsf_send_packet(), instead >> of >>

[FFmpeg-devel] How to satisfy two codecs with one decoder?

2020-04-17 Thread Roger Pack
I want to add to the closed caption libavcodec/ccaption_dec.c decoder to be able to handle both 608 "over CEA 708" (which it already does) and also "raw EIA 608 byte pairs" which it doesn't. My idea was to introduce a new codec id for the raw 608 pairs. AV_CODEC_ID_EIA_RAW_608 or the like. The de

Re: [FFmpeg-devel] How to satisfy two codecs with one decoder?

2020-04-17 Thread James Almer
On 4/17/2020 7:40 PM, Roger Pack wrote: > I want to add to the closed caption libavcodec/ccaption_dec.c decoder > to be able to handle both 608 "over CEA 708" (which it already does) > and also "raw EIA 608 byte pairs" which it doesn't. > > My idea was to introduce a new codec id for the raw 608 p

[FFmpeg-devel] [PATCH] avcodec/pngdec: Pass ret from decode_iccp_chunk()

2020-04-17 Thread Michael Niedermayer
Found while reviewing a patch fixing a similar issue Signed-off-by: Michael Niedermayer --- libavcodec/pngdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 12d4eb0610..67bfc41b31 100644 --- a/libavcodec/pngdec.c +++ b/libavc

Re: [FFmpeg-devel] [PATCH v1] avcodec/bsf: simplify the code

2020-04-17 Thread Limin Wang
On Fri, Apr 17, 2020 at 05:24:32PM +0200, Paul B Mahol wrote: > On 4/17/20, Limin Wang wrote: > > On Fri, Apr 17, 2020 at 04:41:44PM +0200, Andreas Rheinhardt wrote: > >> lance.lmw...@gmail.com: > >> > From: Limin Wang > >> > > >> > Signed-off-by: Limin Wang > >> > --- > >> > libavcodec/bsf.c |

Re: [FFmpeg-devel] [PATCH 1/4] fate: Fix dependencies for ffprobe tests with external samples

2020-04-17 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Up until now, they were appended to the FATE_EXTERN-$(CONFIG_FFMPEG) > variable and were therefore activated when ffmpeg was enabled regardless > of whether ffprobe was enabled. > > Also the same happened with FATE_SAMPLES_FASTSTART, although the > corresponding test (mov-fas

Re: [FFmpeg-devel] [PATCH] ffplay: set stream_index to -1 earlier to prevent segfault

2020-04-17 Thread Peter Ross
Signed-off-by: Peter Ross Reviewed-by: Marton Balint --- Great suggestion. I will apply in a few days if no objections. fftools/ffplay.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 1beec54293..d673b8049a 100644 --- a/fftoo

Re: [FFmpeg-devel] [PATCH v8 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-04-17 Thread Zane van Iperen
On Fri, 17 Apr 2020 18:50:05 +0200 "Michael Niedermayer" wrote: > On Thu, Apr 16, 2020 at 11:39:00PM +, Zane van Iperen wrote: > > On Thu, 16 Apr 2020 21:37:54 +0200 > > "Michael Niedermayer" wrote: > > > > > > > > @@ -1304,6 +1329,13 @@ static int > > > > > > adpcm_decode_frame(AVCodecCon

[FFmpeg-devel] [PATCH v10 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-04-17 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/pp_bnk.c | 293 +++ libavformat/version.h| 2 +- 5 files changed, 297 insertions(+), 1 deletion(-) cr

[FFmpeg-devel] [PATCH v10 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-04-17 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/adpcm.c | 33 + libavcodec/adpcm_data.c | 13 + libavcodec/adpcm_data.h | 2 ++ libavcodec/allcodecs.c |

[FFmpeg-devel] [PATCH v10 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-04-17 Thread Zane van Iperen
Adds support for the soundbank files used by the Pro Pinball series of games. v10: [7] - Change while() to for(). v9: [6] - Rebase after codec_id.h changes - style fixes - Fix an uninitialised variable read v8: [5] - change "goto done" to a return + "goto fail" - Handle truncated fil

Re: [FFmpeg-devel] [PATCH 1/2] avformat/flacenc: Only update streaminfo if it has changed

2020-04-17 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Andreas Rheinhardt: >> An AVStream's codecpar is supposed to be filled by the caller before >> avformat_write_header(); if the CodecParameters change, the caller >> should signal this via packet side data, but not touch the AVStream's >> codecpar. >> >> The FLAC muxer checks f

[FFmpeg-devel] [PATCH] avcodec/truehd_core_bsf: Remove unused AVClass pointer

2020-04-17 Thread Andreas Rheinhardt
The context structure of the truehd_core bsf had a pointer to a const AVClass as its first member; yet this bsf does not have any AVClass associated with it, so that this pointer is always NULL. So remove it. Signed-off-by: Andreas Rheinhardt --- libavcodec/truehd_core_bsf.c | 2 -- 1 file chang

[FFmpeg-devel] [PATCH 1/2] avcodec/adpcm_ima_{apc, ssi, oki}: replace while() with for()

2020-04-17 Thread Zane van Iperen
Per discussion at https://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/260854.html Signed-off-by: Zane van Iperen --- libavcodec/adpcm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index ee18875579..7d35884056 100644 --- a/li

[FFmpeg-devel] [PATCH 2/2] avcodec/adpcm: update get_nb_samples() doc

2020-04-17 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavcodec/adpcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 7d35884056..9ea6a268eb 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -668,7 +668,7 @@ static inline int16_t adpcm_

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mpc: Simplify cleanup

2020-04-17 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Currently Musepack allocates an array that needs to be freed later in > the demuxer's read_close-function; it is the sole reason for said > function's existence. But it is unnecessary, because one can store this > array in the stream's priv_data pointer, so that it will be fre

Re: [FFmpeg-devel] [PATCH v2] libavcodec/libx264: fix reference frame computation based on level

2020-04-17 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > Josh Brewster > Hi Linjie, thanks for the feedback. I have changed the patch to use the right > parameter. I only made sure that the level was positive because its initial > value was -1. > > else if (x4->params.i_level_idc >= 0) { > Let me know if I need to rej

[FFmpeg-devel] [PATCH v2] avcodec/bsf: simplify the code

2020-04-17 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/bsf.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c index b9fc771..3cacbd4 100644 --- a/libavcodec/bsf.c +++ b/libavcodec/bsf.c @@ -534,11 +534,7 @@ int av_bsf_list_parse_str

[FFmpeg-devel] [PATCH v1 1/2] avformat/ftp: Fix for invalid use of av_strtok

2020-04-17 Thread lance . lmwang
From: Limin Wang By the av_strtok() description: * On the first call to av_strtok(), s should point to the string to * parse, and the value of saveptr is ignored. In subsequent calls, s * should be NULL, and saveptr should be unchanged since the previous * call. Signed-off-by: Limin Wang --

[FFmpeg-devel] [PATCH v1 2/2] avformat/http: Fix for invalid use of av_strtok

2020-04-17 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/http.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index c941557..20545ed 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -786,6 +786,7 @@ static int pa

[FFmpeg-devel] [PATCH v3 1/3] avcodec/libx265: Fix Uninitialized scalar variable

2020-04-17 Thread lance . lmwang
From: Limin Wang return error if unknown picture type encountered Fixes CID 1457234 Signed-off-by: Limin Wang Signed-off-by: Limin Wang --- haven't merge yet, so rebase to the git master libavcodec/libx265.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/libx265.c b/libav

[FFmpeg-devel] [PATCH v3 2/3] avcodec/libx264: return immediately if encode_nals return 0

2020-04-17 Thread lance . lmwang
From: Limin Wang x264_encoder_encode can return 0 with nnal 0. As a result, encode_nals will return 0. In this condition, it's better to return 0 immediately to avoid the following unneeded pict_type and flags setting. Signed-off-by: Limin Wang --- libavcodec/libx264.c | 3 +++ 1 file changed,

[FFmpeg-devel] [PATCH v3 3/3] avcodec/libx264: return error if unknown picture type encountered

2020-04-17 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/libx264.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index edd343e..3fa2311 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -476,7 +476,8 @@ static in