Re: [FFmpeg-devel] [PATCH v3 3/3] libavcodec/jpeb2000dec.c: Handle non EOC streams

2020-03-28 Thread Carl Eugen Hoyos
Am Sa., 28. März 2020 um 05:19 Uhr schrieb : > > From: Gautam Ramakrishnan > > This patch allows decoding of j2k streams which do > not have an EOC marker. OpenJPEG implements a similar > check. > --- > libavcodec/jpeg2000dec.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff

Re: [FFmpeg-devel] [PATCH v3 3/3] libavcodec/jpeb2000dec.c: Handle non EOC streams

2020-03-28 Thread Gautam Ramakrishnan
On Sat, Mar 28, 2020 at 3:54 PM Carl Eugen Hoyos wrote: > > Am Sa., 28. März 2020 um 05:19 Uhr schrieb : > > > > From: Gautam Ramakrishnan > > > > This patch allows decoding of j2k streams which do > > not have an EOC marker. OpenJPEG implements a similar > > check. > > --- > > libavcodec/jpeg20

Re: [FFmpeg-devel] [PATCH v3 3/3] libavcodec/jpeb2000dec.c: Handle non EOC streams

2020-03-28 Thread Carl Eugen Hoyos
Am Sa., 28. März 2020 um 12:13 Uhr schrieb Gautam Ramakrishnan : > > On Sat, Mar 28, 2020 at 3:54 PM Carl Eugen Hoyos wrote: > > > > Am Sa., 28. März 2020 um 05:19 Uhr schrieb : > > > > > > From: Gautam Ramakrishnan > > > > > > This patch allows decoding of j2k streams which do > > > not have an

Re: [FFmpeg-devel] [PATCH v3 3/3] libavcodec/jpeb2000dec.c: Handle non EOC streams

2020-03-28 Thread Gautam Ramakrishnan
On Sat, Mar 28, 2020 at 4:59 PM Carl Eugen Hoyos wrote: > > Am Sa., 28. März 2020 um 12:13 Uhr schrieb Gautam Ramakrishnan > : > > > > On Sat, Mar 28, 2020 at 3:54 PM Carl Eugen Hoyos wrote: > > > > > > Am Sa., 28. März 2020 um 05:19 Uhr schrieb : > > > > > > > > From: Gautam Ramakrishnan > > >

Re: [FFmpeg-devel] [PATCH v3] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-28 Thread Nicolas George
Andreas Rheinhardt (12020-03-28): > The commit title says that this commit is about fixing a memleak (it btw That is my concern too. > has one "commit" too much in it), whereas most of this patch is about > adding new functionality. Which makes me wonder how you intend to fix > this in the old re

[FFmpeg-devel] [PATCH v4 2/2] libavcodec/jpeg2000dec.c: Handle non EOC streams

2020-03-28 Thread gautamramk
From: Gautam Ramakrishnan This patch allows decoding of j2k streams which do not have an EOC marker. OpenJPEG implements a similar check. --- libavcodec/jpeg2000dec.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c in

[FFmpeg-devel] [PATCH v4 1/2] libavcodec/jpeg2000dec.c: Add functions and modify structs for PPT marker support

2020-03-28 Thread gautamramk
From: Gautam Ramakrishnan This patch adds support for the PPT marker. It breaks down the jpeg2000_decode_packet() function to decode headers and data separately. --- libavcodec/jpeg2000dec.c | 200 +-- 1 file changed, 170 insertions(+), 30 deletions(-) diff -

Re: [FFmpeg-devel] [PATCH v4 2/2] libavcodec/jpeg2000dec.c: Handle non EOC streams

2020-03-28 Thread Carl Eugen Hoyos
Am Sa., 28. März 2020 um 13:28 Uhr schrieb : > > From: Gautam Ramakrishnan > > This patch allows decoding of j2k streams which do > not have an EOC marker. OpenJPEG implements a similar > check. > --- > libavcodec/jpeg2000dec.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > di

[FFmpeg-devel] [PATCH]lavfi/minterpolate: Allow bigger resolutions if SIZE_MAX is big

2020-03-28 Thread Carl Eugen Hoyos
Hi! Attached patch allows to work-around ticket #7140, tested on a system with a lot of memory. Please review, Carl Eugen From c9f21979215660d78dfa3e308acf148094522a02 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 28 Mar 2020 13:46:05 +0100 Subject: [PATCH] lavfi/minterpolate: Allow

Re: [FFmpeg-devel] [PATCH v4 2/2] libavcodec/jpeg2000dec.c: Handle non EOC streams

2020-03-28 Thread Gautam Ramakrishnan
On Sat, Mar 28, 2020 at 6:22 PM Carl Eugen Hoyos wrote: > > Am Sa., 28. März 2020 um 13:28 Uhr schrieb : > > > > From: Gautam Ramakrishnan > > > > This patch allows decoding of j2k streams which do > > not have an EOC marker. OpenJPEG implements a similar > > check. > > --- > > libavcodec/jpeg20

Re: [FFmpeg-devel] [PATCH 03/14] pthread_frame: merge the functionality for normal decoder init and init_thread_copy

2020-03-28 Thread Anton Khirnov
Quoting David Bryant (2020-03-27 23:51:19) > On 3/27/20 5:57 AM, Anton Khirnov wrote: > > The current design, where > > - proper init is called for the first per-thread context > > - first thread's private data is copied into private data for all the > > other threads > > - a "fixup" function is

[FFmpeg-devel] [PATCH v4 2/2] avformat/dashdec: refine adaptionset attribute members

2020-03-28 Thread Steven Liu
all the members is used check all the representation useable. Signed-off-by: Steven Liu --- libavformat/dashdec.c | 203 +- 1 file changed, 199 insertions(+), 4 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 271202b0a5..63ca

[FFmpeg-devel] [PATCH v4 1/2] Revert "avformat/dashdec: refine adaptionset attribute members"

2020-03-28 Thread Steven Liu
This reverts commit e134c20374ee3cbc6d04885d306b02c9871683a2. Signed-off-by: Steven Liu --- libavformat/dashdec.c | 27 --- 1 file changed, 27 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 5bbe5d3985..271202b0a5 100644 --- a/libavformat/da

[FFmpeg-devel] [PATCH v5 1/2] libavcodec/jpeg2000dec.c: Add functions and modify structs for PPT marker support

2020-03-28 Thread gautamramk
From: Gautam Ramakrishnan This patch adds support for the PPT marker. It breaks down the jpeg2000_decode_packet() function to decode headers and data separately. --- libavcodec/jpeg2000dec.c | 200 +-- 1 file changed, 170 insertions(+), 30 deletions(-) diff -

[FFmpeg-devel] [PATCH v5 2/2] libavcodec/jpeg2000dec.c: Handle non EOC streams

2020-03-28 Thread gautamramk
From: Gautam Ramakrishnan This patch allows decoding of j2k streams which do not have an EOC marker. OpenJPEG implements a similar check. --- libavcodec/jpeg2000dec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c i

Re: [FFmpeg-devel] [PATCH V2] avformat: Add Dynacolor MVC Demuxer

2020-03-28 Thread Tom Needham
Hi Michael I have fixed the build errors you mentioned by not inlining those functions so they do not get relocated. Updated patch below. From 4c17850cb2546487d789b86f511a30bdef40f817 Mon Sep 17 00:00:00 2001 From: Tom Needham <06needh...@gmail.com> Date: Sun, 21 Jul 2019 21:11:19 +0100 Subject:

Re: [FFmpeg-devel] [PATCH 02/14] avformat/matroska: clean the structure formatting

2020-03-28 Thread Steve Lhomme
On 2020-03-25 23:24, Andreas Rheinhardt wrote: Steve Lhomme: From: Steve Lhomme Always use a comma at the end, order elements by value. --- libavformat/matroska.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/matroska.h b/libavformat/matroska.h index 9e

Re: [FFmpeg-devel] [PATCH 10/14] avformat/matroskadec: move the elements semantic in a separate file

2020-03-28 Thread Steve Lhomme
On 2020-03-25 3:09, Andreas Rheinhardt wrote: Steve Lhomme: From: Steve Lhomme So the file can be generated from the Matroska Schema. The EbmlSyntax structures are not shared between files. matroska_segments and matroska_cluster_enter also have their size predefined. No functional changes. -

Re: [FFmpeg-devel] [PATCH v5 1/2] libavcodec/jpeg2000dec.c: Add functions and modify structs for PPT marker support

2020-03-28 Thread Michael Niedermayer
On Sat, Mar 28, 2020 at 06:54:58PM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This patch adds support for the PPT marker. It breaks down the > jpeg2000_decode_packet() function to decode headers and data > separately. > --- > libavcodec/jpeg2000dec.c | 200 +++

Re: [FFmpeg-devel] [PATCH v4 2/2] avformat/dashdec: refine adaptionset attribute members

2020-03-28 Thread Nicolas George
Steven Liu (12020-03-28): > all the members is used check all the representation useable. > > Signed-off-by: Steven Liu > --- > libavformat/dashdec.c | 203 +- > 1 file changed, 199 insertions(+), 4 deletions(-) Thanks. I find this version easier to read,

Re: [FFmpeg-devel] [PATCH 06/14] pthread_frame: do not copy a range of AVCodecContext fields at once

2020-03-28 Thread Michael Niedermayer
On Fri, Mar 27, 2020 at 01:57:40PM +0100, Anton Khirnov wrote: > This is extremely fragile against reordering and hides what is actually > being copied. Copy all the fields manually instead. > --- > libavcodec/pthread_frame.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) LGTM thx

Re: [FFmpeg-devel] [PATCH 3/3] lavc/vaapi_encode_h265: add h265 tile encoding support

2020-03-28 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of Fu, > Linjie > Sent: Tuesday, March 24, 2020 10:15 > To: myp...@gmail.com; FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH 3/3] lavc/vaapi_encode_h265: add h265 > tile encoding support > > > From: myp...@gmail.com > > Sent: Mon

[FFmpeg-devel] [PATCH v6 1/2] libavcodec/jpeg2000dec.c: Add functions and modify structs for PPT marker support

2020-03-28 Thread gautamramk
From: Gautam Ramakrishnan This patch adds support for the PPT marker. It breaks down the jpeg2000_decode_packet() function to decode headers and data separately. --- libavcodec/jpeg2000dec.c | 202 +-- 1 file changed, 172 insertions(+), 30 deletions(-) diff -

[FFmpeg-devel] [PATCH v6 2/2] libavcodec/jpeg2000dec.c: Handle non EOC streams

2020-03-28 Thread gautamramk
From: Gautam Ramakrishnan This patch allows decoding of j2k streams which do not have an EOC marker. OpenJPEG implements a similar check. --- libavcodec/jpeg2000dec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c i

Re: [FFmpeg-devel] [PATCH v2 2/2] avfilter: add vf_overlay_cuda

2020-03-28 Thread Timo Rothenpieler
applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 3/3] avfilter/af_adelay: Check sscanf() return value

2020-03-28 Thread Michael Niedermayer
On Sat, Mar 28, 2020 at 08:17:33AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/af_adelay.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/af_adelay.c b/libavfilter/af_adelay.c > index c96477

Re: [FFmpeg-devel] [PATCH v1 2/2] avfilter/vf_showinfo: limit the max number of timecode

2020-03-28 Thread Michael Niedermayer
On Wed, Mar 25, 2020 at 06:45:48PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_showinfo.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BAD

[FFmpeg-devel] [PATCH 4/8] avformat/mux: factorize writing a packet

2020-03-28 Thread Marton Balint
In preparation for N:M bsf support. Signed-off-by: Marton Balint --- libavformat/mux.c | 82 +++ 1 file changed, 47 insertions(+), 35 deletions(-) diff --git a/libavformat/mux.c b/libavformat/mux.c index f68f962a92..8c2d6a8060 100644 --- a/lib

[FFmpeg-devel] [PATCH 1/8] fftools/ffmpeg: also flush encoders which have a variable frame size

2020-03-28 Thread Marton Balint
Signed-off-by: Marton Balint --- fftools/ffmpeg.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index aaaf241314..6cc3c5a14d 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -1913,9 +1913,6 @@ static void flush_encoders(void) }

[FFmpeg-devel] [PATCH 5/8] avformat/mux: add proper support for full N:M bitstream filtering

2020-03-28 Thread Marton Balint
Previously only 1:1 bitstream filters were supported, the end of the stream was not signalled to the bitstream filters and time base changes were ignored. Signed-off-by: Marton Balint --- libavformat/internal.h | 1 + libavformat/mux.c | 128 ++-

[FFmpeg-devel] [PATCH 3/8] avformat/mux: factorize interleaved write_packet

2020-03-28 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mux.c | 58 +++ 1 file changed, 24 insertions(+), 34 deletions(-) diff --git a/libavformat/mux.c b/libavformat/mux.c index dfb21c8aa5..f68f962a92 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.

[FFmpeg-devel] [PATCH 2/8] avformat/mux: fix check_packet with null packet

2020-03-28 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mux.c b/libavformat/mux.c index bfd1bf491b..dfb21c8aa5 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.c @@ -798,7 +798,7 @@ static int prepare_input_packet(AVFo

[FFmpeg-devel] [PATCH 6/8] avformat/mux: do not destroy packets of av_write_frame on bitstream filtering

2020-03-28 Thread Marton Balint
av_write_frame() does not take ownership of the packet. Signed-off-by: Marton Balint --- libavformat/mux.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavformat/mux.c b/libavformat/mux.c index 3054ab8644..706fdcbbf4 100644 --- a/libavformat/mux.c +++ b/libav

[FFmpeg-devel] [PATCH 7/8] avcodec/pcm_rechunk_bsf: add bitstream filter to rechunk pcm audio

2020-03-28 Thread Marton Balint
Signed-off-by: Marton Balint --- Changelog | 1 + doc/bitstream_filters.texi | 30 ++ libavcodec/Makefile| 1 + libavcodec/bitstream_filters.c | 1 + libavcodec/pcm_rechunk_bsf.c | 206 + libavcodec/version.

[FFmpeg-devel] [PATCH 8/8] avformat/audiointerleave: only keep the retime functionality of the audio interleaver

2020-03-28 Thread Marton Balint
And rename it to retimeinterleave, use the pcm_rechunk bitstream filter for rechunking. By seperating the two functions we hopefully get cleaner code. Signed-off-by: Marton Balint --- configure | 2 + libavformat/Makefile

Re: [FFmpeg-devel] [PATCH 2/8] avformat/mux: fix check_packet with null packet

2020-03-28 Thread Andreas Rheinhardt
Marton Balint: > Signed-off-by: Marton Balint > --- > libavformat/mux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/mux.c b/libavformat/mux.c > index bfd1bf491b..dfb21c8aa5 100644 > --- a/libavformat/mux.c > +++ b/libavformat/mux.c > @@ -798,7 +798,7 @@ s

Re: [FFmpeg-devel] [PATCH 03/14] pthread_frame: merge the functionality for normal decoder init and init_thread_copy

2020-03-28 Thread David Bryant
On 3/28/20 6:23 AM, Anton Khirnov wrote: > Quoting David Bryant (2020-03-27 23:51:19) >> On 3/27/20 5:57 AM, Anton Khirnov wrote: >>> The current design, where >>> - proper init is called for the first per-thread context >>> - first thread's private data is copied into private data for all the >>>

Re: [FFmpeg-devel] [PATCH v2 2/3] avfilter/vf_mix: Check sscanf() return value

2020-03-28 Thread Nicolas George
lance.lmw...@gmail.com (12020-03-28): > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_mix.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Why? What do you expect to change with this patch, and how is it supposed to be better? Regards, -- Nicolas George

Re: [FFmpeg-devel] [PATCH 6/8] avformat/mux: do not destroy packets of av_write_frame on bitstream filtering

2020-03-28 Thread Andreas Rheinhardt
Marton Balint: > av_write_frame() does not take ownership of the packet. > > Signed-off-by: Marton Balint > --- > libavformat/mux.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/libavformat/mux.c b/libavformat/mux.c > index 3054ab8644..706fdcbbf4 100644 >

[FFmpeg-devel] [PATCH 2/2] avcodec/hcadec: Check scale_factors

2020-03-28 Thread Michael Niedermayer
Fixes: out of array read Fixes: 21286/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HCA_fuzzer-5683183715876864 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/hcadec.c | 1 + 1 file chang

[FFmpeg-devel] [PATCH 1/2] avcodec/hapdec: Check tex_size more strictly and before using it

2020-03-28 Thread Michael Niedermayer
Fixes: OOM Fixes: 20774/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HAP_fuzzer-5678608951803904 Fixes: 20956/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HAP_fuzzer-5713643025203200 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Si

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/hcadec: Check scale_factors

2020-03-28 Thread Paul B Mahol
LGTM On 3/28/20, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: > 21286/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HCA_fuzzer-5683183715876864 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH 5/8] avformat/mux: add proper support for full N:M bitstream filtering

2020-03-28 Thread Andreas Rheinhardt
Marton Balint: > Previously only 1:1 bitstream filters were supported, the end of the stream > was > not signalled to the bitstream filters and time base changes were ignored. > > Signed-off-by: Marton Balint > --- > libavformat/internal.h | 1 + > libavformat/mux.c | 128 >

Re: [FFmpeg-devel] [PATCH 8/8] avformat/audiointerleave: only keep the retime functionality of the audio interleaver

2020-03-28 Thread James Almer
On 3/28/2020 3:15 PM, Marton Balint wrote: > +static int mxf_check_bitstream(struct AVFormatContext *s, const AVPacket > *pkt) > +{ > +int ret = 1; > +AVStream *st = s->streams[pkt->stream_index]; > +MXFStreamContext *sc = st->priv_data; > + > +if (st->codecpar->codec_type == AVMED

Re: [FFmpeg-devel] [PATCH 8/8] avformat/audiointerleave: only keep the retime functionality of the audio interleaver

2020-03-28 Thread Marton Balint
On Sat, 28 Mar 2020, James Almer wrote: On 3/28/2020 3:15 PM, Marton Balint wrote: +static int mxf_check_bitstream(struct AVFormatContext *s, const AVPacket *pkt) +{ +int ret = 1; +AVStream *st = s->streams[pkt->stream_index]; +MXFStreamContext *sc = st->priv_data; + +if (st->

Re: [FFmpeg-devel] [PATCH 2/8] avformat/mux: fix check_packet with null packet

2020-03-28 Thread Marton Balint
On Sat, 28 Mar 2020, Andreas Rheinhardt wrote: Marton Balint: Signed-off-by: Marton Balint --- libavformat/mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mux.c b/libavformat/mux.c index bfd1bf491b..dfb21c8aa5 100644 --- a/libavformat/mux.c +++ b/libavf

Re: [FFmpeg-devel] [PATCH 6/8] avformat/mux: do not destroy packets of av_write_frame on bitstream filtering

2020-03-28 Thread Marton Balint
On Sat, 28 Mar 2020, Andreas Rheinhardt wrote: Marton Balint: av_write_frame() does not take ownership of the packet. Signed-off-by: Marton Balint --- libavformat/mux.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavformat/mux.c b/libavformat/mux.c ind

Re: [FFmpeg-devel] [PATCH v2 2/3] avfilter/vf_mix: Check sscanf() return value

2020-03-28 Thread Limin Wang
On Sat, Mar 28, 2020 at 08:10:51PM +0100, Nicolas George wrote: > lance.lmw...@gmail.com (12020-03-28): > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/vf_mix.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > Why? What do you expect to change with

Re: [FFmpeg-devel] [PATCH v2 2/3] avfilter/vf_mix: Check sscanf() return value

2020-03-28 Thread Nicolas George
Limin Wang (12020-03-29): > If av_sscanf failed, s->weights[i] is invalid data and can't be used > further. I think you are mistaken: if av_sscanf() fails, s->weights[i] stays unchanged: it was 0, it's still 0. > As the old code allow to use the last weights, so I use > continue to avoid invali

Re: [FFmpeg-devel] [PATCH v3] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-28 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12020-03-28): >> The commit title says that this commit is about fixing a memleak (it btw > > That is my concern too. > >> has one "commit" too much in it), whereas most of this patch is about >> adding new functionality. Which makes me wonder how you intend

Re: [FFmpeg-devel] [PATCH v4 1/2] Revert "avformat/dashdec: refine adaptionset attribute members"

2020-03-28 Thread Andreas Rheinhardt
Steven Liu: > This reverts commit e134c20374ee3cbc6d04885d306b02c9871683a2. > > Signed-off-by: Steven Liu > --- > libavformat/dashdec.c | 27 --- > 1 file changed, 27 deletions(-) > > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c > index 5bbe5d3985..271202b0

Re: [FFmpeg-devel] [PATCH v4 1/2] Revert "avformat/dashdec: refine adaptionset attribute members"

2020-03-28 Thread Steven Liu
> 2020年3月29日 上午7:48,Andreas Rheinhardt 写道: > > Steven Liu: >> This reverts commit e134c20374ee3cbc6d04885d306b02c9871683a2. >> >> Signed-off-by: Steven Liu >> --- >> libavformat/dashdec.c | 27 --- >> 1 file changed, 27 deletions(-) >> >> diff --git a/libavformat/dashd

Re: [FFmpeg-devel] [PATCH v4 1/2] Revert "avformat/dashdec: refine adaptionset attribute members"

2020-03-28 Thread Andreas Rheinhardt
Steven Liu: > > >> 2020年3月29日 上午7:48,Andreas Rheinhardt 写道: >> >> Steven Liu: >>> This reverts commit e134c20374ee3cbc6d04885d306b02c9871683a2. >>> >>> Signed-off-by: Steven Liu >>> --- >>> libavformat/dashdec.c | 27 --- >>> 1 file changed, 27 deletions(-) >>> >>> diff -

Re: [FFmpeg-devel] [PATCH v4 1/2] Revert "avformat/dashdec: refine adaptionset attribute members"

2020-03-28 Thread Steven Liu
> 2020年3月29日 上午8:03,Andreas Rheinhardt 写道: > > Steven Liu: >> >> >>> 2020年3月29日 上午7:48,Andreas Rheinhardt 写道: >>> >>> Steven Liu: This reverts commit e134c20374ee3cbc6d04885d306b02c9871683a2. Signed-off-by: Steven Liu --- libavformat/dashdec.c | 27 ---

Re: [FFmpeg-devel] [PATCH v2 2/3] avfilter/vf_mix: Check sscanf() return value

2020-03-28 Thread Limin Wang
On Sun, Mar 29, 2020 at 12:31:40AM +0100, Nicolas George wrote: > Limin Wang (12020-03-29): > > If av_sscanf failed, s->weights[i] is invalid data and can't be used > > further. > > I think you are mistaken: if av_sscanf() fails, s->weights[i] stays > unchanged: it was 0, it's still 0. > > > As

[FFmpeg-devel] [PATCH v3 3/3] avfilter/af_adelay: Check sscanf() return value

2020-03-28 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/af_adelay.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_adelay.c b/libavfilter/af_adelay.c index c964777..6ac81c2 100644 --- a/libavfilter/af_adelay.c +++ b/libavfilter/af_adelay.c @@ -155,7 +1

[FFmpeg-devel] [PATCH v3 1/3] avfilter/af_acrossover: Check sscanf() return value

2020-03-28 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/af_acrossover.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_acrossover.c b/libavfilter/af_acrossover.c index f70c50b..002f378 100644 --- a/libavfilter/af_acrossover.c +++ b/libavfilter/af_acros

Re: [FFmpeg-devel] [PATCH v2 3/3] avfilter/af_adelay: Check sscanf() return value

2020-03-28 Thread Limin Wang
On Sat, Mar 28, 2020 at 07:06:13PM +0100, Michael Niedermayer wrote: > On Sat, Mar 28, 2020 at 08:17:33AM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/af_adelay.c | 5 - > > 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH v4 1/2] Revert "avformat/dashdec: refine adaptionset attribute members"

2020-03-28 Thread Steven Liu
> 2020年3月29日 上午8:05,Steven Liu 写道: > > >> 2020年3月29日 上午8:03,Andreas Rheinhardt 写道: >> >> Steven Liu: >>> >>> 2020年3月29日 上午7:48,Andreas Rheinhardt 写道: Steven Liu: > This reverts commit e134c20374ee3cbc6d04885d306b02c9871683a2. > > Signed-off-by: Steven Liu >>>

Re: [FFmpeg-devel] [PATCH v4 1/2] Revert "avformat/dashdec: refine adaptionset attribute members"

2020-03-28 Thread Andreas Rheinhardt
Steven Liu: > > >> 2020年3月29日 上午8:03,Andreas Rheinhardt 写道: >> >> Steven Liu: >>> >>> 2020年3月29日 上午7:48,Andreas Rheinhardt 写道: Steven Liu: > This reverts commit e134c20374ee3cbc6d04885d306b02c9871683a2. > > Signed-off-by: Steven Liu > --- > libavformat/dashde

Re: [FFmpeg-devel] [PATCH v4 1/2] Revert "avformat/dashdec: refine adaptionset attribute members"

2020-03-28 Thread Steven Liu
> 2020年3月29日 上午8:12,Andreas Rheinhardt 写道: > > Steven Liu: >> >> >>> 2020年3月29日 上午8:03,Andreas Rheinhardt 写道: >>> >>> Steven Liu: > 2020年3月29日 上午7:48,Andreas Rheinhardt 写道: > > Steven Liu: >> This reverts commit e134c20374ee3cbc6d04885d306b02c9871683a2. >>

Re: [FFmpeg-devel] [PATCH v4 1/2] Revert "avformat/dashdec: refine adaptionset attribute members"

2020-03-28 Thread Andreas Rheinhardt
Steven Liu: > > >> 2020年3月29日 上午8:05,Steven Liu 写道: >> >> >>> 2020年3月29日 上午8:03,Andreas Rheinhardt 写道: >>> >>> Steven Liu: > 2020年3月29日 上午7:48,Andreas Rheinhardt 写道: > > Steven Liu: >> This reverts commit e134c20374ee3cbc6d04885d306b02c9871683a2. >> >> Signed-

Re: [FFmpeg-devel] [PATCH v4 1/2] Revert "avformat/dashdec: refine adaptionset attribute members"

2020-03-28 Thread Steven Liu
> 2020年3月29日 上午8:20,Andreas Rheinhardt 写道: > > Steven Liu: >> >> >>> 2020年3月29日 上午8:05,Steven Liu 写道: >>> >>> 2020年3月29日 上午8:03,Andreas Rheinhardt 写道: Steven Liu: > > >> 2020年3月29日 上午7:48,Andreas Rheinhardt 写道: >> >> Steven Liu: >>> This reverts

Re: [FFmpeg-devel] [PATCH v4 1/2] Revert "avformat/dashdec: refine adaptionset attribute members"

2020-03-28 Thread Andreas Rheinhardt
Steven Liu: > > >> 2020年3月29日 上午8:12,Andreas Rheinhardt 写道: >> >> Steven Liu: >>> >>> 2020年3月29日 上午8:03,Andreas Rheinhardt 写道: Steven Liu: > > >> 2020年3月29日 上午7:48,Andreas Rheinhardt 写道: >> >> Steven Liu: >>> This reverts commit e134c20374ee3cbc6d04885d30

Re: [FFmpeg-devel] [PATCH v4 1/2] Revert "avformat/dashdec: refine adaptionset attribute members"

2020-03-28 Thread Steven Liu
> 2020年3月29日 上午8:24,Andreas Rheinhardt 写道: > > Steven Liu: >> >> >>> 2020年3月29日 上午8:12,Andreas Rheinhardt 写道: >>> >>> Steven Liu: > 2020年3月29日 上午8:03,Andreas Rheinhardt 写道: > > Steven Liu: >> >> >>> 2020年3月29日 上午7:48,Andreas Rheinhardt 写道: >>> >

Re: [FFmpeg-devel] [PATCH v4 1/2] Revert "avformat/dashdec: refine adaptionset attribute members"

2020-03-28 Thread Steven Liu
> 2020年3月29日 上午8:24,Andreas Rheinhardt 写道: > > Steven Liu: >> >> >>> 2020年3月29日 上午8:12,Andreas Rheinhardt 写道: >>> >>> Steven Liu: > 2020年3月29日 上午8:03,Andreas Rheinhardt 写道: > > Steven Liu: >> >> >>> 2020年3月29日 上午7:48,Andreas Rheinhardt 写道: >>> >

[FFmpeg-devel] [PATCH v2] avformat/dashdec: Don't allocate and leak strings that are never used

2020-03-28 Thread Andreas Rheinhardt
Since commit e134c203 strdups of several elements of a manifest are kept in the DASHContext; but said commit completely forgot to free these strings again (with xmlFree()). Given that these strings are never used at all, this commit closes this leak by reverting said commit. This reverts commit e1

Re: [FFmpeg-devel] [PATCH v2 2/3] avfilter/vf_mix: Check sscanf() return value

2020-03-28 Thread Nicolas George
Limin Wang (12020-03-29): > Anyway if the user option is typo, > the result may be unexpected for user. But your change does not address that. For that, you would print a message and return an error. Which is probably the right thing to do, actually. Regards, -- Nicolas George signature.a

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: Don't allocate and leak strings that are never used

2020-03-28 Thread Steven Liu
> 2020年3月14日 上午3:14,Andreas Rheinhardt 写道: > > Since commit e134c203 strdups of several elements of a manifest are kept > in the DASHContext; but said commit completely forgot to free these > strings again (with xmlFree()). Given that these strings are never used > at all, this commit closes th

Re: [FFmpeg-devel] [PATCH v2] avformat/dashdec: Don't allocate and leak strings that are never used

2020-03-28 Thread Steven Liu
> 2020年3月29日 上午8:32,Andreas Rheinhardt 写道: > > Since commit e134c203 strdups of several elements of a manifest are kept > in the DASHContext; but said commit completely forgot to free these > strings again (with xmlFree()). Given that these strings are never used > at all, this commit closes th

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-03-28 Thread Carl Eugen Hoyos
Am Fr., 27. März 2020 um 15:25 Uhr schrieb Zane van Iperen : > > On Wed, 18 Mar 2020 15:19:19 +0100 > "Carl Eugen Hoyos" wrote: > > > > Any restrictions on track_count and sample_rate that can be used for > > auto-detection? > > > > I've done a preliminary probe function. How's this? > > On all th

[FFmpeg-devel] [PATCH] avformat/dashdec: add attribute lang for audio and subtitle streams

2020-03-28 Thread Steven Liu
There should have lang in the metadata of streams which show to user Signed-off-by: Steven Liu --- libavformat/dashdec.c | 49 +++ 1 file changed, 45 insertions(+), 4 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 271202b0a5

[FFmpeg-devel] [PATCH v3 2/3] avfilter/vf_mix: Check sscanf() return value

2020-03-28 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_mix.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_mix.c b/libavfilter/vf_mix.c index 9e1ae79..9bb1b7a 100644 --- a/libavfilter/vf_mix.c +++ b/libavfilter/vf_mix.c @@ -108,7 +108,10 @@ static

Re: [FFmpeg-devel] [PATCH v2 2/3] avfilter/vf_mix: Check sscanf() return value

2020-03-28 Thread Limin Wang
On Sun, Mar 29, 2020 at 01:32:59AM +0100, Nicolas George wrote: > Limin Wang (12020-03-29): > > Anyway if the user option is typo, > > the result may be unexpected for user. > > But your change does not address that. For that, you would print a > message and return an error. Which is probably th

Re: [FFmpeg-devel] [PATCH 1/3] avformat/avformat: Update av_read_frame() documentation

2020-03-28 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Anton Khirnov: >> Quoting Andreas Rheinhardt (2019-12-01 11:05:44) >>> This commit updates the documentation of av_read_frame() to match its >>> actual behaviour in several ways: >>> >>> 1. On success, av_read_frame() always returns refcounted packets. >>> 2. It can handle uni

[FFmpeg-devel] [PATCH] avformat/hlsenc: skip first char after compare path with path separator

2020-03-28 Thread Steven Liu
before patch: ffmpeg -i input -g 25 -y -c:a aac -map 0:v -map 0:a -master_pl_name playlist.m3u8 -var_stream_map "v:0,a:0" c%v.m3u8" the master file playlist.m3u8 context is #EXTM3U #EXT-X-VERSION:3 #EXT-X-STREAM-INF:BANDWIDTH=2890800,RESOLUTION=1920x800,CODECS="avc1.640028,mp4a.40.2"

[FFmpeg-devel] [PATCH] avformat/mxfdec: Correct confusing struct tag

2020-03-28 Thread Andreas Rheinhardt
Don't use typedef struct MXFTrack {...} MXFTimecodeComponent, in particular given the fact that MXFTrack is a type of its own. Signed-off-by: Andreas Rheinhardt --- libavformat/mxfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.

[FFmpeg-devel] [PATCH] avutil/opt: Don't use NULL for %s string in a log message

2020-03-28 Thread Andreas Rheinhardt
If one calls av_opt_set() with an incorrect string to set the value of an option of type AV_OPT_TYPE_VIDEO_RATE, the given string is used in a log message via %s. This also happens when the string is actually a nullpointer in which case using it for %s is forbidden. This commit changes this by err