Re: [FFmpeg-devel] [PATCH] [PATCH] POWER8 VSX vectorization libswscale/input.c Track ticket 5570

2020-03-25 Thread Pestov Vyacheslav
On 25.03.2020 1:12, Carl Eugen Hoyos wrote: > Am Di., 24. März 2020 um 14:28 Uhr schrieb Pestov Vyacheslav > : >> yuy2ToY_c: 10157 >> yuy2ToY_c_vsx: 2353 >> >> yuy2ToUV_c: 4907 >> yuy2ToUV_c_vsx: 1357 >> >> rgb24ToY_c: 21172 >> rgb24ToY_c_vsx: 9191 >> >> rgb24ToUV_c: 33568 >> rgb24ToUV_c_vsx: 1274

[FFmpeg-devel] [PATCH v1 1/2] avfilter/vf_showinfo: check if the s12m data size is valid

2020-03-25 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_showinfo.c | 4 1 file changed, 4 insertions(+) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 79b79db2d3..71534d1fa8 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_showinfo.c @@ -318,6 +3

[FFmpeg-devel] [PATCH v1 2/2] avfilter/vf_showinfo: limit the max number of timecode

2020-03-25 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_showinfo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 71534d1fa8..b0b0051357 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_showin

[FFmpeg-devel] [PATCH] libavcodec/jpeg2000.h: fix comments for JPEG2000 markers

2020-03-25 Thread gautamramk
From: Gautam Ramakrishnan The comments for some of the markers were incorrect. This patch fixes the comments associated with the markers. --- libavcodec/jpeg2000.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/jpeg2000.h b/libavcodec/jpeg2000.h index c

Re: [FFmpeg-devel] [PATCH v2] avformat/matroskaenc: Write level 1 elements in one go

2020-03-25 Thread Carl Eugen Hoyos
Am Mi., 25. März 2020 um 05:45 Uhr schrieb Andreas Rheinhardt : > > Up until now, writing level 1 elements proceeded as follows: First, the > element id was written to the ordinary output AVIOContext and a dynamic > buffer was opened for the content of the level 1 element in > start_ebml_master_crc

Re: [FFmpeg-devel] [PATCH v2] avformat/matroskaenc: Write level 1 elements in one go

2020-03-25 Thread James Almer
On 3/25/2020 1:44 AM, Andreas Rheinhardt wrote: > Up until now, writing level 1 elements proceeded as follows: First, the > element id was written to the ordinary output AVIOContext and a dynamic > buffer was opened for the content of the level 1 element in > start_ebml_master_crc32(). Then this bu

Re: [FFmpeg-devel] [PATCH v2] avformat/matroskaenc: Write level 1 elements in one go

2020-03-25 Thread Andreas Rheinhardt
Carl Eugen Hoyos: > Am Mi., 25. März 2020 um 05:45 Uhr schrieb Andreas Rheinhardt > : >> >> Up until now, writing level 1 elements proceeded as follows: First, the >> element id was written to the ordinary output AVIOContext and a dynamic >> buffer was opened for the content of the level 1 element

Re: [FFmpeg-devel] [PATCH v1 1/4] avcodec/xsubdec: replace data_size with got_sub_ptr for better readability

2020-03-25 Thread Michael Niedermayer
On Tue, Mar 24, 2020 at 07:05:16PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/xsubdec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) will apply patchset thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: error check when processing tlm marker

2020-03-25 Thread Michael Niedermayer
On Wed, Mar 25, 2020 at 08:15:11AM +0530, Gautam Ramakrishnan wrote: > That was an extremely careless error. Apologies for that. Shall fix > that immediately. However, is changing the return type of get_tlm() > the right way? its probably a good idea to change the return type to int thanks [...

[FFmpeg-devel] [PATCH] avformat/movenc: Reduce size of the allocated MOVIentry array

2020-03-25 Thread James Almer
Increase it in a linear way instead. Helps reduce memory usage, especially on long, non fragmented output. Signed-off-by: James Almer --- An alternative is using av_fast_realloc(), in a similar fashion as ff_add_index_entry(), which will keep the memory usage more closely tied to the amount of en

[FFmpeg-devel] [PATCH v2] avcodec/jpeg2000dec: error check when processing tlm marker

2020-03-25 Thread gautamramk
From: Gautam Ramakrishnan Validate the value of ST field in the TLM marker of JPEG2000. Throw an error when ST takes value of 0x11. --- libavcodec/jpeg2000dec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c index 0

Re: [FFmpeg-devel] [PATCH v2] avformat/matroskaenc: Write level 1 elements in one go

2020-03-25 Thread Carl Eugen Hoyos
Am Mi., 25. März 2020 um 18:08 Uhr schrieb Andreas Rheinhardt : > > Carl Eugen Hoyos: > > Am Mi., 25. März 2020 um 05:45 Uhr schrieb Andreas Rheinhardt > > : > >> > >> Up until now, writing level 1 elements proceeded as follows: First, the > >> element id was written to the ordinary output AVIOCont

Re: [FFmpeg-devel] [PATCH 01/14] avformat/matroska: add missing Buttons track type

2020-03-25 Thread Andreas Rheinhardt
Steve Lhomme: > From: Steve Lhomme > > --- > libavformat/matroska.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/matroska.h b/libavformat/matroska.h > index 86968a8de1..9e33e51c94 100644 > --- a/libavformat/matroska.h > +++ b/libavformat/matroska.h > @@ -271,6 +271,7 @@

Re: [FFmpeg-devel] [PATCH] Check return value from avio_read() to verify data actually read

2020-03-25 Thread John Rummell
> > These would cause mov_read_adrm() to fail but not neccessarily return an > error code if any of these reads less. > Is that intended ? Not at all. Updated to always return AVERROR_INVALIDDATA. On Tue, Mar 24, 2020 at 6:00 PM Michael Niedermayer wrote: > On Mon, Mar 23, 2020 at 05:52:01PM -

Re: [FFmpeg-devel] [PATCH 02/14] avformat/matroska: clean the structure formatting

2020-03-25 Thread Andreas Rheinhardt
Steve Lhomme: > From: Steve Lhomme > > Always use a comma at the end, order elements by value. > --- > libavformat/matroska.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/matroska.h b/libavformat/matroska.h > index 9e33e51c94..e177cd027f 100644 > ---

Re: [FFmpeg-devel] [PATCH] avformat/webmdashenc: Don't use custom option for bitexactness

2020-03-25 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Andreas Rheinhardt: >> The WebM DASH Manifest muxer can write manifests for live streams and >> these contain an entry that depends on the time the manifest is written; >> an AVOption to make the output reproducible has been added for tests. >> But this is unnecessary, as ther

[FFmpeg-devel] [PATCH v1 2/3] avfilter/vf_mix: Check sscanf() return value

2020-03-25 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_mix.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_mix.c b/libavfilter/vf_mix.c index 9e1ae79e00..e47f7e2301 100644 --- a/libavfilter/vf_mix.c +++ b/libavfilter/vf_mix.c @@ -108,7 +108,8 @@ sta

[FFmpeg-devel] [PATCH v1 3/3] avfilter/af_adelay: Check sscanf() return value

2020-03-25 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/af_adelay.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_adelay.c b/libavfilter/af_adelay.c index c9647771f2..7f498ba190 100644 --- a/libavfilter/af_adelay.c +++ b/libavfilter/af_adelay.c @@ -155,

[FFmpeg-devel] [PATCH]configure: Remove all C standard versions from the MSVC command line

2020-03-25 Thread Carl Eugen Hoyos
Hi! Attached patch removes an ugly warning shown for every file when using clang-cl.exe. Please comment, Carl Eugen From 61a07641e2babbb3bc0ad6375d1cb9934f8b434a Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 25 Mar 2020 23:59:11 +0100 Subject: [PATCH] configure: Remove all C standar

[FFmpeg-devel] [PATCH]configure: Get the correct ident for clang-cl.exe

2020-03-25 Thread Carl Eugen Hoyos
Hi! Attached patch avoids that ffmpeg claims its compiler was "No input file" when using clang-cl. Please comment, Carl Eugen From 659397c2ef2881cc5a5c99597aab5946a8f28c43 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Thu, 26 Mar 2020 00:00:10 +0100 Subject: [PATCH] configure: Get the co

[FFmpeg-devel] [PATCH v1 1/3] avfilter/af_acrossover: Check sscanf() return value

2020-03-25 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/af_acrossover.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_acrossover.c b/libavfilter/af_acrossover.c index 20d1d2bda9..c9404b95cd 100644 --- a/libavfilter/af_acrossover.c +++ b/libavfilter/af_a

[FFmpeg-devel] [PATCH 1/3] avformat/matroskadec: Don't discard the upper 32bits of TrackNumber

2020-03-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- This has already been sent in [1]; I'm resending it because it fits here. [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2019-December/254841.html libavformat/matroskadec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/

[FFmpeg-devel] [PATCH 3/3] avformat/matroskadec: Improve forward compability

2020-03-25 Thread Andreas Rheinhardt
Matroska is built around the principle that a reader does not need to understand everything in a file in order to be able to make use of it; it just needs to ignore the data it doesn't know about. Our demuxer typically follows this principle, but there is one important instance where it does not:

[FFmpeg-devel] [PATCH 2/3] avformat/matroskadec: Don't discard valid packets

2020-03-25 Thread Andreas Rheinhardt
A Block (meaning both a Block in a BlockGroup as well as a SimpleBlock) must have at least three bytes after the field containing the encoded TrackNumber. So a if there are <= 3 bytes, the Matroska demuxer would skip this block, believing it to be an empty, but valid Block. This might discard vali

Re: [FFmpeg-devel] [PATCH 05/17] avformat/webm_chunk: Don't use child AVFormatContext for logging

2020-03-25 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Andreas Rheinhardt: >> Signed-off-by: Andreas Rheinhardt >> --- >> libavformat/webm_chunk.c | 7 +++ >> 1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/libavformat/webm_chunk.c b/libavformat/webm_chunk.c >> index bc3d346a00..0d4e3598ed 100644 >> --- a/

[FFmpeg-devel] [PATCH 1/3] avformat/matroskadec: Add a workaround for missing WavPack extradata

2020-03-25 Thread Andreas Rheinhardt
mkvmerge versions 6.2 to 40.0 had a bug that made it not propagate the WavPack extradata (containing the WavPack version) during remuxing from a Matroska file; currently our demuxer would treat every WavPack block encountered as invalid data (unless the WavPack stream is to be discarded (i.e. the s

[FFmpeg-devel] [PATCH 3/3] avformat/matroskaenc: Update the default version of WavPack

2020-03-25 Thread Andreas Rheinhardt
The Matroska muxer currently assumed WavPack version 4.03 in case it was not explicitly signalled via extradata; but following a recommendation by David Bryant, the WavPack creator, this is changed to 4.10. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 2 +- 1 file changed, 1

[FFmpeg-devel] [PATCH 2/3] avformat/wvdec: Export version as extradata

2020-03-25 Thread Andreas Rheinhardt
It might be used by the Matroska muxer. This is also the reason why the FATE-tests for muxing WavPack into Matroska needed to be updated: They now write the correct version 4.07 and not 4.03 as before. Signed-off-by: Andreas Rheinhardt --- libavformat/wvdec.c| 3 +++ tests/fate/wavpack.mak |

[FFmpeg-devel] [PATCH] Add support for playing Audible AAXC (.aaxc) files

2020-03-25 Thread Vesselin Bontchev
From 1a6adbf86fd02775bea467a54c81cc23cc2f6049 Mon Sep 17 00:00:00 2001 From: Vesselin Bontchev Date: Sat, 1 Jan 2000 09:00:00 + Subject: [PATCH] Add support for playing Audible AAXC (.aaxc) files Note: audible_key and audible_iv values are variable (per file) and are externally fed. It is po

[FFmpeg-devel] [PATCH v3] avcodec/jpeg2000dec: error check when processing tlm marker

2020-03-25 Thread gautamramk
From: Gautam Ramakrishnan Validate the value of ST field in the TLM marker of JPEG2000. Throw an error when ST takes value of 0b11. --- libavcodec/jpeg2000dec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c index 0

Re: [FFmpeg-devel] [PATCH 07/14] avformat/matroskadec: fix the type of the TrackLanguage

2020-03-25 Thread Andreas Rheinhardt
Steve Lhomme: > From: Steve Lhomme > > It's an ASCII string, not a UTF-8 string. > --- > libavformat/matroskadec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c > index 4d7fdab99f..383869bced 100644 > --- a/libavfo