Am Fr., 20. März 2020 um 01:49 Uhr schrieb Michael Niedermayer
:
>
> On Thu, Mar 19, 2020 at 10:18:33PM +0100, Carl Eugen Hoyos wrote:
> > Am Do., 19. März 2020 um 19:32 Uhr schrieb Michael Niedermayer
> > :
> > >
> > > On Wed, Mar 18, 2020 at 02:16:30AM +0100, Carl Eugen Hoyos wrote:
> > > > Hi!
>
Quoting Andreas Rheinhardt (2020-03-18 17:10:37)
> Anton Khirnov:
> > Quoting Andreas Rheinhardt (2020-03-17 22:31:46)
> >> This happened for AVBSFContext.
> >>
> >> Signed-off-by: Andreas Rheinhardt
> >> ---
> > Maybe ok. Not sure if it's better to drop it because it's unused or keep
> > it in ca
Quoting Steven Liu (2020-03-19 00:30:52)
>
> Thanks
>
> Steven Liu
>
> > 2020年3月19日 上午12:48，Andreas Rheinhardt 写道：
> >
> > Hello,
> >
> > before the actual review I want to tell you that I actually agree with
> > Nicholas. I don't see the point of already parsing stuff that is not
> > used ye
lgtm
On 3/20/20, Michael Niedermayer wrote:
> Fixes: out of array access
> Fixes:
> 21193/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-5125168956702720
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Mi
Quoting Michael Niedermayer (2020-03-20 01:03:36)
> Fixes: out of array access
> Fixes:
> 21193/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-5125168956702720
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off
Quoting Andreas Rheinhardt (2020-03-18 14:41:23)
> This commit fixes the names and constants of the reserved NAL units
> with nal_unit_type 22 resp. 23. They were "IRAP_IRAP_VLC2x", but are
> actually "RSV_IRAP_VLC2x".
>
> This also required a change to cbs_h265_syntax_template.c.
>
> Signed-off-
Quoting Michael Niedermayer (2020-03-17 01:09:51)
> Fixes: signed integer overflow: 2 * 1210064928 cannot be represented in type
> 'int'
> Fixes:
> 20873/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5761116909338624
>
> Found-by: continuous fuzzing process
> https://github.com/google/os
> 2020年3月20日 下午4:34，Anton Khirnov 写道：
>
> Quoting Steven Liu (2020-03-19 00:30:52)
>>
>> Thanks
>>
>> Steven Liu
>>
>>> 2020年3月19日 上午12:48，Andreas Rheinhardt 写道：
>>>
>>> Hello,
>>>
>>> before the actual review I want to tell you that I actually agree with
>>> Nicholas. I don't see the poi
Steven Liu (12020-03-20):
> Why the specification add these attributes into the documents if these
> attributes not useful, just kidding?
> I said I’m not the specification author.
What Anton and I are trying to explain to you is that either your code
handles the attributes according to the speci
> 2020年3月20日 下午6:51，Nicolas George 写道：
>
> Steven Liu (12020-03-20):
>> Why the specification add these attributes into the documents if these
>> attributes not useful, just kidding?
>> I said I’m not the specification author.
>
> What Anton and I are trying to explain to you is that either y
Steven Liu (12020-03-20):
> Do you mean,
I mean you should only propose code that actually does something. That
should be easy to understand: if you store into a variable without using
the value, remove it; then iterate.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
_
> 2020年3月20日 下午7:05，Nicolas George 写道：
>
> Steven Liu (12020-03-20):
>> Do you mean,
>
> I mean you should only propose code that actually does something. That
> should be easy to understand: if you store into a variable without using
> the value, remove it; then iterate.
Ok, I get it, thanks
Steven Liu (12020-03-20):
> These member will be used for get more correct information of the MPD
>
> Suggested-by: Andreas Rheinhardt
> Suggested-by: Nicolas George
> Signed-off-by: Steven Liu
> ---
> libavformat/dashdec.c | 180 +++---
> 1 file changed, 15
On 20.03.20 00:47, Timo Rothenpieler wrote:
I'm looking into adding hardware-frame support to make_writable, so
modifications might not be needed.
Yep it seems to be more consistent if av_frame_make_writable could
support hardware frames.
Please let me know if you are going to do it, or if
On 20.03.2020 12:30, Yaroslav Pogrebnyak wrote:
On 20.03.20 00:47, Timo Rothenpieler wrote:
I'm looking into adding hardware-frame support to make_writable, so
modifications might not be needed.
Yep it seems to be more consistent if av_frame_make_writable could
support hardware frames.
Ple
> 2020年3月20日 下午7:19，Nicolas George 写道：
>
> Steven Liu (12020-03-20):
>> These member will be used for get more correct information of the MPD
>>
>> Suggested-by: Andreas Rheinhardt
>> Suggested-by: Nicolas George
>> Signed-off-by: Steven Liu
>> ---
>> libavformat/dashdec.c | 180 +++
Steven Liu (12020-03-20):
> Which one leak? if xmlGetProp return null, val should null and dose not leak.
Yes, my mistake.
> The end can be null, there can only maxFrameRate=25, or maxFrameRate=60/2.
It is a value from the outside, you can't trust it on pail of security
exploit.
> Just tell the
Steven Liu (12020-03-20):
> To: Nicolas George
Please heed reply-to headers.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-deve
> 2020年3月20日 下午8:25，Nicolas George 写道：
>
>> The end can be null, there can only maxFrameRate=25, or maxFrameRate=60/2.
>
> It is a value from the outside, you can't trust it on pail of security
> exploit.
Yes, av_strtok get the first part and the other part,
And use the strtol get the first pa
Steven Liu (12020-03-20):
> Yes, av_strtok get the first part and the other part,
> And use the strtol get the first part to long, it check the string range, and
> get the endpoint of (not number part.)
> The end is same as the first part.
My exact comment was wrong. The actual problem is that av
On 3/20/2020 10:31 AM, Paul B Mahol wrote:
> +static av_cold int bink2_decode_end(AVCodecContext *avctx)
> +{
> +Bink2Context * const c = avctx->priv_data;
> +
> +av_frame_free(&c->last);
> +av_freep(&c->current_q);
> +av_freep(&c->prev_q);
> +av_freep(&c->current_dc);
> +av
From: Limin Wang
This fixes webvtt segment output.
Please testing with the following command and check the output:
./ffmpeg -i ../fate-suite/sub/MicroDVD_capability_tester.srt -f segment
-segment_time 10 \
-segment_list_size 0 -segment_list sub.m3u8 -segment_format webvtt -scodec
webvtt s
Fixes the use of the implicit declaration
of avpriv_request_sample().
Signed-off-by: Zane van Iperen
---
libavformat/argo_asf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c
index 3339425244..cf1c7472c1 100644
--- a/libavformat/argo_asf.c
+++
On 3/20/20 1:54 AM, Paul B Mahol wrote:
> lgtm
Looks good to me too, sorry about that!
>
> On 3/20/20, Michael Niedermayer wrote:
>> Fixes: out of array access
>> Fixes:
>> 21193/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-5125168956702720
>>
>> Found-by: continuous fuzzing
On Fri, Mar 20, 2020 at 5:45 PM wrote:
>
> From: Limin Wang
>
> This fixes webvtt segment output.
>
> Please testing with the following command and check the output:
> ./ffmpeg -i ../fate-suite/sub/MicroDVD_capability_tester.srt -f segment
> -segment_time 10 \
> -segment_list_size 0 -segmen
Jan Ekström (12020-03-20):
> I do wonder if this is just a case of people forgetting to set the
> flag for the relevant packets in the relevant modules?
>
> I'm not sure if all API users should be forced to handle this
> separately. If the packets are decode'able by themselves, they should
> be ma
On Fri, Mar 20, 2020 at 6:12 PM Nicolas George wrote:
>
> Jan Ekström (12020-03-20):
> > I do wonder if this is just a case of people forgetting to set the
> > flag for the relevant packets in the relevant modules?
> >
> > I'm not sure if all API users should be forced to handle this
> > separatel
> LGTM without comments.
>
> On 3/17/20, numberwolf https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
> ___
> ffmpeg-devel mailing list
> ff
Jan Ekström:
> On Fri, Mar 20, 2020 at 5:45 PM wrote:
>>
>> From: Limin Wang
>>
>> This fixes webvtt segment output.
>>
>> Please testing with the following command and check the output:
>> ./ffmpeg -i ../fate-suite/sub/MicroDVD_capability_tester.srt -f segment
>> -segment_time 10 \
>> -segm
On Fri, Mar 20, 2020 at 9:31 AM Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol
> ---
> configure |1 +
> libavcodec/Makefile |1 +
> libavcodec/allcodecs.c |1 +
> libavcodec/avcodec.h|1 +
> libavcodec/bink2.c | 869
>
On 21/08/2019 10:04, Andreas Rheinhardt wrote:
> +#if FF_API_NONCONST_ENUM_PROTOCOLS
> const char *avio_enum_protocols(void **opaque, int output)
> +#else
> +const char *avio_enum_protocols(const void **opaque, int output)
> +#endif
Do we actually allow breakage like this (even at major bumps)?
On Fri, Mar 20, 2020 at 10:18:49AM +0100, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2020-03-20 01:03:36)
> > Fixes: out of array access
> > Fixes:
> > 21193/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-5125168956702720
> >
> > Found-by: continuous fuzzing process
>
Am Fr., 20. März 2020 um 19:33 Uhr schrieb Derek Buitenhuis
:
>
> On 21/08/2019 10:04, Andreas Rheinhardt wrote:
> > +#if FF_API_NONCONST_ENUM_PROTOCOLS
> > const char *avio_enum_protocols(void **opaque, int output)
> > +#else
> > +const char *avio_enum_protocols(const void **opaque, int output)
>
Am Fr., 20. März 2020 um 16:53 Uhr schrieb Zane van Iperen
:
>
> Fixes the use of the implicit declaration
> of avpriv_request_sample().
I don't see such a warning...
Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/ma
Am Fr., 20. März 2020 um 17:59 Uhr schrieb porscheg...@foxmail.com
:
> > LGTM without comments.
> >
> ping.
Please resend your patch without the comments (and the mail without
the html codes).
Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffm
Derek Buitenhuis:
> On 21/08/2019 10:04, Andreas Rheinhardt wrote:
>> +#if FF_API_NONCONST_ENUM_PROTOCOLS
>> const char *avio_enum_protocols(void **opaque, int output)
>> +#else
>> +const char *avio_enum_protocols(const void **opaque, int output)
>> +#endif
>
> Do we actually allow breakage like
Am Fr., 20. März 2020 um 23:29 Uhr schrieb Andreas Rheinhardt
:
> PS: Actually, there are a couple of functions that need const:
> av_find_best_stream() provides a way to get a pointer to a non-const
> AVCodec (it casts the const away internally); and
> av_input/output_audio/video_device_next() ne
Carl Eugen Hoyos:
> Am Fr., 20. März 2020 um 23:29 Uhr schrieb Andreas Rheinhardt
> :
>
>> PS: Actually, there are a couple of functions that need const:
>> av_find_best_stream() provides a way to get a pointer to a non-const
>> AVCodec (it casts the const away internally); and
>> av_input/output_
On Fri, Mar 20, 2020 at 06:03:53PM +0200, Jan Ekström wrote:
> On Fri, Mar 20, 2020 at 5:45 PM wrote:
> >
> > From: Limin Wang
> >
> > This fixes webvtt segment output.
> >
> > Please testing with the following command and check the output:
> > ./ffmpeg -i ../fate-suite/sub/MicroDVD_capability_te
On Fri, 20 Mar 2020 22:28:28 +0100
"Carl Eugen Hoyos" wrote:
> Am Fr., 20. März 2020 um 16:53 Uhr schrieb Zane van Iperen
> :
> >
> > Fixes the use of the implicit declaration
> > of avpriv_request_sample().
>
> I don't see such a warning...
>
Yeah sorry, was something screwy going on. Re-./c
On Thu, Mar 19, 2020 at 12:39 AM Carl Eugen Hoyos wrote:
>
> Hi!
>
> Without this patch, make clean (and make distclean) do not delete
> ffmpeg_g.ilk and ffmpeg_g.pdb (and friends).
>
LGTM
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ff
by putting the palette in the demuxer's context. This also allows to
remove this demuxer's read_close-function.
Signed-off-by: Andreas Rheinhardt
---
libavformat/bethsoftvid.c | 24 ++--
1 file changed, 6 insertions(+), 18 deletions(-)
diff --git a/libavformat/bethsoftvid.c
The classical ptr = av_realloc(ptr, size), just with av_fast_realloc().
Signed-off-by: Andreas Rheinhardt
---
libavformat/bethsoftvid.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/libavformat/bethsoftvid.c b/libavformat/bethsoftvid.c
index e52b17433c..c54c54325
by putting the palette in the demuxer's context. This also allows to
remove this demuxer's read_close-function.
Signed-off-by: Andreas Rheinhardt
---
libavformat/bethsoftvid.c | 25 +++--
1 file changed, 7 insertions(+), 18 deletions(-)
diff --git a/libavformat/bethsoftvid.c
On Fri, Mar 20, 2020 at 02:31:05PM +0100, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol
> ---
> configure |1 +
> libavcodec/Makefile |1 +
> libavcodec/allcodecs.c |1 +
> libavcodec/avcodec.h|1 +
> libavcodec/bink2.c | 869 ++
Do it only if the packet has been successfully allocated in
av_new_packet() -- otherwise on error a completely uninitialized packet
would be unreferenced later.
Signed-off-by: Andreas Rheinhardt
---
libavformat/subtitles.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib
On 3/20/2020 10:31 AM, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol
> ---
> configure |1 +
> libavcodec/Makefile |1 +
> libavcodec/allcodecs.c |1 +
> libavcodec/avcodec.h|1 +
> libavcodec/bink2.c | 869
> libavcode
Reviewed-by: Paul B Mahol
Signed-off-by: numberwolf
---
Here, don't need show motionless vectors,because they're useless.
And remove comments.
doc/examples/extract_mvs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/doc/examples/extract_mvs.c b/doc/examples/extract_mvs.c
index de31ccd
and also add padding to it; moreover, don't use memcpy to write one byte
to extradata.
Signed-off-by: Andreas Rheinhardt
---
libavformat/hnm.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/libavformat/hnm.c b/libavformat/hnm.c
index 40ef5c06ee..31221553a4 100644
---
The hnm demuxer's context struct contained lots of fields that are
write-only variables or that are not used outside of parsing the header
and that can therefore be replaced by local variables of hnm_read_header().
This commit removes all of these from the context; the second type has
been replaced
50 matches
Mail list logo
