[FFmpeg-devel] [PATCH] lavc/vaapi_encode_h265: fix conf_win_xxx_offset for 4:2:2/4:4:4 encoding

2020-03-08 Thread Linjie Fu
Use desc->log2_chroma_w/h to calculate the sps->conf_win_right/bottom_offset. Based on Table 6-1, SubWidthC and SubHeightC depend on chroma format(log2_chroma_w/h). Based on D-28 and D-29, set the correct cropped width/height. croppedWidth = pic_width_in_luma_samples − SubWidth

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h265: fix conf_win_xxx_offset for 4:2:2/4:4:4 encoding

2020-03-08 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > Mark Thompson > Sent: Sunday, March 8, 2020 00:35 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h265: fix > conf_win_xxx_offset for 4:2:2/4:4:4 encoding > > On 05/03/2020 07:41, Linjie Fu wrote: > > Based on Table 6-1, se

Re: [FFmpeg-devel] [PATCH, v2 4/4] tests/checkasm: add overflow test for hevc_add_res

2020-03-08 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > Linjie Fu > Sent: Thursday, March 5, 2020 15:48 > To: ffmpeg-devel@ffmpeg.org > Cc: Xu, Guangxin ; Fu, Linjie > Subject: [FFmpeg-devel] [PATCH, v2 4/4] tests/checkasm: add overflow test > for hevc_add_res > > Add overflow test for hevc_add_res when int16_t coe

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/libzmq: Make default pkt_size value consistent with amqp

2020-03-08 Thread Marton Balint
On Fri, 28 Feb 2020, Andriy Gelman wrote: From: Andriy Gelman Signed-off-by: Andriy Gelman --- libavformat/libzmq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/libzmq.c b/libavformat/libzmq.c index 8c8b294c921..1b0d8638dbf 100644 --- a/libavformat/libzmq.c

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat: Add AMQP version 0-9-1 protocol support

2020-03-08 Thread Marton Balint
Subject: [FFmpeg-devel] [PATCH v2 1/2] avformat: Add AMQP version 0-9-1 protocol support From: Andriy Gelman Supports connecting to a RabbitMQ broker via AMQP version 0-9-1. Signed-off-by: Andriy Gelman --- Changes in v2: - Addressed comments from Marton - Updated documentation C

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_opt: warn about overwritten parsed options

2020-03-08 Thread Gyan Doshi
On 08-03-2020 01:22 am, Marton Balint wrote: On Sat, 29 Feb 2020, Marton Balint wrote: Signed-off-by: Marton Balint --- fftools/ffmpeg_opt.c | 70 +--- 1 file changed, 67 insertions(+), 3 deletions(-) Ping, will apply soon. LGTM. Gyan _

[FFmpeg-devel] [PATCH v3 0/2] High Voltage Software ALP demuxer + decoder.

2020-03-08 Thread Zane van Iperen
Adds support for the .TUN and .PCM files used by some High Voltage Software games. Please ping for review. v3: - Move Changelog and doc changes into their respective patches - Restored the empty line v2: - check for header size and "ADPCM" magic in probe - error if sample rate > 44100 to

[FFmpeg-devel] [PATCH v3 2/2] avformat: add demuxer for LEGO Racers' ALP format

2020-03-08 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/alp.c| 146 +++ libavformat/version.h| 4 +- 5 files changed, 151 insertions(+), 2 deletions(-) c

[FFmpeg-devel] [PATCH v3 1/2] avcodec: add decoder for High Voltage Software's ALP ADPCM

2020-03-08 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/adpcm.c | 36 libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 ++

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m_enc: Adapt to the new internal encode API

2020-03-08 Thread Lynne
Mar 8, 2020, 05:40 by andriy.gel...@gmail.com: > On Sat, 07. Mar 23:13, James Almer wrote: > >> On 3/7/2020 9:23 PM, Andriy Gelman wrote: >> > From: Andriy Gelman >> > >> > Should be squashed with: >> > http://ffmpeg.org/pipermail/ffmpeg-devel/2020-February/257735.html >> >> Thank you! Only thre

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m_enc: Adapt to the new internal encode API

2020-03-08 Thread James Almer
On 3/8/2020 9:29 AM, Lynne wrote: > Mar 8, 2020, 05:40 by andriy.gel...@gmail.com: > >> On Sat, 07. Mar 23:13, James Almer wrote: >> >>> On 3/7/2020 9:23 PM, Andriy Gelman wrote: From: Andriy Gelman Should be squashed with: http://ffmpeg.org/pipermail/ffmpeg-devel/2020-Februar

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat: add demuxer for LEGO Racers' ALP format

2020-03-08 Thread Paul B Mahol
lgtm On 3/8/20, Zane van Iperen wrote: > Signed-off-by: Zane van Iperen > --- > Changelog| 1 + > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/alp.c| 146 +++ > libavformat/version.h| 4 +-

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add decoder for High Voltage Software's ALP ADPCM

2020-03-08 Thread Paul B Mahol
lgtm On 3/8/20, Zane van Iperen wrote: > Signed-off-by: Zane van Iperen > --- > Changelog | 1 + > doc/general.texi| 1 + > libavcodec/Makefile | 1 + > libavcodec/adpcm.c | 36 > libavcodec/allcodecs.c | 1 + > libavcodec

[FFmpeg-devel] [PATCH] lavc/v4l2_m2m_dec: Init reserved bytes to zero before ioctl call

2020-03-08 Thread Andriy Gelman
From: Andriy Gelman struct v4l2_selection contains reserved bytes which should be set to zero before the ioctl call. Fixes valgrind error: Syscall param ioctl(VKI_V4L2_S_SELECTION) points to uninitialised byte(s) Signed-off-by: Andriy Gelman --- libavcodec/v4l2_m2m_dec.c | 2 +- 1 file change

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: fix possible memory leak in decoder

2020-03-08 Thread Marton Balint
On Thu, 5 Mar 2020, Marton Balint wrote: Fixes ticket #8549. Applied. Regards, Marton Signed-off-by: Marton Balint --- fftools/ffplay.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index fee0619f7c..f6511e4afd 100644 --- a/ff

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_opt: warn about overwritten parsed options

2020-03-08 Thread Marton Balint
On Sun, 8 Mar 2020, Gyan Doshi wrote: On 08-03-2020 01:22 am, Marton Balint wrote: On Sat, 29 Feb 2020, Marton Balint wrote: Signed-off-by: Marton Balint --- fftools/ffmpeg_opt.c | 70 +--- 1 file changed, 67 insertions(+), 3 deletions(-

Re: [FFmpeg-devel] [PATCH] avformat/udp: support w32pthreads compat

2020-03-08 Thread Marton Balint
On Fri, 6 Mar 2020, Ross Nicholson wrote: Ping Thanks, applied. Regards, Marton On 2 Mar 2020, at 21:30, Ross Nicholson wrote: phunkyfish in the history is fine thanks ;) On 2 Mar 2020, at 21:00, Marton Balint wrote:  On Mon, 2 Mar 2020, Ross Nicholson wrote: Updated to corr

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_opt: warn about overwritten parsed options

2020-03-08 Thread Carl Eugen Hoyos
Am So., 8. März 2020 um 19:35 Uhr schrieb Marton Balint : > > > > On Sun, 8 Mar 2020, Gyan Doshi wrote: > > > > > > > On 08-03-2020 01:22 am, Marton Balint wrote: > >> > >> > >> On Sat, 29 Feb 2020, Marton Balint wrote: > >> > >>> Signed-off-by: Marton Balint > >>> --- > >>> fftools/ffmpeg_opt.c |

[FFmpeg-devel] [PATCH v3 1/2] avformat: Add AMQP version 0-9-1 protocol support

2020-03-08 Thread Andriy Gelman
From: Andriy Gelman Supports connecting to a RabbitMQ broker via AMQP version 0-9-1. Signed-off-by: Andriy Gelman --- Changes in v3: - Fixed a bug when parsing username that contained a url encoded ":" - Fixed documentation error and improved logging Changes in v2: - Addressed com

[FFmpeg-devel] [PATCH v3 2/2] avformat/libzmq: Make default pkt_size value consistent with amqp

2020-03-08 Thread Andriy Gelman
From: Andriy Gelman Signed-off-by: Andriy Gelman --- doc/protocols.texi | 2 +- libavformat/libzmq.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 27df4759b63..e510019f2d8 100644 --- a/doc/protocols.texi +++ b/doc/protocol

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat: Add AMQP version 0-9-1 protocol support

2020-03-08 Thread Andriy Gelman
On Sun, 08. Mar 12:25, Marton Balint wrote: > > > Subject: [FFmpeg-devel] [PATCH v2 1/2] avformat: Add AMQP version 0-9-1 > > protocol support > > > > From: Andriy Gelman > > > > Supports connecting to a RabbitMQ broker via AMQP version 0-9-1. > > > > Signed-off-by: Andriy Gelman > > --- > >

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat: Add AMQP version 0-9-1 protocol support

2020-03-08 Thread Marton Balint
On Sun, 8 Mar 2020, Andriy Gelman wrote: From: Andriy Gelman Supports connecting to a RabbitMQ broker via AMQP version 0-9-1. Signed-off-by: Andriy Gelman --- Changes in v3: - Fixed a bug when parsing username that contained a url encoded ":" - Fixed documentation error and improved

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat: Add AMQP version 0-9-1 protocol support

2020-03-08 Thread Andriy Gelman
On Sun, 08. Mar 16:33, Andriy Gelman wrote: > From: Andriy Gelman > > Supports connecting to a RabbitMQ broker via AMQP version 0-9-1. > > Signed-off-by: Andriy Gelman > --- > > Changes in v3: > - Fixed a bug when parsing username that contained a url encoded ":" > - Fixed documentatio

[FFmpeg-devel] [PATCH v4 1/2] avformat: Add AMQP version 0-9-1 protocol support

2020-03-08 Thread Andriy Gelman
From: Andriy Gelman Supports connecting to a RabbitMQ broker via AMQP version 0-9-1. Signed-off-by: Andriy Gelman --- Changes in v4: - Fixed leak from user_decoded/password_decoded when amqp_new_connection() fails Changes in v3: - Fixed a bug when parsing username that containe

Re: [FFmpeg-devel] [PATCH, v2 4/4] tests/checkasm: add overflow test for hevc_add_res

2020-03-08 Thread Michael Niedermayer
On Thu, Mar 05, 2020 at 03:48:28PM +0800, Linjie Fu wrote: > Add overflow test for hevc_add_res when int16_t coeff = -32768, > and doubled the test cases. > > The result of C is good, while ASM is not. > > To verify: > make fate-checkasm-hevc_add_res > ffmpeg/tests/checkasm/checkasm --tes

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add decoder for High Voltage Software's ALP ADPCM

2020-03-08 Thread Michael Niedermayer
On Sun, Mar 08, 2020 at 03:32:25PM +0100, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If the United States is serious about tackling the national security threats related to an insecure 5G network, it needs to reth

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat: add demuxer for LEGO Racers' ALP format

2020-03-08 Thread Michael Niedermayer
On Sun, Mar 08, 2020 at 03:31:48PM +0100, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The educated differ from the uneducated as much as the living from the dead. -- Aristotle signature.asc Description: PGP signa

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat: add demuxer for LEGO Racers' ALP format

2020-03-08 Thread Carl Eugen Hoyos
Am So., 8. März 2020 um 13:09 Uhr schrieb Zane van Iperen : > +static int alp_probe(const AVProbeData *p) > +{ > +uint32_t i; > + > +if (AV_RL32(p->buf) != ALP_TAG) > +return 0; > + > +/* Only allowed header sizes are 8 and 12. */ > +i = AV_RL32(p->buf + 4); > +if (i !=

[FFmpeg-devel] [PATCH] avcodec/decode: remove unused AVCodecInternal compat_decode field

2020-03-08 Thread James Almer
Signed-off-by: James Almer --- libavcodec/decode.c | 1 - libavcodec/internal.h | 1 - 2 files changed, 2 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 03b9da25f9..0e3d7e17e4 100644 --- a/libavcodec/decode.c +++ b/libavcodec/decode.c @@ -826,7 +826,6 @@ static int c

Re: [FFmpeg-devel] [PATCH, v2 4/4] tests/checkasm: add overflow test for hevc_add_res

2020-03-08 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Monday, March 9, 2020 06:16 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH, v2 4/4] tests/checkasm: add overflow > test for hevc_add_res > > On Thu, Mar 05, 2020 at 03:48:28PM

Re: [FFmpeg-devel] [PATCH] dashenc: more accurate time values in playlist.mpd

2020-03-08 Thread Jeyapal, Karthick
On 3/5/20 9:02 PM, Alfred E. Heggestad wrote: > > > On 05/03/2020 15:37, Carl Eugen Hoyos wrote: >> Am Do., 5. März 2020 um 11:08 Uhr schrieb Alfred E. Heggestad >> : >> >>> -int64_t update_period = c->last_duration / AV_TIME_BASE; >>> +double update_period = (double)c->last_durati

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/cbs_h2645: Avoid more cases of 0 size slices

2020-03-08 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: Assertion failure > Fixes: > 19629/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_METADATA_fuzzer-5676822528524288 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- >