Re: [FFmpeg-devel] [PATCH 1/3] avutil/frame: add use_last_roi

2020-02-14 Thread Hendrik Leppkes
On Fri, Feb 14, 2020 at 4:41 AM Guo, Yejun wrote: > > For some cases, the regions of interest do not change, it is not > convenient to always prepare the roi data for every frame. So, add > use_last_roi to show it uses the same roi data as last frame. > > Since a new flag is added into AVFrame, th

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-14 Thread Paul B Mahol
On 2/14/20, Fu, Linjie wrote: >> -Original Message- >> From: ffmpeg-devel On Behalf Of Fu, >> Linjie >> Sent: Tuesday, February 11, 2020 20:58 >> To: FFmpeg development discussions and patches > de...@ffmpeg.org> >> Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: allow forcing input framerate on streamcopy

2020-02-14 Thread Andreas Rheinhardt
On Tue, Feb 11, 2020 at 6:05 PM Paul B Mahol wrote: > From: Leo Izen > > Signed-off-by: Paul B Mahol > --- > The OP has been asked to improve the commit message [1] and the same applies to you. E.g. I did not initially know that this was supposed to apply to video only. > fftools/ffmpeg.c |

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffprobe: Remove unneeded casts

2020-02-14 Thread Andreas Rheinhardt
On Tue, Aug 6, 2019 at 3:18 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffprobe.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c > index 238

[FFmpeg-devel] [PATCH] avfilter/vf_program_opencl: make it possible to pass plane as argument to kernel

2020-02-14 Thread Paul B Mahol
Fixes #7190 Signed-off-by: Paul B Mahol --- doc/filters.texi| 4 libavfilter/vf_program_opencl.c | 17 + 2 files changed, 21 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index b957b9302e..5bd0e44b67 100644 --- a/doc/filters.texi +++ b/doc/

Re: [FFmpeg-devel] [PATCH]lavc/mlp_parse: Read wordlength from 0xba streams

2020-02-14 Thread Carl Eugen Hoyos
Am Fr., 14. Feb. 2020 um 01:26 Uhr schrieb Hendrik Leppkes : > > On Fri, Feb 14, 2020 at 12:29 AM Carl Eugen Hoyos wrote: > > > > Attached patch allows detecting s16 truehd streams encoded with > > FFmpeg, only tested with FFmpeg's encoder, I did not look into any > > specification. > > According

Re: [FFmpeg-devel] [PATCH]lavc/mlp_parse: Read wordlength from 0xba streams

2020-02-14 Thread Hendrik Leppkes
On Fri, Feb 14, 2020 at 11:45 AM Carl Eugen Hoyos wrote: > > Am Fr., 14. Feb. 2020 um 01:26 Uhr schrieb Hendrik Leppkes > : > > > > On Fri, Feb 14, 2020 at 12:29 AM Carl Eugen Hoyos > > wrote: > > > > > > Attached patch allows detecting s16 truehd streams encoded with > > > FFmpeg, only tested w

Re: [FFmpeg-devel] [PATCH]lavc/mlp_parse: Read wordlength from 0xba streams

2020-02-14 Thread Carl Eugen Hoyos
Am Fr., 14. Feb. 2020 um 11:48 Uhr schrieb Hendrik Leppkes : > > On Fri, Feb 14, 2020 at 11:45 AM Carl Eugen Hoyos wrote: > > > > Am Fr., 14. Feb. 2020 um 01:26 Uhr schrieb Hendrik Leppkes > > : > > > > > > On Fri, Feb 14, 2020 at 12:29 AM Carl Eugen Hoyos > > > wrote: > > > > > > > > Attached p

Re: [FFmpeg-devel] [PATCH]lavc/mlp_parse: Read wordlength from 0xba streams

2020-02-14 Thread Paul B Mahol
On 2/14/20, Carl Eugen Hoyos wrote: > Am Fr., 14. Feb. 2020 um 11:48 Uhr schrieb Hendrik Leppkes > : >> >> On Fri, Feb 14, 2020 at 11:45 AM Carl Eugen Hoyos >> wrote: >> > >> > Am Fr., 14. Feb. 2020 um 01:26 Uhr schrieb Hendrik Leppkes >> > : >> > > >> > > On Fri, Feb 14, 2020 at 12:29 AM Carl Eu

Re: [FFmpeg-devel] [PATCH]lavc/mlp_parse: Read wordlength from 0xba streams

2020-02-14 Thread Carl Eugen Hoyos
Am Fr., 14. Feb. 2020 um 12:02 Uhr schrieb Paul B Mahol : > > On 2/14/20, Carl Eugen Hoyos wrote: > > The way I read this document is that precision is not stored and that we > > need a decoder option to force decoding less than 24 bits. > > No, your patch is nonsense. Hendrik already explained

Re: [FFmpeg-devel] [PATCH]lavc/mlp_parse: Read wordlength from 0xba streams

2020-02-14 Thread Paul B Mahol
On 2/14/20, Carl Eugen Hoyos wrote: > Am Fr., 14. Feb. 2020 um 12:02 Uhr schrieb Paul B Mahol : >> >> On 2/14/20, Carl Eugen Hoyos wrote: > >> > The way I read this document is that precision is not stored and that we >> > need a decoder option to force decoding less than 24 bits. >> >> No, your

Re: [FFmpeg-devel] [PATCH]lavc/mlp_parse: Read wordlength from 0xba streams

2020-02-14 Thread Carl Eugen Hoyos
Am Fr., 14. Feb. 2020 um 12:07 Uhr schrieb Paul B Mahol : > > On 2/14/20, Carl Eugen Hoyos wrote: > > Am Fr., 14. Feb. 2020 um 12:02 Uhr schrieb Paul B Mahol : > >> > >> On 2/14/20, Carl Eugen Hoyos wrote: > > > >> > The way I read this document is that precision is not stored and that we > >> >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dstdec: Use local channels variable

2020-02-14 Thread Paul B Mahol
lgtm On 2/13/20, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/dstdec.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/dstdec.c b/libavcodec/dstdec.c > index 880b838b0c..bdabced823 100644 > --- a/libavcodec

[FFmpeg-devel] [PATCH] avcodec/dvdsub: Fix warning about incompatible pointer type

2020-02-14 Thread Andreas Rheinhardt
Fixes "passing argument 2 of ‘strtoul’ from incompatible pointer type [-Wincompatible-pointer-types]" ("expected ‘char ** restrict’ but argument is of type ‘const char **’") for GCC and "passing 'const char **' to parameter of type 'char **' discards qualifiers in nested pointer types [-Wincompatib

Re: [FFmpeg-devel] [PATCH] avcodec/dvdsub: Fix warning about incompatible pointer type

2020-02-14 Thread Paul B Mahol
LGTM On 2/14/20, Andreas Rheinhardt wrote: > Fixes "passing argument 2 of ‘strtoul’ from incompatible pointer > type [-Wincompatible-pointer-types]" ("expected ‘char ** restrict’ but > argument is of type ‘const char **’") for GCC and "passing 'const char > **' to parameter of type 'char **' disc

Re: [FFmpeg-devel] [PATCH] avcodec/dvdsub: Fix warning about incompatible pointer type

2020-02-14 Thread James Almer
On 2/14/2020 8:46 AM, Paul B Mahol wrote: > LGTM > > On 2/14/20, Andreas Rheinhardt wrote: >> Fixes "passing argument 2 of ‘strtoul’ from incompatible pointer >> type [-Wincompatible-pointer-types]" ("expected ‘char ** restrict’ but >> argument is of type ‘const char **’") for GCC and "passing 'c

Re: [FFmpeg-devel] [PATCH 1/3] avutil/frame: add use_last_roi

2020-02-14 Thread James Almer
On 2/14/2020 5:33 AM, Hendrik Leppkes wrote: > On Fri, Feb 14, 2020 at 4:41 AM Guo, Yejun wrote: >> >> For some cases, the regions of interest do not change, it is not >> convenient to always prepare the roi data for every frame. So, add >> use_last_roi to show it uses the same roi data as last fr

Re: [FFmpeg-devel] [PATCH 1/3] avutil/frame: add use_last_roi

2020-02-14 Thread Ronald S. Bultje
Hi, On Thu, Feb 13, 2020 at 10:41 PM Guo, Yejun wrote: > For some cases, the regions of interest do not change, it is not > convenient to always prepare the roi data for every frame. Since side-data is refcounted, can't you just keep the "last" one in memory and refcount it? That way, if you w

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dstdec: Use local channels variable

2020-02-14 Thread Michael Niedermayer
On Fri, Feb 14, 2020 at 10:20:41AM +0100, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship naturally arises out of democracy, and the most aggravated form of tyranny and slavery out of the most extreme liber

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/dstdec: Check sample rate

2020-02-14 Thread Paul B Mahol
LGTM On 2/13/20, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 20659/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DST_fuzzer-5735812071424000 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michae

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/dstdec: Check sample rate

2020-02-14 Thread Paul B Mahol
LGTM On 2/13/20, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 20659/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DST_fuzzer-5735812071424000 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michae

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/dstdec: Check sample rate

2020-02-14 Thread Paul B Mahol
Actually I'm pretty sure log message is not needed as not power of 8 is simply not possible. On 2/14/20, Paul B Mahol wrote: > LGTM > > On 2/13/20, Michael Niedermayer wrote: >> Fixes: out of array access >> Fixes: >> 20659/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DST_fuzzer-57358120714

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffprobe: Remove unneeded casts

2020-02-14 Thread Michael Niedermayer
On Tue, Aug 06, 2019 at 03:17:06AM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffprobe.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC

Re: [FFmpeg-devel] [PATCH 4/7] avformat/segafilmenc: Remove AVClass

2020-02-14 Thread Andreas Rheinhardt
Andreas Rheinhardt: > This muxer does not have any private options and so does not need a > private class. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/segafilmenc.c | 8 > 1 file changed, 8 deletions(-) > > diff --git a/libavformat/segafilmenc.c b/libavformat/segafilmenc.

[FFmpeg-devel] [PATCH] avcodec: fix pcm zork decoder

2020-02-14 Thread Paul B Mahol
Fixes #1939 Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 2 +- libavcodec/adpcm.c | 60 + libavcodec/allcodecs.c | 2 +- libavcodec/codec_desc.c | 4 +-- libavcodec/pcm.c| 9 --- 5 files changed, 64 insertions(+), 13 dele

Re: [FFmpeg-devel] [PATCH 01/12] avformat/tests/url: make format more readable

2020-02-14 Thread Marton Balint
On Sat, 8 Feb 2020, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/tests/url.c | 3 ++- tests/ref/fate/url | 27 ++- 2 files changed, 16 insertions(+), 14 deletions(-) Ping for the series, will apply soon... Thanks, Marton diff --git a/liba

[FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-14 Thread Linjie Fu
Currently, ffmpeg inserts scale filter by default in the filter graph to force the whole decoded stream to scale into the same size with the first frame. It's not quite make sense in resolution changing cases if user wants the rawvideo without any scale. Using autoscale/noautoscale as an output op

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-14 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Paul B Mahol > Sent: Friday, February 14, 2020 16:55 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale > to disable/enable the default scal

[FFmpeg-devel] avfilter/vf_zscale: fix crash on unaligned input

2020-02-14 Thread jjadfh5dfg
Sent with [ProtonMail](https://protonmail.com) Secure Email. 0001-avfilter-vf_zscale-fix-crash-on-unaligned-input.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To un

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: add support for external bitrate control for HEVC

2020-02-14 Thread Zhong Li
Linjie Fu 于2020年2月13日周四 下午8:50写道: > > Enables option for hevc_qsv encoder: > -extbrc > > Improvements in BD-Rate could be observed with extbrc on. > > Signed-off-by: Linjie Fu > --- > Details for extbrc: > https://github.com/Intel-Media-SDK/MediaSDK/blob/master/doc/mediasdk-man.md#external-bi