[FFmpeg-devel] [PATCH 5/5] mlpenc: clean up

2020-01-25 Thread Jai Luthra
Signed-off-by: Jai Luthra --- On Fri, Jan 24, 2020 at 02:25:20PM +0100, Paul B Mahol wrote: > This is not cleanup, this adds new line of code without proper explanation. My bad, I was testing something and forgot to remove that line. Fixed now. libavcodec/mlpenc.c | 23 ++-

Re: [FFmpeg-devel] [PATCH] lavc/dvdsubenc: accept palette from options

2020-01-25 Thread Michael Kuron
On Sat, Jan 25, 2020 at 01:24 AM Carl Eugen Hoyos wrote: >> static const AVOption options[] = { >> +{"palette", "set the global palette", OFFSET(palette_str), >> AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, SE }, > > What happens if invalid values are passed as palette? The string is parsed un

Re: [FFmpeg-devel] [PATCH] lavc/dvdsubenc: accept palette from options

2020-01-25 Thread Nicolas George
Michael Kuron (12020-01-25): > In fact, this entire patch is > basically copy+paste from there. Then please fix the patch so that the same code is used, not a copy of it. Otherwise, enhancements or fixes would have to be duplicated too. Regards, -- Nic

[FFmpeg-devel] [PATCH] lavc/dvdsubenc: accept palette from options

2020-01-25 Thread Michael Kuron
Previously, the default palette would always be used. Now, we can accept a custom palette, just like dvdsubdec does. Signed-off-by: Michael Kuron --- doc/decoders.texi | 2 +- doc/encoders.texi | 8 libavcodec/Makefile| 1 + libavcodec/dvdsub.c| 35 +

Re: [FFmpeg-devel] [PATCH] lavc/dvdsubenc: accept palette from options

2020-01-25 Thread Nicolas George
Michael Kuron (12020-01-25): > Previously, the default palette would always be used. > Now, we can accept a custom palette, just like dvdsubdec does. > > Signed-off-by: Michael Kuron > --- > doc/decoders.texi | 2 +- > doc/encoders.texi | 8 > libavcodec/Makefile| 1 + >

[FFmpeg-devel] [PATCH] lavc/dvdsubenc: accept palette from options

2020-01-25 Thread Michael Kuron
Previously, the default palette would always be used. Now, we can accept a custom palette, just like dvdsubdec does. Signed-off-by: Michael Kuron --- doc/decoders.texi | 2 +- doc/encoders.texi | 8 libavcodec/Makefile| 2 ++ libavcodec/dvdsub.c| 33

Re: [FFmpeg-devel] [PATCH] avformat/movenc: allow ISMV timescale to be user-set

2020-01-25 Thread Gyan
On 25-01-2020 11:04 am, Gyan wrote: On 23-01-2020 05:56 pm, Gyan Doshi wrote: As per the PIFF standard, the timescale of 1000 is recommended but not mandatory, so don't override the user-set value. A warning is shown for non-recommended values. ---   libavformat/movenc.c | 14 ++

Re: [FFmpeg-devel] [PATCH] avutil/thread: fix strict_pthread_cond_timedwait

2020-01-25 Thread Marton Balint
On Wed, 22 Jan 2020, Marton Balint wrote: Timeout error was assumed to be fatal which it is not. Applied. Regards, Marton Signed-off-by: Marton Balint --- libavutil/thread.h | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/libavutil/thread.h b

Re: [FFmpeg-devel] [PATCH 1/4] avformat/udp: add newline after warning

2020-01-25 Thread Marton Balint
On Thu, 16 Jan 2020, myp...@gmail.com wrote: On Thu, Jan 16, 2020 at 8:20 AM Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/udp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index f4ec148a2f..e42a069b24 10064

[FFmpeg-devel] [PATCH 1/2] tools/target_dec_fuzzer: Sort threshold list alphabetically

2020-01-25 Thread Michael Niedermayer
This also removes the comments as they are hard to maintain together with sorted lists Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 54 ++- 1 file changed, 25 insertions(+), 29 deletions(-) diff --git a/tools/target_dec_fuzzer.c b/tools/

[FFmpeg-devel] [PATCH 2/2] tools/target_dec_fuzzer: Add threshold for ALS

2020-01-25 Thread Michael Niedermayer
Fixes: Timeout (253sec -> 16sec) Fixes: 18668/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-6227155369590784 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 +

[FFmpeg-devel] [PATCH v5 1/2] avcodec: add decoder for argonaut games' adpcm codec

2020-01-25 Thread Zane van Iperen
Adds support for the ADPCM variant used by some Argonaut Games' games, such as 'Croc! Legend of the Gobbos', and 'Croc 2'. Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/adpcm.c | 67 +

[FFmpeg-devel] [PATCH v5 2/2] avformat: add demuxer for argonaut games' ASF format

2020-01-25 Thread Zane van Iperen
Adds support for the custom ASF container used by some Argonaut Games' games, such as 'Croc! Legend of the Gobbos', and 'Croc 2'. Can also handle the sample files in: https://samples.ffmpeg.org/game-formats/brender/part2.zip Signed-off-by: Zane van Iperen --- Changelog| 1 + l

[FFmpeg-devel] [PATCH v5 0/2] Argonaut Games ASF and ADPCM decoding support

2020-01-25 Thread Zane van Iperen
Hi all, This patchset adds support for the ASF container and ADPCM variant used by some Argonaut Software games such as 'Croc! Legend of the Gobbos' and 'Croc 2'. It has been tested against: - ANISOUND/*.ASFfrom Croc 1 - music/*.asf from Croc 2 - FIGHT/SOUND/*.ASF from https://sa

[FFmpeg-devel] [PATCH 29/30] avformat/matroskaenc: Check BlockAdditional size before use

2020-01-25 Thread Andreas Rheinhardt
Don't read a 64bit number before having checked that the data is at least 8 bytes long. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 44403

[FFmpeg-devel] [PATCH 30/30] avformat/matroskaenc: Improve BlockAdditions

2020-01-25 Thread Andreas Rheinhardt
8ffcc826 added support for muxing BlockAdditions with BlockAddID equal to one. The restriction to BlockAddID == 1 probably resulted from a limitation to what was needed; yet over time this led to three occurences of "(side_data_size && additional_id == 1)". This commit changes this by setting side_

[FFmpeg-devel] [PATCH 1/2] avformat/dvenc: Replace write_trailer by deinit function

2020-01-25 Thread Andreas Rheinhardt
The old write_trailer only freed memory, so it is better to make a dedicated deinit function out of it. Given that this function will also be called when writing the header fails, one can also remove code that frees already allocated fifos when allocating another one fails. Signed-off-by: Andreas

[FFmpeg-devel] [PATCH 2/2] avformat/dvenc: Don't zero unnecessarily

2020-01-25 Thread Andreas Rheinhardt
The muxing context has already been zeroed when it was allocated, hence it is unnecessary to do it again. Signed-off-by: Andreas Rheinhardt --- libavformat/dvenc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavformat/dvenc.c b/libavformat/dvenc.c index b89ad4d1c8..c71e532771 100644