Re: [FFmpeg-devel] [PATCH 4/4] avformat/udp: do not use thread cancellation when receiving data

2020-01-17 Thread Matt Oliver
On Fri, 17 Jan 2020 at 18:44, Hendrik Leppkes wrote: > On Fri, Jan 17, 2020 at 12:30 AM Michael Niedermayer > wrote: > > > > On Thu, Jan 16, 2020 at 01:20:16AM +0100, Marton Balint wrote: > > > It is not supported by every threading implementation, and the only > thing we > > > gain with it is a

Re: [FFmpeg-devel] [SCISYS Possible Spam] Re: [PATCH v6] avformat/mov: Memory optimization with QuickTime/MP4

2020-01-17 Thread Jörg Beckmann
> -Ursprüngliche Nachricht- > Von: ffmpeg-devel Im Auftrag von Moritz > Barsnick > Gesendet: Mittwoch, 8. Januar 2020 15:25 > An: FFmpeg development discussions and patches > Betreff: [SCISYS Possible Spam] Re: [FFmpeg-devel] [PATCH v6] avformat/mov: > Memory optimization with QuickTime

Re: [FFmpeg-devel] [PATCH] avfilter/scale: fix CID 1457833

2020-01-17 Thread Gyan
On 16-01-2020 09:07 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2020-01-16 13:59:47) --- libavfilter/vf_scale.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index d46c767e70..70978345e8 100644 --- a/libavfilter/vf

[FFmpeg-devel] [PATCH] avfilter/f_metadata: correct check for existing metadata

2020-01-17 Thread Gyan Doshi
When adding metadata, existing dictionary need not be present. --- libavfilter/f_metadata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/f_metadata.c b/libavfilter/f_metadata.c index bf298e9d39..598257b15b 100644 --- a/libavfilter/f_metadata.c +++ b/libavfilter/f

Re: [FFmpeg-devel] [PATCH v3] avutil/frame: Use av_realloc_array()

2020-01-17 Thread lance . lmwang
ping On Thu, Dec 26, 2019 at 08:33:38AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavutil/frame.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/libavutil/frame.c b/libavutil/frame.c > index e403809..2e76

Re: [FFmpeg-devel] [PATCH v8 1/4] avutil: add AV_FRAME_DATA_SEI_UNREGISTERED side data type

2020-01-17 Thread lance . lmwang
ping the patchset for further comments. On Wed, Jan 08, 2020 at 11:46:00PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/APIchanges | 3 +++ > libavutil/frame.c | 1 + > libavutil/frame.h | 8 > libavutil/version.h | 2 +- >

Re: [FFmpeg-devel] [PATCH] avfilter/f_metadata: correct check for existing metadata

2020-01-17 Thread Paul B Mahol
OK if tested and works. On 1/17/20, Gyan Doshi wrote: > When adding metadata, existing dictionary need not be present. > --- > libavfilter/f_metadata.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/f_metadata.c b/libavfilter/f_metadata.c > index bf298e9d39.

Re: [FFmpeg-devel] [PATCH] avfilter/f_metadata: correct check for existing metadata

2020-01-17 Thread Gyan
On 17-01-2020 03:52 pm, Paul B Mahol wrote: OK if tested and works. Tested. Pushed as c95dfe5cce98cde3e7fb14fbd04b3897f3927cec Thanks, Gyan On 1/17/20, Gyan Doshi wrote: When adding metadata, existing dictionary need not be present. --- libavfilter/f_metadata.c | 2 +- 1 file changed

Re: [FFmpeg-devel] [PATCH v2] doc/v4l2_m2m: Add documentation

2020-01-17 Thread Andriy Gelman
On Fri, 17. Jan 11:29, Gyan wrote: > > > On 17-01-2020 01:47 am, Andriy Gelman wrote: > > On Thu, 16. Jan 10:51, Gyan wrote: > > > > > > On 16-01-2020 09:44 am, Andriy Gelman wrote: > > > > From: Andriy Gelman > > > > > > > > Signed-off-by: Andriy Gelman > > > > --- > > > >doc/decoders.te

[FFmpeg-devel] [PATCH] fate/filter-video.mak: do not use bit-exact check for dnn_processing

2020-01-17 Thread Guo, Yejun
the reason is that the tested models are in float format Signed-off-by: Guo, Yejun --- tests/fate/filter-video.mak| 9 +++- ...filter-dnn_processing-halve_first_channel_float | 55 -- .../fate/filter-dnn_processing-halve_gray_float| 55 ---

[FFmpeg-devel] [PATCH 22/23] avformat/matroskaenc: Combine checks for audio

2020-01-17 Thread Andreas Rheinhardt
mkv_write_track() currently has three places where it checks for whether the current codec type is audio: One in a switch and two outside of it. These checks can be combined by moving the code after the other two checks inside the audio-related part of the switch. Signed-off-by: Andreas Rheinhardt

[FFmpeg-devel] [PATCH 23/23] avformat/matroskaenc: Reindent after previous commit

2020-01-17 Thread Andreas Rheinhardt
Also remove { } after an if if there is only one statement inside { }. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 9

Re: [FFmpeg-devel] [PATCH 10/11] avformat/oggparsevorbis: Use AV_DICT_DONT_STRDUP_VAL to avoid av_strdup

2020-01-17 Thread Michael Niedermayer
On Mon, Nov 11, 2019 at 02:12:58AM +0100, Andreas Rheinhardt wrote: > This will likely also fix CID 1452427, a false positive resulting from > Coverity thinking that av_dict_set() automatically frees its key and > value parameters (even without the AV_DICT_DONT_STRDUP_* flags). > > (AV_DICT_APPEND

Re: [FFmpeg-devel] [PATCH] configure: Increase minimum libx265 version

2020-01-17 Thread Michael Niedermayer
On Thu, Jan 16, 2020 at 09:18:07PM +, Derek Buitenhuis wrote: > On 08/01/2020 22:21, Andriy Gelman wrote: > > From: Andriy Gelman > > > > libx265.c references a member x265_picture.quantOffsets (for ROI > > support) which was added in X265_BUILD 70. Increase the minimum libx265 > > version to

Re: [FFmpeg-devel] [PATCH 1/2] avformat/movenc, segafilmenc: Remove unnecessary avio_tell()

2020-01-17 Thread Michael Niedermayer
On Thu, Jan 16, 2020 at 05:49:14AM +0100, Andreas Rheinhardt wrote: > When the faststart option for the mov/mp4 muxer is used, the current > position (i.e. the size of the already written data pre-shifting) was > evaluated twice: First in an initialization and then again later, > overwriting the fi

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-17 Thread James Zern
On Wed, Jan 15, 2020 at 6:20 PM Wonkap Jang wrote: > > HI, > My comments are in-line. > > On Tue, Jan 14, 2020 at 8:55 PM James Zern > wrote: > > > On Tue, Jan 14, 2020 at 11:07 AM Wonkap Jang > > wrote: > > > [...] > > > + > > > +/** > > > + * 0=L, 1=GF, 2=ARF, > > > > my point

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/libx264: return error if unknown picture type encountered

2020-01-17 Thread Michael Niedermayer
On Fri, Jan 17, 2020 at 12:48:48PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/libx264.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c > index ca8f6c0..4fef0be

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-17 Thread James Zern
On Thu, Jan 16, 2020 at 11:04 AM Wonkap Jang wrote: > > James, > > On Thu, Jan 16, 2020 at 10:58 AM Wonkap Jang < > wonkap-at-google@ffmpeg.org> wrote: > > > This commit reuses the configuration options for VP8 that enables > > temporal scalability for VP9. It also adds a way to enable three >

[FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-17 Thread Wonkap Jang
This commit reuses the configuration options for VP8 that enables temporal scalability for VP9. It also adds a way to enable three preset temporal structures (refer to the documentation for more detail) that can be used in offline encoding. --- doc/encoders.texi | 18 ++- libavcodec/libvpxen

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-17 Thread Wonkap Jang
Hi James, On Fri, Jan 17, 2020 at 1:50 PM Wonkap Jang wrote: > This commit reuses the configuration options for VP8 that enables > temporal scalability for VP9. It also adds a way to enable three > preset temporal structures (refer to the documentation for more > detail) that can be used in offl

Re: [FFmpeg-devel] [PATCH 4/4] avformat/udp: do not use thread cancellation when receiving data

2020-01-17 Thread James Almer
On 1/17/2020 4:51 AM, Matt Oliver wrote: > On Fri, 17 Jan 2020 at 18:44, Hendrik Leppkes wrote: > >> On Fri, Jan 17, 2020 at 12:30 AM Michael Niedermayer >> wrote: >>> >>> On Thu, Jan 16, 2020 at 01:20:16AM +0100, Marton Balint wrote: It is not supported by every threading implementation, a

[FFmpeg-devel] [PATCH v2 2/2] avcodec/libx264: return error if unknown picture type encountered

2020-01-17 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/libx264.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index ca8f6c0..4fef0be 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -471,7 +471,8 @@ static in

Re: [FFmpeg-devel] [PATCH] Add a commandline option to control loop restoration for libaom

2020-01-17 Thread James Zern
On Mon, Dec 23, 2019 at 12:53 PM Wang Cao wrote: > > Signed-off-by: Wang Cao > --- > doc/encoders.texi | 3 +++ > libavcodec/libaomenc.c | 6 ++ > 2 files changed, 9 insertions(+) > lgtm. sorry for losing track of this. > [...] > +if (ctx->enable_restoration >= 0) > + codecct

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/libx264: return error if unknown picture type encountered

2020-01-17 Thread Limin Wang
On Fri, Jan 17, 2020 at 10:09:47PM +0100, Michael Niedermayer wrote: > On Fri, Jan 17, 2020 at 12:48:48PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/libx264.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > >

Re: [FFmpeg-devel] [PATCH] Add a commandline option to control loop restoration for libaom

2020-01-17 Thread James Zern
On Fri, Jan 17, 2020 at 2:45 PM James Zern wrote: > > On Mon, Dec 23, 2019 at 12:53 PM Wang Cao wrote: > > > > Signed-off-by: Wang Cao > > --- > > doc/encoders.texi | 3 +++ > > libavcodec/libaomenc.c | 6 ++ > > 2 files changed, 9 insertions(+) > > > > lgtm. sorry for losing track of

Re: [FFmpeg-devel] [PATCH] fate/filter-video.mak: do not use bit-exact check for dnn_processing

2020-01-17 Thread Carl Eugen Hoyos
Am Fr., 17. Jan. 2020 um 15:37 Uhr schrieb Guo, Yejun : > > the reason is that the tested models are in float format The two reference files are ~1MB together: Do we want / need that? (No opinion here.) Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-de

Re: [FFmpeg-devel] headers for gapless playback

2020-01-17 Thread Kaplan, John
Hey guys thanks for the discussion - sorry I went dark on this, I had a death in the family last November & am I the executor, so am just starting to free up again for projects. This is my first experience with ffmpeg coding, so I may have newbie questions. I just got a debug build completed & g

[FFmpeg-devel] [PATCH] avcodec/ffwavesynth: Correct undefined overflow of PINK_UNIT

2020-01-17 Thread Michael Niedermayer
Fixes: signed integer overflow: 9223372036854775775 + 128 cannot be represented in type 'long' Fixes: 20054/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5686385113825280 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg S

Re: [FFmpeg-devel] [PATCH] compat/w32pthreads: propagate the return value of SleepConditionVariableSRW()

2020-01-17 Thread James Almer
On 1/17/2020 4:41 AM, Hendrik Leppkes wrote: > On Fri, Jan 17, 2020 at 2:41 AM James Almer wrote: >> >> Signed-off-by: James Almer >> --- >> compat/w32pthreads.h | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/compat/w32pthreads.h b/compat/w32pthreads.h >> index 21a

[FFmpeg-devel] [PATCH] avcodec/libx265: zero the padding bytes in extradata

2020-01-17 Thread James Almer
Signed-off-by: James Almer --- libavcodec/libx265.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 9e4711e50b..e42c7b4d85 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -400,6 +400,7 @@ static av_cold int libx265_encode_init(

[FFmpeg-devel] [PATCH V1 2/2] doc/spp: Update spp command options docs

2020-01-17 Thread Jun Zhao
From: Jun Zhao Update spp command options docs Suggested-by: Moritz Barsnick Signed-off-by: Jun Zhao --- doc/filters.texi |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 7f1f59b..15c7f76 100644 --- a/doc/filters.texi +++ b/d

[FFmpeg-devel] [PATCH 24/24] avformat/matroskaenc: Don't implicitly mark WebVTT in WebM as English

2020-01-17 Thread Andreas Rheinhardt
Writing the language of WebVTT in WebM proceeded differently than the language of all other tracks: In case no language was given, it does not write anything instead of "und" (for undefined). Because the default value of the Language element in WebM (that inherited it from Matroska) is "eng" (for E

[FFmpeg-devel] [PATCH V1 1/2] doc/bsfs: h264_metadata: Update docs about display orientation SEI

2020-01-17 Thread Jun Zhao
From: Jun Zhao Add docs about display orientation SEI. Signed-off-by: Jun Zhao --- doc/bitstream_filters.texi | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index 8fe5b3a..ff5d027 100644 ---

Re: [FFmpeg-devel] [PATCH V1 1/2] doc/bsfs: h264_metadata: Update docs about display orientation SEI

2020-01-17 Thread Andreas Rheinhardt
On Sat, Jan 18, 2020 at 3:11 AM Jun Zhao wrote: > From: Jun Zhao > > Add docs about display orientation SEI. > > Signed-off-by: Jun Zhao > --- > doc/bitstream_filters.texi | 21 + > 1 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/doc/bitstream_filters.t

Re: [FFmpeg-devel] headers for gapless playback

2020-01-17 Thread Carl Eugen Hoyos
Am Sa., 18. Jan. 2020 um 00:14 Uhr schrieb Kaplan, John : > As far as control, I'll need to add a config switch to control adding gapless > data or not. Why wouldn't it always be added? Please avoid top-posting here, Carl Eugen ___ ffmpeg-devel mailin

Re: [FFmpeg-devel] [PATCH V1 2/2] doc/spp: Update spp command options docs

2020-01-17 Thread Gyan
On 18-01-2020 07:13 am, Jun Zhao wrote: From: Jun Zhao Update spp command options docs Suggested-by: Moritz Barsnick Signed-off-by: Jun Zhao --- doc/filters.texi |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 7f1f59b.

Re: [FFmpeg-devel] [PATCH] avfilter/pad: improve error check for w and h

2020-01-17 Thread Gyan
On 15-01-2020 09:25 pm, Gyan Doshi wrote: Target dimensions have to cover entire input. --- libavfilter/vf_pad.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_pad.c b/libavfilter/vf_pad.c index 186d3f028d..e86292eaa2 100644 --- a/libavfilter/vf_pa