Re: [FFmpeg-devel] [PATCH 6/8] lavc/vaapi_hevc: add function to find exact va_profile for REXT

2020-01-12 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Mark Thompson > Sent: Thursday, January 9, 2020 06:44 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 6/8] lavc/vaapi_hevc: add function to > find exact va_profile for REXT > > On 29/12/2019 16:30, Linjie Fu wrote

Re: [FFmpeg-devel] [PATCH] HEVC: Export motion vectors to frame side data.

2020-01-12 Thread Asaf Kave
On Wed, Jan 8, 2020 at 11:30 AM Asaf Kave wrote: > > > On Tue, Jan 7, 2020 at 4:49 AM Zhong Li wrote: > >> Haven't tested but patch LGTM >> > > Thanks Li for the feedback. > > >> >> Asaf Kave 于2019年12月29日周日 下午10:08写道: >> > >> > --- >> > libavcodec/hevc_refs.c | 15 >> > libavcodec/hevcde

Re: [FFmpeg-devel] AVWriter API

2020-01-12 Thread Nicolas George
Anton Khirnov (12020-01-07): > Replying to this thread, since it contains the motivation. Thanks. > And most importantly - strings are simple. Every C programmer (worth the > name) understands strings. But now you'd be forcing every API user to > understand and remember this new API. I'll reply

Re: [FFmpeg-devel] [PATCH 001/244] Add a new channel layout API

2020-01-12 Thread Nicolas George
Anton Khirnov (12020-01-07): > How is it any better in the unsigned case? You do a well-defined > unsigned overflow and end up with an invalid channel count (which might > even look sane). I explained this: you can guard against defined behaviors, not against undefined behaviors, because the compi

Re: [FFmpeg-devel] [PATCH 001/244] Add a new channel layout API

2020-01-12 Thread Nicolas George
Anton Khirnov (12020-01-07): > This API is the simplest way I could think of that achieves the desired > goals (bundling the channel count+layout together, allowing arbitrary > channel counts, ambisonic,...). Most things doable with the current API > are just as simple in the new one. What I am sa

Re: [FFmpeg-devel] [PATCH 1/8] lavu/pix_fmt: add new pixel format y210

2020-01-12 Thread Carl Eugen Hoyos
Am So., 12. Jan. 2020 um 08:57 Uhr schrieb Fu, Linjie : > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Mark Thompson > > Sent: Thursday, January 9, 2020 05:47 > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH 1/8] lavu/pix_fmt: add new pixel format >

Re: [FFmpeg-devel] AVWriter API

2020-01-12 Thread Josh de Kock
Hi, I have very little time to work on FFmpeg lately but this thread caught my interest. Nicolas George writes: > Anton Khirnov (12020-01-07): >> And most importantly - strings are simple. Every C programmer (worth the >> name) understands strings. But now you'd be forcing every API user to >> u

Re: [FFmpeg-devel] [PATCH 2/8] swscale: Add swscale input support for Y210

2020-01-12 Thread Carl Eugen Hoyos
Am So., 29. Dez. 2019 um 17:40 Uhr schrieb Linjie Fu : > > Add swscale input support for Y210, output support and fate > test could be added later if there is requirement for software > CSC to this packed format. > > Signed-off-by: Linjie Fu > --- > libswscale/input.c | 48 +++

Re: [FFmpeg-devel] AVWriter API

2020-01-12 Thread Hendrik Leppkes
On Sun, Jan 12, 2020 at 5:45 PM Josh de Kock wrote: > > > Hi, > > I have very little time to work on FFmpeg lately but this thread caught > my interest. > > Nicolas George writes: > > Anton Khirnov (12020-01-07): > >> And most importantly - strings are simple. Every C programmer (worth the > >> na

Re: [FFmpeg-devel] [PATCH] HEVC: Export motion vectors to frame side data.

2020-01-12 Thread Andriy Gelman
Hello Asaf, If you compile the code, there are many warning about mixed declaration and code. I had a quick look code and have comments below: On Sun, 29. Dec 16:08, Asaf Kave wrote: > --- > libavcodec/hevc_refs.c | 15 > libavcodec/hevcdec.c | 173

[FFmpeg-devel] [PATCH 1/4] avfilter/vf_normalize: move luts into private context

2020-01-12 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_normalize.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_normalize.c b/libavfilter/vf_normalize.c index 2e1b274f8c..ef97aecc0e 100644 --- a/libavfilter/vf_normalize.c +++ b/libavfilter/vf_normalize.c @@ -

[FFmpeg-devel] [PATCH 2/4] avfilter/vf_normalize: factor code dealing with AVFrame pixels out

2020-01-12 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_normalize.c | 69 -- 1 file changed, 43 insertions(+), 26 deletions(-) diff --git a/libavfilter/vf_normalize.c b/libavfilter/vf_normalize.c index ef97aecc0e..d353d8b75a 100644 --- a/libavfilter/vf_normalize.c +++

[FFmpeg-devel] [PATCH 3/4] avfilter/vf_normalize: add support for planar rgb

2020-01-12 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_normalize.c | 51 +++--- 1 file changed, 48 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_normalize.c b/libavfilter/vf_normalize.c index d353d8b75a..6a8a7631bc 100644 --- a/libavfilter/vf_normalize.c +++ b

[FFmpeg-devel] [PATCH 4/4] avfilter/vf_normalize: add support for >8 depth

2020-01-12 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_normalize.c | 121 - 1 file changed, 105 insertions(+), 16 deletions(-) diff --git a/libavfilter/vf_normalize.c b/libavfilter/vf_normalize.c index 6a8a7631bc..a008c14f3c 100644 --- a/libavfilter/vf_normalize.c +++

Re: [FFmpeg-devel] [PATCH 001/244] Add a new channel layout API

2020-01-12 Thread Anton Khirnov
Quoting Nicolas George (2020-01-12 14:28:06) > Anton Khirnov (12020-01-07): > > How is it any better in the unsigned case? You do a well-defined > > unsigned overflow and end up with an invalid channel count (which might > > even look sane). > > I explained this: you can guard against defined beha

Re: [FFmpeg-devel] [PATCH 1/9] avformat/s337m: Use base AVClass for av_log usage

2020-01-12 Thread Tomas Härdin
fre 2020-01-03 klockan 16:56 +0100 skrev Nicolas Gaullier: > s337m_get_offset_and_codec does not make use of > AVFormatContext: AVClass is enough for logging. > Will facilitate further use from outside > --- > libavformat/s337m.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) >

Re: [FFmpeg-devel] [PATCH 2/9] avformat/s337m: Split read_packet/get_packet

2020-01-12 Thread Tomas Härdin
fre 2020-01-03 klockan 16:56 +0100 skrev Nicolas Gaullier: > Prepare use of s337m_get_packet from outside. > --- > libavformat/s337m.c | 28 +--- > libavformat/s337m.h | 38 ++ > 2 files changed, 59 insertions(+), 7 deletions(-) > create

Re: [FFmpeg-devel] [PATCH 3/9] avformat/s337m: Consider container bit resolution

2020-01-12 Thread Tomas Härdin
fre 2020-01-03 klockan 16:56 +0100 skrev Nicolas Gaullier: > Prepare the support of s337m in muxers other than raw (ex: wav). > For example, this forbids reading 16 bits DolbyE stream from a 24 bit wav > file. > --- > libavformat/s337m.c | 20 ++-- > libavformat/s337m.h | 3 ++- >

Re: [FFmpeg-devel] [PATCH 4/9] avformat/s337m: New ff_s337m_probe()

2020-01-12 Thread Tomas Härdin
fre 2020-01-03 klockan 16:56 +0100 skrev Nicolas Gaullier: > Similar to ff_spdif_probe() with two additionnal parameters: > - an AVClass for logging > - the bit resolution of the container as it may be 16 or 24 for s337m > --- > libavformat/s337m.c | 35 +++ > libav

Re: [FFmpeg-devel] [PATCH 5/9] avformat/wavdec: s337m support

2020-01-12 Thread Tomas Härdin
fre 2020-01-03 klockan 16:56 +0100 skrev Nicolas Gaullier: > Add s337m probing/reading similarly to spdif. > Add a new AVOption 'dolbyeprobe' to enable it. > --- > libavformat/wavdec.c | 23 +++ > 1 file changed, 19 insertions(+), 4 deletions(-) > > -static void set_spdif(AVF

Re: [FFmpeg-devel] [PATCH 6/9] avformat/wavdec: fix s337m/spdif probing beyond data_end

2020-01-12 Thread Tomas Härdin
fre 2020-01-03 klockan 16:56 +0100 skrev Nicolas Gaullier: > --- > libavformat/wavdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c > index 2796905e1f..ccb9576b84 100644 > --- a/libavformat/wavdec.c > +++ b/libavformat/wavde

Re: [FFmpeg-devel] [PATCH 7/9] avformat/wavdec: Fix s337m last packet parsing

2020-01-12 Thread Tomas Härdin
fre 2020-01-03 klockan 16:56 +0100 skrev Nicolas Gaullier: > Fix reading beyond data_end. > --- > libavformat/wavdec.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c > index ccb9576b84..039ec1658e 100644 > --- a/libavfo

Re: [FFmpeg-devel] [PATCH 9/9] avformat/wavdec: Test s337m

2020-01-12 Thread Tomas Härdin
fre 2020-01-03 klockan 16:56 +0100 skrev Nicolas Gaullier: > Test the new 'dolbyeprobe' AVOption. > Test dolby_e decoding for 24 bits with program config '5.1+2' > --- > tests/Makefile | 1 + > tests/fate-run.sh| 4 > tests/fate/audio.mak | 5 + > 3 files changed, 10 insertions(

[FFmpeg-devel] [PATCH v2 1/3] avformat/apngdec: Return error for incomplete header

2020-01-12 Thread Andreas Rheinhardt
If avio_read() could read anything, it returns the number of bytes read, even if it could not read as much as the caller desired. apng_read_header() only checked the return value of its avio_read() calls for being negative and this meant that it was possible for an incomplete header to not be detec

[FFmpeg-devel] [PATCH v2 2/3] avformat/apngdec: Fix size/overflow checks

2020-01-12 Thread Andreas Rheinhardt
apng data consists of parts containing a small header (including a four-byte size field) and a data part; the size field does not account for everything and is actually twelve bytes short of the actual size. In order to make sure that the size fits into an int, the size field is checked for being >

[FFmpeg-devel] [PATCH v2 3/3] avformat/apngdec: Remove goto fail that does nothing

2020-01-12 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/apngdec.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/libavformat/apngdec.c b/libavformat/apngdec.c index e9c317efbf..13b66d700c 100644 --- a/libavformat/apngdec.c +++ b/libavformat/apngdec.c @@

Re: [FFmpeg-devel] [PATCH 1/2] avformat/aviobuf: Remove AVIOInternal and one level of indirection

2020-01-12 Thread Andreas Rheinhardt
On Mon, Jan 6, 2020 at 3:51 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > In the Libav commit cae448cf, the opaque of every AVIOContext opened > by ffio_fdopen() (which is used internally by avio_open() and avio_open2()) > changed: It was a simple pointer to an URLContext before,

Re: [FFmpeg-devel] [PATCH V1 11/11] lavfi/vulume: enable runtime change flag

2020-01-12 Thread myp...@gmail.com
On Sun, Jan 12, 2020 at 2:44 AM Michael Niedermayer wrote: > > On Sat, Jan 11, 2020 at 12:13:58PM +0800, Jun Zhao wrote: > > From: Jun Zhao > > > > enable runtime change flag. > > > > Signed-off-by: Jun Zhao > > --- > > libavfilter/af_volume.c |3 ++- > > 1 files changed, 2 insertions(+),

Re: [FFmpeg-devel] [PATCH V1] doc/general: Add avs2 decoder/encoder entry

2020-01-12 Thread myp...@gmail.com
On Sat, Jan 11, 2020 at 1:26 PM Gyan wrote: > > > > On 11-01-2020 09:42 am, Jun Zhao wrote: > > From: Jun Zhao > > > > Add avs2 decoder/encoder entry > > > > Signed-off-by: Jun Zhao > > --- > > doc/general.texi |2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git

Re: [FFmpeg-devel] New Defects reported by Coverity Scan for FFmpeg/FFmpeg (fwd)

2020-01-12 Thread myp...@gmail.com
On Sun, Jan 12, 2020 at 5:54 AM Marton Balint wrote: > > Hi, > > Has anybody reported these and similar false positives involving > av_dict_set() with a 0 flag to Coverity? > > These are popping up all over the codebase, something should be done to > make Coverity smarter about them. Any ideas? In

Re: [FFmpeg-devel] [PATCH V1 01/11] lavfi/spp: add "quality" option in runtime change path

2020-01-12 Thread myp...@gmail.com
On Sun, Jan 12, 2020 at 2:50 AM Michael Niedermayer wrote: > > On Sat, Jan 11, 2020 at 12:13:48PM +0800, Jun Zhao wrote: > > From: Jun Zhao > > > > it's stranage to use option "level" in runtime change path but used > > "quality" in option, add "quality" in runtime change path, it's more > > intu

Re: [FFmpeg-devel] [PATCH V1 01/11] lavfi/spp: add "quality" option in runtime change path

2020-01-12 Thread myp...@gmail.com
On Mon, Jan 13, 2020 at 9:19 AM myp...@gmail.com wrote: > > On Sun, Jan 12, 2020 at 2:50 AM Michael Niedermayer > wrote: > > > > On Sat, Jan 11, 2020 at 12:13:48PM +0800, Jun Zhao wrote: > > > From: Jun Zhao > > > > > > it's stranage to use option "level" in runtime change path but used > > > "q

[FFmpeg-devel] [PATCH 1/6] doc/v4l2_m2m: Add documentation

2020-01-12 Thread Andriy Gelman
From: Andriy Gelman Signed-off-by: Andriy Gelman --- doc/decoders.texi | 12 doc/encoders.texi | 27 +++ 2 files changed, 39 insertions(+) diff --git a/doc/decoders.texi b/doc/decoders.texi index f18226b3504..222f681810b 100644 --- a/doc/decoders.texi +++ b

[FFmpeg-devel] [PATCH 4/6] avcodec/v4l2_context: Use AVERROR macro

2020-01-12 Thread Andriy Gelman
From: Andriy Gelman Signed-off-by: Andriy Gelman --- libavcodec/v4l2_context.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_context.c index d38ff732dbf..5b8d5f225cd 100644 --- a/libavcodec/v4l2_context.c +++ b/libavcodec/v4l

[FFmpeg-devel] [PATCH 3/6] avcodec/v4l2_m2m: Simplify capture buffer init check

2020-01-12 Thread Andriy Gelman
From: Andriy Gelman Before this commit s->avctx == NULL was used to infer that an encoder is being initialzed. Code readability has been improved by directly using !av_codec_is_decoder() instead. Signed-off-by: Andriy Gelman --- libavcodec/v4l2_m2m.c | 4 ++-- libavcodec/v4l2_m2m_enc.c | 2

[FFmpeg-devel] [PATCH 6/6] avcodec/v4l2_m2m: Cosmetics

2020-01-12 Thread Andriy Gelman
From: Andriy Gelman Change pointer symbol position. Signed-off-by: Andriy Gelman --- libavcodec/v4l2_m2m.c | 10 +- libavcodec/v4l2_m2m_dec.c | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/v4l2_m2m.c b/libavcodec/v4l2_m2m.c index 6f62e694125..d0b

[FFmpeg-devel] [PATCH 5/6] avcodec/v4l2_m2m: Use consistent logging context

2020-01-12 Thread Andriy Gelman
From: Andriy Gelman Before this commit v4l2_m2m used two different logging contexts (from V4L2m2mPriv and AVCodecContext). For consistency always use AVCodecContext. Signed-off-by: Andriy Gelman --- libavcodec/v4l2_context.c | 2 +- libavcodec/v4l2_m2m.c | 18 +- 2 files c

[FFmpeg-devel] [PATCH 2/6] avcodec:v4l2_context: Remove NULL initialization

2020-01-12 Thread Andriy Gelman
From: Andriy Gelman Signed-off-by: Andriy Gelman --- libavcodec/v4l2_context.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_context.c index bdc2b841530..d38ff732dbf 100644 --- a/libavcodec/v4l2_context.c +++ b/libavcodec/v

Re: [FFmpeg-devel] [PATCH 1/6] doc/v4l2_m2m: Add documentation

2020-01-12 Thread Gyan
On 13-01-2020 09:41 am, Andriy Gelman wrote: From: Andriy Gelman Signed-off-by: Andriy Gelman --- doc/decoders.texi | 12 doc/encoders.texi | 27 +++ 2 files changed, 39 insertions(+) diff --git a/doc/decoders.texi b/doc/decoders.texi index f18226b35

[FFmpeg-devel] ffplay is not working on ARM processor

2020-01-12 Thread Parameshwaran Thangaraj
Hi Team, I would like to cross compile ffmpeg and ffplay for linux embedded with ARM processor. Other parameters: *Toradex Apalis iMX6* *RAM 1GB* ffmpeg is working fine. But ffplay is not working. Shows following error,