Re: [FFmpeg-devel] [PATCHv2 1/3] avutil/eval: separate AVExpr state to a new AVExprState struct

Quoting Marton Balint (2019-12-30 23:23:40) > Also add helper functions to allocate and free such a struct, and make it > usable by providing a new av_eval_expr2 function for which you can specify a > custom AVExprState. Why not just parse the expression multiple times? Performance? Beyond that,

Re: [FFmpeg-devel] [PATCH] lavc/qsv: adding DX11 support

Quoting Artem Galin (2019-12-23 19:31:04) > This enables DX11 support for QSV with higher priority than DX9. > In case of multiple GPUs configuration, DX9 API does not allow to get > access to QSV device in some cases - headless. > Implementation based on DX11 resolves that restriction by enumerati

[FFmpeg-devel] [PATCH 2/2] avio: do not export avpriv_io_{move, delete}

They are private and not used by anything outside of lavf. There is no reason for them to be exported. --- libavformat/avio.c| 4 ++-- libavformat/avio.h| 19 --- libavformat/dashenc.c | 10 +- libavformat/url.h | 20 4 files changed, 27 in

[FFmpeg-devel] [PATCH 1/2] examples/avio_dir_cmd: drop support for move/delete operations

They use non-public functions, which is unacceptable for a public API example. Rename the example back to avio_list_dir. This effectively reverts c84d208c275d6a43b3c3421d38772179abf8acee and 767d780ec001167b2fd8f6cfe4ef78a3a8b1e34c. --- configure | 4 +- doc/e

Re: [FFmpeg-devel] [PATCH 2/2] avio: do not export avpriv_io_{move, delete}

On 1/10/2020 8:21 AM, Anton Khirnov wrote: > They are private and not used by anything outside of lavf. There is no > reason for them to be exported. > --- > libavformat/avio.c| 4 ++-- > libavformat/avio.h| 19 --- > libavformat/dashenc.c | 10 +- > libavformat/ur

Re: [FFmpeg-devel] [PATCH 1/2] examples/avio_dir_cmd: drop support for move/delete operations

On 1/10/2020 8:21 AM, Anton Khirnov wrote: > They use non-public functions, which is unacceptable for a public API > example. Rename the example back to avio_list_dir. > > This effectively reverts c84d208c275d6a43b3c3421d38772179abf8acee and > 767d780ec001167b2fd8f6cfe4ef78a3a8b1e34c. LGTM, these

Re: [FFmpeg-devel] [PATCH] CDToons decoder

On 1/5/20, Alyssa Milburn wrote: > This adds a decoder for Broderbund's sprite-based QuickTime CDToons > codec, based on the decoder I wrote for ScummVM. > > A couple of samples can be found at http://noopwafel.net/cdtoons/. > > Signed-off-by: Alyssa Milburn > --- > Changelog | 1

Re: [FFmpeg-devel] [PATCH v2] fate: Don't use depreceated keepside option

On Mon, Dec 30, 2019 at 1:43 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > The tests for concat use this option which is scheduled for removal and > does nothing any more. So remove it; otherwise, these tests would fail > at the next major version bump. > > Signed-off-by: Andreas

Re: [FFmpeg-devel] [PATCH 2/2] avio: do not export avpriv_io_{move, delete}

Quoting James Almer (2020-01-10 14:33:06) > On 1/10/2020 8:21 AM, Anton Khirnov wrote: > > They are private and not used by anything outside of lavf. There is no > > reason for them to be exported. > > --- > > libavformat/avio.c| 4 ++-- > > libavformat/avio.h| 19 --- > >

[FFmpeg-devel] [PATCH] avformat/hlsenc: compare without the last directory separator in get_relative_url

fix ticket: 8461 Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index d130f03ea6..e87f08b0e6 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -1234,7 +1234,7 @@ stat

Re: [FFmpeg-devel] [PATCH v2] fate: Don't use depreceated keepside option

On 1/10/2020 11:04 AM, Andreas Rheinhardt wrote: > On Mon, Dec 30, 2019 at 1:43 PM Andreas Rheinhardt < > andreas.rheinha...@gmail.com> wrote: > >> The tests for concat use this option which is scheduled for removal and >> does nothing any more. So remove it; otherwise, these tests would fail >> a

Re: [FFmpeg-devel] [PATCH 7/7] avformat/mov: Use AV_DICT_DONT_STRDUP_VAL to avoid av_strdup

On Sun, Nov 10, 2019 at 05:07:33AM +0100, Andreas Rheinhardt wrote: > This will likely also fix CID 1452574 and 1452565, false positives > resulting from Coverity thinking that av_dict_set() automatically > frees its key and value parameters (even without the > AV_DICT_DONT_STRDUP_* flags). > > Si

Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_showinfo: fix the integer handling issues

On Thu, Jan 09, 2020 at 09:02:11AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Fixes CID 1457606 and 1457607 > Signed-off-by: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_showinfo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) will apply thx

Re: [FFmpeg-devel] [PATCH v1] avcodec/utils: replace avctx->internal with avci for better readability

On Thu, Jan 09, 2020 at 09:04:33AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/utils.c | 63 > -- > 1 file changed, 33 insertions(+), 30 deletions(-) will apply thx [...] -- Mic

Re: [FFmpeg-devel] [PATCH] avfilter/f_metadata: allow direct flushing when printing to file

On 10-01-2020 11:00 am, Gyan wrote: On 07-01-2020 05:44 pm, Gyan Doshi wrote: Useful for monitoring sparse data in realtime ---   doc/filters.texi | 3 +++   libavfilter/f_metadata.c | 6 ++   2 files changed, 9 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index

Re: [FFmpeg-devel] [PATCH v3 3/3] doc/encoders: add VP9 temporal scalability encoding option

On Thu, Jan 9, 2020 at 8:09 PM James Zern wrote: > On Wed, Jan 8, 2020 at 3:00 PM Wonkap Jang > wrote: > > > > Documentation change for adding support for encoding > > with temporal scalability in VP9. > > --- > > doc/encoders.texi | 18 +++--- > > 1 file changed, 15 insertions(+),

Re: [FFmpeg-devel] [PATCHv2 1/3] avutil/eval: separate AVExpr state to a new AVExprState struct

On Fri, 10 Jan 2020, Anton Khirnov wrote: Quoting Marton Balint (2019-12-30 23:23:40) Also add helper functions to allocate and free such a struct, and make it usable by providing a new av_eval_expr2 function for which you can specify a custom AVExprState. Why not just parse the expression

Re: [FFmpeg-devel] [PATCH 1/2] examples/avio_dir_cmd: drop support for move/delete operations

On Fri, 10 Jan 2020, James Almer wrote: On 1/10/2020 8:21 AM, Anton Khirnov wrote: They use non-public functions, which is unacceptable for a public API example. Rename the example back to avio_list_dir. This effectively reverts c84d208c275d6a43b3c3421d38772179abf8acee and 767d780ec001167b2f

[FFmpeg-devel] [PATCH v4 1/2] avcodec/libvpxenc: add VP9 temporal scalability encoding option

This commit reuses the configuration options for VP8 that enables temporal scalability for VP9. It also adds a way to enable three preset temporal structures (refer to the documentation for more detail) that can be used in offline encoding. --- doc/encoders.texi | 18 ++- libavcodec/libvpxen

[FFmpeg-devel] [PATCH v4 2/2] avcodec/libvpxenc: add a way to explicitly set temporal layer id

In order for rate control to correctly allocate bitrate to each temporal layer, correct temporal layer id has to be set to each frame. This commit provides the ability to set correct temporal layer id for each frame. --- libavcodec/libvpxenc.c | 13 - 1 file changed, 12 insertions(+),

Re: [FFmpeg-devel] [PATCH 2/2] avio: do not export avpriv_io_{move, delete}

On Fri, 10 Jan 2020, Anton Khirnov wrote: Quoting James Almer (2020-01-10 14:33:06) On 1/10/2020 8:21 AM, Anton Khirnov wrote: > They are private and not used by anything outside of lavf. There is no > reason for them to be exported. > --- > libavformat/avio.c| 4 ++-- > libavformat/avi

Re: [FFmpeg-devel] [PATCH 2/2] avio: do not export avpriv_io_{move, delete}

On 1/10/2020 11:30 AM, Anton Khirnov wrote: > Quoting James Almer (2020-01-10 14:33:06) >> On 1/10/2020 8:21 AM, Anton Khirnov wrote: >>> They are private and not used by anything outside of lavf. There is no >>> reason for them to be exported. >>> --- >>> libavformat/avio.c| 4 ++-- >>> liba

Re: [FFmpeg-devel] [PATCH 1/2] examples/avio_dir_cmd: drop support for move/delete operations

On 1/10/2020 2:57 PM, Marton Balint wrote: > > > On Fri, 10 Jan 2020, James Almer wrote: > >> On 1/10/2020 8:21 AM, Anton Khirnov wrote: >>> They use non-public functions, which is unacceptable for a public API >>> example. Rename the example back to avio_list_dir. >>> >>> This effectively rever

Re: [FFmpeg-devel] [PATCH v4 1/2] avcodec/libvpxenc: add VP9 temporal scalability encoding option

On Fri, Jan 10, 2020 at 9:59 AM Wonkap Jang wrote: > This commit reuses the configuration options for VP8 that enables > temporal scalability for VP9. It also adds a way to enable three > preset temporal structures (refer to the documentation for more > detail) that can be used in offline encodin

Re: [FFmpeg-devel] [PATCH] avformat/image2: Upon request, make available extra metadata, fields related to input path to be used by filters.

On 09/01/2020 21:39, Marton Balint wrote: > > > On Sat, 4 Jan 2020, Alexandre Heitor Schmidt wrote: > >> Hi there! I'm just writing to make sure this patch wasn't forgotten. :) > > Thanks, I think the patch is fine now, I will apply it tomorrow if there are no further comments. > > Regards, > Ma

[FFmpeg-devel] [PATCH] tiffdec: support embedded ICC profiles

Patch attached. Very widespread, every NASA TIFF image has an ICC profile embedded, and its almost never sRGB, so this is really needed for proper color display. >From 1a3cbad82c897110e8ef221aae9733b841a443fc Mon Sep 17 00:00:00 2001 From: Lynne Date: Fri, 10 Jan 2020 21:55:19 + Subject: [PA

[FFmpeg-devel] [PATCH 3/3] tools/target_dec_fuzzer: limit per frame samples for APE

APE in its highest compression mode is really slow so even one frame of millions of samples takes a long time Fixes: Timeout (too long -> 3sec) Fixes: 19937/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5751668818051072 Signed-off-by: Michael Niedermayer --- tools/target_dec_fuz

[FFmpeg-devel] [PATCH 1/3] avcodec/ralf: Fix integer overflow in apply_lpc()

Fixes: signed integer overflow: 2147482897 + 2048 cannot be represented in type 'int' Fixes: 19240/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RALF_fuzzer-5743240326414336 Fixes: 19869/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RALF_fuzzer-5150136636538880 Found-by: continuous fuzz

[FFmpeg-devel] [PATCH 2/3] avcodec/agm: YUV420 without DCT needs even dimensions

Fixes: out of array access Fixes: 19892/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AGM_fuzzer-5707525924323328 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/agm.c | 5 + 1 file ch

Re: [FFmpeg-devel] [PATCH] avformat/image2: Upon request, make available extra metadata, fields related to input path to be used by filters.

On Fri, 10 Jan 2020, Alexandre Heitor Schmidt wrote: On 09/01/2020 21:39, Marton Balint wrote: > > > On Sat, 4 Jan 2020, Alexandre Heitor Schmidt wrote: > >> Hi there! I'm just writing to make sure this patch wasn't forgotten. :) > > Thanks, I think the patch is fine now, I will apply it tomor

Re: [FFmpeg-devel] [PATCH 2/2] avio: do not export avpriv_io_{move, delete}

On Fri, Jan 10, 2020 at 7:31 PM James Almer wrote: > > On 1/10/2020 11:30 AM, Anton Khirnov wrote: > > Quoting James Almer (2020-01-10 14:33:06) > >> On 1/10/2020 8:21 AM, Anton Khirnov wrote: > >>> They are private and not used by anything outside of lavf. There is no > >>> reason for them to be

[FFmpeg-devel] [PATCH V1] doc/general: Add avs2 decoder/encoder entry

From: Jun Zhao Add avs2 decoder/encoder entry Signed-off-by: Jun Zhao --- doc/general.texi |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/doc/general.texi b/doc/general.texi index a5b77e0..e668599 100644 --- a/doc/general.texi +++ b/doc/general.texi @@ -819,6 +819,8

[FFmpeg-devel] [PATCH V1 06/11] lavfi/streamselect: enable runtime change flag

From: Jun Zhao enable runtime change flag. Signed-off-by: Jun Zhao --- libavfilter/f_streamselect.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libavfilter/f_streamselect.c b/libavfilter/f_streamselect.c index 7a1ff77..b3ae4be 100644 --- a/libavfilter/f_streamsel

[FFmpeg-devel] [PATCH V1 05/11] lavfi/scale: enable runtime change flag

From: Jun Zhao enable runtime change flag. Signed-off-by: Jun Zhao --- libavfilter/vf_scale.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index 8620d1c..81b2207 100644 --- a/libavfilter/vf_scale.c +++ b/libavf

[FFmpeg-devel] [PATCH V1 08/11] lavfi/eq: enable runtime change flag

From: Jun Zhao enable runtime change flag Signed-off-by: Jun Zhao --- libavfilter/vf_eq.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/libavfilter/vf_eq.c b/libavfilter/vf_eq.c index 914a07f..f4cf499 100644 --- a/libavfilter/vf_eq.c +++ b/libavfilte

[FFmpeg-devel] [PATCH V1 09/11] lavfi/firequalizer: enable runtime change flag

From: Jun Zhao enable runtime change flag Signed-off-by: Jun Zhao --- libavfilter/af_firequalizer.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_firequalizer.c b/libavfilter/af_firequalizer.c index 00ddc87..f4513a1 100644 --- a/libavfilter/af_fire

[FFmpeg-devel] [PATCH V1 11/11] lavfi/vulume: enable runtime change flag

From: Jun Zhao enable runtime change flag. Signed-off-by: Jun Zhao --- libavfilter/af_volume.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libavfilter/af_volume.c b/libavfilter/af_volume.c index b106ed8..213c571 100644 --- a/libavfilter/af_volume.c +++ b/libavfi

[FFmpeg-devel] [PATCH V1 10/11] lavfi/zscale: enable runtime change flag

From: Jun Zhao enable runtime change flag Signed-off-by: Jun Zhao --- libavfilter/vf_zscale.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index db2dd17..46c5dd7 100644 --- a/libavfilter/vf_zscale.c +++ b/lib

[FFmpeg-devel] [PATCH V1 04/11] lavfi/hue: enable runtime change flag

From: Jun Zhao enable runtime change flag. Signed-off-by: Jun Zhao --- libavfilter/vf_hue.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavfilter/vf_hue.c b/libavfilter/vf_hue.c index 32b..026d4b6 100644 --- a/libavfilter/vf_hue.c +++ b/libavfilter/vf_hue.c

[FFmpeg-devel] [PATCH V1 02/11] lavfi/spp: enable runtime change flag

From: Jun Zhao enable runtime change flag. Signed-off-by: Jun Zhao --- libavfilter/vf_spp.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libavfilter/vf_spp.c b/libavfilter/vf_spp.c index db381cd..7381938 100644 --- a/libavfilter/vf_spp.c +++ b/libavfilter/vf_spp.c

[FFmpeg-devel] [PATCH V1 01/11] lavfi/spp: add "quality" option in runtime change path

From: Jun Zhao it's stranage to use option "level" in runtime change path but used "quality" in option, add "quality" in runtime change path, it's more intuitive and keep the "level" for compatibility. Signed-off-by: Jun Zhao --- doc/filters.texi |9 + libavfilter/vf_spp.c |

[FFmpeg-devel] [PATCH V1 07/11] lavfi/rotate: enable runtime change flag

From: Jun Zhao enable runtime change flag Signed-off-by: Jun Zhao --- libavfilter/vf_rotate.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_rotate.c b/libavfilter/vf_rotate.c index 371ff7f..378be44 100644 --- a/libavfilter/vf_rotate.c +++ b/libavfi

[FFmpeg-devel] [PATCH 2/2] avformat/libzmq: Replace fail statements with goto

From: Andriy Gelman Signed-off-by: Andriy Gelman --- libavformat/libzmq.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/libavformat/libzmq.c b/libavformat/libzmq.c index 2df55542c7e..8c8b294c921 100644 --- a/libavformat/libzmq.c +++ b/libavformat

[FFmpeg-devel] [PATCH 1/2] avformat/libzmq: Check return of zmq_setsockopt

From: Andriy Gelman Signed-off-by: Andriy Gelman --- libavformat/libzmq.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavformat/libzmq.c b/libavformat/libzmq.c index d86488293ff..2df55542c7e 100644 --- a/libavformat/libzmq.c +++ b/libavformat/libzmq.c @@ -123,7

[FFmpeg-devel] [PATCH V1 03/11] lavfi/crop: enable runtime change flag

From: Jun Zhao enable runtime change flag. Signed-off-by: Jun Zhao --- libavfilter/vf_crop.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/libavfilter/vf_crop.c b/libavfilter/vf_crop.c index 9bf4077..8dbf1b5 100644 --- a/libavfilter/vf_crop.c +++ b/libavf

Re: [FFmpeg-devel] [PATCH V1] doc/general: Add avs2 decoder/encoder entry

On 11-01-2020 09:42 am, Jun Zhao wrote: From: Jun Zhao Add avs2 decoder/encoder entry Signed-off-by: Jun Zhao --- doc/general.texi |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/doc/general.texi b/doc/general.texi index a5b77e0..e668599 100644 --- a/doc/general

[FFmpeg-devel] [PATCH v1] avcodec/wavpack: simplify the code

From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/wavpack.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/wavpack.c b/libavcodec/wavpack.c index d024280..edc0f79 100644 --- a/libavcodec/wavpack.c +++ b/libavcodec/wavpack.c @@ -1114,9 +1114,7 @@ static

Re: [FFmpeg-devel] [PATCH] avfilter: add crossfade filter

Paul, this is useful. When can you merge this? On 24-10-2019 02:19 am, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- doc/filters.texi | 18 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_blend.c | 157 ++