Re: [FFmpeg-devel] [PATCH] checkasm: af_afir: Use a dynamic tolerance depending on values

2019-12-12 Thread Martin Storsjö
On Wed, 11 Dec 2019, Martin Storsjö wrote: As the values generated by av_bmg_get can be arbitrarily large (only the stddev is specified), we can't use a fixed tolerance. Calculate a dynamic tolerance (like in float_dsp from 38f966bdb), based on the individual steps of the calculation. This

Re: [FFmpeg-devel] [PATCH 2/3] fate: Fix use of target_path/target_samples

2019-12-12 Thread Martin Storsjö
On Tue, 10 Dec 2019, Martin Storsjö wrote: --- tests/fate-run.sh | 24 - tests/fate/filter-video.mak | 4 +- tests/fate/gapless.mak | 104 ++-- tests/fate/mov.mak | 2 +- tests/fate/seek.mak | 2 +- 5 files changed, 68 ins

Re: [FFmpeg-devel] [PATCH 1/2] rtsp: Use AVERROR() with errno.h error codes for error returns

2019-12-12 Thread Michael Niedermayer
On Wed, Dec 11, 2019 at 02:21:22PM +0200, Martin Storsjö wrote: > For this particular function, it's only required to return nonzero, > but use the common AVERROR() pattern for consistency. > --- > libavformat/rtsp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx [...] -- Mic

[FFmpeg-devel] [PATCH,v2] lavfi/vf_zscale: remove unused code

2019-12-12 Thread Linjie Fu
Signed-off-by: Linjie Fu --- libavfilter/vf_zscale.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index db2dd17..bd5825f 100644 --- a/libavfilter/vf_zscale.c +++ b/libavfilter/vf_zscale.c @@ -287,13 +287,6 @@ static int config_props(A

Re: [FFmpeg-devel] [PATCH] checkasm: af_afir: Use a dynamic tolerance depending on values

2019-12-12 Thread Michael Niedermayer
On Wed, Dec 11, 2019 at 11:21:27AM +0200, Martin Storsjö wrote: > As the values generated by av_bmg_get can be arbitrarily large > (only the stddev is specified), we can't use a fixed tolerance. > Calculate a dynamic tolerance (like in float_dsp from 38f966bdb), > based on the individual steps

Re: [FFmpeg-devel] [PATCH] checkasm: af_afir: Use a dynamic tolerance depending on values

2019-12-12 Thread Martin Storsjö
On Thu, 12 Dec 2019, Michael Niedermayer wrote: On Wed, Dec 11, 2019 at 11:21:27AM +0200, Martin Storsjö wrote: As the values generated by av_bmg_get can be arbitrarily large (only the stddev is specified), we can't use a fixed tolerance. Calculate a dynamic tolerance (like in float_dsp from 38

[FFmpeg-devel] [PATCHv2] checkasm: af_afir: Use a dynamic tolerance depending on values

2019-12-12 Thread Martin Storsjö
As the values generated by av_bmg_get can be arbitrarily large (only the stddev is specified), we can't use a fixed tolerance. Calculate a dynamic tolerance (like in float_dsp from 38f966bdb), based on the individual steps of the calculation. This fixes running this test with certain seeds, wh

[FFmpeg-devel] [PATCH v7 3/3] lavf/movenc: cosmetics

2019-12-12 Thread Yuki Tsuchiya
Signed-off-by: Yuki Tsuchiya --- libavformat/movenc.c | 64 ++-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 8456bfac6d..6eade938ba 100644 --- a/libavformat/movenc.c +++ b/libavformat/mov

[FFmpeg-devel] [PATCH v7 2/3] lavf/isom: support for demuxing and remuxing of MPEG-H 3D Audio in MP4

2019-12-12 Thread Yuki Tsuchiya
Implemented according to the specification at https://www.iso.org/standard/69561.html The 'mhm1' sample entry is registered with MP4RA, which is defined as MHAS encapsulated single stream MPEG-H 3D Audio. 'MHAS' stands for MPEG-H audio stream, which contains encoded audio data and corresponds me

[FFmpeg-devel] [PATCH v7 1/3] lavc/codec_desc: introduce AV_CODEC_PROP_INTRA_ONLY flag to audio codec

2019-12-12 Thread Yuki Tsuchiya
Introduce AV_CODEC_PROP_INTRA_ONLY flag to audio codec as well as video codec to support non intra-only audio codec. Since all audio codecs are processed as intra-only codec so far, the intra-only flag is added to the all audio codec descriptors. This commit should not change behavior. Signed-of

Re: [FFmpeg-devel] [PATCH 04/11] avformat/apngdec: Return error when header incomplete

2019-12-12 Thread Nicolas George
James Almer (12019-12-10): > An incomplete header is invalid/truncated data, so this should be either > AVERROR_INVALIDDATA or AVERROR(EIO). AVERROR_INVALIDDATA ok, but not AVERROR(EIO): there was no input our output error, except if reported by the underlying layer. We have been using AVERROR(EI

Re: [FFmpeg-devel] [PATCH v7 1/3] lavc/codec_desc: introduce AV_CODEC_PROP_INTRA_ONLY flag to audio codec

2019-12-12 Thread Andreas Rheinhardt
On Thu, Dec 12, 2019 at 12:47 PM Yuki Tsuchiya wrote: > Introduce AV_CODEC_PROP_INTRA_ONLY flag to audio codec as well as video > codec to support non intra-only audio codec. > Since all audio codecs are processed as intra-only codec so far, the > intra-only flag is added to the all audio codec d

Re: [FFmpeg-devel] [PATCH v7 1/3] lavc/codec_desc: introduce AV_CODEC_PROP_INTRA_ONLY flag to audio codec

2019-12-12 Thread James Almer
On 12/12/2019 9:10 AM, Andreas Rheinhardt wrote: > On Thu, Dec 12, 2019 at 12:47 PM Yuki Tsuchiya > wrote: > >> Introduce AV_CODEC_PROP_INTRA_ONLY flag to audio codec as well as video >> codec to support non intra-only audio codec. >> Since all audio codecs are processed as intra-only codec so fa

[FFmpeg-devel] [PATCH] avcodec/mlp_parser: mark sync frames as key frames

2019-12-12 Thread James Almer
Signed-off-by: James Almer --- libavcodec/mlp_parser.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/mlp_parser.c b/libavcodec/mlp_parser.c index b5d3ff7226..5d2ddc5a70 100644 --- a/libavcodec/mlp_parser.c +++ b/libavcodec/mlp_parser.c @@ -61,6 +61,8 @@ static int mlp_parse

Re: [FFmpeg-devel] [PATCH v7 2/3] lavf/isom: support for demuxing and remuxing of MPEG-H 3D Audio in MP4

2019-12-12 Thread James Almer
On 12/12/2019 8:38 AM, Yuki Tsuchiya wrote: > Implemented according to the specification at > https://www.iso.org/standard/69561.html > The 'mhm1' sample entry is registered with MP4RA, which is defined as MHAS > encapsulated single stream MPEG-H 3D Audio. > 'MHAS' stands for MPEG-H audio stream,

Re: [FFmpeg-devel] [PATCH v7 1/3] lavc/codec_desc: introduce AV_CODEC_PROP_INTRA_ONLY flag to audio codec

2019-12-12 Thread Tsuchiya, Yuki (SHES)
Hi, Thank you for the feedbacks. On 2019/12/12 21:32, "James Almer" wrote: On 12/12/2019 9:10 AM, Andreas Rheinhardt wrote: >> Not all audio codecs are intra-only. TrueHD is a notable exception: It uses >> sync frames and only they should be keyframes. > > Correct. But befo

Re: [FFmpeg-devel] [PATCH v7 2/3] lavf/isom: support for demuxing and remuxing of MPEG-H 3D Audio in MP4

2019-12-12 Thread Tsuchiya, Yuki (SHES)
Hi James, On 2019/12/12 21:45, "ffmpeg-devel on behalf of James Almer" wrote: >> diff --git a/libavformat/movenc.c b/libavformat/movenc.c >> index dd144ae20a..8456bfac6d 100644 >> --- a/libavformat/movenc.c >> +++ b/libavformat/movenc.c >> @@ -2493,6 +2493,7 @@ static int m

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: add Tiles encode support for HEVC

2019-12-12 Thread Zhong Li
Will apply. Thanks! Fu, Linjie 于2019年12月10日周二 上午8:57写道: > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Zhong Li > > Sent: Sunday, December 8, 2019 16:32 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH] lavc/

Re: [FFmpeg-devel] [PATCH v7 2/3] lavf/isom: support for demuxing and remuxing of MPEG-H 3D Audio in MP4

2019-12-12 Thread Moritz Barsnick
On Thu, Dec 12, 2019 at 20:38:39 +0900, Yuki Tsuchiya wrote: > #define LIBAVCODEC_VERSION_MAJOR 58 > -#define LIBAVCODEC_VERSION_MINOR 64 > +#define LIBAVCODEC_VERSION_MINOR 65 > #define LIBAVCODEC_VERSION_MICRO 101 Nit: reset MICRO to 100 when bumping MINOR (or MAJOR). Moritz __

Re: [FFmpeg-devel] [PATCH v7 2/3] lavf/isom: support for demuxing and remuxing of MPEG-H 3D Audio in MP4

2019-12-12 Thread Tsuchiya, Yuki (SHES)
Thank you for pointing it out. I'll fix. On 2019/12/12 22:51, "ffmpeg-devel on behalf of Moritz Barsnick" wrote: On Thu, Dec 12, 2019 at 20:38:39 +0900, Yuki Tsuchiya wrote: > #define LIBAVCODEC_VERSION_MAJOR 58 > -#define LIBAVCODEC_VERSION_MINOR 64 > +#define LIBAVCODEC_VE

Re: [FFmpeg-devel] [PATCH v7 2/3] lavf/isom: support for demuxing and remuxing of MPEG-H 3D Audio in MP4

2019-12-12 Thread James Almer
On 12/12/2019 9:57 AM, Tsuchiya, Yuki (SHES) wrote: > Hi James, > > On 2019/12/12 21:45, "ffmpeg-devel on behalf of James Almer" > wrote: > > >> diff --git a/libavformat/movenc.c b/libavformat/movenc.c > >> index dd144ae20a..8456bfac6d 100644 > >> --- a/libavformat/movenc.c > >

[FFmpeg-devel] [PATCH v8 4/4] lavf/movenc: cosmetics

2019-12-12 Thread Yuki Tsuchiya
Signed-off-by: Yuki Tsuchiya --- libavformat/movenc.c | 64 ++-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 8456bfac6d..6eade938ba 100644 --- a/libavformat/movenc.c +++ b/libavformat/mov

[FFmpeg-devel] [PATCH v8 3/4] lavf/isom: support for demuxing and remuxing of MPEG-H 3D Audio in MP4

2019-12-12 Thread Yuki Tsuchiya
Implemented according to the specification at https://www.iso.org/standard/69561.html The 'mhm1' sample entry is registered with MP4RA, which is defined as MHAS encapsulated single stream MPEG-H 3D Audio. 'MHAS' stands for MPEG-H audio stream, which contains encoded audio data and corresponds me

[FFmpeg-devel] [PATCH v8 1/4] lavc/codec_desc: introduce AV_CODEC_PROP_INTRA_ONLY flag to audio codec

2019-12-12 Thread Yuki Tsuchiya
Introduce AV_CODEC_PROP_INTRA_ONLY flag to audio codec as well as video codec to support non intra-only audio codec. Since all of the audio codecs are processed as intra-only codec in is_intra_only() so far, the intra-only flag is added to all the audio codec descriptors to doesn’t change behavi

[FFmpeg-devel] [PATCH v8 2/4] lavc/codec_desc: set TrueHD to non intra-only codec

2019-12-12 Thread Yuki Tsuchiya
Signed-off-by: Yuki Tsuchiya --- libavcodec/codec_desc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index 98b6348c59..3b0ffa0f5d 100644 --- a/libavcodec/codec_desc.c +++ b/libavcodec/codec_desc.c @@ -2691,7 +2691,7 @@ stat

Re: [FFmpeg-devel] [PATCH] lavc/hevc_cabac: fix cbf_cb and cbf_cr for transform depth 4

2019-12-12 Thread Thilo Borgmann
Hi, Am 12.12.19 um 08:27 schrieb Fu, Linjie: >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Carl Eugen Hoyos >> Sent: Wednesday, December 11, 2019 18:19 >> To: FFmpeg development discussions and patches > de...@ffmpeg.org> >> Subject: Re: [FFmpeg-devel] [PATCH] lavc/hevc_caba

Re: [FFmpeg-devel] [PATCHv2] checkasm: af_afir: Use a dynamic tolerance depending on values

2019-12-12 Thread Michael Niedermayer
On Thu, Dec 12, 2019 at 11:47:16AM +0200, Martin Storsjö wrote: > As the values generated by av_bmg_get can be arbitrarily large > (only the stddev is specified), we can't use a fixed tolerance. > Calculate a dynamic tolerance (like in float_dsp from 38f966bdb), > based on the individual steps

[FFmpeg-devel] [PATCH] FATE: add test for hevc files with 4 TUDepth(0..4) of cbf_cb/cbf_cr

2019-12-12 Thread Linjie Fu
5 cabac states for cbf_cb and cbf_cr are supported according to Table 9-4. Add a test for 64x64 4:4:4 8bit HEVC clips with TUDepth = 4, cbf_cr > 0. Signedoff-by: Xu Guangxin Signed-off-by: Linjie Fu --- tests/fate/hevc.mak | 3 +++ tests/ref/fate/hevc-cabac-tudepth | 6 ++ 2

Re: [FFmpeg-devel] [PATCH] lavc/hevc_cabac: fix cbf_cb and cbf_cr for transform depth 4

2019-12-12 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Thilo Borgmann > Sent: Thursday, December 12, 2019 22:15 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavc/hevc_cabac: fix cbf_cb and cbf_cr > for transform depth 4 > > Hi, > > Am 12.12.19 um 08:27 schrieb Fu

[FFmpeg-devel] [PATCH 2/2] avformat/microdvdenc: Use avio_w8 to write a char

2019-12-12 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/microdvdenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/microdvdenc.c b/libavformat/microdvdenc.c index 6639651e02..80e6fa8674 100644 --- a/libavformat/microdvdenc.c +++ b/libavformat/microdvdenc.c @@ -52,7 +5

[FFmpeg-devel] [PATCH 1/2] avformat/microdvd: Use \n instead of \0 to end file header

2019-12-12 Thread Andreas Rheinhardt
Up until now, the microdvd demuxer uses av_strdup() to allocate the extradata from a string; its length is set to strlen() + 1, i.e. including the \0 at the end. Upon remuxing, the muxer would simply copy the extradata at the beginning, including the \0. This commit changes this by not adding the

Re: [FFmpeg-devel] [PATCH v8 1/4] lavc/codec_desc: introduce AV_CODEC_PROP_INTRA_ONLY flag to audio codec

2019-12-12 Thread James Almer
On 12/12/2019 11:02 AM, Yuki Tsuchiya wrote: > Introduce AV_CODEC_PROP_INTRA_ONLY flag to audio codec as well as video codec > to support non intra-only audio codec. > Since all of the audio codecs are processed as intra-only codec in > is_intra_only() so far, the intra-only flag is added to all

Re: [FFmpeg-devel] [PATCH v8 3/4] lavf/isom: support for demuxing and remuxing of MPEG-H 3D Audio in MP4

2019-12-12 Thread James Almer
On 12/12/2019 11:02 AM, Yuki Tsuchiya wrote: > Implemented according to the specification at > https://www.iso.org/standard/69561.html > The 'mhm1' sample entry is registered with MP4RA, which is defined as MHAS > encapsulated single stream MPEG-H 3D Audio. > 'MHAS' stands for MPEG-H audio stream

Re: [FFmpeg-devel] [PATCH v8 4/4] lavf/movenc: cosmetics

2019-12-12 Thread James Almer
On 12/12/2019 11:02 AM, Yuki Tsuchiya wrote: > Signed-off-by: Yuki Tsuchiya > --- > libavformat/movenc.c | 64 ++-- > 1 file changed, 32 insertions(+), 32 deletions(-) Applied, thanks. ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH] lavc/x265: set preferred_transfer_characteristics for HLG

2019-12-12 Thread James Almer
On 12/4/2019 11:24 AM, Zhong Li wrote: > "HEVC HDR UHDTV Bitstreams using HLG10 shall also contain the > alternative_transfer_characteristics SEI message. The > alternative_transfer_characteristics SEI message shall be inserted on > the HEVC DVB_RAP, and preferred_transfer_characteristics shall be

[FFmpeg-devel] [PATCH] avfilter/vsrc_cellauto/life: Fix av_log type

2019-12-12 Thread Andreas Rheinhardt
This fixes an oversight in 1d757b11 and 5ee4c12e. Signed-off-by: Andreas Rheinhardt --- libavfilter/vsrc_cellauto.c | 2 +- libavfilter/vsrc_life.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vsrc_cellauto.c b/libavfilter/vsrc_cellauto.c index c75460334

[FFmpeg-devel] [PATCH V1] fftools/cmdutils: Fix break command dump for -map option

2019-12-12 Thread Jun Zhao
From: Jun Zhao Before this fix, ffmpeg -h full | grep map get the command dump like: -map [-]input_file_id[:stream_specifier][,sync_file_id[:stream_s set input stream mapping ^

Re: [FFmpeg-devel] [PATCH 3/4] avfilter/vf_dnn_processing: add format GRAY8 and GRAYF32 support

2019-12-12 Thread Pedro Arthur
Hi, how should I test this patch? Em sex., 22 de nov. de 2019 às 04:57, Guo, Yejun escreveu: > Signed-off-by: Guo, Yejun > --- > doc/filters.texi| 8 ++- > libavfilter/vf_dnn_processing.c | 147 > ++-- > 2 files changed, 118 insertions(+),

Re: [FFmpeg-devel] [PATCH] avfilter/vsrc_cellauto/life: Fix av_log type

2019-12-12 Thread Gyan
On 12-12-2019 09:45 pm, Andreas Rheinhardt wrote: This fixes an oversight in 1d757b11 and 5ee4c12e. Yours is the 3rd patch for this. https://patchwork.ffmpeg.org/patch/16658/ + https://patchwork.ffmpeg.org/patch/16657/ https://patchwork.ffmpeg.org/patch/16660/ Gyan Signed-off-by: Andr

Re: [FFmpeg-devel] [PATCH] FATE: add test for hevc files with 4 TUDepth(0..4) of cbf_cb/cbf_cr

2019-12-12 Thread James Almer
On 12/12/2019 12:25 PM, Linjie Fu wrote: > 5 cabac states for cbf_cb and cbf_cr are supported according to > Table 9-4. > > Add a test for 64x64 4:4:4 8bit HEVC clips with TUDepth = 4, cbf_cr > 0. > > Signedoff-by: Xu Guangxin > Signed-off-by: Linjie Fu > --- > tests/fate/hevc.mak

Re: [FFmpeg-devel] [PATCH 2/4] convert_from_tensorflow.py: add support when kernel size is 1*1 with one input/output channel (gray image)

2019-12-12 Thread Pedro Arthur
Em sex., 22 de nov. de 2019 às 04:57, Guo, Yejun escreveu: > > Signed-off-by: Guo, Yejun > --- > tools/python/convert_from_tensorflow.py | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tools/python/convert_from_tensorflow.py > b/tools/python/convert_from_tensorflow.

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/vf_dnn_processing: refine code for better naming

2019-12-12 Thread Pedro Arthur
Em sex., 22 de nov. de 2019 às 04:56, Guo, Yejun escreveu: > > Signed-off-by: Guo, Yejun > --- > libavfilter/vf_dnn_processing.c | 90 > - > 1 file changed, 45 insertions(+), 45 deletions(-) > > diff --git a/libavfilter/vf_dnn_processing.c b/libavfilter/v

Re: [FFmpeg-devel] [PATCH] avfilter/vsrc_cellauto/life: Fix av_log type

2019-12-12 Thread myp...@gmail.com
On Fri, Dec 13, 2019 at 12:15 AM Andreas Rheinhardt wrote: > > This fixes an oversight in 1d757b11 and 5ee4c12e. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/vsrc_cellauto.c | 2 +- > libavfilter/vsrc_life.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --g

[FFmpeg-devel] [PATCH] avcodec/cbs_h2645: Fail on all 0 NAL units

2019-12-12 Thread Michael Niedermayer
Fixes: assertion failure Fixes: 19286/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_REDUNDANT_PPS_fuzzer-5707990724509696 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cbs_h2645.c | 3 ++-

Re: [FFmpeg-devel] [PATCH] avcodec/v210dec: move the stride read after its fully initialized

2019-12-12 Thread Michael Niedermayer
On Wed, Dec 11, 2019 at 11:09:12PM +0800, Limin Wang wrote: > On Sun, Dec 01, 2019 at 11:26:47PM +0100, Michael Niedermayer wrote: > > Fixes: out of array read > > Fixes: > > 19129/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_V210_fuzzer-5068171023482880 > > Maybe fixes: > > 19130/clusterfuz

Re: [FFmpeg-devel] [PATCH] lavc/utils.c: fix code indentations

2019-12-12 Thread Michael Niedermayer
On Wed, Dec 11, 2019 at 04:52:01PM +0800, Linjie Fu wrote: > Introduced since 4b4a02b8. > > Signed-off-by: Linjie Fu > --- > libavcodec/utils.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC

Re: [FFmpeg-devel] [PATCH] lavc/mips: simplify the switch code

2019-12-12 Thread Michael Niedermayer
On Wed, Dec 11, 2019 at 04:48:03PM +0800, Linjie Fu wrote: > Signed-off-by: Linjie Fu > --- > libavcodec/mips/h264pred_init_mips.c | 3 --- > 1 file changed, 3 deletions(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The greatest way to live wit

Re: [FFmpeg-devel] [PATCH 01/11] avformat/mov: Use ff_alloc_extradata for dvdsub extradata

2019-12-12 Thread Michael Niedermayer
On Wed, Dec 11, 2019 at 04:03:12PM +0800, myp...@gmail.com wrote: > On Wed, Dec 11, 2019 at 6:00 AM Andreas Rheinhardt > wrote: > > > > Signed-off-by: Andreas Rheinhardt > > --- > > libavformat/mov.c | 11 --- > > 1 file changed, 4 insertions(+), 7 deletions(-) > > > > diff --git a/libav

Re: [FFmpeg-devel] [PATCH 02/11] avformat/apngdec: Make sure that extradata is zero-padded

2019-12-12 Thread Michael Niedermayer
On Tue, Dec 10, 2019 at 10:59:46PM +0100, Andreas Rheinhardt wrote: > Zeroing the padding has been forgotten. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/apngdec.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) will apply thx [...] -- Michael GnuPG finge

Re: [FFmpeg-devel] [PATCH 03/11] avformat/apngdec: Don't free extradata manually

2019-12-12 Thread Michael Niedermayer
On Tue, Dec 10, 2019 at 10:59:47PM +0100, Andreas Rheinhardt wrote: > The extradata will be freed automatically when the corresponding stream > gets freed. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/apngdec.c | 4 > 1 file changed, 4 deletions(-) will apply thx [...] -- M

Re: [FFmpeg-devel] [PATCH 08/11] avformat/rtpdec_hevc: Don't reimplement ff_alloc_extradata

2019-12-12 Thread Michael Niedermayer
On Tue, Dec 10, 2019 at 10:59:52PM +0100, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/rtpdec_hevc.c | 11 ++- > 1 file changed, 2 insertions(+), 9 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787

Re: [FFmpeg-devel] [PATCH 09/11] avformat: Forward errors where possible

2019-12-12 Thread Michael Niedermayer
On Tue, Dec 10, 2019 at 10:59:53PM +0100, Andreas Rheinhardt wrote: > It is not uncommon to find code where the caller thinks to know better > what the return value should be than the callee. E.g. something like > "if (av_new_packet(pkt, size) < 0) return AVERROR(ENOMEM);". This commit > changes se

Re: [FFmpeg-devel] [PATCH] avformat: Don't free old extradata before ff_alloc/get_extradata

2019-12-12 Thread Michael Niedermayer
On Wed, Dec 11, 2019 at 12:21:07PM +0100, Andreas Rheinhardt wrote: > These functions already free it themselves before they allocate the new > extradata. > > Signed-off-by: Andreas Rheinhardt > --- > Resending because I got the commit title wrong: There is no > ff_allocate_extradata. > > libav

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: Fix type in av_log for random_seed in cellauto and life

2019-12-12 Thread Andreas Rheinhardt
On Sat, Dec 7, 2019 at 10:27 AM Michael Niedermayer wrote: > Fixes CID 1456556 / 1456555 > > Signed-off-by: Michael Niedermayer > --- > libavfilter/vsrc_cellauto.c | 2 +- > libavfilter/vsrc_life.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/vsrc_

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: Fix type in av_log for random_seed in cellauto and life

2019-12-12 Thread Michael Niedermayer
On Thu, Dec 12, 2019 at 08:21:47PM +0100, Andreas Rheinhardt wrote: > On Sat, Dec 7, 2019 at 10:27 AM Michael Niedermayer > wrote: > > > Fixes CID 1456556 / 1456555 > > > > Signed-off-by: Michael Niedermayer > > --- > > libavfilter/vsrc_cellauto.c | 2 +- > > libavfilter/vsrc_life.c | 2 +-

Re: [FFmpeg-devel] [PATCH] lavc/x265: set preferred_transfer_characteristics for HLG

2019-12-12 Thread Vittorio Giovara
On Thu, Dec 12, 2019 at 11:14 AM James Almer wrote: > On 12/4/2019 11:24 AM, Zhong Li wrote: > > "HEVC HDR UHDTV Bitstreams using HLG10 shall also contain the > > alternative_transfer_characteristics SEI message. The > > alternative_transfer_characteristics SEI message shall be inserted on > > th

Re: [FFmpeg-devel] [PATCH] configure: Check for the SetDllDirectory and GetModuleHandle functions

2019-12-12 Thread Martin Storsjö
On Tue, 10 Dec 2019, Martin Storsjö wrote: These functions aren't available when building for the restricted UWP/WinRT/WinStore API subsets. Normally when building in this mode, one is probably only building the libraries, but being able to build ffmpeg.exe still is useful (and a ffmpeg.exe tar

Re: [FFmpeg-devel] [PATCHv2] fate: Add an option for disabling the 2k/4k tests

2019-12-12 Thread Martin Storsjö
On Wed, 11 Dec 2019, Martin Storsjö wrote: On Wed, 11 Dec 2019, Carl Eugen Hoyos wrote: Am Mi., 11. Dez. 2019 um 09:39 Uhr schrieb Martin Storsjö : When testing on a memory limited system, these tests consume a significant amount of memory and can often fail if testing by running multiple p

Re: [FFmpeg-devel] [PATCHv2] fate: Add an option for disabling the 2k/4k tests

2019-12-12 Thread James Almer
On 12/12/2019 7:03 PM, Martin Storsjö wrote: > On Wed, 11 Dec 2019, Martin Storsjö wrote: > >> On Wed, 11 Dec 2019, Carl Eugen Hoyos wrote: >> >>> Am Mi., 11. Dez. 2019 um 09:39 Uhr schrieb Martin Storsjö >> : When testing on a memory limited system, these tests consume a significa

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h2645: Fail on all 0 NAL units

2019-12-12 Thread Andriy Gelman
On Thu, 12. Dec 18:43, Michael Niedermayer wrote: > Fixes: assertion failure > Fixes: > 19286/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_REDUNDANT_PPS_fuzzer-5707990724509696 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-of

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h2645: Fail on all 0 NAL units

2019-12-12 Thread James Almer
On 12/12/2019 7:15 PM, Andriy Gelman wrote: > On Thu, 12. Dec 18:43, Michael Niedermayer wrote: >> Fixes: assertion failure >> Fixes: >> 19286/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_REDUNDANT_PPS_fuzzer-5707990724509696 >> >> Found-by: continuous fuzzing process >> https://github.com/goog

[FFmpeg-devel] [PATCH 4/5] avcodec/hevc_mp4toannexb_bsf: check that nalu size doesnt overflow

2019-12-12 Thread Michael Niedermayer
Fixes: Out of array access Fixes: 19299/clusterfuzz-testcase-minimized-ffmpeg_BSF_HEVC_MP4TOANNEXB_fuzzer-5169193398042624 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/hevc_mp4toannexb_bsf.

[FFmpeg-devel] [PATCH 2/5] avcodec/cbs_av1: Check leb128 values read

2019-12-12 Thread Michael Niedermayer
"It is a requirement of bitstream conformance that the value returned from the leb128 parsing process is less than or equal to (1 << 32) - 1." Fixes: assertion failure Fixes: 19293/clusterfuzz-testcase-minimized-ffmpeg_BSF_TRACE_HEADERS_fuzzer-5749508361420800 Found-by: continuous fuzzing proce

[FFmpeg-devel] [PATCH 3/5] avcodec/hevc_mp4toannexb_bsf: Avoid NULL memcpy()

2019-12-12 Thread Michael Niedermayer
Fixes: invalid memcpy use Fixes: 19299/clusterfuzz-testcase-minimized-ffmpeg_BSF_HEVC_MP4TOANNEXB_fuzzer-5169193398042624 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/hevc_mp4toannexb_bsf.c

[FFmpeg-devel] [PATCH 1/5] avcodec/iff: Check input space before loop in decode_delta_d()

2019-12-12 Thread Michael Niedermayer
Fixes: Timeout (114sec ->108ms) Fixes: 19290/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5740598116220928 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/iff.c | 3 +++ 1

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/hevc_mp4toannexb_bsf: check that nalu size doesnt overflow

2019-12-12 Thread Andriy Gelman
On Fri, 13. Dec 01:28, Michael Niedermayer wrote: > Fixes: Out of array access > Fixes: > 19299/clusterfuzz-testcase-minimized-ffmpeg_BSF_HEVC_MP4TOANNEXB_fuzzer-5169193398042624 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-of

[FFmpeg-devel] [PATCH 5/5] avcodec/hevc_mp4toannexb_bsf: Check that there is enough input left for nalu size

2019-12-12 Thread Michael Niedermayer
No testcase Signed-off-by: Michael Niedermayer --- libavcodec/hevc_mp4toannexb_bsf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/hevc_mp4toannexb_bsf.c b/libavcodec/hevc_mp4toannexb_bsf.c index baa93628ed..e0d20a550c 100644 --- a/libavcodec/hevc_mp4toannexb

[FFmpeg-devel] [PATCH, v2] FATE: add test for hevc files with 4 TUDepth(0..4) of cbf_cb/cbf_cr

2019-12-12 Thread Linjie Fu
5 cabac states for cbf_cb and cbf_cr are supported according to Table 9-4. Add a test for 64x64 4:4:4 8bit HEVC clips with TUDepth = 4, cbf_cr > 0. Signed-off-by: Xu Guangxin Signed-off-by: Linjie Fu --- tests/fate/hevc.mak | 3 +++ tests/ref/fate/hevc-cabac-tudepth | 6 ++ 2

Re: [FFmpeg-devel] [PATCH] FATE: add test for hevc files with 4 TUDepth(0..4) of cbf_cb/cbf_cr

2019-12-12 Thread Fu, Linjie
Hi, > -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Friday, December 13, 2019 00:55 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] FATE: add test for hevc files with 4 > TUDepth(0..4) of cbf_cb/cbf_cr > > On 12/12/2019 12:25 PM, Linjie Fu

Re: [FFmpeg-devel] [PATCH, v2] FATE: add test for hevc files with 4 TUDepth(0..4) of cbf_cb/cbf_cr

2019-12-12 Thread Carl Eugen Hoyos
Am Fr., 13. Dez. 2019 um 03:43 Uhr schrieb Linjie Fu : > 5 cabac states for cbf_cb and cbf_cr are supported according to > Table 9-4. > > Add a test for 64x64 4:4:4 8bit HEVC clips with TUDepth = 4, cbf_cr > 0. > +fate-hevc-cabac-tudepth: CMD = framecrc -flags unaligned -i > $(TARGET_SAMPLES)/hev

Re: [FFmpeg-devel] [PATCH, v2] FATE: add test for hevc files with 4 TUDepth(0..4) of cbf_cb/cbf_cr

2019-12-12 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Carl Eugen Hoyos > Sent: Friday, December 13, 2019 10:47 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH, v2] FATE: add test for hevc files with 4 > TUDepth(0..4) of cbf_cb/cbf