Re: [FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

ensure make fate works, please take a look At 2019-11-08 12:12:58, "manuelyuan" wrote: >From: Mengyang Yuan > >In this case, the input video is of dynamic frame rate and we don't want to >duplicate or drop frames, but the output video duration calculated by DTS is >incorrect, I solved it by us

[FFmpeg-devel] [PATCH v2 1/3] avfilter/vf_colorbalance: Fix for the wrong step value for 16bit format

From: Limin Wang Please try to reproduce with below command: ./ffplay -vf format=rgba64,colorbalance=rm=.2 ../fate-suite/mpeg2/t.mpg Without the patch, the step is 8 if you check it by gdb or print out. Signed-off-by: Limin Wang --- libavfilter/vf_colorbalance.c | 3 ++- 1 file changed, 2 in

[FFmpeg-devel] [PATCH v2 2/3] avfilter/vf_colorbalance: change to float to make framecrc same for 32 and 64bit system

From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_colorbalance.c | 36 +-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/libavfilter/vf_colorbalance.c b/libavfilter/vf_colorbalance.c index 3fd1426696..1ab3a61039 100644 --- a/libavfil

[FFmpeg-devel] [PATCH v2 3/3] FATE: add a test for colorbalance

From: Limin Wang Signed-off-by: Limin Wang --- have tested with x86_64, x86_32, mips tests/fate/filter-video.mak | 12 tests/ref/fate/filter-colorbalance | 8 tests/ref/fate/filter-colorbalance-gbrap| 8 tests/ref/fate/filter-colorb

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter/vf_colorbalance: Fix for the wrong step value for 16bit format

Do not touch this file I actively working on it. On 11/13/19, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Please try to reproduce with below command: > ./ffplay -vf format=rgba64,colorbalance=rm=.2 ../fate-suite/mpeg2/t.mpg > > Without the patch, the step is 8 if you check it by gdb or

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter/vf_colorbalance: Fix for the wrong step value for 16bit format

Also step is later divided by 2. On 11/13/19, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Please try to reproduce with below command: > ./ffplay -vf format=rgba64,colorbalance=rm=.2 ../fate-suite/mpeg2/t.mpg > > Without the patch, the step is 8 if you check it by gdb or print out. > >

[FFmpeg-devel] [PATCH] lavc/vaapi_encode: reconfigure sequence parameter in case it changes

Aspect ratio change should be preserved in the output result of transcoding. A better choice is to reconfigure when parameter changing is detected, but a fix to reconfigure on IDR frame is simple and effective with no performance drop. Fix #6276 for VAAPI. Signed-off-by: Linjie Fu --- libavcode

Re: [FFmpeg-devel] [PATCH 2/2] lavc/rav1e: add doc for threads option

qmin and qmax are generic optiopns too. Many generic options can't be appled to specified encoders, so just add the supported options here. Following libaom's format probally a good idea. Gyan 于2019年11月12日周二 下午7:04写道： > > > > On 12-11-2019 02:39 pm, Zhong Li wrote: > > Signed-off-by: Zhong Li >

Re: [FFmpeg-devel] [PATCH v1 2/2] configure: Fix for the configure failed for vmaf

Just curious why this issue hasn't been found earlier. 于2019年11月12日周二 下午7:24写道： > > From: Limin Wang > > When enable-libvmaf with the vmaf master installed , it'll report below error: > ERROR: libvmaf >= 1.3.9 not found using pkg-config > > In fact, after vmaf installed, the vmaf pkg-config file

[FFmpeg-devel] [PATCH 0/2] add superfastblur/stackblur

V1: - fix R/B swap issue in superfastblur, tks Zhao Zhili - add stackblur, it is a compromise between Gaussian Blur and Box blur Jun Zhao (2): lavfi/superfastblur: add superfastblur filter lavfi/stackblur: add stackblur filter doc/filters.texi | 37 libavfilter/Make

[FFmpeg-devel] [PATCH 2/2] lavfi/stackblur: add stackblur filter

From: Jun Zhao add stackblur filter Signed-off-by: Jun Zhao --- doc/filters.texi | 22 +++ libavfilter/Makefile |1 + libavfilter/allfilters.c |1 + libavfilter/vf_stackblur.c | 362 4 files changed, 386 insertions(+), 0

[FFmpeg-devel] [PATCH 1/2] lavfi/superfastblur: add superfastblur filter

From: Jun Zhao add superfastblur filter Signed-off-by: Jun Zhao --- doc/filters.texi | 15 +++ libavfilter/Makefile |1 + libavfilter/allfilters.c |1 + libavfilter/vf_superfastblur.c | 274 4 files changed, 291

[FFmpeg-devel] [PATCH v2] librav1e: Don't make users explicitly set -qp -1 to use bit rate mode

Signed-off-by: Derek Buitenhuis --- libavcodec/librav1e.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c index 5052cac896..a5835ee6be 100644 --- a/libavcodec/librav1e.c +++ b/libavcodec/librav1e.c @@ -533,7 +533,7 @@ retry: #defi

Re: [FFmpeg-devel] [PATCH] avformat/id3v2: Avoid av_strdup for key and value of dict

lgtm On 11/10/19, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/id3v2.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c > index e9843eef9a..abe073dcc1 100644 > --- a/libavformat/

[FFmpeg-devel] [PATCH] avdevice/decklink: add option to drop frames till timecode is seen

As suggested in the review of an earlier patch*, this one drops frames till a TC is seen. Testing results to follow. Thanks, Gyan *https://patchwork.ffmpeg.org/patch/14081/ From 0932db9d14dea215c1b0e5dcac4eac16cd6a Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Mon, 9 Sep 2019 18:33:09 +

Re: [FFmpeg-devel] [PATCH v1 2/2] configure: Fix for the configure failed for vmaf

> On Nov 13, 2019, at 9:41 PM, Zhong Li wrote: > > Just curious why this issue hasn't been found earlier. I think it's a regression of libvmaf: libvmaf: build with meson https://github.com/Netflix/vmaf/commit/82a86e040371f2ca8665d6c210e3d1d2d608a636 I have a pull request for

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: correctly set width values for dvcprohd

> On Nov 12, 2019, at 1:14 PM, Baptiste Coudurier > wrote: > >> >> On Nov 11, 2019, at 3:30 PM, Tomas Härdin > > wrote: >> >> lör 2019-11-09 klockan 15:46 -0800 skrev Baptiste Coudurier: >>> --- >>> libavformat/mxfenc.c | 15 --- >>> 1 file changed, 12 in

Re: [FFmpeg-devel] [PATCH v1] avfilter: Add tonemap vaapi filter for H2S

On Tue, Nov 12, 2019 at 04:59:48PM +0800, Xinpeng Sun wrote: > It performs HDR(High Dynamic Range) to SDR(Standard Dynamic Range) conversion > with tone-mapping. It supports HDR10 only as input temporarily. > > H2S: P010 -> NV12 > > An example command to use this filter with vaapi codecs: > FFMPE

Re: [FFmpeg-devel] [PATCH] avcodec/dvenc: support encoding dvcprohd

> On Nov 12, 2019, at 1:13 PM, Baptiste Coudurier > wrote: > >> >> On Nov 9, 2019, at 4:11 PM, Baptiste Coudurier >> wrote: >> >> --- >> libavcodec/dv.h | 1 + >> libavcodec/dvenc.c | 561 >> tests/fate/vcodec.mak | 14

Re: [FFmpeg-devel] [PATCH v2] librav1e: Don't make users explicitly set -qp -1 to use bit rate mode

On 11/13/2019 2:17 PM, James Almer wrote: > On 11/13/2019 12:29 PM, Derek Buitenhuis wrote: >> Signed-off-by: Derek Buitenhuis >> --- >> libavcodec/librav1e.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c >> index 5052cac

Re: [FFmpeg-devel] [PATCH V1] lavfi/superfastblur: add superfastblur filter

On Wed, Nov 13, 2019 at 12:24:34AM +0100, Paul B Mahol wrote: > On 11/13/19, Michael Niedermayer wrote: > > On Tue, Nov 12, 2019 at 12:48:09PM +0100, Paul B Mahol wrote: > >> If this filter is same speed or better than boxblur, it should replace > >> boxblur filter, as boxblur filter is GPL. > > >

[FFmpeg-devel] [PATCH] avformat/dvenc: support muxing dvcprohd

--- libavformat/dvenc.c | 48 + 1 file changed, 22 insertions(+), 26 deletions(-) diff --git a/libavformat/dvenc.c b/libavformat/dvenc.c index 93c103b316..a7d1413eb2 100644 --- a/libavformat/dvenc.c +++ b/libavformat/dvenc.c @@ -28,7 +28,6 @@ * Founda

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: simplify dv ul handling

> On Nov 11, 2019, at 4:07 PM, Baptiste Coudurier > wrote: > > --- > libavformat/mxfenc.c | 128 --- > 1 file changed, 46 insertions(+), 82 deletions(-) > Will apply — Baptiste ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] avcodec/vp8: fix multiple ff_thread_finish_setup() calls

Hi, On Wed, Nov 13, 2019 at 2:00 AM wrote: > From: Zhao Zhili > > vp7 decoder doesn't set update_thread_context field > --- > libavcodec/vp8.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c > index eb51d1f3c9..b4deb3ed67 100644 >

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: add option to drop frames till timecode is seen

Hi, We tested this with several types of tapes. The results are as follows: Out of 58 captures on Betacam tapes 55 had 0 frame offset and 3 had an offset of 1 frame. All 3 were captured using the flag "-wait_for_tc 1". Out of the 58 captures roughly half were captured with and half without "-wait

Re: [FFmpeg-devel] [PATCH v2] librav1e: Don't make users explicitly set -qp -1 to use bit rate mode

On 13/11/2019 17:21, James Almer wrote: > Actually, remove the comment about what it defaults to. That's out of > our control and may very well change in a future version of librav1e. > libx264 doesn't say anything like that, it just sets qp and crf to -1 > and bitrate to 0, and lets the library do

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: add option to drop frames till timecode is seen

My previous email was incorrect about "-wait_for_tc 1". The 2 commands used were: (1) ffmpeg -loglevel trace -timecode_format rp188any -wait_for_tc 1 -f decklink -probesize 15M -analyzeduration 5M -i "DeckLink Quad (1)" -t 30 -preset veryfast output.mov (2) ffmpeg -loglevel trace -timecode_for

Re: [FFmpeg-devel] [PATCH] avfilter/scale: allow dynamic output via expressions

On Tue, Nov 12, 2019 at 07:20:47PM +0530, Gyan wrote: > This patch relies on the proposed addition to the eval API at > https://patchwork.ffmpeg.org/patch/16109/ > > FATE passes. > > Gyan > Makefile |4 > scale.c| 72 -- > vf_scale.c | 436 > ++

Re: [FFmpeg-devel] [PATCH v2] librav1e: Don't make users explicitly set -qp -1 to use bit rate mode

On 11/13/2019 12:29 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavcodec/librav1e.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/librav1e.c b/libavcodec/librav1e.c > index 5052cac896..a5835ee6be 100644 > --- a/libavcodec/librav1e

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: correctly set width values for dvcprohd

mån 2019-11-11 klockan 15:52 -0800 skrev Baptiste Coudurier: > > On Nov 11, 2019, at 3:30 PM, Tomas Härdin wrote: > > > > lör 2019-11-09 klockan 15:46 -0800 skrev Baptiste Coudurier: > > > --- > > > libavformat/mxfenc.c | 15 --- > > > 1 file changed, 12 insertions(+), 3 deletions(-) >

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: simplify dv ul handling

ons 2019-11-13 klockan 09:25 -0800 skrev Baptiste Coudurier: > > On Nov 11, 2019, at 4:07 PM, Baptiste Coudurier < > > baptiste.coudur...@gmail.com> wrote: > > > > --- > > libavformat/mxfenc.c | 128 -- > > - > > 1 file changed, 46 insertions(+), 82 deletions

Re: [FFmpeg-devel] [PATCH] avformat/dvenc: support muxing dvcprohd

ons 2019-11-13 klockan 09:22 -0800 skrev Baptiste Coudurier: > --- > libavformat/dvenc.c | 48 + > 1 file changed, 22 insertions(+), 26 deletions(-) > > diff --git a/libavformat/dvenc.c b/libavformat/dvenc.c > index 93c103b316..a7d1413eb2 100644 > --- a

[FFmpeg-devel] [PATCHv2 01/10] avformat/mpegtsenc: allow any sensible PID for elementary and PMT PIDs

This sets the range of the first automatically assigned PMT PID or elementary stream PID parameters to [0x20, 0x1ffa]. You can still assign manually a PID for a stream using AVStream->id in the wider [0x10, 0x1ffe] range as specified by ISO13818-1. But since DVB and ATSC both reserves some PIDs, le

[FFmpeg-devel] [PATCHv2 06/10] avformat/mpegtsenc: use standard pids for m2ts

Signed-off-by: Marton Balint --- doc/muxers.texi | 6 -- libavformat/mpegtsenc.c | 31 ++- 2 files changed, 34 insertions(+), 3 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 5d7ff1ab3b..4e76b40151 100644 --- a/doc/muxers.texi +++ b/doc

Re: [FFmpeg-devel] [PATCH] avformat/id3v2: Avoid av_strdup for key and value of dict

On Wed, Nov 13, 2019 at 04:46:48PM +0100, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No great genius has ever existed without some touch of madness. -- Aristotle signature.asc Description: PGP signature _

Re: [FFmpeg-devel] [PATCH v1 2/2] configure: Fix for the configure failed for vmaf

On Thu, Nov 14, 2019 at 01:03:09AM +0800, Zhao Zhili wrote: > > > > On Nov 13, 2019, at 9:41 PM, Zhong Li wrote: > > > > Just curious why this issue hasn't been found earlier. > > I think it's a regression of libvmaf: > libvmaf: build with meson > > https://github.com/Netflix/vmaf

Re: [FFmpeg-devel] [PATCH v1 2/2] configure: Fix for the configure failed for vmaf

> On Nov 14, 2019, at 8:56 AM, Limin Wang wrote: > > On Thu, Nov 14, 2019 at 01:03:09AM +0800, Zhao Zhili wrote: >> >> >>> On Nov 13, 2019, at 9:41 PM, Zhong Li wrote: >>> >>> Just curious why this issue hasn't been found earlier. >> >> I think it's a regression of libvmaf: >> libvmaf

Re: [FFmpeg-devel] [PATCH] avcodec/encode: add missing assert to avcodec_receive_packet()

On 11/9/2019 8:08 PM, James Almer wrote: > Encoders must return reference counted packets. > > This was checked only for encoders using the encode2 AVCodec API, while > blindly accepting whatever encoders using the receive_packet AVCodec API > were returning. > > Signed-off-by: James Almer > ---

[FFmpeg-devel] [PATCH v2] avcodec/vp8: fix multiple ff_thread_finish_setup() calls

From: Zhao Zhili webp decoder doesn't set update_thread_context field $ ffmpeg -i rgb_q80.webp -f null - [webp @ 0x7ffbd5823200] Multiple ff_thread_finish_setup() calls --- libavcodec/vp8.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c

Re: [FFmpeg-devel] [PATCH] avcodec/vp8: fix multiple ff_thread_finish_setup() calls

> On Nov 14, 2019, at 1:25 AM, Ronald S. Bultje wrote: > > Hi, > > On Wed, Nov 13, 2019 at 2:00 AM > wrote: > >> From: Zhao Zhili >> >> vp7 decoder doesn't set update_thread_context field >> --- >> libavcodec/vp8.c | 3 ++- >> 1 file changed, 2 insertions(+),

Re: [FFmpeg-devel] [PATCH] avfilter/scale: allow dynamic output via expressions

On 14-11-2019 01:12 am, Michael Niedermayer wrote: On Tue, Nov 12, 2019 at 07:20:47PM +0530, Gyan wrote: This patch relies on the proposed addition to the eval API at https://patchwork.ffmpeg.org/patch/16109/ FATE passes. Gyan Makefile |4 scale.c| 72 -- vf_scale.c |

Re: [FFmpeg-devel] [PATCH v1 2/2] configure: Fix for the configure failed for vmaf

There is a big problem now IIUC. Your patch will make older version libvmaf can't be built in FFmpeg now (though I haven't tested). Probably a better solution is update the min required vmaf version with your patch? -enabled libvmaf && require_pkg_config libvmaf "libvmaf >= 1.3.9" libvm

Re: [FFmpeg-devel] [PATCH v1 2/2] configure: Fix for the configure failed for vmaf

On 14-11-2019 11:52 am, Zhong Li wrote: There is a big problem now IIUC. Your patch will make older version libvmaf can't be built in FFmpeg now (though I haven't tested). Probably a better solution is update the min required vmaf version with your patch? Please avoid doing this. A popular b

Re: [FFmpeg-devel] [PATCH v1 2/2] configure: Fix for the configure failed for vmaf

On Thu, Nov 14, 2019 at 02:22:31PM +0800, Zhong Li wrote: > There is a big problem now IIUC. > Your patch will make older version libvmaf can't be built in FFmpeg > now (though I haven't tested). > > Probably a better solution is update the min required vmaf version > with your patch? > > -enable