> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Dennis Mungai
> Sent: Tuesday, November 5, 2019 13:04
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Cc: Zhong Li
> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: add the missing vp9 file
>
> On Mon, 4 Nov
---
libavcodec/wmadec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/wmadec.c b/libavcodec/wmadec.c
index 78b51e5871..e7886262f3 100644
--- a/libavcodec/wmadec.c
+++ b/libavcodec/wmadec.c
@@ -889,11 +889,11 @@ static int wma_decode_superframe(AVCodecContext *a
---
libavcodec/get_bits.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavcodec/get_bits.h b/libavcodec/get_bits.h
index c4ab607744..66fb877599 100644
--- a/libavcodec/get_bits.h
+++ b/libavcodec/get_bits.h
@@ -234,9 +234,9 @@ static inline void refill_32(GetBitCon
On Tue, Nov 05, 2019 at 10:13:52AM +0530, Gyan wrote:
>
>
> On 05-11-2019 04:35 am, Michael Niedermayer wrote:
> >On Sun, Nov 03, 2019 at 11:14:25AM +0530, Gyan wrote:
> >>Helps better identification of expr eval failures.
> >>
> >>Gyan
> >> eval.c| 21 +
> >> eval.h
On 05-11-2019 03:55 pm, Michael Niedermayer wrote:
On Tue, Nov 05, 2019 at 10:13:52AM +0530, Gyan wrote:
On 05-11-2019 04:35 am, Michael Niedermayer wrote:
On Sun, Nov 03, 2019 at 11:14:25AM +0530, Gyan wrote:
Helps better identification of expr eval failures.
Gyan
eval.c| 21 +
On Tue, Nov 05, 2019 at 11:13:50AM +0100, Ramiro Polla wrote:
> ---
> libavcodec/wmadec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
LGTM
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
If you drop bombs on a foreign country and kill a hun
On Tue, Nov 05, 2019 at 11:13:49AM +0100, Ramiro Polla wrote:
> ---
> libavcodec/get_bits.h | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
LGTM
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Why not whip the teacher when the pupil misbeha
Gyan (12019-11-05):
> An example of a cross-referenced expression would be 'y=x+rand(10)'.
> Normally in filters, X would be evaluated first, then Y, then X again. The
> 2nd eval of X will overwrite the first and can generate a different value.
> With this func, we can avoid the 2nd eval.
>
> I'm
On Wed, 30. Oct 09:45, Andriy Gelman wrote:
> On Thu, 24. Oct 20:50, Andriy Gelman wrote:
> > On Tue, 15. Oct 22:50, Andriy Gelman wrote:
> > > From: Andriy Gelman
> > >
> > > Fixes #7799
> > >
> > > Currently, the mp4toannexb filter always inserts the same extradata at
> > > the start of the fi
On 05-11-2019 07:40 pm, Nicolas George wrote:
Gyan (12019-11-05):
An example of a cross-referenced expression would be 'y=x+rand(10)'.
Normally in filters, X would be evaluated first, then Y, then X again. The
2nd eval of X will overwrite the first and can generate a different value.
With this
>>On Thu, Oct 31, 2019 at 06:04:58PM +0100, Nicolas Gaullier wrote:
>> Allow the user to set or override the vbv size
>> ---
>> libavformat/mpegenc.c | 6 +-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>This is not the "correct" way to handle this, because one mpeg container
>can conta
On Mon, Nov 04, 2019 at 06:42:10PM +, Kevin Wheatley wrote:
> This pair of patches work together to facilitate user specified timescales for
> the Movie Header Atom 'mvhd', which allows constant sample table durations for
> all frame rates.
>
> Currently there is a fixed timescale of 1000, whi
On Tue, Nov 5, 2019 at 5:44 PM Gaullier Nicolas
wrote:
>
> >>On Thu, Oct 31, 2019 at 06:04:58PM +0100, Nicolas Gaullier wrote:
> >> Allow the user to set or override the vbv size
> >> ---
> >> libavformat/mpegenc.c | 6 +-
> >> 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> >This is not
On Mon, Nov 4, 2019, at 3:42 PM, Carl Eugen Hoyos wrote:
> Am Di., 5. Nov. 2019 um 00:45 Uhr schrieb Lou Logan :
>
> [...]
>
> Set lgtm.
Set pushed.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Signed-off-by: Lou Logan
---
Fixes:
--disable-everything --enable-encoder=dca
/usr/bin/ld: libavcodec/libavcodec.a(dcaenc.o): in function `encode_init':
dcaenc.c:(.text+0xeb9): undefined reference to `ff_mdct_init_fixed_32'
/usr/bin/ld: libavcodec/libavcodec.a(dcaenc.o): in function `encode_clos
Signed-off-by: Lou Logan
---
Fixes:
--disable-everything --enable-encoder=opus
/usr/bin/ld: libavcodec/libavcodec.a(dcaenc.o): in function `encode_init':
dcaenc.c:(.text+0xeb9): undefined reference to `ff_mdct_init_fixed_32'
/usr/bin/ld: libavcodec/libavcodec.a(dcaenc.o): in function `encode_close
Signed-off-by: Lou Logan
---
Fixes:
--disable-everything --enable-encoder=snow
/usr/bin/ld: libavcodec/libavcodec.a(ituh263enc.o): in function
`h263_get_motion_length':
ituh263enc.c:(.text+0x487): undefined reference to `ff_mvtab'
/usr/bin/ld: ituh263enc.c:(.text+0x4db): undefined reference to `f
Signed-off-by: Lou Logan
---
Fixes:
--disable-everything --enable-encoder=wmv1
/usr/bin/ld: libavcodec/libavcodec.a(msmpeg4enc.o): in function
`ff_msmpeg4_encode_init':
msmpeg4enc.c:(.text+0x627): undefined reference to `ff_msmpeg4_common_init'
/usr/bin/ld: msmpeg4enc.c:(.text+0x671): undefined
Hi to all dev!
FFmpeg on Windows32;
request of full audio codec support
pcm_s16be
into a container MP4.
LOG:
[mp4 @ 00a5f840] Could not find tag for codec pcm_s16be in stream #1, codec
not currently supported in container
Could not write header for output file #0 (incorrect codec parameters ?):
On Fri, Nov 01, 2019 at 01:33:43PM +0100, Michael Niedermayer wrote:
> This compared to the other suggestions is cleaner and easier to understand
> keeping the condition in the if() simple.
>
> This affects alot of fate tests.
>
> See: [FFmpeg-devel] [PATCH 05/11] avformat/nutenc: Don't pass NULL
On Mon, Nov 04, 2019 at 07:09:59PM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> doc/bitstream_filters.texi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi
> index 5
Am Di., 5. Nov. 2019 um 20:36 Uhr schrieb Lou Logan :
[...]
Set lgtm.
Thank you, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-
The decoder hardcodes that audio is stream_id = 1 so it does not
currently work with more or less than 1 video stream at st=0
Fixes: assertion failure
Fixes:
18602/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6259277199310848
Found-by: continuous fuzzing process
https://github.com/googl
Fixes: signed integer overflow: 6175076100092079360 - -5034989061050195840
cannot be represented in type 'long'
Fixes:
18614/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5704508847423488
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/
Fixes: signed integer overflow: 1145975808 - -1146173210 cannot be represented
in type 'int'
Fixes:
18616/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RALF_fuzzer-5121296757424128
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off
The G729 reference clips after each individual operation and keeps track if
overflow
occurred (in the fixed point implementation), this here is
simpler and faster but not 1:1 the same what the reference does.
Non fuzzed samples which trigger any such overflow are welcome, so
the need and impact o
Signed-off-by: Michael Niedermayer
---
libavformat/vividas.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/libavformat/vividas.c b/libavformat/vividas.c
index e4255fd5cc..b804260b5d 100644
--- a/libavformat/vividas.c
+++ b/libavformat/vividas.c
@@ -52,6 +52,7
Am Mi., 6. Nov. 2019 um 00:31 Uhr schrieb Michael Niedermayer
:
>
> The G729 reference clips after each individual operation and keeps
> track if overflow occurred (in the fixed point implementation)
I believe this is missing the word "decoder".
Carl Eugen
Am Fr., 1. Nov. 2019 um 06:24 Uhr schrieb Yuki Tsuchiya
:
>
> Implemented according to the specification at
> https://www.iso.org/standard/69561.html
> The "mhm1" sample entry is registered with MP4RA, which is defined as MHAS
> encapsulated single stream MPEG-H 3D Audio.
> "MHAS" stands for MPEG
Am Mi., 30. Okt. 2019 um 03:52 Uhr schrieb Yuki.Tsuchiya
:
> Here is the sample content of the MPEG-H 3D Audio.
> https://www.filehosting.org/file/details/829625/mpeg-h_3d_audio_mhm1_sample.mp4
Does not work here, please use any other filehoster.
Thank you, Carl Eugen
___
Am Sa., 2. Nov. 2019 um 17:08 Uhr schrieb Michael Niedermayer
:
>
> Fixes: Timeout (23sec -> 5ms)
> Fixes:
> 18517/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NUV_fuzzer-5753135536013312
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpe
From: Mengyang Yuan
In this case, the input video is of dynamic frame rate and we don't want to
duplicate or drop frames, but the output video duration calculated by DTS is
incorrect, I solved it by using PTS.
There are many UGC videos with dynamic frame rates, which are represented by
PTS jumps.
Our code can actually write tracks with a TrackNum in the range of
1..127 without problems. Variable length integers that only have '1'
bits after the marker bit are not reserved when being used to encode
the TrackNumber in a block (there is no equivalent of unknown length
elements here).
Signed-o
If mkv_write_trailer() is not called, the cached audio packet might
leak; so unref it in mkv_deinit().
Signed-off-by: Andreas Rheinhardt
---
When I initially wrote the deinit function, I was under the impression
that the user always has to call av_write_trailer(). Therefore this has
been forgotte
When creating dash streams, the track number is externally prescribed
and not derived from the number of streams in the AVFormatContext. Up
until now, a track number of zero was allowed, although this is an
illegal track number.
Furthermore, it was not checked whether the number of tracks for a fil
Sometimes it has not been checked whether opening the dynamic buffer for
writing tags fails; this might have led to segfaults.
Signed-off-by: Andreas Rheinhardt
---
libavformat/matroskaenc.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/libavformat/matroskaenc.c
This comment does not account for the fact that the limits on cluster
size and duration are configurable by the user since 98308bd4.
Signed-off-by: Andreas Rheinhardt
---
libavformat/matroskaenc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/libavformat/matroskaenc.c b/libavformat/matros
The Matroska video-projection master element has such a small maximum
length that it can always be written with a length field of length one.
So it is unnecessary to first write the element into a dynamic buffer to
get the accurate length in order not to waste bytes on the length field.
Signed-off
The Matroska muxer currently only adds CuePoints in three cases:
a) For video keyframes. b) For the first audio frame in a new cluster if
in dash-mode. c) For subtitles. This means that ordinary Matroska audio
files won't have any cues which impedes seeking.
This commit changes this. For every tra
Up until e7ddafd5, the Matroska muxer wrote two seekheads: One at the
beginning referencing the main level 1 elements (i.e. not the clusters)
and one at the end, referencing the clusters. This second seekhead was
useless and has therefore been removed. Yet the seekhead-related
functions and structu
Attachments are streams in FFmpeg, but they are not tracks in Matroska.
Yet they were counted when checking a limit for the number of tracks that
the Matroska muxer imposes. This is unnecessary and has been changed.
(The Matroska file format actually has practically no limit on the
number of track
In order to determine whether the current cluster needs to be closed
because of the limits on cluster-size and cluster-time,
mkv_write_packet() would first get the size of the current cluster via
applying avio_tell() on the dynamic buffer holding the current cluster.
It did this without checking wh
This avoids errors lateron after the file header has already been
partially written.
Signed-off-by: Andreas Rheinhardt
---
libavformat/matroskaenc.c | 35 ++-
1 file changed, 22 insertions(+), 13 deletions(-)
diff --git a/libavformat/matroskaenc.c b/libavformat/m
The EBML as well as the Matroska specifications allow empty strings, yet
the Matroska muxer enforced the requirement that a filename tag exists
for attachments and errored out if it didn't. This has been changed: In
the absence of a filename, an empty string is used.
Signed-off-by: Andreas Rheinha
Mainly reindentation.
Signed-off-by: Andreas Rheinhardt
---
libavformat/matroskaenc.c | 88 +++
1 file changed, 44 insertions(+), 44 deletions(-)
diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
index 776911e517..5e3f9144a0 100644
--- a/liba
Use the mime_types of the corresponding AVCodecDescriptor instead of own
arrays. The former are more encompassing.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/codec_desc.c | 1 +
libavformat/matroskaenc.c | 14 +++---
2 files changed, 4 insertions(+), 11 deletions(-)
diff --git
Several EBML master elements for which a good upper bound of the final
length was available were nevertheless written as unknown-length
EBML-elements, so that their length field was eight bytes long. This has
been changed.
Signed-off-by: Andreas Rheinhardt
---
libavformat/matroskaenc.c
While the Matroska specification allows the filename string to be empty,
forwarding an empty string as tag is useless.
Signed-off-by: Andreas Rheinhardt
---
libavformat/matroskadec.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libavformat/matroskadec.c b/libavformat/m
In order to indicate that the frames in a BlockGroup are not keyframes,
one has to add a ReferenceBlock element containing the timestamp of a
reference block that has already been written. The timestamp ought to be
relative to the timestamp of the block it is attached to. Yet the
Matroska muxer use
If there are attachments to write, the Matroska muxer currently
allocates two objects: An array that contains an entry for each
attachment containing just the stream index of the corresponding
stream and the uid used for this attachment; and a structure with
a pointer to said array and a counter fo
As WebM doesn't support attachments, the Matroska muxer drops them when
in WebM mode. This happened silently until this commit which adds a
warning for this.
Signed-off-by: Andreas Rheinhardt
---
libavformat/matroskaenc.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
Up until now, the TrackUID of a Matroska track which is supposed to be
random was not random at all: It always coincided with the TrackNumber
which is usually the 1-based index of the corresponding stream in the
array of AVStreams. This has been changed: It is now set via an AVLFG
if AVFMT_FLAG_BIT
Write a few numbers directly via AV_WB32 instead of using an AVIOContext
(that is initialized only for this very purpose) to write these numbers
at known offsets into a fixed buffer.
Signed-off-by: Andreas Rheinhardt
---
libavformat/matroskaenc.c | 23 ++-
1 file changed, 10
mkv_cuepoint (the structure used to store the index entries in our
Matroska muxer) currently contains fields for both the index of the
packet's stream in the AVFormatContext->streams array and for the
Matroska TrackNumber; correspondingly, mkv_add_cuepoint() has arguments
for both. But these two nu
The Matroska muxer does not write every stream as a Matroska track; some
streams are written as attachments. But should no stream be written as a
Matroska track, the Matroska muxer would nevertheless write a Tracks
element without a TrackEntry. This is against the spec. This commit
changes this and
Set surfaces pool used for storing reference frames dynamically
according to SPS.(reference framecount, reordered frame number, etc)
Compared to a fixed pool size for H.264 and HEVC, the usage of
GPU memory could be improved.
CMD:
ffmpeg -hwaccel vaapi -vaapi_device /dev/dri/renderD128
-i
On Mon, Nov 4, 2019 at 4:55 PM James Zern wrote:
>
> On Sat, Nov 2, 2019 at 9:20 AM Marton Balint wrote:
> >
> > Signed-off-by: Marton Balint
> > ---
> > libavcodec/libvpxenc.c | 60
> > ++
> > 1 file changed, 36 insertions(+), 24 deletions(-)
>
On Fri, Nov 1, 2019 at 1:01 PM James Zern wrote:
>
> On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote:
> >
> > This avoids copying the full frame after decoding.
> >
> > Signed-off-by: Marton Balint
> > ---
> > libavcodec/libvpxdec.c | 73
> > ++-
On Fri, Nov 1, 2019 at 11:55 AM James Zern wrote:
>
> On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote:
> >
> > If the alpha decoder init failed we presented the error message from the
> > normal
> > decoder. This change should prevent such mistakes.
> >
> > Signed-off-by: Marton Balint
> >
On 06-11-2019 12:30 pm, leozhang wrote:
Signed-off-by: leozhang
---
libavcodec/extract_extradata_bsf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/extract_extradata_bsf.c
b/libavcodec/extract_extradata_bsf.c
index 17e5deb..ff111de 100644
--- a/libavco
On Fri, Nov 1, 2019 at 1:01 PM James Zern wrote:
>
> On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote:
> >
> > Signed-off-by: Marton Balint
> > ---
> > libavcodec/libvpxdec.c | 11 +++
> > 1 file changed, 11 insertions(+)
> >
>
> lgtm.
applied, thanks.
_
On Fri, Nov 1, 2019 at 11:47 AM James Zern wrote:
>
> On Sun, Oct 27, 2019 at 10:10 AM Marton Balint wrote:
> >
> > Signed-off-by: Marton Balint
> > ---
> > libavcodec/libvpxenc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> lgtm.
applied, thanks.
_
On Fri, Nov 1, 2019 at 11:52 AM James Zern wrote:
>
> On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote:
> >
> > Signed-off-by: Marton Balint
> > ---
> > libavcodec/libvpxdec.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> lgtm. good catch.
applied, thanks.
_
63 matches
Mail list logo
