Re: [FFmpeg-devel] [PATCH V3] avfilter/vf_bilateral: process command to set the parameter at runtime

2019-11-02 Thread Tao Zhang
Good weekend. Is it ok or any more suggestions? Tao Zhang 于2019年10月28日周一 下午2:53写道: > > ping > > leozhang 于2019年10月24日周四 下午5:18写道: > > > > Reviewed-by: Paul B Mahol > > Reviewed-by: Jun Zhao > > Signed-off-by: leozhang > > --- > > libavfilter/vf_bilateral.c | 57 > > +

Re: [FFmpeg-devel] [PATCH V3] avfilter/vf_bilateral: process command to set the parameter at runtime

2019-11-02 Thread Paul B Mahol
You mixed functional and non-functional changes in single patch. This is big no. On 11/2/19, Tao Zhang wrote: > Good weekend. Is it ok or any more suggestions? > > Tao Zhang 于2019年10月28日周一 下午2:53写道: >> >> ping >> >> leozhang 于2019年10月24日周四 下午5:18写道: >> > >> > Reviewed-by: Paul B Mahol >> > Rev

Re: [FFmpeg-devel] [PATCH 5/5] avformat/Makefile: add missing pcm dependency to sdx demuxer

2019-11-02 Thread Carl Eugen Hoyos
Am Fr., 1. Nov. 2019 um 23:37 Uhr schrieb Lou Logan : [...] Set lgtm. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-

Re: [FFmpeg-devel] [PATCH V3] avfilter/vf_bilateral: process command to set the parameter at runtime

2019-11-02 Thread Tao Zhang
Paul B Mahol 于2019年11月2日周六 下午6:34写道: > > You mixed functional and non-functional changes in single patch. Lesson learned. I'll submit a new patch. Thanks a lot. Today is a good day. > This is big no. > > On 11/2/19, Tao Zhang wrote: > > Good weekend. Is it ok or any more suggestions? > > > > Tao

[FFmpeg-devel] [PATCH V1 1/5] lavf/hls: fix the log context setting in log message

2019-11-02 Thread Jun Zhao
From: Jun Zhao Fix the log context setting in log message Signed-off-by: Jun Zhao --- libavformat/hls.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index ac151d5..8ce1ad9 100644 --- a/libavformat/hls.c +++ b/libavf

[FFmpeg-devel] [PATCH V1 2/5] lavf/mov: add log context dump in log message

2019-11-02 Thread Jun Zhao
From: Jun Zhao add log context dump in log message. Signed-off-by: Jun Zhao --- libavformat/mov.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 4f69664..d5c67fb 100644 --- a/libavformat/mov.c

[FFmpeg-devel] [PATCH V1 4/5] lavf/flvenc: Cosmetics: fix indentation

2019-11-02 Thread Jun Zhao
From: Jun Zhao fix indentation Signed-off-by: Jun Zhao --- libavformat/flvenc.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index fb1dede..9d13275 100644 --- a/libavformat/flvenc.c +++ b/libavformat/flvenc.c @@ -97

[FFmpeg-devel] [PATCH V1 3/5] lavf/hls: support probesize/max_analyze_duration when open sub-demuxer

2019-11-02 Thread Jun Zhao
From: Jun Zhao Add probesize/max_analyze_duration support when open the sub-demuxer, it's will be used to minimizing the initial delay. Signed-off-by: Jun Zhao --- libavformat/hls.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c

[FFmpeg-devel] [PATCH V1 5/5] lavf/dashend: enable probesize/max_analyze_duration setting in sub-demuxer

2019-11-02 Thread Jun Zhao
From: Jun Zhao Enable probesize/max_analyze_duration setting when open the sub-demuxer, it's will be used to minimizing the initial delay. Signed-off-by: Jun Zhao --- libavformat/dashdec.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/dashdec.c b/libav

[FFmpeg-devel] [PATCH 1/2] tools/probetest: replace the deprecated API

2019-11-02 Thread zhongli_dev
From: Zhong Li Signed-off-by: Zhong Li --- tools/probetest.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/probetest.c b/tools/probetest.c index 2c6c1de246..cfa309cabd 100644 --- a/tools/probetest.c +++ b/tools/probetest.c @@ -38,9 +38,10 @@ static const char

[FFmpeg-devel] [PATCH 2/2] tools/enum_options: replace the deprecated API

2019-11-02 Thread zhongli_dev
From: Zhong Li Signed-off-by: Zhong Li --- tools/enum_options.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/enum_options.c b/tools/enum_options.c index 77e1f9f799..28631d1a6b 100644 --- a/tools/enum_options.c +++ b/tools/enum_options.c @@ -88,20 +88,22 @

[FFmpeg-devel] [PATCH 5/5] avcodec/ralf: use multiply instead of shift to avoid undefined behavior in decode_block()

2019-11-02 Thread Michael Niedermayer
Fixes: left shift of negative value -249 Fixes: 18566/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RALF_fuzzer-5649394561187840 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/ralf.c | 2

[FFmpeg-devel] [PATCH 2/5] avcodec/nuv: Move comptype check up

2019-11-02 Thread Michael Niedermayer
Fixes: Timeout (23sec -> 5ms) Fixes: 18517/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NUV_fuzzer-5753135536013312 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/nuv.c | 8 +--- 1 f

Re: [FFmpeg-devel] Reimbursement request

2019-11-02 Thread Michael Niedermayer
On Wed, Oct 30, 2019 at 09:25:24PM +0100, Carl Eugen Hoyos wrote: > Hi! > > I am requesting reimbursement for my travel to the Google mentor summit. > My total travelling expenses were € 90,90 LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugf

[FFmpeg-devel] [PATCH 4/5] avcodec/atrac3: Check for huge block aligns

2019-11-02 Thread Michael Niedermayer
The largest documented frame size = block align is 1024 bytes (https://wiki.multimedia.cx/index.php/ATRAC3) Without a limit this can allocate arbitrary memory and trigger OOM Fixes: OOM Fixes: 18337/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC3_fuzzer-5763861478637568 Fixes: 18556/clu

[FFmpeg-devel] [PATCH 3/5] avcodec/wmavoice: Fix integer overflow in synth_frame()

2019-11-02 Thread Michael Niedermayer
Fixes: left shift of negative value -3 Fixes: 18518/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMAVOICE_fuzzer-6560514359951360 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/wmavoice.

[FFmpeg-devel] [PATCH 1/5] avcodec/agm: Do not allow MVs out of the picture area as no edge is allocated

2019-11-02 Thread Michael Niedermayer
Fixes: out of array access Fixes: 18499/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AGM_fuzzer-5749038406434816 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/agm.c | 4 ++-- 1 file cha

[FFmpeg-devel] [RFC PATCH] avutil/frame: fix remove_side_data

2019-11-02 Thread Zhao Zhili
From: Zhao Zhili remove_side_data is supposed to remove a single instance by design. Since new_side_data() doesn't forbid add multiple instance of the same type, remove_side_data should deal with that. --- libavutil/frame.c | 21 + 1 file changed, 13 insertions(+), 8 deletion

[FFmpeg-devel] [PATCHv2 2/6] avcodec/libvpxenc: only allocate alpha U/V planes on size changes

2019-11-02 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/libvpxenc.c | 60 ++ 1 file changed, 36 insertions(+), 24 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 4c02315fd2..ae3fdf1028 100644 --- a/libavcodec/libvpxenc.c +++ b/l

Re: [FFmpeg-devel] [PATCH] avfilter: add eval video filter

2019-11-02 Thread Michael Niedermayer
On Fri, Nov 01, 2019 at 09:38:39PM +0100, Paul B Mahol wrote: > On 11/1/19, Michael Niedermayer wrote: > > On Fri, Nov 01, 2019 at 04:50:38PM +0100, Paul B Mahol wrote: > >> On 11/1/19, Michael Niedermayer wrote: > >> > On Fri, Nov 01, 2019 at 01:09:24PM +0100, Paul B Mahol wrote: > >> >> Signed-

Re: [FFmpeg-devel] [RFC PATCH] avutil/frame: fix remove_side_data

2019-11-02 Thread Marton Balint
On Sun, 3 Nov 2019, Zhao Zhili wrote: From: Zhao Zhili remove_side_data is supposed to remove a single instance by design. Since new_side_data() doesn't forbid add multiple instance of the same type, remove_side_data should deal with that. Please update the docs of the function that it rem

[FFmpeg-devel] [RFC PATCH v2] avutil/frame: fix remove_side_data

2019-11-02 Thread Zhao Zhili
remove_side_data is supposed to remove a single instance by design. Since new_side_data() doesn't forbid add multiple instances of the same type, remove_side_data should deal with that. --- I'm afraid this patch makes it harder to enforce single entry per type. libavutil/frame.c | 2 +- libavutil

Re: [FFmpeg-devel] [PATCH V1 2/5] lavf/mov: add log context dump in log message

2019-11-02 Thread Michael Niedermayer
On Sat, Nov 02, 2019 at 10:54:58PM +0800, Jun Zhao wrote: > From: Jun Zhao > > add log context dump in log message. > > Signed-off-by: Jun Zhao > --- > libavformat/mov.c | 30 +++--- > 1 files changed, 15 insertions(+), 15 deletions(-) LGTM thx [...] -- Michael

Re: [FFmpeg-devel] [PATCH v2] avformat: Add max_probe_packets option

2019-11-02 Thread Michael Niedermayer
On Fri, Nov 01, 2019 at 01:58:59PM -0400, Andriy Gelman wrote: > Michael, > On Sat, 19. Oct 16:54, Michael Niedermayer wrote: > > On Thu, Oct 17, 2019 at 10:49:20AM -0400, Andriy Gelman wrote: > > > From: Andriy Gelman > > > > > > Allows user to set maximum number of buffered packets when > > > p

Re: [FFmpeg-devel] [PATCH] avcodec/dvdec: correctly decode bottom mb row in 1080i field mode

2019-11-02 Thread Baptiste Coudurier
On Wed, Sep 11, 2019 at 12:29 PM Baptiste Coudurier < baptiste.coudur...@gmail.com> wrote: > --- > libavcodec/dv.h| 2 ++ > libavcodec/dvdec.c | 90 +++--- > 2 files changed, 72 insertions(+), 20 deletions(-) > > diff --git a/libavcodec/dv.h b/libavcod

[FFmpeg-devel] [PATCH] avcodec/dvenc: support encoding dvcprohd

2019-11-02 Thread Baptiste Coudurier
--- libavcodec/dv.h | 1 + libavcodec/dvenc.c| 555 +- tests/fate/vcodec.mak | 14 +- 3 files changed, 514 insertions(+), 56 deletions(-) diff --git a/libavcodec/dv.h b/libavcodec/dv.h index 7ef5b7c552..0205d72347 100644 --- a/libavcodec/dv.h +

Re: [FFmpeg-devel] [PATCH] avcodec/dvdec: correctly set interlaced and tff

2019-11-02 Thread Baptiste Coudurier
On Wed, Sep 11, 2019 at 1:29 PM Baptiste Coudurier < baptiste.coudur...@gmail.com> wrote: > Hey Carl, > > On Sep 11, 2019, at 12:38 PM, Carl Eugen Hoyos wrote: > > Am Mi., 11. Sept. 2019 um 21:31 Uhr schrieb Baptiste Coudurier > : > > > --- > libavcodec/dvdec.c | 13 ++--- > 1 file changed

Re: [FFmpeg-devel] [PATCH] avcodec/dvenc: support encoding dvcprohd

2019-11-02 Thread Baptiste Coudurier
On Thu, Sep 19, 2019 at 12:34 PM Michael Niedermayer wrote: > On Wed, Sep 11, 2019 at 12:29:57PM -0700, Baptiste Coudurier wrote: > > --- > > libavcodec/dv.h| 1 + > > libavcodec/dvenc.c | 576 - > > 2 files changed, 522 insertions(+), 55 deletio

[FFmpeg-devel] [PATCH] [PATCH] avcodec: Add more kCVImageBufferColorPrimaries to videotoolboxenc

2019-11-02 Thread Nomis101
--- libavcodec/videotoolboxenc.c | 8 1 file changed, 8 insertions(+) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 40a7f643e0..cc08cf6a50 100644 --- a/libavcodec/videotoolboxenc.c +++ b/libavcodec/videotoolboxenc.c @@ -894,6 +894,14 @@ static int get_cv_

Re: [FFmpeg-devel] [PATCH] libavcodec/v4l2_m2m_enc:free v4l2 encode session properly when initialiZzation fails Fix ticket 8285 bug

2019-11-02 Thread Andriy Gelman
On Mon, 21. Oct 23:01, Colin NG wrote: > --- > libavcodec/v4l2_m2m_enc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/v4l2_m2m_enc.c b/libavcodec/v4l2_m2m_enc.c > index 474e6bef89..17fc3d30cf 100644 > --- a/libavcodec/v4l2_m2m_enc.c > +++ b/libavcodec/v4l2_m2m_enc.c > @@ -3

[FFmpeg-devel] [PATCH] avutil/eval: add function to track variable use

2019-11-02 Thread Gyan
Helps better identification of expr eval failures. Gyan From 19bce329464676f071707b99575f80e5abe1cd4c Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sat, 2 Nov 2019 20:16:42 +0530 Subject: [PATCH] avutil/eval: add function to track variable use Helps avoid multiple evals of cross-referenced e

Re: [FFmpeg-devel] [PATCH] avcodec/dvenc: support encoding dvcprohd

2019-11-02 Thread Carl Eugen Hoyos
Am Sa., 2. Nov. 2019 um 20:06 Uhr schrieb Baptiste Coudurier : > -if (avctx->height > 576) { > -av_log(avctx, AV_LOG_ERROR, "DVCPRO HD encoding is not > supported.\n"); > -return AVERROR_PATCHWELCOME; > -} Please mention ticket #1370. Thank you for the patch, Carl Eugen

Re: [FFmpeg-devel] [PATCH] avcodec/dvdec: correctly decode bottom mb row in 1080i field mode

2019-11-02 Thread Carl Eugen Hoyos
Am Sa., 2. Nov. 2019 um 20:02 Uhr schrieb Baptiste Coudurier : > > On Wed, Sep 11, 2019 at 12:29 PM Baptiste Coudurier < > baptiste.coudur...@gmail.com> wrote: > > > --- > > libavcodec/dv.h| 2 ++ > > libavcodec/dvdec.c | 90 +++--- > > 2 files changed,