LGTM
On 10/19/19, Michael Niedermayer wrote:
> Fixes: NULL pointer dereference
> Fixes:
> 18331/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-5652847445671936
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-
On Sat, Oct 19, 2019 at 11:11:07AM -0300, James Almer wrote:
> Despite the doxy stating that it's called when the muxer is destroyed,
> this was not true in practice. It's only called by av_write_trailer()
> and on init() failure.
>
> An AVFormatContext may be closed without writing the trailer if
IIDC camera sources can now be listed by using the following command:
ffmpeg -sources libdc1394
The basic structure of this function was borrowed from
libavdevice/alsa.c:ff_alsa_get_device_list.
Signed-off-by: Forest Crossman
---
libavdevice/libdc1394.c | 73 +++
Signed-off-by: Forest Crossman
---
doc/indevs.texi | 51 +
1 file changed, 51 insertions(+)
diff --git a/doc/indevs.texi b/doc/indevs.texi
index 757fac91de..078f45497a 100644
--- a/doc/indevs.texi
+++ b/doc/indevs.texi
@@ -1086,6 +1086,57 @@ Set th
Signed-off-by: Forest Crossman
---
doc/indevs.texi | 3 ++
libavdevice/libdc1394.c | 70 -
2 files changed, 51 insertions(+), 22 deletions(-)
diff --git a/doc/indevs.texi b/doc/indevs.texi
index 14595774f3..757fac91de 100644
--- a/doc/indevs.texi
Without this, the timestamp will unexpectedly wrap around after
approximately 2146 frames (on a 64-bit system, at least), which is about
19 minutes at the lowest framerate supported by the IIDC standard and
about 9 seconds at the highest supported framerate.
To fix this, we use av_rescale() to do
Without this, if a mode or framerate is selected that the camera doesn't
support, it's possible that the camera will enter a state where it won't
respond until it's power-cycled.
Tested with an Apple iSight.
Signed-off-by: Forest Crossman
---
libavdevice/libdc1394.c | 56 +++
I was having trouble with libdc1394 the first time I used it (e.g.,
setting unsupported video modes/framerates on cameras, trying to use
multiple cameras, tring to figure out how to set the arguments so the
command would actually work, etc.) so I thought I'd go ahead and add
some ease-of-use enhanc
Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type
'int'
Fixes:
18333/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_COMFORTNOISE_fuzzer-5668481831272448
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-b
Signed-off-by: Michael Niedermayer
---
libavutil/lfg.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/libavutil/lfg.h b/libavutil/lfg.h
index 94b02909ec..2b669205d1 100644
--- a/libavutil/lfg.h
+++ b/libavutil/lfg.h
@@ -24,6 +24,12 @@
#include
+/**
+ * Context structure for the L
This patch (and others in this set) appear to have been sent multiple
times. This is the latest received one, so reviewing this one.
On 20-10-2019 03:25 PM, Forest Crossman wrote:
Signed-off-by: Forest Crossman
---
doc/indevs.texi | 51 +
1 fi
On Sun, Oct 20, 2019 at 5:21 AM Gyan wrote:
>
> This patch (and others in this set) appear to have been sent multiple
> times. This is the latest received one, so reviewing this one.
Interesting, sorry about that. I only ran git send-email once, but I
did notice that the messages arrived out-of-o
Despite the doxy stating that it's called when the muxer is destroyed,
this was not true in practice. It's only called by av_write_trailer()
and on init() failure.
An AVFormatContext may be closed without writing the trailer if errors
ocurred while muxing packets, so in order to prevent memory lea
Paul B Mahol (12019-10-19):
> Fixes #8313
>
> Signed-off-by: Paul B Mahol
> ---
> libavfilter/vf_tile.c | 1 +
> 1 file changed, 1 insertion(+)
Ok.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-d
On Sat, Oct 19, 2019 at 22:33:55 -0700, Jun Li wrote:
> +ret = ff_replaygain_export(st, s->internal->id3v2_meta);
In libavformat/Makefile, CONFIG_W64_DEMUXER and CONFIG_WAV_DEMUXER now
probably need to depend on replaygain.o.
(I made the same mistake recently.)
Cheers,
Moritz
___
On Sun, Oct 20, 2019 at 10:09:45AM +0200, Paul B Mahol wrote:
> LGTM
will apply
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever
On Sun, Sep 29, 2019 at 01:53:44AM +0200, Michael Niedermayer wrote:
> Fixes: TImeout (20sec -> 4sec)
> Fixes:
> 17735/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DXV_fuzzer-5723368317255680
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/
On Sun, Sep 29, 2019 at 01:53:41AM +0200, Michael Niedermayer wrote:
> Fixes: signed integer overflow: 62220 * 262144 cannot be represented in type
> 'int'
> Fixes:
> 17145/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1IMAGE_fuzzer-5667394743173120
>
> Found-by: continuous fuzzing process
On Mon, Sep 30, 2019 at 06:30:24PM +0200, Michael Niedermayer wrote:
> Fixes: signed integer overflow: -1795675744 + -1926578528 cannot be
> represented in type 'int'
> Fixes:
> 17741/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5131336402075648
>
> Found-by: continuous f
On Tue, Oct 01, 2019 at 01:12:51AM +0200, Michael Niedermayer wrote:
> Fixes: Timeout (15sec -> 72ms)
> Fixes:
> 17774/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALIAS_PIX_fuzzer-5193929107963904
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/pro
On Tue, Oct 01, 2019 at 01:12:52AM +0200, Michael Niedermayer wrote:
> Fixes: signed integer overflow: -2147481503 + -32732 cannot be represented in
> type 'int'
> Fixes:
> 17782/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMACKAUD_fuzzer-5769672225456128
>
> Found-by: continuous fuzzing p
On Tue, Oct 01, 2019 at 01:12:53AM +0200, Michael Niedermayer wrote:
> Fixes: signed integer overflow: 2147483628 + 128 cannot be represented in
> type 'int'
> Fixes:
> 17783/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5146470595952640
>
> Found-by: continuous fuzzing process
On Wed, Oct 02, 2019 at 11:37:40PM +0200, Michael Niedermayer wrote:
> Fixes: Timeout (19sec -> 44ms)
> Fixes:
> 17816/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PTX_fuzzer-5704459950227456
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/
On Fri, Oct 04, 2019 at 07:59:39PM +0200, Michael Niedermayer wrote:
> Fixes: Timeout (14sec - 120ms)
> Fixes:
> 17824/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AGM_fuzzer-5639825457152000
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects
Signed-off-by: Paul B Mahol
---
doc/filters.texi | 32 +++
libavfilter/Makefile | 2 +
libavfilter/allfilters.c | 2 +
libavfilter/vf_maskedminmax.c | 359 ++
4 files changed, 395 insertions(+)
create mode 100644 libavfilter/vf_mask
Instead of rounding toward zero and thus producing
darker output.
Signed-off-by: Paul B Mahol
---
libavfilter/vf_nlmeans.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c
index dcb5a03953..06233b0dd4 100644
--- a/libavfilter
Enhancement #7803
Copy id3 metadata to format meta data and stream side data.
Signed-off-by: Jun Li
---
libavformat/Makefile | 4 ++--
libavformat/wavdec.c | 10 ++
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/libavformat/Makefile b/libavformat/Makefile
index 615156c1
Fixes: null pointer dereference
Fixes:
18341/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC9_fuzzer-5681203490848768
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/atrac9dec.c | 1 +
Fixes: shift exponent -14 is negative
Fixes:
18335/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RAWVIDEO_fuzzer-5723267192586240
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/rawdec.c |
Fixes: signed integer overflow: 2117181180 + 60483298 cannot be represented in
type 'int'
Fixes:
18344/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5685327791915008
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by:
The largest documented frame size = block align is 1024 bytes
(https://wiki.multimedia.cx/index.php/ATRAC3)
Without a limit this can allocate arbitrary memory and trigger OOM
Fixes: OOM
Fixes:
18337/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC3_fuzzer-5763861478637568
Found-by: contin
On Sun, Oct 20, 2019 at 6:11 AM Moritz Barsnick wrote:
> On Sat, Oct 19, 2019 at 22:33:55 -0700, Jun Li wrote:
> > +ret = ff_replaygain_export(st, s->internal->id3v2_meta);
>
> In libavformat/Makefile, CONFIG_W64_DEMUXER and CONFIG_WAV_DEMUXER now
> probably need to depend on replaygain.o
From: Limin Wang
Signed-off-by: Limin Wang
---
libavcodec/hapdec.c | 19 +++
1 file changed, 3 insertions(+), 16 deletions(-)
diff --git a/libavcodec/hapdec.c b/libavcodec/hapdec.c
index 8c845770cf..dd325bb51a 100644
--- a/libavcodec/hapdec.c
+++ b/libavcodec/hapdec.c
@@ -246,7
ping
On Tue, Oct 08, 2019 at 11:04:51PM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Reviewed-by: Moritz Barsnick
> Signed-off-by: Limin Wang
> ---
> doc/filters.texi | 11 ++-
> libavfilter/af_silencedetect.c | 1 -
> 2 files changed, 10 insertions(+),
From: Limin Wang
Signed-off-by: Limin Wang
---
libavcodec/dds.c | 19 +++
1 file changed, 3 insertions(+), 16 deletions(-)
diff --git a/libavcodec/dds.c b/libavcodec/dds.c
index 9154f692fa..7c0ad9ee72 100644
--- a/libavcodec/dds.c
+++ b/libavcodec/dds.c
@@ -434,7 +434,7 @@ stat
Michael, this is the updated version, please help to review it.
On Fri, Oct 18, 2019 at 09:24:11AM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Threading is to avoid a core cpu being occupied fully with other filters like
> scale,
> regarding performance, if your cpu frequency
Signed-off-by: James Almer
---
libavformat/flacenc.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c
index a07260f426..93cc79bbe0 100644
--- a/libavformat/flacenc.c
+++ b/libavformat/flacenc.c
@@ -348,11 +348,17 @@ stat
Signed-off-by: James Almer
---
libavformat/ttaenc.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/libavformat/ttaenc.c b/libavformat/ttaenc.c
index d8e1136ead..73c29ae936 100644
--- a/libavformat/ttaenc.c
+++ b/libavformat/ttaenc.c
@@ -147,6 +147,7 @@ static int tta_write_traile
Signed-off-by: James Almer
---
libavformat/mp3enc.c | 24
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c
index f4814be80e..34b753ffa0 100644
--- a/libavformat/mp3enc.c
+++ b/libavformat/mp3enc.c
@@ -473,8 +473,6
If the trailer is never writen, there could be buffered pages that would leak.
Signed-off-by: James Almer
---
libavformat/oggenc.c | 8
1 file changed, 8 insertions(+)
diff --git a/libavformat/oggenc.c b/libavformat/oggenc.c
index 06021c4f4b..77aa2518dc 100644
--- a/libavformat/oggenc.
On 10/20/2019 11:49 PM, James Almer wrote:
> If the trailer is never writen, there could be buffered pages that would leak.
Much like the avi patch i sent the other day, this fix also depends on
"avformat: call AVOutputFormat->deinit() when freeing the context".
>
> Signed-off-by: James Almer
>
James Almer:
> Signed-off-by: James Almer
> ---
> libavformat/ttaenc.c | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/libavformat/ttaenc.c b/libavformat/ttaenc.c
> index d8e1136ead..73c29ae936 100644
> --- a/libavformat/ttaenc.c
> +++ b/libavformat/ttaenc.c
> @@ -147,6 +147
On 21-10-2019 06:17 AM, Limin Wang wrote:
ping
Pushed as 0afc1fe1470094e84dfa4e25a7f1bb2d52fbb92c
On Tue, Oct 08, 2019 at 11:04:51PM +0800, lance.lmw...@gmail.com wrote:
From: Limin Wang
Reviewed-by: Moritz Barsnick
Signed-off-by: Limin Wang
---
doc/filters.texi | 11 ++
James Almer:
> Signed-off-by: James Almer
> ---
> libavformat/mp3enc.c | 24
> 1 file changed, 20 insertions(+), 4 deletions(-)
>
> diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c
> index f4814be80e..34b753ffa0 100644
> --- a/libavformat/mp3enc.c
> +++ b/libavfo
On Sun, Oct 20, 2019 at 09:54:16PM +0200, Paul B Mahol wrote:
> Instead of rounding toward zero and thus producing
> darker output.
>
> Signed-off-by: Paul B Mahol
> ---
> libavfilter/vf_nlmeans.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavfilter/vf_nlmeans.c
45 matches
Mail list logo