Re: [FFmpeg-devel] [PATCH V2] lavfi/hqdn3d: add slice thread optimization

On 10/8/19, Jun Zhao wrote: > From: Jun Zhao > > Enabled one thread per planar, used the test command for 1080P video > (YUV420P format) as follow: > > ffmpeg -i 1080p.mp4 -an -vf hqdn3d -f null /dev/nul > > This optimization improved the performance about 30% in 1080P YUV420P > case (from 110fps

Re: [FFmpeg-devel] [PATCH] doc/examples/decode_audio: read the audio data from data[0]

On 10/8/19, Steven Liu wrote: > > >> 在 2019年10月8日，16:48，Paul B Mahol 写道： >> >> On 10/8/19, Steven Liu wrote: >>> only frame linesize[0] can get length size, >>> i have tested before patch like this: >>> ffmpeg -i /Users/liuqi/input.mp3 -codec:a ac3 -ac 5 a.ac3 >>> ./doc/examples/decode_audio a.a

[FFmpeg-devel] [PATCH v1 01/11] avformat/hlsenc: move freep segment from sls_flags_filename_process after caller failed

Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index cd4320114d..a1c03dbed5 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -887,7 +887,6 @@ static int sls_flags_

[FFmpeg-devel] [PATCH v1 07/11] avformat/rl2: fix memleak when read end of file

Signed-off-by: Steven Liu --- libavformat/rl2.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/libavformat/rl2.c b/libavformat/rl2.c index d847d9aaa8..07696965c7 100644 --- a/libavformat/rl2.c +++ b/libavformat/rl2.c @@ -171,18 +171,24 @@ static av_cold

[FFmpeg-devel] [PATCH v1 04/11] avformat/jvdec: fix memleak when read_header failed

Signed-off-by: Steven Liu --- libavformat/jvdec.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/jvdec.c b/libavformat/jvdec.c index 18c81f0de7..17ada7b0f1 100644 --- a/libavformat/jvdec.c +++ b/libavformat/jvdec.c @@ -113,9 +113,10 @@ static int read_heade

[FFmpeg-devel] [PATCH v1 02/11] avformat/hlsenc: fix memleak of vtt_dirname_r in hls_delete_old_segments

Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index a1c03dbed5..a689acc2e0 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -575,6 +575,7 @@ static int hls_delete_old_segments(AVFor

[FFmpeg-devel] [PATCH v1 11/11] avformat/wc3movie: fix memleak when read content size not equvipe input size

Signed-off-by: Steven Liu --- libavformat/wc3movie.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/wc3movie.c b/libavformat/wc3movie.c index 27f5eb1962..657700 100644 --- a/libavformat/wc3movie.c +++ b/libavformat/wc3movie.c @@ -130,8 +130,10 @@ static int

[FFmpeg-devel] [PATCH v1 03/11] avformat/iff: fix memleak when get st->codecpar->extradata failed in iff_read_header

Signed-off-by: Steven Liu --- libavformat/iff.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/iff.c b/libavformat/iff.c index f4d806b7b8..2a3729f97e 100644 --- a/libavformat/iff.c +++ b/libavformat/iff.c @@ -529,8 +529,11 @@ static int iff_read_header(AVForma

[FFmpeg-devel] [PATCH v1 08/11] avformat/rtmpproto: fix memleak when open rtmp failed

Signed-off-by: Steven Liu --- libavformat/rtmpproto.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index eb08d4d424..ae5eef8bca 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -2880,6 +2880,12 @@ reconnect:

[FFmpeg-devel] [PATCH v1 09/11] avformat/smacker: fix memleak when avformat_new_stream failed

Signed-off-by: Steven Liu --- libavformat/smacker.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavformat/smacker.c b/libavformat/smacker.c index b5c858aa9b..239894dad0 100644 --- a/libavformat/smacker.c +++ b/libavformat/smacker.c @@ -172,8 +172,11 @@ static

[FFmpeg-devel] [PATCH v1 05/11] avformat/libmodplug: fix memleak when load modplug failed

Signed-off-by: Steven Liu --- libavformat/libmodplug.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/libmodplug.c b/libavformat/libmodplug.c index 314bdae3e7..d4f78d99b1 100644 --- a/libavformat/libmodplug.c +++ b/libavformat/libmodplug.c @@ -216,9 +216,10 @

[FFmpeg-devel] [PATCH v1 10/11] avformat/swfdec: fix memleak when inflateInit failed

Signed-off-by: Steven Liu --- libavformat/swfdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/swfdec.c b/libavformat/swfdec.c index 85bd30404e..a9358f09a9 100644 --- a/libavformat/swfdec.c +++ b/libavformat/swfdec.c @@ -152,6 +152,8 @@ static int swf_read_header(AVFormatCon

[FFmpeg-devel] [PATCH v1 06/11] avformat/mpc8: fix memleak when seek table too big

Signed-off-by: Steven Liu --- libavformat/mpc8.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mpc8.c b/libavformat/mpc8.c index 0eb879ffc0..e452cd6878 100644 --- a/libavformat/mpc8.c +++ b/libavformat/mpc8.c @@ -168,6 +168,7 @@ static void mpc8_parse_seektable(AVFormatContext *

Re: [FFmpeg-devel] [PATCH v1 03/11] avformat/iff: fix memleak when get st->codecpar->extradata failed in iff_read_header

lgtm On 10/9/19, Steven Liu wrote: > Signed-off-by: Steven Liu > --- > libavformat/iff.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavformat/iff.c b/libavformat/iff.c > index f4d806b7b8..2a3729f97e 100644 > --- a/libavformat/iff.c > +++ b/libavformat/iff.c >

Re: [FFmpeg-devel] [PATCH v1 04/11] avformat/jvdec: fix memleak when read_header failed

On Wed, Oct 09, 2019 at 03:35:23PM +0800, Steven Liu wrote: > Signed-off-by: Steven Liu > --- > libavformat/jvdec.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/libavformat/jvdec.c b/libavformat/jvdec.c > index 18c81f0de7..17ada7b0f1 100644 > --- a/libavformat/

[FFmpeg-devel] [PATCH v1 1/2] avformat/hlsenc: free the original malloc pointer to avoid error when system function used in the following patch

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/hlsenc.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index b9f5b69fcf..5d8c4a3a8f 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -493,8 +

[FFmpeg-devel] [PATCH v1 2/2] avutil/avstring: replace with system interface if dirname and basename functions are detected

From: Limin Wang Signed-off-by: Limin Wang --- configure| 4 libavutil/avstring.c | 13 - 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 8413826f9e..5296a4cc93 100755 --- a/configure +++ b/configure @@ -2188,6 +2188,8 @@

Re: [FFmpeg-devel] [PATCH v1 02/11] avformat/hlsenc: fix memleak of vtt_dirname_r in hls_delete_old_segments

On Wed, Oct 09, 2019 at 03:35:21PM +0800, Steven Liu wrote: > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index a1c03dbed5..a689acc2e0 100644 > --- a/libavformat/hlsenc.c > +++ b/lib

Re: [FFmpeg-devel] [PATCH v1 02/11] avformat/hlsenc: fix memleak of vtt_dirname_r in hls_delete_old_segments

> 在 2019年10月9日，16:36，Limin Wang 写道： > > On Wed, Oct 09, 2019 at 03:35:21PM +0800, Steven Liu wrote: >> Signed-off-by: Steven Liu >> --- >> libavformat/hlsenc.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c >> index a1c03dbed5..a689acc2e

Re: [FFmpeg-devel] [PATCH v1 1/2] avformat/hlsenc: free the original malloc pointer to avoid error when system function used in the following patch

> 在 2019年10月9日，16:28，lance.lmw...@gmail.com 写道： > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/hlsenc.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index b9f5b69fcf..5d8c4a3a8f 100

[FFmpeg-devel] [PATCH v2 1/2] avformat/hlsenc: free the original malloc pointer to avoid error when system function used in the following patch

From: Limin Wang Signed-off-by: Limin Wang --- git format the patch on master, the v1 depend on other patch and can't git am directly. libavformat/hlsenc.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index cd4320

[FFmpeg-devel] [PATCH v2 2/2] avutil/avstring: replace with system interface if dirname and basename functions are detected

From: Limin Wang Signed-off-by: Limin Wang --- configure| 4 libavutil/avstring.c | 13 - 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 8413826..5296a4c 100755 --- a/configure +++ b/configure @@ -2188,6 +2188,8 @@ SYSTEM

Re: [FFmpeg-devel] [PATCH 1/8] avutil/opt: add AV_OPT_FLAG_COMMAND_PARAM flag

Because this receives no comments so fat at all, will apply asap this set. On 10/8/19, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavutil/opt.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavutil/opt.h b/libavutil/opt.h > index 39f4a8dda0..693a170bcc 100644 > ---

Re: [FFmpeg-devel] [PATCH 1/8] avutil/opt: add AV_OPT_FLAG_COMMAND_PARAM flag

Paul B Mahol (12019-10-09): > Because this receives no comments so fat at all, will apply asap this set. Less than 24 hours for something that changes the public API? Out of the question. If in one week you had no comments, you can ask again that people look into it. Regards, -- Nicolas Geor

Re: [FFmpeg-devel] [PATCH 1/8] avutil/opt: add AV_OPT_FLAG_COMMAND_PARAM flag

On 10/9/19, Nicolas George wrote: > Paul B Mahol (12019-10-09): >> Because this receives no comments so fat at all, will apply asap this >> set. > > Less than 24 hours for something that changes the public API? Out of the > question. This only adds single flag. > > If in one week you had no comm

[FFmpeg-devel] lavc/vaapi_encode: add support for maxframesize

Ping for the patch set: https://patchwork.ffmpeg.org/patch/13949/ https://patchwork.ffmpeg.org/patch/13950/ linjie binDZvhyPLKen.bin Description: FFmpeg-devel-v3-1-2-lavc-vaapi_encode-add-support-for-maxframesize.patch binrlGxg22TJb.bin Description: FFmpeg-devel-2-2-doc-vaapi_encode-add-docume

Re: [FFmpeg-devel] [PATCH 1/8] avutil/opt: add AV_OPT_FLAG_COMMAND_PARAM flag

Paul B Mahol (12019-10-09): > This only adds single flag. A flag that belongs in the public API, and therefore that we will have to support for a long time. Hence the need to make sure it is properly designed. > Out of question. Your reply with all due respect is ignored. This is not respect, th

Re: [FFmpeg-devel] [PATCH 1/8] avutil/opt: add AV_OPT_FLAG_COMMAND_PARAM flag

On 10/9/19, Nicolas George wrote: > Paul B Mahol (12019-10-09): >> This only adds single flag. > > A flag that belongs in the public API, and therefore that we will have > to support for a long time. Hence the need to make sure it is properly > designed. > >> Out of question. Your reply with all d

Re: [FFmpeg-devel] [PATCH 1/8] avutil/opt: add AV_OPT_FLAG_COMMAND_PARAM flag

Paul B Mahol (12019-10-09): > This is small patch Not when it touches public API. Anyway, I maintain lavfi, and I tell you not to commit before I reviewed. Break the rules and I will make sure that there are consequences. By the way, I had some time this morning, and I had considered reviewing

[FFmpeg-devel] [PATCH 04/13] avfilter/af_anlms: switch to ff_filter_process_command()

Signed-off-by: Paul B Mahol --- libavfilter/af_anlms.c | 27 ++- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/libavfilter/af_anlms.c b/libavfilter/af_anlms.c index 75bd969a83..b618e2367d 100644 --- a/libavfilter/af_anlms.c +++ b/libavfilter/af_anlms.c @@

[FFmpeg-devel] [PATCH 01/13] avutil/opt: add AV_OPT_FLAG_COMMAND_PARAM flag

Signed-off-by: Paul B Mahol --- libavutil/opt.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/opt.h b/libavutil/opt.h index 39f4a8dda0..693a170bcc 100644 --- a/libavutil/opt.h +++ b/libavutil/opt.h @@ -288,6 +288,7 @@ typedef struct AVOption { */ #define AV_OPT_FLAG_READONLY

[FFmpeg-devel] [PATCH 03/13] avutil/opt: print command flag too

Signed-off-by: Paul B Mahol --- libavutil/opt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/opt.c b/libavutil/opt.c index 7c2649725f..5bc70f7ffc 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -1217,6 +1217,7 @@ static void opt_list(void *obj, void *av_log_obj, const char

[FFmpeg-devel] [PATCH 05/13] avfilter/vf_gblur: switch to ff_filter_process_command()

Signed-off-by: Paul B Mahol --- libavfilter/vf_gblur.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/libavfilter/vf_gblur.c b/libavfilter/vf_gblur.c index 6ef261478f..6a4e7d6936 100644 --- a/libavfilter/vf_gblur.c +++ b/libavfilter/vf_gblur.c @@ -35,7 +

[FFmpeg-devel] [PATCH 02/13] avfilter/avfilter: add ff_filter_process_command()

Signed-off-by: Paul B Mahol --- libavfilter/avfilter.c | 13 + libavfilter/internal.h | 7 +++ 2 files changed, 20 insertions(+) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 93e866b79c..4d462d4e0a 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilt

[FFmpeg-devel] [PATCH 07/13] avfilter/af_anlmdn: switch to ff_filter_process_command()

Signed-off-by: Paul B Mahol --- libavfilter/af_anlmdn.c | 36 +++- 1 file changed, 7 insertions(+), 29 deletions(-) diff --git a/libavfilter/af_anlmdn.c b/libavfilter/af_anlmdn.c index b5bc94b4eb..8125005114 100644 --- a/libavfilter/af_anlmdn.c +++ b/libavfilter/a

[FFmpeg-devel] [PATCH 11/13] avfilter/vf_drawbox: use ff_filter_process_command()

Signed-off-by: Paul B Mahol --- libavfilter/vf_drawbox.c | 55 ++-- 1 file changed, 24 insertions(+), 31 deletions(-) diff --git a/libavfilter/vf_drawbox.c b/libavfilter/vf_drawbox.c index e5f5351b9d..2a5cd2ac48 100644 --- a/libavfilter/vf_drawbox.c +++ b/liba

[FFmpeg-devel] [PATCH 06/13] avfilter/vf_avgblur: switch to ff_filter_process_command()

Signed-off-by: Paul B Mahol --- libavfilter/vf_avgblur.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/libavfilter/vf_avgblur.c b/libavfilter/vf_avgblur.c index a1f6c9b80e..0857d11878 100644 --- a/libavfilter/vf_avgblur.c +++ b/libavfilter/vf_avgblur.c

[FFmpeg-devel] [PATCH 12/13] avfilter/af_rubberband: use ff_filter_process_command()

Signed-off-by: Paul B Mahol --- libavfilter/af_rubberband.c | 33 + 1 file changed, 9 insertions(+), 24 deletions(-) diff --git a/libavfilter/af_rubberband.c b/libavfilter/af_rubberband.c index ef937f4415..8db87fda1e 100644 --- a/libavfilter/af_rubberband.c +++ b/

[FFmpeg-devel] [PATCH 10/13] avfilter/vf_colorchannelmixer: add support for commands

Signed-off-by: Paul B Mahol --- libavfilter/vf_colorchannelmixer.c | 31 ++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/libavfilter/vf_colorchannelmixer.c b/libavfilter/vf_colorchannelmixer.c index 3a9cd37b78..074aa5e0f1 100644 --- a/libavfilter/vf_

[FFmpeg-devel] [PATCH 09/13] avfilter/vf_amplify: add support for commands

Signed-off-by: Paul B Mahol --- libavfilter/vf_amplify.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavfilter/vf_amplify.c b/libavfilter/vf_amplify.c index 48dcb93a67..590d31e57f 100644 --- a/libavfilter/vf_amplify.c +++ b/libavfilter/vf_amplify.c @@ -268

[FFmpeg-devel] [PATCH 13/13] avfilter/af_biquads: use ff_filter_process_command()

Signed-off-by: Paul B Mahol --- libavfilter/af_biquads.c | 133 +++ 1 file changed, 10 insertions(+), 123 deletions(-) diff --git a/libavfilter/af_biquads.c b/libavfilter/af_biquads.c index 247a47256f..43633a9e41 100644 --- a/libavfilter/af_biquads.c +++ b/lib

[FFmpeg-devel] [PATCH 08/13] avfilter/vf_scroll: add support for commands

Signed-off-by: Paul B Mahol --- libavfilter/vf_scroll.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_scroll.c b/libavfilter/vf_scroll.c index 32b36d5631..f233976c53 100644 --- a/libavfilter/vf_scroll.c +++ b/libavfilter/vf_scroll.c @@ -155,12 +155,

Re: [FFmpeg-devel] [PATCH 1/8] avutil/opt: add AV_OPT_FLAG_COMMAND_PARAM flag

On 10/9/19, Nicolas George wrote: > Paul B Mahol (12019-10-09): >> This is small patch > > Not when it touches public API. Such interpretation is not in documentation. > > Anyway, I maintain lavfi, and I tell you not to commit before I > reviewed. Such line is not in MAINTAINERS. > > Break the

Re: [FFmpeg-devel] [PATCH 1/8] avutil/opt: add AV_OPT_FLAG_COMMAND_PARAM flag

Paul B Mahol (12019-10-09): > Such interpretation is not in documentation. > Such line is not in MAINTAINERS. > This is violent attack. > I do not believe in your good faith regarding me ever. I will not argue further with you. You have been warned. Regards, -- Nicolas George signature.a

[FFmpeg-devel] [PATCH 2/6] avcodec/pcm: Check bits_per_coded_sample

Fixes: shift exponent -2 is negative Fixes: 17736/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PCM_F16LE_fuzzer-5742815929171968 Fixes: 17998/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PCM_F24LE_fuzzer-5716980383875072 Found-by: continuous fuzzing process https://github.com/google/o

Re: [FFmpeg-devel] [PATCH 1/8] avutil/opt: add AV_OPT_FLAG_COMMAND_PARAM flag

On 10/9/19, Nicolas George wrote: > Paul B Mahol (12019-10-09): >> Such interpretation is not in documentation. > >> Such line is not in MAINTAINERS. > >> This is violent attack. > >> I do not believe in your good faith regarding me ever. > > I will not argue further with you. You have been warned

[FFmpeg-devel] [PATCH 01/14] avutil/opt: add AV_OPT_FLAG_COMMAND_PARAM flag

Signed-off-by: Paul B Mahol --- libavutil/opt.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/opt.h b/libavutil/opt.h index 39f4a8dda0..693a170bcc 100644 --- a/libavutil/opt.h +++ b/libavutil/opt.h @@ -288,6 +288,7 @@ typedef struct AVOption { */ #define AV_OPT_FLAG_READONLY

[FFmpeg-devel] [PATCH 03/14] avutil/opt: print command flag too

Signed-off-by: Paul B Mahol --- libavutil/opt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/opt.c b/libavutil/opt.c index 7c2649725f..5bc70f7ffc 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -1217,6 +1217,7 @@ static void opt_list(void *obj, void *av_log_obj, const char

[FFmpeg-devel] [PATCH 02/14] avfilter/avfilter: add ff_filter_process_command()

Signed-off-by: Paul B Mahol --- libavfilter/avfilter.c | 13 + libavfilter/internal.h | 7 +++ 2 files changed, 20 insertions(+) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 93e866b79c..4d462d4e0a 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilt

[FFmpeg-devel] [PATCH 04/14] avfilter/af_anlms: switch to ff_filter_process_command()

Signed-off-by: Paul B Mahol --- libavfilter/af_anlms.c | 27 ++- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/libavfilter/af_anlms.c b/libavfilter/af_anlms.c index 75bd969a83..b618e2367d 100644 --- a/libavfilter/af_anlms.c +++ b/libavfilter/af_anlms.c @@

[FFmpeg-devel] [PATCH 05/14] avfilter/vf_gblur: switch to ff_filter_process_command()

Signed-off-by: Paul B Mahol --- libavfilter/vf_gblur.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/libavfilter/vf_gblur.c b/libavfilter/vf_gblur.c index 6ef261478f..6a4e7d6936 100644 --- a/libavfilter/vf_gblur.c +++ b/libavfilter/vf_gblur.c @@ -35,7 +

[FFmpeg-devel] [PATCH 09/14] avfilter/vf_amplify: add support for commands

Signed-off-by: Paul B Mahol --- libavfilter/vf_amplify.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavfilter/vf_amplify.c b/libavfilter/vf_amplify.c index 48dcb93a67..590d31e57f 100644 --- a/libavfilter/vf_amplify.c +++ b/libavfilter/vf_amplify.c @@ -268

[FFmpeg-devel] [PATCH 08/14] avfilter/vf_scroll: add support for commands

Signed-off-by: Paul B Mahol --- libavfilter/vf_scroll.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_scroll.c b/libavfilter/vf_scroll.c index 32b36d5631..f233976c53 100644 --- a/libavfilter/vf_scroll.c +++ b/libavfilter/vf_scroll.c @@ -155,12 +155,

[FFmpeg-devel] [PATCH 06/14] avfilter/vf_avgblur: switch to ff_filter_process_command()

Signed-off-by: Paul B Mahol --- libavfilter/vf_avgblur.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/libavfilter/vf_avgblur.c b/libavfilter/vf_avgblur.c index a1f6c9b80e..0857d11878 100644 --- a/libavfilter/vf_avgblur.c +++ b/libavfilter/vf_avgblur.c

[FFmpeg-devel] [PATCH 07/14] avfilter/af_anlmdn: switch to ff_filter_process_command()

Signed-off-by: Paul B Mahol --- libavfilter/af_anlmdn.c | 36 +++- 1 file changed, 7 insertions(+), 29 deletions(-) diff --git a/libavfilter/af_anlmdn.c b/libavfilter/af_anlmdn.c index b5bc94b4eb..8125005114 100644 --- a/libavfilter/af_anlmdn.c +++ b/libavfilter/a

[FFmpeg-devel] [PATCH 10/14] avfilter/vf_colorchannelmixer: add support for commands

Signed-off-by: Paul B Mahol --- libavfilter/vf_colorchannelmixer.c | 31 ++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/libavfilter/vf_colorchannelmixer.c b/libavfilter/vf_colorchannelmixer.c index 3a9cd37b78..074aa5e0f1 100644 --- a/libavfilter/vf_

[FFmpeg-devel] [PATCH 13/14] avfilter/af_biquads: use ff_filter_process_command()

Signed-off-by: Paul B Mahol --- libavfilter/af_biquads.c | 133 +++ 1 file changed, 10 insertions(+), 123 deletions(-) diff --git a/libavfilter/af_biquads.c b/libavfilter/af_biquads.c index 247a47256f..43633a9e41 100644 --- a/libavfilter/af_biquads.c +++ b/lib

[FFmpeg-devel] [PATCH 14/14] avfilter/af_atempo: use ff_filter_process_command()

Signed-off-by: Paul B Mahol --- libavfilter/af_atempo.c | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c index 688dac5464..39b500ba95 100644 --- a/libavfilter/af_atempo.c +++ b/libavfilter/af_atempo.c

[FFmpeg-devel] [PATCH 11/14] avfilter/vf_drawbox: use ff_filter_process_command()

Signed-off-by: Paul B Mahol --- libavfilter/vf_drawbox.c | 55 ++-- 1 file changed, 24 insertions(+), 31 deletions(-) diff --git a/libavfilter/vf_drawbox.c b/libavfilter/vf_drawbox.c index e5f5351b9d..2a5cd2ac48 100644 --- a/libavfilter/vf_drawbox.c +++ b/liba

[FFmpeg-devel] [PATCH 12/14] avfilter/af_rubberband: use ff_filter_process_command()

Signed-off-by: Paul B Mahol --- libavfilter/af_rubberband.c | 33 + 1 file changed, 9 insertions(+), 24 deletions(-) diff --git a/libavfilter/af_rubberband.c b/libavfilter/af_rubberband.c index ef937f4415..8db87fda1e 100644 --- a/libavfilter/af_rubberband.c +++ b/

[FFmpeg-devel] [PATCH 1/6] avcodec/aacdec_template: Check samplerate

A value above INT_MAX/2 can overflow in SBR Fixes: signed integer overflow: 2 * 1881153568 cannot be represented in type 'int' Fixes: 17996/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5687126468853760 Found-by: continuous fuzzing process https://github.com/google/oss-fuz

[FFmpeg-devel] [PATCH 5/6] tools/target_dec_fuzzer: Adjust threshold for G2M

G2M allows large images from small input and also reallocates multiple buffers on any resolution change. Fixes: Timeout (22sec -> 5sec) Fixes: 18022/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_G2M_fuzzer-5089192530411520 Found-by: continuous fuzzing process https://github.com/google/oss-f

[FFmpeg-devel] [PATCH 3/6] avcodec/rv10: Check input for minimal frame size

Fixes: Timeout (18sec -> 4sec) Fixes: 18012/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV20_fuzzer-5767486145822720 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/rv10.c | 7 +-- 1

[FFmpeg-devel] [PATCH 4/6] avcodec/aptx: Check the number of channels

Fixes: store to null pointer of type 'uint32_t' (aka 'unsigned int') Fixes: 18021/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APTX_HD_fuzzer-5761738313564160 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermay

[FFmpeg-devel] [PATCH 6/6] avcodec/wmaprodec: Fix cleanup on error

Fixes: memleaks Fixes: 18023/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XMA2_fuzzer-5642535011090432 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/wmaprodec.c | 7 +++ 1 file chan

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/pcm: Check bits_per_coded_sample

lgtm On 10/9/19, Michael Niedermayer wrote: > Fixes: shift exponent -2 is negative > Fixes: > 17736/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PCM_F16LE_fuzzer-5742815929171968 > Fixes: > 17998/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PCM_F24LE_fuzzer-5716980383875072 > > Found-by

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/wmaprodec: Fix cleanup on error

probably ok On 10/9/19, Michael Niedermayer wrote: > Fixes: memleaks > Fixes: > 18023/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XMA2_fuzzer-5642535011090432 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael N

[FFmpeg-devel] [PATCH] avfilter: fix typo in comments

From: Zhao Zhili --- libavfilter/avfilter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h index 9d70e7118b..3eaa8a4089 100644 --- a/libavfilter/avfilter.h +++ b/libavfilter/avfilter.h @@ -79,7 +79,7 @@ int avfilter_pad_count(c

Re: [FFmpeg-devel] [PATCH] avfilter: fix typo in comments

On Wed, Oct 9, 2019 at 8:06 PM wrote: > > From: Zhao Zhili > > --- > libavfilter/avfilter.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h > index 9d70e7118b..3eaa8a4089 100644 > --- a/libavfilter/avfilter.h > +++ b/libavf

[FFmpeg-devel] [PATCH V3 1/3] avfilter/dnn: add DLT prefix for enum DNNLayerType to avoid potential conflicts

and also change CONV to DLT_CONV2D for better description Signed-off-by: Guo, Yejun --- libavfilter/dnn/dnn_backend_native.c | 25 +++-- libavfilter/dnn/dnn_backend_native.h | 12 +++- libavfilter/dnn/dnn_backend_tf.c | 10 +- 3 files changed, 27 insertion

[FFmpeg-devel] [PATCH V3 2/3] avfilter/dnn: unify the layer execution function in native mode

Signed-off-by: Guo, Yejun --- libavfilter/dnn/Makefile | 1 + libavfilter/dnn/dnn_backend_native.c | 34 -- libavfilter/dnn/dnn_backend_native.h | 4 ++- libavfilter/dnn/dnn_backend_native_layer_conv2d.c | 4 ++- libavf

[FFmpeg-devel] [PATCH V3 3/3] avfilter/dnn: unify the layer load function in native mode

Signed-off-by: Guo, Yejun --- libavfilter/dnn/dnn_backend_native.c | 114 +++-- libavfilter/dnn/dnn_backend_native.h | 2 +- libavfilter/dnn/dnn_backend_native_layer_conv2d.c | 46 + libavfilter/dnn/dnn_backend_native_layer_conv2d.h | 1 +

Re: [FFmpeg-devel] [PATCH 1/8] avutil/opt: add AV_OPT_FLAG_COMMAND_PARAM flag

On Wed, Oct 09, 2019 at 11:24:55AM +0200, Paul B Mahol wrote: > Because this receives no comments so fat at all, will apply asap this set. I think you should be a bit more patient, threatening to apply after only about 24h. Just causes people who have an interrest in the code but cannot immedeatly

Re: [FFmpeg-devel] [PATCH v1 08/11] avformat/rtmpproto: fix memleak when open rtmp failed

On Wed, Oct 09, 2019 at 03:35:27PM +0800, Steven Liu wrote: > Signed-off-by: Steven Liu > --- > libavformat/rtmpproto.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c > index eb08d4d424..ae5eef8bca 100644 > --- a/libavformat/rtmpp

Re: [FFmpeg-devel] [PATCH v1 08/11] avformat/rtmpproto: fix memleak when open rtmp failed

On 10/9/19, Limin Wang wrote: > On Wed, Oct 09, 2019 at 03:35:27PM +0800, Steven Liu wrote: >> Signed-off-by: Steven Liu >> --- >> libavformat/rtmpproto.c | 6 ++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c >> index eb08d4d424..ae5e

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/mpjpegdec: fix strict boundary search string

On Tue, Oct 08, 2019 at 01:55:27PM +0200, Moritz Barsnick wrote: > On Tue, Oct 08, 2019 at 11:32:09 +0200, Michael Niedermayer wrote: > > > A side effect is that this coincidentally breaks enforcement of > > > strict MIME headers against servers running motion < 3.4.1, where > > > the boundary anno

Re: [FFmpeg-devel] [PATCH v1] avcodec/magicyuv: remove duplicate code

ping, I hope it makes sense to reduce the code size. On Tue, Sep 24, 2019 at 09:13:52AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/magicyuv.c | 30 ++ > 1 file changed, 6 insertions(+), 24 deletions(-) >

Re: [FFmpeg-devel] [PATCH] avcodec/exr: Allow duplicate use of channel indexes

On Tue, Oct 08, 2019 at 05:13:42PM +0200, Paul B Mahol wrote: > Why are you not gonna apply this patch? > > Fix code you break! I did not treat this patch special it was on the mailing list waiting for a review like any other bugfix ill apply it with my next push Thanks for remining me [...] -

[FFmpeg-devel] [PATCH V3] lavfi/hqdn3d: add slice thread optimization

From: Jun Zhao Enabled one thread per planar, used the test command for 1080P video (YUV420P format) as follow: ffmpeg -i 1080p.mp4 -an -vf hqdn3d -f null /dev/nul This optimization improved the performance about 30% in 1080P YUV420P case (from 110fps to 143fps), also pass the framemd5 check an

[FFmpeg-devel] [PATCH V1 1/4] lavfi/colorspace: typedef ThreadData as all other filters

From: Jun Zhao typedef ThreadData as all other filters. Signed-off-by: Jun Zhao --- libavfilter/vf_colorspace.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c index 04954c1..db41f64 100644 --- a/libavfil

[FFmpeg-devel] [PATCH V1 2/4] lavfi/lenscorrection: remove unnecessary cast for void *

From: Jun Zhao Remove unnecessary cast for void * pointer. Signed-off-by: Jun Zhao --- libavfilter/vf_lenscorrection.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavfilter/vf_lenscorrection.c b/libavfilter/vf_lenscorrection.c index 239fe19..b5400a2 100644 --- a

[FFmpeg-devel] [PATCH V1 3/4] lavfi/remap: remove unnecessary cast for void *

From: Jun Zhao Remove unnecessary cast for void * pointer. Signed-off-by: Jun Zhao --- libavfilter/vf_remap.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_remap.c b/libavfilter/vf_remap.c index b1c3e43..720020c 100644 --- a/libavfilter/vf_remap.c +

[FFmpeg-devel] [PATCH V1 4/4] lavfi/v360: remove unnecessary cast for void *

From: Jun Zhao Remove unnecessary cast for void * pointer. Signed-off-by: Jun Zhao --- libavfilter/vf_v360.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavfilter/vf_v360.c b/libavfilter/vf_v360.c index a28a03d..a0f3c52 100644 --- a/libavfilter/vf_v360.c +++ b/l

Re: [FFmpeg-devel] [PATCH V3] lavfi/hqdn3d: add slice thread optimization

On 10/9/19, Jun Zhao wrote: > From: Jun Zhao > > Enabled one thread per planar, used the test command for 1080P video > (YUV420P format) as follow: > > ffmpeg -i 1080p.mp4 -an -vf hqdn3d -f null /dev/nul > > This optimization improved the performance about 30% in 1080P YUV420P > case (from 110fps

Re: [FFmpeg-devel] [PATCH V1 1/4] lavfi/colorspace: typedef ThreadData as all other filters

Whole set looks fine to me. On 10/9/19, Jun Zhao wrote: > From: Jun Zhao > > typedef ThreadData as all other filters. > > Signed-off-by: Jun Zhao > --- > libavfilter/vf_colorspace.c |8 > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavfilter/vf_colorspace.c

Re: [FFmpeg-devel] [PATCH v1] avcodec/magicyuv: remove duplicate code

ok On 10/9/19, Limin Wang wrote: > > ping, I hope it makes sense to reduce the code size. > > On Tue, Sep 24, 2019 at 09:13:52AM +0800, lance.lmw...@gmail.com wrote: >> From: Limin Wang >> >> Signed-off-by: Limin Wang >> --- >> libavcodec/magicyuv.c | 30 ++ >> 1 fi

Re: [FFmpeg-devel] [PATCH 03/14] avutil/opt: print command flag too

On Wed, Oct 09, 2019 at 12:16:54PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavutil/opt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavutil/opt.c b/libavutil/opt.c > index 7c2649725f..5bc70f7ffc 100644 > --- a/libavutil/opt.c > +++ b/libavutil/opt.c > @

Re: [FFmpeg-devel] [PATCH 03/14] avutil/opt: print command flag too

On 10/9/19, Michael Niedermayer wrote: > On Wed, Oct 09, 2019 at 12:16:54PM +0200, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavutil/opt.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavutil/opt.c b/libavutil/opt.c >> index 7c2649725f..5bc70f7ffc 100644 >>

Re: [FFmpeg-devel] [PATCH 01/14] avutil/opt: add AV_OPT_FLAG_COMMAND_PARAM flag

On Wed, Oct 09, 2019 at 12:16:52PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavutil/opt.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavutil/opt.h b/libavutil/opt.h > index 39f4a8dda0..693a170bcc 100644 > --- a/libavutil/opt.h > +++ b/libavutil/opt.h > @

Re: [FFmpeg-devel] [PATCH 02/14] avfilter/avfilter: add ff_filter_process_command()

On Wed, Oct 09, 2019 at 12:16:53PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/avfilter.c | 13 + > libavfilter/internal.h | 7 +++ > 2 files changed, 20 insertions(+) > > diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c > index 93e86

Re: [FFmpeg-devel] [PATCH 04/14] avfilter/af_anlms: switch to ff_filter_process_command()

On Wed, Oct 09, 2019 at 12:16:55PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/af_anlms.c | 27 ++- > 1 file changed, 6 insertions(+), 21 deletions(-) LGTM if it works (i didnt test) Thanks [...] -- Michael GnuPG fingerprint: 9FF212

Re: [FFmpeg-devel] [PATCH 05/14] avfilter/vf_gblur: switch to ff_filter_process_command()

On Wed, Oct 09, 2019 at 12:16:56PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_gblur.c | 20 ++-- > 1 file changed, 2 insertions(+), 18 deletions(-) LGTM if tested thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC7870

Re: [FFmpeg-devel] [PATCH 06/14] avfilter/vf_avgblur: switch to ff_filter_process_command()

On Wed, Oct 09, 2019 at 12:16:57PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_avgblur.c | 20 ++-- > 1 file changed, 2 insertions(+), 18 deletions(-) LGTM if tested [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B

Re: [FFmpeg-devel] [PATCH 07/14] avfilter/af_anlmdn: switch to ff_filter_process_command()

On Wed, Oct 09, 2019 at 12:16:58PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/af_anlmdn.c | 36 +++- > 1 file changed, 7 insertions(+), 29 deletions(-) LGTM if tested thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF673

Re: [FFmpeg-devel] [PATCH 08/14] avfilter/vf_scroll: add support for commands

On Wed, Oct 09, 2019 at 12:16:59PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_scroll.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) LGTM if tested thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I

Re: [FFmpeg-devel] [PATCH 09/14] avfilter/vf_amplify: add support for commands

On Wed, Oct 09, 2019 at 12:17:00PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_amplify.c | 14 -- > 1 file changed, 8 insertions(+), 6 deletions(-) [...] > @@ -311,4 +312,5 @@ AVFilter ff_vf_amplify = { > .init = init, > .uninit

Re: [FFmpeg-devel] [PATCH 09/14] avfilter/vf_amplify: add support for commands

On 10/9/19, Michael Niedermayer wrote: > On Wed, Oct 09, 2019 at 12:17:00PM +0200, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavfilter/vf_amplify.c | 14 -- >> 1 file changed, 8 insertions(+), 6 deletions(-) > [...] >> @@ -311,4 +312,5 @@ AVFilter ff_vf_amplify =

Re: [FFmpeg-devel] [PATCH 01/14] avutil/opt: add AV_OPT_FLAG_COMMAND_PARAM flag

On 10/9/19, Michael Niedermayer wrote: > On Wed, Oct 09, 2019 at 12:16:52PM +0200, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavutil/opt.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavutil/opt.h b/libavutil/opt.h >> index 39f4a8dda0..693a170bcc 100644 >>

[FFmpeg-devel] [PATCH] avcodec/tiff: add support for 16-bit YCbCr images and correct processing of border pixels

Added support for 16-bit per sample YUV formats. This would allow ffmpeg to losslessly save (later) and load subsampled 10/16-bit YUV frames in simple and somewhat standard format. Corrected handling of border pixels when unpacking YUV. Example for 8-bit (bottom line): https://github.com/BitMi

Re: [FFmpeg-devel] [PATCH 14/14] avfilter/af_atempo: use ff_filter_process_command()

On Wed, Oct 9, 2019 at 4:19 AM Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol > --- > libavfilter/af_atempo.c | 25 - > 1 file changed, 8 insertions(+), 17 deletions(-) > > diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c > index 688dac5464..39b500ba95

  1   2   >