Re: [FFmpeg-devel] [PATCH] avcodec/tiff: correct the default value of YCbCrSubsampling

Am Di., 24. Sept. 2019 um 20:32 Uhr schrieb Skakov Pavel : > TIFF decoder uses wrong default YCbCrSubsampling value so it breaks > on files that rely on standard default and omit the value. Patch applied. Thank you, Carl Eugen ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH v1 1/2] lavu/pixfmt: add new pixel format a2r10g10b10/a2b10g10r10

Am Mi., 25. Sept. 2019 um 04:46 Uhr schrieb Xinpeng Sun : > Add two 10 bit RGBA pixel format for hardware color space > conversion support in VAAPI and QSV: > > 2:10:10:10 10 bit: A2R10G10B10 > 2:10:10:10 10 bit: A2B10G10R10 Without more explanation, this patch is not ok. Carl Eugen

[FFmpeg-devel] [PATCH]lavf/avio: Print https warning also for avio_find_protocol_name()

Hi! Attached patch helps users fixing ticket #8197. Please comment, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg

[FFmpeg-devel] [PATCH 1/4] avformat/shortendec: Check k in probe

Fixes: Assertion failure Fixes: 17640/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5708767475269632 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/shortendec.c | 8 +++- 1 file c

[FFmpeg-devel] [PATCH 3/4] avcodec/sbcdec: Initilaize nubmer of channels

Fixes: out of array access Fixes: 17609/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SBC_fuzzer-5758729319874560 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/sbcdec.c | 1 + 1 file cha

[FFmpeg-devel] [PATCH 2/4] avcodec/cavsdec: Check remaining bitstream in the main loop in decode_pic()

Fixes: Timeout (149sec ->1sec) Fixes: 17311/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CAVS_fuzzer-5679368642232320 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cavsdec.c | 14 ++

[FFmpeg-devel] [PATCH 4/4] avcodec/g729_parser: Check block_size

Fixes: Infinite loop Fixes: 17611/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ACELP_KELVIN_fuzzer-5765134928052224 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/g729_parser.c | 6 +

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/g729_parser: Check block_size

lgtm On 9/25/19, Michael Niedermayer wrote: > Fixes: Infinite loop > Fixes: > 17611/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ACELP_KELVIN_fuzzer-5765134928052224 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Mic

Re: [FFmpeg-devel] [PATCH 01/13] avformat/mux: Move packet references

Andreas Rheinhardt: > Andreas Rheinhardt: >> In the common case that the input packet was already refcounted, >> ff_interleave_add_packet would allocate a new AVPacketList, use >> av_packet_ref to create a new reference to the buffer for the >> AVPacketList's packet, interleave the packet and final

Re: [FFmpeg-devel] [PATCH]lavf/avio: Print https warning also for avio_find_protocol_name()

Am Mi., 25. Sept. 2019 um 11:35 Uhr schrieb Carl Eugen Hoyos : > > Hi! > > Attached patch helps users fixing ticket #8197. > > Please comment, Carl Eugen From 92a62e4f56f4820d79529060636e0382b33b376b Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 25 Sep 2019 11:32:57 +0200 Subject: [PA

Re: [FFmpeg-devel] [PATCH 3/5] avcodec: add max_samples

On Tue, Sep 03, 2019 at 07:52:35PM +0200, Nicolas George wrote: > James Almer (12019-09-03): > > I prefer a separate field. If the existing field was called in a more > > ambiguous way I'd be ok with reusing it, but not like this. > > Same for me. ok, will apply thanks [...] -- Michael Gn

Re: [FFmpeg-devel] [PATCH 4/5] tools/target_dec_fuzzer: Set max_samples

On Tue, Sep 03, 2019 at 02:14:25AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > tools/target_dec_fuzzer.c | 4 > 1 file changed, 4 insertions(+) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting code th

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/apedec: Check max_samples

On Tue, Sep 03, 2019 at 02:39:27PM -0300, James Almer wrote: > On 9/3/2019 8:13 AM, Michael Niedermayer wrote: > > On Mon, Sep 02, 2019 at 09:40:47PM -0300, James Almer wrote: > >> On 9/2/2019 9:14 PM, Michael Niedermayer wrote: > >>> Fixes: OOM > >>> Fixes: > >>> 16627/clusterfuzz-testcase-minimi

[FFmpeg-devel] [PATCH] avcodec/qtrleenc: fix undefined behaviour

Fixes #7991. Signed-off-by: Paul B Mahol --- libavcodec/qtrleenc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/qtrleenc.c b/libavcodec/qtrleenc.c index cdd864bf82..6669c1302f 100644 --- a/libavcodec/qtrleenc.c +++ b/libavcodec/qtrleenc.c @@ -259,9 +259,1

Re: [FFmpeg-devel] [PATCH v4] doc/filters: add 4x4 layout example for xstack filter

Ok, the formatting is fine except for one. See below. On 25-09-2019 03:56 AM, lance.lmw...@gmail.com wrote: From: Limin Wang Reviewed-by: Gyan Signed-off-by: Limin Wang --- doc/filters.texi | 42 +- 1 file changed, 41 insertions(+), 1 deletion(-) d

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_stack: simplify main processing path

Signed-off-by: Paul B Mahol --- libavfilter/vf_stack.c | 93 ++ 1 file changed, 48 insertions(+), 45 deletions(-) diff --git a/libavfilter/vf_stack.c b/libavfilter/vf_stack.c index 4d254e0013..3b05807a95 100644 --- a/libavfilter/vf_stack.c +++ b/libavfilte

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_stack: add slice threading

Signed-off-by: Paul B Mahol --- libavfilter/vf_stack.c | 43 +++--- 1 file changed, 28 insertions(+), 15 deletions(-) diff --git a/libavfilter/vf_stack.c b/libavfilter/vf_stack.c index 3b05807a95..b9e87a4429 100644 --- a/libavfilter/vf_stack.c +++ b/libavfilte

[FFmpeg-devel] [PATCH] aformat/movenc: add missing padding to output track extradata

Fixes ticket #8183. Signed-off-by: James Almer --- libavformat/movenc.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index c824ff5ba1..e3283871d0 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -5

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/fitsdec: Prevent division by 0 with huge data_max

On Thu, Jul 18, 2019 at 08:21:21AM +0200, Reimar Döffinger wrote: > > > On 16.07.2019, at 20:31, Michael Niedermayer wrote: > > > On Tue, Jul 16, 2019 at 08:34:14AM +0200, Reimar Döffinger wrote: > >> On 16.07.2019, at 00:50, Michael Niedermayer > >> wrote: > >> > >>> Fixes: division by 0 >

[FFmpeg-devel] [PATCH] Adding a flag to give user the option to have ffmpeg fail instead of warn when mismatches are found in rtmp url stream or application names.

From: Will Martin Motivation: When running multiple rtmp ingest on the same machine on the same port, users may want to explicitly forbid mismatched rtmp streams from successfully completing handshakes. This patch allows for such enforcement Signed-off-by: Will Martin --- libavformat/librtmp.

[FFmpeg-devel] [PATCH 02/12] avcodec/dstdec: Fix integer overflow in samples_per_frame computation

Fixes: Timeout (? -> 2ms) Fixes: 17616/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DST_fuzzer-5198057947267072 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/dstdec.c | 2 +- 1 file cha

[FFmpeg-devel] [PATCH 01/12] avcodec/wmaprodec: get frame during frame decode

Fixes: memleak Fixes: 17615/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XMA2_fuzzer-5681306024804352 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/wmaprodec.c | 10 ++ 1 file c

[FFmpeg-devel] [PATCH 07/12] tools/target_dec_fuzzer: Print samples decoded like pixels

Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c index 6c670d8eb9..4af7b26e54 100644 --- a/tools/target_dec_fuzzer.c +++ b/tools/target_dec_fuzzer.c @@ -297,7

[FFmpeg-devel] [PATCH 03/12] avcodec/fitsdec: Prevent division by 0 with huge data_max

Fixes: division by 0 Fixes: 15657/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FITS_fuzzer-5738154838982656 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/fitsdec.c | 9 - 1 file

[FFmpeg-devel] [PATCH 08/12] avcodec/atrac3: Check block_align

Fixes: Infinite loop Fixes: 17620/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC3_fuzzer-5086123012915200 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/atrac3.c | 2 +- 1 file chang

[FFmpeg-devel] [PATCH 04/12] avcodec/hcom: Check that there are dictionary entries

Fixes: out of array read Fixes: 17617/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HCOM_fuzzer-5674970478280704 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/hcom.c | 3 ++- 1 file chan

[FFmpeg-devel] [PATCH 05/12] avcodec/alsdec: Avoid dereferencing context pointer in inner interleave loop

This makes the decoder faster Improves/Fixes: Timeout (22sec -> 20sec) Testcase: 17619/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5078510820917248 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niederm

[FFmpeg-devel] [PATCH 06/12] tools/target_dec_fuzzer: Check number of all samples decoded too, like max pixels

Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c index 0dc1854738..6c670d8eb9 100644 --- a/tools/target_dec_fuzzer.c +++ b/tools/target_dec_fuzzer.c @@ -94,6 +94,7 @@ c

[FFmpeg-devel] [PATCH 09/12] avcodec/pafvideo: Only clear frame when it was written to

This avoids unneeded operations and makes the code faster. Fixes: Timeout Fixes: 15724/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PAF_VIDEO_fuzzer-5750842205929472 (12sec -> 9sec) Fixes: 17625/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PAF_VIDEO_fuzzer-5640515311108096 (16sec ->

[FFmpeg-devel] [PATCH 12/12] avcodec/4xm: Check index in decode_i_block() also in the path where its not used.

Fixes: Infinite loop Fixes: signed integer overflow: 2147483644 + 16 cannot be represented in type 'int' Fixes: 16169/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FOURXM_fuzzer-5662570416963584 Fixes: 16782/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FOURXM_fuzzer-5743163859271680 Fix

[FFmpeg-devel] [PATCH 11/12] avcodec/loco: Check for end of input in the first line

Fixes: Timeout (85sec -> 0.1sec) Fixes: 17634/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LOCO_fuzzer-5666410809786368 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/loco.c | 2 ++ 1 fi

[FFmpeg-devel] [PATCH 10/12] tools/target_dec_fuzzer: Adjust threshold for MSZH

Fixes: Timeout (250sec -> 6sec) Fixes: 17627/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSZH_fuzzer-5643017129558016 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 +

Re: [FFmpeg-devel] [PATCH v3] avcodec/dnxhdenc: return error if av_malloc failed

On 9/23/2019 12:36 AM, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/dnxhdenc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c > index 41b8079a09..c82c5d5140 100644 > --- a/libavcodec/

Re: [FFmpeg-devel] [PATCH v4 3/9] avformat/utils: Move the reference to the packet list

On 9/20/2019 5:39 PM, Andreas Rheinhardt wrote: > Up until now, ff_packet_list_put had a flaw: When it moved a packet to > the list (meaning, when it ought to move the reference to the packet > list instead of creating a new one via av_packet_ref), it did not reset > the original packet, confusing

Re: [FFmpeg-devel] [PATCH] Adding a flag to give user the option to have ffmpeg fail instead of warn when mismatches are found in rtmp url stream or application names.

On 2019-09-25T20:57:08+0200, William Martin wrote: > +av_log(s, AV_LOG_ERROR, "App field don't match up: %s <-> %s. " Although I'm not a native English speaker, since "field" isn't plural, I'm pretty confident "don't" should be "doesn't". -- Reino ___

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: correct the default value of YCbCrSubsampling

On 9/25/2019 5:48 AM, Carl Eugen Hoyos wrote: > Am Di., 24. Sept. 2019 um 20:32 Uhr schrieb Skakov Pavel : > >> TIFF decoder uses wrong default YCbCrSubsampling value so it breaks >> on files that rely on standard default and omit the value. > > Patch applied. > > Thank you, Carl Eugen This pat

Re: [FFmpeg-devel] [PATCH v4 3/9] avformat/utils: Move the reference to the packet list

James Almer: > On 9/20/2019 5:39 PM, Andreas Rheinhardt wrote: >> Up until now, ff_packet_list_put had a flaw: When it moved a packet to >> the list (meaning, when it ought to move the reference to the packet >> list instead of creating a new one via av_packet_ref), it did not reset >> the original

Re: [FFmpeg-devel] [PATCH] Adding a flag to give user the option to have ffmpeg fail instead of warn when mismatches are found in rtmp url stream or application names.

Am Mi., 25. Sept. 2019 um 21:04 Uhr schrieb William Martin : > > From: Will Martin > > Motivation: When running multiple rtmp ingest on the same machine on the same > port, users may want to explicitly forbid mismatched rtmp streams from > successfully completing handshakes. This patch allows fo

Re: [FFmpeg-devel] [PATCH v4 3/9] avformat/utils: Move the reference to the packet list

On 9/25/2019 7:06 PM, Andreas Rheinhardt wrote: > James Almer: >> On 9/20/2019 5:39 PM, Andreas Rheinhardt wrote: >>> Up until now, ff_packet_list_put had a flaw: When it moved a packet to >>> the list (meaning, when it ought to move the reference to the packet >>> list instead of creating a new on

Re: [FFmpeg-devel] [PATCH 2/2] avformat/utils: Fix memleaks

On 9/24/2019 1:31 PM, Andreas Rheinhardt wrote: > ff_read_packet had potential memleaks: > 1. If av_packet_make_refcounted fails, it means that the packet is not > refcounted, but it could nevertheless carry side data and therefore > needs to be unreferenced. > 2. If putting a packet on a packet li

Re: [FFmpeg-devel] [PATCH v4 2/9] avformat/utils: unref packet on AVInputFormat.read_packet() failure

On 9/20/2019 5:39 PM, Andreas Rheinhardt wrote: > From: James Almer > > Demuxers may have allocated a packet before encountering an error and > aborting. > > Fixes ticket #8150 > > Signed-off-by: James Almer > --- > Earlier versions of this patchset used av_init_packet() together with > setti

Re: [FFmpeg-devel] [PATCH v4 3/9] avformat/utils: Move the reference to the packet list

On 9/20/2019 5:39 PM, Andreas Rheinhardt wrote: > Up until now, ff_packet_list_put had a flaw: When it moved a packet to > the list (meaning, when it ought to move the reference to the packet > list instead of creating a new one via av_packet_ref), it did not reset > the original packet, confusing

[FFmpeg-devel] [PATCH] avformat/utils: Move the reference to the packet list

Up until now, ff_packet_list_put had a flaw: When it moved a packet to the list (meaning, when it ought to move the reference to the packet list instead of creating a new one via av_packet_ref), it did not reset the original packet, confusing the ownership of the data in the packet. This has been d

Re: [FFmpeg-devel] [PATCH] avformat/utils: Move the reference to the packet list

On 9/25/2019 9:05 PM, Andreas Rheinhardt wrote: > Up until now, ff_packet_list_put had a flaw: When it moved a packet to > the list (meaning, when it ought to move the reference to the packet > list instead of creating a new one via av_packet_ref), it did not reset > the original packet, confusing

Re: [FFmpeg-devel] [PATCH]lavf/avio: Print https warning also for avio_find_protocol_name()

> 在 2019年9月25日，下午8:11，Carl Eugen Hoyos 写道： > > Am Mi., 25. Sept. 2019 um 11:35 Uhr schrieb Carl Eugen Hoyos > : >> >> Hi! >> >> Attached patch helps users fixing ticket #8197. LGTM >> >> Please comment, Carl Eugen Thanks Steven ___ ffmpeg-dev

[FFmpeg-devel] [PATCH v5] doc/filters: add 4x4 layout example for xstack filter

From: Limin Wang Reviewed-by: Gyan Signed-off-by: Limin Wang --- doc/filters.texi | 45 - 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index d0fdf957af..a53f572e10 100644 --- a/doc/filters.texi +++

Re: [FFmpeg-devel] [PATCH v4] doc/filters: add 4x4 layout example for xstack filter

On Wed, Sep 25, 2019 at 09:26:58PM +0530, Gyan wrote: > Ok, the formatting is fine except for one. See below. > > On 25-09-2019 03:56 AM, lance.lmw...@gmail.com wrote: > >From: Limin Wang > > > >Reviewed-by: Gyan > >Signed-off-by: Limin Wang > >--- > > doc/filters.texi | 42 +++

[FFmpeg-devel] [PATCH v5] doc/filters: add 4x4 layout example for xstack filter

From: Limin Wang Reviewed-by: Gyan Signed-off-by: Limin Wang --- doc/filters.texi | 45 - 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index d0fdf957af..a53f572e10 100644 --- a/doc/filters.texi +++