Re: [FFmpeg-devel] [PATCH 1/3] avcodec/adpcm: Check number of channels for MTAF

2019-09-24 Thread Paul B Mahol
lgtm On 9/24/19, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 17608/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_MTAF_fuzzer-5074936267276288 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

[FFmpeg-devel] [PATCH] lavc/vaapi_encode: remove consistency check of depth for each component

2019-09-24 Thread Linjie Fu
Previously, consistency check of depth is introduced to make sure each component of the pixel format has the same depth. Since Y410(with a different depth in alpha channel) is supported for ICL+, this check should be removed to make the encoder work. Signed-off-by: Linjie Fu --- libavcodec/vaap

[FFmpeg-devel] [PATCH v2 2/3] avfilter/vf_framerate: refine the filter_slice code for better readiablity

2019-09-24 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/framerate.h| 1 + libavfilter/vf_framerate.c | 35 +-- 2 files changed, 14 insertions(+), 22 deletions(-) diff --git a/libavfilter/framerate.h b/libavfilter/framerate.h index 8048dfa36a..3d8200b2fe

[FFmpeg-devel] [PATCH v2 3/3] avfilter/vf_framerate: remove duplicate code with macro-based function

2019-09-24 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/framerate.h| 3 +- libavfilter/vf_framerate.c | 58 +- 2 files changed, 27 insertions(+), 34 deletions(-) diff --git a/libavfilter/framerate.h b/libavfilter/framerate.h index 3d8200b2fe..887f173

[FFmpeg-devel] [PATCH v2 1/3] avfilter/vf_framerate: limit the scene level max range

2019-09-24 Thread lance . lmwang
From: Limin Wang Reviewed-by: Paul B Mahol Signed-off-by: Limin Wang --- libavfilter/vf_framerate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_framerate.c b/libavfilter/vf_framerate.c index 06e463e4d7..a5dad3c769 100644 --- a/libavfilter/vf_framerate.c +

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/adpcm: Check number of channels for MTAF

2019-09-24 Thread Michael Niedermayer
On Tue, Sep 24, 2019 at 09:17:49AM +0200, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Complexity theory is the science of finding the exact solution to an approximation. Benchmarking OTOH is finding an approximation

Re: [FFmpeg-devel] [PATCH] avcodec/truespeech: Eliminate some left shifts

2019-09-24 Thread Michael Niedermayer
On Sun, Sep 22, 2019 at 09:02:00AM +, Andreas Rheinhardt wrote: > Michael Niedermayer: > > This avoids some invalid shifts > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/truespeech.c | 7 +++ > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/lib

Re: [FFmpeg-devel] [PATCH v2 3/3] FATE: add fate test for minterpolate filter

2019-09-24 Thread Limin Wang
ping, please help to push it or comments. On Sun, Sep 15, 2019 at 07:05:35PM +0200, Michael Niedermayer wrote: > On Sat, Sep 14, 2019 at 11:37:31AM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > tests/fate/filter-video.mak |

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: support input path is a null pointer or empty string

2019-09-24 Thread Limin Wang
ping, please help to push the patchset. On Fri, Sep 20, 2019 at 10:53:38AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Linux and OSX systems support basename and dirname via , I plan to > make the wrapper interface conform to the standard interface first. > If it is feasible, I

Re: [FFmpeg-devel] [PATCH v1] doc/filters: add 4x4 layout example for xstack filter

2019-09-24 Thread Limin Wang
ping, although my testing is OK. On Thu, Sep 19, 2019 at 01:43:14PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > In additon, I have added details of each input position to help understand > how to write the layout parameters. > > Signed-off-by: Limin Wang > --- > doc/filters

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: support input path is a null pointer or empty string

2019-09-24 Thread Paul B Mahol
On 9/24/19, Limin Wang wrote: > > ping, please help to push the patchset. There are typos in patch. > > On Fri, Sep 20, 2019 at 10:53:38AM +0800, lance.lmw...@gmail.com wrote: >> From: Limin Wang >> >> Linux and OSX systems support basename and dirname via , I plan >> to >> make the wrapper int

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/dxv: Check op_offset in both directions

2019-09-24 Thread Michael Niedermayer
On Mon, Sep 23, 2019 at 11:09:28AM +0200, Paul B Mahol wrote: > Feel free to apply this patch as it does not break current files, but ok, will apply > I think check is incomplete. yes, more things need to be checked ill send another patch thx [...] -- Michael GnuPG fingerprint: 9FF2128B1

Re: [FFmpeg-devel] [PATCH v1] doc/filters: add 4x4 layout example for xstack filter

2019-09-24 Thread Gyan
On 24-09-2019 04:02 PM, Limin Wang wrote: ping, although my testing is OK. On Thu, Sep 19, 2019 at 01:43:14PM +0800, lance.lmw...@gmail.com wrote: From: Limin Wang In additon, I have added details of each input position to help understand how to write the layout parameters. Signed-off-by:

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: support input path is a null pointer or empty string

2019-09-24 Thread Limin Wang
On Tue, Sep 24, 2019 at 12:33:05PM +0200, Paul B Mahol wrote: > On 9/24/19, Limin Wang wrote: > > > > ping, please help to push the patchset. > > There are typos in patch. Sorry, I'm not native English and have no clue where it is, so please help point out where is it? I'll fix it or the commi

[FFmpeg-devel] [PATCH v2] doc/filters: add 4x4 layout example for xstack filter

2019-09-24 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/filters.texi | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index e41384aed8..9e76af36a3 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -19057,

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: support input path is a null pointer or empty string

2019-09-24 Thread Paul B Mahol
On 9/24/19, Limin Wang wrote: > On Tue, Sep 24, 2019 at 12:33:05PM +0200, Paul B Mahol wrote: >> On 9/24/19, Limin Wang wrote: >> > >> > ping, please help to push the patchset. >> >> There are typos in patch. > > Sorry, I'm not native English and have no clue where it is, > so please help point o

Re: [FFmpeg-devel] [PATCH v3] avutil/avstring: support input path is a null pointer or empty string

2019-09-24 Thread Limin Wang
On Tue, Sep 24, 2019 at 01:05:41PM +0200, Paul B Mahol wrote: > On 9/24/19, Limin Wang wrote: > > On Tue, Sep 24, 2019 at 12:33:05PM +0200, Paul B Mahol wrote: > >> On 9/24/19, Limin Wang wrote: > >> > > >> > ping, please help to push the patchset. > >> > >> There are typos in patch. > > > > Sorr

[FFmpeg-devel] [PATCH v4 3/4] avformat/hlsenc: replace with av_dirname to get the directory

2019-09-24 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/hlsenc.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index d663785e4a..753addcbde 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @

[FFmpeg-devel] [PATCH v4 1/4] avutil/avstring: support input path as a null pointer or empty string

2019-09-24 Thread lance . lmwang
From: Limin Wang Linux and OSX systems support basename and dirname via , I plan to make the wrapper interface conform to the standard interface first. If it is feasible, I will continue to modify it to call the system interface if there is already a system call interface. You can get more descr

[FFmpeg-devel] [PATCH v4 4/4] avformat/hlsenc: replace with av_freep for all av_free

2019-09-24 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/hlsenc.c | 64 ++-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 753addcbde..784a2b5ec0 100644 --- a/libavformat/hlsenc.c +++ b

[FFmpeg-devel] [PATCH v4 2/4] avformat/hlsenc: remove the unnecessary null pointer check

2019-09-24 Thread lance . lmwang
From: Limin Wang Reviewed-by: Liu Steven Signed-off-by: Limin Wang --- libavformat/hlsenc.c | 26 ++ 1 file changed, 2 insertions(+), 24 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 1f2bdfbe4d..d663785e4a 100644 --- a/libavformat/hlsenc.c

Re: [FFmpeg-devel] [PATCH v1] doc/filters: add 4x4 layout example for xstack filter

2019-09-24 Thread Limin Wang
On Tue, Sep 24, 2019 at 04:10:12PM +0530, Gyan wrote: > > > On 24-09-2019 04:02 PM, Limin Wang wrote: > >ping, although my testing is OK. > > > > > >On Thu, Sep 19, 2019 at 01:43:14PM +0800, lance.lmw...@gmail.com wrote: > >>From: Limin Wang > >> > >>In additon, I have added details of each inpu

[FFmpeg-devel] [PATCH v1] avfilter/vf_scenechangedetect: add filter to detect scene change

2019-09-24 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- I am not sure if a new filter should be added to detect scene changes. Now some filters f_select, vf_fieldmatch, vf_framerate, vf_minterpotate implement their own version of the scene change detection, I think this is not easy to maintain and it'

Re: [FFmpeg-devel] [PATCH v2] doc/filters: add 4x4 layout example for xstack filter

2019-09-24 Thread Gyan
On 24-09-2019 04:35 PM, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- doc/filters.texi | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index e41384aed8..9e76af36a3 100

[FFmpeg-devel] [PATCH 1/2] libavcodec/dxv: Remove redundant seek

2019-09-24 Thread Michael Niedermayer
This seeks to the position the previous call to dxv_decompress_opcodes() positioned us in case of success Signed-off-by: Michael Niedermayer --- libavcodec/dxv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/dxv.c b/libavcodec/dxv.c index 8d5e4b1c6c..3fb50e96d0 100644 --- a/libav

[FFmpeg-devel] [PATCH 2/2] avcodec/dxv: Subtract 12 earlier in dxv_decompress_cocg()

2019-09-24 Thread Michael Niedermayer
the data_start is after reading 12 bytes and if its subtracted at the very end the intermediate might overflow Signed-off-by: Michael Niedermayer --- libavcodec/dxv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dxv.c b/libavcodec/dxv.c index 3fb50e96d0..1486de7

[FFmpeg-devel] [PATCH v3] doc/filters: add 4x4 layout example for xstack filter

2019-09-24 Thread lance . lmwang
From: Limin Wang Reviewed-by: Gyan Signed-off-by: Limin Wang --- doc/filters.texi | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index e41384aed8..9e76af36a3 100644 --- a/doc/filters.texi +++ b/doc/filt

Re: [FFmpeg-devel] [PATCH 3/4] tools/target_dec_fuzzer: Adjust threshold for MSS2

2019-09-24 Thread Michael Niedermayer
On Sun, Sep 01, 2019 at 11:10:27PM +0200, Michael Niedermayer wrote: > The decoder is slow > > Fixes: Timeout (94sec -> 7sec) > Fixes: > 16417/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSS2_fuzzer-5711668050395136 > > Found-by: continuous fuzzing process > https://github.com/google/oss-

Re: [FFmpeg-devel] [PATCH 1/5] tools/target_dec_fuzzer: consider potential padding/edge in pixel threshold

2019-09-24 Thread Michael Niedermayer
On Wed, Sep 04, 2019 at 06:04:54PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (73sec ->30ms) > Fixes: > 16921/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5689384594046976 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/ffwavesynth: Fix integer overflow in timestamps

2019-09-24 Thread Michael Niedermayer
On Sat, Sep 21, 2019 at 03:47:00PM +0200, Nicolas George wrote: > Michael Niedermayer (12019-09-06): > > Fixes: signed integer overflow: 9223371075321077760 * 2 cannot be > > represented in type 'long' > > Fixes: > > 16447/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-56989

Re: [FFmpeg-devel] [PATCH 2/2] avformat/utils: Do not assume duration is non negative in compute_pkt_fields()

2019-09-24 Thread Michael Niedermayer
On Fri, Sep 06, 2019 at 01:03:05AM +0200, Michael Niedermayer wrote: > Several subtitle demuxers set negative durations > > Fixes: signed integer overflow: 9223372036854775807 - -1 cannot be > represented in type 'long' > Fixes: > 16925/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-576651

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/alac: fix undefined behavior with INT_MIN in lpc_prediction()

2019-09-24 Thread Michael Niedermayer
On Fri, Sep 06, 2019 at 12:47:44PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -2147483648 * -1 cannot be represented in > type 'int' > Fixes: > 16786/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5632818851348480 > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/utils: Use av_memcpy_backptr() in ff_color_frame()

2019-09-24 Thread Michael Niedermayer
On Sun, Sep 08, 2019 at 11:34:16PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (191sec -> 53sec) > Fixes: > 16908/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5711207859748864 > Fixes: > 10709/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5630617975259136 >

Re: [FFmpeg-devel] [PATCH v2] avformat/rtpdec_rfc4175: support non-zero based line numbers

2019-09-24 Thread Kah Goh
On Wed, Sep 11, 2019 at 08:28:09PM +0200, Michael Niedermayer wrote: > On Wed, Aug 28, 2019 at 11:12:51PM +0800, Kah Goh wrote: > > There are differing standards that define different starting line > > numbers. For example, VSF TR-03 says the line numbers starts at 1, > > whereas SMPTE 2110-20 says

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs_h264: Automatically free SEI payload on error

2019-09-24 Thread Mark Thompson
On 11/09/2019 23:18, Andreas Rheinhardt wrote: > If adding an SEI message to an access unit fails, said SEI message was > not touched, so that the caller had to free any data associated with it > that might need to be freed. But given that ff_cbs_h264_add_sei_message > can simply call cbs_h264_free

Re: [FFmpeg-devel] [PATCH v3] doc/filters: add 4x4 layout example for xstack filter

2019-09-24 Thread Gyan
On 24-09-2019 06:20 PM, lance.lmw...@gmail.com wrote: From: Limin Wang Reviewed-by: Gyan Signed-off-by: Limin Wang --- doc/filters.texi | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index e41384a

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/h264_metadata: Add feature to repeat x264 SEI

2019-09-24 Thread Mark Thompson
On 11/09/2019 23:18, Andreas Rheinhardt wrote: > x264 adds a user data unregistered SEI containing its version number and > encoding parameters to the first access unit. This SEI is mostly > informative, but it can also be used by a decoder (like FFmpeg's H.264 > decoder) to decide whether to use w

[FFmpeg-devel] [PATCH 1/2] avformat/utils: Assert that stream_index is valid

2019-09-24 Thread Andreas Rheinhardt
There is currently an ordinary check for this (which would lead to a memleak), but given that no demuxer should ever return a packet with an invalid stream_index it is more appropriate for this to be an assert. FATE passes with this change. Signed-off-by: Andreas Rheinhardt --- libavformat/util

[FFmpeg-devel] [PATCH 2/2] avformat/utils: Fix memleaks

2019-09-24 Thread Andreas Rheinhardt
ff_read_packet had potential memleaks: 1. If av_packet_make_refcounted fails, it means that the packet is not refcounted, but it could nevertheless carry side data and therefore needs to be unreferenced. 2. If putting a packet on a packet list fails, it wasn't unreferenced. Furthermore, read_frame

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: Assert that stream_index is valid

2019-09-24 Thread Gyan
On 24-09-2019 10:01 PM, Andreas Rheinhardt wrote: There is currently an ordinary check for this (which would lead to a memleak), but given that no demuxer should ever return a packet with an invalid stream_index it is more appropriate for this to be an assert. FATE passes with this change. Si

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: Assert that stream_index is valid

2019-09-24 Thread Marton Balint
On Tue, 24 Sep 2019, Gyan wrote: On 24-09-2019 10:01 PM, Andreas Rheinhardt wrote: There is currently an ordinary check for this (which would lead to a memleak), but given that no demuxer should ever return a packet with an invalid stream_index it is more appropriate for this to be an asser

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: Assert that stream_index is valid

2019-09-24 Thread Gyan
On 24-09-2019 11:38 PM, Marton Balint wrote: On Tue, 24 Sep 2019, Gyan wrote: On 24-09-2019 10:01 PM, Andreas Rheinhardt wrote: There is currently an ordinary check for this (which would lead to a memleak), but given that no demuxer should ever return a packet with an invalid stream_inde

[FFmpeg-devel] [PATCH] avcodec/tiff: correct the default value of YCbCrSubsampling

2019-09-24 Thread Skakov Pavel
TIFF decoder uses wrong default YCbCrSubsampling value so it breaks on files that rely on standard default and omit the value. From 1b638417034ec212de4675db8e1695d1e5469d1d Mon Sep 17 00:00:00 2001 From: Pavel Skakov Date: Tue, 24 Sep 2019 20:30:59 +0300 Subject: [PATCH] avcodec/tiff: correct th

Re: [FFmpeg-devel] [PATCH V2] lavf/4xm: fix memory leak in error handing path

2019-09-24 Thread Michael Niedermayer
On Tue, Sep 24, 2019 at 12:39:24AM +0800, Jun Zhao wrote: > From: Jun Zhao > > need to free the header in error path. > > Signed-off-by: Jun Zhao > --- > libavformat/4xm.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF21

[FFmpeg-devel] [PATCH 00/15] Fix undefined behaviour II

2019-09-24 Thread Andreas Rheinhardt
Here is another batch of fixes for undefined behaviour found via running FATE through UBSan.* Most of the issues found are invalid left shifts of negative numbers and so are my patches. I have only fixed issues where I was sure that no overflow can happen in the multiplication that replaced a left

[FFmpeg-devel] [PATCH 01/15] avutil/common: Add macro for left-shifting

2019-09-24 Thread Andreas Rheinhardt
Left shifting a negative integer is undefined, yet often needed. Therefore add a macro that internally uses multiplication by powers of two to make it clear that a shift is intended. Signed-off-by: Andreas Rheinhardt --- I don't insist on this macro. I only added it so that one can easily see tha

[FFmpeg-devel] [PATCH 02/15] avcodec/truespeech: Fix invalid shift

2019-09-24 Thread Andreas Rheinhardt
Fixes the last undefined behaviour in the truespeech FATE-test as well as the last of the truespeech bugs reported in ticket #8159. The other left shifts of negative numbers have already been fixed in c7c0229b. Signed-off-by: Andreas Rheinhardt --- libavcodec/truespeech.c | 2 +- 1 file changed,

[FFmpeg-devel] [PATCH 09/15] avcodec/ffv1enc: Fix out-of-bounds-array access

2019-09-24 Thread Andreas Rheinhardt
libavcodec/ffv1enc.c accessed an array of uint8_t [32] via array[0][j] in order to loop over all the uint8_t in this array of arrays. Of course this implied an out-of-bounds access for array[0] and UBSan complained about this. So perform the access via an ordinary pointer to uint8_t. This affected

[FFmpeg-devel] [PATCH 03/15] avfilter/vf_xbr: Fix left shift of negative number

2019-09-24 Thread Andreas Rheinhardt
Affected every usage of vf_xbr, e.g. the FATE-tests filter-2xbr, filter-3xbr, filter-4xbr. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_xbr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_xbr.c b/libavfilter/vf_xbr.c index 2c71871d22..a854fb0c8c 10064

[FFmpeg-devel] [PATCH 04/15] avfilter/hqx: Fix undefined left shifts of negative numbers

2019-09-24 Thread Andreas Rheinhardt
Affected every usage of this filter; in particular, it affected the FATE-tests filter-2xbr, filter-3xbr and filter-4xbr. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_hqx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_hqx.c b/libavfilter/vf_hqx.c inde

[FFmpeg-devel] [PATCH 05/15] swscale/x86/swscale: Fix undefined left shifts of negative numbers

2019-09-24 Thread Andreas Rheinhardt
This affected many FATE-tests: The number of failing tests went down from 663 to 344. (Both numbers exclude tests that failed because of unaligned accesses in code that is inside #if HAVE_FAST_UNALIGNED.) Signed-off-by: Andreas Rheinhardt --- libswscale/x86/swscale.c | 4 ++-- 1 file changed, 2

[FFmpeg-devel] [PATCH 06/15] avcodec/adpcm: Fix undefined left shifts of negative numbers

2019-09-24 Thread Andreas Rheinhardt
Affected the adpcm-afc, adpcm-dtk, adpcm-ea-1, adpcm-ea-2, adpcm-ima-oki, adpcm-ea-maxis-xa, adpcm-ea-r1, adpcm-ea-r2, adpcm-ea-r3 and adpcm-thp FATE-tests. Signed-off-by: Andreas Rheinhardt --- libavcodec/adpcm.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff

[FFmpeg-devel] [PATCH 12/15] avcodec/exr: Fix undefined left shifts of negative numbers

2019-09-24 Thread Andreas Rheinhardt
Affected the FATE-tests exr-rgb-scanline-pxr24-half-uint32-13x9 and exr-rgb-scanline-pxr24-uint32. Signed-off-by: Andreas Rheinhardt --- libavcodec/exr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index c12469cc28..28e636add3 100644 --

[FFmpeg-devel] [PATCH 10/15] swscale/utils: Fix invalid left shifts of negative numbers

2019-09-24 Thread Andreas Rheinhardt
Affected the FATE-tests vsynth_lena-dv-411, vsynth1-dv-411, vsynth2-dv-411 and hevc-paramchange-yuv420p.yuv420p10. Signed-off-by: Andreas Rheinhardt --- libswscale/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/utils.c b/libswscale/utils.c index 1b1f779532

[FFmpeg-devel] [PATCH 07/15] avcodec/cavsdsp: Fix undefined left shifts of negative numbers

2019-09-24 Thread Andreas Rheinhardt
Affected the ffmpeg-filter_colorkey FATE-test (but only if the C version of idct8_add is used and not e.g. the x86 SSE2 version). Signed-off-by: Andreas Rheinhardt --- The FFLSHIFT macro isn't used here, because the coefficients here look like weights, so that bit-shifting is actually not intende

[FFmpeg-devel] [PATCH 08/15] avcodec/ffv1enc: Factor check out of a loop

2019-09-24 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/ffv1enc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index 796d81f7c6..1bf9663053 100644 --- a/libavcodec/ffv1enc.c +++ b/libavcodec/ffv1enc.c @@ -428,9 +428,13 @@ stat

[FFmpeg-devel] [PATCH 11/15] avformat/webmdashenc: Don't pass NULL to memcmp

2019-09-24 Thread Andreas Rheinhardt
Affects the FATE-tests webm-dash-manifest-unaligned-video-streams, webm-dash-manifest and webm-dash-manifest-representations. Signed-off-by: Andreas Rheinhardt --- libavformat/webmdashenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/webmdashenc.c b/libavfor

[FFmpeg-devel] [PATCH 13/15] avcodec/vc1_pred: Fix undefined left shifts of negative numbers

2019-09-24 Thread Andreas Rheinhardt
Affects the FATE-tests vc1_sa10143, vc1_ilaced_twomv. Signed-off-by: Andreas Rheinhardt --- libavcodec/vc1_pred.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vc1_pred.c b/libavcodec/vc1_pred.c index e1ad0e1d7d..f714d7ce22 100644 --- a/libavcodec/vc1_pred.c

[FFmpeg-devel] [PATCH 14/15] avcodec/cinepakenc: Fix invalid shifts

2019-09-24 Thread Andreas Rheinhardt
Fixes: left shift of 1 by 31 places cannot be represented in type 'int'. Affected the FATE-tests vsynth1-cinepak, vsynth2-cinepak and vsynth_lena-cinepak. Signed-off-by: Andreas Rheinhardt --- libavcodec/cinepakenc.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a

[FFmpeg-devel] [PATCH 15/15] avcodec/dnxhdenc: Fix undefined left shifts of negative numbers

2019-09-24 Thread Andreas Rheinhardt
Affected 61 FATE-tests: 60 vsynth tests and lavf-mxf_opatom. Signed-off-by: Andreas Rheinhardt --- 239 failing tests left to go! libavcodec/dnxhdenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c index 41b8079a09..034bcfc

[FFmpeg-devel] [PATCH v4] doc/filters: add 4x4 layout example for xstack filter

2019-09-24 Thread lance . lmwang
From: Limin Wang Reviewed-by: Gyan Signed-off-by: Limin Wang --- doc/filters.texi | 42 +- 1 file changed, 41 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index e41384a..a8342c0 100644 --- a/doc/filters.texi +++ b/doc/fi

Re: [FFmpeg-devel] [PATCH V2] libavcodec/libx264 and libx265: add a flag to output ROI warnings only once.

2019-09-24 Thread Mark Thompson
On 23/09/2019 03:02, Guo, Yejun wrote: > Signed-off-by: Guo, Yejun > --- > libavcodec/libx264.c | 16 ++-- > libavcodec/libx265.c | 11 ++- > 2 files changed, 24 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c > index 86e3530..878828

Re: [FFmpeg-devel] [PATCH v3] doc/filters: add 4x4 layout example for xstack filter

2019-09-24 Thread Limin Wang
On Tue, Sep 24, 2019 at 09:22:13PM +0530, Gyan wrote: > > > On 24-09-2019 06:20 PM, lance.lmw...@gmail.com wrote: > >From: Limin Wang > > > >Reviewed-by: Gyan > >Signed-off-by: Limin Wang > >--- > > doc/filters.texi | 34 +- > > 1 file changed, 33 insertions(+)

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: correct the default value of YCbCrSubsampling

2019-09-24 Thread Carl Eugen Hoyos
Am Di., 24. Sept. 2019 um 20:32 Uhr schrieb Skakov Pavel : > TIFF decoder uses wrong default YCbCrSubsampling value so it breaks on > files that rely on standard default and omit the value. The patch seems to agree with the specification, can you provide a sample? https://www.awaresystems.be/imag

Re: [FFmpeg-devel] [PATCH 4/6] lavu/hwcontext_vaapi: add vaapi_format_map support for AYUV/Y210/Y410

2019-09-24 Thread Mark Thompson
On 24/09/2019 04:21, Fu, Linjie wrote: >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Mark Thompson >> Sent: Friday, September 13, 2019 07:48 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH 4/6] lavu/hwcontext_vaapi: add >> vaapi_format_map support for AYU

[FFmpeg-devel] [PATCH] Change libvpxenc default to crf=32.

2019-09-24 Thread Elliott Karpilovsky
Current default is 200kbps, which produces inconsistent results (too high for low-res, too low for hi-res). Use CRF instead, which will adapt. Affects VP9. Also have VP8 use a default bitrate of 256kbps. --- libavcodec/libvpxenc.c | 74 +++--- libavcodec/version

Re: [FFmpeg-devel] [PATCH 4/6] lavu/hwcontext_vaapi: add vaapi_format_map support for AYUV/Y210/Y410

2019-09-24 Thread Carl Eugen Hoyos
Am Mi., 25. Sept. 2019 um 00:45 Uhr schrieb Mark Thompson : > From what you've said so far, I get the impression that the alpha channel in > your AYUV and Y410 formats is not actually supported at all in the hardware > you have? (That is, there is no support for decoding video with an alpha > c

Re: [FFmpeg-devel] [PATCH 4/6] lavu/hwcontext_vaapi: add vaapi_format_map support for AYUV/Y210/Y410

2019-09-24 Thread Carl Eugen Hoyos
Am Do., 19. Sept. 2019 um 09:11 Uhr schrieb Fu, Linjie : > > 4:2:2: > > * 8-bit: YUYV or similar? > > Supported FourCC is YUY2, and supported decode format is YUYV422; Why is this not AV_PIX_FMT_YUYV422? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-

Re: [FFmpeg-devel] [PATCH V2 1/3] checkasm/vf_eq: add test for vf_eq

2019-09-24 Thread Song, Ruiling
> -Original Message- > From: ffmpeg-devel On Behalf Of Li, > Zhong > Sent: Tuesday, September 24, 2019 2:34 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH V2 1/3] checkasm/vf_eq: add test for > vf_eq > > > From: ffmpeg-devel On

Re: [FFmpeg-devel] [PATCH 4/6] lavu/hwcontext_vaapi: add vaapi_format_map support for AYUV/Y210/Y410

2019-09-24 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Carl Eugen Hoyos > Sent: Wednesday, September 25, 2019 07:33 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 4/6] lavu/hwcontext_vaapi: add > vaapi_format_map support for AYUV/

Re: [FFmpeg-devel] [PATCH 4/6] lavu/hwcontext_vaapi: add vaapi_format_map support for AYUV/Y210/Y410

2019-09-24 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Carl Eugen Hoyos > Sent: Wednesday, September 25, 2019 07:34 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 4/6] lavu/hwcontext_vaapi: add > vaapi_format_map support for AYUV/

Re: [FFmpeg-devel] [PATCH v4 2/2] avfilter: Add tonemap vaapi filter

2019-09-24 Thread Zachary Zhou
On 9/16/19 7:36 PM, Carl Eugen Hoyos wrote: Am Mi., 11. Sept. 2019 um 23:02 Uhr schrieb Carl Eugen Hoyos : Am Mi., 11. Sept. 2019 um 07:41 Uhr schrieb Zachary Zhou : It supports ICL platform. H2H (HDR to HDR): P010 -> A2R10G10B10 H2S (HDR to SDR): P010 -> ARGB +if (ctx->hdr_type == HDR_VAA

Re: [FFmpeg-devel] [PATCH v4 1/2] libavuitl: add A2R10G10B10 & A2B10G10R10

2019-09-24 Thread Zachary Zhou
On 9/16/19 7:37 PM, Carl Eugen Hoyos wrote: Am Mi., 11. Sept. 2019 um 07:40 Uhr schrieb Zachary Zhou : +AV_PIX_FMT_A2R10G10B10, ///< 10-bit Pixel RGB formats. +AV_PIX_FMT_A2B10G10R10, ///< 10-bit Pixel BGR formats. Without more explanation, this patch is not ok imo. Thank Carl for r

Re: [FFmpeg-devel] [PATCH v1] libavutil: add A2R10G10B10 & A2B10G10R10

2019-09-24 Thread Zachary Zhou
On 9/12/19 4:43 AM, Carl Eugen Hoyos wrote: Am Mi., 11. Sept. 2019 um 07:59 Uhr schrieb Zhou, Zachary : -Original Message- From: ffmpeg-devel On Behalf Of Carl Eugen Hoyos Sent: Wednesday, September 11, 2019 7:30 AM To: FFmpeg development discussions and patches Subject: Re: [FFmpe

[FFmpeg-devel] [PATCH v1 1/2] lavu/pixfmt: add new pixel format a2r10g10b10/a2b10g10r10

2019-09-24 Thread Xinpeng Sun
Add two 10 bit RGBA pixel format for hardware color space conversion support in VAAPI and QSV: 2:10:10:10 10 bit: A2R10G10B10 2:10:10:10 10 bit: A2B10G10R10 Add query support in fate. Signed-off-by: Xinpeng Sun --- libavutil/pixdesc.c | 26 ++ libavutil/pix

[FFmpeg-devel] [PATCH v1 2/2] lavu/hwcontext_vaapi: add vaapi_format_map support for A2R10G10B10/A2B10G10R10

2019-09-24 Thread Xinpeng Sun
Enalbe the color space convertions p010->a2r10g10b10/a2b10g10r10 in VAAPI. Signed-off-by: Xinpeng Sun --- libavutil/hwcontext_vaapi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c index cf117640f2..3aaa5ff0b5 100644 --- a/liba

Re: [FFmpeg-devel] [PATCH V2] lavf/4xm: fix memory leak in error handing path

2019-09-24 Thread myp...@gmail.com
On Wed, Sep 25, 2019 at 4:21 AM Michael Niedermayer wrote: > > On Tue, Sep 24, 2019 at 12:39:24AM +0800, Jun Zhao wrote: > > From: Jun Zhao > > > > need to free the header in error path. > > > > Signed-off-by: Jun Zhao > > --- > > libavformat/4xm.c |3 ++- > > 1 files changed, 2 insertions(

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: Assert that stream_index is valid

2019-09-24 Thread Gyan
On 24-09-2019 11:39 PM, Gyan wrote: On 24-09-2019 11:38 PM, Marton Balint wrote: On Tue, 24 Sep 2019, Gyan wrote: On 24-09-2019 10:01 PM, Andreas Rheinhardt wrote: There is currently an ordinary check for this (which would lead to a memleak), but given that no demuxer should ever retu