Re: [FFmpeg-devel] [PATCH] avformat/rmdec.c: fix left shift of negative value in rm_sync()

On Sun, Sep 15, 2019 at 12:22:39AM -0300, James Almer wrote: > Fixes ticket 8143. > > Signed-off-by: James Almer > --- > libavformat/rmdec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c > index c9abd38d33..ccdc38f98a 100644

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m_enc: check for V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME availability before using

> -Original Message- > From: Aman Gupta [mailto:a...@tmm1.net] On Behalf Of Aman Gupta > Sent: Saturday, September 14, 2019 7:31 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Guo, Yejun ; Aman Gupta > Subject: [PATCH] avcodec/v4l2_m2m_enc: check for > V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME availab

[FFmpeg-devel] [PATCH] avcodec/mips: simplified code in vp3dsp_idct_msa.c.

Use the macros of ADD8 to replace continuous addition operations. --- libavcodec/mips/vp3dsp_idct_msa.c | 80 - libavutil/mips/generic_macros_msa.h | 6 +++ 2 files changed, 22 insertions(+), 64 deletions(-) diff --git a/libavcodec/mips/vp3dsp_idct_msa.c b/

Re: [FFmpeg-devel] [PATCH 01/13] avformat/mux: Move packet references

Andreas Rheinhardt: > In the common case that the input packet was already refcounted, > ff_interleave_add_packet would allocate a new AVPacketList, use > av_packet_ref to create a new reference to the buffer for the > AVPacketList's packet, interleave the packet and finally unreference > the origi

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m_enc: check for V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME availability before using

On Sun, Sep 15, 2019 at 08:43:32AM +, Guo, Yejun wrote: > > > > -Original Message- > > From: Aman Gupta [mailto:a...@tmm1.net] On Behalf Of Aman Gupta > > Sent: Saturday, September 14, 2019 7:31 AM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Guo, Yejun ; Aman Gupta > > Subject: [PATCH] a

[FFmpeg-devel] [PATCH v2] avformat/rmdec.c: fix left shift of negative value in rm_sync()

Fixes ticket 8143. Signed-off-by: James Almer --- libavformat/rmdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c index c9abd38d33..e95cc9f858 100644 --- a/libavformat/rmdec.c +++ b/libavformat/rmdec.c @@ -724,8 +724,8 @@ stat

Re: [FFmpeg-devel] [PATCH v2] avformat/rmdec.c: fix left shift of negative value in rm_sync()

James Almer: > Fixes ticket 8143. > > Signed-off-by: James Almer > --- > libavformat/rmdec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c > index c9abd38d33..e95cc9f858 100644 > --- a/libavformat/rmdec.c > +++ b/libavform

Re: [FFmpeg-devel] [PATCH v2] avformat/rmdec.c: fix left shift of negative value in rm_sync()

On 9/15/2019 10:19 AM, Andreas Rheinhardt wrote: > James Almer: >> Fixes ticket 8143. >> >> Signed-off-by: James Almer >> --- >> libavformat/rmdec.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c >> index c9abd38d33..e95cc

[FFmpeg-devel] [PATCH] avcodec/allcodecs: make libdav1d the preferred AV1 decoder

It's considerably faster than libaom in most systems. Signed-off-by: James Almer --- libavcodec/allcodecs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c index 5130fca026..d5dfba1877 100644 --- a/libavcodec/allcodecs.c +++ b/l

[FFmpeg-devel] [PATCH] avfilter/x86/vf_360: add most of >8 depth asm

Signed-off-by: Paul B Mahol --- libavfilter/x86/vf_v360.asm| 67 ++ libavfilter/x86/vf_v360_init.c | 12 ++ 2 files changed, 79 insertions(+) diff --git a/libavfilter/x86/vf_v360.asm b/libavfilter/x86/vf_v360.asm index a0936eb6dc..5b241220d8 100644 --- a/l

Re: [FFmpeg-devel] [PATCH v2 3/3] FATE: add fate test for minterpolate filter

On Sat, Sep 14, 2019 at 11:37:31AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > tests/fate/filter-video.mak | 4 > tests/ref/fate/filter-minterpolate-down | 6 ++ > tests/ref/fate/filter-minterpolate-up | 15 +

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: Check for EOF in mov_read_meta()

On Sat, Aug 31, 2019 at 10:36:32AM -0300, James Almer wrote: > On 8/31/2019 5:47 AM, Michael Niedermayer wrote: > > On Fri, Aug 30, 2019 at 08:57:29PM -0300, James Almer wrote: > >> On 8/30/2019 8:25 PM, Michael Niedermayer wrote: > >>> Fixes: Timeout (195sec -> 2ms) > >>> Fixes: > >>> 16735/clust

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: Check for EOF in mov_read_meta()

On 9/15/2019 4:34 PM, Michael Niedermayer wrote: > On Sat, Aug 31, 2019 at 10:36:32AM -0300, James Almer wrote: >> On 8/31/2019 5:47 AM, Michael Niedermayer wrote: >>> On Fri, Aug 30, 2019 at 08:57:29PM -0300, James Almer wrote: On 8/30/2019 8:25 PM, Michael Niedermayer wrote: > Fixes: Tim

[FFmpeg-devel] [PATCH] avcodec/ttaenc: Fix undefined shift

ttaenc contained (1 << unary) - 1 as an argument for a function expecting an unsigned int. unary can be as big as 31 in this case. The type of the shift and the whole expression is int, because 1 fits into an integer, so that the behaviour is undefined if unary == 31 as the result of the shift can'

[FFmpeg-devel] [PATCH] Delete unused branch in libaomenc

--- libavcodec/libaomenc.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index 7f47707a09..0b369d50a7 100644 --- a/libavcodec/libaomenc.c +++ b/libavcodec/libaomenc.c @@ -572,15 +572,11 @@ static av_cold int aom_i

Re: [FFmpeg-devel] [PATCH v2] avutil/mips: refactor msa SLDI_Bn_0 and SLDI_Bn macros.

On Wed, Aug 07, 2019 at 10:49:19AM +0800, Shiyou Yin wrote: > LGTM. will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I do not agree with what you have to say, but I'll defend to the death your right to say it. -- Voltaire signature.asc Description: P

Re: [FFmpeg-devel] [PATCH 2/6] tools/target_dec_fuzzer: Adjust motionpixels threshold

On Sun, Aug 25, 2019 at 08:41:54PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (151sec -> 173ms) > Fixes: > 16053/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOTIONPIXELS_fuzzer-5647069169057792 > Fixes: > 16053/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOTIONPIXELS_fuzzer-51

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/utils: Free threads on init failure

On Tue, Aug 27, 2019 at 11:21:51PM +0200, Michael Niedermayer wrote: > Fixes: Multiple memleaks > Fixes: ffmpeg-memory-leak > > Found-by: Francis Provencher > Signed-off-by: Michael Niedermayer > --- > libavcodec/utils.c | 3 +++ > 1 file changed, 3 insertions(+) will apply [...] -- Michael

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/gdv: Replace assert() checking bitstream by if()

On Wed, Aug 28, 2019 at 11:17:19PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/gdv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "Nothing to

Re: [FFmpeg-devel] [PATCH 1/2] tools/target_dec_fuzzer: increase snows threshold

On Thu, Aug 29, 2019 at 09:46:31PM +0200, Michael Niedermayer wrote: > snow allows creating large output from tiny input, like other > wavelet codecs > > Fixes: Timeout (82sec -> 1.5sec) > Fixes: > 9520/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SNOW_fuzzer-6286612576075776 > > Found-by:

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/hevcdec: repeat character in skiped

On Wed, Aug 28, 2019 at 07:26:50PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/hevcdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply patchset [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB B

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cfhd: Check that cropped size is smaller than full

On Thu, Aug 29, 2019 at 09:04:58PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 57342 * 120830 cannot be represented in type > 'int' > Fixes: > 16426/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CFHD_fuzzer-5758744817827840 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/3] avformat/cdxl: Fix integer overflow in intermediate

On Sat, Aug 31, 2019 at 01:25:02AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 65535 * 65312 cannot be represented in type > 'int' > Fixes: > 16704/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6294115603447808 > > Found-by: continuous fuzzing process > https://gi

Re: [FFmpeg-devel] [PATCH 4/5] avformat/vividas: Remove align offset which is always masked off

On Sun, Sep 01, 2019 at 12:32:39AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/vividas.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many that

Re: [FFmpeg-devel] [PATCH 3/5] avformat/vividas: remove dead assignment

On Sun, Sep 01, 2019 at 12:32:38AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/vividas.c | 2 -- > 1 file changed, 2 deletions(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are too smart

[FFmpeg-devel] [PATCH] Change libvpx-vpx default to crf=32.

Current default is 200kbps, which produces inconsistent results (too high for low-res, too low for hi-res). Use CRF instead, which will adapt. Affects vp8/vp9. Also have VP8 use a default bitrate of 256kbps. --- libavcodec/libvpxenc.c | 74 +++--- 1 file changed

Re: [FFmpeg-devel] [PATCH] Change libvpx-vpx default to crf=32.

On Wed, Sep 4, 2019 at 9:53 AM James Zern wrote: > > Hi, > > On Wed, Aug 28, 2019 at 2:26 PM Elliott Karpilovsky > wrote: > > > > Current default is 200kbps, which produces inconsistent > > results (too high for low-res, too low for hi-res). Use > > CRF instead, which will adapt. Affects vp8/vp9.

[FFmpeg-devel] [PATCH v1 3/4] avformat/hlsenc: replace with av_dirname to get the directory

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/hlsenc.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index b5681a85c7..21fb9d7a1d 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @

[FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: replace with av_freep for all av_free

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/hlsenc.c | 64 ++-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 21fb9d7a1d..6dc92b786e 100644 --- a/libavformat/hlsenc.c +++ b

[FFmpeg-devel] [PATCH v1 1/4] avutil/avstring: support input path is a null pointer or empty string

From: Limin Wang Signed-off-by: Limin Wang --- libavutil/avstring.c | 12 libavutil/avstring.h | 13 + 2 files changed, 17 insertions(+), 8 deletions(-) diff --git a/libavutil/avstring.c b/libavutil/avstring.c index 4c068f5bc5..9fddd0c77b 100644 --- a/libavutil/avstrin

Re: [FFmpeg-devel] [PATCH v1 6/6] Add myself as v210enc, v210dec maintainer

Ping, please give comments, I have submit some patches for v210enc and v210dec and nobody give feedback except Michael Niedermayer. I'm request to be maintainer of them, Below is all of patches submited: https://patchwork.ffmpeg.org/project/ffmpeg/list/?submitter=669&state=&q=&archive=&delegate

Re: [FFmpeg-devel] [PATCH v4 1/2] libavuitl: add A2R10G10B10 & A2B10G10R10

> -Original Message- > From: Fu, Linjie > Sent: Wednesday, September 11, 2019 1:54 PM > To: FFmpeg development discussions and patches > Cc: Zhou, Zachary > Subject: RE: [FFmpeg-devel] [PATCH v4 1/2] libavuitl: add A2R10G10B10 & > A2B10G10R10 > > > -Original Message- > > From:

Re: [FFmpeg-devel] [PATCH v4 2/2] avfilter: Add tonemap vaapi filter

> -Original Message- > From: ffmpeg-devel On Behalf Of Moritz > Barsnick > Sent: Wednesday, September 11, 2019 3:56 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v4 2/2] avfilter: Add tonemap vaapi filter > > On Wed, Sep 11, 2019 at 13:39:56 +

[FFmpeg-devel] [PATCH v1 2/4] avformat/hlsenc: remove the unnecessary null pointer check

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/hlsenc.c | 31 ++- 1 file changed, 2 insertions(+), 29 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 1f2bdfbe4d..b5681a85c7 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/h

Re: [FFmpeg-devel] [PATCH v1 1/4] avutil/avstring: support input path is a null pointer or empty string

> 在 2019年9月16日，上午9:03，lance.lmw...@gmail.com 写道： > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavutil/avstring.c | 12 > libavutil/avstring.h | 13 + > 2 files changed, 17 insertions(+), 8 deletions(-) > > diff --git a/libavutil/avstring.c b/libavutil/a

Re: [FFmpeg-devel] [PATCH v1 6/6] Add myself as v210enc, v210dec maintainer

> 在 2019年8月29日，上午9:27，lance.lmw...@gmail.com 写道： > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 7f60ef0021..4110d38354 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -243,6

Re: [FFmpeg-devel] [PATCH v1 2/4] avformat/hlsenc: remove the unnecessary null pointer check

> 在 2019年9月16日，上午9:03，lance.lmw...@gmail.com 写道： > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/hlsenc.c | 31 ++- > 1 file changed, 2 insertions(+), 29 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 1f2bdf