Re: [FFmpeg-devel] [PATCH] Don't send teardown if rtsp_hd_out is null

2019-08-05 Thread Ross Nicholson
Wrong commit message/subject. Please ignore. Will send new patch shortly. On Sun, 4 Aug 2019 at 22:41, Ross Nicholson wrote: > Example stream that does not work: rtsp:// > 184.72.239.149/vod/mp4:BigBuckBunny_115k.mov > > Extending the condition allows the stream to be processed correctly. > > On

[FFmpeg-devel] [PATCH] libavformat/rtspdec: Don't send teardown if rtsp_hd_out is null

2019-08-05 Thread Ross Nicholson
From: phunkyfish --- libavformat/rtspdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index 32dff2319c..3a79d1b175 100644 --- a/libavformat/rtspdec.c +++ b/libavformat/rtspdec.c @@ -57,7 +57,7 @@ static int rtsp_read_close(AV

Re: [FFmpeg-devel] [PATCH] libavformat/rtspdec: Don't send teardown if rtsp_hd_out is null

2019-08-05 Thread Ross Nicholson
Example stream that does not work: rtsp:// 184.72.239.149/vod/mp4:BigBuckBunny_115k.mov Extending the condition allows the stream to be processed correctly. On Mon, 5 Aug 2019 at 08:17, Ross Nicholson wrote: > From: phunkyfish > > --- > libavformat/rtspdec.c | 2 +- > 1 file changed, 1 insert

Re: [FFmpeg-devel] [PATCHv2 1/4] avformat/mpegtsenc: fix incorrect PCR selection with multiple programs

2019-08-05 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Sunday, 4 de August de 2019 22:25, Marton Balint wrote: > On Sun, 4 Aug 2019, Andreas Håkon wrote: > > > Hi Marton, > > ‐‐‐ Original Message ‐‐‐ > > > > > v2: a video is stream is preferred if there are no programs, just like > > > before

[FFmpeg-devel] [PATCH v16 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-08-05 Thread Jing Sun
Signed-off-by: Zhengxu Huang Signed-off-by: Hassene Tmar Signed-off-by: Jun Zhao Signed-off-by: Jing Sun --- configure| 4 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/libsvt_hevc.c | 500 +++ lib

Re: [FFmpeg-devel] [PATCH v16 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-08-05 Thread Sun, Jing A
This update corrected the rc_mode assignment position. It should get assigned before the if(). 264a265,269 > +if (param->rateControlMode) { > +param->maxQpAllowed = avctx->qmax; > +param->minQpAllowed = avctx->qmin; > +} > + 277,281d281 < +if (param->rateControlMode) {

[FFmpeg-devel] [PATCH] avcodec: add msrle encoder

2019-08-05 Thread Paul B Mahol
Hi, Patch attached. 0001-avcodec-add-msrle-encoder.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ff

[FFmpeg-devel] [REQUEST] ffmpeg-security subscription

2019-08-05 Thread Paul B Mahol
Hi, I here hereby request from lead FFmpeg entity to give me subscription to ffmpeg-security mailing list. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/hnm4video: Optimize postprocess_current_frame()

2019-08-05 Thread Tomas Härdin
lör 2019-08-03 klockan 18:57 +0200 skrev Michael Niedermayer: > On Sat, Aug 03, 2019 at 04:07:22PM +0200, Tomas Härdin wrote: > > lör 2019-08-03 klockan 01:49 +0200 skrev Michael Niedermayer: > > > -uint32_t x, y, src_x, src_y; > > > +uint32_t x, y, src_y; > > > +int width = hnm->width;

Re: [FFmpeg-devel] [PATCH] compat/cuda: Change inclusion guards

2019-08-05 Thread Timo Rothenpieler
On 05/08/2019 03:09, Andreas Rheinhardt wrote: cuda_runtime.h as well as dynlink_loader.h used nonstandard inclusion guards with an AV_ prefix, although these files are not in an libav*/ path. So change the inclusion guards and adapt the ref file of the source fate test accordingly. Signed-off-b

Re: [FFmpeg-devel] [PATCH] avcodec: add msrle encoder

2019-08-05 Thread Tomas Härdin
mån 2019-08-05 klockan 10:39 +0200 skrev Paul B Mahol: > Hi, > > Patch attached. > +static av_cold int msrle_encode_init(AVCodecContext *avctx) > +{ > +MsrleEncContext *s = avctx->priv_data; > + > +if (av_image_check_size(avctx->width, avctx->height, 0, avctx) < 0) > +return AVERR

[FFmpeg-devel] [PATCH V2 1/2] lavf/showinfo: support mastering display sidedata

2019-08-05 Thread Jun Zhao
From: Jun Zhao support mastering display sidedata. Signed-off-by: Jun Zhao --- libavfilter/vf_showinfo.c | 30 ++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index f6f8f49..d5c444e 100644 --

[FFmpeg-devel] [PATCH V2 2/2] lavf/showinfo: use error level when get invalid sidedata

2019-08-05 Thread Jun Zhao
From: Jun Zhao Use error level when get invalid sidedata, and remove a unnecessary newline in error message. Signed-off-by: Jun Zhao --- libavfilter/vf_showinfo.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c

[FFmpeg-devel] [PATCH V2 0/2] Add Mastering Display support in showinfo

2019-08-05 Thread Jun Zhao
V2: - change the level from info to error when get invalid side data Jun Zhao (2): lavf/showinfo: support mastering display sidedata lavf/showinfo: use error level when get invalid sidedata libavfilter/vf_showinfo.c | 36 +--- 1 files changed, 33 insertions(

[FFmpeg-devel] [PATCH V1] examples/encode_video: only add sequence end code for mpeg1/2 video

2019-08-05 Thread Jun Zhao
From: Jun Zhao Only add sequence end code for mpeg1/mpeg2 video, or else use the encoder libx264 or libx265 in this sample, decoding the output file will get unknow NALU type error. Signed-off-by: Jun Zhao --- doc/examples/encode_video.c |3 ++- 1 files changed, 2 insertions(+), 1 deletion

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_scale: Ensure scaled video is divisible by n

2019-08-05 Thread Lars Kiesow
Hi everyone, this is now open for nearly a month with no more comments or change requests. Anything else I should do to get this merged? Best regards, Lars On Mon, 8 Jul 2019 17:43:40 +0200 Lars Kiesow wrote: > This patch adds a new option to the scale filter which ensures that > the output re

Re: [FFmpeg-devel] [PATCH] avcodec: add msrle encoder

2019-08-05 Thread Lynne
Aug 5, 2019, 9:39 AM by one...@gmail.com: > Hi, > > Patch attached. > > int run = FFMIN(255, copy); Just replace all FFMIN(255 with av_clip_uint8, should be faster, in theory, on some platforms. > +switch (s->pixel_size) {> +case 3:> + > bytestream2_put_le24(&s->pb

Re: [FFmpeg-devel] [PATCH] avcodec: add msrle encoder

2019-08-05 Thread Paul B Mahol
On Mon, Aug 5, 2019 at 2:05 PM Lynne wrote: > Aug 5, 2019, 9:39 AM by one...@gmail.com: > > > Hi, > > > > Patch attached. > > > > > int run = FFMIN(255, copy); > > Just replace all FFMIN(255 with av_clip_uint8, should be faster, in > theory, on some platforms. > > > > +switch (s->pixel_si

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_scale: Ensure scaled video is divisible by n

2019-08-05 Thread Paul B Mahol
On Mon, Aug 5, 2019 at 1:31 PM Lars Kiesow wrote: > Hi everyone, > this is now open for nearly a month with no more comments or change > requests. Anything else I should do to get this merged? > Best regards, > Yes, ping it more frequently, until its merged. Waiting for months will not help as p

[FFmpeg-devel] [RFC] How to become release maintainer

2019-08-05 Thread Paul B Mahol
Hi, Is there some official way how to become release maintainer? Expecially creating new releases once in a while. I'm not happy with current release management in FFmpeg. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/l

Re: [FFmpeg-devel] [RFC] How to become release maintainer

2019-08-05 Thread Gyan
On 05-08-2019 06:05 PM, Paul B Mahol wrote: Hi, Is there some official way how to become release maintainer? Expecially creating new releases once in a while. I'm not happy with current release management in FFmpeg. Yes, release intervals look to be erratic. What would help is a suggested s

Re: [FFmpeg-devel] [RFC] How to become release maintainer

2019-08-05 Thread James Almer
On 8/5/2019 10:13 AM, Gyan wrote: > > > On 05-08-2019 06:05 PM, Paul B Mahol wrote: >> Hi, >> >> Is there some official way how to become release maintainer? >> Expecially creating new releases once in a while. >> I'm not happy with current release management in FFmpeg. > > Yes, release interval

Re: [FFmpeg-devel] [RFC] How to become release maintainer

2019-08-05 Thread Reto Kromer
James Almer wrote: >>> master nb_commits % 1500 == 0. >And if you make the cut as strict as you suggest, you'll surely >get broken releases. I fully agree that such an orthodoxy would result in broken releases. Seen this from a user of releases perspective, a good compromise between availabilit

[FFmpeg-devel] [PATCH 1/7] x86inc: Fix VEX -> EVEX instruction conversion

2019-08-05 Thread James Darnley
From: Henrik Gramner There's an edge case that wasn't properly handled. --- libavutil/x86/x86inc.asm | 5 + 1 file changed, 5 insertions(+) diff --git a/libavutil/x86/x86inc.asm b/libavutil/x86/x86inc.asm index 5044ee86f0..bc370a6186 100644 --- a/libavutil/x86/x86inc.asm +++ b/libavutil/x86

[FFmpeg-devel] [PATCH 4/7] x86inc: Turn 'movsxd' into 'movifnidn' on x86-32

2019-08-05 Thread James Darnley
From: Henrik Gramner --- libavutil/x86/x86inc.asm | 4 1 file changed, 4 insertions(+) diff --git a/libavutil/x86/x86inc.asm b/libavutil/x86/x86inc.asm index 10b7711637..04dbb6b785 100644 --- a/libavutil/x86/x86inc.asm +++ b/libavutil/x86/x86inc.asm @@ -293,6 +293,10 @@ DECLARE_REG_TMP_SIZ

[FFmpeg-devel] [PATCH 5/7] x86inc: Make 'non-adjacent' default in the TAIL_CALL macro

2019-08-05 Thread James Darnley
From: Henrik Gramner --- libavutil/x86/x86inc.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/x86/x86inc.asm b/libavutil/x86/x86inc.asm index 04dbb6b785..af35fe1e4d 100644 --- a/libavutil/x86/x86inc.asm +++ b/libavutil/x86/x86inc.asm @@ -685,7 +685,7 @@ DECLARE_

Re: [FFmpeg-devel] [PATCH] libavcodec/iff: Use unsigned to avoid undefined behaviour

2019-08-05 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 6/7] x86inc: Improve warnings for use of unsupported instructions

2019-08-05 Thread James Darnley
From: Henrik Gramner Warn when the following are used without the appropriate cpuflag: * YMM and ZMM registers * 'pextrw' with a memory operand * GPR instruction set extensions --- libavutil/x86/x86inc.asm | 120 +++ 1 file changed, 83 insertions(+), 37 del

[FFmpeg-devel] [PATCH 0/7] Import some x264asm patches from x264

2019-08-05 Thread James Darnley
Here are a few easy-to-import patches from x264. These are all after x264 commit 4a158b00 "x86inc: Correctly set mmreg variables" which FFmpeg already has (commit eb5f063e7c). It does not include the following commits: * 82721eae "x86inc: Add x86-32 PIC support macros" * 101bd27d "x86inc: Support

[FFmpeg-devel] [PATCH 2/7] x86inc: Optimize VEX instruction encoding

2019-08-05 Thread James Darnley
From: Henrik Gramner Most VEX-encoded instructions require an additional byte to encode when src2 is a high register (e.g. x|ymm8..15). If the instruction is commutative we can swap src1 and src2 when doing so reduces the instruction length, e.g. vpaddw xmm0, xmm0, xmm8 -> vpaddw xmm0, xmm8,

[FFmpeg-devel] [PATCH 7/7] x86inc: Add support for GFNI instructions

2019-08-05 Thread James Darnley
From: Henrik Gramner --- libavutil/x86/x86inc.asm | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/libavutil/x86/x86inc.asm b/libavutil/x86/x86inc.asm index d1b4c982fc..8c8cc97e0c 100644 --- a/libavutil/x86/x86inc.asm +++ b/libavutil/x86/x86inc

[FFmpeg-devel] [PATCH 3/7] x86inc: Improve SAVE/LOAD_MM_PERMUTATION macros

2019-08-05 Thread James Darnley
From: Henrik Gramner Use register numbers instead of copying the full register names. This makes it possible to change register widths in the middle of a function and keep the mmreg permutations intact which can be useful for code that only needs larger vectors for parts of the function in combin

Re: [FFmpeg-devel] [RFC] How to become release maintainer

2019-08-05 Thread James Almer
On 8/5/2019 10:35 AM, Reto Kromer wrote: > James Almer wrote: > master nb_commits % 1500 == 0. > >> And if you make the cut as strict as you suggest, you'll surely >> get broken releases. > > I fully agree that such an orthodoxy would result in broken > releases. > > Seen this from a user

Re: [FFmpeg-devel] [RFC] How to become release maintainer

2019-08-05 Thread Gyan
On 05-08-2019 06:48 PM, James Almer wrote: On 8/5/2019 10:13 AM, Gyan wrote: On 05-08-2019 06:05 PM, Paul B Mahol wrote: Hi, Is there some official way how to become release maintainer? Expecially creating new releases once in a while. I'm not happy with current release management in FFmpeg

Re: [FFmpeg-devel] [PATCH] avcodec/dirac_parser: Fix overflow in dts

2019-08-05 Thread Paul B Mahol
lgtm On Sat, Aug 3, 2019 at 1:17 PM Michael Niedermayer wrote: > Fixes: signed integer overflow: -2147483648 - 1 cannot be represented in > type 'int' > Fixes: > 15568/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5634719611355136 > > Found-by: continuous fuzzing process > https

Re: [FFmpeg-devel] [RFC] How to become release maintainer

2019-08-05 Thread Michael Niedermayer
On Mon, Aug 05, 2019 at 10:47:56AM -0300, James Almer wrote: > On 8/5/2019 10:35 AM, Reto Kromer wrote: > > James Almer wrote: > > > master nb_commits % 1500 == 0. > > > >> And if you make the cut as strict as you suggest, you'll surely > >> get broken releases. > > > > I fully agree that s

Re: [FFmpeg-devel] [PATCH] lavu/tx: don't compile double precision transforms on CONFIG_SMALL

2019-08-05 Thread Paul B Mahol
On Fri, Aug 2, 2019 at 6:01 PM Lynne wrote: > They'll likely only be used in not so small filters, so for embedded users > it makes sense to not compile them in. > I think, CONFIG_SMALL should be removed. > > ___ > ffmpeg-devel mailing list > ffmpeg-

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/loco: Check for end of input in pixel decode

2019-08-05 Thread Paul B Mahol
lgtm On Sat, Aug 3, 2019 at 1:51 AM Michael Niedermayer wrote: > Fixes: Timeout (100sec -> 5sec) > Fixes: > 15509/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LOCO_fuzzer-5724297261219840 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmp

Re: [FFmpeg-devel] [PATCH] avcodec/dirac_parser: Fix overflow in dts

2019-08-05 Thread Michael Niedermayer
On Mon, Aug 05, 2019 at 04:57:49PM +0200, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No snowflake in an avalanche ever feels responsible. -- Voltaire signature.asc Description: PGP signature _

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/atrac9dec: Check grad_range[1] more tightly

2019-08-05 Thread Michael Niedermayer
On Sun, Aug 04, 2019 at 02:18:19AM +0200, Lynne wrote: > Aug 4, 2019, 12:16 AM by mich...@niedermayer.cc: > > > Alternatively the array could be made bigger but the extra values > > would not be read without other changes. > > > > Fixes: Out of array access > > Fixes: > > 15658/clusterfuzz-testca

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/mss1: check for overread and forward errors

2019-08-05 Thread Paul B Mahol
looks fine to me ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/atrac9dec: Replace impossible conditions by assert

2019-08-05 Thread Michael Niedermayer
On Sun, Aug 04, 2019 at 01:41:48AM +0200, Lynne wrote: > Aug 4, 2019, 12:16 AM by mich...@niedermayer.cc: > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/atrac9dec.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/libavcodec/atrac9dec.c b/libavcod

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/bink: Add many end of input checks

2019-08-05 Thread Michael Niedermayer
On Sun, Aug 04, 2019 at 01:16:06AM +0200, Michael Niedermayer wrote: > Fixes: Timeout (83sec -> 15sec) > Fixes: > 15595/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINK_fuzzer-5689153263501312 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/project

Re: [FFmpeg-devel] [PATCH 1/7] avformat/av1: add color config values to AV1SequenceParameters

2019-08-05 Thread Paul B Mahol
lgtm On Tue, Jul 30, 2019 at 10:22 PM James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/av1.c | 32 ++-- > 1 file changed, 18 insertions(+), 14 deletions(-) > > diff --git a/libavformat/av1.c b/libavformat/av1.c > index 5fde8df97e..bd23891d26 10064

Re: [FFmpeg-devel] [PATCH 01/13] avcodec/apedec: Do not partially clear data array

2019-08-05 Thread Michael Niedermayer
On Sun, Aug 04, 2019 at 06:44:04PM +0200, Michael Niedermayer wrote: > Fixes: Assertion failure and memleak > Fixes: > 15709/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5182435093905408 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/pro

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/loco: Check for end of input in pixel decode

2019-08-05 Thread Michael Niedermayer
On Mon, Aug 05, 2019 at 05:00:08PM +0200, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have often repented speaking, but never of holding my tongue. -- Xenocrates signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/mss1: check for overread and forward errors

2019-08-05 Thread Michael Niedermayer
On Mon, Aug 05, 2019 at 05:03:53PM +0200, Paul B Mahol wrote: > looks fine to me will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many that live deserve death. And some that die deserve life. Can you give it to them? Then do not be too eager to de

Re: [FFmpeg-devel] [PATCH] libavcodec/iff: Use unsigned to avoid undefined behaviour

2019-08-05 Thread Michael Niedermayer
On Mon, Aug 05, 2019 at 03:43:23PM +0200, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is dangerous to be right in matters on which the established authorities are wrong. -- Voltaire signature.asc Description: P

Re: [FFmpeg-devel] [RFC] How to become release maintainer

2019-08-05 Thread James Almer
On 8/5/2019 11:58 AM, Michael Niedermayer wrote: > On Mon, Aug 05, 2019 at 10:47:56AM -0300, James Almer wrote: >> On 8/5/2019 10:35 AM, Reto Kromer wrote: >>> James Almer wrote: >>> >> master nb_commits % 1500 == 0. >>> And if you make the cut as strict as you suggest, you'll surely

Re: [FFmpeg-devel] [PATCH v5] avfilter/avf_aphasemeter: Add out-of-phase and mono detection

2019-08-05 Thread Paul B Mahol
This should be applied with sdtbool.h include removed. On Mon, Jul 8, 2019 at 2:01 PM Romane Lafon wrote: > This patch extends aphasemeter to detect out of phase or mono sequences in > stereo streams, with its associated documentation. > ___ > ffmpeg-

Re: [FFmpeg-devel] [PATCH 05/13] avcodec/cbs_av1_syntax_template: Check ref_frame_idx before use

2019-08-05 Thread James Almer
On 8/4/2019 1:44 PM, Michael Niedermayer wrote: > Fixes: index -1 out of bounds for type 'AV1ReferenceFrameState [8]' > Fixes: > 16079/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5758807440883712 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/p

Re: [FFmpeg-devel] [RFC] samples.ffmpeg.org

2019-08-05 Thread Michael Niedermayer
On Mon, Aug 05, 2019 at 02:44:29AM +, Li, Zhong wrote: > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > > Of Michael Niedermayer > > Sent: Monday, August 5, 2019 3:45 AM > > To: FFmpeg development discussions and patches > > > > Subject: Re: [FFmpeg-devel] [RFC] samp

Re: [FFmpeg-devel] [RFC] samples.ffmpeg.org

2019-08-05 Thread Paul B Mahol
On Mon, Aug 5, 2019 at 5:21 PM Michael Niedermayer wrote: > On Mon, Aug 05, 2019 at 02:44:29AM +, Li, Zhong wrote: > > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > > > Of Michael Niedermayer > > > Sent: Monday, August 5, 2019 3:45 AM > > > To: FFmpeg development d

Re: [FFmpeg-devel] libavcodec: add timer bitstream filter [v2]

2019-08-05 Thread Moritz Barsnick
Hi Andreas, On Fri, Aug 02, 2019 at 13:03:03 +, Andreas Håkon wrote: While trying to figure out how to add features I'd like to see into this ;-), some remarks: > +Apply an offset to the PTS/DTS timestamps. > + > +@table @option > +@item offset > +The offset value to apply to the PTS/DTS tim

Re: [FFmpeg-devel] [PATCH] avformat/assenc: Don't truncate lines to 4095 characters

2019-08-05 Thread Paul B Mahol
Please send such patch. On Sun, Aug 4, 2019 at 5:41 PM Marton Balint wrote: > > > On Sun, 4 Aug 2019, Paul B Mahol wrote: > > > On Sun, Aug 4, 2019 at 2:58 PM Marton Balint wrote: > > > >> > >> > >> On Sun, 4 Aug 2019, Paul B Mahol wrote: > >> > >> > On Sun, Aug 4, 2019 at 12:54 PM Marton Balin

Re: [FFmpeg-devel] [PATCH 05/13] avcodec/cbs_av1_syntax_template: Check ref_frame_idx before use

2019-08-05 Thread Michael Niedermayer
On Mon, Aug 05, 2019 at 12:19:24PM -0300, James Almer wrote: > On 8/4/2019 1:44 PM, Michael Niedermayer wrote: > > Fixes: index -1 out of bounds for type 'AV1ReferenceFrameState [8]' > > Fixes: > > 16079/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5758807440883712 > > > > Found-by: conti

Re: [FFmpeg-devel] [PATCH 6/7] avformat/dashenc: add missing padding to the updated extradata

2019-08-05 Thread Paul B Mahol
On Fri, Aug 2, 2019 at 5:07 PM James Almer wrote: > On 8/2/2019 11:46 AM, Andreas Rheinhardt wrote: > > James Almer: > >> Signed-off-by: James Almer > >> --- > >> libavformat/dashenc.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/libavformat/dashenc.c b/li

Re: [FFmpeg-devel] [PATCH 6/7] avformat/dashenc: add missing padding to the updated extradata

2019-08-05 Thread James Almer
On 8/5/2019 12:42 PM, Paul B Mahol wrote: > On Fri, Aug 2, 2019 at 5:07 PM James Almer wrote: > >> On 8/2/2019 11:46 AM, Andreas Rheinhardt wrote: >>> James Almer: Signed-off-by: James Almer --- libavformat/dashenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) >>

Re: [FFmpeg-devel] [RFC] samples.ffmpeg.org

2019-08-05 Thread Michael Niedermayer
On Mon, Aug 05, 2019 at 05:24:31PM +0200, Paul B Mahol wrote: > On Mon, Aug 5, 2019 at 5:21 PM Michael Niedermayer > wrote: > > > On Mon, Aug 05, 2019 at 02:44:29AM +, Li, Zhong wrote: > > > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > > > > Of Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 6/7] avformat/dashenc: add missing padding to the updated extradata

2019-08-05 Thread Andreas Rheinhardt
Paul B Mahol: > On Fri, Aug 2, 2019 at 5:07 PM James Almer wrote: > >> On 8/2/2019 11:46 AM, Andreas Rheinhardt wrote: >>> James Almer: Signed-off-by: James Almer --- libavformat/dashenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfo

Re: [FFmpeg-devel] [RFC] samples.ffmpeg.org

2019-08-05 Thread Paul B Mahol
On Mon, Aug 5, 2019 at 5:45 PM Michael Niedermayer wrote: > On Mon, Aug 05, 2019 at 05:24:31PM +0200, Paul B Mahol wrote: > > On Mon, Aug 5, 2019 at 5:21 PM Michael Niedermayer > > > wrote: > > > > > On Mon, Aug 05, 2019 at 02:44:29AM +, Li, Zhong wrote: > > > > > From: ffmpeg-devel [mailto:

Re: [FFmpeg-devel] [PATCH v3] avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation

2019-08-05 Thread Michael Niedermayer
On Thu, Jun 27, 2019 at 06:06:22AM +, Jacob Siddall wrote: > The previous calculation code did not account for the fact that the > copy_offset for the start of the frame array is at index 0, yet the > scan line number from the rfc4175 RTP header starts at 1. > This caused 2 issues to appear: >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/sanm: Check extradata_size before allocations

2019-08-05 Thread Michael Niedermayer
On Tue, Jul 16, 2019 at 08:47:26PM +0200, Michael Niedermayer wrote: > On Tue, Jul 16, 2019 at 08:27:43AM +0200, Reimar Döffinger wrote: > > On 16.07.2019, at 00:50, Michael Niedermayer wrote: > > > > > Fixes: Leaks > > > Fixes: > > > 15349/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SANM_

Re: [FFmpeg-devel] [PATCH] avcodec/vqavideo: Set video size

2019-08-05 Thread Michael Niedermayer
On Fri, Jul 26, 2019 at 01:52:19AM +0200, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 15919/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VQA_fuzzer-5657368257363968 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmp

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/alsdec: Check for block_length <= 0 in read_var_block_data()

2019-08-05 Thread Michael Niedermayer
On Fri, Jul 26, 2019 at 06:26:06PM +0200, Michael Niedermayer wrote: > Fixes: left shift of negative value -1 > Fixes: > 15719/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5685731105701888 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/p

[FFmpeg-devel] [PATCH] doc/fate: Document how to request samples upload access

2019-08-05 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- doc/fate.texi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/fate.texi b/doc/fate.texi index 2be61d639c..e04fbfbe43 100644 --- a/doc/fate.texi +++ b/doc/fate.texi @@ -157,6 +157,9 @@ practice generally do not replace, remove or overwrite files a

Re: [FFmpeg-devel] [PATCH v3] avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation

2019-08-05 Thread Kieran Kunhya
On Mon, 5 Aug 2019 at 17:10, Michael Niedermayer wrote: > On Thu, Jun 27, 2019 at 06:06:22AM +, Jacob Siddall wrote: > > The previous calculation code did not account for the fact that the > > copy_offset for the start of the frame array is at index 0, yet the > > scan line number from the rf

Re: [FFmpeg-devel] libavcodec: add timer bitstream filter [v2]

2019-08-05 Thread Andreas Håkon
Hi Moritz, ‐‐‐ Original Message ‐‐‐ On Monday, 5 de August de 2019 17:31, Moritz Barsnick wrote: > Hi Andreas, > > While trying to figure out how to add features I'd like to see into > this ;-), some remarks: > > > +Apply an offset to the PTS/DTS timestamps. > > + > > +@table @option >

[FFmpeg-devel] [PATCH v3] avcodec/vaapi_encode_h264: add support for a/53 closed caption sei

2019-08-05 Thread Aman Gupta
From: Aman Gupta Signed-off-by: Aman Gupta --- libavcodec/vaapi_encode_h264.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c index f4965d8b09..280bd4752b 100644 --- a/libavcodec/v

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: fix PCR generation intervals

2019-08-05 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Sunday, 4 de August de 2019 22:30, Marton Balint wrote: > PCR generation was based on counting packets for both CBR and VBR streams. > Couting packets might have worked for CBR streams (when muxrate was specified) > but it only took into account th

Re: [FFmpeg-devel] [PATCH v3] avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation

2019-08-05 Thread Michael Niedermayer
On Mon, Aug 05, 2019 at 06:05:29PM +0100, Kieran Kunhya wrote: > On Mon, 5 Aug 2019 at 17:10, Michael Niedermayer > wrote: > > > On Thu, Jun 27, 2019 at 06:06:22AM +, Jacob Siddall wrote: > > > The previous calculation code did not account for the fact that the > > > copy_offset for the start

Re: [FFmpeg-devel] [RFC] samples.ffmpeg.org

2019-08-05 Thread Thilo Borgmann
Am 05.08.19 um 17:57 schrieb Paul B Mahol: > On Mon, Aug 5, 2019 at 5:45 PM Michael Niedermayer > wrote: > >> On Mon, Aug 05, 2019 at 05:24:31PM +0200, Paul B Mahol wrote: >>> On Mon, Aug 5, 2019 at 5:21 PM Michael Niedermayer >> >>> wrote: >>> On Mon, Aug 05, 2019 at 02:44:29AM +, Li,

[FFmpeg-devel] [PATCH] avfilter: add vr360 filter

2019-08-05 Thread Eugene Lyapustin
Signed-off-by: Eugene Lyapustin --- doc/filters.texi | 137 +++ libavfilter/Makefile |1 + libavfilter/allfilters.c |1 + libavfilter/vf_vr360.c | 1847 ++ 4 files changed, 1986 insertions(+) create mode 100644 libavfilter/vf_vr360.c di

Re: [FFmpeg-devel] [RFC] samples.ffmpeg.org

2019-08-05 Thread Michael Niedermayer
On Mon, Aug 05, 2019 at 05:57:47PM +0200, Paul B Mahol wrote: > On Mon, Aug 5, 2019 at 5:45 PM Michael Niedermayer > wrote: > > > On Mon, Aug 05, 2019 at 05:24:31PM +0200, Paul B Mahol wrote: > > > On Mon, Aug 5, 2019 at 5:21 PM Michael Niedermayer > > > > > wrote: > > > > > > > On Mon, Aug 05,

Re: [FFmpeg-devel] [PATCH] avfilter: add vr360 filter

2019-08-05 Thread Thilo Borgmann
Am 05.08.19 um 20:46 schrieb Eugene Lyapustin: > Signed-off-by: Eugene Lyapustin > --- > doc/filters.texi | 137 +++ > libavfilter/Makefile |1 + > libavfilter/allfilters.c |1 + > libavfilter/vf_vr360.c | 1847 ++ > +AVFilter ff_vf_vr36

Re: [FFmpeg-devel] [PATCH] avfilter: add vr360 filter

2019-08-05 Thread Paul B Mahol
On Mon, Aug 5, 2019 at 8:57 PM Thilo Borgmann wrote: > Am 05.08.19 um 20:46 schrieb Eugene Lyapustin: > > Signed-off-by: Eugene Lyapustin > > --- > > doc/filters.texi | 137 +++ > > libavfilter/Makefile |1 + > > libavfilter/allfilters.c |1 + > > libavfilter/vf_vr360.c |

Re: [FFmpeg-devel] [PATCH] avfilter: add vr360 filter

2019-08-05 Thread Thilo Borgmann
Am 05.08.19 um 21:00 schrieb Paul B Mahol: > On Mon, Aug 5, 2019 at 8:57 PM Thilo Borgmann > wrote: > >> Am 05.08.19 um 20:46 schrieb Eugene Lyapustin: >>> Signed-off-by: Eugene Lyapustin >>> --- >>> doc/filters.texi | 137 +++ >>> libavfilter/Makefile |1 + >>> libavfilter/all

Re: [FFmpeg-devel] [RFC] samples.ffmpeg.org

2019-08-05 Thread Paul B Mahol
On Mon, Aug 5, 2019 at 8:55 PM Michael Niedermayer wrote: > On Mon, Aug 05, 2019 at 05:57:47PM +0200, Paul B Mahol wrote: > > On Mon, Aug 5, 2019 at 5:45 PM Michael Niedermayer > > > wrote: > > > > > On Mon, Aug 05, 2019 at 05:24:31PM +0200, Paul B Mahol wrote: > > > > On Mon, Aug 5, 2019 at 5:2

Re: [FFmpeg-devel] [RFC] samples.ffmpeg.org

2019-08-05 Thread Michael Niedermayer
On Mon, Aug 05, 2019 at 08:48:03PM +0200, Thilo Borgmann wrote: > Am 05.08.19 um 17:57 schrieb Paul B Mahol: > > On Mon, Aug 5, 2019 at 5:45 PM Michael Niedermayer > > wrote: > > > >> On Mon, Aug 05, 2019 at 05:24:31PM +0200, Paul B Mahol wrote: > >>> On Mon, Aug 5, 2019 at 5:21 PM Michael Nieder

Re: [FFmpeg-devel] [PATCH] avfilter: add vr360 filter

2019-08-05 Thread Paul B Mahol
On Mon, Aug 5, 2019 at 9:01 PM Thilo Borgmann wrote: > Am 05.08.19 um 21:00 schrieb Paul B Mahol: > > On Mon, Aug 5, 2019 at 8:57 PM Thilo Borgmann > > wrote: > > > >> Am 05.08.19 um 20:46 schrieb Eugene Lyapustin: > >>> Signed-off-by: Eugene Lyapustin > >>> --- > >>> doc/filters.texi

Re: [FFmpeg-devel] [RFC] samples.ffmpeg.org

2019-08-05 Thread Thilo Borgmann
Am 05.08.19 um 21:02 schrieb Michael Niedermayer: > On Mon, Aug 05, 2019 at 08:48:03PM +0200, Thilo Borgmann wrote: >> Am 05.08.19 um 17:57 schrieb Paul B Mahol: >>> On Mon, Aug 5, 2019 at 5:45 PM Michael Niedermayer >>> wrote: >>> On Mon, Aug 05, 2019 at 05:24:31PM +0200, Paul B Mahol wrote:

Re: [FFmpeg-devel] [PATCH] avfilter: add vr360 filter

2019-08-05 Thread Thilo Borgmann
Am 05.08.19 um 21:07 schrieb Paul B Mahol: > On Mon, Aug 5, 2019 at 9:01 PM Thilo Borgmann > wrote: > >> Am 05.08.19 um 21:00 schrieb Paul B Mahol: >>> On Mon, Aug 5, 2019 at 8:57 PM Thilo Borgmann >>> wrote: >>> Am 05.08.19 um 20:46 schrieb Eugene Lyapustin: > Signed-off-by: Eugene Lya

Re: [FFmpeg-devel] [PATCH] avfilter: add vr360 filter

2019-08-05 Thread Paul B Mahol
On Mon, Aug 5, 2019 at 9:12 PM Thilo Borgmann wrote: > Am 05.08.19 um 21:07 schrieb Paul B Mahol: > > On Mon, Aug 5, 2019 at 9:01 PM Thilo Borgmann > > wrote: > > > >> Am 05.08.19 um 21:00 schrieb Paul B Mahol: > >>> On Mon, Aug 5, 2019 at 8:57 PM Thilo Borgmann > >>> wrote: > >>> > Am 05.

Re: [FFmpeg-devel] [PATCH] avfilter: add vr360 filter

2019-08-05 Thread Thilo Borgmann
Am 05.08.19 um 21:16 schrieb Paul B Mahol: > On Mon, Aug 5, 2019 at 9:12 PM Thilo Borgmann > wrote: > >> Am 05.08.19 um 21:07 schrieb Paul B Mahol: >>> On Mon, Aug 5, 2019 at 9:01 PM Thilo Borgmann >>> wrote: >>> Am 05.08.19 um 21:00 schrieb Paul B Mahol: > On Mon, Aug 5, 2019 at 8:57 P

Re: [FFmpeg-devel] [PATCH] Extract QP from h264 encoded videos

2019-08-05 Thread Juan De León
On Sat, Aug 3, 2019 at 12:15 PM Michael Niedermayer wrote: > > +const char* av_get_qp_type_string(enum AVExtractQPSupportedCodecs > codec_id, int index) > > +{ > > +switch (codec_id) { > > +case AV_EXTRACT_QP_CODEC_ID_H264: > > +return index < AV_QP_ARR_SIZE_H264 ? QP_NAME

[FFmpeg-devel] [PATCH] Extract QP from h264 encoded videos

2019-08-05 Thread Juan De León
AVQuantizationParams data structure for extracting qp and storing as AV_FRAME_DATA_QUANTIZATION_PARAMS AVFrameSideDataType design doc: https://docs.google.com/document/d/1WClt3EqhjwdGXhEw386O0wfn3IBQ1Ib-_5emVM1gbnA/edit?usp=sharing Signed-off-by: Juan De León --- libavutil/Makefile

[FFmpeg-devel] [PATCH] configure: cuda_llvm: fix include path for MSYS2

2019-08-05 Thread Ricardo Constantino
MSYS2 converts paths to MinGW-based applications from unix to pseudo-windows paths on execution time. Since there was no space between '-include' and the path, MSYS2 doesn't detect the path properly. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/conf

Re: [FFmpeg-devel] [RFC] samples.ffmpeg.org

2019-08-05 Thread Michael Niedermayer
On Mon, Aug 05, 2019 at 09:09:36PM +0200, Thilo Borgmann wrote: > Am 05.08.19 um 21:02 schrieb Michael Niedermayer: > > On Mon, Aug 05, 2019 at 08:48:03PM +0200, Thilo Borgmann wrote: > >> Am 05.08.19 um 17:57 schrieb Paul B Mahol: > >>> On Mon, Aug 5, 2019 at 5:45 PM Michael Niedermayer > >>> >

Re: [FFmpeg-devel] [PATCH] configure: cuda_llvm: fix include path for MSYS2

2019-08-05 Thread Timo Rothenpieler
On 05.08.2019 21:47, Ricardo Constantino wrote: MSYS2 converts paths to MinGW-based applications from unix to pseudo-windows paths on execution time. Since there was no space between '-include' and the path, MSYS2 doesn't detect the path properly. --- configure | 2 +- 1 file changed, 1 insert

Re: [FFmpeg-devel] [PATCH] Extract QP from h264 encoded videos

2019-08-05 Thread Michael Niedermayer
On Mon, Aug 05, 2019 at 12:16:08PM -0700, Juan De León wrote: > On Sat, Aug 3, 2019 at 12:15 PM Michael Niedermayer > wrote: > > > > +const char* av_get_qp_type_string(enum AVExtractQPSupportedCodecs > > codec_id, int index) > > > +{ > > > +switch (codec_id) { > > > +case AV_EXTRACT_Q

Re: [FFmpeg-devel] [PATCH v3] avcodec/vaapi_encode_h264: add support for a/53 closed caption sei

2019-08-05 Thread Michael Niedermayer
On Mon, Aug 05, 2019 at 10:58:43AM -0700, Aman Gupta wrote: > From: Aman Gupta > > Signed-off-by: Aman Gupta > --- > libavcodec/vaapi_encode_h264.c | 30 +- > 1 file changed, 29 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/vaapi_encode_h264.c b/libavcode

Re: [FFmpeg-devel] [PATCH V2 2/2] lavf/showinfo: use error level when get invalid sidedata

2019-08-05 Thread Michael Niedermayer
On Mon, Aug 05, 2019 at 06:39:21PM +0800, Jun Zhao wrote: > From: Jun Zhao > > Use error level when get invalid sidedata, and remove a unnecessary > newline in error message. > > Signed-off-by: Jun Zhao > --- > libavfilter/vf_showinfo.c |6 +++--- > 1 files changed, 3 insertions(+), 3 dele

Re: [FFmpeg-devel] [PATCH] configure: cuda_llvm: fix include path for MSYS2

2019-08-05 Thread Ricardo Constantino
On Mon, 5 Aug 2019 at 20:57, Timo Rothenpieler wrote: > On 05.08.2019 21:47, Ricardo Constantino wrote: > > MSYS2 converts paths to MinGW-based applications from unix to > > pseudo-windows paths on execution time. > > Since there was no space between '-include' and the path, MSYS2 doesn't > > det

Re: [FFmpeg-devel] [PATCH] configure: cuda_llvm: fix include path for MSYS2

2019-08-05 Thread Ricardo Constantino
On Mon, 5 Aug 2019 at 21:46, Ricardo Constantino wrote: > > > On Mon, 5 Aug 2019 at 20:57, Timo Rothenpieler > wrote: > >> On 05.08.2019 21:47, Ricardo Constantino wrote: >> > MSYS2 converts paths to MinGW-based applications from unix to >> > pseudo-windows paths on execution time. >> > Since th

[FFmpeg-devel] [PATCH 1/3] avformat/avio: add avio_print_n_strings and avio_print

2019-08-05 Thread Marton Balint
These functions can be used to print a variable number of strings consecutively to the IO context. Unlike av_bprintf, no temporery buffer is necessary. Signed-off-by: Marton Balint --- doc/APIchanges| 3 +++ libavformat/avio.h| 16 libavformat/aviobuf.c | 17 +++

[FFmpeg-devel] [PATCH 3/3] avformat/avio: remove 4k limit from avio_printf

2019-08-05 Thread Marton Balint
We do this by switching to AVBPrint. Signed-off-by: Marton Balint --- doc/APIchanges| 3 +++ libavformat/avio.h| 5 - libavformat/aviobuf.c | 15 ++- libavformat/version.h | 2 +- 4 files changed, 18 insertions(+), 7 deletions(-) diff --git a/doc/APIchanges b/doc/

[FFmpeg-devel] [PATCH 2/3] avformat/assenc: optimize writing dialogs

2019-08-05 Thread Marton Balint
An example where the preivously added API can be useful. Also fixes ticket #6390. Signed-off-by: Marton Balint --- libavformat/assenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/assenc.c b/libavformat/assenc.c index d50f18feb1..12aadca171 100644 --- a/libav

Re: [FFmpeg-devel] FFmpeg 4.2

2019-08-05 Thread Michael Niedermayer
On Sun, Aug 04, 2019 at 07:56:00AM +0200, Michael Niedermayer wrote: > On Sun, Jul 21, 2019 at 07:11:40PM +0200, Michael Niedermayer wrote: > > On Mon, May 20, 2019 at 08:39:45PM +0200, Michael Niedermayer wrote: > > > Hi > > > > > > Its quite some time since 4.1 so its probably getting time to br

Re: [FFmpeg-devel] FFmpeg 4.2

2019-08-05 Thread Thomas Volkert
Hi, On 05.08.2019 23:49, Michael Niedermayer wrote: > 4.2 release made Thanks - shared on Facebook. Best regards, Thomas. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit li

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: fix PCR generation intervals

2019-08-05 Thread Marton Balint
On Mon, 5 Aug 2019, Andreas Håkon wrote: Hi Marton, ‐‐‐ Original Message ‐‐‐ On Sunday, 4 de August de 2019 22:30, Marton Balint wrote: PCR generation was based on counting packets for both CBR and VBR streams. Couting packets might have worked for CBR streams (when muxrate was sp

  1   2   >