Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: fix incorrect PCR with multiple programs

2019-07-27 Thread Andriy Gelman
Andreas, On Mon, 22. Jul 12:22, Andreas Håkon wrote: > Hi, > > Based on the discussion of my previous patch > https://patchwork.ffmpeg.org/patch/13487/ > Here I publish a first part of the patch that only addresses the PCR problem. Thanks for splitting the patch set. > > This supersedes too:

[FFmpeg-devel] [PATCH v1 2/2] avfilter/vf_scale: change filter_frame interface to activate interface

2019-07-27 Thread lance . lmwang
From: Limin Wang It's for the frame thread support later, once I have finished frame thread fate testing, I'll submit for review. Signed-off-by: Limin Wang --- libavfilter/vf_scale.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/liba

[FFmpeg-devel] [PATCH v1 1/2] avfilter/vf_scale: split the scale_frame function from filter_frame for activate function support

2019-07-27 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_scale.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index 7aebf56..efb480d 100644 --- a/libavfilter/vf_scale.c +++ b/libavfilter/v

[FFmpeg-devel] [PATCH] avcodec/cfhd: add bayer support

2019-07-27 Thread Paul B Mahol
Hi, patch attached. 0001-avcodec-cfhd-add-bayer-support.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ.

Re: [FFmpeg-devel] [PATCH] avfilter: add arnndn filter

2019-07-27 Thread Lynne
Jul 26, 2019, 4:37 PM by one...@gmail.com : > +static void biquad(float *y, float mem[2], const float *x, > +   const float *b, const float *a, int N) > +{ > +    for (int i = 0; i < N; i++) { > +    float xi, yi; > +    xi = x[i]; > +    yi = x[

Re: [FFmpeg-devel] [PATCH] avfilter: add square audio source filter

2019-07-27 Thread Nicolas George
Paul B Mahol (12019-07-26): > Nicolas, are you fine with this changes? Sorry, my mail server had trouble recently. On it. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org htt

Re: [FFmpeg-devel] [PATCH] avfilter: add arnndn filter

2019-07-27 Thread Paul B Mahol
On Sat, Jul 27, 2019 at 3:55 PM Lynne wrote: > Jul 26, 2019, 4:37 PM by one...@gmail.com : > > +static void biquad(float *y, float mem[2], const float *x, > > + const float *b, const float *a, int N) > > +{ > > +for (int i = 0; i < N; i++) { > > +

Re: [FFmpeg-devel] [PATCH] avfilter: add square audio source filter

2019-07-27 Thread Nicolas George
Paul B Mahol (12019-07-14): > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 44 > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/asrc_sine.c | 86 ++-- > 4 files changed, 119 insertions(+

[FFmpeg-devel] [PATCH] libavfilter/vf_drawtext: Avoid undefined behavior from GET_UTF8

2019-07-27 Thread Aaron Boushley
The vf_drawtext filter uses the GET_UTF8 macro in multiple locations. Each of these use `continue;` as the error handler. However the documentation for the GET_UTF8 macro states "ERROR should not contain a loop control statement which could interact with the internal while loop, and should force an

Re: [FFmpeg-devel] Fix for closed connection with http_persistent

2019-07-27 Thread Michael Niedermayer
On Fri, Jul 26, 2019 at 10:13:01PM +, Ian Klassen wrote: > Hi, > > Here is a potential fix for this bug: https://trac.ffmpeg.org/ticket/7975 > > Before reusing the connection the headers are checked to see if the server is > closing the connection. Also, the server may respond with "Connecti

[FFmpeg-devel] [PATCH] libavfilter/vf_drawtext: Avoid undefined behavior from GET_UTF8

2019-07-27 Thread Aaron Boushley
The vf_drawtext filter uses the GET_UTF8 macro in multiple locations. Each of these use `continue;` as the error handler. However the documentation for the GET_UTF8 macro states "ERROR should not contain a loop control statement which could interact with the internal while loop, and should force a

Re: [FFmpeg-devel] Fix for closed connection with http_persistent

2019-07-27 Thread Ian Klassen
Sorry, I manually changed the file... This one should work. On Sat, Jul 27, 2019 at 9:16 AM Michael Niedermayer wrote: On Fri, Jul 26, 2019 at 10:13:01PM +, Ian Klassen wrote: > Hi, > > Here is a potential fix for this bug: https://trac.ffmpeg.org/ticket/7975 > > Before reusing the connec

[FFmpeg-devel] [PATCH] avformat/movenc: don't ignore errors when writing codec specific boxes in a VisualSampleEntry

2019-07-27 Thread James Almer
Prevents muxing ultimately broken and spec non-compliant files. Signed-off-by: James Almer --- libavformat/movenc.c | 37 ++--- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index a96139077b..6ffaff6910

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: fix incorrect PCR with multiple programs

2019-07-27 Thread Andreas Håkon
Hi Andriy, I'm glad to read you! --- Original Message --- On Saturday, 27 de July de 2019 9:05, Andriy Gelman wrote: > > The MPEG-TS muxer has a serious bug related to the PCR pid selection. > > This bug appears when more than one program is used. The root cause is > > because > > the

[FFmpeg-devel] [PATCH] lavu/tx: add support for double precision FFT and MDCT

2019-07-27 Thread Lynne
Simply moves and templates the actual transforms to support an additional data type. Unlike the float version, which is equal or better than libfftw3f, double precision output is bit identical with libfftw3. >From 121dc2f176f2d03be10c11db33b956310eb1f5db Mon Sep 17 00:00:00 2001 From: Lynne Date:

Re: [FFmpeg-devel] Fix for closed connection with http_persistent

2019-07-27 Thread Moritz Barsnick
> +// read headers if not already loaded (this is needed to check if > connection is closing) > +if (!s->end_header) { > + int new_location; > + http_read_header(h, &new_location); > + > + if (s->willclose) { > +ret = ffurl_closep(&s->hd); > + > +if (ret < 0)

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: adjust for timecode lag

2019-07-27 Thread Marton Balint
On Fri, 26 Jul 2019, Gyan wrote: Patch supported by and tested at Google. Seems like a huge hack for a decklink issue... ;) I wonder if there are better approaches to work around this. Like dropping all frames until we have a valid signal. How is this repoducible? do you have an exact m

[FFmpeg-devel] libavformat/mpegtsenc: fix incorrect PCR with multiple programs [v2]

2019-07-27 Thread Andreas Håkon
Hi, This newversion fixes all the problems commented in https://patchwork.ffmpeg.org/patch/14036/ Now, it works with/without video streams. Regards. A.H. ---From c9b295c49828f31bba3879de887c7b2ed0e2641c Mon Sep 17 00:00:00 2001 From: Andreas Hakon Date: Sat, 27 Jul 2019 21:28:32 +0100 Subject:

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: fix incorrect PCR with multiple programs

2019-07-27 Thread Andreas Håkon
Hi Andriy, ‐‐‐ Original Message ‐‐‐ On Saturday, 27 de July de 2019 20:06, Andreas Håkon wrote: > > Thank you for your comments! I'll write more later. Stay tuned. > > Regards. > A.H. > Check the new version https://patchwork.ffmpeg.org/patch/14099/ Regards. A.H. --- ___

Re: [FFmpeg-devel] [PATCH] avcodec/mips: [loongson] refine process of setting block as 0 in h264dsp_mmi.

2019-07-27 Thread Reimar Döffinger
On 26.07.2019, at 10:25, Shiyou Yin wrote: > 1. Refine setting zero process in function ff_h264_add_pixels4_8_mmi and > ff_h264_idct_add_8_mmi. "refine" is rather unspecific. What was changed? How large is the improvement, any specific numbers? > 2. Remove redundant setting zeor Typo _

Re: [FFmpeg-devel] [PATCH v7 2/2] lavc/tiff: Decode embedded JPEGs in DNG images

2019-07-27 Thread Reimar Döffinger
On 26.07.2019, at 09:34, Nick Renieris wrote: > Στις Παρ, 26 Ιουλ 2019 στις 2:21 π.μ., ο/η Reimar Döffinger > έγραψε: >> >> On 25.07.2019, at 17:35, velocit...@gmail.com wrote: >> >>> +// Lookup table lookup >>> +if (lut) >>> +value = lut[value]; >> >> As this function is in t

[FFmpeg-devel] [PATCH 1/2] avcodec/lcldec: Optimize YUV422 case

2019-07-27 Thread Michael Niedermayer
This merges several byte operations and avoids some shifts inside the loop Improves: Timeout (330sec -> 134sec) Improves: 15599/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSZH_fuzzer-5658127116009472 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/proj

[FFmpeg-devel] [PATCH 2/2] avcodec/lcldec: Check mthread_inlen instead of cliping

2019-07-27 Thread Michael Niedermayer
Clipping was added in 2009 to avoid crashes. The clipped case would produce a 2nd slice with 0 input thus also producing 0 output. Subsequent checks will cause decoder failure unless both slices have the same output length. thus the only way this would not already fail is if the output from both sl

Re: [FFmpeg-devel] [PATCH v3] avutil/mips: Avoid instruction exception caused by gssqc1/gslqc1.

2019-07-27 Thread Reimar Döffinger
On 26.07.2019, at 07:18, Shiyou Yin wrote: > Ensure the address accesed by gssqc1/gslqc1 are 16-bits memory-aligned. Looks good to me if standard DECLARE_ALIGNED should work for stack on MIPS. (on x86 it used to be possible for the stack pointer to only be 8-byte aligned, in which case DECLARE_

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/lcldec: Optimize YUV422 case

2019-07-27 Thread Reimar Döffinger
On 28.07.2019, at 00:31, Michael Niedermayer wrote: > This merges several byte operations and avoids some shifts inside the loop > > Improves: Timeout (330sec -> 134sec) > Improves: > 15599/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSZH_fuzzer-5658127116009472 > > Found-by: continuou

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-27 Thread David Bryant
On 7/25/19 8:36 AM, Lynne wrote: > Jul 25, 2019, 6:12 AM by da...@wavpack.com: > +    crc += (crc << 1) + code; >>> Don't NIH CRCs, we have av_crc in lavu. See below how to use it. >>> >> It's not a standard crc, but more of a recirculating checksum, so the NIH >> code is required. >

Re: [FFmpeg-devel] [PATCH] avcodec/mips: [loongson] refine process of setting block as 0 in h264dsp_mmi.

2019-07-27 Thread Shiyou Yin
>-Original Message- >From: ffmpeg-devel-boun...@ffmpeg.org [mailto:ffmpeg-devel-boun...@ffmpeg.org] >On Behalf Of >Reimar D?ffinger >Sent: Sunday, July 28, 2019 6:06 AM >To: FFmpeg development discussions and patches >Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mips: [loongson] refine proc

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-27 Thread David Bryant
On 7/24/19 12:26 AM, Paul B Mahol wrote: > On 7/23/19, David Bryant wrote: >> On 7/23/19 12:47 AM, Paul B Mahol wrote: >>> On 7/23/19, David Bryant wrote: On 7/21/19 11:23 PM, Paul B Mahol wrote: > On 7/22/19, David Bryant wrote: >> Hi, >> >> As I promised late last year, he

[FFmpeg-devel] [PATCH v2] avcodec/mips: [loongson] refine process of setting block as 0 in h264dsp_mmi.

2019-07-27 Thread Shiyou Yin
In function ff_h264_add_pixels4_8_mmi, there is no need to reset '%[ftmp0]' to 0, because it's value has never changed since the start of the asm block. This patch remove the redundant 'xor' and set src to zero once it was loaded. In function ff_h264_idct_add_8_mmi, 'block' is seted to zero twice.

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: adjust for timecode lag

2019-07-27 Thread Gyan
On 28-07-2019 01:37 AM, Marton Balint wrote: On Fri, 26 Jul 2019, Gyan wrote: Patch supported by and tested at Google. Seems like a huge hack for a decklink issue... ;) I wonder if there are better approaches to work around this. Like dropping all frames until we have a valid signal.