Re: [FFmpeg-devel] [PATCH v4] vaapi_encode_mjpeg: fix bad component id bug

2019-06-13 Thread Dominik 'Rathann' Mierzejewski
On Friday, 07 June 2019 at 23:45, U. Artie Eoff wrote: > The compound literals assigned to "components" > only exist within the scope of the if/else > block (thanks Mark Thompson for the better > explanation). > > Thus, after this if/else block, "components" > ends up pointing to an arbitrary/unde

Re: [FFmpeg-devel] [PATCH v4] vaapi_encode_mjpeg: fix bad component id bug

2019-06-13 Thread Andreas Rheinhardt
Dominik 'Rathann' Mierzejewski: > On Friday, 07 June 2019 at 23:45, U. Artie Eoff wrote: >> The compound literals assigned to "components" >> only exist within the scope of the if/else >> block (thanks Mark Thompson for the better >> explanation). >> >> Thus, after this if/else block, "components"

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/mediacodecdec: try to receive a frame after signaling EOF to the codec

2019-06-13 Thread Matthieu Bouron
On Sun, May 26, 2019 at 11:25:09AM +0200, Matthieu Bouron wrote: > On Tue, May 07, 2019 at 02:09:02AM -0700, Aman Gupta wrote: > > On Thu, May 2, 2019 at 1:20 AM Matthieu Bouron > > wrote: > > > > > On Wed, Apr 24, 2019 at 09:59:28AM +0200, Matthieu Bouron wrote: > > > > Avoids returning EAGAIN a

[FFmpeg-devel] [PATCH v2] libavfilter: Add derain filter changeLog

2019-06-13 Thread Xuewei Meng
Signed-off-by: Xuewei Meng --- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index 0e4e9eb7b9..086f36b966 100644 --- a/Changelog +++ b/Changelog @@ -32,6 +32,7 @@ version : - asr filter - showspatial multimedia filter - VP4 video decoder +- derain filter

[FFmpeg-devel] [PATCH] tools/target_dem_fuzzer: ignore avformat_find_stream_info() failure

2019-06-13 Thread Michael Niedermayer
Such a failure should not be fatal and its worth testing this path too Signed-off-by: Michael Niedermayer --- tools/target_dem_fuzzer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/target_dem_fuzzer.c b/tools/target_dem_fuzzer.c index b51c766878..409599636d 100644 --- a/tools/targe

Re: [FFmpeg-devel] [PATCH 3/4] avformat/wtvdec: Avoid (32bit signed) sectors

2019-06-13 Thread Peter Ross
On Thu, Jun 13, 2019 at 01:20:19AM +0200, Michael Niedermayer wrote: > Fixes: left shift of negative value -14614752 > Fixes: > 15174/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5670543606415360 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/pr

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: new interlaced mux mode

2019-06-13 Thread Andreas Håkon
Hi Andriy, I'm glad you're interested in this patch. > > This patch implements a new optional "parallel muxing mode" in the MPEGTS > > muxer. > > The strategy that implements the current mux (selected by default) is based > > on > > writing full PES packages sequentially. This mode can be pro

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/fitsdec: Check data_min/max

2019-06-13 Thread Moritz Barsnick
On Thu, Jun 13, 2019 at 01:20:20 +0200, Michael Niedermayer wrote: > +if (header->data_min == header->data_max) { Just a note: Equality comparison of floats/doubles may trigger a warning. (Possibly needs to be explicitly enabled though, like with "-Wfloat-equal" on gcc.) Might be okay thou

Re: [FFmpeg-devel] [PATCH v4] vaapi_encode_mjpeg: fix bad component id bug

2019-06-13 Thread Eoff, Ullysses A
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Andreas Rheinhardt > Sent: Thursday, June 13, 2019 2:11 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v4] vaapi_encode_mjpeg: fix bad component > id bug > > Dominik '

[FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-13 Thread Amir Pauker
set AVFrame decode_error_flags in case h->slice_ctx->er.error_occurred is set after the call to ff_h264_execute_decode_slices. This allows the user to detect concealed decoding errors in the call to avcodec_receive_frame Signed-off-by: Amir Pauker --- doc/APIchanges | 3 +++ libavcodec/h26

[FFmpeg-devel] [PATCH 3/4] avcodec/fitsdec: Fix division be 0 in size check

2019-06-13 Thread Michael Niedermayer
Fixes: division by zero Fixes: 15210/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FITS_fuzzer-5746033243455488 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/fitsdec.c | 2 +- 1 file cha

[FFmpeg-devel] [PATCH 1/4] avcodec/aacpsdsp_template: Fix integer overflow in ps_hybrid_analysis_c()

2019-06-13 Thread Michael Niedermayer
Fixes: signed integer overflow: -1539565182 + -798086761 cannot be represented in type 'int' Fixes: 14807/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-564925382682214 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed

Re: [FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: Also fuzz extradata

2019-06-13 Thread Michael Niedermayer
On Fri, Jun 07, 2019 at 04:39:58PM +0200, Michael Niedermayer wrote: > This should improve coverage > > Signed-off-by: Michael Niedermayer > --- > tools/target_dec_fuzzer.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) will apply [...] -- Michael GnuPG fingerpri

[FFmpeg-devel] [PATCH 4/4] avcodec/truemotion2: Fix integer overflow in last loop in tm2_update_block()

2019-06-13 Thread Michael Niedermayer
Fixes: signed integer overflow: -1727985666 - 538976288 cannot be represented in type 'int' Fixes: 15031/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-5100228035739648 Signed-off-by: Michael Niedermayer --- libavcodec/truemotion2.c | 2 +- 1 file changed, 1 insertion(+),

[FFmpeg-devel] [PATCH 2/4] avcodec/hevc_ps: Fix integer overflow with num_tile_rows

2019-06-13 Thread Michael Niedermayer
Fixes: signed integer overflow: -2147483648 - 1 cannot be represented in type 'int' Fixes: 14880/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5130977304641536 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mich

Re: [FFmpeg-devel] [PATCH 1/3] avformat/vpk: Fix integer overflow in samples_per_block computation

2019-06-13 Thread Michael Niedermayer
On Thu, Jun 06, 2019 at 11:50:57PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 84026453 * 28 cannot be represented in type > 'int' > Fixes: > 15111/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5675630072430592 > > Found-by: continuous fuzzing process > https://gi

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/bitstream: Check for integer code truncation in build_table()

2019-06-13 Thread Michael Niedermayer
On Wed, Jun 05, 2019 at 12:55:16PM +0200, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: > 14563/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AGM_fuzzer-5646451545210880 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH 3/4] avformat/wtvdec: Avoid (32bit signed) sectors

2019-06-13 Thread Michael Niedermayer
On Thu, Jun 13, 2019 at 10:27:00PM +1000, Peter Ross wrote: > On Thu, Jun 13, 2019 at 01:20:19AM +0200, Michael Niedermayer wrote: > > Fixes: left shift of negative value -14614752 > > Fixes: > > 15174/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5670543606415360 > > > > Found-by: continu

[FFmpeg-devel] [PATCH] avformat/oggparseogm: unknown codec triggers error

2019-06-13 Thread Chris Cunningham
Only "succeed" to read a header if the codec is valid. Otherwise return AVERROR_INVALIDDATA. --- libavformat/oggparseogm.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libavformat/oggparseogm.c b/libavformat/oggparseogm.c index a07453760b..e71298d39a 100644 ---

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: unknown codec triggers error

2019-06-13 Thread Chris Cunningham
+James This is patch is a follow up from an earlier thread: https://patchwork.ffmpeg.org/patch/11983/ I've implemented the easy part of that proposal. We also discussed disallowing multiple headers in an ogm change (generally a revert of: https://github.com/FFmpeg/FFmpeg/commit/81b743eb102654727

[FFmpeg-devel] [PATCH V1 2/2] lavf/dashdec: Save and forward more avio options same as HLS demuxer

2019-06-13 Thread Jun Zhao
From: Jun Zhao Save and forward more avio options same as HLS demuxer Signed-off-by: Jun Zhao --- libavformat/dashdec.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 2c50f23..446825d 100644 --- a/libavformat/dash

[FFmpeg-devel] [PATCH V1 1/2] lavf/hls: More log message

2019-06-13 Thread Jun Zhao
From: Jun Zhao More log message, it's will help the debugging Signed-off-by: Jun Zhao --- libavformat/hls.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index b5df9ae..3b1d4fe 100644 --- a/libavformat/hls.c +++ b/libavformat

Re: [FFmpeg-devel] [PATCH V1 2/2] lavf/dashdec: Save and forward more avio options same as HLS demuxer

2019-06-13 Thread Liu Steven
https://patchwork.ffmpeg.org/patch/13388/ reference this patch. > 在 2019年6月14日,上午9:35,Jun Zhao 写道: > > From: Jun Zhao > > Save and forward more avio options same as HLS demuxer > > Signed-off-by: Jun Zhao > --- > libavformat/dashdec.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletio

Re: [FFmpeg-devel] [PATCH V1 1/2] lavf/hls: More log message

2019-06-13 Thread Liu Steven
> 在 2019年6月14日,上午9:35,Jun Zhao 写道: > > From: Jun Zhao > > More log message, it's will help the debugging > > Signed-off-by: Jun Zhao > --- > libavformat/hls.c |5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index b5df

Re: [FFmpeg-devel] [PATCH, v3] lavf/qsvvpp:allocate continuous memory

2019-06-13 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Linjie Fu > Sent: Tuesday, June 4, 2019 11:59 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie > Subject: [FFmpeg-devel] [PATCH,v3] lavf/qsvvpp:allocate continuous > memory > > Mediasdk calls CMRT to copy from video to

Re: [FFmpeg-devel] [PATCH, v3] lavf/qsvvpp:allocate continuous memory

2019-06-13 Thread Fu, Linjie
> -Original Message- > From: Li, Zhong > Sent: Friday, June 14, 2019 11:34 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Fu, Linjie > Subject: RE: [FFmpeg-devel] [PATCH,v3] lavf/qsvvpp:allocate continuous > memory > > > From: ffmpeg-devel [mailto:ffmpeg-devel-b